[PATCH v2 2/2] .mailmap: Map all Xilinx users mail ids to AMD

2023-04-25 Thread Ashok Reddy Soma
From: Algapally Santosh Sagar The mail ids of all the current Xilinx users are to be mapped to AMD following the merger with AMD. The mailmap file is updated accordingly. The ids of Marek Behún and Michal Simek are taken as reference. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok

[PATCH v2 1/2] .mailmap: Sort the mailmap ids in dictionary order

2023-04-25 Thread Ashok Reddy Soma
From: Algapally Santosh Sagar The mailmap ids are not arranged in the dictionary order. So, sort the mailmap ids in the dictionary order. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma --- (no changes since v1) .mailmap | 28 ++-- 1 file chang

[PATCH v2 0/2] Update mailmap ids

2023-04-25 Thread Ashok Reddy Soma
In this patch series - Sort mailmap ids according to dictionary order - Update all Xilinx users mail ids to AMD Changes in v2: - Updated the missing mailids - Removed the space after mail id - Added closing brace for Vikhyat Goyal email id Algapally Santosh Sagar (2): .mailmap: Sort the

[PATCH 3/5] arm: dts: rockchip: add Radxa ROCK 4C+

2023-04-25 Thread FUKAUMI Naoki
Linux commit 246450344dad arm64: dts: rockchip: rk3399: Radxa ROCK 4C+ Add support for Radxa ROCK 4C+ SBC. Key differences of 4C+ compared to previous ROCK Pi 4. - Rockchip RK3399-T SoC - DP from 4C replaced with micro HDMI 2K@60fps - 4-lane MIPI DSI with 1920*1080 - RK817 Audio codec Also, an o

[PATCH 1/5] arm: dts: rockchip: rock-pi-4: sync with Linux 6.3

2023-04-25 Thread FUKAUMI Naoki
sync dts{,i} files for Radxa ROCK Pi 4 series with Linux 6.3. because rk3399-rock-pi-4a.dts is enough for ROCK Pi 4A/B/A+/B+ and ROCK 4SE, delete dts{,i} for ROCK Pi 4B. Signed-off-by: FUKAUMI Naoki --- arch/arm/dts/Makefile | 1 - arch/arm/dts/rk3399-rock-pi-4.dtsi

[PATCH 4/5] configs: rockchip: add Radxa ROCK 4C+

2023-04-25 Thread FUKAUMI Naoki
add defconfig for Radxa ROCK 4C+. Signed-off-by: FUKAUMI Naoki --- configs/rock-4c-plus-rk3399_defconfig | 97 +++ 1 file changed, 97 insertions(+) create mode 100644 configs/rock-4c-plus-rk3399_defconfig diff --git a/configs/rock-4c-plus-rk3399_defconfig b/configs/roc

[PATCH 2/5] configs: rockchip: rock-pi-4: use dtb for ROCK Pi 4A instead of 4B

2023-04-25 Thread FUKAUMI Naoki
rk3399-rock-pi-4a.dtb is enough for Radxa ROCK Pi 4A/B/A+/B+ and ROCK 4SE. Signed-off-by: FUKAUMI Naoki --- configs/rock-pi-4-rk3399_defconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configs/rock-pi-4-rk3399_defconfig b/configs/rock-pi-4-rk3399_defconfig index 4e

[PATCH 5/5] doc: rockchip: update list of Radxa ROCK (Pi) 4 boards

2023-04-25 Thread FUKAUMI Naoki
add Radxa ROCK (Pi) 4 variants. Signed-off-by: FUKAUMI Naoki --- doc/board/rockchip/rockchip.rst | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/board/rockchip/rockchip.rst b/doc/board/rockchip/rockchip.rst index 1dccb17d72..749e40de01 100644 --- a/doc/board/rockchip/

Re: [PATCH V2 01/53] spl: imx8mm: enlarge SPL_MAX_SIZE

2023-04-25 Thread Peng Fan
On 4/20/2023 2:57 PM, Frieder Schrempf wrote: Hi, On 26.07.22 10:40, Peng Fan (OSS) wrote: From: Peng Fan The CONFIG_SPL_MAX_SIZE could be 0x27000 for i.MX8MM when SPL_TEXT_BASE set to 0x7E1000. The DDR firmware max uses 96KB, there is a 4KB padding header before SPL_TEXT_BASE, so the SPL

Re: [PATCH] imx: fix get_boot_device() for imx8

2023-04-25 Thread Peng Fan
On 4/25/2023 12:33 AM, Tim Harvey wrote: commit 787f04bb6a0a ("imx: add USB2_BOOT type") broke get_boot_device() for IMX8 which affects booting from SDP due to boot_instance being non-zero. Fix this by only using boot_instance for imx8ulp and imx9. Fixes: 787f04bb6a0a ("imx: add USB2_BOOT ty

Re: [PATCH] arm: imx8m: remove unused and obsolete board_fix_fdt() in SOC context

2023-04-25 Thread Peng Fan
On 4/25/2023 10:19 PM, Hugo Villeneuve wrote: From: Hugo Villeneuve It doesn't seem appropriate for arch/SOC to use a board-level functionality (CONFIG_OF_BOARD_FIXUP), because this prevents boards that need to do FDT fixup from using that feature. Also, this code is completely dead and use

Re: [PATCH v3] console: usb: kbd: Limit poll frequency to improve performance

2023-04-25 Thread Simon Glass
Hi Filip, On Tue, 25 Apr 2023 at 06:36, Filip Žaludek wrote: > > > > Hi Simon, > > > On 4/19/23 03:49, Simon Glass wrote: > > Hi Filip, > > > > On Tue, 11 Apr 2023 at 14:24, Filip Žaludek > > wrote: > >> > >> > >> > >> On 2/8/23 20:01, Mark Kettenis wrote: > Date: Wed, 8 Feb 2023 19:45:36

Re: [PATCH v2] common/Kconfig: fix comments syntax error

2023-04-25 Thread Simon Glass
On Tue, 25 Apr 2023 at 12:34, Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > Fix comments error in EVENT_DEBUG description: > this get usefui -> this to get useful > > Signed-off-by: Hugo Villeneuve > --- > common/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Review

Re: [PATCH 27/31] Makefile: Disable LTO when building with MSYS2

2023-04-25 Thread Simon Glass
Hi Pali, On Tue, 25 Apr 2023 at 10:28, Pali Rohár wrote: > > On Monday 24 April 2023 17:08:32 Simon Glass wrote: > > This creates a lot of errors of the form: > > > > `__stack_chk_fail' referenced in section `.text' of ...ltrans.o: defined > >in discarded section `.text' of common/stackprot.o

Re: distro_boot vs. env-based bootmenu

2023-04-25 Thread Simon Glass
+Heinrich Schuchardt +Ilias Apalodimas in case they have ideas on this On Mon, 24 Apr 2023 at 15:22, Frank Wunderlich wrote: > > Am 24. April 2023 21:44:25 MESZ schrieb Simon Glass : > >Hi Frank, > > > >On Fri, 21 Apr 2023 at 10:03, Frank Wunderlich > >wrote: > >> > >> Maybe you have an idea be

Re: [PATCH 10/31] sandbox: Provide a linker script for MSYS2

2023-04-25 Thread Simon Glass
Hi Pali, On Tue, 25 Apr 2023 at 13:33, Pali Rohár wrote: > > On Tuesday 25 April 2023 13:23:04 Simon Glass wrote: > > Hi Pali, > > > > On Tue, 25 Apr 2023 at 12:11, Pali Rohár wrote: > > > > > > On Tuesday 25 April 2023 12:01:04 Simon Glass wrote: > > > > Hi Pali, > > > > > > > > On Tue, 25 Apr

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-04-25 Thread Tom Rini
On Tue, Apr 25, 2023 at 10:02:01PM +0200, Rasmus Villemoes wrote: > On 25/04/2023 21.31, Tom Rini wrote: > > On Fri, Mar 17, 2023 at 11:26:39AM +0100, Rasmus Villemoes wrote: > > > > >> Now, the only way to be really sure is to build the world > >> with/without this patch and check if any .dtb fi

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-04-25 Thread Rasmus Villemoes
On 25/04/2023 21.31, Tom Rini wrote: > On Fri, Mar 17, 2023 at 11:26:39AM +0100, Rasmus Villemoes wrote: > >> Now, the only way to be really sure is to build the world >> with/without this patch and check if any .dtb file changes, but I >> don't have the means to do that. > > So, yes, this cause

Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant

2023-04-25 Thread Eugen Hristev
On 4/25/23 22:22, Ramon Fried wrote: On Tue, Apr 25, 2023 at 4:17 PM Eugen Hristev wrote: On 4/25/23 16:06, Eugen Hristev wrote: Add minimal support for 8125B version. Changes are based on the Linux driver. Tested on Radxa Rock 5B Rk3588 board. Connection to a laptop worked fine in 100 Mbps

Re: [PATCH 10/31] sandbox: Provide a linker script for MSYS2

2023-04-25 Thread Pali Rohár
On Tuesday 25 April 2023 13:23:04 Simon Glass wrote: > Hi Pali, > > On Tue, 25 Apr 2023 at 12:11, Pali Rohár wrote: > > > > On Tuesday 25 April 2023 12:01:04 Simon Glass wrote: > > > Hi Pali, > > > > > > On Tue, 25 Apr 2023 at 10:21, Pali Rohár wrote: > > > > > > > > On Monday 24 April 2023 17:0

Re: [PATCH] scripts/Makefile.lib: also consider $(CONFIG_SYS_BOARD)-u-boot.dtsi

2023-04-25 Thread Tom Rini
On Fri, Mar 17, 2023 at 11:26:39AM +0100, Rasmus Villemoes wrote: > I have a couple of boards, e.g. foo21, bar33, each with a few > different revisions, so I have > > foo21-revA.dts > foo21-revB.dts > bar33-revA.dts > bar33-revB.dts > > Now the necessary U-Boot specific additions for the

[PATCH] arm: dts: iot2050: Include u-boot specific bits implicitly

2023-04-25 Thread Jan Kiszka
From: Jan Kiszka Create *-u-boot.dtsi files for each target dtb of the IOT2050 series so that we can drop the #include deviations from upstream dts[i] files here. Signed-off-by: Jan Kiszka --- This was tested against most of our boards with the DTS synced from kernel 6.3. arch/arm/dts/k3-am

Re: [PATCH 10/31] sandbox: Provide a linker script for MSYS2

2023-04-25 Thread Simon Glass
Hi Pali, On Tue, 25 Apr 2023 at 12:11, Pali Rohár wrote: > > On Tuesday 25 April 2023 12:01:04 Simon Glass wrote: > > Hi Pali, > > > > On Tue, 25 Apr 2023 at 10:21, Pali Rohár wrote: > > > > > > On Monday 24 April 2023 17:08:15 Simon Glass wrote: > > > > Add a script to allow the U-Boot sandbox

Re: [PATCH v3 11/19] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img

2023-04-25 Thread Simon Glass
Hi Neha, On Tue, 25 Apr 2023 at 01:32, Neha Malcom Francis wrote: > > Hi Simon > > On 25/04/23 01:12, Simon Glass wrote: > > Hi Neha, > > > > On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: > >> > >> Support added for HS and GP boot binaries for AM64x. > >> > >> tiboot3.bin, tispl.bin a

Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant

2023-04-25 Thread Ramon Fried
On Tue, Apr 25, 2023 at 4:17 PM Eugen Hristev wrote: > > On 4/25/23 16:06, Eugen Hristev wrote: > > Add minimal support for 8125B version. > > Changes are based on the Linux driver. > > Tested on Radxa Rock 5B Rk3588 board. > > > > Connection to a laptop worked fine in 100 Mbps mode. > > 1000 Mbps

Re: [PATCH 2/2] net: phy: Make phy_interface_is_rgmii a switch statement

2023-04-25 Thread Ramon Fried
On Thu, Apr 13, 2023 at 9:07 PM Nishanth Menon wrote: > > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This exposed a problem in > range checking functions to identify the interface type. Though this > specific api was'nt imp

Re: [PATCH v3 3/3] net: dhcp6: Add a sandbox test for dhcp6

2023-04-25 Thread Ramon Fried
On Tue, Apr 11, 2023 at 8:48 PM wrote: > > From: Sean Edmond > > Requires proper environment with DHCP6 server provisioned. > > Signed-off-by: Sean Edmond > --- > configs/sandbox_defconfig | 1 + > test/py/tests/test_net.py | 25 + > 2 files changed, 26 insertions(+) >

Re: [PATCH v3 1/3] net: dhcp6: Add DHCPv6 (DHCP for IPv6)

2023-04-25 Thread Ramon Fried
On Tue, Apr 11, 2023 at 8:48 PM wrote: > > From: Sean Edmond > > Adds DHCPv6 protocol to u-boot. > > Allows for address assignement with DHCPv6 4-message exchange > (SOLICIT->ADVERTISE->REQUEST->REPLY). Includes DHCPv6 options > required by RFC 8415. Also adds DHCPv6 options required > for PXE

Re: [PATCH v3 2/3] net: dhcp6: pxe: Add DHCP/PXE commands for IPv6

2023-04-25 Thread Ramon Fried
On Tue, Apr 11, 2023 at 8:48 PM wrote: > > From: Sean Edmond > > Adds commands to support DHCP and PXE with IPv6. > > New configs added: > - CMD_DHCP6 > - DHCP6_PXE_CLIENTARCH > - DHCP6_PXE_DHCP_OPTION > - DHCP6_ENTERPRISE_ID > > New commands added (when IPv6 is enabled): > - dhcp6 > - pxe get -i

Re: [PATCH v2 3/3] net: dhcp6: Add a sandbox test for dhcp6

2023-04-25 Thread Ramon Fried
On Fri, Apr 7, 2023 at 9:55 PM Simon Glass wrote: > > On Fri, 7 Apr 2023 at 18:56, wrote: > > > > From: Sean Edmond > > > > Requires proper environment with DHCP6 server provisioned. > > > > Signed-off-by: Sean Edmond > > --- > > configs/sandbox_defconfig | 1 + > > test/py/tests/test_net.py

Re: [PATCH v2 1/3] net: dhcp6: Add DHCPv6 (DHCP for IPv6)

2023-04-25 Thread Ramon Fried
On Fri, Apr 7, 2023 at 9:55 PM Simon Glass wrote: > > Hi, > > On Fri, 7 Apr 2023 at 18:56, wrote: > > > > From: Sean Edmond > > > > Adds DHCPv6 protocol to u-boot. > > > > Allows for address assignement with DHCPv6 4-message exchange > > (SOLICIT->ADVERTISE->REQUEST->REPLY). Includes DHCPv6 opt

Re: [PATCH v3 11/19] am64x: dts: binman: Package tiboot3.bin, tispl.bin u-boot.img

2023-04-25 Thread Andrew Davis
On 4/25/23 2:31 AM, Neha Malcom Francis wrote: Hi Simon On 25/04/23 01:12, Simon Glass wrote: Hi Neha, On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: Support added for HS and GP boot binaries for AM64x. tiboot3.bin, tispl.bin and u-boot.img: For HS-SE devices tiboot3.bin_fs, tisp

Re: [PATCH 00/31] Allow building sandbox with MSYS2

2023-04-25 Thread Simon Glass
Hi Tom, On Tue, 25 Apr 2023 at 10:04, Tom Rini wrote: > > On Tue, Apr 25, 2023 at 04:59:53AM +0200, Heinrich Schuchardt wrote: > > > > > > Am 25. April 2023 01:08:05 MESZ schrieb Simon Glass : > > >This expands the existing work to allow sandbox to build and run on > > >Windows using MSYS2. > > >

[PATCH v2] common/Kconfig: fix comments syntax error

2023-04-25 Thread Hugo Villeneuve
From: Hugo Villeneuve Fix comments error in EVENT_DEBUG description: this get usefui -> this to get useful Signed-off-by: Hugo Villeneuve --- common/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/Kconfig b/common/Kconfig index f2783ee65d..0d69e83a33 1006

Re: [PATCH] common/Kconfig: fix comments syntax error

2023-04-25 Thread Hugo Villeneuve
On Tue, 25 Apr 2023 12:00:58 -0600 Simon Glass wrote: > Hi Hugo, > > On Tue, 25 Apr 2023 at 07:46, Hugo Villeneuve wrote: > > > > From: Hugo Villeneuve > > > > Fix comments error in EVENT_DEBUG description: > > usefui -> useful > > > > Signed-off-by: Hugo Villeneuve > > --- > > common/Kc

Re: [PATCH 0/6] virtio: Use bounce buffers when VIRTIO_F_IOMMU_PLATFORM set

2023-04-25 Thread Tom Rini
On Wed, 29 Mar 2023 22:24:54 +0800, Ying-Chun Liu (PaulLiu) wrote: > These patches will use bounce buffers when VIRTIO_F_IOMMU_PLATFORM feature > is in a virtio device. > > This feature can be tested with qemu with -device virtio-iommu-pci. > So that when a -device virtio-blk-pci with iommu_platf

Re: [PATCH 10/31] sandbox: Provide a linker script for MSYS2

2023-04-25 Thread Pali Rohár
On Tuesday 25 April 2023 12:01:04 Simon Glass wrote: > Hi Pali, > > On Tue, 25 Apr 2023 at 10:21, Pali Rohár wrote: > > > > On Monday 24 April 2023 17:08:15 Simon Glass wrote: > > > Add a script to allow the U-Boot sandbox executable to be built for > > > Windows. Add a note as to why this seems

Re: [PATCH] common/Kconfig: fix comments syntax error

2023-04-25 Thread Simon Glass
Hi Hugo, On Tue, 25 Apr 2023 at 07:46, Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > Fix comments error in EVENT_DEBUG description: > usefui -> useful > > Signed-off-by: Hugo Villeneuve > --- > common/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/c

Re: [PATCH v3 01/19] binman: ti-board-config: Add support for TI board config binaries

2023-04-25 Thread Simon Glass
Hi Neha, On Tue, 25 Apr 2023 at 00:24, Neha Malcom Francis wrote: > > Hi Simon > > On 25/04/23 01:12, Simon Glass wrote: > > Hi Neha, > > > > On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: > >> > >> The ti-board-config entry loads and validates a given YAML config file > >> against a g

Re: [PATCH v3 1/2] serial: zynqmp: Fetch baudrate from dtb and update

2023-04-25 Thread Simon Glass
Hi Venkatesh, On Tue, 25 Apr 2023 at 06:05, Venkatesh Yadav Abbarapu wrote: > > From: Algapally Santosh Sagar > > The baudrate configured in .config is taken by default by serial. If > change of baudrate is required then the .config needs to changed and > u-boot recompilation is required or the

Re: [PATCH v3 09/19] am65: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img

2023-04-25 Thread Simon Glass
Hi Neha, On Tue, 25 Apr 2023 at 01:26, Neha Malcom Francis wrote: > > Hi Simon, > > On 25/04/23 01:12, Simon Glass wrote: > > Hi Neha, > > > > On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: > >> > >> Support added for HS and GP boot binaries for AM65x. > >> > >> tiboot3.bin, sysfw.itb,

Re: [PATCH 10/31] sandbox: Provide a linker script for MSYS2

2023-04-25 Thread Simon Glass
Hi Pali, On Tue, 25 Apr 2023 at 10:21, Pali Rohár wrote: > > On Monday 24 April 2023 17:08:15 Simon Glass wrote: > > Add a script to allow the U-Boot sandbox executable to be built for > > Windows. Add a note as to why this seems to be necessary for now. > > > > Signed-off-by: Simon Glass > > --

Re: [PATCH v2] cosmetic:fix typo in 'mmc write' example

2023-04-25 Thread Simon Glass
Hi Alexander, On Tue, 25 Apr 2023 at 04:00, Alexander Shirokov wrote: > > In the 'mmc write' command example, it writes 16 blocks (0x10). But the > output contains 256 (0x100) blocks. This patch fixes the mismatch. > > Signed-off-by: Alexander Shirokov > --- > doc/usage/cmd/mmc.rst | 2 +- > 1

Re: [PATCH v3 6/6] video: panel: add generic endeavoru panel

2023-04-25 Thread Simon Glass
On Tue, 25 Apr 2023 at 01:52, Svyatoslav Ryhel wrote: > > Family of panels used by HTC in One X. Though were used variants > at least from 3 vendors, this driver provides generic support for > all of them. > > Tested-by: Ion Agorria # HTC One X T30 Sony > Tested-by: Svyatoslav Ryhel # HTC One X

Re: [PATCH] event: fix comments syntax error

2023-04-25 Thread Simon Glass
On Tue, 25 Apr 2023 at 07:47, Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > Fix comments syntax error in event description: > creasted -> created > > Signed-off-by: Hugo Villeneuve > --- > doc/develop/event.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [PATCH] mtd: spi-nor-core: Add fixups for s25fs512s

2023-04-25 Thread Jagan Teki
On Sun, Apr 23, 2023 at 5:26 AM Marek Vasut wrote: > > From: Takahiro Kuwano > > This patch adds fixups for s25fs512s to address the following issues > from reading SFDP: > > - Non-uniform sectors by factory default. The setting needs to be > checked and assign erase hook as needed. > - P

Re: [PATCH v2] cmd: sf/nand: Print and return failure when 0 length is passed

2023-04-25 Thread Jagan Teki
On Wed, Apr 12, 2023 at 1:22 PM Ashok Reddy Soma wrote: > > For sf commands, when '0' length is passed for erase, update, write or > read, there might be undesired results. Ideally '0' length means nothing to > do. > > So print 'ERROR: Invalid size 0' and return cmd failure when length '0' is > pa

Re: [PATCH] spi: synquacer: Silence unused variable warnings

2023-04-25 Thread Jagan Teki
On Fri, Apr 7, 2023 at 2:43 PM Ilias Apalodimas wrote: > > When building with clang, the compiler compains with > > drivers/spi/spi-synquacer.c:212:11: warning: variable 'bus_width' is used > uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > else if (priv->mode

Re: [PATCH 1/1] mtd: spi-nor: missing fallthrough in set_4byte()

2023-04-25 Thread Jagan Teki
On Sat, Apr 1, 2023 at 1:04 PM Heinrich Schuchardt wrote: > > Add a missing fallthrough macro to avoid a -Wimplicit-fallthrough warning. > > Signed-off-by: Heinrich Schuchardt > --- Applied to u-boot-spi/master

Re: [PATCH v1] spi: npcm-fiu: add regulator feature and remove set clock

2023-04-25 Thread Jagan Teki
On Tue, Mar 7, 2023 at 1:40 PM Jim Liu wrote: > > NPCM7xx/NPCM8xx default is boot from flash. > removed set clock feature due to reliability and security. > the clock will set by bootblock or tip. > > Signed-off-by: Jim Liu > --- Reviewed-by: Jagan Teki Applied to u-boot-spi/master

Re: [PATCH] spi: f-ospi: Add missing spi_mem_default_supports_op() helper

2023-04-25 Thread Jagan Teki
On Mon, Mar 27, 2023 at 11:05 AM Kunihiko Hayashi wrote: > > The .supports_op() callback function returns true by default after > performing driver-specific checks. Therefore the driver cannot apply > the buswidth in devicetree. > > Call spi_mem_default_supports_op() helper to handle the buswidth

Re: [PATCH] mtd: spi-nor: Add CHIP_ERASE optimization

2023-04-25 Thread Jagan Teki
On Thu, Mar 2, 2023 at 7:16 AM Marek Vasut wrote: > > Add support for CHIP_ERASE opcode 0xc7 . This is useful in case the > entire SPI NOR is supposed to be erase at once, as is it considerably > faster than 4k sector erase and even slightly faster than 64k block > erase. The spi_nor_erase_chip()

Re: [PATCH] environment: ti: Add get_fit_config command to get FIT config string

2023-04-25 Thread Tom Rini
On Tue, Apr 25, 2023 at 11:20:45AM -0500, Andrew Davis wrote: > When OE is packaging a dtb file into the FIT image it names the node based > on the dtb filename. Node names can't have "/" so it is turned into "_". > We select our FIT config using the "fdtfile" env var so we don't duplicate > the b

Re: [PATCH v2 2/2] ARM: dts: stm32mp: alignment with v6.3

2023-04-25 Thread Marek Vasut
On 4/24/23 16:21, Patrick Delaunay wrote: Device tree alignment with Linux kernel v6.3: - f5a058023239 - ARM: dts: stm32: add i2c nodes into stm32mp131.dtsi - 8539ebb435a5 - ARM: dts: stm32: enable i2c1 and i2c5 on stm32mp135f-dk.dts - 8539ebb435a5 - ARM: dts: stm32: add spi nodes into stm32mp

[PATCH v2 30/30] ide: Make use of U-Boot types

2023-04-25 Thread Simon Glass
Use standard U-Boot types in the file to make the code less verbose. Signed-off-by: Simon Glass --- Changes in v2: - Rebase to master drivers/block/ide.c | 79 + 1 file changed, 37 insertions(+), 42 deletions(-) diff --git a/drivers/block/ide.c b/dr

[PATCH v2 22/30] ide: Use desc consistently for struct blk_desc

2023-04-25 Thread Simon Glass
Most of the code uses 'desc' as the variable name for a blk descriptor. Change ide to do the same. Tidy up some extra brackets and types while we are here. Leave the code in ide_probe() alone since it is about to be refactored. Signed-off-by: Simon Glass --- (no changes since v1) drivers/blo

[PATCH v2 24/30] ide: Move all blk_desc init into ide_ident()

2023-04-25 Thread Simon Glass
Rather than having the caller fill some of this in, do it all in the ide_ident() function, since it knows all the values. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/block/ide.

[PATCH v2 29/30] ide: Simplify expressions and hex values

2023-04-25 Thread Simon Glass
The code has quite a few unnecessary brackets and comparisons to zero, etc. Fix these up as well as some upper-case hex values and use of 0x in printf() strings. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 115 +--- 1 file

[PATCH v2 28/30] ide: Convert to use log_debug()

2023-04-25 Thread Simon Glass
Avoid the use of the function name in a few of the debug() calls, since this causes a checkpatch warning. Convert all other calls too. Use lower-case hex consistently. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 80 ++---

[PATCH v2 27/30] ide: Tidy up ide_reset()

2023-04-25 Thread Simon Glass
Avoid using #ifdef and use a single function declaration, so it is easier to read. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c inde

[PATCH v2 25/30] ide: Use a single local blk_desc for ide_ident()

2023-04-25 Thread Simon Glass
We only use one member of the ide_dev_desc[] array at a time and it does not stick around outside ide_probe(). Use a single element instead. Copy over the missing members of blk_desc at the same, since this was missing from the previous code. Signed-off-by: Simon Glass Fixes: 68e6f221ed0 ("block

[PATCH v2 26/30] ide: Correct LBA setting

2023-04-25 Thread Simon Glass
Fix a longstanding bug where the LBA is calculated as the size of the media instead of the number of blocks. This was perhaps not noticed earlier since it prints the correct value first, before setting the wrong value. Drop the unnecessary blksz variable while we are here. Signed-off-by: Simon Gl

[PATCH v2 23/30] ide: Make ide_ident() return an error code

2023-04-25 Thread Simon Glass
Update ide_ident() to indicate whether it finds a device or not. Use that to decide whether to create a block device for it, rather than looking DEV_TYPE_UNKNOWN. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 101 +++- 1 file

[PATCH v2 20/30] ide: Move ide_init() entirely within ide_probe()

2023-04-25 Thread Simon Glass
Now that ide_probe() is the only caller of ide_init(), move all the code into the probe function, so it is easier to refactor it. Move ide_dev_desc[] into ide_probe() to, since it is the only user. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 84 +

[PATCH v2 21/30] ide: Combine the two loops in ide_probe()

2023-04-25 Thread Simon Glass
The two loops in this function operate on the same ide_dev_desc[] array. Combine them to reduce duplication. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/block/ide.c b/drivers/b

[PATCH v2 19/30] ide: Move setting of vendor strings into ide_probe()

2023-04-25 Thread Simon Glass
The current implementation adds this information in the block device's probe() function, which is called in the blk_probe_or_unbind() in ide_probe(). It is simpler to do this in ide_probe() itself, since the effect is the same. This helps to consolidate use of ide_dev_desc[] which we would like to

[PATCH v2 18/30] ide: Make ide_bus_ok a local variable

2023-04-25 Thread Simon Glass
This is only used in one place now, so make it a local variable. Signed-off-by: Simon Glass --- Changes in v2: - Drop [] in patch subject drivers/block/ide.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c index aac4462

[PATCH v2 15/30] ide: Avoid preprocessor for CONFIG_ATAPI

2023-04-25 Thread Simon Glass
Use IS_ENABLED() instead for all conditions. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c index a51a0008cae..6c5227a5c0e 100644 --- a/drivers

[PATCH v2 17/30] ide: Move bus init into a function

2023-04-25 Thread Simon Glass
Move this code into a separate function which returns whether the bus was found, or not. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 87 + 1 file changed, 48 insertions(+), 39 deletions(-) diff --git a/drivers/block/id

[PATCH v2 16/30] ide: Avoid preprocessor for CONFIG_LBA48

2023-04-25 Thread Simon Glass
Use IS_ENABLED() instead for all conditions. Add the 'lba48' flag into struct blk_desc always, since it uses very little space. Use a bool so the meaning is clearer. Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek --- (no changes since v1) drivers/block/ide.c | 57

[PATCH v2 14/30] ide: Simplify success condition

2023-04-25 Thread Simon Glass
Change the if() to remove extra brackets and check for the positive case first, i.e. when a device is found. Exit the loop in that case, with the retry logic in the 'else' part. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 36 +---

[PATCH v2 13/30] ide: Refactor confusing loop code

2023-04-25 Thread Simon Glass
This code is hard to follow as it uses #ifdef in a strange way. Adjust it to avoid the preprocessor. Drop the special return for the non-ATAPI case since we can rely on tries becoming 0 and exiting the loop. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 43

[PATCH v2 11/30] ide: Make function static

2023-04-25 Thread Simon Glass
Only one function is called from outside this file. Make all the others static. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 23 +++ include/ide.h | 11 --- 2 files changed, 11 insertions(+), 23 deletions(-) diff --git a/drivers/

[PATCH v2 12/30] ide: Change the retries variable

2023-04-25 Thread Simon Glass
Use a 'tries' variable which starts at the number of tries we want to do, rather than a 'retries' one that stops at either 1 or 2. This will make it easier to refactor the code to avoid the horrible #ifdefs Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 10 +

[PATCH v2 10/30] ide: Correct use of ATAPI

2023-04-25 Thread Simon Glass
The use of atapi_read() was incorrect dropped. Fix this so that it will be used when needed. Use a udevice for the first argument of atapi_read() so it is consistent with ide_read(). This requires much of the ATAPI code to be brought out from behind the existing #ifdef. It will still be removed by

[PATCH v2 09/30] ide: Create a prototype for ide_set_reset()

2023-04-25 Thread Simon Glass
This is used by a board so should be in the header file. Add it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 2 -- include/ide.h | 10 ++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c inde

[PATCH v2 08/30] ide: Drop weak functions

2023-04-25 Thread Simon Glass
These are not used from outside this file anymore. Make them static and remove them from the header file. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 14 +++--- include/ide.h | 13 - 2 files changed, 7 insertions(+), 20 deletions(-) dif

[PATCH v2 07/30] ide: Move a few functions further up the file

2023-04-25 Thread Simon Glass
Move these functions so they appear before they are used. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 68 ++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c index

[PATCH v2 05/30] ide: Move ide_init() into probing

2023-04-25 Thread Simon Glass
At present the code does ide_init() as a separate operation, then calls device_probe() to copy over the information. We can call ide_init() from probe just as easily. The only difference is that using 'ide init' twice will do nothing. However it already fails to copy over the new data in that case

[PATCH v2 06/30] ide: Drop ide_device_present()

2023-04-25 Thread Simon Glass
This function is not used anymore. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 9 - include/ide.h | 4 2 files changed, 13 deletions(-) diff --git a/drivers/block/ide.c b/drivers/block/ide.c index 13770484b36..b5be022a067 100644 --- a

[PATCH v2 04/30] ide: Drop init for not using BLK

2023-04-25 Thread Simon Glass
ALl boards use CONFIG_BLK now so this code is not used. Drop it and the header-file #ifdef Signed-off-by: Simon Glass --- (no changes since v1) common/board_r.c | 12 include/ide.h| 7 --- 2 files changed, 19 deletions(-) diff --git a/common/board_r.c b/common/board_r.c

[PATCH v2 03/30] ide: Drop CONFIG_START_IDE

2023-04-25 Thread Simon Glass
This is not used by any board. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) common/board_r.c | 5 - include/ide.h| 7 --- 2 files changed, 12 deletions(-) diff --git a/common/board_r.c b/common/board_r.c index 6b4180b3ecd..7076af64f5d 100644 --- a/common/board_r.c

[PATCH v2 02/30] ide: Use mdelay() for long delays

2023-04-25 Thread Simon Glass
Rather than using very large numbers with udelay(), use mdelay(), which is easier to follow. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/drivers/block/ide.c b/drivers/bl

[PATCH v2 01/30] ide: Move ATA_CURR_BASE to C file

2023-04-25 Thread Simon Glass
This is not used outside one C file. Move it out of the header to reduce its visbility. Signed-off-by: Simon Glass --- (no changes since v1) drivers/block/ide.c | 3 +++ include/ide.h | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/ide.c b/drivers/bl

[PATCH v2 00/30] ide: Clean up code and fix a few bugs

2023-04-25 Thread Simon Glass
This code was converted to driver model a long time again but it was a pretty rough conversion. It introduced a few minor bugs, e.g. the device capacity is incorrect and some flags are lost (such as lba48). This series tidies up the code and fixes these bugs. This involves quite a bit of refactori

Re: [PATCH 17/31] sandbox: Allow weak symbols to be dropped

2023-04-25 Thread Pali Rohár
On Tuesday 25 April 2023 10:44:17 Bin Meng wrote: > Hi Simon, > > On Tue, Apr 25, 2023 at 7:09 AM Simon Glass wrote: > > > > The sandbox build makes use of a small number of weak symbols. Allow these > > to be dropped when building for the PE format, since its support for weak > > symbols is poor

Re: [PATCH 27/31] Makefile: Disable LTO when building with MSYS2

2023-04-25 Thread Pali Rohár
On Monday 24 April 2023 17:08:32 Simon Glass wrote: > This creates a lot of errors of the form: > > `__stack_chk_fail' referenced in section `.text' of ...ltrans.o: defined >in discarded section `.text' of common/stackprot.o (symbol from plugin) This issue should be rather fixed... > Drop LT

[PATCH] fdt: Indicate that people should use the ofnode API

2023-04-25 Thread Simon Glass
Add a note to the comment at the top of this file. Signed-off-by: Simon Glass --- lib/fdtdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 0827e16859f..55cc95db5d0 100644 --- a/lib/fdtdec.c +++ b/lib/fdtdec.c @@ -1,6 +1,9 @@ // SPDX-License-Identifi

Re: [PATCH 26/31] Makefile: Correct the ans1_compiler rule for MSYS2

2023-04-25 Thread Pali Rohár
On Monday 24 April 2023 17:08:31 Simon Glass wrote: > Add the required extension to the Makefile rule. > > Signed-off-by: Simon Glass > --- > > Makefile | 1 + > scripts/Makefile.build | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile

Re: [PATCH 25/31] Makefile: Disable unsupported compiler options with PE

2023-04-25 Thread Pali Rohár
On Monday 24 April 2023 17:08:30 Simon Glass wrote: > The MSYS2 compiler does not support some of these options. Drop them to > avoid build errors. > > Signed-off-by: Simon Glass > --- > > Makefile | 2 ++ > scripts/Makefile.lib | 5 - > 2 files changed, 6 insertions(+), 1 delet

Re: [PATCH 10/31] sandbox: Provide a linker script for MSYS2

2023-04-25 Thread Pali Rohár
On Monday 24 April 2023 17:08:15 Simon Glass wrote: > Add a script to allow the U-Boot sandbox executable to be built for > Windows. Add a note as to why this seems to be necessary for now. > > Signed-off-by: Simon Glass > --- > > Makefile | 11 +- > arch/sandbox/config.m

Re: [PATCH 24/31] build: Disable weak symbols for MSYS2

2023-04-25 Thread Pali Rohár
On Monday 24 April 2023 17:08:29 Simon Glass wrote: > Weak symbols are not well supported by the PE format, so disable them. They are supported by PE format. This is likely issue of (older) toolchain. What about rather requiring better toolchain version and fix special cases of weak functions do n

[PATCH] environment: ti: Add get_fit_config command to get FIT config string

2023-04-25 Thread Andrew Davis
When OE is packaging a dtb file into the FIT image it names the node based on the dtb filename. Node names can't have "/" so it is turned into "_". We select our FIT config using the "fdtfile" env var so we don't duplicate the board_name to fdt logic. Result is fdtfile needs mangled when used to se

Re: [PATCH 06/31] pylibfdt: Allow building on Windows

2023-04-25 Thread Pali Rohár
On Monday 24 April 2023 17:08:11 Simon Glass wrote: > Handle the different shared-object extension with MSYS2 by creating a new > SOEXT variable. LIBEXT would be a better name as "SO" name refers to ELF. I saw that variable LIBEXT is used in more projects for this purpose. > Signed-off-by: Simon

Re: [PATCH 00/31] Allow building sandbox with MSYS2

2023-04-25 Thread Tom Rini
On Tue, Apr 25, 2023 at 04:59:53AM +0200, Heinrich Schuchardt wrote: > > > Am 25. April 2023 01:08:05 MESZ schrieb Simon Glass : > >This expands the existing work to allow sandbox to build and run on > >Windows using MSYS2. > > Why do we need this? > Wouldn't a developer on Windows be much bette

Re: [PATCH 25/31] Makefile: Disable unsupported compiler options with PE

2023-04-25 Thread Tom Rini
On Mon, Apr 24, 2023 at 05:08:30PM -0600, Simon Glass wrote: > The MSYS2 compiler does not support some of these options. Drop them to > avoid build errors. > > Signed-off-by: Simon Glass > --- > > Makefile | 2 ++ > scripts/Makefile.lib | 5 - > 2 files changed, 6 insertions(+)

Re: [PATCH 03/31] u_boot_pylib: Make pty optional

2023-04-25 Thread Tom Rini
On Mon, Apr 24, 2023 at 05:08:08PM -0600, Simon Glass wrote: > This library is not available on Windows. Detect this and work around it > by using a normal pipe. > > Signed-off-by: Simon Glass > --- > > scripts/make_pip.sh | 9 +++-- > tools/u_boot_pylib/cros_subprocess.p

Re: [PATCH 2/2] .mailmap: Map all Xilinx users mail ids to AMD

2023-04-25 Thread Tom Rini
On Mon, Apr 24, 2023 at 12:44:12AM -0600, Ashok Reddy Soma wrote: > From: Algapally Santosh Sagar > > The mail ids of all the current Xilinx users are to be mapped to AMD > following the merger with AMD. The mailmap file is updated accordingly. > > The ids of Marek Behún and Michal Simek are tak

Re: [PATCH 00/30] ide: Clean up code and fix a few bugs

2023-04-25 Thread Tom Rini
On Tue, Mar 28, 2023 at 08:06:47AM +1300, Simon Glass wrote: > This code was converted to driver model a long time again but it was a > pretty rough conversion. It introduced a few minor bugs, e.g. the device > capacity is incorrect and some flags are lost (such as lba48). > > This series tidies

[PATCH] arm: imx8m: remove unused and obsolete board_fix_fdt() in SOC context

2023-04-25 Thread Hugo Villeneuve
From: Hugo Villeneuve It doesn't seem appropriate for arch/SOC to use a board-level functionality (CONFIG_OF_BOARD_FIXUP), because this prevents boards that need to do FDT fixup from using that feature. Also, this code is completely dead and useless (from comments by Rasmus Villemoes on the mail

  1   2   >