Re: [PATCH v2 2/9] cmd: boot: implement PMIC based poweroff

2023-08-08 Thread Svyatoslav Ryhel
9 серпня 2023 р. 05:03:41 GMT+03:00, Simon Glass написав(-ла): >Hi Svyatoslav, > >On Mon, 31 Jul 2023 at 12:07, Svyatoslav Ryhel wrote: >> >> >> >> 31 липня 2023 р. 20:08:06 GMT+03:00, Simon Glass >> написав(-ла): >> >Hi Svyatoslav, >> > >> >On Sun, 30 Jul 2023 at 01:23, Svyatoslav Ryhel

Re: [PATCH 2/2] doc: imx8mp_evk: Use in-tree build in the example

2023-08-08 Thread Peng Fan
On 8/7/2023 9:42 PM, Fabio Estevam wrote: From: Fabio Estevam To make it consistent with the instructions from other NXP imx8m boards, such as imx8mm-evk and imx8mn-evk, use U-Boot in-tree build in the examples. Signed-off-by: Fabio Estevam Reviewed-by: Peng Fan

Re: [PATCH 1/2] doc: imx8mp_evk: Remove unneeded export ATF_LOAD_ADDR line

2023-08-08 Thread Peng Fan
On 8/7/2023 9:42 PM, Fabio Estevam wrote: From: Fabio Estevam Originally, exporting the ATF_LOAD_ADDR was required, but since binman has been used to generate the flash.bin, it is no longer needed to do such manual export. The ATF address is now passed via binman in imx8mp-u-boot.dtsi:

Re: [PATCH v8 1/4] i2c: designware: Add Kconfig for designware_i2c_pci.c

2023-08-08 Thread Simon Glass
Hi, On Tue, 25 Jul 2023 at 03:47, Minda Chen wrote: > > As the Designware_i2c_pci.c uses ACPI APIs, If some SoCs (StarFive > JH7110) contain Designware i2c and PCI but do not use ACPI, > This file will be can't be compiled. So add a new Kconfig for > designware_i2c_pci.c, which depends on

Re: [PATCH v2 2/4] malloc: Don't use ifdefs for SYS_MALLOC_DEFAULT_TO_INIT

2023-08-08 Thread Simon Glass
On Tue, 8 Aug 2023 at 16:53, Sean Anderson wrote: > > With CONFIG_IS_ENABLED we can eliminate some ifdefs. > > Signed-off-by: Sean Anderson > Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v1) > > common/dlmalloc.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-)

Re: [v2] doc: Begin adding a best practices document for board ports

2023-08-08 Thread Simon Glass
On Tue, 8 Aug 2023 at 14:36, Tom Rini wrote: > > To help guide developers down the right path, begin a document that > lists some best practices to follow when creating a new board port. > > Signed-off-by: Tom Rini > --- > Cc: Heinrich Schuchardt > Changes in v2: > - Apply feedback from

Re: [PATCH] regulator: preserve error code properly in regulator_list_autoset()

2023-08-08 Thread Simon Glass
Hi, On Tue, 8 Aug 2023 at 15:42, Tom Rini wrote: > > On Wed, Jul 26, 2023 at 10:01:21AM +0300, Dan Carpenter wrote: > > > This code has a & vs && typo so it only preserves odd value error > > codes and not even value error codes. > > > > Signed-off-by: Dan Carpenter > > Reviewed-by: Simon Glass

Re: [PATCH v2 4/4] malloc: Enable SYS_MALLOC_RUNTIME_INIT by default in SPL

2023-08-08 Thread Simon Glass
On Tue, 8 Aug 2023 at 16:53, Sean Anderson wrote: > > On boards with size restrictions, 1-2k can be a significant fraction of > the binary size. Add a new SPL version of SYS_MALLOC_RUNTIME_INIT and > enable it by default. > > Signed-off-by: Sean Anderson > --- > > (no changes since v1) > >

Re: [RFC PATCH] env: Export environment config to OS devicetree

2023-08-08 Thread Simon Glass
Hi Frieder, On Mon, 7 Aug 2023 at 06:19, Frieder Schrempf wrote: > > Hi Simon, hi Stefano, > > On 04.08.23 15:39, Stefano Babic wrote: > > Hi Simon, > > > > On 04.08.23 05:42, Simon Glass wrote: > >> Hi, > >> > >> On Thu, 3 Aug 2023 at 07:21, Stefano Babic wrote: > >>> > >>> Hi Frieder, > >>> >

Re: getting u-boot to work on raspi 3b (32bit)

2023-08-08 Thread Simon Glass
Hi Robert, On Fri, 28 Jul 2023 at 07:39, Robert Wenisch wrote: > > Hi Simon, > > meanwhile I've tried booting from an FIT image. I.e. I wrote an ist file and > baked an itb for booting. > However, that gave me errors along the lines of "Wrong image format for bootm > command". I wonder

Re: [PATCH 1/3] arm: qemu: Enable Bochs video support

2023-08-08 Thread Simon Glass
Hi Alper, On Tue, 8 Aug 2023 at 13:19, Alper Nebi Yasak wrote: > > Commit 716161663ec49 ("riscv: qemu: Enable Bochs video support") enables > a video console for QEMU RISC-V virtual machines using an emulated Bochs > VGA card. Similarly, enable it for ARM virtual machines as well. > >

Re: [PATCH v2 1/4] common: Only mark malloc initialized after mem_malloc_init

2023-08-08 Thread Simon Glass
On Tue, 8 Aug 2023 at 16:53, Sean Anderson wrote: > > Instead of marking malloc as initialized as soon as relocation is done, > defer it until after we call mem_malloc_init. This ensures that malloc > initialization is done before we switch away from simple_malloc, and > matches the SPL behavior.

Re: [PATCH v19 0/9] introduce Arm FF-A support

2023-08-08 Thread Simon Glass
Hi, On Tue, 8 Aug 2023 at 13:25, Tom Rini wrote: > > On Fri, Aug 04, 2023 at 02:33:36PM +0100, Abdellatif El Khlifi wrote: > > > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A) [A]. > > > > FF-A specifies interfaces that enable a pair of software execution > > environments

Re: [PATCH 1/3] malloc: Don't use ifdefs for SYS_MALLOC_DEFAULT_TO_INIT

2023-08-08 Thread Simon Glass
On Mon, 31 Jul 2023 at 23:24, Heinrich Schuchardt wrote: > > On 8/1/23 00:33, Sean Anderson wrote: > > With CONFIG_IS_ENABLED we can eliminate some ifdefs. > > > > Signed-off-by: Sean Anderson > > Reviewed-by: Heinrich Schuchardt > Reviewed-by: Simon Glass

Re: [PATCH 1/1] video: avoid build failure on veyron board

2023-08-08 Thread Simon Glass
Hi Alvaro, On Fri, 4 Aug 2023 at 06:42, Alvaro Fernando García wrote: > > Hello Simon, > > El vie, 4 ago 2023 a la(s) 00:02, Simon Glass (s...@google.com) escribió: >> >> Hi, >> >> On Thu, 3 Aug 2023 at 18:37, Alvaro Fernando García >> wrote: >> > >> > 533ad9dc avoided an overflow but causes

Re: [PATCH 1/3] fdt: common API to populate kaslr seed

2023-08-08 Thread Simon Glass
Hi, On Fri, 4 Aug 2023 at 17:34, wrote: > > From: Dhananjay Phadke > > fdt_fixup_kaslr_seed() will update given FDT with random seed value. > Source for random seed can be TPM or RNG driver in u-boot or sec > firmware (ARM). > > Signed-off-by: Dhananjay Phadke > --- >

Re: [RFC] dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation

2023-08-08 Thread Simon Glass
Hi Jonas, On Sat, 5 Aug 2023 at 07:32, Jonas Karlman wrote: > > Devices for nodes with e.g. bootph-pre-ram are initialized three times. > 1. At SPL stage (always bind and probe only if used) > 2. At U-Boot proper pre-reloc (always bind and probe) > 3. At U-Boot proper normal (always bind and

Re: [PATCH v2 3/4] malloc: Don't statically initialize av_ if using malloc_init

2023-08-08 Thread Simon Glass
On Tue, 8 Aug 2023 at 16:53, Sean Anderson wrote: > > When we enable malloc_init, there is no need to statically initialize > av_, since we are going to do it manually. This lets us move av_ to > .bss, saving around 1-2k of data (depending on the pointer size). > > cALLOc must be adjusted to not

Re: [PATCH 2/3] fdt: kaslr seed from tpm entropy

2023-08-08 Thread Simon Glass
Hi, On Fri, 4 Aug 2023 at 17:34, wrote: > > From: Dhananjay Phadke > > Add support for KASLR seed from TPM device. Invokes tpm_get_random() > API to read 8-bytes of random bytes for KASLR. > > Signed-off-by: Dhananjay Phadke > Signed-off-by: Drew Kluemke > Signed-off-by: Sean Edmond > --- >

Re: NVMe support on RPi CM4 board

2023-08-08 Thread Simon Glass
Hi Luis, On Tue, 8 Aug 2023 at 17:09, Luis Alfredo da Silva wrote: > > I compiled u-boot version 2023-07 and boot it on a RPi CM4 using a PCIe M.2 > NVMe drive, but it doesn't appear to be working. > > Once u-boot has started and boot successfully it recognizes the PCIe device > giving me the

Re: [PATCH v2 2/9] cmd: boot: implement PMIC based poweroff

2023-08-08 Thread Simon Glass
Hi Svyatoslav, On Mon, 31 Jul 2023 at 12:07, Svyatoslav Ryhel wrote: > > > > 31 липня 2023 р. 20:08:06 GMT+03:00, Simon Glass > написав(-ла): > >Hi Svyatoslav, > > > >On Sun, 30 Jul 2023 at 01:23, Svyatoslav Ryhel wrote: > >> > >> > >> > >> 24 липня 2023 р. 05:28:24 GMT+03:00, Simon Glass >

Re: Porting feature to ancient U-boot V.S porting ancient hardware code patches to new U-boot

2023-08-08 Thread Simon Glass
Hi, On Tue, 8 Aug 2023 at 14:41, Mr Academia Euforia wrote: > > Hi there, > > I'm working on certain feature to be added to ONIE that is running on > Broadcom's Helix4 -based network switch. Part of the task is to add FIT > signature signing to U-boot versions supported by ONIE. ONIE as part of

Re: [PATCH 3/3] arm: qemu: Enable usb keyboard as an input device

2023-08-08 Thread Simon Glass
On Tue, 8 Aug 2023 at 13:19, Alper Nebi Yasak wrote: > > Commit 02be57caf730 ("riscv: qemu: Enable usb keyboard as an input > device") adds PCI xHCI support to QEMU RISC-V virtual machines and > enables using a USB keyboard as one of the input devices. Similarly, > enable those for ARM virtual

Re: [PATCH 2/3] arm: qemu: Enable PRE_CONSOLE_BUFFER

2023-08-08 Thread Simon Glass
On Tue, 8 Aug 2023 at 13:19, Alper Nebi Yasak wrote: > > Commit 608b80b5b855 ("riscv: qemu: Enable PRE_CONSOLE_BUFFER") enables > buffering console messages for QEMU RISC-V virtual machines so those > printed before the video console is available will still show up on the > display. Similarly,

Re: [PATCH v3 10/10] MAINTAINERS: Add Broadcom Broadband SoC HS SPI drivers

2023-08-08 Thread Tom Rini
On Wed, Jun 07, 2023 at 04:37:10PM -0700, William Zhang wrote: > Add entry for Broadcom Broadband SoC HS SPI drivers > > Signed-off-by: William Zhang Can you please rebase this rest of this series on top of current next and fix the compiler warnings that show up, thanks. -- Tom

Re: [u-boot-test-hooks 1/4] bin/flash.sdwire_common_mount: Switch to sourcing the next writer script

2023-08-08 Thread Tom Rini
On Tue, 25 Jul 2023 17:08:44 -0400, Tom Rini wrote: > Rather than invoking the script that will write to the mounted directory > as a binary, source it as a script so that it has access to more than > just two parameters. This will allow us to have the same flexibility in > our writers that

Re: [PATCH] btrfs: fix some error checking for btrfs_decompress()

2023-08-08 Thread Tom Rini
On Thu, Aug 03, 2023 at 01:29:34PM +0300, Dan Carpenter wrote: > The btrfs_decompress() function mostly (u32)-1 on error but it can > also return -EPERM or other kernel error codes from zstd_decompress(). > The "ret" variable is an int, so we could just check for negatives. > > Signed-off-by:

Re: [PATCH] test: fix a couple NULL vs IS_ERR() checks

2023-08-08 Thread Tom Rini
On Mon, Jul 31, 2023 at 05:08:41PM +0300, Dan Carpenter wrote: > The x509_cert_parse() and pkcs7_parse_message() functions return error > pointers. They don't return NULL. Update the checks accordingly. > > Signed-off-by: Dan Carpenter > Reviewed-by: Simon Glass Applied to u-boot/next,

Re: [PATCH] expo: allocate correct amount of memory

2023-08-08 Thread Tom Rini
On Mon, Jul 31, 2023 at 05:08:29PM +0300, Dan Carpenter wrote: > This should be allocating the memory for "item" instead of "menu". > The item struct is 48 bytes instead of 96 (assuming a 64bit system) > so this saves a little memory. > > Signed-off-by: Dan Carpenter > Reviewed-by: Simon Glass

Re: [PATCH] cmd: improve string matching for hex

2023-08-08 Thread Tom Rini
On Mon, Jul 31, 2023 at 05:03:59PM +0300, Dan Carpenter wrote: > Match the "=0x" instead of just "=0". > > Signed-off-by: Dan Carpenter > Reviewed-by: Heinrich.Schuchardt > Reviewed-by: Simon Glass > Reviewed-by: Ilias Apalodimas Applied to u-boot/next, thanks! -- Tom signature.asc

Re: [PATCH 1/1] pci: correct function name in message

2023-08-08 Thread Tom Rini
On Thu, Jul 27, 2023 at 06:50:14PM +0200, Heinrich Schuchardt wrote: > If an error message contains a function name, it should match the name of > the function throwing the message. > > Fixes: 7739d93d8288 ("pci: Match region flags using a mask") > Signed-off-by: Heinrich Schuchardt >

Re: [PATCH] cramfs: clean up some error messages

2023-08-08 Thread Tom Rini
On Thu, Jul 27, 2023 at 10:16:03AM +0300, Dan Carpenter wrote: > This line break is not done correctly. We don't want to have all those > tabs in the printed output. > > Signed-off-by: Dan Carpenter > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc

Re: [PATCH] test: unicode: fix a sizeof() vs ARRAY_SIZE() bug

2023-08-08 Thread Tom Rini
On Thu, Jul 27, 2023 at 10:12:58AM +0300, Dan Carpenter wrote: > The u16_strlcat() is in units of u16 not bytes. So the limit needs to > be ARRAY_SIZE() instead of sizeof(). > > Signed-off-by: Dan Carpenter Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] cmd: pxe_utils: add some missing tabs

2023-08-08 Thread Tom Rini
On Thu, Jul 27, 2023 at 10:12:39AM +0300, Dan Carpenter wrote: > These lines are supposed to be indented one more tab. Otherwise it's > confusing to read. > > Signed-off-by: Dan Carpenter > Reviewed-by: Patrick Delaunay Applied to u-boot/next, thanks! -- Tom signature.asc Description:

Re: [PATCH] remoteproc: uclass: Clean up a return

2023-08-08 Thread Tom Rini
On Wed, Jul 26, 2023 at 10:00:33AM +0300, Dan Carpenter wrote: > We know that "pa" is non-NULL so it's nicer to just return zero instead > of return !pa. This has no effect on runtime behavior. > > Signed-off-by: Dan Carpenter > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! --

Re: [PATCH] fdt: off by one in ofnode_lookup_fdt()

2023-08-08 Thread Tom Rini
On Wed, Jul 26, 2023 at 09:59:52AM +0300, Dan Carpenter wrote: > The "oftree_count" is the number of entries which have been set in > the oftree_list[] array. If all the entries have been initialized then > this off by one would result in reading one element beyond the end > of the array. > >

Re: [PATCH] fs: btrfs: Prevent error pointer dereference in list_subvolums()

2023-08-08 Thread Tom Rini
On Wed, Jul 26, 2023 at 09:59:04AM +0300, Dan Carpenter wrote: > If btrfs_read_fs_root() fails with -ENOENT, then we go to the next > entry. Fine. But if it fails for a different reason then we need > to clean up and return an error code. In the current code it > doesn't clean up but instead

Re: [PATCH] cros_ec: Fix an error code is cros_ec_get_sku_id()

2023-08-08 Thread Tom Rini
On Wed, Jul 26, 2023 at 09:58:34AM +0300, Dan Carpenter wrote: > The ec_command_inptr() function returns negative error codes or > the number of bytes that it was able to read. The cros_ec_get_sku_id() > function should return negative error codes. Right now it returns > positive error codes or

Re: [PATCH] cmd: Fix a size parameter in test_readonly()

2023-08-08 Thread Tom Rini
On Tue, Jul 25, 2023 at 09:50:26AM +0300, Dan Carpenter wrote: > The parentheses are in the wrong place so this passes the number of > bytes to write as "sizeof(index_0) != TPM_SUCCESS" when just > "sizeof(index_0)" was intended. (1 byte vs 4 bytes). > > Signed-off-by: Dan Carpenter Applied

Re: [PATCH] cmd: Fix an error code in cmd_mux_find()

2023-08-08 Thread Tom Rini
On Tue, Jul 25, 2023 at 09:50:08AM +0300, Dan Carpenter wrote: > This returns the wrong variable. It ends up returning NULL when it was > suppose to return an error pointer. > > Signed-off-by: Dan Carpenter Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] board_f: Cosmetic style fix

2023-08-08 Thread Tom Rini
On Sat, Jul 22, 2023 at 12:15:21AM +0800, Bin Meng wrote: > Some coding convention fixes for print_resetinfo(). > > Signed-off-by: Bin Meng > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] crc32: Drop duplicates crc header includes

2023-08-08 Thread Tom Rini
On Fri, Jul 14, 2023 at 05:39:32PM +0300, Ilya Lukin wrote: > Fixes: 3db711085752 ("crc32: Use the crc.h header for crc functions") > Signed-off-by: Ilya Lukin <4.sh...@gmail.com> Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/2] lib/charset: fix u16_strlcat() return value

2023-08-08 Thread Tom Rini
On Fri, Jul 14, 2023 at 01:24:51PM +0200, Matthias Schiffer wrote: > strlcat returns min(strlen(dest), count)+strlen(src). Make u16_strlcat's > behaviour the same for consistency. > > Fixes: eca08ce94ceb ("lib/charset: add u16_strlcat() function") > Signed-off-by: Matthias Schiffer Applied to

Re: [PATCH 1/2] Revert "lib: string: Fix strlcpy return value", fix callers

2023-08-08 Thread Tom Rini
On Fri, Jul 14, 2023 at 01:24:50PM +0200, Matthias Schiffer wrote: > Both the Linux kernel and libbsd agree that strlcpy() should always > return strlen(src) and not include the NUL termination. The incorrect > U-Boot implementation makes it impossible to check the return value for > truncation,

Re: [PATCH] video: Add parentheses around VNBYTES() macro

2023-08-08 Thread Tom Rini
On Wed, Jul 26, 2023 at 09:54:08AM +0300, Dan Carpenter wrote: > The VNBYTES() macro needs to have parentheses to prevent some (harmless) > macro expansion bugs. The VNBYTES() macro is used like this: > > VID_TO_PIXEL(x) * VNBYTES(vid_priv->bpix) > > The * operation is done before the /

Re: Strange construct in binman description

2023-08-08 Thread Tim Harvey
On Tue, Aug 8, 2023 at 10:54 AM Simon Glass wrote: > > Hi Tim, > > On Mon, 7 Aug 2023 at 14:03, Tim Harvey wrote: > > > > On Sun, Jul 30, 2023 at 7:50 PM Simon Glass wrote: > > > > > > Hi Tim, > > > > > > On Sun, 30 Jul 2023 at 17:42, Tim Harvey wrote: > > > > > > > > > > > > On Wed, Jul 26,

NVMe support on RPi CM4 board

2023-08-08 Thread Luis Alfredo da Silva
I compiled u-boot version 2023-07 and boot it on a RPi CM4 using a PCIe M.2 NVMe drive, but it doesn't appear to be working. Once u-boot has started and boot successfully it recognizes the PCIe device giving me the next output U-Boot> pci BusDevFun VendorId DeviceId Device Class

[PATCH v2 0/4] malloc: Reduce size by initializing data at runtime

2023-08-08 Thread Sean Anderson
In my efforts to get SPL to fit into flash after some changes I made, I noticed that av_ is one of the largest variables in SPL. As it turns out, we can generate it at runtime, and the code is already there. This has the potential to save 1-2k across the board, for some (very) minor boot time

[PATCH v2 3/4] malloc: Don't statically initialize av_ if using malloc_init

2023-08-08 Thread Sean Anderson
When we enable malloc_init, there is no need to statically initialize av_, since we are going to do it manually. This lets us move av_ to .bss, saving around 1-2k of data (depending on the pointer size). cALLOc must be adjusted to not access top before malloc_init. While we're at it,

[PATCH v2 4/4] malloc: Enable SYS_MALLOC_RUNTIME_INIT by default in SPL

2023-08-08 Thread Sean Anderson
On boards with size restrictions, 1-2k can be a significant fraction of the binary size. Add a new SPL version of SYS_MALLOC_RUNTIME_INIT and enable it by default. Signed-off-by: Sean Anderson --- (no changes since v1) Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH v2 2/4] malloc: Don't use ifdefs for SYS_MALLOC_DEFAULT_TO_INIT

2023-08-08 Thread Sean Anderson
With CONFIG_IS_ENABLED we can eliminate some ifdefs. Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- (no changes since v1) common/dlmalloc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/common/dlmalloc.c b/common/dlmalloc.c index

[PATCH v2 1/4] common: Only mark malloc initialized after mem_malloc_init

2023-08-08 Thread Sean Anderson
Instead of marking malloc as initialized as soon as relocation is done, defer it until after we call mem_malloc_init. This ensures that malloc initialization is done before we switch away from simple_malloc, and matches the SPL behavior. Fixes: c9356be3074 ("dm: Split the simple malloc()

Re: [PATCH 1/3] imx7d-sdb-u-boot: Pass SPDX-License tag

2023-08-08 Thread Marek Vasut
On 8/8/23 23:40, Fabio Estevam wrote: From: Fabio Estevam SPDX-License tag is missing and checkpatch complains about it. Add the SPDX-License tag using the same one from imx7d-sdb.dts. Signed-off-by: Fabio Estevam --- arch/arm/dts/imx7d-sdb-u-boot.dtsi | 2 ++ 1 file changed, 2

Re: [PATCH 3/3] smegw01: Convert to watchdog driver model

2023-08-08 Thread Marek Vasut
On 8/8/23 23:40, Fabio Estevam wrote: From: Fabio Estevam Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for

Re: [PATCH 2/3] mx7dsabresd: Convert to watchdog driver model

2023-08-08 Thread Marek Vasut
On 8/8/23 23:40, Fabio Estevam wrote: From: Fabio Estevam Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for

Re: [PATCH v2] arm: imx: imx8m: imx9: Fix DRAM size calculation due to rom_pointer

2023-08-08 Thread Fabio Estevam
Hi Elena, On 08/08/2023 08:58, Elena Popa wrote: If dram_init_banksize() is called from SPL, the rom_pointer, at that point, is not correctly initialized. This causes wrong calculation of DRAM start and size in dram_init_banksize(). The issue became apparent only in Falcon Mode. Added an extra

Re: [PATCH] regulator: preserve error code properly in regulator_list_autoset()

2023-08-08 Thread Tom Rini
On Wed, Jul 26, 2023 at 10:01:21AM +0300, Dan Carpenter wrote: > This code has a & vs && typo so it only preserves odd value error > codes and not even value error codes. > > Signed-off-by: Dan Carpenter > Reviewed-by: Simon Glass > --- > drivers/power/regulator/regulator-uclass.c | 2 +- > 1

[PATCH 3/3] smegw01: Convert to watchdog driver model

2023-08-08 Thread Fabio Estevam
From: Fabio Estevam Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset. Signed-off-by:

[PATCH 2/3] mx7dsabresd: Convert to watchdog driver model

2023-08-08 Thread Fabio Estevam
From: Fabio Estevam Commit 68dcbdd594d4 ("ARM: imx: Add weak default reset_cpu()") caused the 'reset' command in U-Boot to not cause a board reset. Fix it by switching to the watchdog driver model via sysreset, which is the preferred method for implementing the watchdog reset. Signed-off-by:

[PATCH 1/3] imx7d-sdb-u-boot: Pass SPDX-License tag

2023-08-08 Thread Fabio Estevam
From: Fabio Estevam SPDX-License tag is missing and checkpatch complains about it. Add the SPDX-License tag using the same one from imx7d-sdb.dts. Signed-off-by: Fabio Estevam --- arch/arm/dts/imx7d-sdb-u-boot.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git

Porting feature to ancient U-boot V.S porting ancient hardware code patches to new U-boot

2023-08-08 Thread Mr Academia Euforia
Hi there, I'm working on certain feature to be added to ONIE that is running on Broadcom's Helix4 -based network switch. Part of the task is to add FIT signature signing to U-boot versions supported by ONIE. ONIE as part of the build process uses uboot snapshots, and applies platform patches on

Re: [PATCH 3/6] ARM: imx: Add weak default reset_cpu()

2023-08-08 Thread Marek Vasut
On 8/8/23 21:17, Fabio Estevam wrote: Hi Marek, On Mon, Jun 26, 2023 at 5:53 AM Marek Vasut wrote: Add weak default reset_cpu() implementation needed by e.g. panic(). Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Fabio Estevam Cc: Stefano Babic ---

[v2] doc: Begin adding a best practices document for board ports

2023-08-08 Thread Tom Rini
To help guide developers down the right path, begin a document that lists some best practices to follow when creating a new board port. Signed-off-by: Tom Rini --- Cc: Heinrich Schuchardt Changes in v2: - Apply feedback from Heinrich --- doc/develop/board_best_practices.rst | 26

Re: [PATCH] doc: Begin adding a best practices document for board ports

2023-08-08 Thread Heinrich Schuchardt
On 8/8/23 00:15, Tom Rini wrote: To help guide developers down the right path, begin a document that lists some best practices to follow when creating a new board port. Signed-off-by: Tom Rini --- doc/develop/board_best_practices.rst | 26 ++ doc/develop/index.rst

Re: [PATCH v19 0/9] introduce Arm FF-A support

2023-08-08 Thread Tom Rini
On Fri, Aug 04, 2023 at 02:33:36PM +0100, Abdellatif El Khlifi wrote: > Adding support for Arm FF-A v1.0 (Arm Firmware Framework for Armv8-A) [A]. > > FF-A specifies interfaces that enable a pair of software execution > environments aka partitions to > communicate with each other. A partition

[PATCH 3/3] arm: qemu: Enable usb keyboard as an input device

2023-08-08 Thread Alper Nebi Yasak
Commit 02be57caf730 ("riscv: qemu: Enable usb keyboard as an input device") adds PCI xHCI support to QEMU RISC-V virtual machines and enables using a USB keyboard as one of the input devices. Similarly, enable those for ARM virtual machines as well. Signed-off-by: Alper Nebi Yasak ---

[PATCH 2/3] arm: qemu: Enable PRE_CONSOLE_BUFFER

2023-08-08 Thread Alper Nebi Yasak
Commit 608b80b5b855 ("riscv: qemu: Enable PRE_CONSOLE_BUFFER") enables buffering console messages for QEMU RISC-V virtual machines so those printed before the video console is available will still show up on the display. Similarly, enable it for ARM virtual machines as well. Signed-off-by: Alper

[PATCH 1/3] arm: qemu: Enable Bochs video support

2023-08-08 Thread Alper Nebi Yasak
Commit 716161663ec49 ("riscv: qemu: Enable Bochs video support") enables a video console for QEMU RISC-V virtual machines using an emulated Bochs VGA card. Similarly, enable it for ARM virtual machines as well. Signed-off-by: Alper Nebi Yasak --- arch/arm/Kconfig | 4

[PATCH 0/3] arm: qemu: Enable Bochs, console buffering, USB keyboard

2023-08-08 Thread Alper Nebi Yasak
Now that the driver for the Bochs VGA card emulated by QEMU is no longer limited to x86 architectures [1], this series enables it on arm and arm64 virtual machines to provide a graphical interface. In line with that series this also enables console buffering and USB keyboard. Tested with the

Re: [PATCH 3/6] ARM: imx: Add weak default reset_cpu()

2023-08-08 Thread Fabio Estevam
Hi Marek, On Mon, Jun 26, 2023 at 5:53 AM Marek Vasut wrote: > > Add weak default reset_cpu() implementation needed by e.g. panic(). > > Signed-off-by: Marek Vasut > --- > Cc: "NXP i.MX U-Boot Team" > Cc: Fabio Estevam > Cc: Stefano Babic > --- > arch/arm/mach-imx/cpu.c | 4 > 1 file

Re: [PATCHv5 11/13] net/lwip: connection between cmd and lwip apps

2023-08-08 Thread Ilias Apalodimas
Hi Maxim [...] > > > +static int lwip_empty_tmo(void) { return 0; }; > > > +int (*ulwip_tmo)(void) = lwip_empty_tmo; > > > +void ulwip_set_tmo(int (*tmo)(void)) > > > +{ > > > + ulwip_tmo = tmo; > > > +} > > > + > > > +static void ulwip_clear_tmo(void) > > > +{ > > > + ulwip_tmo =

Re: Strange construct in binman description

2023-08-08 Thread Simon Glass
Hi Tim, On Mon, 7 Aug 2023 at 14:03, Tim Harvey wrote: > > On Sun, Jul 30, 2023 at 7:50 PM Simon Glass wrote: > > > > Hi Tim, > > > > On Sun, 30 Jul 2023 at 17:42, Tim Harvey wrote: > > > > > > > > > On Wed, Jul 26, 2023, 5:55 PM Simon Glass wrote: > > >> > > >> Hi Tim, > > >> > > >> On Mon,

Re: [PATCHv5 09/13] net/lwip: implement lwip port to u-boot

2023-08-08 Thread Simon Glass
Hi Maxim, On Tue, 8 Aug 2023 at 04:07, Maxim Uvarov wrote: > > > > > On Thu, 3 Aug 2023 at 22:21, Maxim Uvarov wrote: >> >> >> >> On Thu, 3 Aug 2023 at 03:32, Simon Glass wrote: >>> >>> Hi Maxim, >>> >>> On Wed, 2 Aug 2023 at 08:11, Maxim Uvarov wrote: >>> > >>> >>> subject: U-Boot >>> >>>

Re: [PATCH] dm: core: allow DM_POST_INIT_F notification for TIMER_EARLY

2023-08-08 Thread Simon Glass
Hi Chanho, On Tue, 8 Aug 2023 at 01:35, Chanho Park wrote: > > Since the Patch 55171aedda88, VisionFive2 booting has been broken [1]. > VisionFive2 board requires to enable CONFIG_TIMER_EARLY but booting went > to panic from initr_dm_devices due to lack of a timer device. > > - Error logs >

Re: [PATCHv5 12/13] net/lwip: replace original net commands with lwip

2023-08-08 Thread Simon Glass
Hi Maxim, On Tue, 8 Aug 2023 at 08:06, Maxim Uvarov wrote: > > > > On Thu, 3 Aug 2023 at 03:32, Simon Glass wrote: >> >> Hi Maxim, >> >> On Wed, 2 Aug 2023 at 08:11, Maxim Uvarov wrote: >> > >> > Replace original commands: ping, tftp, dhcp and wget. >> > >> > Signed-off-by: Maxim Uvarov >> >

Re: [PATCH] arm: Add arch/arm/dts/Makefile specifically to MAINTAINERS

2023-08-08 Thread Simon Glass
On Mon, 7 Aug 2023 at 15:08, Tom Rini wrote: > > In order to reduce the number of people that are cc'd on a patch for > simply touching arch/arm/dts/Makefile (which is a big common file) add > an entry specifically to MAINTAINERS under the ARM entry. > > Signed-off-by: Tom Rini > --- >

[PATCH 4/5] clk: promote clk_dev_ops to linux/clk-provider.h

2023-08-08 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen So that it can be used by others. Signed-off-by: Yang Xiwen --- drivers/clk/clk-uclass.c | 5 - include/linux/clk-provider.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c index

[PATCH 5/5] clk: ccf: call clock provided ops directly for endisable()

2023-08-08 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen Calling into CCF framework will cause a clock being enabled twice instead of once (clk->enable_count becomes 2 rather than 1), thus making it hard to disable (needs to call clk_disable() twice). Fix that by calling clock provided ops directly. Signed-off-by: Yang Xiwen ---

[PATCH 2/5] clk: call log_debug() instead to avoid console log printing

2023-08-08 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen it's a very common case to register a clock without a parent, such as clk_register_fixed_rate(). Replace log_error() with log_debug() to avoid useless console log if not debugging. Signed-off-by: Yang Xiwen --- drivers/clk/clk.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 3/5] clk: also handle ENOENT in *_optional functions

2023-08-08 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen If the device does not specify any clocks in device tree, these functions will return PTR_ERR(-ENOENT). This is not the intended behavior and does not comply with linux kernel CCF. Fix that by returning NULL under such circumstances instead. Signed-off-by: Yang Xiwen ---

[PATCH 0/5] clk: A few bugfixes/enhancements for CCF

2023-08-08 Thread Yang Xiwen via B4 Relay
They are found during my development for HiSilicon clock driver. Details are in commit logs. Signed-off-by: Yang Xiwen --- Yang Xiwen (5): clk: export clk_register_mux_table() clk: call log_debug() instead to avoid console log printing clk: also handle ENOENT in *_optional

[PATCH 1/5] clk: export clk_register_mux_table()

2023-08-08 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen It's already implemented in clk-mux.c, export it in the header file. Signed-off-by: Yang Xiwen --- include/linux/clk-provider.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h index b8acacd49e..801404480b

[PATCH 2/2] net: mv88e6xxx: add Clause 45 support

2023-08-08 Thread Robert Marko
Marvell LinkStreet switches support Clause 45 MDIO on the internal bus. C45 read or writes require the register address to be written first to the SMI PHY Data register, and then a special C45 Write Address Register OP is used on the SMI PHY Register before making a C45 Read Data Register OP and

[PATCH 1/2] net: mv88e6xxx: use generic bitfield macros for MDIO

2023-08-08 Thread Robert Marko
Driver is currently defining the mask and bit shifting itself, there is no need for that as U-Boot has generic bitfield macros that help us achieve the same result but in a cleaner way. Signed-off-by: Robert Marko --- drivers/net/mv88e6xxx.c | 25 + 1 file changed, 13

[RFC] spl_fit.c: SPL Falcon Mode return to U-Boot

2023-08-08 Thread Elena Popa
When Falcon Mode is enabled, spl_start_uboot() function must be defined. If this function returns 0 then SPL should start the kernel, if it returns 1 then U-Boot must be started. When spl_start_uboot() returns 1, then U-Boot must be loaded, and as far as I can tell spl_image->os should be set

Re: [PATCH 2/2] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-08-08 Thread Alexander Dahl
Hello Michael, Am Tue, Aug 08, 2023 at 03:49:45PM +0200 schrieb Michael Nazzareno Trimarchi: > Hi > > On Tue, Aug 8, 2023 at 3:03 PM Alexander Dahl wrote: > > > > Adapt behaviour to Linux kernel driver. > > > > The return value of gpio_request_by_name_nodev() was not checked before, > > and

Re: [PATCH 0/2] mtd: nand: raw: atmel: R/B gpio on sam9x60

2023-08-08 Thread Alexander Dahl
Hello Mihai, Am Tue, Aug 08, 2023 at 01:40:26PM + schrieb mihai.s...@microchip.com: > Hi Alex, > > Please find bellow my answer: > > -- > > Added Mihai who tested this a lot at some point in time > > Eugen > > On 8/8/23 16:02, Alexander Dahl wrote: > > Hello

Re: [PATCH v4 0/6] Introduce the sysinfo command

2023-08-08 Thread Marek Vasut
On 8/8/23 16:31, Peter Robinson wrote: On Tue, Aug 8, 2023 at 3:27 PM Detlev Casanova wrote: On Tuesday, August 8, 2023 10:21:11 A.M. EDT Peter Robinson wrote: On Thu, Jul 20, 2023 at 3:50 PM Detlev Casanova wrote: The command can be used to show various information that can be used to

Re: [PATCH v4 0/6] Introduce the sysinfo command

2023-08-08 Thread Peter Robinson
On Tue, Aug 8, 2023 at 3:27 PM Detlev Casanova wrote: > > On Tuesday, August 8, 2023 10:21:11 A.M. EDT Peter Robinson wrote: > > On Thu, Jul 20, 2023 at 3:50 PM Detlev Casanova > > > > wrote: > > > The command can be used to show various information that can be used to > > > identify the running

Re: [PATCH v4 0/6] Introduce the sysinfo command

2023-08-08 Thread Detlev Casanova
On Tuesday, August 8, 2023 10:21:11 A.M. EDT Peter Robinson wrote: > On Thu, Jul 20, 2023 at 3:50 PM Detlev Casanova > > wrote: > > The command can be used to show various information that can be used to > > identify the running system. > > > > Currently supported subcommands are: > > * model:

Re: [PATCH 1/5] board: rockchip: Add Pine64 Quartz64-A Board

2023-08-08 Thread Christopher Obbard
Hi Jonas, On Sun, 2023-07-23 at 15:04 +, Jonas Karlman wrote: > On 2023-07-23 16:55, Jonas Karlman wrote: > > The Pine64 Quartz64 Model A is a single-board computer based on the > > Rockchip RK3566 SoC. The board features USB3, SATA, PCIe, HDMI, USB2.0, > > CSI, DSI, eDP, eMMC, SD, and an

Re: [PATCH v4 0/6] Introduce the sysinfo command

2023-08-08 Thread Peter Robinson
On Thu, Jul 20, 2023 at 3:50 PM Detlev Casanova wrote: > > The command can be used to show various information that can be used to > identify the running system. > > Currently supported subcommands are: > * model: A string representing the model > * id: The id of the board > * revision: The

Re: [PATCHv5 12/13] net/lwip: replace original net commands with lwip

2023-08-08 Thread Maxim Uvarov
On Thu, 3 Aug 2023 at 03:32, Simon Glass wrote: > Hi Maxim, > > On Wed, 2 Aug 2023 at 08:11, Maxim Uvarov wrote: > > > > Replace original commands: ping, tftp, dhcp and wget. > > > > Signed-off-by: Maxim Uvarov > > --- > > boot/bootmeth_efi.c | 2 +- > > boot/bootmeth_pxe.c | 2 +- > >

Re: [PATCH] spl: mmc: Fix check of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR

2023-08-08 Thread Tom Rini
On Tue, Aug 08, 2023 at 04:42:15PM +0300, Elena Popa wrote: > When Falcon Mode is enabled, SPL needs to check the value of > CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR. Unfortunately, it was using the > CONFIG_VAL(SYS_MMCSD_RAW_MODE_ARGS_SECTOR) which converts it into >

[PATCH] spl: mmc: Fix check of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR

2023-08-08 Thread Elena Popa
When Falcon Mode is enabled, SPL needs to check the value of CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTOR. Unfortunately, it was using the CONFIG_VAL(SYS_MMCSD_RAW_MODE_ARGS_SECTOR) which converts it into CONFIG_SPL_SYS_MMCSD_RAW_MODE_ARGS_SECTOR when CONFIG_SPL_BUILD is enabled.

Re: [PATCH 2/2] mtd: nand: raw: atmel: Add error handling when rb-gpios missing

2023-08-08 Thread Michael Nazzareno Trimarchi
Hi On Tue, Aug 8, 2023 at 3:03 PM Alexander Dahl wrote: > > Adapt behaviour to Linux kernel driver. > > The return value of gpio_request_by_name_nodev() was not checked before, > and thus in case 'rb-gpios' was missing in DT, rb.type was set to > ATMEL_NAND_GPIO_RB nevertheless, leading to

Re: [PATCH 1/2] mtd: nand: raw: atmel: Remove duplicate line

2023-08-08 Thread Michael Nazzareno Trimarchi
Hi On Tue, Aug 8, 2023 at 3:03 PM Alexander Dahl wrote: > > Signed-off-by: Alexander Dahl > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c > b/drivers/mtd/nand/raw/atmel/nand-controller.c

RE: [PATCH 0/2] mtd: nand: raw: atmel: R/B gpio on sam9x60

2023-08-08 Thread Mihai.Sain
Hi Alex, Please find bellow my answer: -- Added Mihai who tested this a lot at some point in time Eugen On 8/8/23 16:02, Alexander Dahl wrote: > Hello everyone, > > this is a patch series wtih some real fixes _and_ a question or some > kind of support request in

[PATCH v1] configs: starfive: Enable environment in SPI flash support

2023-08-08 Thread Shengyu Qu
On Starfive Visionfive 2, the u-boot environment settings are saved to on-board SPI flash. Enable relative configs by default and set offset and size according to upstream linux dts. Signed-off-by: Shengyu Qu --- configs/starfive_visionfive2_defconfig | 9 + 1 file changed, 9

Re: [PATCH 0/2] mtd: nand: raw: atmel: R/B gpio on sam9x60

2023-08-08 Thread Eugen Hristev
Added Mihai who tested this a lot at some point in time Eugen On 8/8/23 16:02, Alexander Dahl wrote: Hello everyone, this is a patch series wtih some real fixes _and_ a question or some kind of support request in the cover letter. I would be happy if anyone could read the cover letter

  1   2   >