[RESEND PATCH v5 7/7] board: ti: j721s2: MAINTAINERS: Update the MAINTAINERS File.

2023-09-19 Thread Manorit Chawdhry
Update the MAINTAINERS file and propose a new MAINTAINER for j721s2 due to the previous MAINTAINER not being associated with TI. Reviewed-by: Nishanth Menon Signed-off-by: Manorit Chawdhry --- board/ti/j721s2/MAINTAINERS | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

[RESEND PATCH v5 6/7] docs: board: ti: Add j721s2_evm documentation

2023-09-19 Thread Manorit Chawdhry
Add the documentation for J721S2-EVM and SK-AM68 TRM for J721S2/AM68: https://www.ti.com/lit/pdf/spruj28 Product Page for J721S2: https://www.ti.com/tool/J721S2XSOMXEVM Product Page for AM68: https://www.ti.com/tool/SK-AM68 Reviewed-by: Neha Malcom Francis Reviewed-by: Nishanth Menon

[RESEND PATCH v5 5/7] k3-am68: Sync from Linux tag v6.6-rc1

2023-09-19 Thread Manorit Chawdhry
The following commit syncs the device tree from Linux tag v6.6-rc1 to U-boot and fixes the following to be compatible with the future syncs - - Include k3-am68-sk-base-board.dts file Remove the duplicated pinmuxes from r5 and -u-boot.dtsi files and include k3-am68-sk-base-board.dts for

[RESEND PATCH v5 4/7] k3-j721s2: Sync from Linux tag v6.6-rc1

2023-09-19 Thread Manorit Chawdhry
The following commit syncs the device tree from Linux tag v6.6-rc1 to U-boot and fixes the following to be compatible with the future syncs - - Include k3-j721s2-common-proc-board.dts file Remove the duplicated pinmuxes from r5 and -u-boot.dtsi files and include

[RESEND PATCH v5 3/7] arm: mach-k3: j721s2: Add mcu_timer0 id to the dev list

2023-09-19 Thread Manorit Chawdhry
mcu_timer0 is used by u-boot as the tick-timer. Add it to the soc devices lsit so it an be enabled via the k3 power controller. Reviewed-by: Neha Malcom Francis Reviewed-by: Nishanth Menon Signed-off-by: Manorit Chawdhry --- arch/arm/mach-k3/j721s2/dev-data.c | 1 + 1 file changed, 1

[RESEND PATCH v5 2/7] Revert "arm: dts: k3-j7*: ddr: Update to 0.10 version of DDR config tool"

2023-09-19 Thread Manorit Chawdhry
The update causes instability in am68-sk boards so revert the patch in the meantime till fix is available. This reverts commit f1edf4bb6aa19732574ac23ca90cb9a0ba395ec1. Signed-off-by: Manorit Chawdhry --- arch/arm/dts/k3-j721e-ddr-evm-lp4-4266.dtsi | 98 +++---

[RESEND PATCH v5 1/7] configs: j721s2_evm_r5_defconfig: Increase malloc pool size in DRAM

2023-09-19 Thread Manorit Chawdhry
From: Udit Kumar The malloc capacity in DRAM at R5 SPL is set to 1MB which isn't sufficient to load the new tispl.bin to enable loading of tispl.bin the size is increased by 256KB to 1.25MB. Cc: Nikhil M Jain Signed-off-by: Udit Kumar Reviewed-by: Nishanth Menon Signed-off-by: Manorit

[RESEND PATCH v5 0/7] J721S2 DTS Sync from v6.6-rc1 to u-boot

2023-09-19 Thread Manorit Chawdhry
The sync tries to ensure that U-boot remains functional with the updated Linux DTS and all the fixes from Linux move to U-boot during the sync. The series tries to sync from Linux v6.6-rc1 along with addition of the documentation for J721S2 that had been previously missing. DMA fixes [0] are

Re: [PATCH] J721S2 DTS Sync from v6.6-rc1 to u-boot

2023-09-19 Thread Manorit Chawdhry
Hi Konstantin, On 17:26-20230919, Konstantin Ryabitsev wrote: > September 19, 2023 at 7:20 AM, "Manorit Chawdhry" wrote: > > Am not sure either.. I had been using b4 for all the patches and I still > > see that my next revision queued by b4 also has the same problem.

[PATCH v6 1/2] configs: Add support in Kconfig and convert for armada boards

2023-09-19 Thread Venkatesh Yadav Abbarapu
From: Algapally Santosh Sagar The DEFAULT_ENV_IS_RW is moved to the Kconfig for easier configuration. Hence, the CONFIG_DEFAULT_ENV_IS_RW config is added to the defconfig files to allow enabling them for armada boards. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Venkatesh Yadav

[PATCH v6 2/2] serial: zynqmp: Fetch baudrate from dtb and update

2023-09-19 Thread Venkatesh Yadav Abbarapu
From: Algapally Santosh Sagar The baudrate configured in .config is taken by default by serial. If change of baudrate is required then the .config needs to changed and u-boot recompilation is required or the u-boot environment needs to be updated. To avoid this, support is added to fetch the

[PATCH v6 0/2] Add support to fetch baudrate from dtb

2023-09-19 Thread Venkatesh Yadav Abbarapu
In this patch series - Add support in Kconfig and convert for armada boards - Fetch baudrate from the dtb and update Changes in v6: - Changed Kconfig OF_SERIAL_DT_BAUD to OF_SERIAL_BAUD. - Added IS_ENABLED() in place of #ifdef CONFIG_OF_SERIAL_AUD Changes in v5: - Adding DEFAULT_ENV_IS_RW

[PATCH] pinctrl: Increase size of pinmux status buffer

2023-09-19 Thread Venkatesh Yadav Abbarapu
For Xilinx ZynqMP SOC new parameter was added and now it can set 7 parameters for its pins. Pinmux status command will print the status of these parameters for each pin. But current print buffer length is only 80 characters long, increase it to 90 to print all the parameters without truncation.

[PATCH v2] cmd: sf: Fix the flash_is_unlocked api size parameter

2023-09-19 Thread Venkatesh Yadav Abbarapu
When flash erase is called with size parameter, code is checking if sectors are locked or not. But for checking, the whole device length minus offset is used instead of actual size which should be erased. That's why when only some sectors are locked it is not possible to erase unlocked sectors.

[PATCH v5 19/20] x86: doc: Split out manual booting into its own file

2023-09-19 Thread Simon Glass
Move this out of the main file since for simple users it is easier to rely on standard boot. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add new patch doc/arch/x86/index.rst | 1 + doc/arch/x86/manual_boot.rst | 276

[PATCH v5 20/20] x86: doc: coreboot: Mention 64-bit Linux distros

2023-09-19 Thread Simon Glass
Add a little more detail as to why coreboot64 is preferred for booting Linux distros. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add new patch doc/board/coreboot/coreboot.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v5 18/20] x86: doc: Update summaries and add links

2023-09-19 Thread Simon Glass
Refresh the summary information so it is more up-to-date. Add links to the coreboot and slimbootloader docs. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add new patch doc/arch/x86/x86.rst | 17 ++--- 1 file changed, 10

[PATCH v5 17/20] x86: doc: Move into its own directory

2023-09-19 Thread Simon Glass
There is enough material that it makes sense to split this up into several files. Create an x86/ directory for this purpose. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add new patch doc/arch/index.rst | 2 +- doc/arch/x86/index.rst

[PATCH v5 16/20] x86: coreboot: Record the position of the SMBIOS tables

2023-09-19 Thread Simon Glass
Make a note of where coreboot installed the SMBIOS tables so that we can pass this on to EFI. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Add new patch arch/x86/lib/coreboot/cb_sysinfo.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v5 15/20] efi: Use the installed SMBIOS tables

2023-09-19 Thread Simon Glass
U-Boot should set up the SMBIOS tables during startup, as it does on x86. Ensure that it does this correctly on non-x86 machines too, by creating an event spy for last-stage init. Tidy up the installation-condition code while we are here. Signed-off-by: Simon Glass --- (no changes since v4)

[PATCH v5 14/20] Record the position of the SMBIOS tables

2023-09-19 Thread Simon Glass
Remember where these end up so that we can pass this information on to the EFI layer. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v4) Changes in v4: - Fix arm and riscv Changes in v2: - Add new patch arch/arm/include/asm/global_data.h | 3 +++

[PATCH v5 13/20] bootstd: Keep track of use of usb stop

2023-09-19 Thread Simon Glass
When 'usb stop' is run, doing 'bootflow scan' does not run the USB hunter again so does not see any devices. Fix this by telling bootstd about the state of USB. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootdev-uclass.c | 27 +++

[PATCH v5 12/20] x86: smbios: Add a Kconfig indicating SMBIOS-table presence

2023-09-19 Thread Simon Glass
When booted from coreboot, U-Boot does not build the SMBIOS tables, but it should still pass them on to the OS. Add a new option which indicates whether SMBIOS tables are present, however they were built. Flip the ordering so that the dependency is listed first, which is less confusing. Adjust

[PATCH v5 11/20] efi: x86: Correct the condition for installing ACPI tables

2023-09-19 Thread Simon Glass
It is not always the case that U-Boot builds the ACPI tables itself. For example, when booting from coreboot, the ACPI tables are built by coreboot. Correct the Makefile condition so that U-Boot can pass on tables built by a previous firmware stage. Tidy up the installation-condition code while

[PATCH v5 10/20] x86: coreboot: Enable VIDEO_COPY

2023-09-19 Thread Simon Glass
At least on modern machines the write-back mechanism for the frame buffer is quite slow when scrolling, since it must read the entire frame buffer and write it back. Enable the VIDEO_COPY feature to resolve this problem. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since

[PATCH v5 09/20] x86: coreboot: Align options between coreboot and coreboot64

2023-09-19 Thread Simon Glass
These two builds are similar but have some different options for not good reason. Line them up to be as similar as possible. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v2) Changes in v2: - Update the malloc size too configs/coreboot64_defconfig | 7 +++

[PATCH v5 08/20] x86: coreboot: Drop USB init on startup

2023-09-19 Thread Simon Glass
This is very annoying as it is quite slow on many machines. Also, U-Boot has an existing 'preboot' mechanism to enable this feature if desired. Drop this code so that it is possible to choose whether to init USB or not. Use the existing USE_PREBOOT mechanism instead. Signed-off-by: Simon Glass

[PATCH v5 07/20] x86: coreboot: Enable CONFIG_SYS_NS16550_MEM32

2023-09-19 Thread Simon Glass
The debug UART on modern machines uses a 32-bit wide transfer. Without this, setting debug output causes a hang or no output. It is not obvious (when enabling CONFIG_DEBUG_UART) that this is needed. Enable 32-bit access to avoid this trap. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v5 06/20] x86: coreboot: Look for DBG2 UART in SPL too

2023-09-19 Thread Simon Glass
If coreboot does not set up sysinfo for the UART, SPL currently hangs. Use the DBG2 technique there as well. This allows coreboot64 to boot from coreboot even if the console info is missing from sysinfo Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v5: - Correct 'teechnique'

[PATCH v5 05/20] x86: Allow APCI in SPL

2023-09-19 Thread Simon Glass
This is needed so we can find the DBG2 table provided by coreboot. Add a Kconfig so it can be enabled. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) lib/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/lib/Kconfig b/lib/Kconfig index

[PATCH v5 04/20] x86: Set the CPU vendor in SPL

2023-09-19 Thread Simon Glass
We don't read this information in 64-bit mode, since we don't have the macros for doing it. Set it to Intel by default. This allows the TSC timer to work correctly. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) arch/x86/cpu/x86_64/cpu.c | 7 +++ 1 file

[PATCH v5 03/20] x86: coreboot: Rearrange arch_cpu_init()

2023-09-19 Thread Simon Glass
Init errors in SPL are currently ignored by this function. Change the code to init the CPU, reporting an error if something is wrong. After that, look for the coreboot table. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v5: - Drop unwanted space

[PATCH v5 02/20] x86: coreboot: Enable standard boot

2023-09-19 Thread Simon Glass
Enable bootstd options and provide instructions on how to boot a linux distro using coreboot. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- Changes in v5: - Use 'lzma' instead of 'LZMA' configs/coreboot64_defconfig| 14 ++ configs/coreboot_defconfig | 1 +

[PATCH v5 01/20] x86: coreboot: Add IDE and SATA

2023-09-19 Thread Simon Glass
Add these options to permit access to more disk types. Add some documentation as well. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) configs/coreboot64_defconfig| 1 + configs/coreboot_defconfig | 9 + doc/board/coreboot/coreboot.rst | 20

[PATCH v5 00/20] x86: efi: Fixes and improvements for coreboot

2023-09-19 Thread Simon Glass
This little series fixes various bugs and annoyances in coreboot and coreboot64. With this both coreboot and coreboot64 start up and work reasonably well on Brya (x86 Chromebook) and U-Boot can boot common Linux distros. - Make coreboot64 debug UART start reliably - Avoid the long USB-init delay

Re: [PATCH v4 2/2] x86: Update cbmem driver

2023-09-19 Thread Simon Glass
Hi Bin, On Tue, 19 Sept 2023 at 02:47, Bin Meng wrote: > > Hi Simon, > > On Mon, Sep 11, 2023 at 3:13 AM Simon Glass wrote: > > > > This driver is not actually built since a Kconfig was never created for > > it. > > > > Add a Kconfig (which is already implied by COREBOOT) and update the > >

Re: [PATCH v4 07/20] x86: coreboot: Enable CONFIG_SYS_NS16550_MEM32

2023-09-19 Thread Simon Glass
Hi Bin, On Tue, 19 Sept 2023 at 01:19, Bin Meng wrote: > > Hi Simon, > > On Thu, Aug 24, 2023 at 5:11 AM Simon Glass wrote: > > > > The debug UART on modern machines uses a 32-bit wide transfer. Without > > this, setting debug output causes a hang or no output. It is not obvious > > (when

Re: [PATCH v4 08/20] x86: coreboot: Drop USB init on startup

2023-09-19 Thread Simon Glass
Hi Bin, On Tue, 19 Sept 2023 at 01:19, Bin Meng wrote: > > Hi Simon, > > On Thu, Aug 24, 2023 at 5:11 AM Simon Glass wrote: > > > > This is very annoying as it is quite slow on many machines. Also, U-Boot > > has an existing 'preboot' mechanism to enable this feature if desired. > > > > Drop

Re: [PATCH v4 16/20] x86: coreboot: Record the position of the SMBIOS tables

2023-09-19 Thread Simon Glass
Hi Bin, On Tue, 19 Sept 2023 at 01:20, Bin Meng wrote: > > On Thu, Aug 24, 2023 at 5:11 AM Simon Glass wrote: > > > > Make a note of where coreboot installed the SMBIOS tables so that we can > > pass this on to EFI. > > > > Signed-off-by: Simon Glass > > --- > > > > (no changes since v2) > > >

Re: [PATCH 1/1] binman: doc: Remove incomplete sentence

2023-09-19 Thread Simon Glass
Hi Heinrich, On Tue, 19 Sept 2023 at 04:02, Heinrich Schuchardt wrote: > > This is the difference between version 1 and 2 of Massimo's patch: > > binman: doc: fix reference tag placement for Logging section > v2: >

[PATCH 2/2] dm: core: Adjust dump-sorting to get stats only when needed

2023-09-19 Thread Simon Glass
If we are not sorting the tree we don't need to get the stats. Adjust the code to avoid the wasted time. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/dump.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/core/dump.c b/drivers/core/dump.c

[PATCH 1/2] dm: core: Correct references to DM_SPL

2023-09-19 Thread Simon Glass
This does not existing anymore. Update the two in-tree uses of it to the correct Kconfig option, which is SPL_DM Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to correct references to DM_SPL drivers/block/Kconfig | 2 +- drivers/core/Kconfig | 2 +- 2 files changed, 2

Re: [PATCH] mx8m: csf.sh: pad csf blob for u-boot.itb to CSF_SIZE minus IVT header

2023-09-19 Thread Marek Vasut
On 9/19/23 21:15, Rasmus Villemoes wrote: On 19/09/2023 20.27, Marek Vasut wrote: On 9/19/23 12:00, Rasmus Villemoes wrote: When built with CONFIG_IMX_HAB, the full FIT image, including stuff tacked on beyond the end of the fdt structure, is expected to be (fdt size rounded up to 0x1000

Re: [PATCH v5 00/21] Kconfig: Tidy up some options

2023-09-19 Thread Tom Rini
On Thu, 14 Sep 2023 10:55:38 -0600, Simon Glass wrote: > The view from 'make menuconfig' is confusing in places. This series aims > to improve the top-level menu and also the boot menu. > > It also groups FDT-fixup options tegether, at least the ones I could fine. > > Finally this series marks

Re: [PATCH] J721S2 DTS Sync from v6.6-rc1 to u-boot

2023-09-19 Thread Konstantin Ryabitsev
September 19, 2023 at 7:20 AM, "Manorit Chawdhry" wrote: > Am not sure either.. I had been using b4 for all the patches and I still > see that my next revision queued by b4 also has the same problem. Not > exactly sure what went wrong with b4 but would be careful next time. > Thanks for pointing

Re: [RFC PATCH 0/5] Allow for removal of DT nodes and properties

2023-09-19 Thread Tom Rini
On Tue, Sep 19, 2023 at 02:25:49PM -0600, Simon Glass wrote: > Hi Rob, > > On Mon, 18 Sept 2023 at 11:00, Rob Herring wrote: > > > > On Thu, Sep 14, 2023 at 5:42 PM Simon Glass wrote: > > > > > > Hi Rob, > > > > > > On Wed, 13 Sept 2023 at 16:39, Rob Herring wrote: > > > > > > > > On Fri, Sep

[PATCH] bootstd: use ARCH_DMA_MINALIGN in memalign() when allocating memory

2023-09-19 Thread Tony Dinh
Use ARCH_DMA_MINALIGN in memalign() when allocating memory to read the script from the media. Ref: https://lore.kernel.org/u-boot/cajalify05f3cr4x4g2mvkppxnbefzrhq+5cngyn8ejpg8en...@mail.gmail.com/T/#m26daadc2463fe653b814a94e6309e5e6bb6be1d1 Note: this patch depends on the previous patch

Re: [PATCH 1/2] spl: make SYS_SPL_MALLOC depend on !(SPL_STACK_R && SPL_SYS_MALLOC_SIMPLE)

2023-09-19 Thread Tom Rini
On Fri, Sep 15, 2023 at 07:50:49PM +0200, Rasmus Villemoes wrote: > Currently, one can have both SYS_SPL_MALLOC=y and > SPL_SYS_MALLOC_SIMPLE=y. > > However, while the former does make board_init_r() in spl.c call > mem_malloc_init(), that has no effect at all, because that just > updates a few

Re: [RFC PATCH 0/5] Allow for removal of DT nodes and properties

2023-09-19 Thread Simon Glass
Hi Rob, On Mon, 18 Sept 2023 at 11:00, Rob Herring wrote: > > On Thu, Sep 14, 2023 at 5:42 PM Simon Glass wrote: > > > > Hi Rob, > > > > On Wed, 13 Sept 2023 at 16:39, Rob Herring wrote: > > > > > > On Fri, Sep 8, 2023 at 1:06 PM Mark Kettenis > > > wrote: > > > > > > > > > From: Jassi Brar

Re: [PATCH v1 1/2] TO BE FOLDED: x86: tangier: Add FADT to the chain

2023-09-19 Thread Simon Glass
Hi Bin, On Tue, 19 Sept 2023 at 01:56, Bin Meng wrote: > > On Tue, Sep 19, 2023 at 3:28 PM Bin Meng wrote: > > > > Hi Andy, > > > > On Fri, Aug 25, 2023 at 9:52 PM Andy Shevchenko > > wrote: > > > > > > The Simon's patch missed the FADT to be added to the chain, hence all > > > the issues on

Re: [PATCH v2] clk: ti: Notify AVS driver upon setting clock rate

2023-09-19 Thread Nishanth Menon
On 22:58-20230919, Kumar, Udit wrote: > Hi Nishanth, > > On 9/19/2023 9:07 PM, Nishanth Menon wrote: > > On 19:34-20230919, Udit Kumar wrote: > > > AVS is enabled at R5 SPL stage, on few platforms like J721E > > > and J7200 clk-k3 is used instead if clk-sci driver

Re: [PATCH] mx8m: csf.sh: pad csf blob for u-boot.itb to CSF_SIZE minus IVT header

2023-09-19 Thread Rasmus Villemoes
On 19/09/2023 20.27, Marek Vasut wrote: > On 9/19/23 12:00, Rasmus Villemoes wrote: >> When built with CONFIG_IMX_HAB, the full FIT image, including stuff >> tacked on beyond the end of the fdt structure, is expected to be (fdt >> size rounded up to 0x1000 boundary)+CONFIG_CSF_SIZE. >> >> Now,

Re: [PATCH] mx8m: csf.sh: pad csf blob for u-boot.itb to CSF_SIZE minus IVT header

2023-09-19 Thread Marek Vasut
On 9/19/23 12:00, Rasmus Villemoes wrote: When built with CONFIG_IMX_HAB, the full FIT image, including stuff tacked on beyond the end of the fdt structure, is expected to be (fdt size rounded up to 0x1000 boundary)+CONFIG_CSF_SIZE. Now, when the FIT image is loaded from a storage device, it

Re: [PATCH] imx8mp: binman: rename spl and u-boot nodes

2023-09-19 Thread Marek Vasut
On 9/19/23 11:28, Rasmus Villemoes wrote: The hab signing script doc/imx/habv4/csf_examples/mx8m/csf.sh does fdtget -t x u-boot.dtb /binman/imx-boot/uboot offset to figure out the offset of u-boot.itb inside flash.bin. That works fine for imx8mm, imx8mn, imx8mq, but fails for imx8mp because

[PATCH 36/36] expo: Update documentation to include textline

2023-09-19 Thread Simon Glass
Update the expo documentation to include mention of this new object type. Signed-off-by: Simon Glass --- doc/develop/cedit.rst | 3 ++- doc/develop/expo.rst | 48 ++- 2 files changed, 45 insertions(+), 6 deletions(-) diff --git a/doc/develop/cedit.rst

[PATCH 35/36] expo: Update tests to include textline

2023-09-19 Thread Simon Glass
Provide test coverage for the new expo object type, including building and reading/writing settings. Signed-off-by: Simon Glass --- arch/sandbox/dts/cedit.dtsi | 8 include/test/cedit-test.h | 5 - test/boot/cedit.c | 30 +++---

[PATCH 34/36] expo: Support building an expo with a textline

2023-09-19 Thread Simon Glass
Add textline to the list of objects which tthe expo builder can build. This allows them to be provided in the description. Signed-off-by: Simon Glass --- boot/expo_build.c | 45 + 1 file changed, 45 insertions(+) diff --git a/boot/expo_build.c

[PATCH 33/36] expo: Plumb in textline to cedit

2023-09-19 Thread Simon Glass
Support textlines in the configuration editor. Signed-off-by: Simon Glass --- boot/cedit.c | 58 +++- 1 file changed, 57 insertions(+), 1 deletion(-) diff --git a/boot/cedit.c b/boot/cedit.c index 407793aaddd..f2387170127 100644 ---

[PATCH 32/36] expo: Support handling any key in cedit

2023-09-19 Thread Simon Glass
At present cedit only supports menu keys. For textline objects we need to insert normal ASCII characters. We also need to handle backspace, which is ASCII 9. In fact, expo does not make use of all the menu keys, so partition them accordingly and update the logic to support normal ASCII

[PATCH 31/36] video: Mark truetype_measure() static

2023-09-19 Thread Simon Glass
This function is not used outside this file, so mark it static. Signed-off-by: Simon Glass --- drivers/video/console_truetype.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/console_truetype.c b/drivers/video/console_truetype.c index

[PATCH 30/36] expo: Plumb in textlines to a scene

2023-09-19 Thread Simon Glass
Provide an implementation for textlines in the scene code, so that they are displayed correctly. Provide a way to have a border around the textline, with the internal part being the same colour as the background. This looks more natural. Signed-off-by: Simon Glass --- boot/scene.c |

[PATCH 29/36] expo: Support opening a textline

2023-09-19 Thread Simon Glass
This object needs special handling when it is opened, to set up the CLI and the vidconsole context. Add special support for this. Signed-off-by: Simon Glass --- boot/scene.c | 32 boot/scene_internal.h | 22 ++ boot/scene_textline.c

[PATCH 28/36] expo: Add basic support for textline objects

2023-09-19 Thread Simon Glass
A textline is a line of text which can be edited by the user. It has a maximum length (in chracters) but otherwise there are no restrictions. Signed-off-by: Simon Glass --- boot/Makefile | 3 +- boot/scene_textline.c | 234 ++ include/expo.h

[PATCH 27/36] expo: Add some scene fields needed for text entry

2023-09-19 Thread Simon Glass
Add the CLI state, a buffer to hold the old value of the text being edited and a place to save vidconsole entry context. These will be use by the textline object. Set an upper limit on the maximum number of characters in a textline object supported by expo, at least for now. Signed-off-by: Simon

[PATCH 26/36] expo: Allow rendering the background of any object

2023-09-19 Thread Simon Glass
So far only menus have a background. When other object types are rendered, they may have a background too. Make this code more generic so it will be usable by new object types. Signed-off-by: Simon Glass --- boot/scene.c | 40 +++-

[PATCH 25/36] expo: Make calculation of an object bounding box generic

2023-09-19 Thread Simon Glass
We want to support this for any object, not just menus. Move the code around to allow this. Signed-off-by: Simon Glass --- boot/scene.c | 45 +++ boot/scene_internal.h | 39 + boot/scene_menu.c | 39

[PATCH 24/36] expo: Add a function to write a property to a devicetree

2023-09-19 Thread Simon Glass
When the devicetree is too small for the property being written, we need to expand the devicetree and retry the write. Put this logic into a function so it can be reused. Signed-off-by: Simon Glass --- boot/cedit.c | 38 ++ 1 file changed, 26 insertions(+),

[PATCH 23/36] expo: Allow highlighting other scene-object types

2023-09-19 Thread Simon Glass
So far only menus can be highlighted. With the coming addition of text lines we need to be able to highlight other objects. Add a function to determine whether an object can be highlighted. Signed-off-by: Simon Glass --- boot/scene.c | 11 --- include/expo.h | 8 2 files

[PATCH 22/36] expo: Correct the logic for duplicate-ID detection

2023-09-19 Thread Simon Glass
Update scene_txt_str() to account for the possibility that the passed-in str_id may be 0 Signed-off-by: Simon Glass --- boot/scene.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/boot/scene.c b/boot/scene.c index 9c4466c1a47..8e5d3aa7dc0 100644 --- a/boot/scene.c +++

[PATCH 21/36] expo: Correct some swallowed errors in scene

2023-09-19 Thread Simon Glass
Return the reported error, rather than assuming it is -ENOMEM Signed-off-by: Simon Glass --- boot/scene.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/boot/scene.c b/boot/scene.c index 08ed85e9188..9c4466c1a47 100644 --- a/boot/scene.c +++ b/boot/scene.c @@ -137,7

[PATCH 20/36] expo: Use switch statements more for object types

2023-09-19 Thread Simon Glass
In a lot of cases menus are the only objects which are have their own behaviour in the cedit, e.g. to move between menus. With expo expanding to support text, this is no-longer true. Use a switch() statement so that we can simply insert a new 'case' for the new object types. Signed-off-by: Simon

[PATCH 19/36] expo: Fix up comments for get_cur_menuitem_text() et al

2023-09-19 Thread Simon Glass
This internal function could use a comment. Add one. Also tidy up a few other comments. Signed-off-by: Simon Glass fixup: comments --- boot/cedit.c | 10 ++ boot/scene_internal.h | 2 +- include/expo.h| 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff

[PATCH 18/36] expo: Add better error reporting

2023-09-19 Thread Simon Glass
When building an expo fails, show some information about which node caused the problem. Use -ENOENT consistently when the ID is missing. This makes it easier for the user to debug things. Signed-off-by: Simon Glass --- boot/expo_build.c | 58 +-- 1

[PATCH 17/36] video: Support showing a cursor

2023-09-19 Thread Simon Glass
Add rudimentary support for displaying a cursor on a vidconsole. This helps the user to see where text is being entered. The implementation so far is very simple: the cursor is just a vertical bar of fixed width and cannot be erased. To erase the cursor, the text must be redrawn over it. This is

[PATCH 16/36] video: Export vidconsole_entry_start()

2023-09-19 Thread Simon Glass
At present this is called only when a newline is detected, since this indicates the start of a line of text being entered. Export this function so it can be used by expo, which may start a new text line itself, without first writing out a newline. Signed-off-by: Simon Glass ---

[PATCH 15/36] video: Allow saving and restoring text-entry state

2023-09-19 Thread Simon Glass
Text entry operates within a context which includes quite a bit of information. For example, with Truetype fonts, each character in the text string has a position stored, so that it is possible to backspace to that character. This information is built up as strings are drawn on the display. For

[PATCH 14/36] video: Allow obtaining the nominal size of a string size

2023-09-19 Thread Simon Glass
At present there is a method for measuring text, but if the actual text string is not known, it cannot be used. For text editor we want to set the size of the entry box to cover the expected text size. Add the concept of a 'norminal' size with a method to calculate that for the vidconsole. If

[PATCH 13/36] cli: Add a function to set up a new cread

2023-09-19 Thread Simon Glass
Create a init function so that it is easy to use command-line reading. Signed-off-by: Simon Glass --- common/cli_readline.c | 24 +++- include/cli.h | 17 - 2 files changed, 31 insertions(+), 10 deletions(-) diff --git a/common/cli_readline.c

[PATCH 12/36] cli: Allow command completion to be disabled

2023-09-19 Thread Simon Glass
When inputting text outside the command line we don't want to use tab for command completion. Add an option to control this. Signed-off-by: Simon Glass --- common/cli_readline.c | 3 ++- include/cli.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 11/36] cli: Allow history to be disabled

2023-09-19 Thread Simon Glass
When inputting text outside the command line we don't want history to be accessible. Add an option to control this. Signed-off-by: Simon Glass --- common/cli_readline.c | 42 ++ include/cli.h | 2 ++ 2 files changed, 24 insertions(+), 20

[PATCH 10/36] cli: Terminate the string in cread_line_process_ch()

2023-09-19 Thread Simon Glass
Rather than relying on the caller, terminate the string inside this function. Do this each time we return, whether input is finished or not. It is not needed when the input is aborted, since the string will be discarded in that case. Signed-off-by: Simon Glass --- common/cli_readline.c | 8

[PATCH 09/36] cli: Create a function to process characters

2023-09-19 Thread Simon Glass
Move most of the inner loop from cread_line() into a new function. This will allow using it from other code. This involves adding a few more members to the state struct. Signed-off-by: Simon Glass --- common/cli_readline.c | 108 -- include/cli.h

[PATCH 08/36] cli: Unindent some code in cread_line()

2023-09-19 Thread Simon Glass
Reduce the indentation level of this code so it is easier to review the next patch, which moves it into a function. Signed-off-by: Simon Glass --- common/cli_readline.c | 279 +- 1 file changed, 139 insertions(+), 140 deletions(-) diff --git

[PATCH 07/36] cli: Convert cread_line() to use a struct for the main vars

2023-09-19 Thread Simon Glass
We want to reuse the editing code elsewhere. As a first step, move the common variables into a struct. This will allow us to eventually put the contents of the inner loop in a function, so it can be called from elsewhere. Signed-off-by: Simon Glass --- common/cli_readline.c | 116

[PATCH 06/36] cli: Use unsigned int instead of unsigned long

2023-09-19 Thread Simon Glass
The index values are not very large so it makes no sense to use a long integer. Change these to uint instead. Signed-off-by: Simon Glass --- common/cli_readline.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/common/cli_readline.c b/common/cli_readline.c

[PATCH 05/36] cli: Implement delete-word in cread_line()

2023-09-19 Thread Simon Glass
The Ctrl-W option is implemented in the cread_line_simple() but not in the full version. This seems odd, so add an implementation. Signed-off-by: Simon Glass --- common/cli_readline.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/common/cli_readline.c

[PATCH 04/36] cli: Drop #ifdefs for CONFIG_AUTO_COMPLETE in cli_readline

2023-09-19 Thread Simon Glass
Use a static inline and adjust the logic to avoid the need for #ifdefs in cli_readline_into_buffer() Signed-off-by: Simon Glass --- common/cli_readline.c | 85 +-- include/command.h | 6 +++ 2 files changed, 48 insertions(+), 43 deletions(-) diff

[PATCH 03/36] cli: Drop some #ifdefs in cli_readline

2023-09-19 Thread Simon Glass
Add a few static inlines to avoid the need for #ifdefs in cli_readline_into_buffer() Signed-off-by: Simon Glass --- common/cli_readline.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/common/cli_readline.c b/common/cli_readline.c index

[PATCH 02/36] cli: Add a command to show cmdline history

2023-09-19 Thread Simon Glass
There is a function for this but it is never used. Showing the history is a useful feature, so add a new 'history' command. Signed-off-by: Simon Glass --- cmd/Kconfig | 7 cmd/Makefile | 1 + cmd/history.c | 23 + common/cli_readline.c

[PATCH 01/36] cli: Move simple readline into a function

2023-09-19 Thread Simon Glass
Move this code into its own function since it is a separate implementation from the full version. Signed-off-by: Simon Glass --- common/cli_readline.c | 79 +-- 1 file changed, 46 insertions(+), 33 deletions(-) diff --git a/common/cli_readline.c

[PATCH 00/36] expo: Support editing lines of text

2023-09-19 Thread Simon Glass
So far expo only supports menus. These are quite flexible for various kinds of settings, but cannot deal with free-form input, such as a serial number or a machine name. This series adds support for a textline object, which is a single line of text. It has a maximum length and its value is stored

Re: [PATCH v3 16/16] doc: board: ti: k3: Add J784S4 EVM and AM69 SK documentation

2023-09-19 Thread Apurva Nandan
On 09/09/23 17:08, Roger Quadros wrote: On 08/09/2023 14:05, Apurva Nandan wrote: TI K3 J784S4 and AM69 SK are new additions to the K3 SoC family. J784S4 is a SoC variant, AM69-SK is a board using AM69 SoC variant. How can a board be part of SoC family? Okay will fix that statement.

Re: [PATCH v3 08/16] board: ti: j784s4: Add board support for J784S4 EVM

2023-09-19 Thread Apurva Nandan
On 09/09/23 16:59, Roger Quadros wrote: On 08/09/2023 14:05, Apurva Nandan wrote: Add board files for J784S4 EVM. Signed-off-by: Hari Nagalla [ add env and board specific yaml files for binman ] Signed-off-by: Neha Malcom Francis [ cleaned up the env files ] Signed-off-by: Manorit

Re: [PATCH v3 08/16] board: ti: j784s4: Add board support for J784S4 EVM

2023-09-19 Thread Apurva Nandan
Hi, On 09/09/23 16:32, Roger Quadros wrote: On 08/09/2023 14:05, Apurva Nandan wrote: Add board files for J784S4 EVM. Signed-off-by: Hari Nagalla [ add env and board specific yaml files for binman ] Signed-off-by: Neha Malcom Francis [ cleaned up the env files ] Signed-off-by: Manorit

Re: [PATCH v3 07/16] remoteproc: k3-dsp: Extend support for C71x DSPs on J784S4 SoCs

2023-09-19 Thread Apurva Nandan
On 09/09/23 16:28, Roger Quadros wrote: On 08/09/2023 14:05, Apurva Nandan wrote: From: Hari Nagalla The K3 J784S4 SoCs have four C71x DSP subsystems in MAIN voltage domain missing period. SoCs have/SoC has The C71x DSPs are 64 bit machine with fixed and floating point DSP> operations.

Re: [PATCH v3 06/16] remoteproc: k3-r5: Extend support for R5F clusters on J784S4 SoCs

2023-09-19 Thread Apurva Nandan
Hi, On 09/09/23 16:26, Roger Quadros wrote: On 08/09/2023 14:05, Apurva Nandan wrote: From: Hari Nagalla The K3 J784S4 SoCs have four dual-core R5F subsystems, one in MCU voltage domain and the other three in MAIN voltage domain. These R5F clusters are similar to the R5F clusters in J7200

Re: [PATCH v3 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

2023-09-19 Thread Apurva Nandan
Hi, On 09/09/23 16:18, Roger Quadros wrote: Hi, On 08/09/2023 14:05, Apurva Nandan wrote: Add j784s4 initialization files for initial SPL boot. Please be consistent in naming. J784S4 ? Signed-off-by: Hari Nagalla [ add firewall configurations and change the R5 MCU scratchpad ]

Re: [PATCH v3 01/16] arm: dts: Introduce j784s4 dts from linux kernel

2023-09-19 Thread Apurva Nandan
Hi, On 09/09/23 16:20, Roger Quadros wrote: On 08/09/2023 14:05, Apurva Nandan wrote: Introduce the basic j784s4 SoC dts from the next-20230905 tag of the linux kernel. Signed-off-by: Hari Nagalla Signed-off-by: Apurva Nandan --- arch/arm/dts/k3-j784s4-evm.dts | 864

Re: [PATCH v2] clk: ti: Notify AVS driver upon setting clock rate

2023-09-19 Thread Kumar, Udit
Hi Nishanth, On 9/19/2023 9:07 PM, Nishanth Menon wrote: On 19:34-20230919, Udit Kumar wrote: AVS is enabled at R5 SPL stage, on few platforms like J721E and J7200 clk-k3 is used instead if clk-sci driver. Add support in clk-k3 driver as well to notify AVS driver upon setting clock rate so

[PATCH] arm64: versal: Add SelectMAP boot mode identification

2023-09-19 Thread Polak, Leszek
Add missing SelectMAP bootmode for proper identification during boot. The SelectMAP configuration interface provides an 8-bit, 16-bit or 32-bit bidirectional data bus interface to the Versal FPGA configuration logic that can be used for both configuration and readback. A connected microcontoller

  1   2   >