Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-11-21 Thread Sughosh Ganu
hi Ilias, On Wed, 22 Nov 2023 at 13:06, Ilias Apalodimas wrote: > > Hi all, > > On Wed, 22 Nov 2023 at 07:23, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Wed, 22 Nov 2023 at 03:42, Simon Glass wrote: > > > > > > Hi Sughosh, > > > > > > On Tue, 21 Nov 2023 at 00:02, Sughosh Ganu > > >

Re: [PATCH 6/7] WIP: efi: Allow helloworld to exit boot services

2023-11-21 Thread Ilias Apalodimas
Hi Simon, On Wed, 22 Nov 2023 at 00:10, Simon Glass wrote: > > Hi Heinrich, > > On Tue, 21 Nov 2023 at 10:17, Heinrich Schuchardt wrote: > > > > On 11/21/23 12:35, Simon Glass wrote: > > > This allows testing of the exit_boot_services call, providing more > > > coverage of the EFI bootmeth. > >

Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-11-21 Thread Ilias Apalodimas
Hi all, On Wed, 22 Nov 2023 at 07:23, Sughosh Ganu wrote: > > hi Simon, > > On Wed, 22 Nov 2023 at 03:42, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Tue, 21 Nov 2023 at 00:02, Sughosh Ganu wrote: > > > > > > Add support for specifying the parameters needed for capsule > > > generation

Re: [PATCH 00/21] Qualcomm generic board support

2023-11-21 Thread Sumit Garg
On Tue, 21 Nov 2023 at 22:39, Caleb Connolly wrote: > > Historically, Qualcomm boards in U-Boot have all had their own > board/qualcomm/xyz directory, their own CONFIG_TARGET_XYZ option, their > own hardcoded sysmap-xyz.c file, and their own U-Boot specific > devicetree with little/no

Re: [PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-21 Thread Ilias Apalodimas
Hi Shahtur On Wed, 22 Nov 2023 at 01:58, Shantur Rathore wrote: > > Currently U-boot uses ESP as storage for EFI variables. > Devices with SPI Flash are used for storing environment with this > commit we allow EFI variables to be stored on SPI Flash. > > Signed-off-by: Shantur Rathore > --- > >

Re: [PATCH 00/21] Qualcomm generic board support

2023-11-21 Thread Sumit Garg
Hi Caleb, On Tue, 21 Nov 2023 at 22:39, Caleb Connolly wrote: > > Historically, Qualcomm boards in U-Boot have all had their own > board/qualcomm/xyz directory, their own CONFIG_TARGET_XYZ option, their > own hardcoded sysmap-xyz.c file, and their own U-Boot specific > devicetree with little/no

Re: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-21 Thread Heiko Schocher
Hello Roger, On 21.11.23 22:56, Roger Quadros wrote: > Hi, > > On 15/11/2023 13:36, Heiko Schocher wrote: >> Hello Roger, >> >> On 15.11.23 12:09, Roger Quadros wrote: >>> >>> >>> On 15/11/2023 07:40, Heiko Schocher wrote: commit 04fcd2587321 ("mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based

Re: [PATCH 2/2] arm: dts: k3-*-binman: Move to using templated FITs

2023-11-21 Thread Neha Malcom Francis
Hi Manorit On 22/11/23 10:50, Manorit Chawdhry wrote: Hi Neha, On 15:40-20231115, Neha Malcom Francis wrote: Reduce redundancy in code by using templates to generate the A72 boot binaries (tispl.bin and u-boot.img) as well as R5 boot binary sysfw.itb (for legacy boot following devices J721E

Re: [PATCH v6 1/2] kbuild: arm64: Add BOOT_TARGETS variable

2023-11-21 Thread Masahiro Yamada
On Mon, Nov 20, 2023 at 12:02 AM Simon Glass wrote: > > Add a new variable containing a list of possible targets. Mark them as > phony. This matches the approach taken for arch/arm > > Signed-off-by: Simon Glass I encounter difficulty in understanding your subject prefix policy. You used

Re: [PATCH v6 2/2] arm64: boot: Support Flat Image Tree

2023-11-21 Thread Masahiro Yamada
On Mon, Nov 20, 2023 at 12:02 AM Simon Glass wrote: > > Add a script which produces a Flat Image Tree (FIT), a single file > containing the built kernel and associated devicetree files. > Compression defaults to gzip which gives a good balance of size and > performance. > > The files compress

Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-11-21 Thread Sughosh Ganu
hi Tom, On Wed, 22 Nov 2023 at 03:54, Tom Rini wrote: > > On Tue, Nov 21, 2023 at 03:11:50PM -0700, Simon Glass wrote: > > Hi Sughosh, > > > > On Tue, 21 Nov 2023 at 00:02, Sughosh Ganu wrote: > > > > > > Add support for specifying the parameters needed for capsule > > > generation through a

Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-11-21 Thread Sughosh Ganu
hi Simon, On Wed, 22 Nov 2023 at 03:42, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 21 Nov 2023 at 00:02, Sughosh Ganu wrote: > > > > Add support for specifying the parameters needed for capsule > > generation through a config file, instead of passing them through > > command-line.

Re: [PATCH 2/2] arm: dts: k3-*-binman: Move to using templated FITs

2023-11-21 Thread Manorit Chawdhry
Hi Neha, On 15:40-20231115, Neha Malcom Francis wrote: > Reduce redundancy in code by using templates to generate the A72 boot > binaries (tispl.bin and u-boot.img) as well as R5 boot binary sysfw.itb > (for legacy boot following devices J721E and AM65x). > > Signed-off-by: Neha Malcom Francis

Re: [PATCH v3 4/5] lib: membuff: fix readline not returning line in case of overflow

2023-11-21 Thread Heinrich Schuchardt
On 11/21/23 19:40, Simon Glass wrote: Hi Svyatoslav, On Tue, 21 Nov 2023 at 11:35, Svyatoslav Ryhel wrote: From: Ion Agorria If line overflows readline it will not be returned, fix this behavior, make it optional and documented properly. Signed-off-by: Ion Agorria Signed-off-by:

Re: [PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-21 Thread AKASHI Takahiro
On Tue, Nov 21, 2023 at 11:57:12PM +, Shantur Rathore wrote: > Currently U-boot uses ESP as storage for EFI variables. > Devices with SPI Flash are used for storing environment with this > commit we allow EFI variables to be stored on SPI Flash. > > Signed-off-by: Shantur Rathore > --- > >

[PATCH 1/1] configs: enable VIDEO_ANSI on EFI app

2023-11-21 Thread Heinrich Schuchardt
The cls command ignores $stdout if CONFIG_VIDEO_ANSI=n. This leads to unexpected output. Signed-off-by: Heinrich Schuchardt --- configs/efi-x86_app32_defconfig | 1 + configs/efi-x86_app64_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/configs/efi-x86_app32_defconfig

Re: [PATCH v1 1/3] efi: filestore: don't compile when config disabled

2023-11-21 Thread AKASHI Takahiro
On Tue, Nov 21, 2023 at 11:57:11PM +, Shantur Rathore wrote: > Compile out filestore functions when config isn't enabled. > > Signed-off-by: Shantur Rathore > --- > > include/efi_variable.h| 21 - > lib/efi_loader/efi_var_file.c | 13 +++-- >

[PATCH v1 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-11-21 Thread Shantur Rathore
RockPro64 uses SPI Flash for storing env, also use it store EFI variables. Signed-off-by: Shantur Rathore --- configs/rockpro64-rk3399_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index

[PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-21 Thread Shantur Rathore
Currently U-boot uses ESP as storage for EFI variables. Devices with SPI Flash are used for storing environment with this commit we allow EFI variables to be stored on SPI Flash. Signed-off-by: Shantur Rathore --- include/efi_variable.h| 25 ++ lib/efi_loader/Kconfig|

[PATCH v1 1/3] efi: filestore: don't compile when config disabled

2023-11-21 Thread Shantur Rathore
Compile out filestore functions when config isn't enabled. Signed-off-by: Shantur Rathore --- include/efi_variable.h| 21 - lib/efi_loader/efi_var_file.c | 13 +++-- lib/efi_loader/efi_variable.c | 10 +- 3 files changed, 28 insertions(+), 16

[PATCH v1 0/3] efi_vars: SPI Flash store

2023-11-21 Thread Shantur Rathore
With this patch series we implement SPI Flash storage for EFI variables. Shantur Rathore (3): efi: filestore: don't compile when config disabled efi_vars: Implement SPI Flash store defconfig: rockpro64: Enable SF EFI var store configs/rockpro64-rk3399_defconfig | 2 +

Re: [UBOOT PATCH v4] test/py: net: Add dhcp abort test

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 06:32:47PM +0530, Love Kumar wrote: > Abort the dhcp request in the middle by pressing ctrl + c on u-boot > prompt and validate the abort status. > > Signed-off-by: Love Kumar Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2] test/py: i2c: Add tests for i2c command

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 05:28:43PM +0530, Love Kumar wrote: > Add below test cases for i2c commands: > i2c_bus - To show i2c bus info, > i2c_dev - To set or show the current bus, > i2c_probe - To probe the i2c device, > i2c_eeprom - To test i2c eeprom device, > i2c_probe_all_buses - To list down

[PATCH v2 3/3] rpi5: initial support

2023-11-21 Thread Dmitry Malkin
rpi5: get_board is no longer works. Print model name from FW FDT rpi5 deprecated some calls/tags for MBOX. Better to use FW FDT. However it does not give all information. Signed-off-by: Dmitry Malkin --- v2: new patch --- board/raspberrypi/rpi/rpi.c | 6 ++ 1 file changed, 6

[PATCH v2 2/3] rpi5: initial support

2023-11-21 Thread Dmitry Malkin
rpi5: add alternative way to get MBOX address via FDT node MBOX on RPI5/bcm2712 has a different offset. Find it via "brcm,bcm2835-mbox" node. Signed-off-by: Dmitry Malkin --- v2: new patch --- arch/arm/mach-bcm283x/include/mach/base.h | 1 + arch/arm/mach-bcm283x/include/mach/mbox.h |

[PATCH v2 1/3] rpi5: initial support

2023-11-21 Thread Dmitry Malkin
rpi5: add initial memory map for bcm2712 includes: * 1GB of RAM (from 4GB or 8GB total) * VPU memory interface * SOC range (main peripherals) Signed-off-by: Dmitry Malkin --- v2: new patch --- arch/arm/mach-bcm283x/init.c | 28 1 file changed, 28

[PATCH v2 0/3] rpi5: initial support

2023-11-21 Thread Dmitry Malkin
These patches bring initial boot support for RPI5. Without it the latest master fails with the message: > DRAM: mbox: Timeout waiting for response > bcm2835: Could not query ARM memory size With those patches and rpi_arm64_defconfig (with disabled CONFIG_VIDEO_BCM2835) I'm able to get a working

Re: [PATCH] test/py: mii: Add tests for mii command

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 02:10:51PM +0530, Love Kumar wrote: > Add below test cases for mii commands: > mii_info -To display MII PHY info > mii_list - To list MII devices > mii_set_device - To set MII device > mii_read - To reads register from MII PHY address > mii_dump - To display data from MII

Re: [PATCH] test/py: mii: Add tests for mii command

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 02:10:51PM +0530, Love Kumar wrote: > Add below test cases for mii commands: > mii_info -To display MII PHY info > mii_list - To list MII devices > mii_set_device - To set MII device > mii_read - To reads register from MII PHY address > mii_dump - To display data from MII

Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 03:11:50PM -0700, Simon Glass wrote: > Hi Sughosh, > > On Tue, 21 Nov 2023 at 00:02, Sughosh Ganu wrote: > > > > Add support for specifying the parameters needed for capsule > > generation through a config file, instead of passing them through > > command-line. Parameters

Re: [PATCH 09/21] configs: add dragonboard410c_chainloaded_defconfig

2023-11-21 Thread Simon Glass
Hi Caleb, On Tue, 21 Nov 2023 at 13:21, Caleb Connolly wrote: > > > > On 21/11/2023 19:08, Tom Rini wrote: > > On Tue, Nov 21, 2023 at 05:09:32PM +, Caleb Connolly wrote: > > > >> Revive support for booting db410c using the Linux kernel header, this > >> allows for testing the board more

Re: [PATCH v2 2/7] acpi: carve out qfw_acpi.c

2023-11-21 Thread Simon Glass
On Tue, 21 Nov 2023 at 08:28, Heinrich Schuchardt wrote: > > Move the code related to copying tables from QEMU to a separate code > module. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > new patch > --- > drivers/misc/Makefile | 1 + > drivers/misc/qfw.c | 240

Re: [PATCH 1/4] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-11-21 Thread Simon Glass
Hi Sughosh, On Tue, 21 Nov 2023 at 00:02, Sughosh Ganu wrote: > > Add support for specifying the parameters needed for capsule > generation through a config file, instead of passing them through > command-line. Parameters for more than a single capsule file can be > specified, resulting in

Re: [PATCH v2 1/7] acpi: Kconfig symbol CONFIG_QFW_ACPI

2023-11-21 Thread Simon Glass
On Tue, 21 Nov 2023 at 08:28, Heinrich Schuchardt wrote: > > We have two implementations of write_acpi_tables(). One for writing ACPI > tables based on ACPI_WRITER() entries another based on copying tables from > QEMU. > > Create a symbol CONFIG_QFW_ACPI that signifies copying ACPI tables from >

Re: [PATCH 1/2] global: Clean up arch/*/dts/Makefile

2023-11-21 Thread Simon Glass
Hi Tom, On Tue, 21 Nov 2023 at 07:03, Tom Rini wrote: > > On Mon, Nov 20, 2023 at 07:16:12PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Sun, 19 Nov 2023 at 13:28, Tom Rini wrote: > > > > > > On Sun, Nov 19, 2023 at 12:09:07PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH 4/7] WIP: efi: Disable ANSI output

2023-11-21 Thread Simon Glass
Hi Heinrich, On Tue, 21 Nov 2023 at 10:32, Heinrich Schuchardt wrote: > > On 11/21/23 12:35, Simon Glass wrote: > > We don't want ANSI characters written in tests since it is a pain to > > check the output. > > I never experienced such pain. The Gitlab output just renders things as > expected. >

Re: [BUG] Video does not work as expected on efi-x86_app64.defconfig

2023-11-21 Thread Simon Glass
Hi Heinrich, On Tue, 21 Nov 2023 at 04:58, Heinrich Schuchardt wrote: > > Hello Simon, > > I have built efi-x86_app64_defconfig on v2024.01-rc3. > > On my laptop the video output appears twice. See >

Re: U-Booters at LPC

2023-11-21 Thread Simon Glass
Hi Sean, On Tue, 14 Nov 2023 at 06:30, Sean Anderson wrote: > > Hi Simon, > > On 11/13/23 15:26, Simon Glass wrote: > > Hi Sean, > > > > On Mon, 13 Nov 2023 at 11:15, Sean Anderson wrote: > >> > >> Hi All, > >> > >> I'm at LPC this week, and I'd love to chat with anyone else who's there > >> in

Re: [PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-21 Thread Simon Glass
On Tue, 21 Nov 2023 at 10:32, Sam Protsenko wrote: > > On Mon, Nov 13, 2023 at 12:01 PM Simon Glass wrote: > > > > > > The 'port_id' seems to be needed for ARCH_EXYNOS4 boards. Because > > > Exynos4 doesn't have proper DM clocks, it uses 'id' property to get > > > corresponding UART clock

Re: [PATCH 3/7] efi: test: Create a disk image with and EFI app in it

2023-11-21 Thread Simon Glass
Hi Heinrich, On Tue, 21 Nov 2023 at 10:37, Heinrich Schuchardt wrote: > > On 11/21/23 12:35, Simon Glass wrote: > > Create a new disk for use with test, which contains the sandbox > > helloworld app. This will be used to test the EFI boot bootmeth. > > > > Signed-off-by: Simon Glass > > --- > >

Re: [PATCH 6/7] WIP: efi: Allow helloworld to exit boot services

2023-11-21 Thread Simon Glass
Hi Heinrich, On Tue, 21 Nov 2023 at 10:17, Heinrich Schuchardt wrote: > > On 11/21/23 12:35, Simon Glass wrote: > > This allows testing of the exit_boot_services call, providing more > > coverage of the EFI bootmeth. > > > > Signed-off-by: Simon Glass > > I would prefer to keep helloworld.efi

Re: [PATCH 7/7] WIP: efi: debugging

2023-11-21 Thread Simon Glass
Hi Heinrich, On Tue, 21 Nov 2023 at 10:20, Heinrich Schuchardt wrote: > > On 11/21/23 12:35, Simon Glass wrote: > > This works when run outside a test: > > > > good: > > > > /tmp/b/sandbox/u-boot -T > > -c "bootfl scan mmc; bootfl sel 1; bootfl list; bootfl b" > > > > ** Booting bootflow

Re: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-21 Thread Roger Quadros
Hi, On 15/11/2023 13:36, Heiko Schocher wrote: > Hello Roger, > > On 15.11.23 12:09, Roger Quadros wrote: >> >> >> On 15/11/2023 07:40, Heiko Schocher wrote: >>> commit 04fcd2587321 ("mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based >>> correction") >>> >>> broke AM335x based boards booting from

Re: [PATCH 1/1] efi_loader: generated SMBIOS table below 4 GiB

2023-11-21 Thread Ilias Apalodimas
Hi Heinrich, On Tue, 21 Nov 2023 at 00:33, Heinrich Schuchardt wrote: > > We currently use an outdated format 32-bit format for SMBIOS tables. > So we must allocate SMBIOS tables below 4 GiB. Can we please adjust the commit message to something that would represent the situation better 6 months

Re: [PATCH v3] smbios: arm64: Ensure table is written at a good address

2023-11-21 Thread Ilias Apalodimas
Hi Simon, On Tue, 21 Nov 2023 at 04:58, Simon Glass wrote: > > U-Boot typically sets up its malloc() pool near the top of memory. On > ARM64 systems this can result in an SMBIOS table above 4GB which is > not supported by SMBIOSv2. > > Work around this problem by automatically choosing an

Re: [PATCH v2 3/6] smbios: Use SMBIOS 3.0 to support an address above 4GB

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 10:40:39PM +0200, Ilias Apalodimas wrote: > Hi Simon > > On Tue, 21 Nov 2023 at 04:17, Simon Glass wrote: > > > > Hi Heinrich, > > > > On Mon, 20 Nov 2023 at 19:11, Heinrich Schuchardt > > wrote: > > > > > > On 10/15/23 04:45, Simon Glass wrote: > > > > When the SMBIOS

Re: [PATCH 14/21] mach-snapdragon: dynamic load addresses

2023-11-21 Thread Caleb Connolly
On 21/11/2023 19:24, Tom Rini wrote: > On Tue, Nov 21, 2023 at 05:09:37PM +, Caleb Connolly wrote: > >> Heavily inspired by Apple board code. Use the LMB allocator to configure >> load addresses at runtime, and implement a lookup table for selecting a >> devicetree. >> >> As some Qualcomm

Re: [PATCH v2 3/6] smbios: Use SMBIOS 3.0 to support an address above 4GB

2023-11-21 Thread Ilias Apalodimas
Hi Simon On Tue, 21 Nov 2023 at 04:17, Simon Glass wrote: > > Hi Heinrich, > > On Mon, 20 Nov 2023 at 19:11, Heinrich Schuchardt wrote: > > > > On 10/15/23 04:45, Simon Glass wrote: > > > When the SMBIOS table is written to an address above 4GB a 32-bit table > > > address is not large enough.

Re: [PATCH v2 2/3] efi: Correct display of table GUIDs

2023-11-21 Thread Ilias Apalodimas
On Sun, 12 Nov 2023 at 22:55, Simon Glass wrote: > > The printf() %pU option decodes GUIDs so it is not necessary to do this > first. Drop the incorrect code. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > cmd/efi_common.c | 4 +--- > 1 file changed, 1 insertion(+), 3

Re: [PATCH v2 7/7] configs: qemu: add config fragment for ACPI

2023-11-21 Thread Ilias Apalodimas
On Tue, 21 Nov 2023 at 17:28, Heinrich Schuchardt wrote: > > Provide a configuration fragment to enable ACPI on QEMU. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > new patch > --- > MAINTAINERS | 1 + > board/emulation/configs/acpi.config | 3 +++ >

Re: [PATCH 02/21] arm: allow CONFIG_LINUX_KERNEL_IMAGE_HEADER to be set in defconfig

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 08:17:30PM +, Caleb Connolly wrote: > > > On 21/11/2023 19:07, Tom Rini wrote: > > On Tue, Nov 21, 2023 at 05:09:25PM +, Caleb Connolly wrote: > > > >> Let this option be enabled dynamically for boards that support multiple > >> mechanisms for booting U-Boot

Re: [PATCH 1/7] efi: Use puts() in cout so that console recording works

2023-11-21 Thread Ilias Apalodimas
On Tue, 21 Nov 2023 at 13:36, Simon Glass wrote: > > At present EFI output to the console use fputs() which bypasses the nit, use ->uses > console-recording feature. This makes it impossible for tests to check > the output of an EFI app. > > There doesn't seem to be any need to do this bypass,

Re: [PATCH 09/21] configs: add dragonboard410c_chainloaded_defconfig

2023-11-21 Thread Caleb Connolly
On 21/11/2023 19:08, Tom Rini wrote: > On Tue, Nov 21, 2023 at 05:09:32PM +, Caleb Connolly wrote: > >> Revive support for booting db410c using the Linux kernel header, this >> allows for testing the board more easily via `fastboot`. >> >> Signed-off-by: Caleb Connolly >> --- >>

Re: [PATCH 02/21] arm: allow CONFIG_LINUX_KERNEL_IMAGE_HEADER to be set in defconfig

2023-11-21 Thread Caleb Connolly
On 21/11/2023 19:07, Tom Rini wrote: > On Tue, Nov 21, 2023 at 05:09:25PM +, Caleb Connolly wrote: > >> Let this option be enabled dynamically for boards that support multiple >> mechanisms for booting U-Boot (e.g. as a first-stage or chainloaded >> bootloader). >> >> Signed-off-by: Caleb

RE: [PATCH v7 2/2] schemas: Add some common reserved-memory usages

2023-11-21 Thread Chiu, Chasel
In PR, UefiPayloadPkg/Library/FdtParserLib/FdtParserLib.c, line 268 is for related example code. Thanks, Chasel > -Original Message- > From: Chiu, Chasel > Sent: Tuesday, November 21, 2023 10:34 AM > To: Ard Biesheuvel ; Simon Glass > Cc: devicet...@vger.kernel.org; Mark Rutland ;

RE: [PATCH v7 2/2] schemas: Add some common reserved-memory usages

2023-11-21 Thread Chiu, Chasel
Hi Ard, Here is the POC PR for your reference: https://github.com/tianocore/edk2/pull/4969/files#diff-ccebabae5274b21634723a2111ee0de11bed6cfe8cb206ef9e263d9c5f926a9cR268 Please note that this PR is still in early phase and expected to have significant changes. The idea is that payload entry

[PATCH 19/21] dts: msm8996: import DT from Linux

2023-11-21 Thread Caleb Connolly
Drop in msm8996.dtsi, pm8994.dtsi, and associated headers. Adjust dragonboard820c.dts to work properly, and fix the clock driver. Signed-off-by: Caleb Connolly --- arch/arm/dts/dragonboard820c-uboot.dtsi| 32 - arch/arm/dts/dragonboard820c.dts | 130 +-

Re: [PATCH v2 1/7] acpi: Kconfig symbol CONFIG_QFW_ACPI

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 08:30:34PM +0100, Heinrich Schuchardt wrote: > On 11/21/23 20:00, Tom Rini wrote: > > On Tue, Nov 21, 2023 at 04:27:34PM +0100, Heinrich Schuchardt wrote: > > > > > We have two implementations of write_acpi_tables(). One for writing ACPI > > > tables based on ACPI_WRITER()

Re: Licensing discrepancies or ambiguities

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 11:10:57AM -0800, Vagrant Cascadian wrote: > I've been reviewing the copyright and license information for Das U-Boot > in preparation for uploading to Debian, and found a few surprises. > > tools/libfdt/fdt_rw.c: /* SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause */

Re: [PATCH 21/21] MAINTAINERS: Qualcomm: add some missing paths

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 05:09:44PM +, Caleb Connolly wrote: > Add board/qualcomm and the SoC/PMIC DTSI files. > Adjust the driver paths to use globs rather than hardcoding every > specific driver. > > Signed-off-by: Caleb Connolly [snip] > +F: arch/arm/dts/msm8*.dtsi > +F:

Re: [PATCH v2 1/7] acpi: Kconfig symbol CONFIG_QFW_ACPI

2023-11-21 Thread Heinrich Schuchardt
On 11/21/23 20:00, Tom Rini wrote: On Tue, Nov 21, 2023 at 04:27:34PM +0100, Heinrich Schuchardt wrote: We have two implementations of write_acpi_tables(). One for writing ACPI tables based on ACPI_WRITER() entries another based on copying tables from QEMU. Create a symbol CONFIG_QFW_ACPI

Re: [PATCH 14/21] mach-snapdragon: dynamic load addresses

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 05:09:37PM +, Caleb Connolly wrote: > Heavily inspired by Apple board code. Use the LMB allocator to configure > load addresses at runtime, and implement a lookup table for selecting a > devicetree. > > As some Qualcomm RBx boards have different RAM capacities and

Re: [PATCH 18/21] dts: msm8916: import DT from Linux

2023-11-21 Thread Stephan Gerhold
On Tue, Nov 21, 2023 at 05:09:41PM +, Caleb Connolly wrote: > Import the msm8916 devicetree from Linux and adjust the dragonboard410c > devicetree to use it. > Can you add a note here from which Linux version you took the DT? It seems quite old, the msm8916-pm8916.dtsi doesn't exist anymore

Licensing discrepancies or ambiguities

2023-11-21 Thread Vagrant Cascadian
I've been reviewing the copyright and license information for Das U-Boot in preparation for uploading to Debian, and found a few surprises. tools/libfdt/fdt_rw.c: /* SPDX-License-Identifier: GPL-2.0+ BSD-2-Clause */ I *think* according to the SPDX spec this needs an OR or an AND. I also see no

Re: [PATCH 09/21] configs: add dragonboard410c_chainloaded_defconfig

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 05:09:32PM +, Caleb Connolly wrote: > Revive support for booting db410c using the Linux kernel header, this > allows for testing the board more easily via `fastboot`. > > Signed-off-by: Caleb Connolly > --- > board/qualcomm/dragonboard410c/MAINTAINERS| 1 + >

Re: [PATCH 02/21] arm: allow CONFIG_LINUX_KERNEL_IMAGE_HEADER to be set in defconfig

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 05:09:25PM +, Caleb Connolly wrote: > Let this option be enabled dynamically for boards that support multiple > mechanisms for booting U-Boot (e.g. as a first-stage or chainloaded > bootloader). > > Signed-off-by: Caleb Connolly > --- > This patch has no dependencies

Re: [PATCH 01/21] arm: init: export prev_bl_fdt_addr

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 05:09:24PM +, Caleb Connolly wrote: > When booting U-Boot on board with a locked down first-stage bootloader, > we emulate the Linux boot header. By passing the U-Boot FDT through this > first-stage bootloader and retrieving it afterwards we can pre-populate > the

Re: [PATCH v2 2/7] acpi: carve out qfw_acpi.c

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 04:27:35PM +0100, Heinrich Schuchardt wrote: > Move the code related to copying tables from QEMU to a separate code > module. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/7] acpi: Kconfig symbol CONFIG_QFW_ACPI

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 04:27:34PM +0100, Heinrich Schuchardt wrote: > We have two implementations of write_acpi_tables(). One for writing ACPI > tables based on ACPI_WRITER() entries another based on copying tables from > QEMU. > > Create a symbol CONFIG_QFW_ACPI that signifies copying ACPI

Re: [PATCH v3 4/5] lib: membuff: fix readline not returning line in case of overflow

2023-11-21 Thread Simon Glass
Hi Svyatoslav, On Tue, 21 Nov 2023 at 11:35, Svyatoslav Ryhel wrote: > > From: Ion Agorria > > If line overflows readline it will not be returned, fix this behavior, > make it optional and documented properly. > > Signed-off-by: Ion Agorria > Signed-off-by: Svyatoslav Ryhel > Reviewed-by:

[PATCH v3 5/5] fastboot: add oem console command support

2023-11-21 Thread Svyatoslav Ryhel
From: Ion Agorria "oem console" serves to read console record buffer. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek --- doc/android/fastboot.rst | 1 + drivers/fastboot/Kconfig | 7 +++ drivers/fastboot/fb_command.c | 39

[PATCH v3 3/5] common: console: introduce overflow and isempty calls

2023-11-21 Thread Svyatoslav Ryhel
From: Ion Agorria Separate record overflow logic and add console_record_isempty as available calls don't serve to know output has been read fully with readline's. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek --- common/console.c | 15

[PATCH v3 4/5] lib: membuff: fix readline not returning line in case of overflow

2023-11-21 Thread Svyatoslav Ryhel
From: Ion Agorria If line overflows readline it will not be returned, fix this behavior, make it optional and documented properly. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek --- boot/bootmeth_extlinux.c | 2 +- common/console.c | 2 +-

[PATCH v3 2/5] fastboot: implement "getvar all"

2023-11-21 Thread Svyatoslav Ryhel
From: Ion Agorria This commit implements "fastboot getvar all" listing by iterating the existing dispatchers that don't require parameters (as we pass NULL), uses fastboot multiresponse. Signed-off-by: Ion Agorria Signed-off-by: Svyatoslav Ryhel Reviewed-by: Mattijs Korpershoek ---

[PATCH v3 1/5] fastboot: multiresponse support

2023-11-21 Thread Svyatoslav Ryhel
From: Ion Agorria Currently u-boot fastboot can only send one message back to host, so if there is a need to print more than one line messages must be kept sending until all the required data is obtained. This behavior can be adjusted using multiresponce ability (getting multiple lines of

[PATCH v3 0/5] Implement fastboot multiresponce

2023-11-21 Thread Svyatoslav Ryhel
Currently u-boot fastboot can only send one message back to host, so if there is a need to print more than one line messages must be kept sending until all the required data is obtained. This behavior can be adjusted using multiresponce ability (getting multiple lines of response) proposed in this

Re: [PATCH v2 1/5] cyclic: Add a symbol for SPL

2023-11-21 Thread Tom Rini
On Tue, Nov 21, 2023 at 09:20:39AM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 21 Nov 2023 at 06:06, Tom Rini wrote: > > > > On Mon, Nov 20, 2023 at 07:09:25PM -0700, Simon Glass wrote: > > > > > The cyclic subsystem is currently enabled either in all build phases > > > or none. For tools

Re: [PATCH 2/7] efi: Show the vendor in helloworld

2023-11-21 Thread Heinrich Schuchardt
On 11/21/23 12:35, Simon Glass wrote: Show the vendor name since it useful to see that. With this commit message it remains unclear why displaying the constant value (u"Das U-Boot") is of any value. Best regards Heinrich Signed-off-by: Simon Glass --- lib/efi_loader/helloworld.c | 3

Re: [PATCH 1/7] efi: Use puts() in cout so that console recording works

2023-11-21 Thread Heinrich Schuchardt
On 11/21/23 12:35, Simon Glass wrote: At present EFI output to the console use fputs() which bypasses the console-recording feature. This makes it impossible for tests to check the output of an EFI app. There doesn't seem to be any need to do this bypass, so adjust it to simply use the puts()

Re: [PATCH 02/29] mmc: env: Unify the U_BOOT_ENV_LOCATION conditions

2023-11-21 Thread Tom Rini
On Sun, Nov 19, 2023 at 07:49:32AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Wed, 15 Nov 2023 at 03:02, Heinrich Schuchardt wrote: > > > > On 11/12/23 01:08, Simon Glass wrote: > > > The declaration of U_BOOT_ENV_LOCATION() uses a different #ifdef > > > condition from the code it calls.

Re: [RFC PATCH 0/2] rpi5: initial support

2023-11-21 Thread Tom Rini
On Sat, Nov 18, 2023 at 05:41:34PM +0100, Dmitry Malkin wrote: > I was not able to boot rpi5 with the latest master. I run into > dram_init() error: > > DRAM: mbox: Timeout waiting for response > > bcm2835: Could not query ARM memory size > > Apparently there is a new peripheral layout and ARMC

Re: [PATCH 0/4] serial: s5p: Cleanups

2023-11-21 Thread Sam Protsenko
On Tue, Nov 7, 2023 at 1:06 PM Sam Protsenko wrote: > > A small collection of cleanup patches for serial_s5p.c driver. Should > induce no functional changes. > > Sam Protsenko (4): > serial: s5p: Remove common.h inclusion > serial: s5p: Use livetree API to get "id" property > serial: s5p:

Re: [PATCH v2 1/2] board: samsung: Fix SYS_CONFIG_NAME configs in axy17lte Kconfig

2023-11-21 Thread Sam Protsenko
Hi Tom, Minkyu, On Thu, Nov 9, 2023 at 2:13 PM Sam Protsenko wrote: > > There is a couple of issues related to SYS_CONFIG_NAME config in > axy17lte Kconfig. > > 1. The global SYS_CONFIG_NAME in axy17lte Kconfig overrides >SYS_CONFIG_NAME for all boards specified after this line in >

Re: [PATCH 2/4] serial: s5p: Use livetree API to get "id" property

2023-11-21 Thread Sam Protsenko
On Mon, Nov 13, 2023 at 12:01 PM Simon Glass wrote: > > > > The 'port_id' seems to be needed for ARCH_EXYNOS4 boards. Because > > Exynos4 doesn't have proper DM clocks, it uses 'id' property to get > > corresponding UART clock frequency from its mach code. > > > > Here is what's happening in the

Re: [PATCH 3/7] efi: test: Create a disk image with and EFI app in it

2023-11-21 Thread Heinrich Schuchardt
On 11/21/23 12:35, Simon Glass wrote: Create a new disk for use with test, which contains the sandbox helloworld app. This will be used to test the EFI boot bootmeth. Signed-off-by: Simon Glass --- test/py/tests/test_ut.py | 32 1 file changed, 32

Re: [PATCH 4/7] WIP: efi: Disable ANSI output

2023-11-21 Thread Heinrich Schuchardt
On 11/21/23 12:35, Simon Glass wrote: We don't want ANSI characters written in tests since it is a pain to check the output. I never experienced such pain. The Gitlab output just renders things as expected. For now, don't bother checking the console size. A better solution is need, which

Re: [PATCH 7/7] WIP: efi: debugging

2023-11-21 Thread Heinrich Schuchardt
On 11/21/23 12:35, Simon Glass wrote: This works when run outside a test: good: /tmp/b/sandbox/u-boot -T -c "bootfl scan mmc; bootfl sel 1; bootfl list; bootfl b" ** Booting bootflow 'mmc7.bootdev.part_1' with efi desc = 18c86ee0 dev=mmc, devnr=7:1, path=efi/boot/bootsbox.efi,

Re: [PATCH 6/7] WIP: efi: Allow helloworld to exit boot services

2023-11-21 Thread Heinrich Schuchardt
On 11/21/23 12:35, Simon Glass wrote: This allows testing of the exit_boot_services call, providing more coverage of the EFI bootmeth. Signed-off-by: Simon Glass I would prefer to keep helloworld.efi benign. Please, create a new EFI binary for testing ExitBootServices(). ---

[PATCH 21/21] MAINTAINERS: Qualcomm: add some missing paths

2023-11-21 Thread Caleb Connolly
Add board/qualcomm and the SoC/PMIC DTSI files. Adjust the driver paths to use globs rather than hardcoding every specific driver. Signed-off-by: Caleb Connolly --- MAINTAINERS | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 20/21] dts: qcs404-evb: import DT from Linux

2023-11-21 Thread Caleb Connolly
Following the other boards, pull in the SoC and PMIC DTSI files from Linux and adjust the board to use it. Some U-Boot specific adjustments are still needed, so we can't use fully upstream DT quite yet. Signed-off-by: Caleb Connolly --- arch/arm/dts/pms405.dtsi | 149

[PATCH 18/21] dts: msm8916: import DT from Linux

2023-11-21 Thread Caleb Connolly
Import the msm8916 devicetree from Linux and adjust the dragonboard410c devicetree to use it. Signed-off-by: Caleb Connolly --- arch/arm/dts/dragonboard410c-uboot.dtsi | 44 - arch/arm/dts/dragonboard410c.dts| 198 +- arch/arm/dts/msm8916-pins.dtsi |

[PATCH 16/21] doc: board/qualcomm: document generic targets

2023-11-21 Thread Caleb Connolly
Replace the board specific docs with a generic board.rst file which documents the build/boot process for the sdm845 and qcs404 boards now that the only differences are the DTB in use. At the same time, create a debugging page to document some useful snippets and tips for working with Qualcomm

[PATCH 15/21] mach-snapdragon: generate fdtfile automatically

2023-11-21 Thread Caleb Connolly
With just a few basic rules, we can generate the $fdtfile environment variable to match the format used in Linux. This uses the root compatible property inside u-boot, with specific handling for the Dragonboard845c which is a special case, and for the qrb robotics boards. This is known to work on

[PATCH 14/21] mach-snapdragon: dynamic load addresses

2023-11-21 Thread Caleb Connolly
Heavily inspired by Apple board code. Use the LMB allocator to configure load addresses at runtime, and implement a lookup table for selecting a devicetree. As some Qualcomm RBx boards have different RAM capacities and base addresses, it isn't possible to hardcode these regions. Signed-off-by:

[PATCH 13/21] mach-snapdragon: generalise board support

2023-11-21 Thread Caleb Connolly
Historically, Qualcomm boards have relied on heavy hardcoding in U-Boot, in many cases to the specific SoC but also to the board itself (e.g. memory map). This has been largely resolved by modernising the Qualcomm drivers in U-Boot, however the board code still largely follows this model. This

[PATCH 12/21] board: dragonboard820c: use LINUX_KERNEL_IMAGE_HEADER

2023-11-21 Thread Caleb Connolly
db820c predated support for prepending the kernel image header automatically, drop it's custom linker script and head.S in favour of this generic support. Signed-off-by: Caleb Connolly --- arch/arm/mach-snapdragon/Kconfig | 1 + board/qualcomm/dragonboard820c/Makefile | 1 -

[PATCH 11/21] board: dragonboard410c: import board code from mach-snapdragon

2023-11-21 Thread Caleb Connolly
Some of the db410c board support code was written to be generic and placed in mach-snapdragon. However, as the db410c is the only board using this, move the code out of mach-snapdragon. This makes is more obvious what code is relevant for which targets and helps tidy things up a little more.

[PATCH 10/21] dts: dragonboard410c: fix compatible and clocks

2023-11-21 Thread Caleb Connolly
Use the root compatible strings from upstream Linux, add missing '#clock-cells' property to the gcc node. Adjust some of the msm8916/apq8016 drivers to use the correct upstream compatible properties and DT bindings. Signed-off-by: Caleb Connolly --- arch/arm/dts/dragonboard410c.dts

[PATCH 08/21] serial: msm: fix clock handling

2023-11-21 Thread Caleb Connolly
Use the modern helpers to fetch the clock and use the correct property ("clocks" instead of "clock") Signed-off-by: Caleb Connolly --- arch/arm/dts/dragonboard410c.dts | 3 ++- arch/arm/dts/dragonboard820c.dts | 3 ++- drivers/serial/serial_msm.c | 24 +--- 3 files

[PATCH 09/21] configs: add dragonboard410c_chainloaded_defconfig

2023-11-21 Thread Caleb Connolly
Revive support for booting db410c using the Linux kernel header, this allows for testing the board more easily via `fastboot`. Signed-off-by: Caleb Connolly --- board/qualcomm/dragonboard410c/MAINTAINERS| 1 + configs/dragonboard410c_chainloaded_defconfig | 75 +++

  1   2   >