Re: efi: Set Variable Runtime implementation

2023-11-26 Thread Ilias Apalodimas
Hi Shantur On Sun, 26 Nov 2023 at 12:33, Shantur Rathore wrote: > > Hi Peter, > > On Sat, Nov 25, 2023 at 6:19 AM Peter Robinson wrote: > > > > Hi Shantur, > > > > On Fri, Nov 24, 2023 at 11:55 PM Shantur Rathore wrote: > > > > > > Hi Ilias, > > > > > > On Fri, Nov 24, 2023 at 10:50 PM Ilias

Re: [PATCH v1 2/3] efi_vars: Implement SPI Flash store

2023-11-26 Thread Ilias Apalodimas
Hi Shantur Please don't send a v2 unless the v1 discussion has settled. It just makes life harder. I'll ignore v2 for now and respond here. [...] > > > > > > + if (ret) > > > + goto error; > > > + > > > + ret = spi_flash_erase_dm(sfdev, CONFIG_EFI_VARIABLE_SF_OFFSET,

Re: [PATCH 1/1] i2c: Bugfix in i2c_get_chip_by_phandle()

2023-11-26 Thread Heiko Schocher
Hello Philip, On 24.11.23 15:04, Philip Oberfichtner wrote: > The "i2cbcdev" sneaked in when implementing this function for the > bootcounter use case. Obviously the intention was to use prop_name > instead. > > Fixes: b483552773 (i2c: Implement i2c_get_chip_by_phandle()) > > Signed-off-by:

Re: [PATCH] usb: xhci: Replace terrible formatting with different terrible formatting

2023-11-26 Thread Hector Martin
On 2023/11/23 8:50, Marek Vasut wrote: > Replace one type of terrible code formatting with a different > type of terrible code formatting. No functional change. > > Signed-off-by: Marek Vasut > --- > Cc: Bin Meng > Cc: Hector Martin > --- > drivers/usb/host/xhci-ring.c | 18 +++---

Re: [PATCH] maintainers: rk3399: remove maintainer

2023-11-26 Thread Kever Yang
On 2023/11/24 20:04, Shantur Rathore wrote: Remove Akash Gajjar from MAINTAINERS as email is bouncing. Signed-off-by: Shantur Rathore Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/rockpro64_rk3399/MAINTAINERS | 1 - board/rockchip/evb_rk3399/MAINTAINERS | 1 - 2

[PATCH] watchdog: Correct watchdog timeout print message

2023-11-26 Thread Chanho Park
The wdt_start function takes timeout_ms as a parameter and starts the watchdog with this value. However, when you output the message, it shows the default timeout value for the watchdog device. So this patch fixes that part to output the correct timeout value. Before --> StarFive # wdt start 3000

Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

2023-11-26 Thread Fabio Estevam
Hi Benjamin, On Sun, Nov 26, 2023 at 8:17 PM Szőke Kálmán Benjamin wrote: > > It can happen when will -Wall be enabled as in others SW projects. My patches > are final, ready and works. I will not remove this "supression", it must be a > part of it if the target is to provide code in good

Re: [PATCH] net: designware: Support high memory nodes

2023-11-26 Thread Andre Przywara
On Sun, 26 Nov 2023 16:58:52 +0100 Nils Le Roux wrote: Hi Nils, (adding back the list) > Hi Andre, > > Thank you for the code review and spot-on comments. I'll send a revised > patch soon. In the meantime, I have some silly questions regarding your > first point, please see below: > > On

Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

2023-11-26 Thread Szőke Kálmán Benjamin
It can happen when will -Wall be enabled as in others SW projects. My patches are final, ready and works. I will not remove this "supression", it must be a part of it if the target is to provide code in good quality. If you have any further whishes you can edit my patch and you can be a

[PATCH v3 3/3] defconfig: rockpro64: Enable SF EFI var store

2023-11-26 Thread Shantur Rathore
RockPro64 uses SPI Flash for storing env, also use it store EFI variables. Signed-off-by: Shantur Rathore --- configs/rockpro64-rk3399_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index

[PATCH v3 1/3] efi_var_file: refactor to move buffer functions

2023-11-26 Thread Shantur Rathore
Currently efi_var_file.c has functions to store/read EFI variables to/from memory buffer. These functions can be used with other EFI variable stores so move them out to efi_var_common.c Signed-off-by: Shantur Rathore --- (no changes since v1) include/efi_variable.h | 5 ++

[PATCH v3 2/3] efi_vars: Implement SPI Flash store

2023-11-26 Thread Shantur Rathore
Currently U-boot uses ESP as storage for EFI variables. Devices with SPI Flash are used for storing environment with this commit we allow EFI variables to be stored on SPI Flash. Signed-off-by: Shantur Rathore --- (no changes since v1) include/efi_variable.h| 21

[PATCH v3 0/3] With this patch series we implement SPI Flash storage for EFI

2023-11-26 Thread Shantur Rathore
variables. Changes in v3: - Fixed compiler warnings. Changes in v2: - Refactored efi_var_file to move common parts out as requested - Changed ifdefs to use CONFIG_IS_DEFINED - Fixed typos Shantur Rathore (3): efi_var_file: refactor to move buffer functions efi_vars: Implement SPI Flash

[PATCH] rockchip: rk3328: Set efuse auto mode and timing control

2023-11-26 Thread Jonas Karlman
Reading from efuse return zero when mainline TF-A is used. => dump_efuse : 00 00 00 00 0004: 00 00 00 00 0008: 00 00 00 00 000c: 00 00 00 00 0010: 00 00 00 00 0014: 00 00 00 00 0018: 00 00 00 00 001c:

Re: [PATCH 3/3] sunxi: H616: Add OrangePi Zero 3 board support

2023-11-26 Thread Mikhail Kalashnikov
On 26.11.2023 03:23, Andre Przywara wrote: Hi Andre, On Sat, 25 Nov 2023 20:43:12 +0300 Mikhail Kalashnikov wrote: Hi Mikhail, Hi Andre! Thanks for your patches. I started checking and noticed that USB storage was not working: => usb reset resetting USB... Bus usb@520: USB EHCI 1.00 Bus

Re: [PATCH] mtd: nand: omap_gpmc: Fix NAND in SPL for AM335x

2023-11-26 Thread Tom Rini
On Sat, Nov 25, 2023 at 01:16:05PM +0200, Roger Quadros wrote: > AM335x uses a special driver "am335x_spl_bch.c" as SPL > NAND loader. This driver expects 1 sector at a time ECC > and doesn't work well with multi-sector ECC that was implemented in > commit 04fcd2587321 ("mtd: rawnand: omap_gpmc:

[PATCH] sunxi: H616: OrangePi Zero 2: enable USB power supply

2023-11-26 Thread Andre Przywara
The OrangePi Zero 2 has a USB VBUS regulator, controlled by pin PC16. This is correctly described in the DT, but the patches for supporting this are still pending. Meanwhile add our good old CONFIG_USB1_VBUS_PIN to the defconfig file, to enable power on the USB port and allow using a USB flash

Re: efi: Set Variable Runtime implementation

2023-11-26 Thread Peter Robinson
Hi Shantur, > > > > > I am trying to work out how to enable the SetVariableRT service in > > > > > U-Boot and came across your patch [1] which initially had the > > > > > SetVariable RT service enabled in EFI but in the final patch this was > > > > > removed. > > > > > I am hoping to implement it

Re: Adding support for Orange Pi Zero 3

2023-11-26 Thread Jernej Škrabec
Dne nedelja, 26. november 2023 ob 13:33:51 CET je Andre Przywara napisal(a): > On Sun, 26 Nov 2023 11:32:35 + > Bob McChesney wrote: > > Hi Bob, > > thanks for the reply! > > CC:ing Jernej for the THS SRAM issue and the HDMI support mentioned > below. > > > On Thu, Nov 23, 2023 at

Re: Adding support for Orange Pi Zero 3

2023-11-26 Thread Bob McChesney
On Sun, Nov 26, 2023 at 12:33:51PM +, Andre Przywara wrote: > On Sun, 26 Nov 2023 11:32:35 + > Bob McChesney wrote: > > Hi Bob, > > thanks for the reply! > > > Now that there's a working u-boot for the board - I've got two to choose > > from now :) - I'm going to be concentrating on

Re: Adding support for Orange Pi Zero 3

2023-11-26 Thread Andre Przywara
On Sun, 26 Nov 2023 11:32:35 + Bob McChesney wrote: Hi Bob, thanks for the reply! CC:ing Jernej for the THS SRAM issue and the HDMI support mentioned below. > On Thu, Nov 23, 2023 at 03:17:09PM +, Andre Przywara wrote: > > On Sat, 4 Nov 2023 19:17:44 + > > electricworry wrote: >

Re: [PATCH 3/3] sunxi: H616: Add OrangePi Zero 3 board support

2023-11-26 Thread Andre Przywara
On Sat, 25 Nov 2023 20:27:05 -0800 Stephen Graf wrote: Hi Stephen, > I built u-boot with the additional parameter for usb and it works, I think. > There was one message that might be of concern " > Card did not respond to voltage select! : -110". This is a normal, though admittedly confusing

Re: [PATCH 3/3] sunxi: H616: Add OrangePi Zero 3 board support

2023-11-26 Thread Bob McChesney
On Sat, Nov 25, 2023 at 08:43:12PM +0300, Mikhail Kalashnikov wrote: > Tested-by: Mikhail Kalashnikov > > On 14.11.2023 04:31, Andre Przywara wrote: > > The OrangePi Zero 3 is a small development board featuring the Allwinner > > H618 SoC, shipping with up to 4GB of DRAM, Gigabit Ethernet, a

Re: Adding support for Orange Pi Zero 3

2023-11-26 Thread Bob McChesney
On Thu, Nov 23, 2023 at 03:17:09PM +, Andre Przywara wrote: > On Sat, 4 Nov 2023 19:17:44 + > electricworry wrote: > > Hi, > > > I would like to contribute improvements u-boot to enable support for > > the Orange Pi Zero 3 board. I have already gained a good understanding > > of the

Re: efi: Set Variable Runtime implementation

2023-11-26 Thread Shantur Rathore
Hi Peter, On Sat, Nov 25, 2023 at 6:19 AM Peter Robinson wrote: > > Hi Shantur, > > On Fri, Nov 24, 2023 at 11:55 PM Shantur Rathore wrote: > > > > Hi Ilias, > > > > On Fri, Nov 24, 2023 at 10:50 PM Ilias Apalodimas > > wrote: > > > > > > Hi Shantur > > > > > > On Fri, 24 Nov 2023 at 18:51,