Re: [PATCH 7/7] verdin-imx8mp_defconfig: Enable PCIe/NVMe support

2024-02-22 Thread Francesco Dolcini
On Wed, Feb 21, 2024 at 11:57:51AM +0530, Sumit Garg wrote: > On Tue, 20 Feb 2024 at 21:02, Marek Vasut wrote: > > On 2/20/24 14:10, Sumit Garg wrote: > > > Also, enable reset driver which is a prerequisite for PCIe support. > > Commit message needs to be fixed. > > Let me reiterate the header

Re: [RESEND PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Michal Simek
On 2/22/24 21:05, Sean Anderson wrote: Currently, when we boot from JTAG we try to boot U-Boot from RAM. However, this is a bit tricky to time, since the debugger has to wait for SPL to initialize RAM before it can load U-Boot. This can result in long waits, since occasionally initializing

Re: [PATCH v8 5/8] arm: armv8: save boot arguments

2024-02-22 Thread Ilias Apalodimas
On Sat, 3 Feb 2024 at 18:38, Raymond Mao wrote: > > Save boot arguments x[0-3] into an array for handover of bloblist from > previous boot stage. > > Signed-off-by: Raymond Mao > Suggested-by: Ard Biesheuvel > --- > Changes in v2 > - New patch file created for v2. > Changes in V5 > - Drop the

Re: [PATCH v8 4/8] arm: armv7: save boot arguments

2024-02-22 Thread Ilias Apalodimas
On Sat, 3 Feb 2024 at 18:37, Raymond Mao wrote: > > Save boot arguments r[0-3] into an array for handover of bloblist from > previous boot stage. > > Signed-off-by: Raymond Mao > Suggested-by: Ard Biesheuvel > --- > Changes in v2 > - New patch file created for v2. > Changes in v3 > - Swap value

[PATCH 2/2] arm: mach-k3: j721e: Enable OSPI boot

2024-02-22 Thread Jonathan Humphreys
Add boot ROM XSPI bootmode, and set to BOOT_DEVICE_SPI if detected. Signed-off-by: Jonathan Humphreys --- arch/arm/mach-k3/include/mach/j721e_spl.h | 5 +++-- arch/arm/mach-k3/j721e_init.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] Enable OSPI on j721e

2024-02-22 Thread Jonathan Humphreys
This series enables OSPI storage and boot. fixes: 58d61fb5a77ef31f6aa5973b3ef9650c92edf5ed ("arm: dts: k3-j721e-sk: Add initial A72 specific dts support") Jonathan Humphreys (2): configs: j721e: Enable OSPI memory arm: mach-k3: j721e: Enable OSPI boot

[PATCH 1/2] configs: j721e: Enable OSPI memory

2024-02-22 Thread Jonathan Humphreys
Set config values to enable OSPI functionality. Signed-off-by: Jonathan Humphreys --- configs/j721e_evm_a72_defconfig | 7 +++ configs/j721e_evm_r5_defconfig | 6 ++ 2 files changed, 13 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index

Re: [PATCH] Check curve_name for null to avoid crash

2024-02-22 Thread Sean Anderson
On 2/22/24 17:18, Bob Wolff wrote: If mixed rsa and ecdsa keys are specified in dtsi, an rsa key can be sent into the ecdsa verify. Without the ecdsa,curve property, this function will crash due to lack of checking the null pointer return. nit: there should be a blank line here

Re: ECDSA related PRs

2024-02-22 Thread Bob Wolff
Peter, Thanks for helping lead me down the right path here. WRT tinycrypt, the license is quite permissive. https://github.com/intel/tinycrypt Also, I'd like your advice - I was thinking for the larger patch that I'd do it in two commits. The first would be the addition of the tinycrypt files

[PATCH] Check curve_name for null to avoid crash

2024-02-22 Thread Bob Wolff
If mixed rsa and ecdsa keys are specified in dtsi, an rsa key can be sent into the ecdsa verify. Without the ecdsa,curve property, this function will crash due to lack of checking the null pointer return. Signed-off-by: Bob Wolff --- lib/ecdsa/ecdsa-verify.c | 5 + 1 file changed, 5

[RESEND PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
Currently, when we boot from JTAG we try to boot U-Boot from RAM. However, this is a bit tricky to time, since the debugger has to wait for SPL to initialize RAM before it can load U-Boot. This can result in long waits, since occasionally initializing RAM (and other things in psu_init) takes a

Re: [PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
On 2/22/24 14:36, Fabio Estevam wrote: > On Thu, Feb 22, 2024 at 1:53 PM Sean Anderson wrote: >> >> From: Sean Anderson > ... >> Signed-off-by: Sean Anderson >> --- >> I'm resending this from my linux.dev email as my regular email is >> mangling my patches. > > That's OK, but you need to make

Re: [PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Fabio Estevam
On Thu, Feb 22, 2024 at 1:53 PM Sean Anderson wrote: > > From: Sean Anderson ... > Signed-off-by: Sean Anderson > --- > I'm resending this from my linux.dev email as my regular email is > mangling my patches. That's OK, but you need to make sure that the From and Signed-off-by fields match.

Re: [PATCH 11/16] rockchip: adc: rockchip-saradc: add support for RK3588

2024-02-22 Thread Quentin Schulz
Hi all, On 2/21/24 18:07, Quentin Schulz wrote: From: Quentin Schulz This adds support for the SARADCv2 found on RK3588. There is no stop callback as it is currently configured in single conversion mode, where the ADC is powered down after a single conversion has been made. Cc: Quentin

Re: [PATCH] cmd: eeprom: Fix config dependency

2024-02-22 Thread Tom Rini
On Mon, Feb 19, 2024 at 06:18:38PM +, Ivan Orlov wrote: > We should have CONFIG_DM_I2C or CONFIG_(SPL_)SYS_I2C_LEGACY enabled in > order for `cmd/eeprom.c` to compile as it depends on the i2c functions > which are not compiled otherwise. Update the Kconfig entry for the > 'eeprom' command

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-22 Thread Sean Anderson
On 2/22/24 05:34, Michal Simek wrote: > > > On 2/20/24 20:30, Sean Anderson wrote: >> On 2/20/24 14:18, Michal Simek wrote: >>> >>> >>> On 2/20/24 19:43, Sean Anderson wrote: On 2/20/24 13:24, Michal Simek wrote: > > > On 2/16/24 17:09, Sean Anderson wrote: >> On 2/16/24

Re: [PULL] Please pull qcom/qcom-fixes-2024.04

2024-02-22 Thread Tom Rini
On Thu, Feb 22, 2024 at 04:08:45PM +, Caleb Connolly wrote: > Hi Tom, > > Just a few button fixes that I realise should probably make it in. > > The following changes since commit 37345abb97ef0dd9c50a03b2a72617612dcae585: > > Prepare v2024.04-rc2 (2024-02-13 18:16:57 -0500) > > are

[PATCH v2] arm64: zynqmp: Support semihosting boot method

2024-02-22 Thread Sean Anderson
From: Sean Anderson Currently, when we boot from JTAG we try to boot U-Boot from RAM. However, this is a bit tricky to time, since the debugger has to wait for SPL to initialize RAM before it can load U-Boot. This can result in long waits, since occasionally initializing RAM (and other things in

[PULL] Please pull qcom/qcom-fixes-2024.04

2024-02-22 Thread Caleb Connolly
Hi Tom, Just a few button fixes that I realise should probably make it in. The following changes since commit 37345abb97ef0dd9c50a03b2a72617612dcae585: Prepare v2024.04-rc2 (2024-02-13 18:16:57 -0500) are available in the Git repository at:

Re: [PATCH] arch: mach-k3: fix mapping higher DDR addresses as device memory

2024-02-22 Thread Nishanth Menon
On 12:15-20240222, Neha Malcom Francis wrote: > From: Sekhar Nori > > An entry in memory map table for MMU configuration is spilling over and > inadvertently mapping DDR available at higher address (above 4GB address > space) as device memory (nGnRnE). > > Fix this by

[PATCH 2/2] chameleonv3: set in defconfig for FPGA to reprogram every reboot

2024-02-22 Thread Michał Barnaś
Set CONFIG_TARGET_SOCFPGA_ARRIA10_ALWAYS_REPROGRAM as enabled in chameleon v3 board's defconfig. Signed-off-by: Michał Barnaś --- configs/socfpga_chameleonv3_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/socfpga_chameleonv3_defconfig

[PATCH 1/2] arm: socfpga: arria10: add option to reprogram the FPGA every reboot

2024-02-22 Thread Michał Barnaś
Add Kconfig that enables FPGA reprogramming with warm boot on Arria 10. This option allows to change the bitstream on the filesystem and apply changes with warm reboot without the need for a power cycle. Signed-off-by: Michał Barnaś --- arch/arm/mach-socfpga/Kconfig | 8

[PATCH 0/2] arm: socfpga: arria10: allow to reprogram FPGA with warm reboot

2024-02-22 Thread Michał Barnaś
By default, the board requires power cycle (cold boot) to program the FPGA with bitstream. This change adds Kconfig that allows to enable reprogramming the FPGA with every boot. This makes the update process of the bitstream on the filesystem to be applied with simple system reboot. Michał

[PATCH] riscv: sifive: fu740: reduce DDR speed from 1866MT/s to 1600MT/s

2024-02-22 Thread thomas . perrot
From: Thomas Perrot It appears that there is some timing marginality either in the board layout or the SoC that results in occasional data corruption on some boards. We observed this issue on some of the new HiFive Unmatched RevB boards during volume production as well as some of the original

Re: [PATCH] ARM: Enable CONFIG_64BIT for static analysis

2024-02-22 Thread Dan Carpenter
On Thu, Feb 22, 2024 at 08:16:19AM -0500, Tom Rini wrote: > > That we have 'config 64BIT' in arch/{mips,riscv}/Kconfig as well is a > leftover of thinking this is like the Linux Kernel where there's no > top-level arch/Kconfig file, can you please move the two existing config > 64BIT entries to

Re: [PATCH] ARM: Enable CONFIG_64BIT for static analysis

2024-02-22 Thread Tom Rini
On Thu, Feb 22, 2024 at 09:47:58AM +0300, Dan Carpenter wrote: > In the Makefile there is a line that says this: > > # the checker needs the correct machine size > CHECKFLAGS += $(if $(CONFIG_64BIT),-m64,-m32) > > So set CONFIG_64BIT so that we don't pass -m32 to the static checker. >

[PATCH 4/4] board: ti: am62x: evm: Update simple-framebuffer node in device-tree

2024-02-22 Thread Devarsh Thakkar
Update simple-framebuffer device-tree node by enumerating framebuffer related information in existing simple-framebuffer node in Linux device-tree file and enabling it. In case there is no simple-framebuffer stub detected in Linux kernel device-tree and video is still active, then update the

[PATCH 3/4] boot: Move framebuffer reservation to separate helper

2024-02-22 Thread Devarsh Thakkar
Create separate helper for just reserving framebuffer region without creating or enabling simple-framebuffer node. This is useful for scenarios where user want to preserve the bootloader splash screen till OS boots up and display server gets started without displaying anything else in between and

[PATCH 2/4] video: Assume video to be active if SPL is passing video hand-off

2024-02-22 Thread Devarsh Thakkar
If SPL is passing video handoff structure to U-boot then it is safe to assume that SPL has already enabled video and that's why it is passing video handoff structure to U-boot so that U-boot can preserve the framebuffer. Signed-off-by: Devarsh Thakkar --- drivers/video/video-uclass.c | 4

[PATCH 1/4] boot: fdt_simplefb: Enumerate framebuffer info from video handoff

2024-02-22 Thread Devarsh Thakkar
Enable and update simple-framebuffer node using the video handoff bloblist if video was enabled at SPL stage and corresponding video bloblist was received at u-boot proper with necessary parameters. Signed-off-by: Devarsh Thakkar --- boot/fdt_simplefb.c | 34 +-

[PATCH 0/4] Simplefb and fb reservation related updates

2024-02-22 Thread Devarsh Thakkar
This adds support for simple-framebuffer reservation using video handoff when splash is enabled at SPL stage. Also adds helper function to only enable framebuffer reservation without enabling simple-framebuffer in case user want to continue display bootloader splash without displaying anything

Re: [PATCH v2 13/15] rockchip: rk3328: Add support to build bootable SPI image

2024-02-22 Thread Jonas Karlman
Hi Quentin, On 2024-02-22 11:18, Quentin Schulz wrote: > Hi Jonas, > > On 2/17/24 01:22, Jonas Karlman wrote: >> Similar to RK35xx the BootRom in RK3328 can read all data and look for >> idbloader at 0x8000, same as it does for SD and eMMC. >> >> Use the rksd format and modify the mkimage offset

Re: [PATCH 7/7] verdin-imx8mp_defconfig: Enable PCIe/NVMe support

2024-02-22 Thread Marcel Ziswiler
On Wed, 2024-02-21 at 15:31 +0100, Francesco Dolcini wrote: > On Wed, Feb 21, 2024 at 09:18:51AM +, Marcel Ziswiler wrote: > > On Wed, 2024-02-21 at 08:55 +0100, Francesco Dolcini wrote: > > > On Tue, Feb 20, 2024 at 06:40:56PM +0530, Sumit Garg wrote: > > > > Also, enable reset driver which

Re: riscv: supports_extension() broken for long isa strings

2024-02-22 Thread Heinrich Schuchardt
On 21.02.24 18:59, Conor Dooley wrote: Yo, I mentioned this last night to Heinrich on IRC, supports_extension() is broken for ISA strings longer than 32 characters. M-Mode U-Boot doesn't parse a devicetree, so this doesn't apply there, but for S-mode supports_extension() looks like: static

[PATCH v6 04/11] Makefile: Allow upstream DT subtree to provide DT includes

2024-02-22 Thread Sumit Garg
Allow platforms to reuse DT headers and dtsi includes directly form upstream DT subtree which will be frequently synced with Linux kernel. This will further allow us to drop corresponding DT includes copy from U-Boot tree. Also, since the DT includes from upstream DT subtree are done after DT

[PATCH v6 05/11] dts: Add alternative location for upstream DTB builds

2024-02-22 Thread Sumit Garg
Allow platform owners to mirror devicetree files from devitree-rebasing directory into dts/upstream/src/$(ARCH) (special case for arm64). Then build then along with any *-u-boot.dtsi file present in arch/$(ARCH)/dts directory. Also add a new Makefile for arm64. This will help easy migration for

[PATCH v6 11/11] dts: meson-gxbb: Drop redundant devicetree files

2024-02-22 Thread Sumit Garg
Since meson-gxbb based boards switched to using upstream DT, so drop redundant files from arch/arm/dts directory. Only *-u-boot.dtsi files kept in arch/arm/dts directory for these boards. Reviewed-by: Neil Armstrong Signed-off-by: Sumit Garg --- Changes in v6: - None Changes in v5: - None

[PATCH v6 08/11] doc: devicetree: Updates for devicetree-rebasing subtree

2024-02-22 Thread Sumit Garg
Encourage SoC/board maintainers to migrate to using devicetree-rebasing subtree and maintain a regular sync with Linux kernel devicetree files and bindings. Along with that add documentation regarding how to run DT bindings schema checks. Signed-off-by: Sumit Garg --- Changes in v6: -

[PATCH v6 09/11] MAINTAINERS: Add myself as devicetree-rebasing maintainer

2024-02-22 Thread Sumit Garg
Add myself as devicetree-rebasing maintainer. Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Sumit Garg --- Changes in v6: - None Changes in v5: - None Changes in v4: - Switched subtree to be imported as dts/upstream sub-directory rather than devicetree-rebasing

[PATCH v6 10/11] dts: meson-gxbb: Switch to using upstream DT

2024-02-22 Thread Sumit Garg
Although there were still some variations in board DTS files based on meson-gxbb SoC but I think those were minor differences from upstream and shouldn't impact boot on these devices. So enable OF_UPSTREAM to use upstream DT and add amlogic/ prefix to the DEFAULT_DEVICE_TREE. And thereby directly

[PATCH v6 07/11] doc: devicetree: Align documentation to use Kconfig options

2024-02-22 Thread Sumit Garg
Since U-Boot switched away from manual CONFIG_* defines to Kconfig options, align devicetree documentation accordingly. Signed-off-by: Sumit Garg --- Changes in v6: - None Changes in v5: - Fixed inappropriate documentation update. Changes in v4: - Separate patch to align documentation to use

[PATCH v6 06/11] dts: Add script to uprev dts/upstream subtree

2024-02-22 Thread Sumit Garg
dts/update-dts-subtree.sh is just a wrapper around git subtree commands. Usage from the top level U-Boot source tree, run: $ ./dts/update-dts-subtree.sh pull $ ./dts/update-dts-subtree.sh pick Signed-off-by: Sumit Garg --- Changes in v6: - Incorporate shell script comments from Marek.

[PATCH v6 03/11] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-02-22 Thread Sumit Garg
Allow u-boot to build DTB from a different directory tree such that *-u-boot.dtsi files can be included from a common location. Currently that location is arch/$(ARCH)/dts/, so statically define that common location. This is needed for platform owners to start building DTB files from

[PATCH v6 01/11] CI: Exclude devicetree-rebasing subtree for CONFIG checks

2024-02-22 Thread Sumit Garg
Since devicetree-rebasing is an external repo with its own coding style, exclude it from Azure and gitlab CI CONFIG checks. Reviewed-by: Tom Rini Reviewed-by: Ilias Apalodimas Reviewed-by: Simon Glass Signed-off-by: Sumit Garg --- Changes in v6: - None Changes in v5: - None Changes in v4:

[PATCH v6 02/11] Makefile: Add support for DT bindings schema checks

2024-02-22 Thread Sumit Garg
This adds the build infrastructure for checking DT binding schema documents and validating dtb files using the binding schema. Here we use devicetree-rebasing subtree to provide the DT bindings. Along with that adapt dts/upstream/Bindings/Makefile to align with old U-Boot Kbuild infrastructure.

[PATCH v6 00/11] An effort to bring DT bindings compliance within U-Boot

2024-02-22 Thread Sumit Garg
Changes in v6: -- - v6_dt: https://github.com/b49020/u-boot/tree/v6_dt - Patch #3: Incorporate fix for sandbox CI failure. - Patch #6: Incorporate shell script comments from Marek. - Patch #8: Incorporate documentation review comments from Paul. Changes in v5: -- - Rebased

Re: [PATCH] implement policy_pcr commands to lock NV-indexes behind a PCR

2024-02-22 Thread niek.nooij...@omron.com
Hi Illias sure I pushed it here: https://github.com/nieknooijens/u-boot/tree/tpm_policy_patch Niek 差出人: Ilias Apalodimas 送信日時: 2024年2月21日 18:01 宛先: Niek Nooijens / OC-IAB PBD-C DEVEL 1-1 CC: Dan Carpenter ; u-boot@lists.denx.de 件名: Re: [PATCH] implement

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-22 Thread Michal Simek
On 2/20/24 20:30, Sean Anderson wrote: On 2/20/24 14:18, Michal Simek wrote: On 2/20/24 19:43, Sean Anderson wrote: On 2/20/24 13:24, Michal Simek wrote: On 2/16/24 17:09, Sean Anderson wrote: On 2/16/24 11:03, Sean Anderson wrote: On 2/16/24 10:06, Michal Simek wrote: On 2/16/24

Re: [PATCH v2 13/15] rockchip: rk3328: Add support to build bootable SPI image

2024-02-22 Thread Quentin Schulz
Hi Jonas, On 2/17/24 01:22, Jonas Karlman wrote: Similar to RK35xx the BootRom in RK3328 can read all data and look for idbloader at 0x8000, same as it does for SD and eMMC. Use the rksd format and modify the mkimage offset to generate a bootable u-boot-rockchip-spi.bin that can be written to

Re: [PATCH v2 09/15] gpio: rockchip: Use gpio alias id as gpio bank id

2024-02-22 Thread Quentin Schulz
Hi Jonas, On 2/17/24 01:22, Jonas Karlman wrote: The U-Boot driver try to base the gpio bank id on the gpio-ranges prop and fall back to base the bank id on the node name. However, the linux driver try to base the bank id on the gpio alias id and fall back on node order. This can cause issues

Re: [PATCH 05/11] rockchip: io-domain: Add support for RK3399

2024-02-22 Thread Quentin Schulz
Hi Jonas, On 2/21/24 20:05, Jonas Karlman wrote: Hi Quentin, On 2024-02-21 19:18, Quentin Schulz wrote: Hi Jonas, On 2/17/24 19:35, Jonas Karlman wrote: Port the RK3399 part of the Rockchip IO-domain driver from linux. This differs from linux version in that pmu io iodomain bit is enabled

Re: HABv4 with SPL and u-boot-dtb.img on i.MX6

2024-02-22 Thread Benjamin Lemouzy
On Tue, 20 Feb 2024 11:29:53 -0500 Sean Anderson wrote: > On 2/20/24 04:50, Benjamin Lemouzy wrote: > > Using fdtdump shows that crc32 is used as hash algorithm for FIT image > > which is a super weak one. > > I tried to pass another algo (sha256) using mkimage -o option but that > > doesn't