Re: [PATCH] riscv: dts: jh7110: Enable PLL node in SPL

2024-04-19 Thread Bo Gan
On 4/16/24 9:59 PM, E Shattow wrote: On Tue, Apr 9, 2024 at 11:44 PM Bo Gan wrote: On 4/9/24 6:55 PM, E Shattow wrote: Original speed class SD cards fail with this change "unable to change mode". The BUS_ROOT clock will have to be switched to PLL2 anyway in U-Boot proper or in Linux,

[PATCH RFC 9/9] sunxi: video: support HDMI on H6/H616

2024-04-19 Thread John Watts
The H6 and H616 support outputting HDMI through the Display Engine. Set up the clocks and resets appropriately for the HDMI controller. This turns out to be a little tricky as the HDMI clock requires a different parent on the H6 compared to the H616. So we have to end up choosing VIDEO1 on the

[PATCH RFC 8/9] sunxi: Enable display engine on H6/D1

2024-04-19 Thread John Watts
Now that all the code is present and can compile, enable the DE2 so people can use it. Signed-off-by: John Watts --- arch/arm/mach-sunxi/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig index ddf9414b08..9d76e429ef 100644

[PATCH RFC 7/9] sunxi: video: dummy out HDMI on H6/D1

2024-04-19 Thread John Watts
I don't have any hardware to implement HDMI support on, but it's still worth making the code compile for future work. Adding HDMI support shouldn't be too difficult, though beware: The H6 and H616 both have a different set of HDMI clock parents. Future code will most likely need to pick VIDEO0 or

[PATCH RFC 6/9] sunxi: video: silence unused use_mipi_pll warning

2024-04-19 Thread John Watts
This variable is only used sometimes, so gate it behind an #ifdef. Signed-off-by: John Watts --- drivers/video/sunxi/lcdc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/sunxi/lcdc.c b/drivers/video/sunxi/lcdc.c index ea21d602be..1474f6cb2e 100644 ---

[PATCH RFC 5/9] sunxi: video: enable DE2 on H6/D1

2024-04-19 Thread John Watts
This requires just a little change to clocking and reset logic. Signed-off-by: John Watts --- drivers/video/sunxi/sunxi_de2.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/video/sunxi/sunxi_de2.c b/drivers/video/sunxi/sunxi_de2.c index e02d359cd2..9b6c41b212

[PATCH RFC 4/9] sunxi: video: support LCD on H6/D1

2024-04-19 Thread John Watts
The H6/D1/R528 don't require any big changes, just some small tweaks to support new clock and reset logic. Signed-off-by: John Watts --- drivers/video/sunxi/lcdc.c | 20 drivers/video/sunxi/sunxi_lcd.c | 6 -- 2 files changed, 24 insertions(+), 2 deletions(-)

[PATCH RFC 3/9] sunxi: sun50i-h6: Specify DE2 and LCD0 base addresses

2024-04-19 Thread John Watts
These are used for operating the LCD on the H6/H616. Signed-off-by: John Watts --- arch/arm/include/asm/arch-sunxi/cpu_sun50i_h6.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/include/asm/arch-sunxi/cpu_sun50i_h6.h b/arch/arm/include/asm/arch-sunxi/cpu_sun50i_h6.h index

[PATCH RFC 2/9] sunxi: ncat2: Specify DE2 and LCD0 base addresses

2024-04-19 Thread John Watts
These are used for operating the LCD on the D1/T113. Signed-off-by: John Watts --- arch/arm/include/asm/arch-sunxi/cpu_sunxi_ncat2.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/include/asm/arch-sunxi/cpu_sunxi_ncat2.h b/arch/arm/include/asm/arch-sunxi/cpu_sunxi_ncat2.h

[PATCH RFC 1/9] sunxi: clock: support H6/D1 video clocks

2024-04-19 Thread John Watts
This code adds support for clocking VIDEO0 and VIDEO1, as well as registers used for the DE2. This code deliberately uses a 12MHz step in clocking to align with the DE2 code's expectation of double 6MHz steps. Signed-off-by: John Watts --- arch/arm/include/asm/arch-sunxi/clock_sun50i_h6.h | 56

[PATCH RFC 0/9] sunxi: video: Support LCD and HDMI output on H6/D1

2024-04-19 Thread John Watts
This patch series is my first attempt at supporting an LCD panel on the T113. I can confirm this specific use case works, but I've added code for the H6/H616 too in the process as a lot of the logic is the same. I've also included an untested patch for HDMI support at the end in case anyone wants

[PATCH] ARM: stm32: Ping IWDG on exit from PSCI suspend code

2024-04-19 Thread Marek Vasut
Make sure the OS would not get any spurious IWDG pretimeout IRQ right after the system wakes up. This may happen in case the SoC got woken up by another source than the IWDG pretimeout and the pretimeout IRQ arrived immediately afterward, but too late to be handled by the suspend main loop. In

Re: [PULL] Pull request for u-boot master / v2024.07 = u-boot-stm32-20240419

2024-04-19 Thread Tom Rini
On Fri, Apr 19, 2024 at 02:01:47PM +0200, Patrice CHOTARD wrote: > Hi Tom > > Please pull the STM32 related patches for u-boot/master, v2024.07: > u-boot-stm32-20240419 > > CI status: > https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/20430 > > &g

Re: [GIT PULL] Please pull u-boot-dfu-20240419

2024-04-19 Thread Tom Rini
lines/20427 > > Thanks, > Mattijs > > The following changes since commit 2c3fa4b8add3cb6a440184ab67debc6867d383c0: > > sandbox: don't call os_close with invalid file descriptor (2024-04-17 > 17:06:16 -0600) > > are available in the Git repository at: > > https://sourc

Re: Pull request for tpm-master-18042024

2024-04-19 Thread Tom Rini
On Thu, Apr 18, 2024 at 08:14:01PM +0300, Ilias Apalodimas wrote: > OP-TEE fixes only on this PR, no TPM related ones. > > The following changes since commit 2c3fa4b8add3cb6a440184ab67debc6867d383c0: > > sandbox: don't call os_close with invalid file descriptor (2024-04-17 > 17:06:16 -0600)

[PATCH v2 6/7] dts: am62x: binman: Include firmware capsules binman nodes

2024-04-19 Thread Jonathan Humphreys
Fill in the am62x SK's capsule GUID properties of the base binman capsule nodes. Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-am625-sk-binman.dtsi | 30 1 file changed, 30 insertions(+) diff --git a/arch/arm/dts/k3-am625-sk-binman.dtsi

[PATCH v2 4/7] dts: beagleplay: binman: Include firmware capsules binman nodes

2024-04-19 Thread Jonathan Humphreys
Fill in the BeaglePlay's capsule GUID properties of the base binman capsule nodes. Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 27 arch/arm/dts/k3-am625-r5-beagleplay.dts | 15 +++ 2 files changed, 42 insertions(+) diff

[PATCH v2 0/7] binman: ti: create binman nodes for EFI capsules

2024-04-19 Thread Jonathan Humphreys
Add binman nodes for EFI capsules of firmware components so that capsules are automatically created during the UBoot builds. This is enabled for several TI SoC based platforms: AM64, AM62, AM62p, BeaglePlay, J7, and BeagleboneAI. Changes from v1: - on GP devices, still use signed images in

[PATCH v2 2/7] dts: am64x: binman: Include firmware capsules binman nodes

2024-04-19 Thread Jonathan Humphreys
Fill in the am64x SK's capsule GUID properties of the base binman capsule nodes. Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-am64x-binman.dtsi | 30 ++ 1 file changed, 30 insertions(+) diff --git a/arch/arm/dts/k3-am64x-binman.dtsi

[PATCH v2 5/7] dts: am62px: binman: Include firmware capsules binman nodes

2024-04-19 Thread Jonathan Humphreys
Fill in the am62px SK's capsule GUID properties of the base binman capsule nodes. Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-am62p-sk-binman.dtsi | 29 1 file changed, 29 insertions(+) diff --git a/arch/arm/dts/k3-am62p-sk-binman.dtsi

[PATCH v2 1/7] dts: ti: binman: Add base K3 firmware capsule nodes

2024-04-19 Thread Jonathan Humphreys
Create capsule files for tiboot3.bin, tispl.bin, and u-boot.img. Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-binman-capsule-r5.dtsi | 21 ++ arch/arm/dts/k3-binman-capsule.dtsi| 38 ++ 2 files changed, 59 insertions(+) create mode 100644

[PATCH v2 7/7] dts: beagleboneai64: binman: Include firmware capsules binman nodes

2024-04-19 Thread Jonathan Humphreys
Fill in the BeagleBoneAI64's capsule GUID properties of the base binman capsule nodes. Also add it's SYSFW binman capsule node. Signed-off-by: Jonathan Humphreys --- .../dts/k3-j721e-beagleboneai64-u-boot.dtsi | 23 +++ arch/arm/dts/k3-j721e-r5-beagleboneai64.dts | 29

[PATCH v2 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-19 Thread Jonathan Humphreys
Fill in the J721e SK's capsule GUID properties of the base binman capsule nodes. Also add it's SYSFW binman capsule node. Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-j721e-binman.dtsi | 49 +++ 1 file changed, 49 insertions(+) diff --git

Re: [PATCH v3 04/19] doc: board: ti: am64x: document OSPI layout

2024-04-19 Thread Tom Rini
On Fri, Apr 19, 2024 at 03:56:46PM -0500, Jonathan Humphreys wrote: > Signed-off-by: Jonathan Humphreys > --- > doc/board/ti/am64x_evm.rst | 48 ++ > 1 file changed, 48 insertions(+) [snip] > +Flash layout for OSPI: > + > +.. code-block:: console > + > +

[PATCH v3 00/19] EFI: ti: Enable EFI capsule updates

2024-04-19 Thread Jonathan Humphreys
Enable on disk capsule updates, which includes defining the firmware components (tiboot3, spl, u-boot) and enabling processing of raw capsule updates. This is enabled for several TI SoC based platforms: AM64, AM62, AM62p, BeaglePlay, J7, and BeagleboneAI. This series also includes enabling seral

[PATCH v3 05/19] board: j721e: Define capsule update firmware info

2024-04-19 Thread Jonathan Humphreys
Define the firmware components updatable via EFI capsule update, including defining capsule GUIDs for the various firmware components for the SK-TDA4VM. Signed-off-by: Jonathan Humphreys --- board/ti/j721e/evm.c| 38 + include/configs/j721e_evm.h | 29

[PATCH v3 19/19] configs: beagleboneai64: Enable EFI capsule update

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- configs/j721e_beagleboneai64_a72_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/j721e_beagleboneai64_a72_defconfig b/configs/j721e_beagleboneai64_a72_defconfig index 3d234bc1a8f..e74ee68e23e 100644 ---

[PATCH v3 04/19] doc: board: ti: am64x: document OSPI layout

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- doc/board/ti/am64x_evm.rst | 48 ++ 1 file changed, 48 insertions(+) diff --git a/doc/board/ti/am64x_evm.rst b/doc/board/ti/am64x_evm.rst index 6ae35b3fee3..a7468fbd254 100644 --- a/doc/board/ti/am64x_evm.rst +++

[PATCH v3 03/19] configs: am64x: Enable EFI capsule update

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- configs/am64x_evm_a53_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/am64x_evm_a53_defconfig b/configs/am64x_evm_a53_defconfig index e000549d6d0..c9bdd7b54cc 100644 --- a/configs/am64x_evm_a53_defconfig +++

[PATCH v3 14/19] configs: am62x: Enable serial flash DFU

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- configs/am62x_evm_a53_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/am62x_evm_a53_defconfig b/configs/am62x_evm_a53_defconfig index 6b37f8b4791..cc397f72d2c 100644 --- a/configs/am62x_evm_a53_defconfig +++

[PATCH v3 11/19] board: am62px: Define capsule update firmware info

2024-04-19 Thread Jonathan Humphreys
Define the firmware components updatable via EFI capsule update, including defining capsule GUIDs for the various firmware components for the AM62px SK. Signed-off-by: Jonathan Humphreys --- board/ti/am62px/evm.c| 32 include/configs/am62px_evm.h | 24

[PATCH v3 07/19] doc: board: ti: j721e: document OSPI layout

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- doc/board/ti/j721e_evm.rst | 85 +- 1 file changed, 56 insertions(+), 29 deletions(-) diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti/j721e_evm.rst index a422a9bf1a0..a0fc37ab6d7 100644 ---

[PATCH v3 02/19] board: am64x: Define capsule update firmware info

2024-04-19 Thread Jonathan Humphreys
Define the firmware components updatable via EFI capsule update, including defining capsule GUIDs for the various firmware components for the AM64x SK. Signed-off-by: Jonathan Humphreys --- board/ti/am64x/evm.c| 33 + include/configs/am64x_evm.h | 24

[PATCH v3 17/19] doc: board: ti: am62x: document OSPI layout

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- doc/board/ti/am62x_sk.rst | 48 +++ 1 file changed, 48 insertions(+) diff --git a/doc/board/ti/am62x_sk.rst b/doc/board/ti/am62x_sk.rst index b12dc85f06b..bf7ea754e32 100644 --- a/doc/board/ti/am62x_sk.rst +++

[PATCH v3 10/19] configs: beagleplay: Enable EFI capsule update

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- configs/am62x_beagleplay_a53_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/am62x_beagleplay_a53_defconfig b/configs/am62x_beagleplay_a53_defconfig index 68e103f58dc..23b9c466248 100644 --- a/configs/am62x_beagleplay_a53_defconfig

[PATCH v3 18/19] board: beagleboneai64: Define capsule update firmware info

2024-04-19 Thread Jonathan Humphreys
Define the firmware components updatable via EFI capsule update, including defining capsule GUIDs for the various firmware components for the BeagleBoneAI64. Note this involved creating BeagleBoneAI64's own beagleboneai64.h board header file instead of reusing j721e_evm's. Signed-off-by:

[PATCH v3 01/19] doc: uefi: capsules: Start Capsule Update porting section

2024-04-19 Thread Jonathan Humphreys
Created a capsule update porting section in the documentation that outlines the steps a board developer must do when porting from an existing reference board implementation. In particular, added a big warning that new capsule GUID's need to be defined. Signed-off-by: Jonathan Humphreys ---

[PATCH v3 16/19] configs: am62x: Enable EFI capsule update

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- configs/am62x_evm_a53_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/am62x_evm_a53_defconfig b/configs/am62x_evm_a53_defconfig index cc397f72d2c..d628535a4ed 100644 --- a/configs/am62x_evm_a53_defconfig +++

[PATCH v3 12/19] configs: am62px: Enable EFI capsule update

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- configs/am62px_evm_a53_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/am62px_evm_a53_defconfig b/configs/am62px_evm_a53_defconfig index 638d2e90a6b..02500e205d1 100644 --- a/configs/am62px_evm_a53_defconfig +++

[PATCH v3 08/19] board: beagleplay: Define capsule update firmware info

2024-04-19 Thread Jonathan Humphreys
Define the firmware components updatable via EFI capsule update, including defining capsule GUIDs for the various firmware components for the BeaglePlay. Note this involved creating BeaglePlay's own beagleplay.h board header file instead of reusing am62_evm's. Signed-off-by: Jonathan Humphreys

[PATCH v3 13/19] doc: board: ti: am62px: document OSPI layout

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- doc/board/ti/am62px_sk.rst | 48 ++ 1 file changed, 48 insertions(+) diff --git a/doc/board/ti/am62px_sk.rst b/doc/board/ti/am62px_sk.rst index 1f2982c36f9..7ff20fbf8e6 100644 --- a/doc/board/ti/am62px_sk.rst +++

[PATCH v3 09/19] configs: beagleplay: Enable DFU for MMC

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- configs/am62x_beagleplay_a53_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/am62x_beagleplay_a53_defconfig b/configs/am62x_beagleplay_a53_defconfig index 147967d3c11..68e103f58dc 100644 --- a/configs/am62x_beagleplay_a53_defconfig

[PATCH v3 06/19] configs: j721e: Enable EFI capsule update

2024-04-19 Thread Jonathan Humphreys
Signed-off-by: Jonathan Humphreys --- configs/j721e_evm_a72_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig index 077bf508328..b8840a556e1 100644 --- a/configs/j721e_evm_a72_defconfig +++

[PATCH v3 15/19] board: am62x: Define capsule update firmware info

2024-04-19 Thread Jonathan Humphreys
Define the firmware components updatable via EFI capsule update, including defining capsule GUIDs for the various firmware components for the AM62x SK. Signed-off-by: Jonathan Humphreys --- board/ti/am62x/evm.c| 32 include/configs/am62x_evm.h | 24

Re: [PATCH] mmc: sdhci: introduce adma_write_desc() hook to struct sdhci_ops

2024-04-19 Thread Greg Malysa
Hi, > Some target are failed to build. (e.g, j721e_beagleboneai64_r5) > > +drivers/mmc/sdhci-adma.c: In function '__sdhci_adma_write_desc': > +drivers/mmc/sdhci-adma.c:37:43: error: 'const struct sdhci_ops' has no > member named 'adma_write_desc' > + 37 | if (host && host->ops &&

Re: [PATCH v2] configs: am62px_evm_a53_defconfig: Enable MMC UHS config option

2024-04-19 Thread Bryan Brattlof
On April 16, 2024 thus sayeth Judith Mendez: > Enable MMC UHS support for to allow to enter the UHS > modes for MMC1. > s/support for/support/ Though it doesn't really matter to me. ;) > Signed-off-by: Judith Mendez > --- > Changes since v1: > - Fix typo in patch description > --- > >

Re: [PATCH v3] tpm-v2: allow algoirthm name to be configured for pcr_read and pcr_extend

2024-04-19 Thread Ilias Apalodimas
On Fri, 19 Apr 2024 at 20:52, Tim Harvey wrote: > > On Fri, Apr 19, 2024 at 10:37 AM Ilias Apalodimas > wrote: > > > > Also quickly looking at this, you need a new function for > > tpm2_algorithm_to_mask() (look below) > > > > On Fri, 19 Apr 2024 at 20:20, Ilias Apalodimas > > wrote: > > > > >

Re: [PATCH] usb: dwc2: Add in version 4xx compatibility

2024-04-19 Thread Greg Malysa
Hi Mattijs, > Please avoid top-posting when replying, it makes following the > discussion more difficult: > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions Will do. Sorry about that; I'm still learning about this

Re: [PATCH v3 1/3] clk: imx8mm: Add support for PCIe clocks

2024-04-19 Thread Marek Vasut
On 4/19/24 5:29 PM, Tim Harvey wrote: Add support for PCIe clocks required to enable PCIe support on iMX8MM SoC. Signed-off-by: Tim Harvey Reviewed-by: Marek Vasut

Re: [PATCH v4 3/3] dts: support building all dtb files for a specific vendor

2024-04-19 Thread Neil Armstrong
On 18/04/2024 20:39, Caleb Connolly wrote: This adjusts OF_UPSTREAM to behave more like the kernel by allowing for all the devicetree files for a given vendor to be compiled. This is useful for Qualcomm in particular as most boards are supported by a single U-Boot build just provided with a

Re: [PATCH v3] tpm-v2: allow algoirthm name to be configured for pcr_read and pcr_extend

2024-04-19 Thread Tim Harvey
On Fri, Apr 19, 2024 at 10:37 AM Ilias Apalodimas wrote: > > Also quickly looking at this, you need a new function for > tpm2_algorithm_to_mask() (look below) > > On Fri, 19 Apr 2024 at 20:20, Ilias Apalodimas > wrote: > > > > Hi Tim, > > > > On Fri, 19 Apr 2024 at 20:13, Tim Harvey wrote: > >

Re: [PATCH v3] tpm-v2: allow algoirthm name to be configured for pcr_read and pcr_extend

2024-04-19 Thread Ilias Apalodimas
Also quickly looking at this, you need a new function for tpm2_algorithm_to_mask() (look below) On Fri, 19 Apr 2024 at 20:20, Ilias Apalodimas wrote: > > Hi Tim, > > On Fri, 19 Apr 2024 at 20:13, Tim Harvey wrote: > > > > On Sat, Apr 6, 2024 at 9:33 AM Ilias Apalodimas > > wrote: > > > > > >

Re: [PATCH v3] tpm-v2: allow algoirthm name to be configured for pcr_read and pcr_extend

2024-04-19 Thread Ilias Apalodimas
Hi Tim, On Fri, 19 Apr 2024 at 20:13, Tim Harvey wrote: > > On Sat, Apr 6, 2024 at 9:33 AM Ilias Apalodimas > wrote: > > > > Hi Tim, > > > > Thanks for the patch > > > > I'll be away next week, I'll try to find time and take a closer look. > > The pipeline [0] shows some TPM related failures >

Re: [PATCH v6 01/18] video: tegra20: dc: diverge DC per-SOC

2024-04-19 Thread Svyatoslav Ryhel
пт, 19 квіт. 2024 р. о 19:26 Thierry Reding пише: > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > [...] > > diff --git a/arch/arm/include/asm/arch-tegra114/display.h > > b/arch/arm/include/asm/arch-tegra114/display.h > > new file mode 100644 > > index 00..9411525799 > >

Re: [PATCH v3] tpm-v2: allow algoirthm name to be configured for pcr_read and pcr_extend

2024-04-19 Thread Tim Harvey
On Sat, Apr 6, 2024 at 9:33 AM Ilias Apalodimas wrote: > > Hi Tim, > > Thanks for the patch > > I'll be away next week, I'll try to find time and take a closer look. > The pipeline [0] shows some TPM related failures > > [0] >

Re: [PATCH v6 09/18] video: tegra20: dc: fix printing of framebuffer address

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > From: Jonas Schwöbel > > Framebuffer address should not be a pointer. > > Signed-off-by: Jonas Schwöbel > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dc.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v6 04/18] video: tegra20: dc: pass DC id to internal devices

2024-04-19 Thread Svyatoslav Ryhel
пт, 19 квіт. 2024 р. о 19:58 Thierry Reding пише: > > On Fri Apr 19, 2024 at 6:44 PM CEST, Svyatoslav Ryhel wrote: > > пт, 19 квіт. 2024 р. о 19:38 Thierry Reding пише: > > > > > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > > > > Tegra SoC has 2 independent display controllers

Re: [PATCH v6 12/18] video: tegra20: dc: parameterize V- and H-sync polarities

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Based on Thierry Reding's Linux commit: > > 'commit 1716b1891e1de05e2c20ccafa9f58550f3539717 > ("drm/tegra: rgb: Parameterize V- and H-sync polarities")' > > Signed-off-by: Svyatoslav Ryhel > --- > arch/arm/include/asm/arch-tegra/dc.h

Re: [PATCH v6 04/18] video: tegra20: dc: pass DC id to internal devices

2024-04-19 Thread Thierry Reding
On Fri Apr 19, 2024 at 6:44 PM CEST, Svyatoslav Ryhel wrote: > пт, 19 квіт. 2024 р. о 19:38 Thierry Reding пише: > > > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > > > Tegra SoC has 2 independent display controllers called DC_A and > > > DC_B, they are handled differently by

Re: [PATCH v6 07/18] video: tegra20: dc: add powergate

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Add powergate use on T114 to complete resetting of DC. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dc.c | 27 +++ > 1 file changed, 27 insertions(+) Seems correct: Reviewed-by:

Re: [PATCH v6 11/18] video: tegra20: dc: clean framebuffer memory block

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > From: Jonas Schwöbel > > Fill the framebuffer memory with zeros to avoid visual glitches. > > Signed-off-by: Jonas Schwöbel > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dc.c | 5 + > 1 file changed, 5

Re: [PATCH v6 06/18] video: tegra20: dc: add reset support

2024-04-19 Thread Svyatoslav Ryhel
пт, 19 квіт. 2024 р. о 19:46 Thierry Reding пише: > > On Fri Apr 19, 2024 at 6:37 PM CEST, Svyatoslav Ryhel wrote: > > пт, 19 квіт. 2024 р. о 19:05 Thierry Reding пише: > > > > > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > > > > Implement reset use to discard any changes

Re: [PATCH v6 15/18] video: tegra20: dsi: add reset support

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Implement reset use to discard any changes which could have been > applied to DSI before and can interfere with current configuration. > > Tested-by: Ion Agorria # HTC One X > Tested-by: Svyatoslav Ryhel # Nvidia Tegratab T114 >

Re: [PATCH v6 05/18] video: tegra20: dc: add PLLD2 parent support

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > T30+ SOC have second PLLD - PLLD2 which can be actively used by > DC and act as main DISP1/2 clock parent. > > Tested-by: Agneli # Toshiba AC100 T20 > Tested-by: Robert Eckelmann # ASUS TF101 > Tested-by: Andreas Westman Dorcsak #

Re: [PATCH v6 08/18] video: tegra20: dc: configure behavior if PLLD/D2 is used

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > If DISP1 is a PLLD/D2 child, it cannot go over 370MHz. The cause > of this is not quite clear. This can be overcomed by further > halving the PLLD/D2 if the target parent rate is over 800MHz. > This way DISP1 and DSI clocks will have

Re: [PATCH v6 06/18] video: tegra20: dc: add reset support

2024-04-19 Thread Thierry Reding
On Fri Apr 19, 2024 at 6:37 PM CEST, Svyatoslav Ryhel wrote: > пт, 19 квіт. 2024 р. о 19:05 Thierry Reding пише: > > > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > > > Implement reset use to discard any changes which could have been > > > applied to DC before and can interfere

Re: [PATCH v6 04/18] video: tegra20: dc: pass DC id to internal devices

2024-04-19 Thread Svyatoslav Ryhel
пт, 19 квіт. 2024 р. о 19:38 Thierry Reding пише: > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > > Tegra SoC has 2 independent display controllers called DC_A and > > DC_B, they are handled differently by internal video devices like > > DSI and HDMI controllers so it is

Re: [PATCH v6 16/18] video: tegra20: dsi: remove pre-configuration

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > From: Jonas Schwöbel > > Configuration for DC driver command mode is not required for > every panel. Removed. > > Tested-by: Ion Agorria # HTC One X > Tested-by: Svyatoslav Ryhel # Nvidia Tegratab T114 > Signed-off-by: Jonas Schwöbel

Re: [PATCH v6 04/18] video: tegra20: dc: pass DC id to internal devices

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Tegra SoC has 2 independent display controllers called DC_A and > DC_B, they are handled differently by internal video devices like > DSI and HDMI controllers so it is important for last to know > which display controller is used to

Re: [PATCH v6 06/18] video: tegra20: dc: add reset support

2024-04-19 Thread Svyatoslav Ryhel
пт, 19 квіт. 2024 р. о 19:05 Thierry Reding пише: > > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > > Implement reset use to discard any changes which could have been > > applied to DC before and can interfere with current configuration. > > > > Tested-by: Agneli # Toshiba AC100

Re: [PATCH v6 10/18] video: tegra20: dc: enable backlight after DC is configured

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > From: Jonas Schwöbel > > The goal of panel_set_backlight() is to enable backlight. Hence, > it should be called at the probe end. > > Signed-off-by: Jonas Schwöbel > Signed-off-by: Svyatoslav Ryhel > --- >

Re: [PATCH v6 01/18] video: tegra20: dc: diverge DC per-SOC

2024-04-19 Thread Thierry Reding
On Fri Apr 19, 2024 at 6:26 PM CEST, Thierry Reding wrote: > On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > [...] > > diff --git a/arch/arm/include/asm/arch-tegra114/display.h > > b/arch/arm/include/asm/arch-tegra114/display.h > > new file mode 100644 > > index

Re: [PATCH v6 02/18] video: tegra20: dc: fix image shift on rotated panels

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Subtracting 1 from x and y fixes image shifting on rotated > panels. > > Tested-by: Robert Eckelmann # ASUS Grouper E1565 > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dc.c | 4 ++-- > 1 file changed, 2

Re: [PATCH v6 17/18] video: tegra20: dsi: set correct fifo depth

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > From: Jonas Schwöbel > > According to Thierry Reding's commit in the linux kernel > > 976cebc35bed0456a42bf96073a26f251d23b264 > "drm/tegra: dsi: Make FIFO depths host parameters" > > correct depth of the video FIFO is 1920 *words* no

Re: [PATCH v6 14/18] video: tegra20: dsi: add T114 support

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Existing Tegra DSI driver mostly fits T114 apart MIPI calibration > which on T114 has dedicated driver. To resolve this MIPI calibration > logic was split for pre-T114 and T114+ devices. > > Tested-by: Ion Agorria # HTC One X >

Re: [PATCH v6 01/18] video: tegra20: dc: diverge DC per-SOC

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: [...] > diff --git a/arch/arm/include/asm/arch-tegra114/display.h > b/arch/arm/include/asm/arch-tegra114/display.h > new file mode 100644 > index 00..9411525799 > --- /dev/null > +++ b/arch/arm/include/asm/arch-tegra114/display.h

[PATCH 5/5] board: phytec: Add SOM detection for AM6x

2024-04-19 Thread Daniel Schultz
Add all functions to read each SOM option from the EEPROM image and detect whether it's the correct product for this image. Signed-off-by: Daniel Schultz --- board/phytec/common/Kconfig | 18 +++ board/phytec/common/Makefile| 1 +

[PATCH 4/5] board: phytec: common: Fix eepom is empty check

2024-04-19 Thread Daniel Schultz
The ptr variable is currently defined as int and sizeof returns the size of the eeprom data struct as Byte (32 in total). In case the eeprom is empty, the check, if the eeprom is empty, will most likely stop after 8 iterations because it will continue with the stack which should contain some

[PATCH 3/5] board: phytec: check eeprom_data validity

2024-04-19 Thread Daniel Schultz
From: Yannic Moog For all of the functions that access the eeprom_data, make sure these data are valid. Use the valid member of the phytec_eeprom_data struct. This fixes a bug where only the API revision check guarded against accessing rubbish. But if API revision was e.g. 6, eeprom setup failed

[PATCH 2/5] board: phytec: introduce eeprom struct member 'valid'

2024-04-19 Thread Daniel Schultz
From: Yannic Moog Add a new nember to the eeprom_data that indicates whether the associated data is valid or not. Make use of this new member in the phytec_eeprom_data_init function by setting the valid value appropriately. Move the eeprom data to a new struct payload that holds the payload of

[PATCH 1/5] board: phytec: common: Generic "add extension" function

2024-04-19 Thread Daniel Schultz
Add a generic function to apply overlays in our board code to not implement the same logic in different PHYTEC products. Signed-off-by: Daniel Schultz --- board/phytec/common/phytec_som_detection.c | 33 ++ board/phytec/common/phytec_som_detection.h | 5 2 files

[PATCH 0/5] Update PHYTEC SOM Detection

2024-04-19 Thread Daniel Schultz
This patch series extends PHYTEC's SOM detection by minor fixes, a generic helper function and a new valid flag. Moreover, it adds a module to provide access to the SOM detection for our TI AM6 products. Daniel Schultz (3): board: phytec: common: Generic "add extension" function board:

Re: [PATCH v6 13/18] video: tegra20: add MIPI calibration driver

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Dedicated MIPI calibration driver is used on T114 and newer. Before > T114 MIPI calibration registers were part of VI and CSI. > > Tested-by: Svyatoslav Ryhel # Nvidia Tegratab T114 > Signed-off-by: Svyatoslav Ryhel > --- >

Re: [PATCH v6 06/18] video: tegra20: dc: add reset support

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Implement reset use to discard any changes which could have been > applied to DC before and can interfere with current configuration. > > Tested-by: Agneli # Toshiba AC100 T20 > Tested-by: Robert Eckelmann # ASUS TF101 > Tested-by:

Re: [PATCH v6 18/18] video: tegra20: dsi: use set_backlight for backlight only

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > From: Jonas Schwöbel > > Shift the backlight set further to prevent visual glitches on > panel init. > > Signed-off-by: Jonas Schwöbel > Signed-off-by: Svyatoslav Ryhel > --- > drivers/video/tegra20/tegra-dsi.c | 10 -- > 1

Re: [PATCH v6 03/18] video: tegra20: consolidate DC header

2024-04-19 Thread Thierry Reding
On Tue Jan 23, 2024 at 6:16 PM CET, Svyatoslav Ryhel wrote: > Consolidate HD headers and place the result into video/tegra20 Was this supposed to be "DC" headers like in the subject? Other than that this makes sense, so: Reviewed-by: Thierry Reding signature.asc Description: PGP signature

[PATCH v3 3/3] imx8mm_venice_defconfig: Enable PCIe/NVMe support

2024-04-19 Thread Tim Harvey
Enable PCIe/NVMe support. Also, enable the reset driver which is a prerequisite for PCIe support. Signed-off-by: Tim Harvey --- v3: no changes v2: no changes --- configs/imx8mm_venice_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configs/imx8mm_venice_defconfig

[PATCH v3 2/3] pci: dw_imx: add support for IMX8MM

2024-04-19 Thread Tim Harvey
Add support for the IMX8MM SoC by adding driver data with the compatible string of the GPR controller. Reviewed-by: Marek Vasut Signed-off-by: Tim Harvey --- v3: collected tags v2: do not cache chip info in priv per Marek's suggestion --- drivers/pci/pcie_dw_imx.c | 18 -- 1

[PATCH v3 1/3] clk: imx8mm: Add support for PCIe clocks

2024-04-19 Thread Tim Harvey
Add support for PCIe clocks required to enable PCIe support on iMX8MM SoC. Signed-off-by: Tim Harvey --- v3: wrap pcie clk config around IS_ENABLED to avoid SPL growth as suggested by Marek --- drivers/clk/imx/clk-imx8mm.c | 27 +++ 1 file changed, 27 insertions(+)

Re: [PATCH v4 0/7] Add SE HMBSC board support

2024-04-19 Thread Sumit Garg
Hi Caleb, On Fri, 12 Apr 2024 at 02:54, Sumit Garg wrote: > > SE HMIBSC board is based on Qcom APQ8016 SoC. One of the major > difference from db410c is serial port where HMIBSC board uses UART1 as > the debug console with an RS232 port, patch #2 - #5 adds corresponding > driver support. > >

Re: [PATCH] ARM: imx: Enable kaslrseed command on DH i.MX8M Plus DHCOM

2024-04-19 Thread Tim Harvey
On Thu, Apr 18, 2024 at 11:42 AM Marek Vasut wrote: > > On 4/18/24 8:02 PM, Fabio Estevam wrote: > > Hi Tim, > > > > On Thu, Apr 18, 2024 at 2:54 PM Tim Harvey wrote: > > > >> Fabio, if you enable CONFIG_DM_RNG on an imx8m{m,p}_evk do you get the > >> following in the SPL? > >> Couldn't bind rng

Re: [PATCH v4 2/3] dt-bindings: drop generic headers

2024-04-19 Thread Neil Armstrong
On 18/04/2024 20:39, Caleb Connolly wrote: Drop all the subsystem headers that are compatible with the headers in dts/upstream. Signed-off-by: Caleb Connolly --- include/dt-bindings/ata/ahci.h | 20 - include/dt-bindings/gpio/gpio.h| 42 --

Re: [PATCH 3/3] qcom_defconfig: set SYS_INIT_SP_BSS_OFFSET

2024-04-19 Thread Neil Armstrong
On 18/04/2024 19:24, Caleb Connolly wrote: Give us lots of room for the appended FDT. Signed-off-by: Caleb Connolly --- configs/qcom_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/qcom_defconfig b/configs/qcom_defconfig index 218a9a769682..7b589f0bf7a7 100644 ---

Re: [PATCH 2/3] arm: dts: drop qcom dts files

2024-04-19 Thread Neil Armstrong
On 18/04/2024 19:24, Caleb Connolly wrote: These files are all identical (or older) than those in dts/upstream. Drop them as we now use upstream DTS files with OF_UPSTREAM. Signed-off-by: Caleb Connolly --- arch/arm/dts/apq8016-sbc.dts| 729

Re: [PATCH 1/3] mach-snapdragon: use OF_UPSTREAM

2024-04-19 Thread Neil Armstrong
On 18/04/2024 19:24, Caleb Connolly wrote: Switch to using upstream DT from dts/upstream. Signed-off-by: Caleb Connolly --- MAINTAINERS | 4 arch/arm/Kconfig | 1 + configs/dragonboard410c_defconfig | 2 +- configs/dragonboard820c_defconfig | 2

Re: [PATCH v2 0/7] Tegra panel improvements

2024-04-19 Thread Tom Rini
On Fri, Apr 19, 2024 at 02:29:20PM +0300, Svyatoslav Ryhel wrote: > Hello Tom! This patch set is hanging in patchwork for 3 month > without any comments. If no one has anything to say, may you > pick it into master? There's a number of video related patches outstanding currently, Anatolij will

Re: [PATCH 1/1] efi_loader: superfluous efi_restore_gd after EFI_CALL

2024-04-19 Thread Ilias Apalodimas
On Fri, 19 Apr 2024 at 12:59, Heinrich Schuchardt wrote: > > EFI_CALL() invokes __efi_entry_check() which executes set_gd(efi_gd). > There is no need to execute set_gd(efi_gd) again via efi_restore_gd(). > > Signed-off-by: Heinrich Schuchardt > --- > cmd/bootefi.c | 1 - >

Re: [PATCH 2/3] mach-ipq40xx: import GPIO header from mach-snapgradon

2024-04-19 Thread Robert Marko
On Thu, Apr 18, 2024 at 1:02 PM Caleb Connolly wrote: > > Hi Robert, > > On 18/04/2024 10:14, Robert Marko wrote: > > Pinctrl driver was refactored and moved, but the required header that > > it depends on was not included. > > Thanks for these patches! > > I'm a bit worried about duplicating

Re: [PATCH 3/3] ARM: dts: stm32: Fix partition node name for stm32mp15xx-dhcom-u-boot

2024-04-19 Thread Patrice CHOTARD
On 4/17/24 11:00, Patrick DELAUNAY wrote: > Hi, > > On 3/8/24 14:50, Patrice Chotard wrote: >> Fix flash@0 partition node name with correct offset. >> >> Fixes: 90f992e6a58c ("arm: dts: stm32: Add partitions in flash0 and nand >> node for stm32mp15xx-dhcom/dhcor") >> >> Signed-off-by: Patrice

Re: [PATCH 1/3] ARM: dts: stm32: Fix partition node name for stm32mp157c-ev1-u-boot

2024-04-19 Thread Patrice CHOTARD
On 4/17/24 10:59, Patrick DELAUNAY wrote: > Hi, > > On 3/8/24 14:50, Patrice Chotard wrote: >> Fix flash@0 and nand@0 partition node name with correct offset. >> >> Fixes: e91d3c61767b ("arm: dts: stm32: Add partitions in flash0 and nand >> node for stm32mp15xx-ev1") >> >> Signed-off-by:

  1   2   >