Re: [PATCH] test/py/tests/test_bootstage.py: Combine stash/unstash tests

2024-08-28 Thread Love Kumar
On 29/08/24 4:26 am, Tom Rini wrote: When running the bootstage tests currently we get a warning like: tests/test_bootstage.py::test_bootstage_stash ...PytestReturnNotNoneWarning: Expected None, but tests/test_bootstage.py::test_bootstage_stash returned (37748736, 4096), which will be an err

Re: [PATCH 17/18] rockchip: mmc: Fix a missing colon

2024-08-28 Thread Sughosh Ganu
On Wed, 28 Aug 2024 at 07:18, Simon Glass wrote: > > Add a missing colon in rk3399_emmc_get_phy(). > > Signed-off-by: Simon Glass > --- The change seems to be adding a newline, and not a colon as the commit message is suggesting. -sughosh > > drivers/mmc/rockchip_sdhci.c | 2 +- > 1 file chan

Re: [PATCH] test/py/tests/test_bootstage.py: Combine stash/unstash tests

2024-08-28 Thread Michal Simek
On 8/29/24 00:56, Tom Rini wrote: When running the bootstage tests currently we get a warning like: tests/test_bootstage.py::test_bootstage_stash ...PytestReturnNotNoneWarning: Expected None, but tests/test_bootstage.py::test_bootstage_stash returned (37748736, 4096), which will be an error

Re: How to retrieve cpu info from u-boot fucntion?

2024-08-28 Thread Sourabh Hegde Ramu
Hello Peter, Thanks for the update. Looking at the board/raspberrypi/rpi/rpi.c I think MAC address is only returned for models that have onboard ethernet. but for models raspberry pi 0w / pi 02w it might not return any value. Am I correct? (maybe I overlooked it?) Is there any other approach for t

Re: [PATCH v4 7/9] dts: starfive: Add JH7110 Cadence USB dts node

2024-08-28 Thread E Shattow
On Wed, Aug 28, 2024 at 9:47 PM Sumit Garg wrote: > > Hi, > > On Thu, 29 Aug 2024 at 07:01, Minda Chen wrote: > > > > Add Jh7110 Cadence USB dts node, Visionfive2 default setting > > is USB 2.0 device. > > > > Signed-off-by: Minda Chen > > --- > > .../dts/jh7110-starfive-visionfive-2.dtsi |

Re: [PATCH v4 7/9] dts: starfive: Add JH7110 Cadence USB dts node

2024-08-28 Thread Sumit Garg
Hi, On Thu, 29 Aug 2024 at 07:01, Minda Chen wrote: > > Add Jh7110 Cadence USB dts node, Visionfive2 default setting > is USB 2.0 device. > > Signed-off-by: Minda Chen > --- > .../dts/jh7110-starfive-visionfive-2.dtsi | 5 ++ > arch/riscv/dts/jh7110.dtsi| 53 +++

Grub doesn’t load devicetree

2024-08-28 Thread Tomaž Zaman
I’m working on an arm64 board with an NXP LS1046A CPU and I simply cannot get Grub to load a different device tree than the one that’s provided to it by the EFI Stub. => fatload mmc 0:1 $kernel_addr_r /EFI/boot/grubaa64.efi => fatload mmc 0:1 $fdt_addr_r /boot/dtb/fsl-ls1046a-rdb-sdk.dtb => boot

Re: [PATCH] led: gpio: handle GPIO_ACTIVE_LOW flag properly

2024-08-28 Thread FUKAUMI Naoki
sorry, this patch seems to be wrong. I'll check it again. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. On 8/28/24 21:15, FUKAUMI Naoki wrote: invert gpio state if GPIO_ACTIVE_LOW is specified in dts. Signed-off-by: FUKAUMI Naoki --- drivers/led/led_gpio.c | 5 +

Re: [PATCH] ARM: imx: Wrap i.MX config options in HAVE_IMX

2024-08-28 Thread Marek Vasut
On 8/29/24 3:26 AM, Fabio Estevam wrote: Hi Marek, Hi, On Wed, Aug 28, 2024 at 10:23 PM Marek Vasut wrote: Wrap all the i.MX specific options in HAVE_IMX, otherwise they keep Do you mean MACH_IMX instead? Yes, will be fixed in V2.

[PATCH v4 9/9] MAINTAINERS: Update Starfive visionfive2 maintain files.

2024-08-28 Thread Minda Chen
Add USB related files to Starfive visionfive2 MAINTAINERS. Signed-off-by: Minda Chen Reviewed-by: Marek Vasut --- board/starfive/visionfive2/MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/board/starfive/visionfive2/MAINTAINERS b/board/starfive/visionfive2/MAINTAINERS index d

[PATCH v4 8/9] spl: starfive: star64: Setup USB fdt fixup function

2024-08-28 Thread Minda Chen
Setup star64 USB fdt fixup function. Set dr_mode to host, and add vbus pin (GPIO25), and set USB 3.0 mode. the functions can be used by other 7110 board like Milk-V board. Signed-off-by: Minda Chen --- board/starfive/visionfive2/spl.c | 66 1 file changed, 66 ins

[PATCH v4 7/9] dts: starfive: Add JH7110 Cadence USB dts node

2024-08-28 Thread Minda Chen
Add Jh7110 Cadence USB dts node, Visionfive2 default setting is USB 2.0 device. Signed-off-by: Minda Chen --- .../dts/jh7110-starfive-visionfive-2.dtsi | 5 ++ arch/riscv/dts/jh7110.dtsi| 53 +++ 2 files changed, 58 insertions(+) diff --git a/arch/riscv/

[PATCH v4 6/9] configs: starfive: Add visionfive2 cadence USB configuration

2024-08-28 Thread Minda Chen
Add cadence USB confiuration. Signed-off-by: Minda Chen --- configs/starfive_visionfive2_defconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig index 174ac24dc7..35137eec59 100644 --- a/configs/starf

[PATCH v4 5/9] spl: starfive: visionfive2: Disable USB overcurrent pin by default.

2024-08-28 Thread Minda Chen
For some JH7110 boards, USB host overcurent pin is not reserved, To make USB host work, overcurrent pin must be disabled. So set the pin default disabled in spl stage. Signed-off-by: Minda Chen --- arch/riscv/include/asm/arch-jh7110/gpio.h | 5 + board/starfive/visionfive2/spl.c | 3

[PATCH v4 3/9] phy: starfive: Add Starfive JH7110 PCIe 2.0 PHY driver

2024-08-28 Thread Minda Chen
Add Starfive JH7110 PCIe 2.0 PHY driver, which is generic PHY driver and can be used as USB 3.0 driver. Signed-off-by: Minda Chen --- drivers/phy/starfive/Kconfig | 7 + drivers/phy/starfive/Makefile | 1 + drivers/phy/starfive/phy-jh7110-pcie.c | 237 +

[PATCH v4 4/9] usb: cdns: starfive: Add cdns USB driver

2024-08-28 Thread Minda Chen
Add cdns USB3 wrapper driver. Signed-off-by: Minda Chen --- drivers/usb/cdns3/Kconfig | 7 ++ drivers/usb/cdns3/Makefile | 2 + drivers/usb/cdns3/cdns3-starfive.c | 191 + 3 files changed, 200 insertions(+) create mode 100644 drivers/usb/cdns3/cd

[PATCH v4 2/9] phy: starfive: Add Starfive JH7110 USB 2.0 PHY driver

2024-08-28 Thread Minda Chen
Add Starfive JH7110 USB 2.0 PHY driver, which is generic PHY driver. Signed-off-by: Minda Chen Reviewed-by: Roger Quadros --- drivers/phy/Kconfig| 1 + drivers/phy/Makefile | 1 + drivers/phy/starfive/Kconfig | 14 +++ drivers/phy/starfive/Ma

[PATCH v4 1/9] usb: cdns3: Set USB PHY mode in cdns3_drd_update_mode()

2024-08-28 Thread Minda Chen
USB PHY maybe need to set PHY mode in different USB dr mode. So translate USB PHY mode to generic PHY mode and call generic_phy_set_mode(). Signed-off-by: Minda Chen --- drivers/usb/cdns3/drd.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/usb/cdns3/drd.c b/drivers/

[PATCH v4 0/9] Add Starfive JH7110 Cadence USB driver

2024-08-28 Thread Minda Chen
Add Starfive JH7110 Cadence USB driver and related PHY driver. So the codes can be used in visionfive2 and star64 7110 board. The driver is almost the same with kernel driver. Test with Star64 JH7110 board USB 3.0 + USB 2.0 host. The code can work. - previous version v1: https://patchwork.ozl

Re: [PATCH] ARM: imx: Wrap i.MX config options in HAVE_IMX

2024-08-28 Thread Fabio Estevam
Hi Marek, On Wed, Aug 28, 2024 at 10:23 PM Marek Vasut wrote: > > Wrap all the i.MX specific options in HAVE_IMX, otherwise they keep Do you mean MACH_IMX instead?

[PATCH] ARM: imx: Wrap i.MX config options in HAVE_IMX

2024-08-28 Thread Marek Vasut
Wrap all the i.MX specific options in HAVE_IMX, otherwise they keep showing up in other SoC vendor configurations. No functional change. Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Fabio Estevam Cc: Oleksandr Suvorov Cc: Sean Anderson Cc: Stefano Babic Cc: Tom Rini Cc: u-b

[PATCH] mmc: Hide mmc speed command under mmc command

2024-08-28 Thread Marek Vasut
The mmc speed command configuration option keeps showing up in Kconfig even if CMD_MMC is not set. Move MMC_SPEED_MODE_SET under CMD_MMC to show up the Kconfig option only if MMC command is enabled. Signed-off-by: Marek Vasut --- Cc: AKASHI Takahiro Cc: Francis Laniel Cc: Heinrich Schuchardt C

[PATCH] test/py/tests/test_bootstage.py: Combine stash/unstash tests

2024-08-28 Thread Tom Rini
When running the bootstage tests currently we get a warning like: tests/test_bootstage.py::test_bootstage_stash ...PytestReturnNotNoneWarning: Expected None, but tests/test_bootstage.py::test_bootstage_stash returned (37748736, 4096), which will be an error in a future version of pytest. Did you

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-28 Thread Simon Glass
Hi Tom, On Wed, 28 Aug 2024 at 15:33, Tom Rini wrote: > > On Wed, Aug 28, 2024 at 03:25:00PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 28 Aug 2024 at 14:19, Tom Rini wrote: > > > > > > On Wed, Aug 28, 2024 at 10:45:23AM -0600, Simon Glass wrote: > > > > > > > With Labgrid we don't ne

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-28 Thread Simon Glass
Hi Jonas, On Wed, 28 Aug 2024 at 13:01, Jonas Karlman wrote: > > Hi Simon, > > On 2024-08-28 20:11, Simon Glass wrote: > > Hi again Jonas, > > > > On Wed, 28 Aug 2024 at 11:06, Simon Glass wrote: > >> > >> Hi Jonas, > >> > >> On Wed, 28 Aug 2024 at 10:15, Jonas Karlman wrote: > >>> > >>> Hi Sim

Re: imx8ulp_evk build with buildman fails every other time

2024-08-28 Thread Simon Glass
On Wed, 28 Aug 2024 at 09:40, Jerome Forissier wrote: > > > > On 8/27/24 17:53, Simon Glass wrote: > > Hi Jerome, > > > > On Tue, 27 Aug 2024 at 08:53, Fabio Estevam wrote: > >> > >> Adding Gary and Peng on Cc. > >> > >> On Tue, Aug 27, 2024 at 11:42 AM Jerome Forissier > >> wrote: > >>> > >>> H

Re: [PATCH 00/18] vbe: Series part D

2024-08-28 Thread Simon Glass
Hi Peter, On Wed, 28 Aug 2024 at 03:59, Peter Robinson wrote: > > Hi Simon, > > > This includes various patches towards implementing the VBE abrec > > What is abrec? It's a VBE method which supports A, B and recovery images and permits updating from SPL onwards. The idea is that you can safely u

[PATCH v5 20/20] CI: Allow running tests on sjg lab

2024-08-28 Thread Simon Glass
Add a way to run tests on a real hardware lab. This is in the very early experimental stages. There are only 23 boards and 3 of those are broken! (bob, ff3399, samus). A fourth fails due to problems with the TPM tests. To try this, assuming you have gitlab access, set SJG_LAB=1, e.g.: git push

[PATCH v5 19/20] test: Support testing with two board-builds

2024-08-28 Thread Simon Glass
The Beagleplay board uses two entirely separate builds to produce an image, rather than using an SPL build for this purpose. Handle this in test.py by adding more parameters. Signed-off-by: Simon Glass --- Changes in v5: - Add a patch to support testing with two board-builds test/py/conftest.

[PATCH v5 17/20] test: Try to shut down the lab console gracefully

2024-08-28 Thread Simon Glass
Send the Labgrid quit characters to ask it to exit gracefully. This typically allows it to power off the board being used. If that doesn't work, try the less graceful approach. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_spawn.py | 17 +++-- 1 file changed,

[PATCH v5 16/20] test: Avoid double echo when starting up

2024-08-28 Thread Simon Glass
There is a very annoying bug at present where the terminal echos part of the first command sent to the board. This happens because the terminal is still set to echo for a period until Labgrid starts up and can change this. Fix this by disabling echo (and other terminal features) as soon as the spa

[PATCH v5 18/20] test: Add a section for closing the connection

2024-08-28 Thread Simon Glass
This can take a while and involve multiple steps (e.g. turning the board back off). Add a section for it and show the output. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/py/u_bo

[PATCH v5 15/20] test: Fix mulptiplex_log typo

2024-08-28 Thread Simon Glass
Fix a typo in a comment. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py index e2e78179555..f610fa9a6f8 100644 --- a/test/py/u

[PATCH v5 14/20] test: Improve handling of sending commands

2024-08-28 Thread Simon Glass
We expect commands to be echoed and this should happen quite quickly, since U-Boot is sitting at the prompt waiting for a command. Reduce the timeout for this situation. Try to produce a more useful error message when something goes wrong. Also handle the case where the connection has gone away si

[PATCH v5 12/20] test: Tidy up remaining exceptions

2024-08-28 Thread Simon Glass
Use the new handle_exception() function from ConsoleBase also. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py in

[PATCH v5 11/20] test: Detect dead connections

2024-08-28 Thread Simon Glass
When the connection to a board dies, assume it is dead forever until some user action is taken. Skip all remaining tests. This avoids CI runs taking an hour, with hundreds of 30-second timeouts all to no avail. Signed-off-by: Simon Glass --- (no changes since v1) test/py/conftest.py | 19 +

[PATCH v5 13/20] test: Introduce lab mode

2024-08-28 Thread Simon Glass
There is quite a bit of code in pytest to try to start up U-Boot on a board, with timeouts, expects, etc. This is tedious to maintain and is peripheral to the test system's purpose. It seems better to put this logic in the lab itself, where is can provide such support. With Labgrid we can use the

[PATCH v5 10/20] test: Separate out the exception handling

2024-08-28 Thread Simon Glass
The tests currently catch a very board Exception in each case. This is thrown even in the event of a coding error. We want to handle exceptions differently depending on their severity, so that we can avoid hour-long delays waiting for a board that is clearly broken. As a first step, create some n

[PATCH v5 08/20] test: Introduce the concept of a role

2024-08-28 Thread Simon Glass
In Labgrid there is the concept of a 'role', which is similar to the U-Boot board ID in U-Boot's pytest subsystem. The role indicates both the target and information about the U-Boot build to use. It can also provide any amount of other configuration. The information is obtained using the 'labgrid

[PATCH v5 07/20] test: Create a common function to get the config

2024-08-28 Thread Simon Glass
The settings are decoded in two places. Combine them into a new function, before (in a future patch) expanding the number of items. Signed-off-by: Simon Glass --- (no changes since v1) test/py/conftest.py | 41 - 1 file changed, 28 insertions(+), 13 dele

[PATCH v5 09/20] test: Move the receive code into a function

2024-08-28 Thread Simon Glass
There is quite a bit of code to deal with receiving data from the target so move it into its own receive() function. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_spawn.py | 39 +++ 1 file changed, 27 insertions(+), 12 deletions(-) dif

[PATCH v5 02/20] test: Use a constant for the test timeout

2024-08-28 Thread Simon Glass
Declare a constant rather than open-coding the same value twice. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py index

[PATCH v5 06/20] test: Avoid failing skipped tests

2024-08-28 Thread Simon Glass
When a test returns -EAGAIN this should not be considered a failure. Fix what seems to be a problem case, where the pytests see a failure when a test has merely been skipped. We cannot squash the -EAGAIN error in ut_run_test() since the failure count is incremented by its caller, ut_run_test_live_

[PATCH v5 04/20] test: Release board after tests complete

2024-08-28 Thread Simon Glass
When a board is finished with, the lab may want to power it off, or perform some other function. Add a new script which is called when tests are complete. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_exec_attach.py | 10 ++ 1 file changed, 10 insertions(+

[PATCH v5 05/20] test: Allow connecting to a running board

2024-08-28 Thread Simon Glass
Sometimes we know that the board is already running the right software, so provide an option to allow running of tests directly, without first resetting the board. This saves time when re-running a test where only the Python code is changing. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v5 03/20] test: Pass stderr to stdout

2024-08-28 Thread Simon Glass
Some tests may output things to stderr. Ensure that this output is not dropped, by redirecting it to stdout Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_spawn.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/py/u_boot_spawn.py b/test/py/u_boot_spawn.py index

[PATCH v5 01/20] test: Allow signaling that U-Boot is ready

2024-08-28 Thread Simon Glass
When Labgrid is used, it can get U-Boot ready for running tests. It prints a message when it has done so. Add logic to detect this message and accept it. Signed-off-by: Simon Glass --- (no changes since v1) test/py/u_boot_console_base.py | 9 + 1 file changed, 5 insertions(+), 4 delet

[PATCH v5 00/20] labgrid: Provide an integration with Labgrid

2024-08-28 Thread Simon Glass
Labgrid provides access to a hardware lab in an automated way. It is possible to boot U-Boot on boards in the lab without physically touching them. It relies on relays, USB UARTs and SD muxes, among other things. By way of background, about 4 years ago I wrong a thing called Labman[1] which allowe

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-28 Thread Tom Rini
On Wed, Aug 28, 2024 at 03:25:00PM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 28 Aug 2024 at 14:19, Tom Rini wrote: > > > > On Wed, Aug 28, 2024 at 10:45:23AM -0600, Simon Glass wrote: > > > > > With Labgrid we don't need to specify the various methods, except for > > > the console, which si

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-28 Thread Simon Glass
Hi Tom, On Wed, 28 Aug 2024 at 14:19, Tom Rini wrote: > > On Wed, Aug 28, 2024 at 10:45:23AM -0600, Simon Glass wrote: > > > With Labgrid we don't need to specify the various methods, except for > > the console, which simply calls labgrid-client. > > > > This allows supporting any boards in your

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-28 Thread Simon Glass
Hi Peter, On Wed, 28 Aug 2024 at 12:14, Peter Robinson wrote: > > Hi Simon, > > > With Labgrid we don't need to specify the various methods, except for > > the console, which simply calls labgrid-client. > > > > This allows supporting any boards in your lab, without adding per-board > > configura

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-28 Thread Tom Rini
On Wed, Aug 28, 2024 at 10:45:23AM -0600, Simon Glass wrote: > With Labgrid we don't need to specify the various methods, except for > the console, which simply calls labgrid-client. > > This allows supporting any boards in your lab, without adding per-board > configuration to these hooks. > > P

[PATCH 3/3] x86: coreboot: Enable receiving timestamps from coreboot

2024-08-28 Thread Simon Glass
Bring this information into bootstage. Signed-off-by: Simon Glass --- configs/coreboot_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/coreboot_defconfig b/configs/coreboot_defconfig index 0b103efe16d..692cfd84bf5 100644 --- a/configs/coreboot_defconfig +++ b/configs/cor

[PATCH 2/3] x86: coreboot: Add timestamps from coreboot to bootstage

2024-08-28 Thread Simon Glass
Receiving timestamps from coreboot was unceremoniously dropped some time ago. Add it back. Signed-off-by: Simon Glass Fixes: 8ad01ce36f7 ("x86: Remove x86 specific GD flags as they are...") --- arch/x86/cpu/coreboot/coreboot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/cpu/c

[PATCH 1/3] x86: coreboot: Update the timestamp code to use sysinfo

2024-08-28 Thread Simon Glass
Rather than using a special variable, get the timestamp info from the coreboot sysinfo struct. Return a proper error as well. Signed-off-by: Simon Glass --- arch/x86/cpu/coreboot/timestamp.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/x86/cpu/coreboot/ti

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-28 Thread Tom Rini
On Wed, Aug 28, 2024 at 07:14:01PM +0100, Peter Robinson wrote: > Hi Simon, > > > With Labgrid we don't need to specify the various methods, except for > > the console, which simply calls labgrid-client. > > > > This allows supporting any boards in your lab, without adding per-board > > configurat

Re: [PATCH v4] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-28 Thread Fabio Estevam
Hi Tomas, On Wed, Aug 28, 2024 at 10:09 AM Tomas Paukrt wrote: > > The PSR register works correctly for GPIO pins in input mode, > but always returns 0 for GPIO pins in output mode unless the SION > bit is set. > > The DR register should be used for GPIO pins in output mode > to allow correct get

Re: [PATCH v4] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-28 Thread Marek Vasut
On 8/28/24 3:09 PM, Tomas Paukrt wrote: The PSR register works correctly for GPIO pins in input mode, but always returns 0 for GPIO pins in output mode unless the SION bit is set. The DR register should be used for GPIO pins in output mode to allow correct getting of previously set output value.

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-28 Thread Jonas Karlman
Hi Simon, On 2024-08-28 20:11, Simon Glass wrote: > Hi again Jonas, > > On Wed, 28 Aug 2024 at 11:06, Simon Glass wrote: >> >> Hi Jonas, >> >> On Wed, 28 Aug 2024 at 10:15, Jonas Karlman wrote: >>> >>> Hi Simon, >>> >>> On 2024-08-28 18:01, Simon Glass wrote: Hi Jonas, On Tue, 6

Re: [PATCH 1/2] bootstage: Fix unstash of records from SPL

2024-08-28 Thread Tom Rini
On Wed, Aug 28, 2024 at 08:32:36PM +0200, Jonas Karlman wrote: > Hi Tom, > > On 2024-08-28 20:26, Tom Rini wrote: > > On Sat, 03 Aug 2024 12:41:44 +, Jonas Karlman wrote: > > > >> The commit b81e31a1e6c5 ("bootstash: Do not provide a default address > >> for all") changed a bootstage unstash

Re: [PATCH] ARM: imx: Enable MMU and dcache very early on i.MX8M

2024-08-28 Thread Fabio Estevam
Hi Marek, On Tue, Aug 27, 2024 at 5:04 PM Marek Vasut wrote: > > Enable MMU and caches very early on in the boot process on i.MX8M > in U-Boot proper. This allows board_init_f to run with icache and > dcache enabled, which saves some 700 milliseconds of boot time on > i.MX8M Plus based device. N

Re: [PATCH 1/2] bootstage: Fix unstash of records from SPL

2024-08-28 Thread Jonas Karlman
Hi Tom, On 2024-08-28 20:26, Tom Rini wrote: > On Sat, 03 Aug 2024 12:41:44 +, Jonas Karlman wrote: > >> The commit b81e31a1e6c5 ("bootstash: Do not provide a default address >> for all") changed a bootstage unstash call to bootstage stash, this >> has resulted in bootstage records stashed in

Re: [PATCH v2] mmc: fix signed vs unsigned compare in read check in _spl_load()

2024-08-28 Thread Tom Rini
On Wed, 31 Jul 2024 09:09:00 -0400, Franco Venturi wrote: > Fix signed vs unsigned compare in read check in _spl_load() > > Issue: when info->read() returns a negative value because of an error, >the comparison of 'read' (signed) with 'sizeof(*header)' >(unsigned silently converts

Re: [PATCH 1/2] bootstage: Fix unstash of records from SPL

2024-08-28 Thread Tom Rini
On Sat, 03 Aug 2024 12:41:44 +, Jonas Karlman wrote: > The commit b81e31a1e6c5 ("bootstash: Do not provide a default address > for all") changed a bootstage unstash call to bootstage stash, this > has resulted in bootstage records stashed in SPL no longer get unstaged > in U-Boot proper. Fix t

Re: [PATCH] gpio: Add G7 Aspeed gpio controller driver

2024-08-28 Thread Tom Rini
On Tue, 20 Aug 2024 15:27:36 +0800, Billy Tsai wrote: > In the 7th generation of the SoC from Aspeed, the control logic of the > GPIO controller has been updated to support per-pin control. Each pin now > has its own 32-bit register, allowing for individual control of the pin’s > value, direction,

Re: [PATCH] tools/scripts/Kconfig: Update references from kconfig-language.txt to rst

2024-08-28 Thread Tom Rini
On Mon, 19 Aug 2024 13:24:49 -0300, Hiago De Franco wrote: > The Linux kernel documentation has transitioned from using > kconfig-language.txt to kconfig-language.rst. Therefore update all > occurrences of kconfig-language.txt. > > Applied to u-boot/next, thanks! -- Tom

Re: [PATCH v1] dm: core: Make SPL_DM_SEQ_ALIAS select SPL_STRTO

2024-08-28 Thread Tom Rini
On Mon, 19 Aug 2024 09:43:52 +, Gaskell, Oliver wrote: > Enabling CONFIG_DM_SEQ_ALIAS enables code which relies on > `trailing_strtol()` - which is only linked in SPL when CONFIG_SPL_STRTO > is enabled. > > CONFIG_SPL_STRTO is not enabled by default - to ensure this function is > available in

Re: [PATCH v1] arm: dts: nuvoton: add dts support for npcm845 yosemite4

2024-08-28 Thread Tom Rini
On Mon, 19 Aug 2024 15:24:28 +0800, Jim Liu wrote: > Applied to u-boot/next, thanks! -- Tom

Re: [PATCH] lib: move phdr increment to for loop heading

2024-08-28 Thread Tom Rini
On Sat, 17 Aug 2024 14:02:22 +0300, Maxim Moskalets wrote: > Shifting this pointer in the loop will be more logical when working > with the code later, because you can see at a glance what exactly > changes at each iteration. Moreover, the code remains equivalent > because this variable is not use

Re: [u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-28 Thread Peter Robinson
Hi Simon, > With Labgrid we don't need to specify the various methods, except for > the console, which simply calls labgrid-client. > > This allows supporting any boards in your lab, without adding per-board > configuration to these hooks. > > Provide ellesmere files as an example. What's ellesme

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-28 Thread Simon Glass
Hi again Jonas, On Wed, 28 Aug 2024 at 11:06, Simon Glass wrote: > > Hi Jonas, > > On Wed, 28 Aug 2024 at 10:15, Jonas Karlman wrote: > > > > Hi Simon, > > > > On 2024-08-28 18:01, Simon Glass wrote: > > > Hi Jonas, > > > > > > On Tue, 6 Aug 2024 at 15:50, Simon Glass wrote: > > >> > > >> Hi Jo

Re: [PATCH 00/13] Miscellaneous fixes

2024-08-28 Thread Peter Robinson
On Wed, 28 Aug 2024 at 13:10, Jerome Forissier wrote: > > Miscellaneous fixes made when developing the lwIP series [1]. > > [1] > http://patchwork.ozlabs.org/project/uboot/list/?series=420712&state=%2A&archive=both > > Jerome Forissier (13): > Makefile: detect HOST_ARCH properly when CROSS_COMP

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-28 Thread Simon Glass
Hi Jonas, On Wed, 28 Aug 2024 at 10:15, Jonas Karlman wrote: > > Hi Simon, > > On 2024-08-28 18:01, Simon Glass wrote: > > Hi Jonas, > > > > On Tue, 6 Aug 2024 at 15:50, Simon Glass wrote: > >> > >> Hi Jonas, > >> > >> On Sat, 3 Aug 2024 at 06:42, Jonas Karlman wrote: > >>> > >>> The timer coun

[PATCH v2] list: use list_count_nodes() to count list entries

2024-08-28 Thread Sughosh Ganu
Use the API function list_count_nodes() to count the number of list entries. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass --- Changes since V1: Rebased on top of next boot/scene.c | 8 +--- drivers/mtd/ubi/fastmap.c | 8 +++- fs/yaffs2/yaffs_guts.c| 5 ++--- li

Re: [u-boot-test-hooks PATCH v4 1/3] Create a common file for test scripts

2024-08-28 Thread Tom Rini
On Wed, Aug 28, 2024 at 10:45:21AM -0600, Simon Glass wrote: > The top part of each of the u-boot-test-* files is common. Put it in > a common script file to avoid duplication and to allow it to be > replaced for the Labgrid integration. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini --

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-28 Thread Tom Rini
On Wed, Aug 28, 2024 at 06:15:32PM +0200, Jonas Karlman wrote: > Hi Simon, > > On 2024-08-28 18:01, Simon Glass wrote: > > Hi Jonas, > > > > On Tue, 6 Aug 2024 at 15:50, Simon Glass wrote: > >> > >> Hi Jonas, > >> > >> On Sat, 3 Aug 2024 at 06:42, Jonas Karlman wrote: > >>> > >>> The timer coun

[u-boot-test-hooks PATCH v4 3/3] Provide some basic scripts for Labgrid integration

2024-08-28 Thread Simon Glass
With Labgrid we don't need to specify the various methods, except for the console, which simply calls labgrid-client. This allows supporting any boards in your lab, without adding per-board configuration to these hooks. Provide ellesmere files as an example. Signed-off-by: Simon Glass --- Chan

[u-boot-test-hooks PATCH v4 2/3] Add .none scripts for power off/on

2024-08-28 Thread Simon Glass
These methods don't have a 'none' method right now, but it will be needed for Labgrid. Add these scripts. Note that these are not used by the existing integration, which requires that boards can be powered off and on. Signed-off-by: Simon Glass --- Changes in v4: - Add new patch to add .none sc

[u-boot-test-hooks PATCH v4 1/3] Create a common file for test scripts

2024-08-28 Thread Simon Glass
The top part of each of the u-boot-test-* files is common. Put it in a common script file to avoid duplication and to allow it to be replaced for the Labgrid integration. Signed-off-by: Simon Glass --- Changes in v4: - Use an environment variable to select the Labgrid hooks Changes in v3: - Fal

[u-boot-test-hooks PATCH v4 0/3] Add support for Labgrid

2024-08-28 Thread Simon Glass
This adds hooks for use with Labgrid. The only existing hook that really does anything now is the 'console' one. There is also a new 'getrole' hook which looks up a role to find various things about it, such as the U-Boot board name. Changes in v4: - Use an environment variable to select the Labgr

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-28 Thread Jonas Karlman
Hi Simon, On 2024-08-28 18:01, Simon Glass wrote: > Hi Jonas, > > On Tue, 6 Aug 2024 at 15:50, Simon Glass wrote: >> >> Hi Jonas, >> >> On Sat, 3 Aug 2024 at 06:42, Jonas Karlman wrote: >>> >>> The timer counter on Rockchip SoCs may be reset in TF-A, this may cause >>> the bootstage records to

Re: [PATCH 2/2] bootstage: Do not sort records

2024-08-28 Thread Simon Glass
Hi Jonas, On Tue, 6 Aug 2024 at 15:50, Simon Glass wrote: > > Hi Jonas, > > On Sat, 3 Aug 2024 at 06:42, Jonas Karlman wrote: > > > > The timer counter on Rockchip SoCs may be reset in TF-A, this may cause > > the bootstage records to be printed out of order and with an incorrect > > elapsed tim

Re: imx8ulp_evk build with buildman fails every other time

2024-08-28 Thread Jerome Forissier
On 8/27/24 17:53, Simon Glass wrote: > Hi Jerome, > > On Tue, 27 Aug 2024 at 08:53, Fabio Estevam wrote: >> >> Adding Gary and Peng on Cc. >> >> On Tue, Aug 27, 2024 at 11:42 AM Jerome Forissier >> wrote: >>> >>> Hi, >>> >>> Can someone explain what's happening with the imx8ulp_evk buildman b

[PATCH] mach-imx: do not use if_changed more than once per target

2024-08-28 Thread Jerome Forissier
doc/develop/makefiles.rst has the following note: if_changed should not be used more than once per target. It stores the executed command in a corresponding .cmd file and multiple calls would result in overwrites and unwanted results when the target is up to date and only the tests on ch

Re: How to retrieve cpu info from u-boot fucntion?

2024-08-28 Thread Peter Robinson
Hi, I appear to have missed the first post. > Is there any update on the below request? Are there any functions similar > to eth_get_ethaddr() to retrieve device-specific info? I am working with > raspberry pi 0 and there is no network interface card. > So, eth_get_ethaddr() returns null So ther

Re: u-boot on raspberry pi with secure boot

2024-08-28 Thread Jonas Kvinge
Hi, I have produced a signed linux UKI image. But I need to build u-boot to only allow booting with the signed certificate. So I need a ubootefi.var for (EFI_VAR_SEED_FILE) according tohttps://github.com/u-boot/u-boot/blob/ee2af844ba1b27b2e959c4e649e4b769fbeb4074/lib/efi_loader/Kconfig#L146 How

[PATCH v2] android_ab: Fixes: Fix backup offset calculation

2024-08-28 Thread Joshua Watt
The backup offset is in bytes, but was incorrectly be interpreted as blocks, leading to it being written to the wrong location. Fix the calculation, clarify that ANDROID_AB_BACKUP_OFFSET is in bytes and must be a multiple of the block size, and add a runtime check to validate the offset. Signed-of

Re: How to retrieve cpu info from u-boot fucntion?

2024-08-28 Thread Sourabh Hegde Ramu
Hello, Is there any update on the below request? Are there any functions similar to eth_get_ethaddr() to retrieve device-specific info? I am working with raspberry pi 0 and there is no network interface card. So, eth_get_ethaddr() returns null Thanks in advance On Wed, Jun 19, 2024 at 9:11 AM So

Re: [PATCH v3 0/3] Meson: R/W support for pages used by boot ROM

2024-08-28 Thread Neil Armstrong
Hi, On Mon, 26 Aug 2024 16:17:07 +0300, Arseniy Krasnov wrote: > Patchset is based on patchset for Linux (today merged to nand-next): > https://lore.kernel.org/linux-mtd/20240507230903.3399594-1-avkras...@salutedevices.com/ > > Here is description from it: > > > Amlogic's boot ROM code needs t

Re: [PATCH v4] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-28 Thread Tomas Paukrt
> Changelog is missing, what changed since V3 of this patch ? There was a typo in V3 that caused compilation failure without CONFIG_DM_GPIO.

[PATCH v3 4/4] imx: Remove CFG_MXC_USB_PORTSC

2024-08-28 Thread Fabio Estevam
From: Fabio Estevam The definition of CFG_MXC_USB_PORTSC as (PORT_PTS_UTMI | PORT_PTS_PTW) can be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c. Suggested-by: Tim Harvey Signed-off-by: Fabio Estevam Reviewed

[PATCH v3 3/4] mx5: Remove CFG_MXC_USB_PORT

2024-08-28 Thread Fabio Estevam
From: Fabio Estevam CFG_MXC_USB_PORT is not used anywhere, so remove this unused symbol. Suggested-by: Tim Harvey Signed-off-by: Fabio Estevam Reviewed-by: Peng Fan --- Changes since v2: - None. include/configs/m53menlo.h | 1 - include/configs/mx51evk.h| 1 - include/configs/mx53cx90

[PATCH v3 2/4] usb: ehci-mx5: Add a default for CFG_MXC_USB_PORTSC

2024-08-28 Thread Fabio Estevam
From: Fabio Estevam Just like drivers/usb/host/ehci-mx6.c, add a default for drivers/usb/host/ehci-mx5.c. The motivation for doing this is to remove CFG_MXC_USB_PORTSC from board config files. All the mx5 boards, with the exeption of mx51evk, define CFG_MXC_USB_PORTSC as: #define CFG_MXC_USB_

[PATCH v3 1/4] imx: Remove CFG_MXC_USB_FLAGS

2024-08-28 Thread Fabio Estevam
From: Fabio Estevam CFG_MXC_USB_FLAGS is only used for drivers/usb/host/ehci-mx5.c, so it can be removed from all the imx6/imx7/imx8m board config files. mx51evk.h is the only place CFG_MXC_USB_FLAGS is not set to 0. Suggested-by: Tim Harvey Signed-off-by: Fabio Estevam Reviewed-by: Marek Vas

Re: [PATCH v4] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-28 Thread Marek Vasut
On 8/28/24 3:09 PM, Tomas Paukrt wrote: The PSR register works correctly for GPIO pins in input mode, but always returns 0 for GPIO pins in output mode unless the SION bit is set. The DR register should be used for GPIO pins in output mode to allow correct getting of previously set output value.

Re: [PATCH v3] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-28 Thread Marek Vasut
On 8/28/24 9:58 AM, Lothar Waßmann wrote: Hi, Hi, On Wed, 28 Aug 2024 09:49:44 +0200 (CEST) Tomas Paukrt wrote: You may give a look to this https://lore.kernel.org/u-boot/57015c5f.3080...@denx.de/ Regards, Peng. The Linux driver uses the DR register for about 9 years and the NXP U-Boot d

[PATCH v4] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-28 Thread Tomas Paukrt
The PSR register works correctly for GPIO pins in input mode, but always returns 0 for GPIO pins in output mode unless the SION bit is set. The DR register should be used for GPIO pins in output mode to allow correct getting of previously set output value. Please note that the Linux gpio-mxc driv

Re: [PATCH v6 16/28] mbedtls: add public key porting layer

2024-08-28 Thread Ilias Apalodimas
On Sat, 17 Aug 2024 at 00:51, Raymond Mao wrote: > > Add porting layer for public key on top of MbedTLS X509 library. > Introduce _LEGACY and _MBEDTLS kconfigs for public key legacy and > MbedTLS implementations respectively. > > Signed-off-by: Raymond Mao > --- > Changes in v2 > - Move the porti

Re: [PATCH v6 12/28] mbedtls/external: update MbedTLS PKCS7 test suites

2024-08-28 Thread Ilias Apalodimas
On Sat, 17 Aug 2024 at 00:49, Raymond Mao wrote: > > Update the PKCS7 test suites for multiple certs. > > The PR for this patch is at: > https://github.com/Mbed-TLS/mbedtls/pull/9001 > > For enabling EFI loader PKCS7 features with MbedTLS build, > we need this patch on top of MbedTLS v3.6.0 before

Re: [PATCH v3] gpio: mxc_gpio: fix reading state of GPIO pins in output mode

2024-08-28 Thread Fabio Estevam
Hi Tomas, On Wed, Aug 28, 2024 at 2:58 AM Tomas Paukrt wrote: > regs = (struct gpio_regs *)gpio_ports[port]; > > - val = (readl(®s->gpio_psr) >> gpio) & 0x01; > + if ((readl(®s->gpio_dir) >> offset) & 0x01) This does not build: drivers/gpio/mxc_gpio.c: In function ‘gpio_get

  1   2   >