RE: [PATCH v1 04/20] arm: socfpga: agilex5: Add low level initialization

2024-09-26 Thread Chee, Tien Fong
Hi, > arch/arm/cpu/armv7/lowlevel_init.S:.pushsection .text.s_init, "ax" > arch/arm/cpu/armv7/lowlevel_init.S:WEAK(s_init) > arch/arm/cpu/armv7/lowlevel_init.S:ENDPROC(s_init) > arch/arm/cpu/armv7/lowlevel_init.S: bl s_init > > Maybe such a default lowlevel_

[PATCH v3 2/4] power: regulator: Convert regulators_enable_boot_on/off() to regulator_post_probe

2024-09-26 Thread Marek Vasut
Turn regulators_enable_boot_on() and regulators_enable_boot_off() into empty functions. Implement matching functionality in regulator_post_probe() instead. The regulator_post_probe() is called for all regulators after they probe, and regulators that have regulator-always-on or regulator-boot-on DT

[PATCH v3 4/4] power: regulator: Drop regulators_enable_boot_on/off()

2024-09-26 Thread Marek Vasut
Both regulators_enable_boot_on/off() are unused and superseded by regulator uclass regulator_post_probe(). Remove both functions. Signed-off-by: Marek Vasut --- Cc: Ben Wolsieffer Cc: Caleb Connolly Cc: Chris Morgan Cc: Dragan Simic Cc: Eugen Hristev Cc: Francesco Dolcini Cc: Heinrich Schuc

[PATCH v3 3/4] power: regulator: Drop regulator_unset()

2024-09-26 Thread Marek Vasut
This function is never called, drop it. Signed-off-by: Marek Vasut --- Cc: Ben Wolsieffer Cc: Caleb Connolly Cc: Chris Morgan Cc: Dragan Simic Cc: Eugen Hristev Cc: Francesco Dolcini Cc: Heinrich Schuchardt Cc: Jaehoon Chung Cc: Jagan Teki Cc: Jonas Karlman Cc: Kever Yang Cc: Matteo Li

[PATCH v3 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-09-26 Thread Marek Vasut
In case a regulator DT node contains regulator-always-on or regulator-boot-on property, make sure the regulator gets correctly configured by U-Boot on start up. Unconditionally probe such regulator drivers. This is a preparatory patch for introduction of .regulator_post_probe() which would trigger

[PATCH v2 3/4] image-fit-sig: Remove padding check

2024-09-26 Thread Chia-Wei Wang
The padding algorithm is not mandatory for all signing algorithm. For example, ECDSA does not require a padding method. For RSA requiring PKCS padding, the belonging info->crypto(), assigned with rsa_verify_key(), also has the check on the validity of info->padding(). Thus, remove the info->paddi

[PATCH v2 1/4] lib: ecdsa: Add ECDSA384 support

2024-09-26 Thread Chia-Wei Wang
Add ECDSA384 algorithm support for image signing and verification. Signed-off-by: Chia-Wei Wang Reviewed-by: Simon Glass --- include/u-boot/ecdsa.h | 1 + lib/ecdsa/ecdsa-verify.c | 14 +++--- tools/image-sig-host.c | 7 +++ 3 files changed, 19 insertions(+), 3 deletions(-) d

[PATCH v2 2/4] lib: ecdsa: Create device tree node automatically

2024-09-26 Thread Chia-Wei Wang
Both the signature and the public key are stored as DTS nodes in the FIT image and SPL/U-Boot DTBs. Like the RSA signing & verification do, this patch either creates the nodes or overwirte the content automatically. Signed-off-by: Chia-Wei Wang Reviewed-by: Simon Glass --- lib/ecdsa/ecdsa-libc

Re: [PATCH v5 35/36] configs: Add RPI4 ACPI defconfig

2024-09-26 Thread Tom Rini
On Thu, Sep 26, 2024 at 09:59:23AM +0200, Patrick Rudolph wrote: > Allows to build the RPi4 with ACPI enabled. > > TEST: - Boots on qemu-system-aarch64 -machine raspi4b > - Boots on real hardware with arm_64bit=1 in config.txt > > Signed-off-by: Patrick Rudolph > Reviewed-by: Simon Glass

[2nd RESEND PATCH v2 5/6] mtd: spi-nor: Call spi_nor_post_sfdp_fixups() only after spi_nor_parse_sfdp()

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano This patch follows the upstream linux commit: 5273cc6df984("mtd: spi-nor: core: Call spi_nor_post_sfdp_fixups() only when SFDP is defined") spi_nor_post_sfdp_fixups() was called regardless of if spi_nor_parse_sfdp() had been called or not. late_init() should be instead used

Re: [PATCH v5 36/36] azure-pipelines: Enable qemu_sbsa

2024-09-26 Thread Tom Rini
On Thu, Sep 26, 2024 at 11:29:12PM +0200, Simon Glass wrote: > On Thu, 26 Sept 2024 at 10:12, Patrick Rudolph > wrote: > > > > Add QEMU's SBSA ref board and run tests on it. > > > > Signed-off-by: Patrick Rudolph > > --- > > .azure-pipelines.yml | 8 > > 1 file changed, 8 insertions(+)

Re: [PATCH v2 2/2] regulator: rk8xx: Use buck variable consistently

2024-09-26 Thread Kever Yang
On 2024/9/18 04:59, Jonas Karlman wrote: The buck variable is zero based, i.e. buck=0 match BUCK1 in datasheet. Remove any buck + 1 calculation to be more consistent in usage of the buck variable across the different RK8xx variants in the driver. Signed-off-by: Jonas Karlman Reviewed-by: Ke

[PATCH v2 4/4] drivers/crypto: aspeed: Add Caliptra ECDSA384 support

2024-09-26 Thread Chia-Wei Wang
Aspeed AST27xx SoCs integrate the CPTRA 1.0 secure IP, which export an ECDSA384_SIGNATURE_VERIFY mailbox command service for SoC to use. This patch is verified by the FIT signature verification using the "sha384,ecdsa384" algorithm. Signed-off-by: Chia-Wei Wang Reviewed-by: Simon Glass --- dri

[PATCH v2 0/4] aspeed: ast2700: Add Caliptra ECDSA driver

2024-09-26 Thread Chia-Wei Wang
Aspeed AST2700 SoCs integrates the Caliptra secure IP, where an ECDSA384 signature verification HW interface is exported for SoC crypto needs. This patch series firstly extends the FIT image signing/verify common code to support the ECDSA384 algorithm. For better convenience, the device tree for E

Re: [PATCH v6 01/19] test: Allow signaling that U-Boot is ready

2024-09-26 Thread Tom Rini
On Thu, Sep 26, 2024 at 11:36:00PM +0200, Simon Glass wrote: > Hi Tom, > > On Wed, 25 Sept 2024 at 19:26, Tom Rini wrote: > > > > On Wed, Sep 25, 2024 at 02:49:56PM +0200, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 23 Sept 2024 at 22:35, Tom Rini wrote: > > > > > > > > On Fri, Sep 20,

[RESEND PATCH v2 0/2] mtd: spi-nor-ids: Add NO_CHIP_ERASE flag to Infineon 2Gb parts

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano S25HS02GT, S25HL02GT, and S28HS02GT are dual-die package parts and do not support chip erase. In v2, split the patch and add fixes tag. Takahiro Kuwano (2): mtd: spi-nor-ids: Add NO_CHIP_ERASE flag to Infineon s25hl02Gt and s25hs02gt mtd: spi-nor-ids: Add NO_CHIP_E

[RESEND PATCH v2 2/2] mtd: spi-nor-ids: Add NO_CHIP_ERASE flag to Infineon s28hs02gt

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano S28HS02GT is dual-die package parts and do not support chip erase. Fixes: 16dd1095101 ("mtd: spi-nor-ids: Add Infineon(Cypress) s28hs02gt ID") Reviewed-by: Tudor Ambarus Signed-off-by: Takahiro Kuwano --- drivers/mtd/spi/spi-nor-ids.c | 2 +- 1 file changed, 1 insertion(

[2nd RESEND PATCH v2 2/6] mtd: spi-nor: Allow flashes to specify MTD writesize

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano Some flashes like the Infineon SEMPER NOR flash family use ECC. Under this ECC scheme, multi-pass writes to an ECC block is not allowed. In other words, once data is programmed to an ECC block, it can't be programmed again without erasing it first. Upper layers like file sy

[2nd RESEND PATCH] mtd: spi-nor-ids: Add support for S28HS256T

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano Infineon S28HS256T is 256Mb Octal SPI device which has same functionalities with 512Mb and 1Gb parts. Link:https://www.infineon.com/dgdl/Infineon-S28HS256T_S28HL256T_256Mb_SEMPER_Flash_Octal_interface_1_8V_3-DataSheet-v02_00-EN.pdf?fileId=8ac78c8c8fc2dd9c018fc66787aa0657 Si

[2nd RESEND PATCH v2 1/6] mtd: ubi: Do not zero out EC and VID on ECC-ed NOR flashes

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano For NOR flashes EC and VID are zeroed out before an erase is issued to make sure UBI does not mistakenly treat the PEB as used and associate it with an LEB. But on some flashes, like the Infineon Semper NOR flash family, multi-pass page programming is not allowed on the def

[RESEND PATCH v2 1/2] mtd: spi-nor-ids: Add NO_CHIP_ERASE flag to Infineon s25hl02Gt and s25hs02gt

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano S25HL02GT and S25HS02GT are dual-die package parts and do not support chip erase. Fixes: c95a914aed7 ("mtd: spi-nor-ids: Add Cypress s25hl-t/s25hs-t") Reviewed-by: Tudor Ambarus Signed-off-by: Takahiro Kuwano --- drivers/mtd/spi/spi-nor-ids.c | 4 ++-- 1 file changed, 2

[2nd RESEND PATCH v2 1/3] mtd: spi-nore-core: Fix 4KB erase opcode for s25fs-s

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano The correct 4KB erase opcode should be selected based on the address width currently used. Fixes: 562d166a13 ("mtd: spi-nor-core: Add fixups for s25fs512s") Signed-off-by: Takahiro Kuwano Reviewed-by: Pratyush Yadav Reviewed-by: Dhruva Gole --- drivers/mtd/spi/spi-nor-c

[2nd RESEND PATCH v2 6/6] mtd: spi-nor: Set ECC unit size to MTD writesize in Infineon SEMPER flashes

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano The Infineon SEMPER NOR flash family uses 2-bit ECC by default with each ECC block being 16 bytes. Under this scheme multi-pass programming to an ECC block is not allowed. Set the writesize to make sure multi-pass programming is not attempted on the flash. Acked-by: Tudor A

[2nd RESEND PATCH v2 4/6] mtd: spi-nor: Replace default_init() hook with late_init()

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano default_init() is wrong, it contributes to the maze of initializing flash parameters. We'd like to get rid of it because the flash parameters that it initializes are not really used at SFDP parsing time, thus they can be initialized later. Ideally we want SFDP to initialize

[2nd RESEND PATCH v2 3/6] mtd: spi-nor: Check nor->info before setting macronix_octal_fixups

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano The macronix_octal_fixups should be set only when mfr and flags match. Fixes: df3d5f9e41 ("mtd: spi-nor: add support for Macronix Octal flash") Acked-by: Tudor Ambarus Signed-off-by: Takahiro Kuwano Cc: JaimeLiao --- drivers/mtd/spi/spi-nor-core.c | 4 +++- 1 file chang

[2nd RESEND PATCH v2 0/6] mtd: Make sure UBIFS does not do multi-pass page programming on flashes that don't support it

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano Resent after modifying commit message in #5 (mention Linux commit first) and collecting A-b tags. This series is equivalent to the one for Linux MTD submitted by Pratyush Yadav. https://patchwork.ozlabs.org/project/linux-mtd/list/?series=217759&state=* Changes in v2: -

[2nd RESEND PATCH v2 3/3] mtd: spi-nor-id: Add S25FS064S, S25FS128S, S25FS256S IDs

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano The S25FS064S, S25FS128S, and S25FS256S are the same family of SPI NOR Flash devices with S25FS512S. Some difference depending on the device densities are taken care in post SFDP fixup. Signed-off-by: Takahiro Kuwano Reviewed-by: Pratyush Yadav --- drivers/mtd/spi/spi-no

[2nd RESEND PATCH v2 2/3] mtd: spi-nor-id: Use INFO6 macro for S25FL-S

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano The 6th ID byte is needed to distiguish S25FL-S and S25FS-S families. Signed-off-by: Takahiro Kuwano Reviewed-by: Pratyush Yadav Reviewed-by: Dhruva Gole --- drivers/mtd/spi/spi-nor-ids.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mt

[2nd RESEND PATCH v2 0/3] mtd: spi-nor: Add support for S25FS-S family

2024-09-26 Thread tkuw584924
From: Takahiro Kuwano The S25FS064S, S25FS128S, and S25FS256S are the same family of SPI NOR Flash devices with S25FS512S. Datasheets: https://www.infineon.com/dgdl/Infineon-S25FS064S_64_Mb_8_MB_FS-S_Flash_SPI_Multi-I_O_1-DataSheet-v10_00-EN.pdf?fileId=8ac78c8c7d0d8da4017d0ed526b25412 https://ww

Re: Please pull u-boot-dm/next

2024-09-26 Thread Tom Rini
On Thu, Sep 26, 2024 at 11:22:01PM +0200, Simon Glass wrote: > Hi Tom, > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/22430 > https://dev.azure.com/simon0972/u-boot/_build/results?buildId=68&view=results > > > The following changes since commit 4386ab9118e7b405829fbcb3bbbaf2

Re: [PATCH 14/42] rockchip: Simplify check for SPL

2024-09-26 Thread Tom Rini
On Fri, Sep 27, 2024 at 02:13:32AM +0200, Jonas Karlman wrote: > Hi Simon, > > On 2024-09-27 00:35, Simon Glass wrote: > > Now that SPL means SPL (only) and is not defined for TPL, simplify some > > checks for SPL. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/arm/include/asm/arch-ro

Re: [PATCH v6 10/12] sandbox: virtio: Disable the sandbox virtio blk device

2024-09-26 Thread Tom Rini
On Fri, Sep 27, 2024 at 12:02:21AM +0200, Simon Glass wrote: > This is not implemented so cannot actually be used to read blocks. > Disable it until it is implemented, to avoid causing a hang with EFI, > which probes every available BLK device. > > Signed-off-by: Simon Glass > Issue: https://sou

Re: [PATCH 14/42] rockchip: Simplify check for SPL

2024-09-26 Thread Jonas Karlman
Hi Simon, On 2024-09-27 00:35, Simon Glass wrote: > Now that SPL means SPL (only) and is not defined for TPL, simplify some > checks for SPL. > > Signed-off-by: Simon Glass > --- > > arch/arm/include/asm/arch-rockchip/boot0.h | 3 +-- > arch/arm/mach-rockchip/rk3399/rk3399.c | 2 +- > dr

Re: [PATCH 01/19] spl: Reduce the size of the bl_len field

2024-09-26 Thread Tom Rini
On Thu, Sep 26, 2024 at 11:36:17PM +0200, Simon Glass wrote: > Hi Tom, > > On Thu, 26 Sept 2024 at 06:06, Tom Rini wrote: > > > > On Wed, Sep 25, 2024 at 02:55:27PM +0200, Simon Glass wrote: > > > > > This is a block length, so typicaly 512 bytes. Reduce the size to > > > 16 bits to save space, b

Re: [PATCH 11/19] spl: Support jumping to VPL from TPL

2024-09-26 Thread Tom Rini
On Thu, Sep 26, 2024 at 11:33:52PM +0200, Simon Glass wrote: > Hi Tom, > > On Thu, 26 Sept 2024 at 06:07, Tom Rini wrote: > > > > On Wed, Sep 25, 2024 at 02:55:37PM +0200, Simon Glass wrote: > > > Use spl_get_image_pos() to obtain the image position to jump to. Add > > > the symbols used for VPL

Re: [PATCH 2/9] ARM: dts: socfpga: add Enclustra Intel AA1

2024-09-26 Thread Marek Vasut
On 9/27/24 12:53 AM, Lothar Rubusch wrote: On Thu, Sep 26, 2024 at 3:36 AM Marek Vasut wrote: On 9/26/24 12:49 AM, Lothar Rubusch wrote: Hi, [...] Shall I add the files to my DTS patches and ask for upstreaming of the handoff files into the kernel? Are the handoff files really used by Lin

Re: [PATCH 2/9] ARM: dts: socfpga: add Enclustra Intel AA1

2024-09-26 Thread Lothar Rubusch
On Thu, Sep 26, 2024 at 3:36 AM Marek Vasut wrote: > > On 9/26/24 12:49 AM, Lothar Rubusch wrote: > > Hi, [...] > > Shall I add the files to my DTS patches and ask for upstreaming of the > > handoff files into the kernel? > > Are the handoff files really used by Linux for anything , or do they > c

[PATCH 30/42] global: Rename SPL_TPL_ to PHASE_

2024-09-26 Thread Simon Glass
Use PHASE_ as the symbol to select a particular XPL build. This means that SPL_TPL_ is no-longer set. Update the comment in bootstage to refer to this symbol, instead of SPL_ Signed-off-by: Simon Glass --- Makefile | 2 +- arch/arm/cpu/armv8/Makefile |

[PATCH 00/42] Tidy up use of 'SPL' and CONFIG_SPL_BUILD

2024-09-26 Thread Simon Glass
When the SPL build-phase was first created it was designed to solve a particular problem (the need to init SDRAM so that U-Boot proper could be loaded). It has since expanded to become an important part of U-Boot, with three phases now present: TPL, VPL and SPL Due to this history, the term 'SPL'

Re: [PATCH v2 1/5] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-09-26 Thread Marek Vasut
On 9/26/24 5:05 PM, Jonas Karlman wrote: Hi Marek, Hi, On 2024-09-25 04:21, Marek Vasut wrote: In case a regulator DT node contains regulator-always-on or regulator-boot-on property, make sure the regulator gets correctly configured by U-Boot on start up. Unconditionally probe such regulator

Re: [PATCH 18/27] igep00x0: Drop unused status_led.h header file

2024-09-26 Thread Javier Martinez Canillas
Simon Glass writes: Hello Simon, > This header file is not used, so drop it. > > Signed-off-by: Simon Glass > --- > Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

[PATCH 00/27] led: Remove old status-LED code

2024-09-26 Thread Simon Glass
There has been an LED framework in U-Boot which uses driver model for about 9 years now. Recent work is underway to improve it and provide more features. It is probably a good time to drop the old code, which is only used by 5 boards: ./tools/qconfig.py -f LED_STATUS 5 matches eb_cpu5282

[PATCH 01/42] Makefile: Add a u-boot.cfg file for VPL

2024-09-26 Thread Simon Glass
Create this file for VPL as well, for consistency. Signed-off-by: Simon Glass --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 525576f987d..300cee2e7f6 100644 --- a/Makefile +++ b/Makefile @@ -624,7 +624,7 @@ include/config/%.conf: $(KCO

[PATCH 00/42] Tidy up use of 'SPL' and CONFIG_SPL_BUILD

2024-09-26 Thread Simon Glass
When the SPL build-phase was first created it was designed to solve a particular problem (the need to init SDRAM so that U-Boot proper could be loaded). It has since expanded to become an important part of U-Boot, with three phases now present: TPL, VPL and SPL Due to this history, the term 'SPL'

[PATCH 42/42] doc: Update init docs for the xPL changes

2024-09-26 Thread Simon Glass
Update the documentation here to cover the meaning of xPL Signed-off-by: Simon Glass --- doc/develop/init.rst | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/doc/develop/init.rst b/doc/develop/init.rst index 2955d9bdbc3..ce985781bb4 100644 --- a/doc

[PATCH 41/42] doc: Move init-related things out of README

2024-09-26 Thread Simon Glass
Move this section to rst, changing it just enough so that it builds. Signed-off-by: Simon Glass --- README| 81 - doc/develop/index.rst | 1 + doc/develop/init.rst | 92 +++ 3 files changed, 93 inserti

[PATCH 40/42] README: Drop SoC-specific comment about SPL

2024-09-26 Thread Simon Glass
This should not be in the generic README file, so drop it. Signed-off-by: Simon Glass --- README | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/README b/README index 54ffbd0975b..5115d28fac1 100644 --- a/README +++ b/README @@ -213,15 +213,7 @@ board_init_r():

[PATCH 39/42] xpl: Rename spl_phase_prefix() and spl_phase_name()

2024-09-26 Thread Simon Glass
Use simpler names for these functions. Signed-off-by: Simon Glass --- arch/sandbox/cpu/spl.c | 4 ++-- arch/x86/lib/tpl.c | 2 +- cmd/vbe.c | 2 +- common/spl/spl.c | 5 ++--- include/spl.h | 8 5 files changed, 10 insertions(+), 11 deletions(-) diff --

[PATCH 38/42] xpl: Rename spl_next_phase() and spl_prev_phase()

2024-09-26 Thread Simon Glass
Rename this to use the xpl prefix. Signed-off-by: Simon Glass --- arch/sandbox/cpu/spl.c | 4 ++-- arch/x86/lib/tpl.c | 2 +- common/bloblist.c | 2 +- common/spl/spl.c | 14 +++--- include/spl.h | 8 lib/fdtdec.c | 2 +- 6 files changed,

[PATCH 37/42] xpl: Add a function to indicate when in xPL

2024-09-26 Thread Simon Glass
Add the opposite function to not_xpl() for completeness. Signed-off-by: Simon Glass --- include/spl.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/spl.h b/include/spl.h index bea4d78f8c6..3281b02d63b 100644 --- a/include/spl.h +++ b/include/spl.h @@ -144,6 +144,16 @@

[PATCH 36/42] xpl: Rename spl_in_proper() to not_xpl()

2024-09-26 Thread Simon Glass
Give this function a slightly easier name. Signed-off-by: Simon Glass --- drivers/mtd/nand/raw/sand_nand.c| 2 +- drivers/ram/rockchip/sdram_rk3399.c | 2 +- drivers/serial/ns16550.c| 4 ++-- include/spl.h | 4 ++-- 4 files changed, 6 insertions(+), 6 delet

[PATCH 35/42] xpl: Rename spl_phase() to xpl_phase()

2024-09-26 Thread Simon Glass
Rename this function to indicate that it refers to any xPL phase. Signed-off-by: Simon Glass --- README | 6 +++--- arch/sandbox/cpu/spl.c | 2 +- arch/sandbox/cpu/start.c | 2 +- arch/x86/cpu/apollolake/cpu_spl.c|

[PATCH 34/42] xpl: Rename spl_phase to xpl_phase_t

2024-09-26 Thread Simon Glass
This name fits better with the new naming scheme, so update it. Signed-off-by: Simon Glass --- arch/sandbox/cpu/spl.c | 2 +- common/spl/spl.c | 2 +- doc/device-tree-bindings/bootph.yaml | 2 +- include/spl.h| 12 ++-- 4 file

[PATCH 33/42] xpl: Rename u_boot_first_phase to xpl_is_first_phase()

2024-09-26 Thread Simon Glass
This is a better name for this function, so update it. Tidy up the function comment to mention VPL. Use SPL_BUILD in the SPL check, for clarity. Signed-off-by: Simon Glass --- arch/arm/mach-omap2/am33xx/board.c | 2 +- common/bloblist.c | 4 ++-- common/spl/spl.c

[PATCH 32/42] qconfig: Update tool for new Makefile variables

2024-09-26 Thread Simon Glass
Take account of the new XPL_ and PHASE_ instead of the old SPL_ and SPL_TPL_ Signed-off-by: Simon Glass --- tools/qconfig.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/qconfig.py b/tools/qconfig.py index 7b4934b726d..058d72cf4bc 100755 --- a/too

[PATCH 31/42] spl: Rename SPL_TPL_NAME and SPL_TPL_PROMPT

2024-09-26 Thread Simon Glass
Rename these to use the word PHASE instead. Signed-off-by: Simon Glass --- common/spl/spl.c| 36 ++-- common/spl/spl_fit.c| 2 +- common/spl/spl_legacy.c | 2 +- include/spl.h | 14 +++--- 4 files changed, 27 insertions(+), 27 dele

[PATCH 29/42] global: Rename SPL_ to XPL_

2024-09-26 Thread Simon Glass
Use XPL_ as the symbol to indicate an SPL build. This means that SPL_ is no-longer set. Signed-off-by: Simon Glass --- Makefile| 4 +-- arch/arm/config.mk | 6 ++-- arch/arm/cpu/arm920t/Makefile | 2 +- arch/arm/cpu/arm926ejs/Mak

[PATCH 28/42] drivers: Simplify Makefile condition

2024-09-26 Thread Simon Glass
If TPL is enabled, XPL must be, so drop the redundant check. Signed-off-by: Simon Glass --- drivers/bus/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile index e14cb7fd9c7..b7e6452c48c 100644 --- a/drivers/bus/Makefile +++ b

[PATCH 27/42] rockchip: Simplify Makefile condition

2024-09-26 Thread Simon Glass
If TPL is enabled, XPL must be, do drop the redundant check. Signed-off-by: Simon Glass --- arch/arm/mach-rockchip/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/Makefile b/arch/arm/mach-rockchip/Makefile index 76756c3661b..70f0af4733c 100644

[PATCH 26/42] kconfig: binman: Check for SPL instead of XPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for other phases, update kconfig rules. Signed-off-by: Simon Glass --- include/linux/kconfig.h| 10 +- tools/binman/test/generated/autoconf.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/

[PATCH 25/42] drivers: Simplify Makefile checks

2024-09-26 Thread Simon Glass
The extra ifdefs can be avoided now. Tidy up this Makefile Signed-off-by: Simon Glass --- drivers/Makefile | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/Makefile b/drivers/Makefile index 1b7db812828..260bde957db 100644 --- a/drivers/Makefile +++ b/drivers/M

[PATCH 24/42] stdio: Make use of the SERIAL define

2024-09-26 Thread Simon Glass
This is always enabled for U-Boot proper, so simplify the condition in the common Makefile. Signed-off-by: Simon Glass --- include/stdio.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/include/stdio.h b/include/stdio.h index 56609b846ff..d42fdd2728c 100644 --- a/includ

[PATCH 23/42] serial: Make use of the SERIAL define

2024-09-26 Thread Simon Glass
This is always enabled for U-Boot proper, so simplify the condition in the common Makefile. Signed-off-by: Simon Glass --- common/Makefile | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/common/Makefile b/common/Makefile index 9fdad4bc38d..ae8984659c0 100644 --- a/

[PATCH 22/42] powerpc: Correct check for SPL

2024-09-26 Thread Simon Glass
This variable does not exist so the condition will never be met. Fix it. Signed-off-by: Simon Glass --- arch/powerpc/lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile index b218ae2b91c..64ac4930b62 100644 --- a

[PATCH 21/42] spl: Simplify check for SPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for TPL, simplify some checks for SPL. Signed-off-by: Simon Glass --- include/spl.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/spl.h b/include/spl.h index dd9aeeaf9cc..415d198da56 100644 --- a/include/spl.h

[PATCH 20/42] dm: Simplify check for SPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for TPL, simplify some checks for SPL. Signed-off-by: Simon Glass --- drivers/core/ofnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c index 129b34a5cd2..1ea6dd0e58a 100644 --

[PATCH 19/42] mtd: Simplify check for SPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for TPL, simplify some checks for SPL. Signed-off-by: Simon Glass --- drivers/mtd/Makefile | 2 +- drivers/mtd/nand/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/Makefile b/drivers/mtd/Makefile i

[PATCH 18/42] freescale: Simplify check for SPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for TPL, simplify some checks for SPL. Signed-off-by: Simon Glass --- board/congatec/common/Makefile| 4 +--- board/freescale/common/Makefile | 4 +--- board/freescale/p1010rdb/Makefile | 4 +--- board/freescale/p1_p2_rdb_pc/Mak

Re: [PATCH v14 0/8] spi-nor: Add parallel and stacked memories support

2024-09-26 Thread Tom Rini
On Thu, Sep 26, 2024 at 10:25:00AM +0530, Venkatesh Yadav Abbarapu wrote: > This series adds support for Xilinx qspi parallel and > stacked memeories. > > In parallel mode, the current implementation assumes that a maximum > of two flashes are connected. The QSPI controller splits the data > even

[PATCH 17/42] x86: Simplify check for SPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for TPL, simplify some checks for SPL. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/fsp_bindings.c | 2 +- arch/x86/cpu/broadwell/cpu_full.c | 2 +- arch/x86/lib/Makefile | 9 ++--- 3 files changed, 4 insertion

[PATCH 16/42] powerpc: Simplify check for SPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for TPL, simplify some checks for SPL. Signed-off-by: Simon Glass --- arch/powerpc/cpu/mpc83xx/Makefile | 4 +--- arch/powerpc/lib/Makefile | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/cpu/mpc83xx/

[PATCH 15/42] mips: Simplify check for SPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for TPL, simplify some checks for SPL. Signed-off-by: Simon Glass --- arch/mips/mach-mtmips/mt7621/Makefile | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/arch/mips/mach-mtmips/mt7621/Makefile b/arch/mips/mach-mt

[PATCH 14/42] rockchip: Simplify check for SPL

2024-09-26 Thread Simon Glass
Now that SPL means SPL (only) and is not defined for TPL, simplify some checks for SPL. Signed-off-by: Simon Glass --- arch/arm/include/asm/arch-rockchip/boot0.h | 3 +-- arch/arm/mach-rockchip/rk3399/rk3399.c | 2 +- drivers/clk/rockchip/clk_rk3368.c | 8 drivers/ram/r

[PATCH 13/42] xpl: Define CONFIG_SPL_BUILD only for the SPL build

2024-09-26 Thread Simon Glass
Make this define mean SPL only, not TPL, VPL, etc. Signed-off-by: Simon Glass --- scripts/Makefile.autoconf | 4 ++-- scripts/Makefile.xpl | 9 ++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/scripts/Makefile.autoconf b/scripts/Makefile.autoconf index d7544022a31..

[PATCH 12/42] boot: Drop unnecessary ifdef for LOAD_FIT

2024-09-26 Thread Simon Glass
Use the normal SPL_TPL_ approach for this option. Signed-off-by: Simon Glass --- boot/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/boot/Makefile b/boot/Makefile index 299a22ed689..5bf07e83388 100644 --- a/boot/Makefile +++ b/boot/Makefile @@ -58,9 +58,7 @@ obj

[PATCH 11/42] qconfig: Add XPL_BUILD to ignored symbols

2024-09-26 Thread Simon Glass
This now appears in the code base, so add it to the list of ignored symbols in qconfig Signed-off-by: Simon Glass --- tools/qconfig.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/qconfig.py b/tools/qconfig.py index 8c2fc9efc5f..71e911eeb3b 100755 --- a/tools/qconfi

[PATCH 10/42] log: global: Rename warn_non_spl() and update the condition

2024-09-26 Thread Simon Glass
This should now refer to xPL rather than SPL, so update it throughout the tree. Signed-off-by: Simon Glass --- arch/arm/lib/cache.c | 2 +- doc/develop/logging.rst | 2 +- drivers/spi/spi-uclass.c | 4 ++-- include/log.h| 10 +- 4 files changed, 9 insertions(+), 9 de

[PATCH 09/42] tegra: Use SPL instead of SPL_BUILD

2024-09-26 Thread Simon Glass
SPL_BUILD is not a Kconfig symbol so presumably the intent here is to use SPL instead. Change it. Signed-off-by: Simon Glass --- arch/arm/mach-tegra/tegra124/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-tegra/tegra124/Kconfig b/arch/arm/mach-teg

[PATCH 08/42] x86: Update a comment to mention XPL

2024-09-26 Thread Simon Glass
This uses XPL now, so update the comment. Signed-off-by: Simon Glass --- arch/x86/cpu/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/cpu/cpu.c b/arch/x86/cpu/cpu.c index fbd23af6ce9..ea11b09eacc 100644 --- a/arch/x86/cpu/cpu.c +++ b/arch/x86/cpu/cpu.c @@ -247

[PATCH 07/42] net: freescale: Drop use of SPL_BUILD dependency

2024-09-26 Thread Simon Glass
SPL_BUILD is not a Kconfig symbol. Perhaps the intent here is to use SPL instead. However, this causes build errors, e.g. with T1024RDB_NAND So drop the dependency on !SPL_BUILD since it does nothing. Signed-off-by: Simon Glass --- drivers/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 06/42] doc: Update SPL docs for the xPL changes

2024-09-26 Thread Simon Glass
Update the various references to SPL in this document. Make sure to refer to 'phases' instead of 'stages', which is not a U-Boot term. Fix a few U-boot typos and try to improve grammar a little while we are here. Signed-off-by: Simon Glass --- doc/develop/spl.rst | 81 -

[PATCH 04/42] scripts: Define CONFIG_XPL_BUILD for all xPL builds

2024-09-26 Thread Simon Glass
The new name 'xPL' is intended to indicate a build of any phase which is not U-Boot proper. Define it for all such phases. Note that we also define CONFIG_SPL_BUILD for all xPL builds. This preserves existing behaviour, but future patches will adjust that. Signed-off-by: Simon Glass --- script

[PATCH 03/42] scripts: Add some comments about autoconf.mk

2024-09-26 Thread Simon Glass
Now that the conversion of all CONFIG options to Kconfig is complete, these files only contain the xPL_BUILD defines. Add a comment to make this clear. Signed-off-by: Simon Glass --- scripts/Makefile.xpl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/Makefile.xpl b/scripts/Ma

[PATCH 02/42] scripts: Rename Makefile.spl to Makefile.xpl

2024-09-26 Thread Simon Glass
Rename this file to indicate that it refers to any non-U-Boot-proper phase, not just SPL, which is the phase immediately before U-Boot proper. Signed-off-by: Simon Glass --- Makefile | 6 +++--- scripts/{Makefile.spl => Makefile.xpl} | 0 2 files changed, 3 inserti

[PATCH 01/42] Makefile: Add a u-boot.cfg file for VPL

2024-09-26 Thread Simon Glass
Create this file for VPL as well, for consistency. Signed-off-by: Simon Glass --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 525576f987d..300cee2e7f6 100644 --- a/Makefile +++ b/Makefile @@ -624,7 +624,7 @@ include/config/%.conf: $(KCO

Re: [PATCH v1 04/20] arm: socfpga: agilex5: Add low level initialization

2024-09-26 Thread Marek Vasut
On 9/26/24 8:02 AM, Chee, Tien Fong wrote: Hi, Hi, arch/arm/cpu/armv7/lowlevel_init.S:.pushsection .text.s_init, "ax" arch/arm/cpu/armv7/lowlevel_init.S:WEAK(s_init) arch/arm/cpu/armv7/lowlevel_init.S:ENDPROC(s_init) arch/arm/cpu/armv7/lowlevel_init.S: bl s_init Maybe such a default

[PATCH 00/27] led: Remove old status-LED code

2024-09-26 Thread Simon Glass
There has been an LED framework in U-Boot which uses driver model for about 9 years now. Recent work is underway to improve it and provide more features. It is probably a good time to drop the old code, which is only used by 5 boards: ./tools/qconfig.py -f LED_STATUS 5 matches eb_cpu5282

Re: [PATCH 15/15] binman: Make a start on an iMX8 test

2024-09-26 Thread Marek Vasut
On 9/27/24 12:07 AM, Simon Glass wrote: This patch is for Marek, to provide a starting point. To try it, use 'binman test -T' and see the missing coverage. Signed-off-by: Simon Glass --- tools/binman/etype/nxp_imx8mimage.py | 3 ++- tools/binman/ftest.py| 4 tools/b

Re: [PATCH 19/27] mx23_olinuxino: Drop status-LED code

2024-09-26 Thread Marek Vasut
On 9/27/24 12:10 AM, Simon Glass wrote: Hi Marek, Hello Simon, On Thu, 26 Sept 2024 at 23:40, Marek Vasut wrote: On 9/26/24 10:44 PM, Simon Glass wrote: This is not used anymore, so drop it. Signed-off-by: Simon Glass --- board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 --- 1

Re: [PATCH v5 17/36] drivers: ata: Rename ahci_mvebu

2024-09-26 Thread Tony Dinh
On Thu, Sep 26, 2024 at 1:02 AM Patrick Rudolph wrote: > > Rename 'ahci_mvebu' to 'ahci_generic' and select it by default. > The AHCI driver contains no SoC specific code and only expects the > base address to be passed, thus rename it to ahci_generic and add the > DT compatible string "generic-ah

Re: [PATCH 19/27] mx23_olinuxino: Drop status-LED code

2024-09-26 Thread Simon Glass
Hi Marek, On Thu, 26 Sept 2024 at 23:40, Marek Vasut wrote: > > On 9/26/24 10:44 PM, Simon Glass wrote: > > This is not used anymore, so drop it. > > > > Signed-off-by: Simon Glass > > --- > > > > board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 --- > > 1 file changed, 7 deletions(-) > >

Re: [PATCH v3 2/3] buildman: Allow skipping the dtc build

2024-09-26 Thread Simon Glass
Hi Tom, On Thu, 12 Sept 2024 at 19:44, Tom Rini wrote: > > On Wed, Sep 11, 2024 at 07:01:37PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 10 Sept 2024 at 16:07, Tom Rini wrote: > > > > > > On Tue, Sep 10, 2024 at 02:14:35PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On T

Re: [PATCH v2 13/14] buildman: Retry the build for current source

2024-09-26 Thread Simon Glass
Buildman retries a failed build when processing a branch, but does not do this when building current source. It is useful to do this retry in both cases, so add the logic for it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 8 1 file changed,

Re: [PATCH 02/15] binman: Correct the comment for fdtgrep

2024-09-26 Thread Simon Glass
This returns stdout, not a CommandResult so update the comment. Signed-off-by: Simon Glass --- tools/binman/btool/fdtgrep.py | 3 +-- tools/binman/etype/fit.py | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 01/15] binman: Fix up test coverage for mkeficapsule

2024-09-26 Thread Simon Glass
Add tests for missing tools to complete the test coverage for this etype. Signed-off-by: Simon Glass --- tools/binman/etype/efi_capsule.py | 2 ++ tools/binman/ftest.py | 22 +- 2 files changed, 23 insertions(+), 1 deletion(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 03/15] binman: Tidy up comments for Entry.GetEntryArgsOrProps()

2024-09-26 Thread Simon Glass
Improve the comments for this function. Signed-off-by: Simon Glass --- tools/binman/entry.py | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 04/15] binman: Tidy up comments and pylint warnings in fit

2024-09-26 Thread Simon Glass
Update this entry type to resolve some pylint warnings and make sure that functions and members are fully commented. Signed-off-by: Simon Glass --- tools/binman/etype/fit.py | 73 ++- 1 file changed, 42 insertions(+), 31 deletions(-) Applied to u-boot-dm/nex

Re: [PATCH 05/15] binman: Avoid setting the image_pos attribute directly

2024-09-26 Thread Simon Glass
Two places set this attribute directly. Update them to use the function provided. Signed-off-by: Simon Glass --- tools/binman/etype/atf_fip.py | 2 +- tools/binman/etype/cbfs.py| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm/next, thanks!

Re: [PATCH 06/15] binman: Update fdt-list-dir to use the provided directory

2024-09-26 Thread Simon Glass
Since the files are known to be in the provided directory, use that instead of requiring it to be added to the list of input directories. Signed-off-by: Simon Glass --- tools/binman/etype/fit.py | 10 -- tools/binman/ftest.py | 7 ++- 2 files changed, 14 insertions(+), 3 deleti

Re: [PATCH 07/15] binman: fit: Avoid assuming that a FIT member is a section

2024-09-26 Thread Simon Glass
Use the more generic variable name 'entry' to avoid confusion. Signed-off-by: Simon Glass --- tools/binman/etype/fit.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-dm/next, thanks!

  1   2   3   >