Re: [PATCH 04/40] lib: Convert str_to_list() to use alist

2024-07-29 Thread Sughosh Ganu
On Mon, 29 Jul 2024 at 23:46, Tom Rini wrote: > > On Mon, Jul 29, 2024 at 09:28:57AM -0600, Simon Glass wrote: > > Hi Sughosh, > > > > On Sun, 28 Jul 2024 at 12:07, Sughosh Ganu wrote: > > > > > > On Thu, 25 Jul 2024 at 18:24, Sughosh Ganu > > > wrote: > > > > > > > > On Thu, 25 Jul 2024 at

Re: [PATCH 00/12] omap configuration cleanups

2024-07-29 Thread Tom Rini
On Sun, Jul 28, 2024 at 10:24:49PM +0200, Paul Kocialkowski wrote: > Here is a bunch of configuration cleanups for OMAP boards, mostly > unifying and moving common configuration from board-specific defconfigs > to Kconfig definitions. > > There's also a cleanup of the sniper (LG Optimus Black)

Re: [PATCH 13/14] Update u-boot.cfg to include CFG also

2024-07-29 Thread Tom Rini
On Sun, Jul 28, 2024 at 01:36:09PM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 28 Jun 2024 at 01:33, Simon Glass wrote: > > > > Hi Tom, > > > > On Thu, 27 Jun 2024 at 15:42, Tom Rini wrote: > > > > > > On Thu, Jun 27, 2024 at 09:37:15AM +0100, Simon Glass wrote: > > > > Hi Tom, > > > > > >

Re: Please pull u-boot-dm

2024-07-29 Thread Tom Rini
On Mon, Jul 29, 2024 at 10:19:00AM -0600, Simon Glass wrote: > Hi Tom, > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/21789 > https://dev.azure.com/simon0972/u-boot/_build/results?buildId=66=results > > The following changes since commit

Re: [PATCH 04/40] lib: Convert str_to_list() to use alist

2024-07-29 Thread Tom Rini
On Mon, Jul 29, 2024 at 09:28:57AM -0600, Simon Glass wrote: > Hi Sughosh, > > On Sun, 28 Jul 2024 at 12:07, Sughosh Ganu wrote: > > > > On Thu, 25 Jul 2024 at 18:24, Sughosh Ganu wrote: > > > > > > On Thu, 25 Jul 2024 at 02:24, Tom Rini wrote: > > > > > > > > On Wed, Jul 24, 2024 at

Re: [PATCH 04/40] lib: Convert str_to_list() to use alist

2024-07-29 Thread Sughosh Ganu
On Mon, 29 Jul 2024 at 20:59, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 28 Jul 2024 at 12:07, Sughosh Ganu wrote: > > > > On Thu, 25 Jul 2024 at 18:24, Sughosh Ganu wrote: > > > > > > On Thu, 25 Jul 2024 at 02:24, Tom Rini wrote: > > > > > > > > On Wed, Jul 24, 2024 at 11:31:48AM +0530,

Re: [PATCH 06/40] alist: add a couple of helper functions

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:03, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:03, Sughosh Ganu wrote: > > > > Add a couple of helper functions to detect an empty and full alist. > > > > Signed-off-by: Sughosh Ganu > > --- > > Changes since rfc: None > > > > include/alist.h |

Re: [PATCH 06/35] arm: friendlyarm: Avoid accessing global_data fb_base

2024-07-29 Thread Stefan Bosch
Hi Simon, On 24.07.24 17:08, Simon Glass wrote: Use the new video function to get the framebuffer base. Signed-off-by: Simon Glass --- Tested-by: Stefan Bosch Looks OK, tested on FriendlyElec-Board NanoPC-T2 (s5p4418_nanopi2_defconfig). Thanks! board/friendlyarm/nanopi2/board.c |

Re: [PATCH v4 3/4] alist: Add support for an allocated pointer list

2024-07-29 Thread Tom Rini
On Fri, Jul 26, 2024 at 08:54:52AM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 26 Jul 2024 at 08:33, Tom Rini wrote: > > > > On Fri, Jul 26, 2024 at 08:00:37AM -0600, Simon Glass wrote: > > > In various places it is useful to have an array of structures, but allow > > > it to grow. In some

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-29 Thread Simon Glass
Hi Chris, On Mon, 29 Jul 2024 at 10:45, Chris Webb wrote: > > Hi Simon, > > Simon Glass wrote: > > > Well, yes, mt7981_pinctrl is wrong since it is not actually binding > > the GPIO devices until it itself is probed. It should do it when it is > > bound. > > Oh I see! Yes, I can see the

Re: [PATCH] rockchip: rk3308: Update otp node in u-boot dtsi to match v6.11-rc1

2024-07-29 Thread Jonas Karlman
Hi Quentin, On 2024-07-29 10:48, Quentin Schulz wrote: > Hi Jonas, > > On 7/24/24 9:44 AM, Jonas Karlman wrote: >> The merged upstream DT node for OTP differs slightly, update node in >> rk3308-u-boot.dtsi to match Linux kernel v6.11-rc1 in order to reduce >> possible issue in future when

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-29 Thread Chris Webb
Hi Simon, Simon Glass wrote: Well, yes, mt7981_pinctrl is wrong since it is not actually binding the GPIO devices until it itself is probed. It should do it when it is bound. Oh I see! Yes, I can see the mtk_gpiochip_register(dev) in mtk_pinctrl_common_probe() exactly as you say.

Re: [PATCH v2 24/26] qconfig: Allow searching for CONFIG values

2024-07-29 Thread Simon Glass
Add basic support for searching for matching of non-matching values. Signed-off-by: Simon Glass Fixes: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/20 --- Changes in v2: - Drop debugging doc/develop/qconfig.rst | 14 ++ tools/qconfig.py| 15 +++

Re: [PATCH v2 26/26] qconfig: Support a 'list' format

2024-07-29 Thread Simon Glass
Add a flag to output the found list in a more user-friendly format, with one board per line. Omit the board count. This can be useful with grep, for example. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to support a 'list' format tools/qconfig.py | 14 ++ 1 file

Re: [PATCH v2 25/26] qconfig: Sort the boards by name when finding

2024-07-29 Thread Simon Glass
There is no particular ordering of the board list at present, since it is generated by a multi-threaded process. Sort them by name to make it easier to see if a particular board is present. Signed-off-by: Simon Glass --- Changes in v2: - Add a new patch to sort the boards by name when finding

Re: [PATCH 03/20] binman: Tidy up bintool docs

2024-07-29 Thread Simon Glass
The docs have somehow got out of sync. Regenerate the file to fix the problem. Signed-off-by: Simon Glass --- tools/binman/bintools.rst | 61 --- 1 file changed, 38 insertions(+), 23 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 01/20] fixdep: Support VPL

2024-07-29 Thread Simon Glass
Add VPL support in this tool. Signed-off-by: Simon Glass Fixes: f86ca5ad8f7 ("Introduce Verifying Program Loader (VPL)") --- scripts/basic/fixdep.c | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 02/20] binman: Correct an error in the FIT-template example

2024-07-29 Thread Simon Glass
The example contains references to an non-existent node. Fix it. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 04/20] binman: Tidy up comment for Bintoolfdt_add_pubkey.run()

2024-07-29 Thread Simon Glass
This function returns a value, so add documentation for it. Signed-off-by: Simon Glass --- tools/binman/btool/fdt_add_pubkey.py | 4 1 file changed, 4 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 05/20] binman: Move problem-checking code into a function

2024-07-29 Thread Simon Glass
This has become quite long, so move it into a separate function. Signed-off-by: Simon Glass --- tools/binman/control.py | 78 - 1 file changed, 46 insertions(+), 32 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 06/20] binman: elf: Add more debugging to LookupAndWriteSymbols()

2024-07-29 Thread Simon Glass
When symbol-writing does not appear to work, it can sometimes be hard to figure out what is going on. Add some more debugging to help. Signed-off-by: Simon Glass --- tools/binman/elf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 07/20] binman: Write the compressed output to a file

2024-07-29 Thread Simon Glass
When an entry is compressed, write the compressed contents to a file so that it is possible to see what was produced. This aids debugging with new images. Signed-off-by: Simon Glass --- tools/binman/entry.py | 3 +++ 1 file changed, 3 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 08/20] binman: Correct comment in blob_dtb GetFdtEtype()

2024-07-29 Thread Simon Glass
The filenames are a bit confused. Fix them. Signed-off-by: Simon Glass --- tools/binman/etype/blob_dtb.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 09/20] binman: Mention expanded entries in u-boot-vpl

2024-07-29 Thread Simon Glass
Add a comment about this entry type being expanded, to match the comment for SPL and TPL. Drop an unwanted line in the SPL and TPL docs while here. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 11 +-- tools/binman/etype/u_boot_spl_nodtb.py | 2 --

Re: [PATCH 10/20] binman: Fix a comment typo in _DoReadFileDtb()

2024-07-29 Thread Simon Glass
Fix a minor typo in this function. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 11/20] binman: Correct indentation in testSplPubkeyDtb

2024-07-29 Thread Simon Glass
This function has strange indentation. Fix it. Fixes: 8c1fbd1f607 ("binman: ftest: Add test for u_boot_spl_pubkey_dtb") Signed-off-by: Simon Glass --- tools/binman/ftest.py | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) Applied to u-boot-dm,

Re: [PATCH 12/20] binman: Add a bintool for fdtgrep

2024-07-29 Thread Simon Glass
Binman needs the ability to run fdtgrep to prepare devicetree subsets for use by SPL and TPL. Add a new bintool in preparation for this. Signed-off-by: Simon Glass --- tools/binman/bintools.rst | 8 ++ tools/binman/btool/fdtgrep.py | 137 ++ 2 files

Re: [PATCH 13/20] binman: Remove dependency on pylibfdt for entry-docs

2024-07-29 Thread Simon Glass
Allow the entry-docs command to operate even if pylibfdt is not present in the systemn. Signed-off-by: Simon Glass --- tools/binman/image.py | 7 +++ 1 file changed, 7 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 15/20] binman: Add support for alternative FDTs

2024-07-29 Thread Simon Glass
FIT provides a way to select between different devicetree blobs depending on the model. This works fine for U-Boot proper and allows SPL to select the correct blob for the current board at runtime. The boot sequence (SPL->U-Boot proper) is therefore covered by the existing feature set. The first

Re: [PATCH 14/20] binman: Allow entry types to override FDT contents

2024-07-29 Thread Simon Glass
At present the contents of an FDT (for each phase) are fixed, determined by the build and provided to Binman as input files. Provide a means for entry types to provide their own FDT, so that it can be processed, if needed. Signed-off-by: Simon Glass --- tools/binman/entry.py | 12

Re: [PATCH 16/20] binman: fit: Allow providing FDT filenames in a directory

2024-07-29 Thread Simon Glass
In some cases the list of available FDT files is not available in an entryarg. Provide an option to point to a directory containing them instead. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 7 tools/binman/etype/fit.py | 19 -

Re: [PATCH 19/20] Makefile: Provide VPL devicetree and padding to binman

2024-07-29 Thread Simon Glass
Provide these parameters to binman so that it can produce images targeted at VPL. Signed-off-by: Simon Glass --- Makefile | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 18/20] binman: fit: Allow running fdtgrep on devicetree blobs

2024-07-29 Thread Simon Glass
When using FIT to load firmware builds for multiple models, the FIT must include a common binary along with a number of devicetree blobs, one for each model. This is the same mechanism as is used for loading an OS. However, SPL builds do not normally use the full devicetree, but instead a

Re: [PATCH 17/20] binman: fit: Write the compatible string to configuration

2024-07-29 Thread Simon Glass
FIT allows the FDT's root-node compatible string to be placed in a configuration node to simplify and speed up finding the best match for booting. Add a new property to support this. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 5 ++ tools/binman/etype/fit.py

Re: [PATCH 20/20] Makefile: Pass OF_SPL_REMOVE_PROPS to binman

2024-07-29 Thread Simon Glass
Pass CONFIG_OF_SPL_REMOVE_PROPS to binman so that it can remove properties correctly when producing FITs for SPL phases. Signed-off-by: Simon Glass --- Makefile | 1 + tools/binman/etype/fit.py | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) Applied to u-boot-dm,

Please pull u-boot-dm

2024-07-29 Thread Simon Glass
Hi Tom, https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/21789 https://dev.azure.com/simon0972/u-boot/_build/results?buildId=66=results The following changes since commit 9366640449ac3ef702b624e2f6f7604754a9082b: Merge tag 'dm-pull-26jul24' of

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-29 Thread Simon Glass
Hi Chris, On Mon, 29 Jul 2024 at 09:44, Chris Webb wrote: > > Simon Glass wrote: > > > We cannot probe devices when they are bound since it breaks the > > ordering of driver model. > > > > From your trace it looks like everything is happening after > > relocation. I can't quite see what is

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-29 Thread Chris Webb
Simon Glass wrote: We cannot probe devices when they are bound since it breaks the ordering of driver model. From your trace it looks like everything is happening after relocation. I can't quite see what is actually going wrong. But if you look at dm_init_and_scan(), it does the probe at the

Re: [PATCH 17/40] lmb: introduce a function to add memory to the lmb memory map

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:00, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > > > > > Introduce a function lmb_add_memory() to add available memory to the > > > LMB memory

Re: [PATCH 04/40] lib: Convert str_to_list() to use alist

2024-07-29 Thread Simon Glass
Hi Sughosh, On Sun, 28 Jul 2024 at 12:07, Sughosh Ganu wrote: > > On Thu, 25 Jul 2024 at 18:24, Sughosh Ganu wrote: > > > > On Thu, 25 Jul 2024 at 02:24, Tom Rini wrote: > > > > > > On Wed, Jul 24, 2024 at 11:31:48AM +0530, Sughosh Ganu wrote: > > > > > > > From: Simon Glass > > > > > > > >

Re: [PATCH 00/17] Implement ACPI on aarch64

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > Based on the existing work done by Simon Glass this series adds > support for booting aarch64 devices using ACPI only. As target the > Raspberry Pi4 was used, which is broadly available and allows easy > testing of the proposed

Re: [PATCH 17/17] configs: Add RPI4 ACPI defconfig

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > Allows to build the RPi4 with ACPI enabled. > > TEST: - Boots on qemu-system-aarch64 -machine raspi4b > - Boots on real hardware with arm_64bit=1 in config.txt > > Signed-off-by: Patrick Rudolph > Cc: Simon Glass > Cc:

Re: [PATCH 16/17] arm: mach-bcm283x: Enable ARMV8_MULTIENTRY

2024-07-29 Thread Simon Glass
On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > On FDT platforms the APs are brought out of reset using the spin-table > as defined in the DT. On ACPI enabled platforms there's no FDT, thus > enable the ARMV8_MULTIENTRY to use the ACPI parking protocol instead. > > TEST: - Aps enter

Re: [PATCH 15/17] arm: mach-bcm283x: Add ARMV8_MULTIENTRY support

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > When ACPI is enabled over FDT the APs cannot be brought out of reset > by the OS using the "FDT spin-table" mechanism, as no FDT is provided > to the OS. The APs must be released out of reset in u-boot and then > brought up in

Re: [PATCH 14/17] arm: cpu: Add ACPI parking protocol support

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > On Arm platforms that use ACPI they cannot rely on the "spin-table" > CPU bringup usually defined in the FDT. Thus implement the > 'ACPI Multi-processor Startup for ARM Platforms', also referred to as > 'ACPI parking protocol'.

Re: [PATCH 13/17] board: raspberrypi: Add ASL files from tianocore

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > From: Simon Glass broken email address > > Add the necessary DSDT files copied from tianocore to boot the RPi4. > In addition generate a board specific SSDT to dynamically enable/disable > ACPI devices based on FDT. This is

Re: [PATCH 12/17] arm: bcm283x: Write ACPI tables

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > Allocate a 64KiB buffer for ACPI tables and provide SoC specific tables > for BCM2711: > - MADT > - FADT > - PPTT > - GTDT > - SPCR > > Board specific tables like DSDT and SSDT are added in a separate patch. > > When ACPI is

Re: [PATCH 09/17] acpi: Add ACPITAB for PPTT and GTDT

2024-07-29 Thread Simon Glass
On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > Return the ACPI table revision in acpi_get_table_revision() for > PPTT and GTDT. Match both to ACPI 6.2. > > Signed-off-by: Patrick Rudolph > Cc: Simon Glass > --- > include/acpi/acpi_table.h | 2 ++ > lib/acpi/acpi_table.c | 4

Re: [PATCH 08/17] acpi: acpi_table: Bump revisions

2024-07-29 Thread Simon Glass
On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > The FADT structure found in U-Boot represents FADT revision 6 and the > GICC and GICD structures defined in U-Boot are based on ACPI revision > 6.3. > > Bump the table revision to fix FWTS failures seen on aarch64. > > Signed-off-by:

Re: [PATCH 07/17] arm: acpi: Add generic ACPI methods

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > Add generic ACPI code to generate > - MADT GICC > - MADT GICD > > as commonly used on arm platforms. > > Signed-off-by: Patrick Rudolph > Cc: Tom Rini > Cc: Simon Glass > --- > arch/arm/include/asm/acpi_table.h | 18

Re: [PATCH 06/17] acpi: Add define for GTDT

2024-07-29 Thread Simon Glass
On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > Add the interrupt flag used in ACPI GTDT table as define. > > Signed-off-by: Patrick Rudolph > Cc: Simon Glass > --- > include/acpi/acpi_table.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH 05/17] serial: serial_pl01x: Implement .getinfo() for PL01

2024-07-29 Thread Simon Glass
On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > From: Maximilian Brune > > When ACPI is enabled on arm it will use the getinfo function to fill > the SPCR ACPI table. > > Signed-off-by: Maximilian Brune > Cc: Simon Glass > Cc: Tom Rini > --- > boot/bootflow.c | 8

Re: [PATCH 04/17] acpi: Fix typo

2024-07-29 Thread Simon Glass
On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > Rename ACPI tables MADR to MADT. > > Signed-off-by: Patrick Rudolph > Cc: Simon Glass > --- > include/acpi/acpi_table.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 03/17] acpi: x86: Move MADT to common code

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > Write MADT in common code and let the SoC fill out the body by > calling acpi_fill_madt() which must be implemented at SoC level. > > Signed-off-by: Patrick Rudolph > Cc: Simon Glass > Cc: Bin Meng > --- >

Re: [PATCH 02/17] acpi: x86: Write FADT in common code

2024-07-29 Thread Simon Glass
Hi Patrick, On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > From: Maximilian Brune > > Write the FADT in common code since it's used on all architectures. > Let the cpu code fill out the FADT body by introducing a new weak > function acpi_fill_fadt(). This should be done using the

Re: [PATCH 01/17] acpi: x86: Move SPCR and DBG2 into common code

2024-07-29 Thread Simon Glass
On Sat, 27 Jul 2024 at 01:20, Patrick Rudolph wrote: > > From: Maximilian Brune > > This moves the SPCR and DBG2 table generation into common code, so that > they can be used by architectures other than x86. > > Signed-off-by: Maximilian Brune > Signed-off-by: Patrick Rudolph > Cc: Simon Glass

Re: [PATCH 5/6] efi: Use malloc() for the EFI pool

2024-07-29 Thread Simon Glass
Hi Ilias, On Mon, 29 Jul 2024 at 04:02, Ilias Apalodimas wrote: > > Hi Simon > > On Fri, 26 Jul 2024 at 17:54, Simon Glass wrote: > > > > Hi Ilias, > > > > On Fri, 26 Jul 2024 at 02:31, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > > > > On Fri, 26 Jul 2024 at 02:33, Simon

Re: [PATCH 40/40] lmb: ut: re-enable unit tests

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:58, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:03, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:06, Sughosh Ganu wrote: > > > > > > All the changes needed for making the LMB memory map persistent and > > > global have

Re: [PATCH 36/40] test: lmb: add a separate class of unit tests for lmb

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:56, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:03, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > > > > > Add the LMB unit tests under a separate class of tests. The LMB tests > > > involve

Re: [PATCH 33/40] test: cedit: use allocated address for reading file

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:53, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > > > > > Instead of a randomly selected address, use an LMB allocated one for > > > reading the

Re: [PATCH 30/40] sandbox: iommu: remove lmb allocation in the driver

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:52, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > > > > > The sandbox iommu driver uses the LMB module to allocate a particular > > > range of

Re: [PATCH 25/40] sandbox: move the TCG event log to the start of ram memory

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:45, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > > > > > The TCG event log buffer is being set at the end of ram memory. This > > > region of

Re: [PATCH 24/40] lmb: add a common implementation of arch_lmb_reserve()

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:42, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > > > > > Almost all of the current definitions of arch_lmb_reserve() are doing > > > the same

Re: [PATCH 23/40] lmb: add a flags parameter to the API's

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:40, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > > > > > Add a flags parameter to the LMB API functions. The parameter can then > > > be used to

Re: [PATCH 22/40] lmb: init: initialise the lmb data structures during board init

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 02:36, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > > > > > The memory map maintained by the LMB module is now persistent and > > > global. This

Re: [PATCH 05/40] spl: alloc: call full alloc functions if malloc pool is available

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 01:46, Sughosh Ganu wrote: > > hi Simon, > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:03, Sughosh Ganu wrote: > > > > > > If the malloc simple functionality is enabled in SPL, it is not > > >

Re: [PATCH 11/40] lmb: make LMB memory map persistent and global

2024-07-29 Thread Simon Glass
Hi Sughosh, On Mon, 29 Jul 2024 at 01:50, Sughosh Ganu wrote: > > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 24 Jul 2024 at 00:03, Sughosh Ganu wrote: > > > > > > The current LMB API's for allocating and reserving memory use a > > > per-caller based

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-29 Thread Simon Glass
Hi Chris, On Thu, 13 Jun 2024 at 04:59, Chris Webb wrote: > > 48b3ecbe replumbed the gpio-hog probing to use DM_FLAG_PROBE_AFTER_BIND. > > Unfortunately gpio_post_bind is called after the non-preloc recursive > dm_probe_devices completes, so setting this flag does not have the intended > effect

Re: [PATCH v5 18/20] net-lwip: add TFTP_BLOCKSIZE

2024-07-29 Thread Jerome Forissier
Hi Ilias, On 7/29/24 14:29, Ilias Apalodimas wrote: > Hi Jerome, > > On Thu, 25 Jul 2024 at 15:59, Jerome Forissier > wrote: >> >> Add support for setting the TFTP block size. The default value (1468) >> is fine for Ethernet and allows a better throughput than the TFTP >> default (512), if the

Re: M68K Vectors

2024-07-29 Thread Peter LaDow
I tried both the gcc-12.2 and the gcc-14.1, and both exhibit the same problem I am seeing. And I tried it with the M5373EVB which is included w/ u-boot. >From the arch/m68k/cpu/mcf530x/start.S: _vectors: .long 0x #if defined(CONFIG_M5307) && \ (CONFIG_TEXT_BASE ==

Re: [PATCH v1 2/4] cmd: ab: introduce 'ab_dump' command to print BCB block content

2024-07-29 Thread Dmitry Rokosov
On Sun, Jul 28, 2024 at 01:36:04PM -0600, Simon Glass wrote: > Hi Dmitry, > > On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov > wrote: > > > > It's really helpful to have the ability to dump BCB block for debugging > > A/B logic on the board supported this partition schema. > > > > Command

Re: [PATCH v1 4/4] common: android_ab: fix slot suffix for abc block

2024-07-29 Thread Dmitry Rokosov
On Sun, Jul 28, 2024 at 01:36:06PM -0600, Simon Glass wrote: > Hi Dmitry, > > On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov > wrote: > > > > To align with the official Android BCB (Boot Control Block) > > specifications, it's important to note that the slot_suffix should start > > with an

Re: [PATCH v1 3/4] test/py: introduce test for ab_dump command

2024-07-29 Thread Dmitry Rokosov
Hello Simon, On Sun, Jul 28, 2024 at 01:36:05PM -0600, Simon Glass wrote: > Hi Dmitry, > > On Thu, 25 Jul 2024 at 14:55, Dmitry Rokosov > wrote: > > > > The ab_dump command allows you to display ABC data directly on the > > U-Boot console. During an A/B test execution, this test verifies the >

Re: M68K Vectors

2024-07-29 Thread Peter LaDow
It's not solved yet. I forgot I had hard coded some items. I will give the flavors you suggest a try. I'm trying to add the MCF548x for a legacy board we have. It's near EOL, but we want to leverage uBoot from some in house work. Thanks, Pete On Sun, Jul 28, 2024 at 2:04 PM Angelo Dureghello

Re: [PATCH 3/3] tpm_tcg2: hash algo optimization

2024-07-29 Thread Ilias Apalodimas
On Mon, Jul 15, 2024 at 01:33:19PM +, Benjamin BARATTE wrote: > To properly enable code optimization with hash algorithm, all the > reference of the hash algo should condition to hash enablement. > It is possible to fine tune the list of hash algorithms based on dTPM > configuration. >

Re: [PATCH 2/3] tpm: remove check on pcr bank count

2024-07-29 Thread Ilias Apalodimas
On Mon, Jul 15, 2024 at 01:33:18PM +, Benjamin BARATTE wrote: > The number of PCR banks return by the tpm2_get_pcr_info() is related to > TPM supported list of hash algorithm that could be greater than thus > supported by U-Boot. This is not an issue as long as the PCR active bank > hash an

Re: [PATCH v4 20/29] lib/crypto: Adapt x509_cert_parser to MbedTLS

2024-07-29 Thread Raymond Mao
On Mon, 29 Jul 2024 at 09:20, Ilias Apalodimas wrote: > Hi Raymond > > > > > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_X509) > > +/* Backup of part of the parsing context */ > > I am not sure I understand the comment > > We can remove this comment line. > > +struct x509_cert_mbedtls_ctx { > > +

Re: [PATCH 1/3] tpm: update tpm hash algorithm according to tpm2.0 spec 1.59

2024-07-29 Thread Ilias Apalodimas
Hi Benjamin, Apologies for the late reply, but I wasn't cc'ed in the series. Did you use get_maintainer.pl for the recipients? On Mon, Jul 15, 2024 at 01:33:16PM +, Benjamin BARATTE wrote: > The hash algorithm structure shall reflect the TCG specification for > TPM2.0 > With vesion 1.59,

Re: [PATCH v4 18/29] lib/crypto: Adapt public_key header with MbedTLS

2024-07-29 Thread Ilias Apalodimas
On Tue, 2 Jul 2024 at 21:31, Raymond Mao wrote: > > Previous patch has introduced MbedTLS porting layer for public key, > here to adjust the header and makefiles accordingly. > > Signed-off-by: Raymond Mao > --- > Changes in v2 > - Move the porting layer to MbedTLS dir. > Changes in v3 > -

Re: [PATCH v4 20/29] lib/crypto: Adapt x509_cert_parser to MbedTLS

2024-07-29 Thread Ilias Apalodimas
Hi Raymond > > +#if CONFIG_IS_ENABLED(MBEDTLS_LIB_X509) > +/* Backup of part of the parsing context */ I am not sure I understand the comment > +struct x509_cert_mbedtls_ctx { > + void*tbs; /* Signed data */ > + void*raw_serial;/* Raw serial

Re: [PATCH 1/1] riscv: define find_{first,next}_zero_bit in asm/bitops.h

2024-07-29 Thread Maxim Kochetkov
27.07.2024 13:35, E Shattow wrote: Is this a problem in Linux upstream? or specific to U-Boot, and is it a regression? refrerence https://lore.kernel.org/u-boot/20240504183354.GL2568172@bill-the-cat/ and reference

Re: [PATCH v5 12/20] net: split cmd/net.c into cmd/net.c and cmd/net-common.c

2024-07-29 Thread Ilias Apalodimas
On Thu, 25 Jul 2024 at 15:59, Jerome Forissier wrote: > > Extract some code from cmd/net.c that will be useful in a subsequent > commit to implement wget with NET_LWIP. > > Signed-off-by: Jerome Forissier > --- > cmd/Makefile | 5 ++- > cmd/net-common.c | 109

Re: [PATCH v5 18/20] net-lwip: add TFTP_BLOCKSIZE

2024-07-29 Thread Ilias Apalodimas
Hi Jerome, On Thu, 25 Jul 2024 at 15:59, Jerome Forissier wrote: > > Add support for setting the TFTP block size. The default value (1468) > is fine for Ethernet and allows a better throughput than the TFTP > default (512), if the server supports the blksize option of course. > > I tested this

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-07-29 Thread Svyatoslav Ryhel
пн, 29 лип. 2024 р. о 13:42 Marek Vasut пише: > > On 7/29/24 7:38 AM, Svyatoslav Ryhel wrote: > > [...] > > >> The PMIC is on I2C, DM_PMIC enabled in SPL, both buck4 and buck5 > >> regulators are enabled in SPL, have regulator-always-on and > >> regulator-boot-on and bootph-pre-ram properties. >

Re: [PATCH V7 3/7] doc: board: ti: Update to use the new boot firmware labels

2024-07-29 Thread Francesco Dolcini
On Thu, Jul 25, 2024 at 06:58:23AM -0500, Nishanth Menon wrote: > On 15:05-20240725, Dhruva Gole wrote: > > Use the new boot_firmwares labels that help make documentation more > > specific as to which firmwares are used in which devices > > > > Signed-off-by: Dhruva Gole > > --- > >

[PATCH] rockchip: configs: puma-rk3399: disable VIDEO support that breaks Linux

2024-07-29 Thread Quentin Schulz
From: Quentin Schulz RK3399 Puma has support for driving multiple displays at the same time, the most notable scenario being HDMI+DSI since there exists a devkit with both DSI display and HDMI output. While HDMI seems to work fine in U-Boot, as the U-Boot logo is shown whenever the EFI bootmeth

Re: [PATCH 1/4] power: regulator: Trigger probe of regulators which are always-on or boot-on

2024-07-29 Thread Marek Vasut
On 7/29/24 7:38 AM, Svyatoslav Ryhel wrote: [...] The PMIC is on I2C, DM_PMIC enabled in SPL, both buck4 and buck5 regulators are enabled in SPL, have regulator-always-on and regulator-boot-on and bootph-pre-ram properties. This seems similar enough, right ? Yes, though SPL must remain as

Re: [PATCH 5/6] efi: Use malloc() for the EFI pool

2024-07-29 Thread Ilias Apalodimas
Hi Simon On Fri, 26 Jul 2024 at 17:54, Simon Glass wrote: > > Hi Ilias, > > On Fri, 26 Jul 2024 at 02:31, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > > > On Fri, 26 Jul 2024 at 02:33, Simon Glass wrote: > > > > > > Hi Heinrich, > > > > > > On Thu, 25 Jul 2024 at 09:54, Heinrich

[PATCH v1] timer: npcm: Change counter source

2024-07-29 Thread Jim Liu
The counter value read from TDR register may not be correct. Read SECCNT and CNTR25M instead to get the correct timestamp. Signed-off-by: Jim Liu --- drivers/timer/npcm-timer.c | 83 ++ 1 file changed, 22 insertions(+), 61 deletions(-) diff --git

Re: [PATCH 40/40] lmb: ut: re-enable unit tests

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:03, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:06, Sughosh Ganu wrote: > > > > All the changes needed for making the LMB memory map persistent and > > global have been made, including making corresponding changes in the > > test code. Re-enable the

Re: [PATCH 36/40] test: lmb: add a separate class of unit tests for lmb

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:03, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > > > Add the LMB unit tests under a separate class of tests. The LMB tests > > involve changing the LMB's memory map. With the memory map now > > persistent and global,

Re: [PATCH 33/40] test: cedit: use allocated address for reading file

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > > > Instead of a randomly selected address, use an LMB allocated one for > > reading the file into memory. With the LMB map now being persistent > > and global, the address

[PATCH v1] gpio: npcm: Add SGPIO support for Nuvoton NPCM SoCs

2024-07-29 Thread Jim Liu
Add Nuvoton BMC NPCM7xx/NPCM8xx sgpio driver. BMC can use this driver to increase 64 GPI pins and 64 GPO pins to use. Signed-off-by: Jim Liu --- drivers/gpio/Kconfig | 9 ++ drivers/gpio/Makefile | 1 + drivers/gpio/npcm_sgpio.c | 291 ++ 3 files

Re: [PATCH 30/40] sandbox: iommu: remove lmb allocation in the driver

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > > > The sandbox iommu driver uses the LMB module to allocate a particular > > range of memory for the device virtual address(DVA). This used to work > > earlier since the

Re: [PATCH 27/40] spl: sandbox: initialise the ram banksize in spl

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:05, Sughosh Ganu wrote: > > > > Initialise the ram bank information for sandbox in SPL. This is needed > > for initialising the LMB memory map as part of the platform init. > > I don't understand what

Re: [PATCH] rockchip: rk3308: Update otp node in u-boot dtsi to match v6.11-rc1

2024-07-29 Thread Quentin Schulz
Hi Jonas, On 7/24/24 9:44 AM, Jonas Karlman wrote: The merged upstream DT node for OTP differs slightly, update node in rk3308-u-boot.dtsi to match Linux kernel v6.11-rc1 in order to reduce possible issue in future when devicetree-rebasing v6.11-dts is merged. Why not simply cherry-picking

Re: [PATCH 25/40] sandbox: move the TCG event log to the start of ram memory

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > > > The TCG event log buffer is being set at the end of ram memory. This > > region of memory is to be reserved as LMB_NOMAP memory in the LMB > > memory map. The current

Re: [PATCH 24/40] lmb: add a common implementation of arch_lmb_reserve()

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > > > Almost all of the current definitions of arch_lmb_reserve() are doing > > the same thing. The only exception in a couple of cases is the > > alignment parameter

Re: [PATCH 23/40] lmb: add a flags parameter to the API's

2024-07-29 Thread Sughosh Ganu
On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 24 Jul 2024 at 00:04, Sughosh Ganu wrote: > > > > Add a flags parameter to the LMB API functions. The parameter can then > > be used to pass any other type of reservations or allocations needed > > by the callers. These

Re: [PATCH] rockchip: dts: rk3568: Sync the evb board name with kernel

2024-07-29 Thread Quentin Schulz
Hi Kever, On 7/29/24 9:18 AM, Kever Yang wrote: The name of rk3568 evb in mainline kernel is rk3568-evb1-v10. Signed-off-by: Kever Yang Reviewed-by: Quentin Schulz Thanks! Quentin

  1   2   3   4   5   6   7   8   9   10   >