Re: [U-Boot] [PATCH] rockchip: i2c: don't sent stop bit after each message

Hi Vasily, 在 2019/11/17 3:32, Vasily Khoruzhick 写道: + rk_i2c_send_stop_bit(i2c); + rk_i2c_disable(i2c); I think it is better to also stop i2c if i2c xfer failed, how do you feel about it? @@ -356,11 +356,16 @@ static int rockchip_i2c_xfer(struct udevice *bus, struct i2c_msg

Re: [U-Boot] [Resend] [U-Boot, v4, 7/7] net: gmac_rockchip: Add handeling for RGMII_ID/RXID/TXID

Resend it for Undelivered Mail. 在 2018/8/31 19:54, David.Wu 写道: Hi Janine, This patch looks good. Thank you for adding rgmii-id/rxid/txid. Reviewed-by: David Wu 在 2018/8/28 14:25, Janine Hagemann 写道: Using PHY internal delays in combination with the phy-mode rgmii-id/rxid/txid

Re: [U-Boot] [U-Boot, v4, 6/7] net: gmac_rockchip: Fix a register write in rk3328_gmac_set_to_rgmii

Hi Janine, Thank you for the fix. 在 2018/8/28 14:25, Janine Hagemann 写道: We have to use RK3328_RXCLK_DLY_ENA_GMAC_ENABLE instead of RK3328_RXCLK_DLY_ENA_GMAC_MASK in rk3328_gmac_set_to_rgmii() to enable the RX delay. The MASK was used in a wrong way. Signed-off-by: Janine Hagemann

Re: [U-Boot] [U-Boot, v4, 7/7] net: gmac_rockchip: Add handeling for RGMII_ID/RXID/TXID

Hi Janine, This patch looks good. Thank you for adding rgmii-id/rxid/txid. Reviewed-by: David Wu 在 2018/8/28 14:25, Janine Hagemann 写道: Using PHY internal delays in combination with the phy-mode rgmii-id/rxid/txid was not possible. Only rgmii was supported. Now we can disable rockchip's gmac

Re: [U-Boot] [U-Boot, v2, 16/18] clk: rockchip: Add rk322x gamc clock support

‘assigned-clocks-wip’ branch (which I manually mirror onto GitHub, so I can test via Travis-CI). Comments are welcome, Phil. On 4 Jan 2018, at 14:22, David.Wu <david...@rock-chips.com> wrote: Hi Philipp, Could i just make the clock-driver respond to the requested frequency? I.e. 50MHz w

Re: [U-Boot] [PATCH v2 14/18] rockchip: pinctrl: rk322x: Move the iomux definitions into pinctrl-driver

Hi Heiko 在 2017/12/26 2:59, Heiko Stuebner 写道: Hi David, Am Donnerstag, 9. November 2017, 17:24:58 CET schrieb David Wu: diff --git a/arch/arm/mach-rockchip/rk322x-board-spl.c b/arch/arm/mach-rockchip/rk322x-board-spl.c index 35f4f97..f7c6045 100644 ---

Re: [U-Boot] [PATCH v2 17/18] net: gmac_rockchip: Add support for the RK3228 GMAC

Hi Heiko, Yes, Next plan I want to implement the integrated-phy, because some customers are also consulting this feature, but the current RMII/RGMII of internal/external mac_clk compatible configuration still has a problem, I want to solve this first. 在 2017/12/26 4:45, Heiko Stuebner 写道:

Re: [U-Boot] [U-Boot, v2, 16/18] clk: rockchip: Add rk322x gamc clock support

Hi Philipp, 在 2017/11/26 22:50, Philipp Tomsich 写道: On Thu, 9 Nov 2017, David Wu wrote: Assuming mac_clk is fed by an external clock, set clk_rmii_src clock select control register from IO for rgmii interface. Signed-off-by: David Wu Acked-by: Philipp Tomsich

Re: [U-Boot] [U-Boot, 5/6] net: gmac_rockchip: Use the proerty of "clock_in_out" to set mac clock

Spam detection software, running on the system "lists.denx.de", has identified this incoming email as possible spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview:

Re: [U-Boot] [U-Boot, 4/6] net: gmac_rockchip: Define the gmac grf register struct at gmac_rockchip.c

Spam detection software, running on the system "lists.denx.de", has identified this incoming email as possible spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview:

Re: [U-Boot] [U-Boot, 4/6] net: gmac_rockchip: Define the gmac grf register struct at gmac_rockchip.c

Hi Philipp, 在 2017/10/6 18:06, Philipp Tomsich 写道: On Thu, 21 Sep 2017, David Wu wrote: If we include both the rk3288_grf.h and rv1108_grf.h, there is a number of compiling error for redefinition. So we define the reg structs of mac_grf at gmac_rockchip.c. Remove the rk**_grf.h files, give

Re: [U-Boot] [PATCH] rockchip: imply ADC and SARADC_ROCKCHIP on supported SoCs

Hi Philipp, 在 2017/9/20 21:00, Dr. Philipp Tomsich 写道: Should we just imply these two configuration-values for all Rockchip devices (i.e. even for the RK3036 and RK3228) to further simplify the Kconfig? I think it is okay to imply all rockchip devices, it is no harm. If after all Rockchip

Re: [U-Boot] [PATCH] rockchip: imply ADC and SARADC_ROCKCHIP on supported SoCs

Hi Philipp, 在 2017/9/20 19:54, Philipp Tomsich 写道: Enable the Rockchip SARADC driver on all supported SoCs (i.e. all except the RK3036 and RK3228, which don't have this peripheral): RK3188, RK3288, RK3328, RK3368, RK3399 and RV1108. Signed-off-by: Philipp

Re: [U-Boot] [U-Boot,1/8] adc: Add driver for Rockchip Saradc

Spam detection software, running on the system "lists.denx.de", has identified this incoming email as possible spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview:

Re: [U-Boot] [PATCH 2/8] configs: rockchip: Enable the ROCKCHIP_SARADC config

Spam detection software, running on the system "lists.denx.de", has identified this incoming email as possible spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview:

Re: [U-Boot] [PATCH 4/8] clk: rockchip: Add Saradc clock support for rk3288

Spam detection software, running on the system "lists.denx.de", has identified this incoming email as possible spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview:

Re: [U-Boot] [U-Boot, v4, 5/9] net: gmac_rk3288: Add RK3288 GMAC driver

Hi Simon, Could you rename this driver file from rk3288 to rockchip, and the name of some common function? The other rockchip socs would use this driver as rk1108, etc. 在 2016/12/3 13:06, Simon Glass 写道: From: Sjoerd Simons Add a new driver for the GMAC