Thank you and sorry for missing that
Reviewed-by: Dmitrii Merkurev
Reuse common logic between existing mmc and new introduced
block implementation
Signed-off-by: Dmitrii Merkurev
Cc: Alex Kiernan
Cc: Patrick Delaunay
Cc: Simon Glass
Cc: Mattijs Korpershoek
Cc: Ying-Chun Liu (PaulLiu)
---
drivers/fastboot/Makefile | 4 +-
drivers/fastboot/fb_block.c
1. Get partition info/size
2. Erase partition
3. Flash partition
4. BCB
Signed-off-by: Dmitrii Merkurev
Cc: Alex Kiernan
Cc: Patrick Delaunay
Cc: Simon Glass
Cc: Mattijs Korpershoek
Cc: Ying-Chun Liu (PaulLiu)
---
drivers/fastboot/fb_command.c | 8
drivers/fastboot/fb_common.c
Signed-off-by: Dmitrii Merkurev
Cc: Patrick Delaunay
Cc: Simon Glass
Cc: Mattijs Korpershoek
Cc: Ying-Chun Liu (PaulLiu)
---
drivers/fastboot/Kconfig | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/fastboot/Kconfig b/drivers/fastboot/Kconfig
Co-developed-by: Cody Schuffelen
Signed-off-by: Cody Schuffelen
Signed-off-by: Dmitrii Merkurev
Cc: Tuomas Tynkkynen
Cc: Simon Glass
Cc: Mattijs Korpershoek
Cc: Ying-Chun Liu (PaulLiu)
---
drivers/virtio/virtio_blk.c | 91 +++--
drivers/virtio/virtio_blk.h
Verified this change with AOSP u-boot fastboot flashing tests and it works
as expected.
Reviewed-by: Dmitrii Merkurev
On Mon, Dec 4, 2023 at 12:32 AM Simon Glass wrote:
> Given the name of this variable, it should be an address, not a
> pointer. Update this, to make it easier
Uploaded v2 with fixes
On Thu, Nov 9, 2023 at 2:05 AM Mattijs Korpershoek <
mkorpersh...@baylibre.com> wrote:
> Hi Dmitrii,
>
> Thank you for your patch.
>
> On jeu., nov. 09, 2023 at 00:36, Dmitrii Merkurev
> wrote:
>
> > Currently BCB C API only all
;
> > Hi Dmitrii,
> >
> > Thank you for your patch.
> >
> > Thank you as well for taking the time to upstream things from:
> > https://android.googlesource.com/platform/external/u-boot/
> >
> > On jeu., nov. 09, 2023 at 00:36, Dmitrii Merkure
Currently BCB C API only allows to modify 'command' BCB field.
Extend it so that we can also read and modify all the available
BCB fields (command, status, recovery, stage).
Co-developed-by: Cody Schuffelen
Signed-off-by: Cody Schuffelen
Signed-off-by: Dmitrii Merkurev
Cc: Eugeniu Rosca
Cc
Following patches introduce various block interfaces support
and extend API of BCB (bootloader control block) to reuse it
for Android boot flow of Cuttlefish virtual device.
Signed-off-by: Dmitrii Merkurev
Cc: Eugeniu Rosca
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Cc: Mattijs Korpershoek
Currently BCB command-line, C APIs and implementation only
support MMC interface. Extend it to allow various block
device interfaces.
Signed-off-by: Dmitrii Merkurev
Cc: Eugeniu Rosca
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Cc: Mattijs Korpershoek
Cc: Sean Anderson
Cc: Cody Schuffelen
Currently BCB C API only allows to modify 'command' BCB field.
Extend it so that we can also read and modify all the available
BCB fields (command, status, recovery, stage).
Co-developed-by: Cody Schuffelen
Signed-off-by: Cody Schuffelen
Signed-off-by: Dmitrii Merkurev
Cc: Eugeniu Rosca
Cc
Currently BCB command-line, C APIs and implementation only
support MMC interface. Extend it to allow various block
device interfaces.
Signed-off-by: Dmitrii Merkurev
Cc: Eugeniu Rosca
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Cc: Mattijs Korpershoek
Cc: Sean Anderson
Cc: Cody Schuffelen
Following patches introduce various block interfaces support
and extend API of BCB (bootloader control block) to reuse it
for Android boot flow of Cuttlefish virtual device.
Signed-off-by: Dmitrii Merkurev
Cc: Eugeniu Rosca
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Cc: Mattijs Korpershoek
Hey Tom, huge thanks for sharing that. I agree lwip is the proper way to
handle this, will try out this patch set and eventually migrate fastboot
apps into a new stack.
On Wed, Nov 8, 2023 at 6:45 AM Tom Rini wrote:
> On Tue, Jul 25, 2023 at 10:56:52PM +0100, Dmitrii Merkurev wr
.
On Sun, Jul 23, 2023 at 4:49 AM Simon Glass wrote:
> Hi Dmitrii,
>
> On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev
> wrote:
> >
> > Command to start IP6 only TCP fastboot:
> > fastboot tcp -ipv6
> >
> > Signed-off-by: Dmitrii Merkurev
> > Cc:
>
> Can you use if() here?
Yes, fixed
On Sun, Jul 23, 2023 at 4:48 AM Simon Glass wrote:
> Hi Dmitrii,
>
> On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev
> wrote:
> >
> > fastboot tcp command remains the same, but started
> > listening IP6 in case it's ena
ss wrote:
> Hi Dmitrii,
>
> On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev
> wrote:
> >
> > Add TCP/IP6 related headers and reuse refactored TCP/IP
> > implementation
> >
> > Signed-off-by: Dmitrii Merkurev
> > Cc: Ying-Chun Liu (PaulLiu)
> >
Sun, Jul 23, 2023 at 4:48 AM Simon Glass wrote:
> Hi Dmitrii,
>
> On Wed, 10 May 2023 at 11:00, Dmitrii Merkurev
> wrote:
> >
> > Changes:
> > 1. Separate reusable part from net_set_tcp_header to
> > net_set_tcp_header_common
> > 2. Make TCP signature
Current active eth device may be changed (due to ethprime), so make
sure current net_ip6 is updated as a reaction.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Reviewed-by: Ying-Chun Liu (PaulLiu)
Reviewed-by: Simon Glass
Command to start IPv6 only TCP fastboot:
fastboot tcp -ipv6
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Reviewed-by: Ying-Chun Liu (PaulLiu)
Reviewed-by: Simon Glass
---
cmd/fastboot.c | 29
fastboot tcp command remains the same, but started
listening IP6 in case it's enabled
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Reviewed-by: Ying-Chun Liu (PaulLiu)
Reviewed-by: Simon Glass
---
include/net
Add TCP/IP6 related headers and reuse refactored TCP/IP
implementation
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Reviewed-by: Ying-Chun Liu (PaulLiu)
Reviewed-by: Simon Glass
---
include/net/tcp6.h | 103
This allows us to reuse TCP logic between IP and IP6 stack.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Reviewed-by: Ying-Chun Liu (PaulLiu)
Reviewed-by: Simon Glass
---
include/net.h | 26 +++-
include/net/tcp.h | 109
This allows us to reuse TCP logic between IP and IP6 stack.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Reviewed-by: Ying-Chun Liu (PaulLiu)
Reviewed-by: Simon Glass
---
include/net/tcp.h | 54
> 5. "ut lib net_test_wget" in the U-boot prompt.
>
> Yours,
> Paul
>
>
> On Tue, 9 May 2023 at 01:15, Dmitrii Merkurev wrote:
>>
>> This allows us to reuse TCP logic between IP and IP6 stack.
>>
>> Signed-off-by: Dmitrii Merkurev
>&
Command to start IP6 only TCP fastboot:
fastboot tcp -ipv6
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
cmd/fastboot.c | 29 +
doc/android/fastboot.rst | 8 +++-
2 files changed
Current active eth device may be changed (due to ethprime), so make
sure current net_ip6 is updated as a reaction.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
net/net.c | 8
1 file changed, 4 insertions(+), 4
This allows us to reuse TCP logic between IP and IP6 stack.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/tcp.h | 109 +--
net/net.c | 18 ++-
net/net6.c| 78 ---
net/tcp.c
fastboot tcp command remains the same, but started
listening IP6 in case it's enabled.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/fastboot_tcp.h | 2 +-
net/fastboot_tcp.c | 72
Add TCP/IP6 related headers and reuse refactored TCP/IP
implementation
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/tcp6.h | 106 +
include/net6.h | 14
This allows us to reuse TCP logic between IP and IP6 stack.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/tcp.h | 54
net/tcp.c | 70
Current active eth device may be changed (due to ethprime), so make
sure current net_ip6 is updated as a reaction.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
net/net.c | 8
1 file changed, 4 insertions(+), 4
Command to start IP6 only TCP fastboot:
fastboot tcp -ipv6
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
cmd/fastboot.c | 29 +
doc/android/fastboot.rst | 8 +++-
2 files changed
fastboot tcp command remains the same, but started
listening IP6 in case it's enabled.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/fastboot_tcp.h | 2 +-
net/fastboot_tcp.c | 72
Add TCP/IP6 related headers and reuse refactored TCP/IP
implementation
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/tcp6.h | 103 +
include/net6.h | 14
This allows us to reuse TCP logic between IP and IP6 stack.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/tcp.h | 109 +--
net/net.c | 18 ++-
net/net6.c| 78 ---
net/tcp.c
This allows us to reuse TCP logic between IP and IP6 stack.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/tcp.h | 50 ++---
net/tcp.c | 70
mation about packet
format
https://chromium.googlesource.com/aosp/platform/system/core/+/refs/heads/upstream/fastboot/#fastboot-data
On Sat, Apr 1, 2023 at 7:32 AM Simon Glass wrote:
>
> Hi Dmitrii,
>
> On Wed, 29 Mar 2023 at 09:31, Dmitrii Merkurev wrote:
> >
> > Known l
Introduce reboot, boot and continue commands support to
TCP fastboot by moving existing UDP logic into the common module.
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Reviewed-by: Simon Glass
Reviewed-by: Ramon Fried
Known limitations are
1. fastboot reboot doesn't work (answering OK but not rebooting)
2. flashing isn't supported (TCP transport only limitation)
The command syntax is
fastboot tcp
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon
with the fix)
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Reviewed-by: Ying-Chun Liu (PaulLiu)
Reviewed-by: Simon Glass
Reviewed-by: Ramon Fried
---
include/net/tcp.h | 16 +--
net/tcp.c | 115
Introduce reboot, boot and continue commands support to
TCP fastboot by moving existing UDP logic into the common module.
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
Signed-off-by: Dmitrii Merkurev
---
drivers/fastboot/fb_common.c | 32
Known limitations are
1. fastboot reboot doesn't work (answering OK but not rebooting)
2. flashing isn't supported (TCP transport only limitation)
The command syntax is
fastboot tcp
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon
with the fix)
Signed-off-by: Dmitrii Merkurev
Cc: Ying-Chun Liu (PaulLiu)
Cc: Simon Glass
Сс: Joe Hershberger
Сс: Ramon Fried
---
include/net/tcp.h | 16 +--
net/tcp.c | 115 +++---
net/wget.c| 43 -
3 files changed, 90
45 matches
Mail list logo
