Re: [PATCH v2 00/17] rockchip: eMMC fixes for RK3568 and support for RK3588

2023-04-27 Thread Eugen Hristev
On 4/27/23 18:25, Jonas Karlman wrote: Hi Eugen, On 2023-04-27 16:45, Eugen Hristev wrote: On 4/18/23 19:46, Jonas Karlman wrote: This series fixes eMMC HS400 modes on RK3568 and add support for RK3588. It has been tested with rock-3a-rk3568/rock5b-rk3588 defconfig and

Re: [PATCH v2 00/17] rockchip: eMMC fixes for RK3568 and support for RK3588

2023-04-27 Thread Eugen Hristev
On 4/18/23 19:46, Jonas Karlman wrote: This series fixes eMMC HS400 modes on RK3568 and add support for RK3588. It has been tested with rock-3a-rk3568/rock5b-rk3588 defconfig and CONFIG_MMC_HS200_SUPPORT=y CONFIG_MMC_HS400_SUPPORT=y CONFIG_MMC_HS400_ES_SUPPORT=y CONFIG_MMC_SPEED_MOD

Re: [PATCH] configs: at91: sama5d2_icp_mmc: Enable CONFIG_LTO

2023-04-27 Thread Eugen Hristev
On 4/27/23 12:26, Stefan Roese wrote: Hi Eugen, On 4/27/23 11:19, Eugen Hristev wrote: Hi Stefan, Thank you for the patch. This I guess is a workaround such that you can add a bit more of code. In the end, it's not scalable, and we have to find a better way, probably by removing some o

Re: [PATCH] configs: at91: sama5d2_icp_mmc: Enable CONFIG_LTO

2023-04-27 Thread Eugen Hristev
break. Eugen On 4/27/23 11:59, Stefan Roese wrote: Adding just a tiny bit more code for sama5d2_icp_mmc leads to a SRAM image overflow. Fix this by enabling LTO for this board, so that such changes still can be made to the common U-Boot code. Signed-off-by: Stefan Roese Cc: Tudor Ambarus Cc

[PATCH v3 7/7] configs: rock5b-rk3588: add PCI drivers and command

2023-04-27 Thread Eugen Hristev
Add drivers for PCIe , phy, and command. Signed-off-by: Eugen Hristev --- Changes in v3; - s/pciE/PCIe Changes in v2: - binman_fdt is now removed configs/rock5b-rk3588_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b

[PATCH v3 6/7] ARM: dts: rockchip: rock5b: enable pcie2x1l2 and associated combphy

2023-04-27 Thread Eugen Hristev
From: Christopher Obbard Enable the PCIe 2x1l 2 device and associated combphy. On this bus, the Rock5B has an Ethernet transceiver connected. Signed-off-by: Christopher Obbard [eugen.hris...@collabora.com: minor tweaks] Signed-off-by: Eugen Hristev [jo...@kwiboo.se: add PCIe pins] Signed-off

[PATCH v3 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY

2023-04-27 Thread Eugen Hristev
From: Joseph Chen Add the node for PCIe 2x1l 2 device together with the corresponding combphy. Signed-off-by: Joseph Chen [eugen.hris...@collabora.com: moved to -u-boot.dtsi, minor adaptations] Signed-off-by: Eugen Hristev [jo...@kwiboo.se: adapt to kernel node] Signed-off-by: Jonas Karlman

[PATCH v3 4/7] phy: rockchip: naneng-combphy: Support rk3588

2023-04-27 Thread Eugen Hristev
From: Jon Lin Add support for rk3588 phy variant. The PHY clock is fixed at 100MHz. Signed-off-by: Jon Lin [kever.y...@rock-chips.com: update pcie pll parameters] Co-developed-by: Kever Yang Signed-off-by: Kever Yang [eugen.hris...@collabora.com: squashed, tidy up] Signed-off-by: Eugen

[PATCH v3 3/7] phy: rockchip: naneng-combphy: Add support for multiple resets

2023-04-27 Thread Eugen Hristev
Some variants of the PHY have more than just one reset. To cover all cases, request the rests in bulk rather than just the reset at index 0. Co-developed-by: Ren Jianing Signed-off-by: Ren Jianing Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang --- Changes in v2,v3: - none drivers/phy

[PATCH v3 2/7] pci: pcie_dw_rockchip: Support max_link_speed dts property

2023-04-27 Thread Eugen Hristev
From: Jon Lin Add support for max_link_speed specified in the PCI DT binding. Signed-off-by: Jon Lin [eugen.hris...@collabora.com: port to latest API, set default correctly, align to 80 chars] Signed-off-by: Eugen Hristev [jo...@kwiboo.se: switch to dev_read_u32_default] Signed-off-by: Jonas

[PATCH v3 1/7] pci: pcie_dw_rockchip: Add rk3588 compatible

2023-04-27 Thread Eugen Hristev
From: Jon Lin Add compatible for RK3588 SoC. Signed-off-by: Jon Lin Reviewed-by: Kever Yang --- Changes in v2,v3: - none drivers/pci/pcie_dw_rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c index 6155710a9f5f..ff1

[PATCH v2 7/7] configs: rock5b-rk3588: add pci drivers and command

2023-04-26 Thread Eugen Hristev
Add drivers for pciE , phy, and command. Signed-off-by: Eugen Hristev --- Changes in v2: - binman_fdt is now removed configs/rock5b-rk3588_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index 2685515d3956

[PATCH v2 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY

2023-04-26 Thread Eugen Hristev
From: Joseph Chen Add the node for pciE 2x1l 2 device together with the corresponding combphy. Signed-off-by: Joseph Chen [eugen.hris...@collabora.com: moved to -u-boot.dtsi, minor adaptations] Signed-off-by: Eugen Hristev [jo...@kwiboo.se: adapt to kernel node] Signed-off-by: Jonas Karlman

[PATCH v2 6/7] ARM: dts: rockchip: rock5b: enable pcie2x1l2 and associated combphy

2023-04-26 Thread Eugen Hristev
From: Christopher Obbard Enable the pciE 2x1l 2 device and associated combphy. On this bus, the Rock5B has an Ethernet transceiver connected. Signed-off-by: Christopher Obbard [eugen.hris...@collabora.com: minor tweaks] Signed-off-by: Eugen Hristev [jo...@kwiboo.se: add pcie pins] Signed-off

[PATCH v2 3/7] phy: rockchip: naneng-combphy: Add support for multiple resets

2023-04-26 Thread Eugen Hristev
Some variants of the PHY have more than just one reset. To cover all cases, request the rests in bulk rather than just the reset at index 0. Co-developed-by: Ren Jianing Signed-off-by: Ren Jianing Signed-off-by: Eugen Hristev --- Changes in v2: - none drivers/phy/rockchip/phy-rockchip

[PATCH v2 4/7] phy: rockchip: naneng-combphy: Support rk3588

2023-04-26 Thread Eugen Hristev
From: Jon Lin Add support for rk3588 phy variant. The PHY clock is fixed at 100MHz. Signed-off-by: Jon Lin [kever.y...@rock-chips.com: update pcie pll parameters] Co-developed-by: Kever Yang Signed-off-by: Kever Yang [eugen.hris...@collabora.com: squashed, tidy up] Signed-off-by: Eugen

[PATCH v2 2/7] pci: pcie_dw_rockchip: Support max_link_speed dts property

2023-04-26 Thread Eugen Hristev
From: Jon Lin Add support for max_link_speed specified in the PCI DT binding. Signed-off-by: Jon Lin [eugen.hris...@collabora.com: port to latest API, set default correctly, align to 80 chars] Signed-off-by: Eugen Hristev [jo...@kwiboo.se: switch to dev_read_u32_default] Signed-off-by: Jonas

[PATCH v2 1/7] pci: pcie_dw_rockchip: Add rk3588 compatible

2023-04-26 Thread Eugen Hristev
From: Jon Lin Add compatible for RK3588 SoC. Signed-off-by: Jon Lin --- Changes in v2: - none drivers/pci/pcie_dw_rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c index 6155710a9f5f..ff121046604a 100644 --- a/drive

Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant

2023-04-25 Thread Eugen Hristev
On 4/25/23 22:22, Ramon Fried wrote: On Tue, Apr 25, 2023 at 4:17 PM Eugen Hristev wrote: On 4/25/23 16:06, Eugen Hristev wrote: Add minimal support for 8125B version. Changes are based on the Linux driver. Tested on Radxa Rock 5B Rk3588 board. Connection to a laptop worked fine in 100 Mbps

Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant

2023-04-25 Thread Eugen Hristev
On 4/25/23 16:06, Eugen Hristev wrote: Add minimal support for 8125B version. Changes are based on the Linux driver. Tested on Radxa Rock 5B Rk3588 board. Connection to a laptop worked fine in 100 Mbps mode. 1000 Mbps mode is not working at the moment. Signed-off-by: Eugen Hristev --- The

[PATCH 2/2] configs: rock5b-rk3588: add rtl8169 driver

2023-04-25 Thread Eugen Hristev
Add the rtl8169 driver, which supports the rtl8125b device, which is connected on the pciE bus on this board. Enable also CONFIG_SYS_HAS_NONCACHED_MEMORY to have the descriptors stored. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 2 ++ 1 file changed, 2 insertions

[PATCH 1/2] net: rtl8169: add minimal support for 8125B variant

2023-04-25 Thread Eugen Hristev
Add minimal support for 8125B version. Changes are based on the Linux driver. Tested on Radxa Rock 5B Rk3588 board. Connection to a laptop worked fine in 100 Mbps mode. 1000 Mbps mode is not working at the moment. Signed-off-by: Eugen Hristev --- drivers/net/rtl8169.c | 52

[PATCH v5 3/3] regulator: handle different error codes in regulator_set_enable_if_allowed

2023-04-19 Thread Eugen Hristev
The regulator core can return different codes which are not considered a real error for this function. Return success in such cases. Signed-off-by: Eugen Hristev --- Changes in v5: - this is a new patch drivers/power/regulator/regulator-uclass.c | 6 ++ 1 file changed, 6 insertions

[PATCH v5 2/3] regulator: rename dev_pdata to plat

2023-04-19 Thread Eugen Hristev
Simplify the subsystem by renaming `dev_pdata` to just `plat`. No functional change, just trivial renaming. Suggested-by: Simon Glass Signed-off-by: Eugen Hristev Reviewed-by: Simon Glass --- Changes in v3,v4,v5: - none Changes in v2: - this is a new patch drivers/power/regulator/fan53555

[PATCH v5 1/3] regulator: implement basic reference counter

2023-04-19 Thread Eugen Hristev
ne in Linux, to keep track of enable and disable requests, and only disable the regulator when the last of the consumers has requested shutdown. Signed-off-by: Eugen Hristev Reviewed-by: Simon Glass --- Changes in v5: - none Changes in v4: - add documentation for error codes Changes in v3:

[PATCH v5 4/6] phy: remove phy-supply related code

2023-04-19 Thread Eugen Hristev
phy-supply is now handled at uclass level. Remove it from the drivers that implement it at the driver level. Suggested-by: Jonas Karlman Signed-off-by: Eugen Hristev --- drivers/phy/meson-g12a-usb2.c | 48 --- drivers/phy/meson-gxbb-usb2.c | 38

[PATCH v5 6/6] phy: Keep balance of counts when ops is missing

2023-04-19 Thread Eugen Hristev
From: Jonas Karlman Fixes: 226fce6108fe ("phy: Track power-on and init counts in uclass") Signed-off-by: Jonas Karlman --- drivers/phy/phy-uclass.c | 80 1 file changed, 39 insertions(+), 41 deletions(-) diff --git a/drivers/phy/phy-uclass.c b/drivers/p

[PATCH v5 5/6] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-04-19 Thread Eugen Hristev
Add initial support for the rk3588 PHY variant. The lookup for the host-port reg inside the struct now does a do {} while() instead of a while() {} in order to allow a first check for reg == 0. Co-developed-by: Frank Wang Signed-off-by: Frank Wang Signed-off-by: Eugen Hristev --- drivers/phy

[PATCH v5 3/6] phy: add support for phy-supply

2023-04-19 Thread Eugen Hristev
-off-by: Jonas Karlman Signed-off-by: Eugen Hristev --- Changes in v5: - add changes done by Jonas drivers/phy/phy-uclass.c | 51 +++- 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/drivers/phy/phy-uclass.c b/drivers/phy/phy-uclass.c index

[PATCH v5 1/6] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-04-19 Thread Eugen Hristev
Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev --- Changes in v5: - none Changes in v4: - removed u-boot,dm-spl on regulator which was useless - moved usb nodes to rk3588s-u-boot-dtsi Changes in v2,v3: - none arch/arm/dts

[PATCH v5 2/6] configs: rockchip: rock5b-rk3588: enable USB and regulators

2023-04-19 Thread Eugen Hristev
Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 17 + 1 file changed, 17 insertions(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index

[PATCH v3 2/2] configs: rockchip: rock5b-rk3588: add pinctrl to SPL

2023-04-17 Thread Eugen Hristev
Add pinctrl driver in SPL. Do not remove pinctrl properties for SPL dtb. Signed-off-by: Eugen Hristev --- Changes in v2,v3: - no change configs/rock5b-rk3588_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b

[PATCH v3 1/2] ARM: dts: rk3588-rock-5b-u-boot: add bootph-all to pinctrl for sdmmc

2023-04-17 Thread Eugen Hristev
To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev --- Changes in v3: - change to bootph-all props. Changes in v2: - add u-boot,dm-spl to pull up nodes, to also setup the pull control

[PATCH 4/7] phy: rockchip: naneng-combphy: Support rk3588

2023-04-17 Thread Eugen Hristev
From: Jon Lin Add support for rk3588 phy variant. The PHY clock is fixed at 100MHz. Signed-off-by: Jon Lin [kever.y...@rock-chips.com: update pcie pll parameters] Co-developed-by: Kever Yang Signed-off-by: Kever Yang [eugen.hris...@collabora.com: squashed, tidy up] Signed-off-by: Eugen

[PATCH 5/7] ARM: dts: rockchip: rk3588s-u-boot: add pcie2x1l2 with PHY

2023-04-17 Thread Eugen Hristev
From: Joseph Chen Add the node for pciE 2x1l 2 device together with the corresponding combphy. Signed-off-by: Joseph Chen [eugen.hris...@collabora.com: moved to -u-boot.dtsi, minor adaptations] Signed-off-by: Eugen Hristev --- arch/arm/dts/rk3588s-u-boot.dtsi | 73

[PATCH 6/7] ARM: dts: rockchip: rock5b: enable pcie2x1l2 and associated combphy

2023-04-17 Thread Eugen Hristev
From: Christopher Obbard Enable the pciE 2x1l 2 device and associated combphy. On this bus, the Rock5B has an Ethernet transceiver connected. Signed-off-by: Christopher Obbard [eugen.hris...@collabora.com: minor tweaks] Signed-off-by: Eugen Hristev --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi

[PATCH 7/7] configs: rock5b-rk3588: add pci drivers and command

2023-04-17 Thread Eugen Hristev
Add drivers for pciE , phy, and command. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index 8c097ab3a109..a14fcd2ee924 100644 --- a

[PATCH 3/7] phy: rockchip: naneng-combphy: Add support for multiple resets

2023-04-17 Thread Eugen Hristev
Some variants of the PHY have more than just one reset. To cover all cases, request the rests in bulk rather than just the reset at index 0. Co-developed-by: Ren Jianing Signed-off-by: Ren Jianing Signed-off-by: Eugen Hristev --- drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 8

[PATCH 2/7] pci: pcie_dw_rockchip: Support max_link_speed dts property

2023-04-17 Thread Eugen Hristev
From: Jon Lin Add support for max_link_speed specified in the PCI DT binding. Signed-off-by: Jon Lin [eugen.hris...@collabora.com: port to latest API, set default correctly, align to 80 chars] Signed-off-by: Eugen Hristev --- drivers/pci/pcie_dw_rockchip.c | 11 ++- 1 file changed

[PATCH 1/7] pci: pcie_dw_rockchip: Add rk3588 compatible

2023-04-17 Thread Eugen Hristev
From: Jon Lin Add compatible for RK3588 SoC. Signed-off-by: Jon Lin --- drivers/pci/pcie_dw_rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c index 6155710a9f5f..ff121046604a 100644 --- a/drivers/pci/pcie_dw_rockchip.

Re: [PATCH v2 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

2023-04-14 Thread Eugen Hristev
On 4/14/23 11:55, Kever Yang wrote: On 2023/3/18 00:29, Eugen Hristev wrote: To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Hi Kever, The properties

Re: [PATCH 2/2] reset: rockchip: implement rk3588 lookup table

2023-04-14 Thread Eugen Hristev
On 4/14/23 10:02, Kever Yang wrote: + Heiko and Elaine, Hi Eugen, On 2023/4/13 19:36, Eugen Hristev wrote: The current DT bindings for the rk3588 clock use a different ID than the one that is supposed to be written to the hardware registers. Thus, we cannot use directly the id provided in the

[PATCH] pci: pcie_dw_rockchip: release resources on failing probe

2023-04-13 Thread Eugen Hristev
me error message, and not something different that doesn't make sense. Signed-off-by: Eugen Hristev --- drivers/pci/pcie_dw_rockchip.c | 41 +- 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw

[PATCH 2/2] reset: rockchip: implement rk3588 lookup table

2023-04-13 Thread Eugen Hristev
from Linux. Adapt the clk rk3588 driver as well to bind the reset driver with the lookup table. Signed-off-by: Eugen Hristev --- arch/arm/include/asm/arch-rockchip/clock.h | 21 + drivers/clk/rockchip/clk_rk3588.c | 2 +- drivers/reset/Makefile | 2 +- drivers/r

[PATCH 1/2] clk: rockchip: rk3588: add hardcoded assigned clocks values

2023-04-13 Thread Eugen Hristev
different kind of initialization. Signed-off-by: Eugen Hristev --- drivers/clk/rockchip/clk_rk3588.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/clk/rockchip/clk_rk3588.c b/drivers/clk/rockchip/clk_rk3588.c index 41e31b61a55b..c93c9c304d40 100644 --- a

Re: [PATCH v4 3/5] phy: add support for phy-supply

2023-04-12 Thread Eugen Hristev
On 4/12/23 09:53, Jonas Karlman wrote: Hi Eugen, On 2023-04-04 16:11, Eugen Hristev wrote: Some phys require a phy-supply property that is a phandle to a regulator that needs to be enabled for phy operations. Implement basic supply lookup, enable and disabling, if DM_REGULATOR is available

[PATCH] reset: reset-rockchip: fix trivial line spacing alignment

2023-04-11 Thread Eugen Hristev
Fix line spacing aligment in bind function Fixes: 760188c1aa5b ("rockchip: reset: support a (common) rockchip reset drivers") Signed-off-by: Eugen Hristev --- drivers/reset/reset-rockchip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/reset/reset-ro

[PATCH] clk: rockchip: correct trivial typo in debug message

2023-04-11 Thread Eugen Hristev
s/faile/failed in debug message Signed-off-by: Eugen Hristev --- drivers/clk/rockchip/clk_px30.c | 2 +- drivers/clk/rockchip/clk_rk3036.c | 2 +- drivers/clk/rockchip/clk_rk3188.c | 2 +- drivers/clk/rockchip/clk_rk322x.c | 2 +- drivers/clk/rockchip/clk_rk3288.c | 2 +- drivers/clk/rockchip

[PATCH v4 5/5] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-04-04 Thread Eugen Hristev
Add initial support for the rk3588 PHY variant. The lookup for the host-port reg inside the struct now does a do {} while() instead of a while() {} in order to allow a first check for reg == 0. Co-developed-by: Frank Wang Signed-off-by: Frank Wang Signed-off-by: Eugen Hristev --- Changes in v4

[PATCH v4 4/5] phy: remove phy-supply related code

2023-04-04 Thread Eugen Hristev
phy-supply is now handled at uclass level. Remove it from the drivers that implement it at the driver level. Suggested-by: Jonas Karlman Signed-off-by: Eugen Hristev --- drivers/phy/meson-g12a-usb2.c | 48 --- drivers/phy/meson-gxbb-usb2.c | 38

[PATCH v4 3/5] phy: add support for phy-supply

2023-04-04 Thread Eugen Hristev
Some phys require a phy-supply property that is a phandle to a regulator that needs to be enabled for phy operations. Implement basic supply lookup, enable and disabling, if DM_REGULATOR is available. Signed-off-by: Eugen Hristev --- drivers/phy/phy-uclass.c | 22 ++ 1 file

[PATCH v4 2/5] configs: rockchip: rock5b-rk3588: enable USB and regulators

2023-04-04 Thread Eugen Hristev
Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 17 + 1 file changed, 17 insertions(+) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index

[PATCH v4 1/5] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-04-04 Thread Eugen Hristev
Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev --- Changes in v4: - removed u-boot,dm-spl on regulator which was useless - moved usb nodes to rk3588s-u-boot-dtsi Changes in v2,v3: - none arch/arm/dts/rk3588-rock-5b-u

Re: [PATCH v3 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-04-03 Thread Eugen Hristev
On 4/2/23 14:04, Jonas Karlman wrote: Hi Eugen, On 2023-03-31 11:40, Eugen Hristev wrote: Add initial support for the rk3588 PHY variant. The driver now looks for phy-supply and enables/disables the vbus accordingly. Maybe this should be added to core phy uclass to closer match linux? Look

Re: [PATCH v3 1/3] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-04-03 Thread Eugen Hristev
On 4/2/23 14:00, Jonas Karlman wrote: Hi Eugen, On 2023-03-31 11:40, Eugen Hristev wrote: Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev --- Changes in v2,v3: - none arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 169

[PATCH v2] mmc: dw_mmc: reset controller after data error

2023-04-03 Thread Eugen Hristev
ables initialization] Signed-off-by: Eugen Hristev --- Changes in v2: - actually decrement the reset timeout timer drivers/mmc/dw_mmc.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 5085a3b491da..d6cad998b0cd 1

Re: [PATCH v4 1/2] regulator: implement basic reference counter

2023-04-03 Thread Eugen Hristev
On 4/2/23 13:45, Jonas Karlman wrote: Hi Eugen, On 2023-03-31 11:15, Eugen Hristev wrote: Some devices share a regulator supply, when the first one will request regulator disable, the second device will have it's supply cut off before graciously shutting down. Hence there will be timeout

[PATCH v3 3/3] configs: rockchip: rock5b-rk3588: enable USB and regulators

2023-03-31 Thread Eugen Hristev
Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig

[PATCH v3 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-31 Thread Eugen Hristev
Wang Signed-off-by: Frank Wang Signed-off-by: Eugen Hristev Tested-by: Vasily Khoruzhick # rk3568-based board Tested-by: Xavier Drudis Ferran # rk3399 rock pi 4B+ --- Changes in v3: - add handling of -EBUSY and -EALREADY for regulator return Changes in v2: - add handling of -EACCES drivers

[PATCH v3 1/3] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-03-31 Thread Eugen Hristev
Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev --- Changes in v2,v3: - none arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 169 1 file changed, 169 insertions(+) diff --git a/arch/arm/dts/rk3588-rock-5b

[PATCH v4 2/2] regulator: rename dev_pdata to plat

2023-03-31 Thread Eugen Hristev
Simplify the subsystem by renaming `dev_pdata` to just `plat`. No functional change, just trivial renaming. Suggested-by: Simon Glass Signed-off-by: Eugen Hristev Reviewed-by: Simon Glass --- Changes in v3,v4: - none Changes in v2: - this is a new patch drivers/power/regulator/fan53555.c

[PATCH v4 1/2] regulator: implement basic reference counter

2023-03-31 Thread Eugen Hristev
ne in Linux, to keep track of enable and disable requests, and only disable the regulator when the last of the consumers has requested shutdown. Signed-off-by: Eugen Hristev Reviewed-by: Simon Glass --- Changes in v4: - add documentation for error codes Changes in v3: - add error return codes Ch

[PATCH v3 2/2] regulator: rename dev_pdata to plat

2023-03-30 Thread Eugen Hristev
Simplify the subsystem by renaming `dev_pdata` to just `plat`. No functional change, just trivial renaming. Suggested-by: Simon Glass Signed-off-by: Eugen Hristev --- Changes in v3: - none Changes in v2: - this is a new patch drivers/power/regulator/fan53555.c | 10 ++-- drivers

[PATCH v3 1/2] regulator: implement basic reference counter

2023-03-30 Thread Eugen Hristev
ne in Linux, to keep track of enable and disable requests, and only disable the regulator when the last of the consumers has requested shutdown. Signed-off-by: Eugen Hristev --- Changes in v3: - add error return codes Changes in v2: - add info in header regarding the function drivers/power/regu

[PATCH v2 1/2] regulator: implement basic reference counter

2023-03-28 Thread Eugen Hristev
ne in Linux, to keep track of enable and disable requests, and only disable the regulator when the last of the consumers has requested shutdown. Signed-off-by: Eugen Hristev --- Changes in v2: - add info in header regarding the function drivers/power/regulator/regulator_common.c

[PATCH v2 2/2] regulator: rename dev_pdata to plat

2023-03-28 Thread Eugen Hristev
Simplify the subsystem by renaming `dev_pdata` to just `plat`. No functional change, just trivial renaming. Suggested-by: Simon Glass Signed-off-by: Eugen Hristev --- Changes in v2: - this is a new patch drivers/power/regulator/fan53555.c | 10 ++-- drivers/power/regulator/fixed.c

[PULL next] u-boot-at91-2023.07-a

2023-03-28 Thread Eugen Hristev
Hello Tom, Please pull tag u-boot-at91-2023.07-a , the first set of at91 features for the next cycle 2023.07 . This feature set includes the clock changes required for sam9x60 SoC to support USB host. Thanks, Eugen The following changes since commit fde439219ff53a46bdd5dff69e049ccd4be57310:

Re: [PATCH] regulator: implement basic reference counter

2023-03-27 Thread Eugen Hristev
On 3/18/23 22:20, Simon Glass wrote: Hi Eugen, On Thu, 16 Mar 2023 at 07:53, Eugen Hristev wrote: Some devices share a regulator supply, when the first one will request regulator disable, the second device will have it's supply cut off before graciously shutting down. Hence there wi

Re: [PATCH v2 0/5] Support the required clocks to enable USB on SAM9X60

2023-03-27 Thread Eugen Hristev
On 3/17/23 20:34, Eugen Hristev wrote: On 3/9/23 14:30, Eugen Hristev wrote: On 3/8/23 16:39, Claudiu Beznea wrote: This patch series originates from a bigger patch series: https://lists.denx.de/pipermail/u-boot/2022-December/502865.html A driver for clock operations on SAM9X60's USB

Re: [PATCH v2 0/5] Support the required clocks to enable USB on SAM9X60

2023-03-17 Thread Eugen Hristev
On 3/9/23 14:30, Eugen Hristev wrote: On 3/8/23 16:39, Claudiu Beznea wrote: This patch series originates from a bigger patch series: https://lists.denx.de/pipermail/u-boot/2022-December/502865.html A driver for clock operations on SAM9X60's USB clock has been added as well as its registr

[PATCH v2 2/2] configs: rockchip: rock5b-rk3588: add pinctrl to SPL

2023-03-17 Thread Eugen Hristev
Add pinctrl driver in SPL. Do not remove pinctrl properties for SPL dtb. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index 86acb6da4306

[PATCH v2 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

2023-03-17 Thread Eugen Hristev
To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev --- Changes in v2: - add u-boot,dm-spl to pull up nodes, to also setup the pull control correctly. Also, in the loop that initializes

[PATCH] regulator: implement basic reference counter

2023-03-16 Thread Eugen Hristev
ne in Linux, to keep track of enable and disable requests, and only disable the regulator when the last of the consumers has requested shutdown. Signed-off-by: Eugen Hristev --- drivers/power/regulator/regulator_common.c | 22 ++ drivers/power/regulator/regulator_common.h | 1

[PATCH v4] pinctrl: rockchip: support rk3588 pinctrl

2023-03-15 Thread Eugen Hristev
From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more changes from Linux use translated pull values table] Signed-off-by: Eugen Hristev

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-03-13 Thread Eugen Hristev
On 3/13/23 17:34, Mark Kettenis wrote: Date: Mon, 13 Mar 2023 17:21:05 +0200 From: Eugen Hristev On 3/13/23 17:07, Mark Kettenis wrote: Date: Mon, 13 Mar 2023 16:21:36 +0200 From: Eugen Hristev On 3/13/23 12:00, Jonas Karlman wrote: On 2023-03-13 09:42, Eugen Hristev wrote: On 3/13/23 00

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-03-13 Thread Eugen Hristev
On 3/13/23 17:07, Mark Kettenis wrote: Date: Mon, 13 Mar 2023 16:21:36 +0200 From: Eugen Hristev On 3/13/23 12:00, Jonas Karlman wrote: On 2023-03-13 09:42, Eugen Hristev wrote: On 3/13/23 00:34, Jonas Karlman wrote: Hi Eugen, On 2023-03-08 09:57, Eugen Hristev wrote: On 1/29/23 11:04

[PATCH] mmc: dw_mmc: reset controller after data error

2023-03-13 Thread Eugen Hristev
ables initialization] Signed-off-by: Eugen Hristev --- drivers/mmc/dw_mmc.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 5085a3b491da..7c302ee614f4 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-03-13 Thread Eugen Hristev
On 3/13/23 16:21, Eugen Hristev wrote: On 3/13/23 12:00, Jonas Karlman wrote: On 2023-03-13 09:42, Eugen Hristev wrote: On 3/13/23 00:34, Jonas Karlman wrote: Hi Eugen, On 2023-03-08 09:57, Eugen Hristev wrote: On 1/29/23 11:04, Jonas Karlman wrote: On 2023-01-27 14:21, Jagan Teki wrote

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-03-13 Thread Eugen Hristev
On 3/13/23 12:00, Jonas Karlman wrote: On 2023-03-13 09:42, Eugen Hristev wrote: On 3/13/23 00:34, Jonas Karlman wrote: Hi Eugen, On 2023-03-08 09:57, Eugen Hristev wrote: On 1/29/23 11:04, Jonas Karlman wrote: On 2023-01-27 14:21, Jagan Teki wrote: On Fri, 27 Jan 2023 at 05:13, Jonas

[PATCH 2/2] configs: rockchip: rock5b-rk3588: add pinctrl to SPL

2023-03-13 Thread Eugen Hristev
Add pinctrl driver in SPL. Do not remove pinctrl properties for SPL dtb. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig index 86acb6da4306

[PATCH 1/2] ARM: dts: rk3588-rock-5b-u-boot: add u-boot, dm-spl to pinctrl for sdmmc

2023-03-13 Thread Eugen Hristev
To be able to initialize the pinctrl correctly at SPL level and read u-boot proper from SD-Card, the pinctrl must be initialized. Signed-off-by: Eugen Hristev --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/dts/rk3588

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-03-13 Thread Eugen Hristev
On 3/13/23 00:34, Jonas Karlman wrote: Hi Eugen, On 2023-03-08 09:57, Eugen Hristev wrote: On 1/29/23 11:04, Jonas Karlman wrote: On 2023-01-27 14:21, Jagan Teki wrote: On Fri, 27 Jan 2023 at 05:13, Jonas Karlman wrote: On 2023-01-26 23:16, Jonas Karlman wrote: Hi Jagan, On 2023-01-26 20

Re: [PATCH v2 0/5] Support the required clocks to enable USB on SAM9X60

2023-03-09 Thread Eugen Hristev
On 3/8/23 16:39, Claudiu Beznea wrote: This patch series originates from a bigger patch series: https://lists.denx.de/pipermail/u-boot/2022-December/502865.html A driver for clock operations on SAM9X60's USB clock has been added as well as its registration on CCF. In order for USB to work proper

[PATCH v2 3/3] configs: rockchip: rock5b-rk3588: enable USB and regulators

2023-03-09 Thread Eugen Hristev
Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig

[PATCH v2 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-09 Thread Eugen Hristev
Wang Signed-off-by: Frank Wang Signed-off-by: Eugen Hristev Tested-by: Vasily Khoruzhick # rk3568-based board --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 109 +- 1 file changed, 104 insertions(+), 5 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c

[PATCH v2 1/3] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-03-09 Thread Eugen Hristev
Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 169 1 file changed, 169 insertions(+) diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-09 Thread Eugen Hristev
On 3/9/23 11:11, Xavier Drudis Ferran wrote: El Wed, Mar 08, 2023 at 01:59:54PM +0200, Eugen Hristev deia: On 3/8/23 13:30, Xavier Drudis Ferran wrote: El Fri, Mar 03, 2023 at 09:31:33AM +0200, Eugen Hristev deia: @@ -105,6 +130,17 @@ static int rockchip_usb2phy_power_off(struct phy *phy

Re: [PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-08 Thread Eugen Hristev
On 3/8/23 13:30, Xavier Drudis Ferran wrote: El Fri, Mar 03, 2023 at 09:31:33AM +0200, Eugen Hristev deia: @@ -105,6 +130,17 @@ static int rockchip_usb2phy_power_off(struct phy *phy) struct udevice *parent = dev_get_parent(phy->dev); struct rockchip_usb2phy *priv = dev_get_p

Re: [RFC PATCH 00/16] arm: Add Rockchip RK3588 support

2023-03-08 Thread Eugen Hristev
On 1/29/23 11:04, Jonas Karlman wrote: On 2023-01-27 14:21, Jagan Teki wrote: On Fri, 27 Jan 2023 at 05:13, Jonas Karlman wrote: On 2023-01-26 23:16, Jonas Karlman wrote: Hi Jagan, On 2023-01-26 20:17, Jagan Teki wrote: On Fri, 27 Jan 2023 at 00:33, Jonas Karlman wrote: On 2023-01-26 19:

[PATCH v3] pinctrl: rockchip: support rk3588 pinctrl

2023-03-07 Thread Eugen Hristev
From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more changes from Linux] Signed-off-by: Eugen Hristev --- Changes in v3: - change assert(i

[PATCH 3/3] configs: rockchip: rock5b-rk3588: enable USB and regulators

2023-03-02 Thread Eugen Hristev
Enable USB command, USB drivers, PHY and regulators, for USB host operations. Signed-off-by: Eugen Hristev --- configs/rock5b-rk3588_defconfig | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig

[PATCH 2/3] phy: rockchip-inno-usb2: add initial support for rk3588 PHY

2023-03-02 Thread Eugen Hristev
Wang Signed-off-by: Frank Wang Signed-off-by: Eugen Hristev --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 109 +- 1 file changed, 104 insertions(+), 5 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c

[PATCH 1/3] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add USB 2.0 host

2023-03-02 Thread Eugen Hristev
Add USB 2.0 host nodes and PHYs. Co-developed-by: William Wu Signed-off-by: William Wu Signed-off-by: Eugen Hristev --- arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 169 1 file changed, 169 insertions(+) diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm

Re: [PATCH v2] pinctrl: rockchip: support rk3588 pinctrl

2023-03-01 Thread Eugen Hristev
On 3/1/23 18:03, Eugen Hristev wrote: From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more changes from Linux] Signed-off-by: Eugen Hristev

[PATCH v2] pinctrl: rockchip: support rk3588 pinctrl

2023-03-01 Thread Eugen Hristev
From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more changes from Linux] Signed-off-by: Eugen Hristev --- Changes in v2: - change the way the

[PULL] u-boot-at91-fixes-2023.04-a

2023-03-01 Thread Eugen Hristev
Hello Tom, Please pull tag u-boot-at91-fixes-2023.04-a , the first set of at91 fixes for the cycle 2023.04 . This fixes set include one clock index fix for sama7g5 and two board configuration alignments for pm9g45. Thanks, Eugen The following changes since commit e8c80ac0f7a13bf0fc016ce324b

Re: [PATCH] pinctrl: rockchip: support rk3588 pinctrl

2023-03-01 Thread Eugen Hristev
On 3/1/23 10:53, Jagan Teki wrote: On Wed, 1 Mar 2023 at 14:01, Eugen Hristev wrote: From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more

[PATCH] pinctrl: rockchip: support rk3588 pinctrl

2023-03-01 Thread Eugen Hristev
From: Jianqun Xu Add support for Rockchip rk3588 variant of pinctrl. The driver is adapted from the Linux driver. Signed-off-by: Jianqun Xu [eugen.hris...@collabora.com: port to latest U-boot, bring more changes from Linux] Signed-off-by: Eugen Hristev --- drivers/pinctrl/rockchip/Makefile

Re: [PATCH V2 7/9] gpio/rockchip: rk_gpio support v2 gpio controller

2023-03-01 Thread Eugen Hristev
On 2/14/23 00:27, Chris Morgan wrote: From: Chris Morgan Add support for the newer GPIO controller used by the rk356x series, as well as the pinctrl device for the rk356x series. The GPIOv2 controller has a write enable bit for some registers which differs from the older versions of the GPIO co

Re: [PATCH 1/2] configs:pm9g45_defconfig:Fix boot arguments and boot command

2023-02-28 Thread Eugen Hristev
On 2/20/23 16:27, Ilko Iliev wrote: This patch modify boot arguments and boot command to load 512KB DTB and 8MB Linux Kernel Signed-off-by: Ilko Iliev --- Applied both (with minor tweaks) to u-boot-at91/master, thanks !

<    1   2   3   4   5   6   7   >