at any decimal command line input is treated as HEX or DEC,
rather than being forced to surround any number by its base in the shell.
--
Best regards,
Eugeniu Rosca
break;
> case CMD_PART_INFO_NUMBER:
> - snprintf(buf, sizeof(buf), "0x%x", part);
> + snprintf(buf, sizeof(buf), "%x", part);
--
Best regards,
Eugeniu Rosca
Dear Tom,
On Thu, Dec 10, 2020 at 11:54:44AM -0500, Tom Rini wrote:
> On Thu, Dec 10, 2020 at 08:30:36AM +0100, Eugeniu Rosca wrote:
> > Dear U-Boot maintainers,
> >
> > On Fri, Oct 23, 2020 at 11:52:18AM +0300, Roman Kovalivskyi wrote:
> > > Cur
simply pass correct reboot reason
> string to the BCB implementation. If CMD_BCB is disabled then the
> whole operation would return error code, which is no different
> behaviour than the current implementation.
>
> Eugeniu Rosca (5):
> cmd: bcb: Extract '__bcb_load&#
Hi Patrick,
On Fri, Jul 03, 2020 at 04:40:28PM +, Patrick DELAUNAY wrote:
> > From: U-Boot On Behalf Of Eugeniu Rosca
> > Sent: samedi 11 janvier 2020 00:30
> >
> > Hi Tom,
> >
> > On Fri, Jan 10, 2020 at 04:50:52PM -0500, Tom Rini wrote:
> >
To facilitate tracking, this patch has been superseded by:
https://patchwork.ozlabs.org/patch/1250963/
("image.h: isolate android_image_* functions from tooling")
--
Best Regards
Eugeniu Rosca
Hello Heinrich,
On Sat, Mar 07, 2020 at 09:31:17PM +0100, Heinrich Schuchardt wrote:
> Whichever way you want to go we should finalize the topic as it stops
> EFI patches from being merged.
Could you please review https://patchwork.ozlabs.org/patch/1250963/ ?
--
Best Regards
Eugeniu Rosca
?id=e6176fa4728fb6d
("checkpatch: add --strict warning for c99 fixed size typedefs :
int_t")
[5] https://patchwork.ozlabs.org/patch/1238245/#2363340
Cc: Masahiro Yamada
Cc: Heinrich Schuchardt
Cc: Sam Protsenko
Cc: Lokesh Vutla
Cc: Simon Glass
Cc: AKASHI Takahiro
Reported-by:
Hello Heinrich,
Thank you for your perseverance.
I was just about to reply in https://patchwork.ozlabs.org/patch/1239098.
On Sat, Mar 07, 2020 at 10:53:44AM +0100, Heinrich Schuchardt wrote:
> From: Eugeniu Rosca
>
> Replace 'u32' by 'uint32_t' in image.h, since t
7; command invocations, to avoid
> cluttering the console with DTBO blob sizes.
>
> Signed-off-by: Sam Protsenko
> ---
> Changes in v2:
> - Reserve 512 KiB for DTB area, not 1 MiB
Reviewed-by: Eugeniu Rosca
--
Best Regards
Eugeniu Rosca
command invocations, to avoid
> cluttering the console with DTBO blob sizes.
Looks good to me.
>
> Signed-off-by: Sam Protsenko
Reviewed-by: Eugeniu Rosca
--
Best Regards
Eugeniu Rosca
ill provide a better maintainability.
>
> ifdef would work. Perhaps, splitting the header might be even better.
The above sounds like food for thought on how to mitigate the problem
long-term.
>
> That's my random thought.
Many thanks!
--
Best Regards
Eugeniu Rosca
;)
Fixes: c3bfad825a71ea ("image: android: Add functions for handling dtb field")
Suggested-by: Masahiro Yamada
Signed-off-by: Eugeniu Rosca
---
include/image.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/image.h b/include/image.h
index b316d167d8d7.
Hi Tom,
On Sun, Feb 16, 2020 at 11:53:23AM -0500, Tom Rini wrote:
> On Sun, Feb 16, 2020 at 05:23:14PM +0100, Eugeniu Rosca wrote:
> > On Fri, Feb 14, 2020 at 12:38:19PM -0500, Tom Rini wrote:
> > > The image.h header can be used fairly widely in U-Boot builds. We
> > >
t either. Use uint instead
> here.
>
> Cc: Eugeniu Rosca
> Cc: Sam Protsenko
> Signed-off-by: Tom Rini
> ---
> include/image.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/image.h b/include/image.h
> index b316d167d8d7.
Hi Sam,
On Wed, Jan 15, 2020 at 04:59:13PM +0200, Sam Protsenko wrote:
> The main point of my patch is to fix the erasing of partitions smaller
> than group erase size (512 KiB on BeagleBoard X15). For example, it's
> impossible to erase 'misc' partition (128 KiB), as such an operation
> would era
Hi Sam,
[Relaying the same message to your gmail address]
[Cc-ing Peng, as U-Boot MMC maintainer]
[Cc-ing Faiz, as the one who already reviewed the patch]
On Thu, Jan 09, 2020 at 08:47:15PM +0200, Sam Protsenko wrote:
> Fastboot specification [1] requires MMC to be filled with 0xFF's on
> "fastbo
Hi Sam,
On Thu, Jan 09, 2020 at 08:47:15PM +0200, Sam Protsenko wrote:
> Fastboot specification [1] requires MMC to be filled with 0xFF's on
> "fastboot erase" command:
>
> erase:%s Erase the indicated partition (clear to 0xFFs)
>
> Current "fastboot erase" implementation uses actu
Hi Tom,
On Fri, Jan 10, 2020 at 04:50:52PM -0500, Tom Rini wrote:
> On Tue, Dec 24, 2019 at 05:51:08PM +0100, Eugeniu Rosca wrote:
> > Signed-off-by: Eugeniu Rosca
> > Reviewed-by: Sam Protsenko
>
> Applied to u-boot/master, thanks!
Thanks for merging!
--
Best Regards,
Eugeniu
Hi Simon,
On Wed, Jan 08, 2020 at 10:39:34AM -0700, Simon Glass wrote:
> On Tue, 24 Dec 2019 at 09:52, Eugeniu Rosca wrote:
> > [5] New usage
> > adtimg addr - Set image location to
> > adtimg dump - Print out image conte
Hi Simon,
On Tue, Jan 07, 2020 at 09:49:45AM -0700, Simon Glass wrote:
> On Tue, 24 Dec 2019 at 09:51, Eugeniu Rosca wrote:
> >
> > Rename the existing 'dtimg' command to 'adtimg', in order to:
> > - Suggest the Android origins and scope
> > - Be
ndex number of desired DT blob in DTB area\n"
> + " [addr_var]: variable name to contain DT blob address\n"
> + " [size_var]: variable name to contain DT blob size\n"
[minor] Superfluous blank line at the end of help.
Apart from the above, testing two Android v2 images containing the
DTB in so called "concat" and DTBO formats didn't reveal any issues.
Reviewed-by: Eugeniu Rosca
Tested-by: Eugeniu Rosca
--
Best Regards,
Eugeniu
[svar [ivar]]]
- Get DT address/size/index by id|rev fields
Cc: Sam Protsenko
Signed-off-by: Eugeniu Rosca
---
cmd/adtimg.c | 217 +--
1 file changed, 158 insertions(+), 59 deletions(-)
diff --git a/cmd/adtimg.c b/cmd/adtimg.c
index 22b4f5e1a83f..60
With 'dtimg.c' renamed to 'adtimg.c', now ensure the naming
consistency in the internal implementation of 'adtimg.c'.
No functional change intended.
Cc: Sam Protsenko
Signed-off-by: Eugeniu Rosca
---
cmd/adtimg.c | 51 ++---
the internal namespace of 'adtimg.c'
ELF comparison [**] before and after shows no functional change.
[*] https://patchwork.ozlabs.org/patch/1182212/#2291600
[**] diff -u <(objdump -d cmd/dtimg.o) <(objdump -d cmd/adtimg.o)
Cc: Tom Rini
Cc: Sam Protsenko
Cc: Simon Glass
Si
and testing are described meticulously
in each commit.
[1] https://patchwork.ozlabs.org/patch/1202580/
("cmd: dtimg: Get start and size based on --id and --rev")
[2] https://patchwork.ozlabs.org/patch/1182212/
("cmd: bootimg: Add bootimg command")
Eugeni
On Thu, Dec 05, 2019 at 04:17:38AM +0200, Aleksandr Bulyshchenko wrote:
>Hello Sam,
>I'd like to add my 5 cents regarding separating dtimg start|size into 3
>subcommands
>
> dtimg start index [varname]
> dtimg start id [varname]
> dtimg start rev [varname]
>
>While I don'
Hi again,
[I would be willing to take this discussion offline, if you consider it
too noisy for ML]
On Wed, Oct 23, 2019 at 05:34:22PM +0300, Sam Protsenko wrote:
> +U_BOOT_CMD(
> + bootimg, CONFIG_SYS_MAXARGS, 0, do_bootimg,
> + "manipulate Android Boot Image",
> + "set_addr \n"
> +
Hello Sam,
Please, see one more suggestion below.
On Tue, Dec 03, 2019 at 08:29:10PM +0100, Eugeniu Rosca wrote:
> Hi Sam,
> Cc: Aleksandr, Roman
>
> As expressed in the attached e-mail, to minimize the headaches extending
> the argument list of "bootimg" in future, can
Hi Sam,
On Mon, Dec 02, 2019 at 09:07:15PM +0200, Sam Protsenko wrote:
> I'd like this patch series to be applied ASAP (probably before DTBO
> patches you mention are merged). It's been too long as it is. Once
> merged and we are unblocked w.r.t. Android boot stuff, we can then
> look into DTBO ch
but still sending this out; please skip if already answered]
> + "- get address and size (hex) of DTB file in the image\n"
> + " : index of desired DTB file in DTB area\n"
> + " : variable name to contain DTB file address\n"
> +
Hi Sam,
On Mon, Dec 02, 2019 at 07:19:53PM +0200, Sam Protsenko wrote:
> On Tue, Oct 29, 2019 at 3:49 AM Eugeniu Rosca wrote:
> > On Wed, Oct 23, 2019 at 05:34:20PM +0300, Sam Protsenko wrote:
> > > Android Boot Image v2 adds "DTB" payload (and corresponding fie
Dear Igor and Sam,
Cc: Tom, Simon
On Mon, Nov 18, 2019 at 10:27:32PM +0100, Eugeniu Rosca wrote:
> Hello Igor, hello Sam,
>
> We still have high hopes getting your response to
> https://patchwork.ozlabs.org/patch/958594/#2302310
>
> If not given, we will proceed with impleme
0
(FDT)size = 1178
(FDT)compatible = (unknown)
dt_table_entry[5]:
dt_size = 584
dt_offset = 2886
id = 00779000
rev =
custom[0] =
custom[1] =
custom[2] =
int myvar
myvar=ext4
[3] => uuid
b3909b50-55df-4173-b83c-b05343d2d5d2
=> uuid myvar; print myvar
myvar=4c04b15f-d0c1-4f98-9aca-ab62a66be864
[4] => dtimg start 0x4800 0
0x48e0
=> dtimg start 0x4800 0 myvar; print myvar
myvar=48e0
Signed-off-b
: Wrong image address '0x4800z'
Signed-off-by: Eugeniu Rosca
---
cmd/dtimg.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/cmd/dtimg.c b/cmd/dtimg.c
index 2317c859953d..5989081b0c14 100644
--- a/cmd/dtimg.c
+++ b/cmd/dtimg.c
Being user-friendly is paramount to make any product likeable and
easy to use. Hence, instead of [1], print [2].
[1] dtimg start 0x4800 not-a-number myvar
Error: Wrong index
[2] dtimg start 0x4800 not-a-number myvar
Error: Wrong index 'not-a-number'
Signed-off-by: Eug
**] smatch, cppecheck, sparse, make W=1
Eugeniu Rosca (4):
cmd: dtimg: Report invalid index argument
cmd: dtimg: Merge duplicated prints
cmd: dtimg: Make an optional argument
cmd: dtimg: Get start and size based on --id and --rev
cmd/dtimg.c
Hi Sam,
On Wed, Oct 23, 2019 at 05:34:22PM +0300, Sam Protsenko wrote:
> +static int do_bootimg_get_dtb_file(cmd_tbl_t *cmdtp, int flag, int argc,
> +char * const argv[])
> +{
> + char *endp;
> + char buf[65];
> + u32 index;
> + ulong addr;
> + u
Hello Igor, hello Sam,
We still have high hopes getting your response to
https://patchwork.ozlabs.org/patch/958594/#2302310
If not given, we will proceed with implementing the proposal from
https://patchwork.ozlabs.org/patch/958594/#2303657
--
Best Regards,
Eugeniu
_
Hi Roman,
(CC-ing Igor for Android topics)
On Wed, Nov 13, 2019 at 12:19:59PM +0200, Roman Stratiienko wrote:
> On Tue, Nov 12, 2019 at 8:18 PM Eugeniu Rosca wrote:
> >
> > Hello Sam,
> >
> > On Thu, Aug 16, 2018 at 11:34:13PM +0300, Sam Protsenko wrote:
> > &g
Hello Sam,
On Thu, Aug 16, 2018 at 11:34:13PM +0300, Sam Protsenko wrote:
> dtimg command allows user to work with Android DTB/DTBO image format.
> Such as, getting the address of desired DTB/DTBO file, printing the dump
> of the image in U-Boot shell, etc.
>
> This command is needed to provide A
Hi Sam,
On Wed, Oct 23, 2019 at 05:34:20PM +0300, Sam Protsenko wrote:
> Android Boot Image v2 adds "DTB" payload (and corresponding field in the
> image header). Provide functions for its handling:
I believe this totally new degree of freedom brought by "Android Boot
Image v2" might unintentiona
Hi Sam,
On Wed, Oct 23, 2019 at 10:37:23PM +0300, Sam Protsenko wrote:
[..]
> Thanks for your input. All issues you mentioned should be fixed in v2
> I sent recently. Can you please check it out too?
Thanks for the notification. I will review v2 in the following days.
Congrats with the awesome pr
On Wed, Oct 16, 2019 at 07:43:09PM +0200, Eugeniu Rosca wrote:
> On Wed, Oct 16, 2019 at 07:26:44PM +0200, Marek Vasut wrote:
> > On 10/16/19 7:11 PM, Eugeniu Rosca wrote:
> > > On Tue, Oct 15, 2019 at 10:43:41PM +0200, Marek Vasut wrote:
> > >> Add get_timer_us()
On Wed, Oct 16, 2019 at 07:26:44PM +0200, Marek Vasut wrote:
> On 10/16/19 7:11 PM, Eugeniu Rosca wrote:
> > On Tue, Oct 15, 2019 at 10:43:41PM +0200, Marek Vasut wrote:
> >> Add get_timer_us(), which is useful e.g. when we need higher
> >> precision timestamps.
> &
On Tue, Oct 15, 2019 at 10:43:41PM +0200, Marek Vasut wrote:
> Add get_timer_us(), which is useful e.g. when we need higher
> precision timestamps.
>
> Signed-off-by: Marek Vasut
> Cc: Tom Rini
> Cc: Simon Glass
FWIW, I agree with Simon that bootstage [1] can be an awesome tool for
profiling a
On Fri, Sep 20, 2019 at 10:21:29AM -0400, Tom Rini wrote:
[..]
> Reviewed-by: Tom Rini
On Tue, Sep 24, 2019 at 09:24:57AM +0300, Igor Opaniuk wrote:
[..]
> Reviewed-by: Igor Opaniuk
Thank you for the swift reviews!
--
Best Regards,
Eugeniu
___
U-Bo
tition index in hex format and
'part number' returns decimal value, 'part uuid' command will provide
wrong UUID or fail.
Fixes: be683756f62034 ("cmd: part: Add 'number' sub-command")
Cc: Dirk Behme
Reported-by: Pontus Fuchs
Signed-off-by: Roman Stratiienko
Hi Sam,
On Thu, Sep 19, 2019 at 08:28:15PM +0300, Sam Protsenko wrote:
> Android 10 brings a lot of new requirements for bootloaders: [1]. This
> patch series attempts to implement such a boot process on BeagleBoard
> X15 platform. Some common code is added too, which can be reused later
> for oth
Hi Keerthy,
Hi Simon,
cc: Tom
On Tue, Aug 20, 2019 at 09:39:32AM +0530, Keerthy wrote:
> On 19/08/19 3:54 PM, Eugeniu Rosca wrote:
[..]
> > I took some time to also review the changes in addition to testing.
> >
> > I can see that, since its inception in Linux [1], of_get_ad
ug report:
> https://patchwork.ozlabs.org/patch/1090094/#2212555
>
> Fixes: e679d03b08fb ("core: ofnode: Add ofnode_get_addr_size_index")
> Reported-by: Eugeniu Rosca
> Tested-by: Eugeniu Rosca
> Signed-off-by: Keerthy
> ---
>
> Changes from RFT:
>
> * Fix
Hi all,
On Fri, Aug 16, 2019 at 11:46:03AM -0400, David Zeuthen wrote:
>Hi,
>As for upstreaming libavb patches, I'd be interested in landing them
>upstream... makes it easier for anyone.
>Our upstream is AOSP and we use gerrit for
>code-review:
> https://android-review.googles
_dat0().
>
> Fixes: bb98b8c5c06a ("mmc: During a switch, poll on dat0 if available and
> check the final status")
> Signed-off-by: Sam Protsenko
Reviewed-by: Eugeniu Rosca
Tested-by: Eugeniu Rosca
--
Best Regards,
Eugeniu.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Hi Sam,
CC: LIBAVB people (w.r.t. libavb fixes in U-Boot)
I can reproduce the compiler warnings myself and I confirm they are
fixed with this patch. More comments below.
On Thu, Aug 15, 2019 at 11:04:03PM +0300, Sam Protsenko wrote:
> After updating libavb to most recent version from AOSP/master
On Fri, Aug 16, 2019 at 01:59:20PM +0300, Sam Protsenko wrote:
[..]
> On Fri, Aug 16, 2019 at 1:36 PM Eugeniu Rosca wrote:
> > Thanks for the efforts. I get the same result, except the following
> > minor difference [*]. The diff is minor and non-functional, but I
> > thi
Hi Sam,
On Thu, Aug 15, 2019 at 11:04:02PM +0300, Sam Protsenko wrote:
> Update libavb to commit 5fbb42a189aa in AOSP/master, because new version
> has support for super partition [1], which we need for implementing
> Android dynamic partitions. All changes from previous patches for libavb
> in U-
Superseded by https://patchwork.ozlabs.org/patch/1146933/
("core: of_addr: Correct the size type of of_get_address to fdt_size_t")
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
the initial bug report
https://patchwork.ozlabs.org/patch/1090094/#2212555 and, ideally, add
the "Fixes: " line.
Please, add: Reported-by: Eugeniu Rosca
> Signed-off-by: Keerthy
> ---
> drivers/core/of_addr.c | 4 ++--
> drivers/core/ofnode.c | 2 +-
> include/dm/
Hi Keerthy,
On Wed, Aug 14, 2019 at 01:53:50PM +0530, Keerthy wrote:
> Eugeniu,
>
> Could you kindly help me with the steps to reproduce the issue?
Sure. My pleasure. See [0].
> I am sending out a fix patch to convert all the size instances to fdt_size_t
> type.
>
> I have posted: https://patc
Hi Sam,
On Fri, Aug 09, 2019 at 07:16:03PM +0300, Sam Protsenko wrote:
> The requested_partitions[] array should contain only boot partitions.
> Usually it's only 'boot' partition, as can be seen in [1]. Also, seems
> like the requested_partitions[] are only used when there is no 'vbmeta'
> partit
Hi all,
On Mon, Aug 12, 2019 at 02:13:55PM +0300, Igor Opaniuk wrote:
[..]
> Current snapshot of libavb in U-boot is a bit out-dated (~2 years) and
> before introducing patches that can leverage new features from the mainline
> libavb(taking into account that you're referring to Jul 30, 2019 patch
On Fri, Jul 19, 2019 at 05:36:14PM +0300, Sam Protsenko wrote:
> You can check my android-next branch [1] to check all patches I
> collected for sending (and my current work on top of it).
>
> [1] https://github.com/joe-skb7/u-boot-misc/commits/android-next
It looks like we'll be able to dump th
2200259
[2] https://patchwork.ozlabs.org/cover/1128661/
("[v4,0/4] Add 'bcb' command to read/modify/write Android BCB")
Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields")
Reported-by: Simon Glass
Signed-off-by: Eugeniu Rosca
7; command to read/modify/write BCB fields")
Reported-by: Simon Glass
Signed-off-by: Eugeniu Rosca
Reviewed-by: Sam Protsenko
---
v3:
- No changes
- Added 'Reviewed-by: Sam Protsenko' from v2
v2:
- Fixed accidental rename of field/size variables in bcb_field_get()
- https://
Fix warning V1037 reported by PVS-Studio Static Analyzer:
Two or more case-branches perform the same actions. Check lines: 49, 53
Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields")
Signed-off-by: Eugeniu Rosca
Reviewed-by: Igor Opaniuk
Review
Android README and add BCB overview")
Reported-by: Sam Protsenko
Suggested-by: Sam Protsenko
Signed-off-by: Eugeniu Rosca
Reviewed-by: Igor Opaniuk
Reviewed-by: Sam Protsenko
---
v3:
- Dropped changes in doc/android/fastboot.txt, since the same
have been performed by commit
http
col doc to android dir"), since it
created conflicts merging v2
- No other changes
v2:
- Ensured git bisectability for the series
- [Igor Opaniuk] Enriched patch description
- No series-wide changes in the contents
- https://patchwork.ozlabs.org/cover/1131356/
v1:
- https://patchwork.ozlabs
Hi Sam,
On Thu, Jul 18, 2019 at 07:57:45PM -0400, Tom Rini wrote:
> On Tue, Jul 02, 2019 at 09:14:57PM +0300, Sam Protsenko wrote:
>
> > Signed-off-by: Sam Protsenko
>
> Applied to u-boot/master, thanks!
This recent merge introduced a conflict when applying [1] to master.
Are you aware of any
Hi Heinrich,
On Sun, Jul 14, 2019 at 11:31:50PM +0200, Heinrich Schuchardt wrote:
> Packed structures like struct uuid are not aligned. GCC 9.1 therefore
> throws an error when trying to compile gen_rand_uuid().
>
> lib/uuid.c: In function ‘gen_rand_uuid’:
> lib/uuid.c:244:2: error: converting a
Hi Tom,
cc: Jeremy, Stephen,
On Sun, Jul 14, 2019 at 01:14:32PM -0400, Tom Rini wrote:
> On Sat, Jul 13, 2019 at 10:39:19AM +0200, Eugeniu Rosca wrote:
>
> > Superseded by https://patchwork.ozlabs.org/patch/1131355/
> > ("[v2,1/5] doc: Move README.android-fastboot-
Superseded by https://patchwork.ozlabs.org/patch/1131359/
("[v2,5/5] cmd: bcb: Apply non-functional refinements")
--
Best Regards,
Eugeniu.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Superseded by https://patchwork.ozlabs.org/patch/1131358/
("[v2,4/5] cmd: bcb: Use strcmp() instead of strncmp() for string literals")
--
Best Regards,
Eugeniu.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Superseded by https://patchwork.ozlabs.org/patch/1131357/
("[v2,3/5] cmd: bcb: Fix duplicated handling in two case-branches")
--
Best Regards,
Eugeniu.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Superseded by https://patchwork.ozlabs.org/patch/1131354/
("[v2,2/5] treewide: Fix stale references of Android docs")
--
Best Regards,
Eugeniu.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Superseded by https://patchwork.ozlabs.org/patch/1131355/
("[v2,1/5] doc: Move README.android-fastboot-protocol to doc/android/")
--
Best Regards,
Eugeniu.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
On Fri, Jul 12, 2019 at 05:01:09PM +0300, Sam Protsenko wrote:
> > > diff --git a/cmd/bcb.c b/cmd/bcb.c
> > > index 2bd5a744deb5..3b1c7434e287 100644
> > > --- a/cmd/bcb.c
> > > +++ b/cmd/bcb.c
> > > @@ -46,9 +46,6 @@ static int bcb_is_misused(int argc, char *const argv[])
> > >
> > > switc
Hi Sam,
On Fri, Jul 12, 2019 at 04:25:11PM +0300, Sam Protsenko wrote:
> Reviewed-by: Sam Protsenko
Please, discard the v1 [*] and consider v2 [**] instead.
There should be a clear protocol to communicate that to the maintainers,
such that we avoid seeing the v1 applied to master. I placed a co
Hi Sam,
On Fri, Jul 12, 2019 at 04:18:20PM +0300, Sam Protsenko wrote:
> Let's finalize modern Android boot flow via scripting (as we need all
> those commands anyway), then we can think if we need to wrap the whole
> thing into boot_android command. There is a lot of stuff happening
> during the
On Fri, Jul 12, 2019 at 03:05:59PM +0300, Igor Opaniuk wrote:
> On Fri, Jul 12, 2019 at 2:26 PM Eugeniu Rosca wrote:
> >
> > These have been reported by Simon in [1] and fixed in [2].
> > However, since [1] has already been pushed to u-boot/master, the
> > improvements
The whole series is obsoleted/superseded by v2:
https://patchwork.ozlabs.org/cover/1131356/
("[v2,0/5] Fixes and improvements in BCB and Android docs")
--
Best Regards,
Eugeniu.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo
2200259
[2] https://patchwork.ozlabs.org/cover/1128661/
("[v4,0/4] Add 'bcb' command to read/modify/write Android BCB")
Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields")
Reported-by: Simon Glass
Signed-off-by: Eugeniu Rosca
---
v2
Fix warning V1037 reported by PVS-Studio Static Analyzer:
Two or more case-branches perform the same actions. Check lines: 49, 53
Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields")
Signed-off-by: Eugeniu Rosca
Reviewed-by: Igor Opaniuk
---
v2:
Commit 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB
overview") missed relocating README.android-fastboot-protocol. Fix it.
Fixes: 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB overview")
Signed-off-by: Eugeniu Rosca
Reviewed-by: Igor Opani
7; command to read/modify/write BCB fields")
Reported-by: Simon Glass
Signed-off-by: Eugeniu Rosca
---
v2:
- Fixed accidental rename of field/size variables in bcb_field_get()
v1:
- https://patchwork.ozlabs.org/patch/1131306/
---
cmd/bcb.c | 22 +++---
1 file changed, 11
bs.org/cover/1128661/
("[v4,0/4] Add 'bcb' command to read/modify/write Android BCB")
v2:
- Ensured git bisectability for the series
- [Igor Opaniuk] Enriched patch description
- No series-wide changes in the contents
v1:
- https://patchwork.ozlabs.org/cover/1131295/
Eugen
Android README and add BCB overview")
Reported-by: Sam Protsenko
Suggested-by: Sam Protsenko
Signed-off-by: Eugeniu Rosca
Reviewed-by: Igor Opaniuk
---
v2:
- Added 'Reviewed-by: Igor Opaniuk' from v1
v1:
- https://patchwork.ozlabs.org/patch/1131305/
---
cmd/Kconfig
Hi Igor,
On Fri, Jul 12, 2019 at 02:54:19PM +0300, Igor Opaniuk wrote:
> > static int bcb_field_get(char *name, char **field, int *size)
> > {
> > - if (!strncmp(name, "command", sizeof("command"))) {
> > - *field = bcb.command;
> > + if (!strcmp(name, "command")) {
> >
/
("[v4,0/4] Add 'bcb' command to read/modify/write Android BCB")
Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields")
Reported-by: Simon Glass
Signed-off-by: Eugeniu Rosca
---
cmd/bcb.c | 23 ---
1 file
7; command to read/modify/write BCB fields")
Reported-by: Simon Glass
Signed-off-by: Eugeniu Rosca
---
cmd/bcb.c | 42 +-
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/cmd/bcb.c b/cmd/bcb.c
index 3b1c7434e287..c7138a5179a9 100644
--
Android README and add BCB overview")
Reported-by: Sam Protsenko
Suggested-by: Sam Protsenko
Signed-off-by: Eugeniu Rosca
---
cmd/Kconfig | 2 +-
doc/android/fastboot.txt | 2 +-
test/py/tests/test_avb.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
Fix warning V1037 reported by PVS-Studio Static Analyzer:
Two or more case-branches perform the same actions. Check lines: 49, 53
Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields")
Signed-off-by: Eugeniu Rosca
---
cmd/bcb.c | 3 ---
1 file
Commit 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB
overview") missed relocating README.android-fastboot-protocol. Fix it.
Fixes: 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB overview")
Signed-off-by: Eugeniu Rosca
---
.../f
bs.org/cover/1128661/
("[v4,0/4] Add 'bcb' command to read/modify/write Android BCB")
Eugeniu Rosca (5):
doc: Move README.android-fastboot-protocol to doc/android/
treewide: Fix stale references of Android docs
cmd: bcb: Fix duplicated handling in two case-branches
c
Hi Sam,
On Tue, Jul 09, 2019 at 03:20:01PM +0300, Sam Protsenko wrote:
> Tom, Simon,
>
> Can we please handle this series and apply it to master? A lot of
> Android-related patches depend on this, so if all comments are
> addressed in v4 and there are no further concerns, it would be great
> to h
.;" \
> "setenv dofastboot 0; saveenv;" \
> - "echo Booting into fastboot ...; " \
> - "fastboot " __stringify(CONFIG_FASTBOOT_USB_DEV) "; " \
> + FASTBOOT_CMD \
> "fi;" \
>
jFTR/FWIW, the SD card UUIDs on my H3-Salvator-X [1] are reported
correctly [2] on v2019.07-39-gb4944e25744a.
[1] https://elinux.org/R-Car/Boards/Salvator-X
[2] https://gist.github.com/erosca/829986fe0567ccdba56e6e4849f4d458
--
Best Regards,
Eugeniu.
_
On Tue, Jun 18, 2019 at 12:36:44PM +0200, Marek Vasut wrote:
> Also keep in mind that the U-Boot binary cannot grow over 1 MiB, that's
> a limit imposed by the flash layout, and we're getting close.
I hope enough space will be available in future for enabling such
compile flags as -fsanitize=addre
Hi Priit,
On Tue, Jul 09, 2019 at 02:52:56PM +0300, Priit Laes wrote:
> From: Priit Laes
>
> Add u-boot specific getvar "extension" to fetch u-boot environment
> variables via `fastboot getvar uboot:var`. This makes it possible
> to gather certain data (like mac addresses) in an automated way
>
Superseded by https://patchwork.ozlabs.org/cover/1129905/.
--
Best Regards,
Eugeniu.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
1 - 100 of 396 matches
Mail list logo
