Re: [PATCH v2 01/21] mmc: sdhci: Add helper functions for UHS modes

2020-11-04 Thread Faiz Abbas
Jaehoon, On 21/10/20 5:08 pm, Jaehoon Chung wrote: > Hi Faiz, > > On 10/16/20 8:08 PM, Faiz Abbas wrote: >> Add a set_voltage() function which handles the switch from 3.3V to 1.8V >> for SD card UHS modes. >> >> Signed-off-by: Faiz Abbas &g

[PATCH v2 19/21] arm: dts: k3-am65-main: Add itapdly and clkbuf-sel values

2020-10-16 Thread Faiz Abbas
Add the appropriate itapdly and clkbuf-sel values required for some lower speed modes. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am65-main.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/dts/k3-am65-main.dtsi b/arch/arm/dts/k3-am65-main.dtsi index d151e27028

[PATCH v2 17/21] configs: j7200_evm: Add support for UHS modes

2020-10-16 Thread Faiz Abbas
Add configs to support UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/j7200_evm_a72_defconfig | 8 configs/j7200_evm_r5_defconfig | 1 + 2 files changed, 9 insertions(+) diff --git a/configs/j7200_evm_a72_defconfig b/configs

[PATCH v2 20/21] arm: dts: k3-am654-base-board: Limit Sd card to High speed modes

2020-10-16 Thread Faiz Abbas
There's an issue with the base board in which the power cycle circuit takes way longer to power down than expected by mmc core. code. This prevents the card from enumerating in UHS modes. Disable UHS modes for this board until a new board revision fixes the issue. Signed-off-by: Faiz

[PATCH v2 18/21] i2c: Makefile: Add SPL_DM_I2C_GPIO

2020-10-16 Thread Faiz Abbas
Add an SPL flag to DM_I2C_GPIO to prevent it building automatically in SPL. Signed-off-by: Faiz Abbas --- drivers/i2c/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile index bd248cbf52..b37198036c 100644 --- a/drivers/i2c

[PATCH v2 21/21] configs: am65x_evm: Add configs for UHS modes

2020-10-16 Thread Faiz Abbas
Add configs for voltage switching and UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/am65x_evm_a53_defconfig | 8 configs/am65x_evm_r5_defconfig | 2 ++ 2 files changed, 10 insertions(+) diff --git a/configs/am65x_evm_a53_defconfig b/configs

[PATCH v2 14/21] arm: dts: k3-j7200-main: Add support for gpio0

2020-10-16 Thread Faiz Abbas
Add support for the main_gpio0 node Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j7200-main.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/dts/k3-j7200-main.dtsi b/arch/arm/dts/k3-j7200-main.dtsi index c25f03cf23..b722204c44 100644 --- a/arch/arm/dts

[PATCH v2 11/21] arm: dts: k3-am65: Fix mmc nodes

2020-10-16 Thread Faiz Abbas
the u-boot.dtsi Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am65-main.dtsi | 22 +++ arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 67 +++- arch/arm/dts/k3-am654-base-board.dts | 25 arch/arm/dts/k3-am654-r5-base-board.dts | 20 +- 4

[PATCH v2 13/21] arm: dts: k3-j721e-common-proc-board: Add support for UHS modes for SD card

2020-10-16 Thread Faiz Abbas
Add support for regulators to power cycle and switch IO voltage to the SD card. This enables support for UHS modes. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-common-proc-board.dts | 32 + 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e-common

[PATCH v2 16/21] configs: j721e_evm: Add support for UHS modes

2020-10-16 Thread Faiz Abbas
Add configs to support UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 8 configs/j721e_evm_r5_defconfig | 1 + 2 files changed, 9 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs

[PATCH v2 15/21] arm: dts: k3-j7200-common-proc-board: Enable support for UHS modes

2020-10-16 Thread Faiz Abbas
Add support for UHS modes by adding the regulators to power cycle and voltage switch the card. Also add pinmuxes required for each node Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j7200-common-proc-board.dts | 49 ++- arch/arm/dts/k3-j7200-main.dtsi | 1

[PATCH v2 12/21] arm: dts: k3-j721e-main: Update otap-delay values

2020-10-16 Thread Faiz Abbas
Update otap delay values to match with the latest Data Manual[1]. [1] https://www.ti.com/lit/gpn/dra829v Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-main.dtsi | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/dts/k3-j721e-main.dtsi b/arch/arm/dts/k3

[PATCH v2 08/21] mmc: am654_sdhci: Add support for software tuning

2020-10-16 Thread Faiz Abbas
for each of the values. Typically, the range will have a small contiguous failing window. Considering the tuning range as a circular buffer, the algorithm then sets a final tuned value directly opposite to the failing window. [1] https://www.ti.com/lit/pdf/spract9 Signed-off-by: Faiz Abbas

[PATCH v2 10/21] mmc: am654_sdhci: Use sdhci_set_control_reg()

2020-10-16 Thread Faiz Abbas
Use the generic sdhci_set_control_reg() instead of duplicating in platform driver. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index

[PATCH v2 09/21] mmc: am654_sdhci: Fix HISPD bit configuration in some lower speed modes

2020-10-16 Thread Faiz Abbas
. Use the sdhci writeb callback to implement this condition. [1] http://www.ti.com/lit/gpn/am6546 Section 5.10.5.16.1 Signed-off-by: Faiz Abbas --- drivers/mmc/Kconfig | 1 + drivers/mmc/am654_sdhci.c | 25 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff

[PATCH v2 07/21] mmc: am654_sdhci: Add support for writing to clkbuf_sel

2020-10-16 Thread Faiz Abbas
Add support for writing new clock buffer select property for both the am654x and j721e 4 bit IPs Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index f472672152

[PATCH v2 03/21] mmc: am654_sdhci: Convert flag fields to BIT macro

2020-10-16 Thread Faiz Abbas
Convert the flags field defines to use the BIT() macro. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 15a47f1e71..10350d8d61 100644 --- a/drivers/mmc

[PATCH v2 05/21] mmc: am654_sdhci: Add support for AM65x SR2.0

2020-10-16 Thread Faiz Abbas
Add Support for AM65x PG2.0. Use the SoC bus framework to fixup the platform data and do DLL calibration if the revision is 1.0 Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/mmc/am654_sdhci.c b

[PATCH v2 01/21] mmc: sdhci: Add helper functions for UHS modes

2020-10-16 Thread Faiz Abbas
Add a set_voltage() function which handles the switch from 3.3V to 1.8V for SD card UHS modes. Signed-off-by: Faiz Abbas --- drivers/mmc/sdhci.c | 51 + include/sdhci.h | 1 + 2 files changed, 52 insertions(+) diff --git a/drivers/mmc/sdhci.c b

[PATCH v2 06/21] mmc: am654_sdhci: Add support for input tap delay

2020-10-16 Thread Faiz Abbas
speed mode. Therefore, move all dll configurations to their own functions and gate it with 50 MHz speed and a minimum mode. If both these conditions are not satisfied then configure delay chain modes. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 241 +---

[PATCH v2 04/21] mmc: am654_sdhci: Add flag for PHY calibration

2020-10-16 Thread Faiz Abbas
Not all controllers need calibration for the PHY DLL. Add a DLL_CALIB flag to indicate the same. Also move the write of trm_icp and driver strength to the set_clock() function to match the kernel configuration flow. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 26

[PATCH v2 00/21] Add support for MMC higher speed modes for TI's am65x, j721e and j7200 platforms

2020-10-16 Thread Faiz Abbas
nk to v1: https://patchwork.ozlabs.org/project/uboot/list/?series=206622 Faiz Abbas (21): mmc: sdhci: Add helper functions for UHS modes mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of ios_post() mmc: am654_sdhci: Convert flag fields to BIT macro mmc: am654_sdhci: A

[PATCH v2 02/21] mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of ios_post()

2020-10-16 Thread Faiz Abbas
. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 82abf484e4..15a47f1e71 100644 --- a/drivers/mmc/am654_sdhci.c +++ b/drivers/mmc/am654_sdhci.c @@ -84,7

Re: [PATCH 01/17] mmc: sdhci: Add helper functions for UHS modes

2020-10-11 Thread Faiz Abbas
Hi, On 08/10/20 10:42 am, Faiz Abbas wrote: > Add a set_voltage() function which handles the switch from 3.3V to 1.8V > for SD card UHS modes. > > Signed-off-by: Faiz Abbas > --- Travisci is showing build issues for this patch with some boards. Will fix and repost for v2. Thanks, Faiz

[PATCH 16/17] configs: j721e_evm: Add support for UHS modes

2020-10-07 Thread Faiz Abbas
Add configs to support UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/j721e_evm_a72_defconfig | 8 configs/j721e_evm_r5_defconfig | 1 + 2 files changed, 9 insertions(+) diff --git a/configs/j721e_evm_a72_defconfig b/configs

[PATCH 17/17] configs: j7200_evm: Add support for UHS modes

2020-10-07 Thread Faiz Abbas
Add configs to support UHS modes for the SD card and HS200 for the eMMC. Signed-off-by: Faiz Abbas --- configs/j7200_evm_a72_defconfig | 8 configs/j7200_evm_r5_defconfig | 1 + 2 files changed, 9 insertions(+) diff --git a/configs/j7200_evm_a72_defconfig b/configs

[PATCH 15/17] arm: dts: k3-j7200-common-proc-board: Enable support for UHS modes

2020-10-07 Thread Faiz Abbas
Add support for UHS modes by adding the regulators to power cycle and voltage switch the card. Also add pinmuxes required for each node. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j7200-common-proc-board.dts | 49 ++- .../arm/dts/k3-j7200-r5-common-proc-board.dts | 15

[PATCH 12/17] arm: dts: k3-j721e-main: Update otap-delay values

2020-10-07 Thread Faiz Abbas
Update otap delay values to match with the latest Data Manual[1]. [1] https://www.ti.com/lit/gpn/dra829v Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-main.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/dts/k3-j721e-main.dtsi b/arch/arm/dts/k3

[PATCH 13/17] arm: dts: k3-j721e-common-proc-board: Add support for UHS modes for SD card

2020-10-07 Thread Faiz Abbas
Add support for regulators to power cycle and switch IO voltage to the SD card. This enables support for UHS modes. Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j721e-common-proc-board.dts | 32 + 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e-common

[PATCH 14/17] arm: dts: k3-j7200-main: Add support for gpio0

2020-10-07 Thread Faiz Abbas
Add support for the main_gpio0 node Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-j7200-main.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/dts/k3-j7200-main.dtsi b/arch/arm/dts/k3-j7200-main.dtsi index c25f03cf23..b722204c44 100644 --- a/arch/arm/dts

[PATCH 11/17] arm: dts: k3-am65: Fix mmc nodes

2020-10-07 Thread Faiz Abbas
the u-boot.dtsi Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am65-main.dtsi | 22 +++ arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 67 +++- arch/arm/dts/k3-am654-base-board.dts | 25 arch/arm/dts/k3-am654-r5-base-board.dts | 20 +- 4

[PATCH 10/17] mmc: am654_sdhci: Use sdhci_set_control_reg()

2020-10-07 Thread Faiz Abbas
Use the generic sdhci_set_control_reg() instead of duplicating in platform driver. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index

[PATCH 08/17] mmc: am654_sdhci: Add support for software tuning

2020-10-07 Thread Faiz Abbas
for each of the values. Typically, the range will have a small contiguous failing window. Considering the tuning range as a circular buffer, the algorithm then sets a final tuned value directly opposite to the failing window. [1] https://www.ti.com/lit/pdf/spract9 Signed-off-by: Faiz Abbas

[PATCH 07/17] mmc: am654_sdhci: Add support for writing to clkbuf_sel

2020-10-07 Thread Faiz Abbas
Add support for writing new clock buffer select property for both the am654x and j721e 4 bit IPs Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index f472672152

[PATCH 09/17] mmc: am654_sdhci: Fix HISPD bit configuration in some lower speed modes

2020-10-07 Thread Faiz Abbas
. Use the sdhci writeb callback to implement this condition. [1] http://www.ti.com/lit/gpn/am6546 Section 5.10.5.16.1 Signed-off-by: Faiz Abbas --- drivers/mmc/Kconfig | 1 + drivers/mmc/am654_sdhci.c | 25 +++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff

[PATCH 06/17] mmc: am654_sdhci: Add support for input tap delay

2020-10-07 Thread Faiz Abbas
speed mode. Therefore, move all dll configurations to their own functions and gate it with 50 MHz speed and a minimum mode. If both these conditions are not satisfied then configure delay chain modes. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 241 +---

[PATCH 02/17] mmc: am654_sdhci: Unconditionally switch off DLL in the beginning of ios_post()

2020-10-07 Thread Faiz Abbas
. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 82abf484e4..15a47f1e71 100644 --- a/drivers/mmc/am654_sdhci.c +++ b/drivers/mmc/am654_sdhci.c @@ -84,7

[PATCH 04/17] mmc: am654_sdhci: Add flag for PHY calibration

2020-10-07 Thread Faiz Abbas
Not all controllers need calibration for the PHY DLL. Add a DLL_CALIB flag to indicate the same. Also move the write of trm_icp and driver strength to the set_clock() function to match the kernel configuration flow. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 26

[PATCH 01/17] mmc: sdhci: Add helper functions for UHS modes

2020-10-07 Thread Faiz Abbas
Add a set_voltage() function which handles the switch from 3.3V to 1.8V for SD card UHS modes. Signed-off-by: Faiz Abbas --- drivers/mmc/sdhci.c | 49 + include/sdhci.h | 1 + 2 files changed, 50 insertions(+) diff --git a/drivers/mmc/sdhci.c b

[PATCH 05/17] mmc: am654_sdhci: Add support for AM65x SR2.0

2020-10-07 Thread Faiz Abbas
Add Support for AM65x PG2.0. Use the SoC bus framework to fixup the platform data and do DLL calibration if the revision is 1.0 Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/mmc/am654_sdhci.c b

[PATCH 03/17] mmc: am654_sdhci: Convert flag fields to BIT macro

2020-10-07 Thread Faiz Abbas
Convert the flags field defines to use the BIT() macro. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c index 15a47f1e71..10350d8d61 100644 --- a/drivers/mmc

[PATCH 00/17] Add support for MMC higher speed modes for TI's am65x, j721e and j7200 platforms

2020-10-07 Thread Faiz Abbas
The following patches add support for higher speeds in the SD card and eMMC for TI's am65x, j721e, j7200 platforms. After these patches j721e and j7200 will support ultra high speed while am65x will support upto high speed modes. Faiz Abbas (17): mmc: sdhci: Add helper functions for UHS

[PATCH v2 5/5] configs: Add spiboot support for am335x

2020-09-13 Thread Faiz Abbas
am335x internal SRAM is too small to support the addition of SPI bootmode to the default defconfig. Add a separate spiboot_defconfig Signed-off-by: Faiz Abbas --- board/ti/am335x/MAINTAINERS | 1 + configs/am335x_evm_spiboot_defconfig | 93 2 files changed

[PATCH v2 1/5] arm: dts: am335x-icev2: Add spi node

2020-09-13 Thread Faiz Abbas
Add spi and spi nor flash nodes for am335x-icev2. Signed-off-by: Faiz Abbas --- arch/arm/dts/am335x-icev2.dts | 50 +++ 1 file changed, 50 insertions(+) diff --git a/arch/arm/dts/am335x-icev2.dts b/arch/arm/dts/am335x-icev2.dts index 37484cb6f5..2a1b3a53e9

[PATCH v2 4/5] spi: omap3_spi: Read platform data in ofdata_to_platdata()

2020-09-13 Thread Faiz Abbas
Add an ofdata_to_platdata() callback to access dts in U-boot and access all platform data in it. This prepares the driver for supporting both device tree as well as static platform data structures in SPL. Signed-off-by: Faiz Abbas --- drivers/spi/omap3_spi.c | 37

[PATCH v2 0/5] Add spi boot support to am335x-icev2

2020-09-13 Thread Faiz Abbas
The following patches add spi boot support to TI's am335x-icev2 platform v2: 1. Changed order of patches to avoid breaking build 2. Changed SPI_OFFSET to SPI0_OFFSET and moved the define arch/arm/mach-omap2/am335x/board.c 3. Updated MAINTAINERS list with the new defconfig. Faiz Abb

[PATCH v2 3/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-13 Thread Faiz Abbas
Add platform data and a device structure for the spi device present on am335x-icev2. This requires moving all omap3_spi platform data structures and symbols to an omap3_spi.h so that the board file can access them. Signed-off-by: Faiz Abbas --- arch/arm/mach-omap2/am33xx/board.c | 18

[PATCH v2 2/5] spi: spi-uclass: Block dm_scan_fdt_dev with OF_CONTROL to prevent build failures

2020-09-13 Thread Faiz Abbas
There are devices which don't use OF_CONTROL or OF_PLATDATA but instead rely on statically defined platdata. Block dm_scan_fdt_dev() with both configs to avoid build failures under this condition. Signed-off-by: Faiz Abbas Reviewed-by: Jagan Teki --- drivers/spi/spi-uclass.c | 2 +- 1

Re: [PATCH 0/5] Add spi boot support to am335x-icev2

2020-09-10 Thread Faiz Abbas
Hi Lokesh, On 11/09/20 8:16 am, Lokesh Vutla wrote: > > > On 02/09/20 4:47 pm, Faiz Abbas wrote: >> The following patches add spi boot support to TI's am335x-icev2 platform > > > Can you post v2 with comments addressed? I am waiting on this for sending a PR >

Re: [PATCH 5/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-08 Thread Faiz Abbas
Hi Vignesh, On 07/09/20 5:49 pm, Vignesh Raghavendra wrote: > Hi, > > On 9/7/20 4:02 PM, Faiz Abbas wrote: >> Hi Vignesh, >> >> On 07/09/20 1:48 pm, Vignesh Raghavendra wrote: >>> >>> >>> On 9/7/20 12:36 PM, Faiz Abbas wrote: >>>

Re: [PATCH 5/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-07 Thread Faiz Abbas
Hi Vignesh, On 07/09/20 1:48 pm, Vignesh Raghavendra wrote: > > > On 9/7/20 12:36 PM, Faiz Abbas wrote: >> Hi Lokesh, >> >> On 07/09/20 12:08 pm, Lokesh Vutla wrote: >>> >>> >>> On 02/09/20 4:48 pm, Faiz Abbas wrote: >>>> Add pl

Re: [PATCH 5/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-07 Thread Faiz Abbas
Hi Lokesh, On 07/09/20 12:08 pm, Lokesh Vutla wrote: > > > On 02/09/20 4:48 pm, Faiz Abbas wrote: >> Add platform data and a device structure for the spi device >> present on am335x-icev2. This requires moving all omap3_spi >> platform data structures and symbol

[PATCH 5/5] arm: mach-omap2: am33xx: Add device structure for spi

2020-09-02 Thread Faiz Abbas
Add platform data and a device structure for the spi device present on am335x-icev2. This requires moving all omap3_spi platform data structures and symbols to an omap3_spi.h so that the board file can access them. Signed-off-by: Faiz Abbas --- arch/arm/mach-omap2/am33xx/board.c | 12

[PATCH 4/5] spi: omap3_spi: Read platform data in ofdata_to_platdata()

2020-09-02 Thread Faiz Abbas
Add an ofdata_to_platdata() callback to access dts in U-boot and access all platform data in it. This prepares the driver for supporting both device tree as well as static platform data structures in SPL. Signed-off-by: Faiz Abbas --- drivers/spi/omap3_spi.c | 37

[PATCH 3/5] spi: spi-uclass: Block dm_scan_fdt_dev with OF_CONTROL to prevent build failures

2020-09-02 Thread Faiz Abbas
There are devices which don't use OF_CONTROL or OF_PLATDATA but instead rely on statically defined platdata. Block dm_scan_fdt_dev() with both configs to avoid build failures under this condition. Signed-off-by: Faiz Abbas --- drivers/spi/spi-uclass.c | 2 +- 1 file changed, 1 insertion(

[PATCH 2/5] configs: Add spiboot support for am335x

2020-09-02 Thread Faiz Abbas
am335x internal SRAM is too small to support the addition of SPI bootmode to the default defconfig. Add a separate spiboot_defconfig Signed-off-by: Faiz Abbas --- configs/am335x_evm_spiboot_defconfig | 93 1 file changed, 93 insertions(+) create mode 100644 configs

[PATCH 0/5] Add spi boot support to am335x-icev2

2020-09-02 Thread Faiz Abbas
The following patches add spi boot support to TI's am335x-icev2 platform Faiz Abbas (5): arm: dts: am335x-icev2: Add spi node configs: Add spiboot support for am335x spi: spi-uclass: Block dm_scan_fdt_dev with OF_CONTROL to prevent build failures spi: omap3_spi: Read platform da

[PATCH 1/5] arm: dts: am335x-icev2: Add spi node

2020-09-02 Thread Faiz Abbas
Add spi and spi nor flash nodes for am335x-icev2. Signed-off-by: Faiz Abbas --- arch/arm/dts/am335x-icev2.dts | 50 +++ 1 file changed, 50 insertions(+) diff --git a/arch/arm/dts/am335x-icev2.dts b/arch/arm/dts/am335x-icev2.dts index 37484cb6f5..2a1b3a53e9

Re: [PATCH] Revert "mmc: disable UHS modes if Vcc cannot be switched on and off"

2020-08-11 Thread Faiz Abbas
Pali, On 11/08/20 1:19 pm, Pali Rohár wrote: > On Tuesday 11 August 2020 08:39:24 Faiz Abbas wrote: >> Pali, Peng, >> >> On 10/08/20 6:25 am, Peng Fan wrote: >>> Faiz, Jean >>> >>>> Subject: [PATCH] Revert "mmc: disable UHS modes if Vcc cann

Re: [PATCH] Revert "mmc: disable UHS modes if Vcc cannot be switched on and off"

2020-08-10 Thread Faiz Abbas
Pali, Peng, On 10/08/20 6:25 am, Peng Fan wrote: > Faiz, Jean > >> Subject: [PATCH] Revert "mmc: disable UHS modes if Vcc cannot be switched >> on and off" > > Got time to take a look? > When this issue was reported in the last thread, Pali said that he was unable to get prints because of the

Re: [PATCH 06/13] arm: mach-k3: am6_init: Do USB fixups to facilitate host and device boot modes

2020-08-02 Thread Faiz Abbas
Hi Vignesh, On 03/07/20 1:04 pm, Vignesh Raghavendra wrote: > Hi, > > On 02/07/20 1:32 pm, Faiz Abbas wrote: > > [...] >> int am6_spl_early_init(void) > > Can this be static or do you intend to use this outside of this func file? Fixed this in v2. > >> +{

[PATCH v2 11/13] configs: am65x_evm_a53: Enable USB Mass storage and DFU boot modes

2020-08-02 Thread Faiz Abbas
Enable configs to facilitate booting from USB Mass Storage devices as well as USB peripheral boot Signed-off-by: Faiz Abbas --- configs/am65x_evm_a53_defconfig | 10 ++ include/configs/am65x_evm.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/configs

[PATCH v2 12/13] configs: Add defconfig for USB DFU bootmode

2020-08-02 Thread Faiz Abbas
Because of space constraints, create a new USB defconfig for R5 to faciliate booting in USB peripheral (DFU) bootmode Signed-off-by: Faiz Abbas --- configs/am65x_evm_r5_usbdfu_defconfig | 120 ++ 1 file changed, 120 insertions(+) create mode 100644 configs

[PATCH v2 10/13] configs: am65x_evm: Add support for DFU related configs

2020-08-02 Thread Faiz Abbas
Add offset and environment related configs used for booting from DFU. Signed-off-by: Faiz Abbas --- include/configs/am65x_evm.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h index 19d861d402..902b5ba398 100644

[PATCH v2 09/13] arm: dts: k3-am654-base-board: Add support for USB0 in SPL

2020-08-02 Thread Faiz Abbas
Add nodes for USB0 in SPL to enable USB host boot mode Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 27 1 file changed, 27 insertions(+) diff --git a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi b/arch/arm/dts/k3-am654-base-board-u

[PATCH v2 13/13] configs: Add new config for supporting USB mass storage boot

2020-08-02 Thread Faiz Abbas
Because of space constraints, create a new USB defconfig for R5 to faciliate booting from USB mass storage devices Signed-off-by: Faiz Abbas --- configs/am65x_evm_r5_usbmsc_defconfig | 119 ++ 1 file changed, 119 insertions(+) create mode 100644 configs

[PATCH v2 08/13] arm: dts: k3-am654-r5-base-board: Add USB0 nodes

2020-08-02 Thread Faiz Abbas
Add USB0 nodes and set them to host mode to support USB host and peripheral boot modes Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-r5-base-board.dts | 35 + 1 file changed, 35 insertions(+) diff --git a/arch/arm/dts/k3-am654-r5-base-board.dts b/arch/arm/dts/k3

[PATCH v2 07/13] arm: mach-k3: am6_init: Add support for USB boot mode

2020-08-02 Thread Faiz Abbas
Add support for identifying USB host and device boot modes Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 5 + arch/arm/mach-k3/include/mach/am6_hardware.h | 2 ++ arch/arm/mach-k3/include/mach/am6_spl.h | 3 ++- 3 files changed, 9 insertions(+), 1

[PATCH v2 06/13] arm: mach-k3: am6_init: Do USB fixups to facilitate host and device boot modes

2020-08-02 Thread Faiz Abbas
speeds. Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 40 + 1 file changed, 40 insertions(+) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c index 42d13a39f8..c6d4f05a01 100644 --- a/arch/arm/mach-k3/am6_init.c ++

[PATCH v2 04/13] arm: mach-k3: sysfw-loader: Add support to load SYSFW from USB

2020-08-02 Thread Faiz Abbas
Add support for loading system firmware from a USB mass storage device Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/sysfw-loader.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/mach-k3/sysfw-loader.c b/arch/arm/mach-k3/sysfw-loader.c index 513be09c68..0ebd8c56a7

[PATCH v2 05/13] arm: mach-k3: am6_init: Gate mmc related configurations with the appropriate config

2020-08-02 Thread Faiz Abbas
Gate mmc related system related configurations with DM_MMC to avoid build errors when MMC is not enabled Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c

[PATCH v2 03/13] armv7R: K3: am654: Use full malloc in SPL both pre and post reloc

2020-08-02 Thread Faiz Abbas
go ahead and enable the use of the full malloc by manually initializing the required functionality inside board_init_f by creating a full malloc pool inside the pre-relocation malloc pool. Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 18 ++ 1 file changed, 18

[PATCH v2 02/13] spl: usb: Only init usb once

2020-08-02 Thread Faiz Abbas
usb_init() may be called multiple times for fetching multiple images from SPL. Skip reinitializing USB if its already been done Signed-off-by: Faiz Abbas --- common/spl/spl_usb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/common/spl/spl_usb.c b/common/spl

[PATCH v2 00/13] Add support for USB host and peripheral bootmodes on am65x-idk

2020-08-02 Thread Faiz Abbas
USB subsystem which is a longer term effort v2: Using fdtdec_board_setup() function override in patch 6 instead of open coding spl_common_init() Faiz Abbas (13): spl: usb: Create an API spl_usb_load() spl: usb: Only init usb once armv7R: K3: am654: Use full malloc in SPL both pre and post

[PATCH v2 01/13] spl: usb: Create an API spl_usb_load()

2020-08-02 Thread Faiz Abbas
Create a new API spl_usb_load() that takes the filename as a parameter instead of taking the default U-boot PAYLOAD_NAME Signed-off-by: Faiz Abbas --- common/spl/spl_usb.c | 20 +--- include/spl.h| 14 ++ 2 files changed, 27 insertions(+), 7 deletions

Re: [PATCH] mmc: sdhci: Setup HS modes based on HISPD bit

2020-07-29 Thread Faiz Abbas
Hi, On 29/07/20 8:27 pm, Michal Simek wrote: > There is no reason to setup HS modes by default without checking bit in > capability register. > Setting up HS mode by default breaks option to disable HS mode via > sdhci-caps-mask DT property. > > Disabling HS mode can be done via DT as: > sdhci-ca

[PATCH] mmc: am654_sdhci: Use MMC_MODES_END value instead of hardcoded value

2020-07-28 Thread Faiz Abbas
The hardcoded array size leads to array overflows with changes in speed modes enum in mmc core. Use MMC_MODES_END for otap_del_sel array declaration to fix this. Signed-off-by: Faiz Abbas --- drivers/mmc/am654_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 15/18] arm: dts: k3-j7200: Add dts support

2020-07-23 Thread Faiz Abbas
ra > Signed-off-by: Vishal Mahaveer > Signed-off-by: Faiz Abbas > --- > arch/arm/dts/Makefile | 4 +- > .../k3-j7200-common-proc-board-u-boot.dtsi| 92 + > arch/arm/dts/k3-j7200-common-proc-board.dts | 94 ++ > arc

Re: [PATCH 14/18] mmc: am654_sdhci: Add support for J7200 devices

2020-07-23 Thread Faiz Abbas
Hi Lokesh, On 23/07/20 2:17 pm, Lokesh Vutla wrote: > From: Faiz Abbas > > Add support for SDHCI controllers present on the J7200 device > > Signed-off-by: Faiz Abbas > --- This patch is not required. Lets have both j721e and j7200 compatibles in the dt and use only j721e

Re: am654_sdhci: mmc fail to send stop cmd

2020-07-22 Thread Faiz Abbas
Jan, On 23/07/20 8:55 am, Faiz Abbas wrote: > Jan, > > On 21/07/20 10:52 pm, Jan Kiszka wrote: >> On 21.07.20 19:03, Faiz Abbas wrote: >>> Jan, >>> >>> On 21/07/20 12:06 pm, Jan Kiszka wrote: >>>> On 21.07.20 01:23, Jaehoon Chung wrote: &g

[PATCH] mmc: sdhci: Enable high speed conditional on the correspnding bit

2020-07-22 Thread Faiz Abbas
The capabilities register has a field to indicate whether the host supports high speed mode or not. Add high speed host_caps based on this bit instead of enabling it by default. Signed-off-by: Faiz Abbas --- drivers/mmc/sdhci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: am654_sdhci: mmc fail to send stop cmd

2020-07-22 Thread Faiz Abbas
Jan, On 21/07/20 10:52 pm, Jan Kiszka wrote: > On 21.07.20 19:03, Faiz Abbas wrote: >> Jan, >> >> On 21/07/20 12:06 pm, Jan Kiszka wrote: >>> On 21.07.20 01:23, Jaehoon Chung wrote: >>>> On 7/20/20 10:21 AM, Peng Fan wrote: >>>>> Hi Jan,

Re: am654_sdhci: mmc fail to send stop cmd

2020-07-21 Thread Faiz Abbas
Jan, On 21/07/20 12:06 pm, Jan Kiszka wrote: > On 21.07.20 01:23, Jaehoon Chung wrote: >> On 7/20/20 10:21 AM, Peng Fan wrote: >>> Hi Jan, >>> Subject: am654_sdhci: mmc fail to send stop cmd Hi all, on one device with one specific SD-card (possibly an aging one), I'm seein

Re: [PATCH] mmc: omap_hsmmc: Set 3.3V for IO voltage on all places

2020-07-05 Thread Faiz Abbas
gt; This patch fixes that problematic commit and changes 3.0V to 3.3V on all > remaining places in omap_hsmmc driver. > > Fixes: d2c05f50e12f ("mmc: omap_hsmmc: Set 3.3V for IO voltage") > Signed-off-by: Pali Rohár > --- Reviewed-by: Faiz Abbas Thanks, Faiz

[PATCH 10/13] configs: am65x_evm: Add support for DFU related configs

2020-07-02 Thread Faiz Abbas
Add offset and environment related configs used for booting from DFU. Signed-off-by: Faiz Abbas --- include/configs/am65x_evm.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h index 19d861d402..5435ef85c7

[PATCH 11/13] configs: am65x_evm_a53: Enable USB Mass storage and DFU boot modes

2020-07-02 Thread Faiz Abbas
Enable configs to facilitate booting from USB Mass Storage devices as well as USB peripheral boot Signed-off-by: Faiz Abbas --- configs/am65x_evm_a53_defconfig | 9 + include/configs/am65x_evm.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/configs/am65x_evm_a53_defconfig

[PATCH 12/13] configs: Add new config for supporting USB mass storage boot

2020-07-02 Thread Faiz Abbas
Because of space constraints, create a new USB defconfig for R5 to faciliate booting from USB mass storage devices Signed-off-by: Faiz Abbas --- configs/am65x_evm_r5_usbmsc_defconfig | 119 ++ 1 file changed, 119 insertions(+) create mode 100644 configs

[PATCH 13/13] configs: Add defconfig for USB DFU bootmode

2020-07-02 Thread Faiz Abbas
Because of space constraints, create a new USB defconfig for R5 to faciliate booting in USB peripheral (DFU) bootmode Signed-off-by: Faiz Abbas --- configs/am65x_evm_r5_usbdfu_defconfig | 119 ++ 1 file changed, 119 insertions(+) create mode 100644 configs

[PATCH 08/13] arm: dts: k3-am654-r5-base-board: Add USB0 nodes

2020-07-02 Thread Faiz Abbas
Add USB0 nodes and set them to host mode to support USB host and peripheral boot modes Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-r5-base-board.dts | 35 + 1 file changed, 35 insertions(+) diff --git a/arch/arm/dts/k3-am654-r5-base-board.dts b/arch/arm/dts/k3

[PATCH 09/13] arm: dts: k3-am654-base-board: Add support for USB0 in SPL

2020-07-02 Thread Faiz Abbas
Add nodes for USB0 in SPL to enable USB host boot mode Signed-off-by: Faiz Abbas --- arch/arm/dts/k3-am654-base-board-u-boot.dtsi | 27 1 file changed, 27 insertions(+) diff --git a/arch/arm/dts/k3-am654-base-board-u-boot.dtsi b/arch/arm/dts/k3-am654-base-board-u

[PATCH 06/13] arm: mach-k3: am6_init: Do USB fixups to facilitate host and device boot modes

2020-07-02 Thread Faiz Abbas
ed for accessing the interface at USB 2.0 speeds Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 68 +++-- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c index 42d13a39f8..b65860fe

[PATCH 07/13] arm: mach-k3: am6_init: Add support for USB boot mode

2020-07-02 Thread Faiz Abbas
Add support for identifying USB host and device boot modes Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 5 + arch/arm/mach-k3/include/mach/am6_hardware.h | 2 ++ arch/arm/mach-k3/include/mach/am6_spl.h | 3 ++- 3 files changed, 9 insertions(+), 1

[PATCH 01/13] spl: usb: Create an API spl_usb_load()

2020-07-02 Thread Faiz Abbas
Create a new API spl_usb_load() that takes the filename as a parameter instead of taking the default U-boot PAYLOAD_NAME Signed-off-by: Faiz Abbas --- common/spl/spl_usb.c | 20 +--- include/spl.h| 14 ++ 2 files changed, 27 insertions(+), 7 deletions

[PATCH 05/13] arm: mach-k3: am6_init: Gate mmc related configurations with the appropriate config

2020-07-02 Thread Faiz Abbas
Gate mmc related system related configurations with DM_MMC to avoid build errors when MMC is not enabled Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c

[PATCH 04/13] arm: mach-k3: sysfw-loader: Add support to load SYSFW from USB

2020-07-02 Thread Faiz Abbas
Add support for loading system firmware from a USB mass storage device Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/sysfw-loader.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/mach-k3/sysfw-loader.c b/arch/arm/mach-k3/sysfw-loader.c index 513be09c68..0ebd8c56a7

[PATCH 00/13] Add support for USB host and peripheral bootmodes on am65x-idk

2020-07-02 Thread Faiz Abbas
USB subsystem which is a longer term effort Faiz Abbas (13): spl: usb: Create an API spl_usb_load() spl: usb: Only init usb once armv7R: K3: am654: Use full malloc in SPL both pre and post reloc arm: mach-k3: sysfw-loader: Add support to load SYSFW from USB arm: mach-k3: am6_init: Gate mmc

[PATCH 03/13] armv7R: K3: am654: Use full malloc in SPL both pre and post reloc

2020-07-02 Thread Faiz Abbas
go ahead and enable the use of the full malloc by manually initializing the required functionality inside board_init_f by creating a full malloc pool inside the pre-relocation malloc pool. Signed-off-by: Faiz Abbas --- arch/arm/mach-k3/am6_init.c | 18 ++ 1 file changed, 18

[PATCH 02/13] spl: usb: Only init usb once

2020-07-02 Thread Faiz Abbas
usb_init() may be called multiple times for fetching multiple images from SPL. Skip reinitializing USB if its already been done Signed-off-by: Faiz Abbas --- common/spl/spl_usb.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/common/spl/spl_usb.c b/common/spl

Re: Bisected: omap_hsmmc 3.3V IO voltage incompatible with N900 (Was: Re: Bisected: mmc cause reboot loops on N900)

2020-07-02 Thread Faiz Abbas
Hi Pali, On 01/07/20 2:02 pm, Pali Rohár wrote: > On Friday 12 June 2020 15:03:06 Pali Rohár wrote: >> On Tuesday 26 May 2020 19:49:54 Pali Rohár wrote: >>> On Thursday 07 May 2020 17:19:38 Pali Rohár wrote: >>>> On Thursday 07 May 2020 19:10:14 Faiz Abbas wrote: &

Re: [PATCH 2/7] mmc: zynq_sdhci: Define timing macro's

2020-06-10 Thread Faiz Abbas
Hi Ashok, On 10/06/20 2:48 pm, Ashok Reddy Soma wrote: > Hi Faiz, > >> -Original Message----- >> From: Faiz Abbas >> Sent: Wednesday, May 27, 2020 12:28 PM >> To: Jaehoon Chung ; Michal Simek >> ; u-boot@lists.denx.de; git >> Cc: Ashok Reddy So

  1   2   3   4   5   6   >