Re: [PATCH 05/11] i2c: mediatek: add support for optional arb and pmic clock

2024-06-05 Thread Heiko Schocher
-by: Heiko Schocher bye, Heiko -- -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de

Re: [PATCH] fs: ubifs: Add support for ZSTD decompression

2024-06-03 Thread Heiko Schocher
-- 2 files changed, 53 insertions(+), 2 deletions(-) Please add in future a list of changes you have done (You did, or?) And add me at least to cc (I nearly missed this patch), see: https://docs.u-boot.org/en/latest/develop/sending_patches.html thanks! Reviewed-by: Heiko Schocher

Re: [PATCH] fs: ubifs: Add support for ZSTD decompression

2024-05-27 Thread Heiko Schocher
Hello Piotr, On 06.05.24 16:07, Heiko Schocher wrote: Hello Piotr, On 30.04.24 12:23, Piotr Wojtaszczyk wrote: Signed-off-by: Piotr Wojtaszczyk ---   fs/ubifs/ubifs-media.h |  2 ++   fs/ubifs/ubifs.c   | 55 --   2 files changed, 55 insertions

Re: [PATCH 1/6] video: Move generated bmp headers to include/generated

2024-05-17 Thread Heiko Schocher
/splash.c | 4 ++-- tools/Makefile| 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Heiko Schocher for the aristainetos2 board part. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich

Re: [PATCH 05/11] i2c: Add support for ADI SC5XX-family I2C peripheral

2024-05-16 Thread Heiko Schocher
changed, 402 insertions(+) create mode 100644 drivers/i2c/adi_i2c.c Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80

[PATCH v1] usb: remove not used variable in usb_ether_curr_dev

2024-05-15 Thread Heiko Schocher
grepping for usb_ether_curr_dev in u-boot source code shows $ grep -r usb_ether_curr_dev . ./cmd/usb.c:static int __maybe_unused usb_ether_curr_dev = -1; /* current ethernet device */ $ only declared but never used, so it can safely removed from code. Signed-off-by: Heiko Schocher --- azure

Re: [PATCH] fs: ubifs: Add support for ZSTD decompression

2024-05-06 Thread Heiko Schocher
-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de

Re: [PATCH v2 0/6] Introduce UBI block device

2024-05-06 Thread Heiko Schocher
Hello Alexey, On 06.05.24 15:58, Alexey Romanov wrote: Hello! Ping. okay from my side... I think I acked them already @Dario: IIRC the patchset is delegated to you... If it is okay, I can apply it in u-boot-ubi and send a pull request to Tom, but please, send a Acked-by or Reviewed-by and

Re: [PATCH 48/81] pci: Remove and add needed includes

2024-05-02 Thread Heiko Schocher
Hello Tom, On 02.05.24 03:31, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Stefan Roese Cc: Tom Rini Cc: Nobuhiro Iwamatsu Cc: Marek Vasut Cc: Heiko Schocher Cc: Simon Glass Cc: Mark Kettenis Cc

Re: [PATCH 33/81] gpio: Remove and add needed includes

2024-05-02 Thread Heiko Schocher
: Linus Walleij Cc: Stefan Bosch Cc: Simon Glass Cc: Philipp Tomsich Cc: Kever Yang Cc: Michael Walle Cc: Patrick Delaunay Cc: Patrice Chotard Cc: Thierry Reding Cc: Svyatoslav Ryhel Cc: Sean Anderson Cc: Andre Przywara Cc: Qu Wenruo Cc: Ilias Apalodimas Cc: Heiko Schocher Cc: Peng Fan Cc

Re: [PATCH 35/81] i2c: Remove and add needed includes

2024-05-02 Thread Heiko Schocher
Hello Tom, On 02.05.24 03:30, Tom Rini wrote: Remove from this driver directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Heiko Schocher Cc: Tom Rini Cc: Ryan Chen Cc: Aspeed BMC SW team Cc: Chia-Wei Wang Cc: Joel Stanley Cc: Michal Simek Cc

Re: [PATCH 121/149] board: socrates: Remove and add needed includes

2024-04-30 Thread Heiko Schocher
Hello Tom, On 01.05.24 04:42, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Heiko Schocher --- board/socrates/ddr.c | 1 - board/socrates/law.c | 2 +- board/socrates/nand.c | 2

Re: [PATCH 116/149] board: siemens: Remove and add needed includes

2024-04-30 Thread Heiko Schocher
Hello Tom, On 01.05.24 04:42, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Anatolij Gustschin Cc: Heiko Schocher Cc: Le Jin Cc: Jan Kiszka --- board/siemens/capricorn/board.c | 1 - board

Re: [PATCH 078/149] board: keymile: Remove and add needed includes

2024-04-30 Thread Heiko Schocher
Hello Tom, On 01.05.24 04:42, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Holger Brunck Cc: Heiko Schocher Cc: Niel Fourie Cc: Aleksandar Gerasimovski Cc: Rainer Boschung --- board/keymile

Re: [PATCH 027/149] board: bosch: Remove and add needed includes

2024-04-30 Thread Heiko Schocher
Schocher --- board/bosch/acc/acc.c| 2 +- board/bosch/guardian/board.c | 2 +- board/bosch/guardian/mux.c | 1 - board/bosch/shc/board.c | 2 +- board/bosch/shc/mux.c| 1 - 5 files changed, 3 insertions(+), 5 deletions(-) Thanks! Reviewed-by: Heiko Schocher bye

Re: [PATCH 017/149] board: aristainetos: Remove and add needed includes

2024-04-30 Thread Heiko Schocher
Hello Tom, On 01.05.24 04:41, Tom Rini wrote: Remove from this board vendor directory and when needed add missing include files directly. Signed-off-by: Tom Rini --- Cc: Heiko Schocher --- board/aristainetos/aristainetos.c | 1 - 1 file changed, 1 deletion(-) Thanks! Reviewed

Re: [PATCH] ubi: Depend on MTD

2024-04-25 Thread Heiko Schocher
Hello Tom, On 11.04.24 08:09, Michael Nazzareno Trimarchi wrote: Hi On Thu, Apr 11, 2024 at 7:06 AM John Watts wrote: UBI required MTD to build correctly, add it as a Kconfig dependency. Signed-off-by: John Watts --- While working with UBI on my SPI NAND patch series I found it was

Re: imx8mn: bootcount does not increment

2024-04-25 Thread Heiko Schocher
Hello Fabio, On 26.04.24 03:55, Fabio Estevam wrote: Hi, When enabling bootcount on the imx8mm-evk like this: --- a/configs/imx8mm_evk_defconfig +++ b/configs/imx8mm_evk_defconfig @@ -120,3 +120,5 @@ CONFIG_SDP_LOADADDR=0x4040 CONFIG_USB_GADGET_DOWNLOAD=y CONFIG_SPL_USB_SDP_SUPPORT=y

Re: [PATCH v2 0/2] i2c: Add support for Qualcomm Generic Interface (GENI) I2C controller

2024-04-25 Thread Heiko Schocher
Hello Caleb, On 25.04.24 14:44, Caleb Connolly wrote: Hi Heiko, On 25/04/2024 06:28, Heiko Schocher wrote: Hello Caleb, On 23.04.24 13:43, Caleb Connolly wrote: On Mon, 22 Apr 2024 11:33:51 +0200, Neil Armstrong wrote: Add Support for the Qualcomm Generic Interface (GENI) I2C interface

Re: [PATCH v2 0/2] i2c: Add support for Qualcomm Generic Interface (GENI) I2C controller

2024-04-24 Thread Heiko Schocher
Hello Caleb, On 23.04.24 13:43, Caleb Connolly wrote: On Mon, 22 Apr 2024 11:33:51 +0200, Neil Armstrong wrote: Add Support for the Qualcomm Generic Interface (GENI) I2C interface found on newer Qualcomm SoCs. The Generic Interface (GENI) is a firmware based Qualcomm Universal Peripherals

Re: [PATCH] ubi: Depend on MTD

2024-04-14 Thread Heiko Schocher
to solve this. --- drivers/mtd/ubi/Kconfig | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Heiko Schocher Thanks! bye, Heiko -- -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142

Re: [PATCH v2 0/6] Introduce UBI block device

2024-03-25 Thread Heiko Schocher
Hello Alexey, On 25.03.24 15:41, Alexey Romanov wrote: Hello! This series adds support for the UBI block device, which allows to read/write data block by block. For example, it can now be used for BCB or Android AB command: $ bcb load ubi 0 part_name Tested only on SPI NAND, so bind is

Re: [PATCH v1 6/6] spinand: bind UBI block

2024-03-22 Thread Heiko Schocher
Hello Alexey, On 06.03.24 14:49, Alexey Romanov wrote: UBI block is virtual block device, which is an abstraction over MTD layer. Therefore it is logical to use it in combination with MTD drivers. Signed-off-by: Alexey Romanov --- drivers/mtd/nand/spi/core.c | 9 - 1 file changed,

Re: [PATCH v1 5/6] disk: support UBI partitions

2024-03-22 Thread Heiko Schocher
-$(CONFIG_MTD_UBI_FASTMAP) += fastmap.o obj-y += misc.o obj-y += debug.o obj-$(CONFIG_BLK) += block.o +obj-y += part.o May it is good to have this as an Kconfig option? So boards which do not use UBI block will save code size... Beside of this: Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software

Re: [PATCH v1 4/6] disk: don't try search for partition type if already set

2024-03-22 Thread Heiko Schocher
-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de

Re: [PATCH v1 3/6] drivers: introduce UBI block abstraction

2024-03-22 Thread Heiko Schocher
(+) create mode 100644 drivers/mtd/ubi/block.c Reviewed-by: Heiko Schocher Acked-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80

Re: [PATCH v1 2/6] ubi: allow to write to volume with offset

2024-03-22 Thread Heiko Schocher
+++ include/ubi_uboot.h | 2 +- 3 files changed, 74 insertions(+), 9 deletions(-) Reviewed-by: Heiko Schocher Acked-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [PATCH v1 1/6] ubi: allow to read from volume with offset

2024-03-22 Thread Heiko Schocher
insertions(+), 7 deletions(-) Reviewed-by: Heiko Schocher Acked-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h

Re: [PATCH] mtd: nand: omap_gpmc: Fix NAND in SPL for AM335x

2023-11-27 Thread Heiko Schocher
793.html I can confirm, that the draco thuban board now boots again from NAND. Tested-by: Heiko Schocher Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de

Re: [PATCH 1/1] i2c: Bugfix in i2c_get_chip_by_phandle()

2023-11-26 Thread Heiko Schocher
handle()) > > Signed-off-by: Philip Oberfichtner > --- > drivers/i2c/i2c-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Indeed! Acked-by: Heiko Schocher @Tom: Do you want a pull request from me, or can you pick up this? Thanks! bye, Heiko -- DENX Software Enginee

Re: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-21 Thread Heiko Schocher
Hello Roger, On 21.11.23 22:56, Roger Quadros wrote: > Hi, > > On 15/11/2023 13:36, Heiko Schocher wrote: >> Hello Roger, >> >> On 15.11.23 12:09, Roger Quadros wrote: >>> >>> >>> On 15/11/2023 07:40, Heiko Schocher wrote: >>>> c

Re: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-15 Thread Heiko Schocher
Hello Roger, On 15.11.23 12:09, Roger Quadros wrote: > > > On 15/11/2023 07:40, Heiko Schocher wrote: >> commit 04fcd2587321 ("mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based >> correction") >> >> broke AM335x based boards booting from NAND with

Re: [PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-15 Thread Heiko Schocher
Hello Michael, On 15.11.23 11:38, Michael Nazzareno Trimarchi wrote: > Hi > > On Wed, Nov 15, 2023 at 11:37 AM Leto, Enrico wrote: >> >> Patch is working by me. >> >>> -Original Message- >>> From: Heiko Schocher >>> Sent: Wednesday,

[PATCH] mtd: rawnand: omap_gpmc: fix BCH8 HW based correction

2023-11-14 Thread Heiko Schocher
uban board. Signed-off-by: Heiko Schocher --- fix NAND boot for BCH8 based TI AM335x boards Fix is based on series from Enrico: https://lists.denx.de/pipermail/u-boot/2023-November/536793.html and fixes NAND boot for the draco thuban board. But this patch apply also without the patches from above p

[PATCH] mtd: rawnand: omap_gpmc: remove unneeded variable

2023-11-13 Thread Heiko Schocher
remove unneeded variable ecc_flag in omap_correct_data_bch Signed-off-by: Heiko Schocher --- azure build is fine with this patch: https://dev.azure.com/hs0298/hs/_build/results?buildId=110=results drivers/mtd/nand/raw/omap_gpmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 0/6] siemens,am335x: clean up the draco board family

2023-11-09 Thread Heiko Schocher
Hello Tom, On 08.11.23 17:11, Tom Rini wrote: > On Wed, Nov 08, 2023 at 03:53:16PM +0100, Enrico Leto wrote: > >> The boards were not maintained upstream since the development phase. >> >> Restore SPL and remove unused settings. We need i2c to read the DDR >> settings from EEPROM, get u-boot

Re: [PATCH v2] i2c: designware_i2c: adjust timing calculation

2023-11-02 Thread Heiko Schocher
Hello Heinrich, On 13.10.23 15:09, Heinrich Schuchardt wrote: > In SPL probing of the designware_i2c device on the StarFive VisionFive 2 > board fails with > > dw_i2c: mode 0, ic_clk 100, speed 10, > period 10 rise 1 fall 1 tlow 5 thigh 4 spk 0 > dw_i2c: bad counts. hcnt = -4

Re: [PATCH v3 1/3] bootcount: Remove legacy I2C driver

2023-11-02 Thread Heiko Schocher
Hello Philip, On 31.10.23 08:38, Philip Richard Oberfichtner wrote: > The legacy I2C bootcounter will hereby be removed and eventually > be replaced by a driver model implementation in the follow-up commit. > > The legacy driver has the following drawbacks: > - It's not adhering to the

Please pull u-boot-i2c

2023-11-02 Thread Heiko Schocher
Hello Tom, please pull from u-boot-i2c: The following changes since commit d9650a48234058c645d1a07951c3d2cf129427e6: Merge branch '2023-10-28-assorted-platform-updates' (2023-10-28 09:23:27 -0400) are available in the Git repository at:

Re: [PATCH v3 2/3] i2c: Implement i2c_get_chip_by_phandle()

2023-11-02 Thread Heiko Schocher
Hello Philip, On 31.10.23 08:38, Philip Richard Oberfichtner wrote: > This new function enhances the i2c_get_chip*() toolbox by implementing a > variant that does not require a chip_addr. Instead, the desired device > is pointed to by a phandle. > > Signed-off-by: Philip Richard Oberfichtner >

Re: [PATCH v3 3/3] bootcount: Add driver model I2C driver

2023-11-02 Thread Heiko Schocher
Hello Philip, On 31.10.23 08:38, Philip Richard Oberfichtner wrote: > This adds a generic I2C bootcounter adhering to driver model to replace > the previously removed legacy implementation. > > There is no change in functionality, it can be used on any I2C device. > The device tree configuration

Re: [PATCH v2] i2c: nuvoton: remove standard mode only

2023-11-02 Thread Heiko Schocher
Hello Jim Liu, On 04.10.23 03:35, Jim Liu wrote: > first version is only support standard mode. > remove this judgment to support standard/fast/fast plus mode. > > Signed-off-by: Jim Liu > > Changes for v2: >- add commit message > --- > drivers/i2c/npcm_i2c.c | 5 - > 1 file changed,

Re: [PATCH v3 3/3] bootcount: Add driver model I2C driver

2023-10-31 Thread Heiko Schocher
Kconfig| 10 +++ > drivers/bootcount/Makefile | 1 + > drivers/bootcount/bootcount_dm_i2c.c | 102 +++ > 3 files changed, 113 insertions(+) > create mode 100644 drivers/bootcount/bootcount_dm_i2c.c Reviewed-by: Heiko Schocher bye, Heiko -- D

Re: [PATCH v3 2/3] i2c: Implement i2c_get_chip_by_phandle()

2023-10-31 Thread Heiko Schocher
rd Oberfichtner > --- > > Notes: > Changes in v3: none > Changes in v2: new > > drivers/i2c/i2c-uclass.c | 75 > include/i2c.h| 12 +++ > 2 files changed, 87 insertions(+) Reviewed-by: Heiko Schocher bye

Re: [PATCH v3 1/3] bootcount: Remove legacy I2C driver

2023-10-31 Thread Heiko Schocher
hanges in v2: none > > drivers/bootcount/Kconfig | 24 +++-- > drivers/bootcount/Makefile| 1 - > drivers/bootcount/bootcount_i2c.c | 43 --- > 3 files changed, 3 insertions(+), 65 deletions(-) > delete mode 100644 drivers/

Re: [PATCH v2 3/3] bootcount: Add driver model I2C driver

2023-10-29 Thread Heiko Schocher
Hello Philip, On 26.10.23 05:44, Heiko Schocher wrote: > Hello Philip, > > On 20.10.23 11:02, Philip Richard Oberfichtner wrote: >> This adds a generic I2C bootcounter adhering to driver model to replace >> the previously removed legacy implementation. >> >> Th

Re: [PATCH v2 3/3] bootcount: Add driver model I2C driver

2023-10-25 Thread Heiko Schocher
vers/bootcount/bootcount_dm_i2c.c | 103 +++ > 3 files changed, 114 insertions(+) > create mode 100644 drivers/bootcount/bootcount_dm_i2c.c Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Off

Re: [PATCH v2 2/3] i2c: Implement i2c_get_chip_by_phandle()

2023-10-25 Thread Heiko Schocher
rd Oberfichtner > --- > > Changes in v2: new > > drivers/i2c/i2c-uclass.c | 75 > include/i2c.h| 12 +++ > 2 files changed, 87 insertions(+) Looks good to me, thanks! Reviewed-by: Heiko Schocher bye, Heik

Re: [PATCH v2 1/3] bootcount: Remove legacy I2C driver

2023-10-25 Thread Heiko Schocher
t; drivers/bootcount/Kconfig | 24 +++-- > drivers/bootcount/Makefile| 1 - > drivers/bootcount/bootcount_i2c.c | 43 --- > 3 files changed, 3 insertions(+), 65 deletions(-) > delete mode 100644 drivers/bootcount/bootcount_i2c.c Reviewed-by: Heiko Sc

Re: [PATCH v2] i2c: nuvoton: remove standard mode only

2023-10-25 Thread Heiko Schocher
- > 1 file changed, 5 deletions(-) Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-19 Thread Heiko Schocher
Hello Philip, On 18.10.23 18:10, Simon Glass wrote: > Hi Philip, > > On Wed, 18 Oct 2023 at 05:00, Philip Oberfichtner <mailto:p...@denx.de>> wrote: >> >> Hi Heiko, >> >> On Wed, Oct 18, 2023 at 06:31:57AM +0200, Heiko Schocher wrot

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-17 Thread Heiko Schocher
Hello Simon, On 18.10.23 05:33, Simon Glass wrote: > Hi Philip, > > On Tue, 17 Oct 2023 at 06:57, Philip Oberfichtner wrote: >> >> Hi Simon, >> >> maybe you can give me a hint on how to implement this cleanly in driver >> model? >> >> To sum it up, I'd like to have a phandle pointing to *any*

Re: [PATCH v2] i2c: designware_i2c: adjust timing calculation

2023-10-13 Thread Heiko Schocher
ptive comment for the constant > --- > drivers/i2c/designware_i2c.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) Many thanks for this update! Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich,

Re: [PATCH 1/2] bootcount: Remove legacy I2C driver

2023-10-13 Thread Heiko Schocher
Hello Phillip, On 13.10.23 13:35, Philip Oberfichtner wrote: > Hi Heiko, > > Thank you for reviewing. > > On Fri, Oct 13, 2023 at 01:21:41PM +0200, Heiko Schocher wrote: >> [...] >> >> Hmm.. I find some boards in mainline which still use this driver:

Re: [PATCH 2/2] bootcount: Add driver model I2C driver

2023-10-13 Thread Heiko Schocher
de 100644 > index 00..227641f77e > --- /dev/null > +++ b/drivers/bootcount/bootcount_dm_i2c.c > @@ -0,0 +1,126 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * (C) Copyright 2023 > + * Philip Richard Oberfichtner > + * > + * Based on previous work from Heiko Schoche

Re: [PATCH 1/2] bootcount: Remove legacy I2C driver

2023-10-13 Thread Heiko Schocher
Hello Philip, On 13.10.23 11:43, Philip Richard Oberfichtner wrote: > The legacy I2C bootcounter will hereby be removed and eventually > be replaced by a driver model implementation in the follow-up commit. > > The legacy driver has the following drawbacks: > - It's not adhering to the

Re: [PATCH 1/1] i2c: designware_i2c: adjust timing calculation

2023-10-13 Thread Heiko Schocher
Hello Heinrich, On 13.10.23 10:32, Heinrich Schuchardt wrote: > On 10/13/23 06:37, Heiko Schocher wrote: >> Hello Heinrich, >> >> On 11.10.23 06:48, Heinrich Schuchardt wrote: >>> In SPL probing of the designware_i2c device on the StarFive VisionFive 2 >>&g

Re: [PATCH 1/1] i2c: designware_i2c: adjust timing calculation

2023-10-12 Thread Heiko Schocher
Hello Heinrich, On 11.10.23 06:48, Heinrich Schuchardt wrote: > In SPL probing of the designware_i2c device on the StarFive VisionFive 2 > board fails with > > dw_i2c: mode 0, ic_clk 100, speed 10, > period 10 rise 1 fall 1 tlow 5 thigh 4 spk 0 > dw_i2c: bad counts. hcnt = -4

Re: [PATCH v1] i2c: nuvoton: add support fast mode

2023-10-02 Thread Heiko Schocher
Hello Jim, On 26.09.23 11:08, Jim Liu wrote: > Signed-off-by: Jim Liu > --- > drivers/i2c/npcm_i2c.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/i2c/npcm_i2c.c b/drivers/i2c/npcm_i2c.c > index ea4ef53256..b867b6c8e9 100644 > --- a/drivers/i2c/npcm_i2c.c > +++

Re: [RFC PATCH 0/4] mtd: ubi: Enable accessing RO filesystems in UBI vols

2023-09-21 Thread Heiko Schocher
Hello Sam, sorry for the late reply... On 07.09.23 23:46, Sam Edwards wrote: > Hi Heiko and Simon, > > Thought I'd follow-up to keep this discussion going. The main thing I would > like to decide first (as > it lets me start relying on it in boot scripts) would be the UBI access > syntax: >

Re: [PATCH] drivers: mediatek: Fix error handling in mtk_i2c_do_transfer

2023-09-14 Thread Heiko Schocher
; > Signed-off-by: Francois Berder > --- > drivers/i2c/mtk_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Good catch! Reviewed-by: Heiko Schocher @Tom: Can this go into the release so late? If so, I can make a pull request... bye, Heiko -- DENX Software Engineering G

Please pull u-boot-ubi

2023-08-15 Thread Heiko Schocher
Hello Tom, please pull from u-boot-ubi.git master The following changes since commit 832148f675e427060be074c276956962fa9b5cb6: Merge tag 'u-boot-rockchip-20230814' of https://source.denx.de/u-boot/custodians/u-boot-rockchip (2023-08-14 09:11:09 -0400) are available in the Git repository at:

Re: [PATCH] cmd: ubi: Fix 'ubi list' command arguments parsing

2023-08-15 Thread Heiko Schocher
Hello Dmitry, On 12.07.23 14:58, Dmitry Dunaev wrote: > This fixes allowed argc variable value for arguments parsing > > Fixes: 6de1daf64b1 ("cmd: ubi: Add 'ubi list' command") > Signed-off-by: Dmitry Dunaev > --- > cmd/ubi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to

Please pull u-boot-i2c

2023-08-15 Thread Heiko Schocher
Hello Tom, please pull from u-boot-i2c: The following changes since commit 832148f675e427060be074c276956962fa9b5cb6: Merge tag 'u-boot-rockchip-20230814' of https://source.denx.de/u-boot/custodians/u-boot-rockchip (2023-08-14 09:11:09 -0400) are available in the Git repository at:

Re: [RFC PATCH 0/4] mtd: ubi: Enable accessing RO filesystems in UBI vols

2023-08-14 Thread Heiko Schocher
Hello Sam, many thnkas for your patchset! On 12.08.23 02:06, Sam Edwards wrote: > Hi UBI maintainers, > > My target's rootfs is a read-only filesystem stored in a static UBI volume, > mounted via a "ubiblock" device after boot. I'd also like to keep the boot > files in the same filesystem, so

Re: [PATCH 07/29] i2c: mediatek: fix I2C usability for MT7981

2023-08-09 Thread Heiko Schocher
t; --- > drivers/i2c/mtk_i2c.c | 45 +-- > 1 file changed, 43 insertions(+), 2 deletions(-) Thanks! Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D

Re: [PATCH] i2c: mvtwsi: reset controller if stuck in "bus error" state

2023-08-07 Thread Heiko Schocher
upset it, and (in principle) results in no > externally-observable change in behavior. > > Signed-off-by: Sam Edwards > --- > drivers/i2c/mvtwsi.c | 42 ++ > 1 file changed, 42 insertions(+) Reviewed-by: Heiko Schocher bye, Heiko -- D

Re: [PATCH v2 1/2] i2c: i2c-gpio: Correctly handle new {sda,scl}-gpios bindings

2023-08-06 Thread Heiko Schocher
.1184147-1-judge.pack...@gmail.com/ > > (no changes since v1) > > drivers/i2c/i2c-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Offic

Re: [PATCH v2] ARM: imx: romapi: Fix signed integer bitwise ops misuse

2023-07-02 Thread Heiko Schocher
Hello Marek, On 02.07.23 03:03, Marek Vasut wrote: > Bitwise operations on signed integers are not defined, > replace them with per-call checks. > > Reviewed-by: Peng Fan > Signed-off-by: Marek Vasut > --- > Cc: "NXP i.MX U-Boot Team" > Cc: Fabio Estevam &g

Re: [PATCH] CI: Azure: Split keymile jobs out

2023-06-26 Thread Heiko Schocher
PowerPC one (and while at this, the ls102 job). > > Signed-off-by: Tom Rini > --- > Cc: Aleksandar Gerasimovski > Cc: Heiko Schocher > Cc: Holger Brunck > Cc: Niel Fourie > Cc: Rainer Boschung > --- > .azure-pipelines.yml | 6 -- > 1 file changed, 4 insertions(+)

Re: [PATCH 1/2] imx: hab: Fix a couple of build warnings with DEBUG enabled

2023-06-19 Thread Heiko Schocher
Team" > Cc: Fabio Estevam > Cc: Heiko Schocher > Cc: Heinrich Schuchardt > Cc: Rasmus Villemoes > Cc: Simon Glass > Cc: Stefano Babic > Cc: Tom Rini > Cc: Ye Li > --- > arch/arm/mach-imx/hab.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

Re: [PATCH] spl: spl_legacy: Add extra address checks

2023-06-19 Thread Heiko Schocher
Hello Marek, On 20.06.23 00:41, Marek Vasut wrote: > Check whether the loaded image or entry point does not overlap SPL. > > Signed-off-by: Marek Vasut > --- > Cc: "NXP i.MX U-Boot Team" > Cc: Fabio Estevam > Cc: Heiko Schocher > Cc: Heinrich Schuchardt &

Re: [RFC PATCH] i2c: mvtwsi: reinitialize controller to clear bus errors

2023-06-12 Thread Heiko Schocher
Hello Sam, On 12.06.23 22:16, Sam Edwards wrote: > Hey there Heiko, > > On 6/12/23 06:35, Heiko Schocher wrote: >> I have not the deep knowledge of this specific i2c driver, but may >> also an option is to set >> >> int (*deblock)(struct udevice *bus); &

Re: [RFC PATCH] i2c: mvtwsi: reinitialize controller to clear bus errors

2023-06-12 Thread Heiko Schocher
Hello Sam, On 10.06.23 08:15, Sam Edwards wrote: > Hi I²C maintainers, > > My target has the following devices sharing one bus: > - 24C02 EEPROM > - Realtek 8370 Ethernet switch > - Allwinner T113-s3 (running U-Boot, interfacing via MVTWSI) > > The RTL8370 is configured in "EEPROM autoload"

Re: [PATCHv2] ubifs: allow loading to above 4GiB

2023-06-06 Thread Heiko Schocher
Hello Ben, On 06.06.23 10:23, Ben Dooks wrote: > The ubifsload command is truncating any address above 4GiB as it casts > this address to an u32, instead of using an unsigned long which most of > the other load commands do. Change this to an unsigned long to allow > loading into high memory for

Re: [PATCH] ubifs: allow loading to above 4GiB

2023-06-06 Thread Heiko Schocher
Hello Ben, On 06.06.23 12:30, Ben Dooks wrote: > On 05/06/2023 08:45, Heiko Schocher wrote: >> Hello Ben, >> >> On 10.05.23 15:41, Ben Dooks wrote: >>> The ubifsload command is truncating any address above 4GiB as it casts >>> this address to an u32, inste

Re: Please pull u-boot-i2c

2023-06-05 Thread Heiko Schocher
Hello Tom, On 05.06.23 21:58, Tom Rini wrote: > On Mon, Jun 05, 2023 at 09:39:43AM +0200, Heiko Schocher wrote: > >> Hello Tom, >> >> please pull rom u-boot-i2c.git master >> >> The following changes since commit 26659d426548d1c395ef878c3b820e53a6e3b346

Re: [PATCH] ubifs: allow loading to above 4GiB

2023-06-05 Thread Heiko Schocher
Hello Ben, On 10.05.23 15:41, Ben Dooks wrote: > The ubifsload command is truncating any address above 4GiB as it casts > this address to an u32, instead of using an unsigned long which most of > the other load commands do. Change this to an unsigned long to allow > loading into high memory for

Please pull u-boot-i2c

2023-06-05 Thread Heiko Schocher
Hello Tom, please pull rom u-boot-i2c.git master The following changes since commit 26659d426548d1c395ef878c3b820e53a6e3b346: Merge tag 'efi-2023-07-rc4' of https://source.denx.de/u-boot/custodians/u-boot-efi (2023-06-02 12:13:01 -0400) are available in the Git repository at:

Re: [PATCH] I2C: cdns: Fix broken retry mechanism on arbitration lost.

2023-06-05 Thread Heiko Schocher
Hello Andrea, On 26.05.23 16:56, Andrea Merello wrote: > In the current implementation, in case of I2C arbitration lost, a retry is > attempted; the message counter and pointer are reset to the original values > and the I2C xfer process is restart from the beginning. > > However the message

Re: [PATCH] i2c: rockchip: De-initialize the bus after start bit failure

2023-06-05 Thread Heiko Schocher
initialization. > > Signed-off-by: Ondrej Jirman > Cc: Heiko Schocher > --- > drivers/i2c/rk_i2c.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Applied to u-boot-i2c.git master Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erik

Re: [PATCH 06/40] gpio: Avoid using an invalid ofnode

2023-06-01 Thread Heiko Schocher
is > enabled. > > Signed-off-by: Simon Glass > Fixes: 5fc7cf8c8e2 ("gpio: add gpio-hog support") > --- > > drivers/gpio/gpio-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks! Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software Engineering

Re: [PATCH] i2c: rockchip: De-initialize the bus after start bit failure

2023-05-29 Thread Heiko Schocher
initialization. > > Signed-off-by: Ondrej Jirman > Cc: Heiko Schocher > --- > drivers/i2c/rk_i2c.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Heiko Schocher @kever: Patch is delegated to you on patchwork, for me it is fine, if you pick it up. If you

Re: [PATCH] env: Remove misuse of env is nowhere driver

2023-05-01 Thread Heiko Schocher
Hello Stefan, On 29.04.23 06:30, Heiko Schocher wrote: > Hello Stefan, > > On 28.04.23 15:45, Stefan Herbrechtsmeier wrote: >> From: Stefan Herbrechtsmeier >> >> When using a list of writeable variables, the initial values come from >> the built-in default envi

Re: [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space

2023-05-01 Thread Heiko Schocher
Hello Pali, On 29.04.23 13:10, Pali Rohár wrote: > On Thursday 13 April 2023 22:41:43 Pali Rohár wrote: >> This patch series contains small fixes for mpc85xx old PCI Local Bus driver. >> >> Heiko: Are you able to test these changes? Has your Socrates board >> available old PCI Local Bus support?

Re: [PATCH] env: Remove misuse of env is nowhere driver

2023-04-28 Thread Heiko Schocher
Hello Stefan, On 28.04.23 15:45, Stefan Herbrechtsmeier wrote: > From: Stefan Herbrechtsmeier > > When using a list of writeable variables, the initial values come from > the built-in default environment since commit 5ab81058364b > ("env: Complete generic support for writable list"). Remove

Re: [PATCH u-boot 3/3] pci: auto: Remove PCI_CLASS_PROCESSOR_POWERPC autoconfig case

2023-04-20 Thread Heiko Schocher
e and handle PCI_CLASS_PROCESSOR_POWERPC via default code path. > > Signed-off-by: Pali Rohár > --- > drivers/pci/pci_auto.c | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Heiko Schocher Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Er

Re: [PATCH u-boot 2/3] pci: fsl: Do not access PCI BAR0 register of PCIe Root Port

2023-04-20 Thread Heiko Schocher
-by: Pali Rohár > --- > drivers/pci/pcie_fsl.c | 14 ++ > 1 file changed, 14 insertions(+) Reviewed-by: Heiko Schocher Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Re: [PATCH u-boot 1/3] pci: mpc85xx: Do not access PCI BARs registers of BDF address 00:00.0

2023-04-20 Thread Heiko Schocher
d-off-by: Pali Rohár > --- > drivers/pci/pci_mpc85xx.c | 12 > 1 file changed, 12 insertions(+) Reviewed-by: Heiko Schocher Tested-by: Heiko Schocher Tested on the socrates board, it fixes the problem: PCI: Failed autoconfig bar 18 PCI: Failed autoconfig bar 20 Tha

Re: [PATCH u-boot 0/3] pci: Do not access Freescale PCI controllers BARs registers

2023-04-20 Thread Heiko Schocher
Hello Pali, On 20.04.23 21:44, Pali Rohár wrote: > Freescale PCI and PCIe controllers export in config space in BARs offset > for BDF address 00:00.0 internal controller registers, instead of BAR > registers. Avoid access to these registers to prevent overwriting them. > > Fixes

Re: [PATCH u-boot 3/3] pci: mpc85xx: Do not try to access extended PCIe registers

2023-04-16 Thread Heiko Schocher
access extended PCIe registers as it cannot work. > > Signed-off-by: Pali Rohár > --- > drivers/pci/pci_mpc85xx.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) Thanks! Reviewed-by: Heiko Schocher Tested-by: Heiko Schocher bye, Heiko -- DENX Software E

Re: [PATCH u-boot 2/3] pci: mpc85xx: Allow 8/16-bit access to PCI config space

2023-04-16 Thread Heiko Schocher
CI config space > caused to clear adjacent bits of 32-bit PCI register. > > Signed-off-by: Pali Rohár > --- > drivers/pci/pci_mpc85xx.c | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) Thanks! Reviewed-by: Heiko Schocher Tested-by: Heiko Schoch

Re: [PATCH u-boot 1/3] pci: mpc85xx: Add missing sync() after writing to PCI config space

2023-04-16 Thread Heiko Schocher
Hello Pali, On 13.04.23 22:41, Pali Rohár wrote: > On PowerPC we should use barrier after store operation to HW register. > > Signed-off-by: Pali Rohár > --- > drivers/pci/pci_mpc85xx.c | 1 + > 1 file changed, 1 insertion(+) Good catch, thanks! Reviewed-by: Heiko Schocher

Re: [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space

2023-04-16 Thread Heiko Schocher
Hello Pali, On 13.04.23 22:41, Pali Rohár wrote: > This patch series contains small fixes for mpc85xx old PCI Local Bus driver. > > Heiko: Are you able to test these changes? Has your Socrates board > available old PCI Local Bus support? > > Pali Rohár (3): > pci: mpc85xx: Add missing sync()

Re: [PATCH u-boot 0/3] pci: mpc85xx: Fixes for PCI config space

2023-04-13 Thread Heiko Schocher
Hello Pali, On 13.04.23 22:41, Pali Rohár wrote: > This patch series contains small fixes for mpc85xx old PCI Local Bus driver. > > Heiko: Are you able to test these changes? Has your Socrates board > available old PCI Local Bus support? > > Pali Rohár (3): > pci: mpc85xx: Add missing sync()

Please pull u-boot-i2c

2023-04-11 Thread Heiko Schocher
Hello Tom, please pull from u-boot-i2c: The following changes since commit 11c25c6df0b56ee7eee2c4ddc7f075880daeb8c7: Merge https://source.denx.de/u-boot/custodians/u-boot-mmc (2023-04-10 08:32:11 -0400) are available in the Git repository at:

Re: [PATCH 6/6] m68k: upgrading all boards to dm i2c

2023-04-11 Thread Heiko Schocher
Hello Angelo, On 05.04.23 00:59, Angelo Dureghello wrote: > Upgrading all board configs where i2c is involved to DM i2c. > > Signed-off-by: Angelo Dureghello > --- > configs/M5208EVBE_defconfig | 5 + > configs/M5235EVB_Flash32_defconfig| 1 + > configs/M5235EVB_defconfig

Re: [PATCH 5/6] m68k: dts: add i2c nodes

2023-04-11 Thread Heiko Schocher
Hello Angelo, On 05.04.23 00:59, Angelo Dureghello wrote: > Add all the i2c nodes for each family, and add specific i2c > overwrites in the related board-specific dts. > > Signed-off-by: Angelo Dureghello > --- > arch/m68k/dts/M5208EVBE.dts | 6 +++ > arch/m68k/dts/M5253DEMO.dts

Re: [PATCH 4/6] i2c: fsl_i2c: fix m68k transferts

2023-04-11 Thread Heiko Schocher
Hello Angelo, On 05.04.23 00:59, Angelo Dureghello wrote: > This driver is actually used for powerpc and m68k/ColdFire. > > On ColdFire SoC's, interrupt flag get not set if IIEN flag (mbcr bit6, > interrupt enabled) is not set appropriately before each transfert. > As a result, the transfert

Re: [PATCH 3/6] m68k: mcf5441x: fix CONFIG_SYS_FSL_I2C definition

2023-04-11 Thread Heiko Schocher
Hello Angelo, On 05.04.23 00:59, Angelo Dureghello wrote: > Fix CONFIG_SYS_FSL_I2C to correct name CONFIG_SYS_I2C_FSL. > > Signed-off-by: Angelo Dureghello > --- > arch/m68k/cpu/mcf5445x/speed.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Applied to u-boot-i2c.git master

  1   2   3   4   5   6   7   8   9   10   >