Re: [PATCH 1/1] board: fix compatible property Milk-V Mars CM

2024-07-21 Thread Heinrich Schuchardt
On 7/21/24 23:27, E Shattow wrote: P.S. my suggestion below On Fri, Jul 19, 2024 at 5:06 PM E Shattow wrote: On Fri, Jul 19, 2024 at 4:12 PM Heinrich Schuchardt wrote: For the Milk-V Mars CM (lite) we have only been copying sizeof(void *) bytes to the compatible property instead

[PATCH v2 1/1] mmc: consider cd-gpios in Synopsys DesignWare driver

2024-07-21 Thread Heinrich Schuchardt
The JH7110 SoC uses a GPIO for card detect. * In the of_to_plat function check if a cd-gpios definition exists and request the GPIO. * In the getcd function return the GPIO value in this case. Reported-by: Conor Dooley Signed-off-by: Heinrich Schuchardt --- v2: Check that DM_GPIO

[PATCH 1/1] board: fix compatible property Milk-V Mars CM

2024-07-19 Thread Heinrich Schuchardt
For the Milk-V Mars CM (lite) we have only been copying sizeof(void *) bytes to the compatible property instead of the whole string list. Fixes: de3229599d4f ("board: add support for Milk-V Mars CM") Reported-by: E Shattow Signed-off-by: Heinrich Schuchardt --- board/starfive/visionf

[PATCH 1/1] doc: define html_context in conf.py

2024-07-19 Thread Heinrich Schuchardt
The dictionary html_context is not passed into conf.py but must be created there. See https://dev.readthedocs.io/en/latest/design/theme-context.html#customizing-the-context Fixes: df86796028df ("doc: enable ReadTheDocs addon management") Signed-off-by: Heinrich Schuchardt --- doc/c

Pull request efi-2024-10-rc1-3

2024-07-19 Thread Heinrich Schuchardt
ing distro device-path for media devices * Fix typo in EFI_RT_VOLATILE_STORE description Other: * MAINTAINERS: Rename BOOTDEVICE ---- Heinrich Schuchardt (3): efi_loader: find distro device-path for media devices doc: move o

Re: [PATCH v2 10/21] upl: Add support for reading a upl handoff

2024-07-18 Thread Heinrich Schuchardt
On 13.07.24 09:00, Simon Glass wrote: Universal Payload provides a standard way of handing off control between two firmware phases. Add support for reading the handoff information into a structure. Signed-off-by: Simon Glass --- (no changes since v1) MAINTAINERS | 7 +

[PATCH 1/1] efi_loader: require EFI boot manager for EBBR compliance

2024-07-18 Thread Heinrich Schuchardt
A system has to support booting via the boot manager to be EBBR compliant. See the reference to variables Boot in the specification. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader

Re: [PATCH v2 00/21] Universal Payload initial series

2024-07-18 Thread Heinrich Schuchardt
On 16.07.24 21:08, Tom Rini wrote: On Sat, Jul 13, 2024 at 09:40:17PM +0200, Heinrich Schuchardt wrote: Am 13. Juli 2024 10:12:50 MESZ schrieb Mark Kettenis : From: Simon Glass Date: Sat, 13 Jul 2024 08:00:34 +0100 Universal Payload (UPL) is an Industry Standard for firmware components[1

[PATCH] cmd: move CMD_DHCP6 options beneath CMD_DHCP6

2024-07-17 Thread Heinrich Schuchardt
All Kconfig options that depend on CONFIG_CMD_DHCP6 should immediately follow it. Signed-off-by: Heinrich Schuchardt --- cmd/Kconfig | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index 0cf0d8ad8ab..323e473cd64

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-07-16 Thread Heinrich Schuchardt
On 7/16/24 22:01, Tom Rini wrote: On Tue, Jul 16, 2024 at 09:35:18PM +0200, Heinrich Schuchardt wrote: On 7/16/24 21:13, Tom Rini wrote: On Thu, Jun 20, 2024 at 04:35:39PM -0500, Nishanth Menon wrote: Hi Team, We have briefly discussed this topic on IRC[1]. I would like to propose a new boot

Re: Request for hosting a boot-firmware repository in u-boot git (denx and GitHub)

2024-07-16 Thread Heinrich Schuchardt
On 7/16/24 21:13, Tom Rini wrote: On Thu, Jun 20, 2024 at 04:35:39PM -0500, Nishanth Menon wrote: Hi Team, We have briefly discussed this topic on IRC[1]. I would like to propose a new boot-firmware repository similar to the Linux-firmware repository under the aegis of u-boot hosting. In

[PATCH 1/1] doc: enable ReadTheDocs addon management

2024-07-16 Thread Heinrich Schuchardt
/addons-by-default/ Signed-off-by: Heinrich Schuchardt --- doc/conf.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/conf.py b/doc/conf.py index c9138a5a5d4..e79134cc3d7 100644 --- a/doc/conf.py +++ b/doc/conf.py @@ -21,6 +21,12 @@ from subprocess import check_output # Get Sphinx

[PATCH v2 1/1] boot: provide CONFIG_BOOTMETH_QFW Kconfig parameter

2024-07-16 Thread Heinrich Schuchardt
CONFIG_BOOTMETH_QFW to decide if the QFW boot method shall be provided. Signed-off-by: Heinrich Schuchardt --- v2: default y on all architectures --- boot/Kconfig | 9 + boot/Makefile | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/boot/Kconfig b/boot/Kconfig index

Re: [PATCH 1/1] boot: provide CONFIG_BOOTMETH_QFW Kconfig parameter

2024-07-16 Thread Heinrich Schuchardt
On 7/16/24 09:04, Simon Glass wrote: Hi Heinrich, On Tue, 16 Jul 2024 at 03:40, Heinrich Schuchardt wrote: U-Boot is often used conjunction with QEMU to boot via EFI or syslinux. Here the QFW boot method is not needed. At least for qemu-riscv64_smode_defconfig the kernel parameter is used

Re: [PATCH] doc: fit: add ELF image to list of image formats

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 21:33, Maxim Moskalets wrote: Signed-off-by: Maxim Moskalets Please, always provide a commit message. Otherwise looks good to me. This series suggested to eliminate source_file_format.rst: https://patchwork.ozlabs.org/project/uboot/list/?series=414308 Best regards Heinrich

[PATCH 1/1] boot: provide CONFIG_BOOTMETH_QFW Kconfig parameter

2024-07-15 Thread Heinrich Schuchardt
CONFIG_BOOTMETH_QFW to decide if the QFW boot method shall be provided. Disable the QFW boot method for all architectures but the sandbox by default. Signed-off-by: Heinrich Schuchardt --- boot/Kconfig | 9 + boot/Makefile | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 08/13] bootstd: Tidy up comments on the boothmeth drivers

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 12:13, Simon Glass wrote: Fix a typo in the comment and add one to the EFI driver too. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- boot/bootmeth_efi.c | 1 + boot/bootmeth_extlinux.c | 2 +- boot/bootmeth_script.c | 2 +- 3 files changed, 3

Re: [PATCH 11/13] doc: Add a link to VBE from the bootstd docs

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 12:13, Simon Glass wrote: Link to this page to make it easier to find the VBE docs. Signed-off-by: Simon Glass --- doc/develop/bootstd/overview.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/develop/bootstd/overview.rst

Re: [PATCH 12/13] boot: Correct indentation in efi bootmeth

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 12:13, Simon Glass wrote: Fix a minor indentation / whitespace problem in a comment. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- boot/bootmeth_efi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/bootmeth_efi.c b/boot

Re: [PATCH 06/13] doc: Add a description for bootmeth_cros

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 12:13, Simon Glass wrote: Add documentation for the cros bootmeth. %s/bootmeth/boot method/ throughout the patch. Signed-off-by: Simon Glass --- doc/develop/bootstd/cros.rst | 33 doc/develop/bootstd/index.rst| 1 +

Re: [PATCH 05/13] doc: Add a description for bootmeth_qfw

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 12:13, Simon Glass wrote: Add documentation for the qfw bootmeth. %s/bootmeth/boot method/ Fix up the compatible string to drop the 'extlinux' part, which is not relevant to this bootmeth. Signed-off-by: Simon Glass --- boot/bootmeth_qfw.c | 2 +-

Re: [PATCH 04/13] doc: Add a description for bootmeth_pxe

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 12:13, Simon Glass wrote: Add documentation for the pxe bootmeth. Signed-off-by: Simon Glass --- doc/develop/bootstd/index.rst| 1 + doc/develop/bootstd/overview.rst | 2 +- doc/develop/bootstd/pxelinux.rst | 27 +++ 3 files changed, 29

Re: [PATCH 03/13] doc: Add a description for bootmeth_extlinux

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 12:13, Simon Glass wrote: Add documentation for the extlinux bootmeth. Signed-off-by: Simon Glass --- doc/develop/bootstd/extlinux.rst | 27 +++ doc/develop/bootstd/index.rst| 1 + doc/develop/bootstd/overview.rst | 2 +- 3 files changed, 29

Re: [PATCH 02/13] doc: Move bootstd into its own directory

2024-07-15 Thread Heinrich Schuchardt
On 7/15/24 12:13, Simon Glass wrote: Before adding more files, move the bootstd docs into a new directory, with an index. Signed-off-by: Simon Glass --- MAINTAINERS | 2 +- doc/board/starfive/milk-v_mars_cm.rst | 2 +-

[PATCH 1/1] drivers/mtd/nvmxip: nvmxip.h is a global include

2024-07-15 Thread Heinrich Schuchardt
include/nvmxip.h is a global and not a local include. So we should use angle brackets. Fixes: dc3abd8006c5 ("nvmxip: move header to include") Signed-off-by: Heinrich Schuchardt --- drivers/mtd/nvmxip/nvmxip-uclass.c | 2 +- drivers/mtd/nvmxip/nvmxip.c| 2 +- drivers/

Re: [PATCH 1/2] riscv: spacemit: bananapi_f3: initial support added

2024-07-14 Thread Heinrich Schuchardt
On 7/14/24 17:08, Kongyang Liu wrote: Add basic support for SpacemiT's Banana Pi F3 board Signed-off-by: Kongyang Liu --- arch/riscv/Kconfig | 5 + arch/riscv/cpu/k1/Kconfig | 18 ++ arch/riscv/cpu/k1/Makefile | 6 +

Re: [PATCH 2/2] doc: spacemit: bananapi_f3: document Banana Pi F3 board

2024-07-14 Thread Heinrich Schuchardt
On 7/14/24 17:08, Kongyang Liu wrote: Add document for Banana Pi F3 board which based on SpacemiT's K1 SoC. Signed-off-by: Kongyang Liu --- doc/board/index.rst| 1 + doc/board/spacemit/bananapi_f3.rst | 78 ++ doc/board/spacemit/index.rst

Pull request efi-2024-10-rc1-2

2024-07-14 Thread Heinrich Schuchardt
Heinrich Schuchardt (5): efi_loader: print device-tree in dtbdump.efi rtc: fix the description of the Goldfish RTC driver doc: fix heading level of itest examples env: ENV_IS_IN_EXT4 should enable

[PATCH 1/1] doc: move out-of-tree building info to HTML

2024-07-14 Thread Heinrich Schuchardt
Move the information about out-of-tree building from README to the generated HTML documentation. Signed-off-by: Heinrich Schuchardt --- README| 20 doc/build/gcc.rst | 28 2 files changed, 28 insertions(+), 20 deletions(-) diff

Re: [PATCH] part: efi: Rely on a definition to specify the primary GPT position

2024-07-14 Thread Heinrich Schuchardt
-series/blob/8cc5ee7df1358092f77f43aa0c9661883473e5af/patches-aosp/glodroid/kernel/common-android14-6.1-lts/0001-GLODROID-Allow-placing-primary-GPT-to-2MiB-offset-to.patch пн, 10 черв. 2024 р. о 15:22 Heinrich Schuchardt пише: On 19.05.24 17:35, Roman Stratiienko wrote: Use

Re: [PATCH v2 00/21] Universal Payload initial series

2024-07-13 Thread Heinrich Schuchardt
Am 13. Juli 2024 10:12:50 MESZ schrieb Mark Kettenis : >> From: Simon Glass >> Date: Sat, 13 Jul 2024 08:00:34 +0100 >> >> Universal Payload (UPL) is an Industry Standard for firmware >> components[1]. > >I think you have some trouble understanding the concept of industry >standard ;). I

[PATCH 1/1] efi_loader: find distro device-path for media devices

2024-07-13 Thread Heinrich Schuchardt
Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 2 +- lib/efi_loader/efi_bootmgr.c | 2 +- lib/efi_loader/efi_fdt.c | 33 +++-- 3 files changed, 21 insertions(+), 16 deletions(-) diff --git a/include/efi_loader.h b/include/efi_loader.h index 6

Re: [PATCH] fat: fat2rtc: Sanitize timestamps

2024-07-12 Thread Heinrich Schuchardt
On 12.07.24 11:51, Richard Weinberger wrote: Am Freitag, 12. Juli 2024, 11:46:08 CEST schrieb 'Heinrich Schuchardt' via upstream: Am 12. Juli 2024 10:24:54 MESZ schrieb Richard Weinberger : Make sure that tm_mday and tm_mon are within the expected range. Upper layers such as rtc_calc_weekday

Re: [PATCH 1/2] ext4: Fix integer overflow in ext4fs_read_symlink()

2024-07-12 Thread Heinrich Schuchardt
On 12.07.24 13:14, Richard Weinberger wrote: Am Freitag, 12. Juli 2024, 13:10:12 CEST schrieb 'Heinrich Schuchardt' via upstream: On 02.07.24 21:42, Richard Weinberger wrote: While zalloc() takes a size_t type, adding 1 to the le32 variable will overflow. A carefully crafted ext4 filesystem

Re: [PATCH 2/2] ext4: Fix zalloc()

2024-07-12 Thread Heinrich Schuchardt
On 02.07.24 21:42, Richard Weinberger wrote: The zalloc() function suffers from two problems. 1. If memalign() fails it will return NULL and memset() will use a NULL pointer. 2. memalign() itself seems to crash when more than 2^32 bytes are requested. So, check the return value of memalign()

Re: [PATCH 1/2] ext4: Fix integer overflow in ext4fs_read_symlink()

2024-07-12 Thread Heinrich Schuchardt
On 02.07.24 21:42, Richard Weinberger wrote: While zalloc() takes a size_t type, adding 1 to the le32 variable will overflow. A carefully crafted ext4 filesystem can exhibit an inode size of 0x and as consequence zalloc() will do a zero allocation. Later in the function the inode size

Re: [PATCH] fat: fat2rtc: Sanitize timestamps

2024-07-12 Thread Heinrich Schuchardt
Am 12. Juli 2024 10:24:54 MESZ schrieb Richard Weinberger : >Make sure that tm_mday and tm_mon are within the expected >range. Upper layers such as rtc_calc_weekday() will use >them as lookup keys for arrays and this can cause out of >bounds memory accesses. rtc_calc_weekday() might receive

Re: [RFC v3 1/2] doc: Remove FIT documentation that is elsewhere

2024-07-08 Thread Heinrich Schuchardt
On 08.07.24 17:39, Sam Povilus wrote: FIT documentation is now a separate project, instead of having a duplicate, we should point at the other project. Signed-off-by: Sam Povilus --- doc/usage/fit/index.rst | 5 +- doc/usage/fit/source_file_format.rst | 682

Re: [RFC v3 2/2] doc: add missing table of content links

2024-07-08 Thread Heinrich Schuchardt
On 08.07.24 18:04, Heinrich Schuchardt wrote: On 08.07.24 17:39, Sam Povilus wrote: add missing table of content links, make alphabetical Signed-off-by: Sam Povilus ---   doc/usage/fit/index.rst | 21 ++---   1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/doc

Re: [RFC v3 2/2] doc: add missing table of content links

2024-07-08 Thread Heinrich Schuchardt
On 08.07.24 17:39, Sam Povilus wrote: add missing table of content links, make alphabetical Signed-off-by: Sam Povilus --- doc/usage/fit/index.rst | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/doc/usage/fit/index.rst b/doc/usage/fit/index.rst

Re: [PATCH v4 02/10] lib: uuid: add UUID v5 support

2024-07-05 Thread Heinrich Schuchardt
On 7/2/24 15:30, Caleb Connolly wrote: Add support for generating version 5 UUIDs, these are determistic and work by hashing a "namespace" UUID together with some unique data. One intended usecase is to allow for dynamically generate payload UUIDs for UEFI capsule updates, so that supported

Re: [PATCH v2 0/7] Add Starfive JH7110 Cadence USB driver

2024-07-04 Thread Heinrich Schuchardt
On 7/4/24 07:50, Minda Chen wrote: Add Starfive JH7110 Cadence USB driver and related PHY driver. So the codes can be used in visionfive2 and star64 7110 board. The driver is almost the same with kernel driver. Test with Star64 JH7110 board USB 3.0 + USB 2.0 host. The code can work. - Star64

Re: [RFC 1/1] doc: Remove FIT documentation that is elsewhere

2024-07-01 Thread Heinrich Schuchardt
Am 1. Juli 2024 21:52:12 MESZ schrieb Sam Povilus : > > >On 6/18/2024 12:03 AM, Heinrich Schuchardt wrote: >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >&

[PATCH 1/1] doc: fix heading level of itest examples

2024-07-01 Thread Heinrich Schuchardt
The Examples section should be on the second heading level. Signed-off-by: Heinrich Schuchardt --- doc/usage/cmd/itest.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/usage/cmd/itest.rst b/doc/usage/cmd/itest.rst index 9c307fb4bf4..adcad05b2d4 100644 --- a/doc/usage

[PATCH 1/1] rtc: fix the description of the Goldfish RTC driver

2024-07-01 Thread Heinrich Schuchardt
Replace the incorrect description that was copied from another driver. Signed-off-by: Heinrich Schuchardt --- drivers/rtc/goldfish_rtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/goldfish_rtc.c b/drivers/rtc/goldfish_rtc.c index 3231eb0daf8..e63a2766c76

[NEXT] Pull request efi-2024-10-rc1

2024-06-30 Thread Heinrich Schuchardt
wu command Alexander Dahl (1): doc: develop: Add a general section on gdb usage Bastian Germann (1): doc: fit: Make data-size a conditionally mandatory property Heinrich Schuchardt (4): doc: update requirements.txt spl: correct link to FIT specification efi_selftest:

Re: [PATCH] doc: add bootelf command documentation

2024-06-30 Thread Heinrich Schuchardt
On 6/30/24 12:37, Maxim Moskalets wrote: Signed-off-by: Maxim Moskalets --- doc/usage/cmd/bootelf.rst | 52 +++ 1 file changed, 52 insertions(+) create mode 100644 doc/usage/cmd/bootelf.rst diff --git a/doc/usage/cmd/bootelf.rst

Re: [PATCH] efi_loader: adjust config options for capsule updates

2024-06-30 Thread Heinrich Schuchardt
On 6/22/24 18:38, Ilias Apalodimas wrote: On Sat, 22 Jun 2024 at 19:36, Heinrich Schuchardt wrote: On 20.06.24 22:15, Ilias Apalodimas wrote: EFI_IGNORE_OSINDICATIONS is used to ignore OsIndications if setvariable at runtime is not supported and allow the platform to perform capsule updates

[PATCH v2 1/1] efi_loader: print device-tree in dtbdump.efi

2024-06-29 Thread Heinrich Schuchardt
The dtbdump.efi binary can be used for testing the EFI_DT_FIXUP_PROTOCOL. It provides a command to load a file and have it fixed up and a command to save the resulting file. Add a command 'dump' for displaying the device-tree. Signed-off-by: Heinrich Schuchardt --- v2: print leading

[PATCH 1/1] efi_loader: print device-tree in dtbdump.efi

2024-06-28 Thread Heinrich Schuchardt
The dtbdump.efi binary can be used for testing the EFI_DT_FIXUP_PROTOCOL. It provides a command to load a file and have it fixed up and a command to save the resulting file. Add a command 'dump' for displaying the device-tree. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/dtbdump.c

Re: [PATCH next] doc: develop: Add a general section on gdb usage

2024-06-27 Thread Heinrich Schuchardt
On 6/26/24 12:47, Alexander Dahl wrote: Mashed up from different sources linked below, including the now gone Wiki and doc/README.arm-relocation file. Tested on a custom board with AT91 SAMA5D2 SoC and Segger J-Link Base adapter. This is only generic advice here, the usage is not board

Re: [PATCH] bootstd: cros: store partition type in an efi_guid_t

2024-06-27 Thread Heinrich Schuchardt
Am 27. Juni 2024 19:06:29 MESZ schrieb "Vincent Stehlé" : >The scan_part() function uses a struct uuid to store the little-endian >partition type GUID, but this structure should be used only to contain a >big-endian UUID. Use an efi_guid_t instead. > >Signed-off-by: Vincent Stehlé >Cc: Simon

Re: [PATCH 14/14] smbios: Correct error handling when writing tables

2024-06-23 Thread Heinrich Schuchardt
Am 23. Juni 2024 22:30:33 MESZ schrieb Simon Glass : >Since write_smbios_table() returns an address, we cannot use it to >return and error number. Also, failing on sysinfo_detect() breaks IS_ERR_VALUE() could serve as template for conveying errors in addresses. >existing boards, e.g.

[U-BOOT-TEST][PATCH 1/1] travis-ci: SiFive Unleashed: avoid format warning

2024-06-23 Thread Heinrich Schuchardt
QEMU expects the file format to be specified even for raw files. Currently this change only suppresses a warning. Signed-off-by: Heinrich Schuchardt --- bin/travis-ci/conf.sifive_unleashed_sdcard_qemu | 2 +- bin/travis-ci/conf.sifive_unleashed_spi-nor_qemu | 2 +- 2 files changed, 2

Re: [PATCH 2/7] efi_loader: fix the return values on efi_tcg

2024-06-22 Thread Heinrich Schuchardt
>> >> The authors of the specification only foresaw one or more of the >> parameters being incorrect (EFI_INVALID_PARAMETER). > >I completely agree that the result is misleading. However, I'd prefer >sticking to the spec for now and maybe add a comment?

Pull request doc-2024-07-rc5-2

2024-06-22 Thread Heinrich Schuchardt
Alexander Dahl (2): doc: develop: testing: Fix broken reference to pytest suite help doc: develop: testing: Fix reference to test writing section Heinrich Schuchardt (3): cmd: link to doc/usage/fit/x86-fit-boot.rst doc: FIT links in develop/uefi/uefi.rst boot

Re: [PATCH] efi_loader: adjust config options for capsule updates

2024-06-22 Thread Heinrich Schuchardt
-off-by: Ilias Apalodimas So this v2: v2: allow EFI_IGNORE_OSINDICATIONS if EFI_RT_VOLATILE_STORE=y Reviewed-by: Heinrich Schuchardt --- lib/efi_loader/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index ee71f417147a

Re: [PATCH 7/7] tpm: allow the user to select the compiled algorithms

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: Simon reports that after enabling all algorithms on the TPM some boards fail since they don't have enough storage to accommodate the ~5KB growth. The choice of hash algorithms are determined by the platform and the TPM configuration. Failing to cap a

Re: [PATCH 1/7] tpm: fix the return code, if the eventlog buffer is full

2024-06-22 Thread Heinrich Schuchardt
since we are always checking a buffer and not a device. Fixes: commit 97707f12fdab ("tpm: Support boot measurements") Signed-off-by: Ilias Apalodimas Reviewed-by: Heinrich Schuchardt --- lib/tpm-v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tpm-v2.c

Re: [PATCH 3/7] efi_loader: remove duplicate TCG algo definitions

2024-06-22 Thread Heinrich Schuchardt
introduced different constant names (TPM2_ALG_*). Otherwise Reviewed-by: Heinrich Schuchardt Signed-off-by: Ilias Apalodimas --- include/efi_tcg2.h | 8 1 file changed, 8 deletions(-) diff --git a/include/efi_tcg2.h b/include/efi_tcg2.h index a75b5a35b6e7..54490969b2d1 100644 ---

Re: [PATCH 2/7] efi_loader: fix the return values on efi_tcg

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: A while back we moved the core functions of the EFI TCG protocol to the TPM APIs in order for them to be used with bootm, booti etc. Some prototypes changed from returning efi_status_t to int, which is more appropriate for the non-EFI APIs. However,

Re: [PATCH 5/7] efi_loader: remove unneeded header files

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: efi_tcg2.h already includes tpm-v2.h. Remove it Signed-off-by: Ilias Apalodimas Reviewed by: Heinrich Schuchardt --- lib/efi_loader/efi_tcg2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/efi_loader/efi_tcg2.c b/lib/efi_loader

Re: [PATCH 4/7] tpm: Move TCG into a separate library

2024-06-22 Thread Heinrich Schuchardt
On 22.06.24 16:35, Ilias Apalodimas wrote: commit 97707f12fdab ("tpm: Support boot measurements") moved out code from the EFI subsystem into the TPM one to support measurements when booting with !EFI. Those were moved directly into the TPM subsystem and in the tpm-v2.c library. In hindsight, it

Re: [PATCH 1/1] efi_selftest: can't have measured device-tree with kaslr-seed

2024-06-22 Thread Heinrich Schuchardt
On 18.06.24 17:54, Ilias Apalodimas wrote: On Tue, 18 Jun 2024 at 15:24, Heinrich Schuchardt wrote: Test that we don't have a /chosen/kaslr-seed property if we measure the device-tree. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_fdt.c | 7 +++ 1 file changed

Re: [PATCH v5] cmd: bootm: add ELF file support

2024-06-21 Thread Heinrich Schuchardt
On 6/21/24 16:16, Максим Москалец wrote: пт, 21 июн. 2024 г. в 15:51, Heinrich Schuchardt : On 21.06.24 13:42, Maxim Moskalets wrote: Some operating systems (e.g. seL4) and embedded applications are ELF images. It is convenient to use FIT-images to implement trusted boot. Added "elf&q

Re: [PATCH v3 0/7] efi: CapsuleUpdate: support for dynamic UUIDs

2024-06-21 Thread Heinrich Schuchardt
On 21.06.24 13:25, Ilias Apalodimas wrote: On Fri, 21 Jun 2024 at 14:01, Ilias Apalodimas wrote: Hi Vincent, [...] $ uuid -d 935FE837-FAC8-4394-C008-737D8852C60D encode: STR: 935fe837-fac8-4394-c008-737d8852c60d SIV: 195894493536133784175416063449172723213

Re: [PATCH v5] cmd: bootm: add ELF file support

2024-06-21 Thread Heinrich Schuchardt
On 21.06.24 13:42, Maxim Moskalets wrote: Some operating systems (e.g. seL4) and embedded applications are ELF images. It is convenient to use FIT-images to implement trusted boot. Added "elf" image type for booting using bootm command. Signed-off-by: Maxim Moskalets I guess a test could be

Re: [PATCH v3 0/7] efi: CapsuleUpdate: support for dynamic UUIDs

2024-06-21 Thread Heinrich Schuchardt
On 21.06.24 11:12, Vincent Stehlé wrote: On Wed, Jun 19, 2024 at 10:15:32PM +0300, Ilias Apalodimas wrote: Allô Vincent, Hi Ilias :) Thanks for testing! On Wed, 19 Jun 2024 at 17:02, Vincent Stehlé wrote: On Fri, May 31, 2024 at 03:50:34PM +0200, Caleb Connolly wrote: As more boards

Re: [PATCH v4 9/9] doc: convert README.LED to .rst documentation

2024-06-20 Thread Heinrich Schuchardt
On 6/20/24 06:37, Christian Marangi wrote: On Thu, Jun 20, 2024 at 08:13:34AM +0200, Heinrich Schuchardt wrote: On 6/20/24 01:03, Christian Marangi wrote: Convert README.LED to .rst documentation and include all the relevant documentation in the status_led.h. Signed-off-by: Christian Marangi

Re: [PATCH] efi_loader: adjust config options for capsule updates

2024-06-20 Thread Heinrich Schuchardt
On 18.06.24 17:49, Ilias Apalodimas wrote: EFI_IGNORE_OSINDICATIONS is used to ignore OsIndications if setvariable at runtime is not supported and allow the platform to perform capsule updates on disk. With the recent changes boards can conditionally enable setvariable at runtime using

Re: [PATCH 3/5] buildman: Support building within a Python venv

2024-06-20 Thread Heinrich Schuchardt
On 20.06.24 15:19, Simon Glass wrote: The Python virtualenv tool sets up a few things in the envronment, Nits %s/envronment/environment/ putting its path first in the PATH environment variable and setting up a sys.prefix different from the sys.base_prefix value. At present buildman puts

Re: [PATCH v4 0/9] misc: introduce STATUS LED activity function

2024-06-20 Thread Heinrich Schuchardt
On 6/20/24 01:03, Christian Marangi wrote: This series expand the STATUS LED framework with a new color and a big new feature. One thing that many device need is a way to communicate to the user that the device is actually doing something. This is especially useful for recovery steps where an

Re: [PATCH v4 9/9] doc: convert README.LED to .rst documentation

2024-06-20 Thread Heinrich Schuchardt
On 6/20/24 01:03, Christian Marangi wrote: Convert README.LED to .rst documentation and include all the relevant documentation in the status_led.h. Signed-off-by: Christian Marangi --- doc/README.LED | 77 -- doc/api/index.rst | 1 + doc/api/status_led.rst | 35

[PATCH 1/1] riscv: semihosting: correct alignment

2024-06-19 Thread Heinrich Schuchardt
] RISC-V Semihosting, Version 0.4, 12th June 2024 https://github.com/riscv-non-isa/riscv-semihosting Fixes: 7400d34ba992 ("riscv: semihosting: replace inline assembly with assembly file") Signed-off-by: Heinrich Schuchardt --- arch/riscv/lib/semihosting.S | 2 +- 1 file changed, 1 ins

Re: [PATCH 1/3] cmd: avoid duplicate weak flush_dcache_all()

2024-06-19 Thread Heinrich Schuchardt
On 19.06.24 15:19, Ilias Apalodimas wrote: On Wed, 19 Jun 2024 at 16:05, Ilias Apalodimas wrote: On Wed, 19 Jun 2024 at 15:36, Heinrich Schuchardt wrote: On 19.06.24 14:23, Ilias Apalodimas wrote: On Sun, 16 Jun 2024 at 20:31, Heinrich Schuchardt wrote: If we have multiple weak

Re: [PATCH 2/3] arm: implement invalidate_icache_all on ARM11

2024-06-19 Thread Heinrich Schuchardt
On 19.06.24 14:22, Ilias Apalodimas wrote: Hi Heinrich, On Sun, 16 Jun 2024 at 20:31, Heinrich Schuchardt wrote: In EFI sub-system we rely on invalidate_icache_all() to invalidate the instruction cache after loading binaries. Add the missing implementation on ARM1136, ARM1176. Signed-off

Re: [PATCH 1/3] cmd: avoid duplicate weak flush_dcache_all()

2024-06-19 Thread Heinrich Schuchardt
On 19.06.24 14:23, Ilias Apalodimas wrote: On Sun, 16 Jun 2024 at 20:31, Heinrich Schuchardt wrote: If we have multiple weak implementations of functions, the linker might choose any of these. ARM and RISC-V already provide a weak implementation of flush_dcache_all(). Signed-off-by: Heinrich

[PATCH v4 1/1] usb: informative message if no controller

2024-06-18 Thread Heinrich Schuchardt
The message 'No working controllers found' provides no clue that this refers to USB controllers. Provide a message that refers to USB. Signed-off-by: Heinrich Schuchardt Reviewed-by: Dragan Simic Reviewed-by: Caleb Connolly Reviewed-by: Marek Vasut Reviewed-by: Mattijs Korpershoek --- v4

Re: [PATCH] cmd: make 'booti -h' not crash the board

2024-06-18 Thread Heinrich Schuchardt
Am 18. Juni 2024 16:51:56 MESZ schrieb Caleb Connolly : >Check the result of hextoul() when parsing the first argument to booti, >and add specific handling for "-h" to print usage rather than causing a >null pointer exception. > >Fixes: 5db28905c952 ("cmd: Split 'bootz' and 'booti' out from

Re: [PATCH v6 4/4] test: cmd: fdt: fix chosen test for DM_RNG

2024-06-18 Thread Heinrich Schuchardt
Am 18. Juni 2024 18:45:53 MESZ schrieb Tim Harvey : >On Tue, Jun 18, 2024 at 8:48 AM Tim Harvey wrote: >> >> On Tue, Jun 18, 2024 at 4:51 AM Heinrich Schuchardt >> wrote: >> > >> > On 17.06.24 21:14, Tim Harvey wrote: >> > > Now that k

Re: [PATCH v3] doc: describe UEFI measured boot

2024-06-18 Thread Heinrich Schuchardt
On 18.06.24 17:23, Ilias Apalodimas wrote: We currently only describe the process to enable measured boot using bootm. Describe the UEFI requirements as well which predate bootm. Signed-off-by: Ilias Apalodimas Please, rebase on 00cac7456125 ("doc: describe UEFI measured boot") Best regards

Re: [PATCH 1/1] spl: correct link to FIT specification

2024-06-18 Thread Heinrich Schuchardt
On 18.06.24 13:54, Marek Vasut wrote: On 6/18/24 8:32 AM, Heinrich Schuchardt wrote: Replace the invalid link to the FIT file format specification. Signed-off-by: Heinrich Schuchardt --- SPL is tightly size constrained. Shouldn't we remove the message with the link which is only of interest

[PATCH 1/1] cmd: correct kaslrseed description

2024-06-18 Thread Heinrich Schuchardt
The number of random bytes generated is hard coded as 8. The command takes no argument. Signed-off-by: Heinrich Schuchardt --- cmd/kaslrseed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/kaslrseed.c b/cmd/kaslrseed.c index e0d3c7fe748..e9b0e3d5985 100644 --- a/cmd

[PATCH 1/1] efi_selftest: can't have measured device-tree with kaslr-seed

2024-06-18 Thread Heinrich Schuchardt
Test that we don't have a /chosen/kaslr-seed property if we measure the device-tree. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_fdt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/efi_selftest/efi_selftest_fdt.c b/lib/efi_selftest/efi_selftest_fdt.c

Re: [PATCH v6 4/4] test: cmd: fdt: fix chosen test for DM_RNG

2024-06-18 Thread Heinrich Schuchardt
: Heinrich Schuchardt Cc: Hugo Villeneuve Cc: Marek Vasut Cc: Tom Rini Cc: Chris Morgan --- v6: new patch --- test/cmd/fdt.c | 4 1 file changed, 4 insertions(+) diff --git a/test/cmd/fdt.c b/test/cmd/fdt.c index 547085521758..537d8a338bbf 100644 --- a/test/cmd/fdt.c +++ b/test/cmd/fdt.c

[PATCH v3 1/1] usb: informative message if no controller

2024-06-18 Thread Heinrich Schuchardt
The message 'No working controllers found' provides no clue that this refers to USB controllers. Provide a message that refers to USB. Use log_info(). Signed-off-by: Heinrich Schuchardt --- v3: plural controllers v2: add 'found' at end of message keep printf --- drivers

[PATCH v2 1/1] usb: informative message if no controller

2024-06-18 Thread Heinrich Schuchardt
The message 'No working controllers found' provides no clue that this refers to USB controllers. Provide a message that refers to USB. Signed-off-by: Heinrich Schuchardt --- v2: add 'found' at end of message keep printf --- drivers/usb/host/usb-uclass.c | 2 +- 1 file changed

[PATCH 1/1] spl: correct link to FIT specification

2024-06-18 Thread Heinrich Schuchardt
Replace the invalid link to the FIT file format specification. Signed-off-by: Heinrich Schuchardt --- SPL is tightly size constrained. Shouldn't we remove the message with the link which is only of interest to developers. --- common/spl/spl_fit.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] boot: links to FIT documentation in Kconfig

2024-06-18 Thread Heinrich Schuchardt
Correct the links to the FIT documentation in boot/Kconfig. Signed-off-by: Heinrich Schuchardt --- boot/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index 6f3096c15a6..36bdc83b957 100644 --- a/boot/Kconfig +++ b/boot/Kconfig

[PATCH 1/1] doc: FIT links in develop/uefi/uefi.rst

2024-06-18 Thread Heinrich Schuchardt
Correct the links to the FIT documentation. Signed-off-by: Heinrich Schuchardt --- doc/develop/uefi/uefi.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/develop/uefi/uefi.rst b/doc/develop/uefi/uefi.rst index 0389b269c01..ea70dcbda86 100644 --- a/doc/develop/uefi

[PATCH 1/1] cmd: link to doc/usage/fit/x86-fit-boot.rst

2024-06-18 Thread Heinrich Schuchardt
Replace the outdated link. Signed-off-by: Heinrich Schuchardt --- cmd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/Kconfig b/cmd/Kconfig index ff0f5941ecc..9e4245a9702 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -622,7 +622,7 @@ config CMD_ZBOOT

Re: [RFC 1/1] doc: Remove FIT documentation that is elsewhere

2024-06-18 Thread Heinrich Schuchardt
On 6/17/24 22:20, Sam Povilus wrote: FIT documentation is now a separate project, instead of having a duplicate, we should point at the other project. Signed-off-by: Sam Povilus --- doc/usage/fit/index.rst | 14 +- doc/usage/fit/source_file_format.rst | 682

Re: [PATCH v4 05/14] net-lwip: add DHCP support and dhcp commmand

2024-06-17 Thread Heinrich Schuchardt
On 17.06.24 17:32, Jerome Forissier wrote: Add what it takes to enable NETDEVICES with NET_LWIP and enable DHCP as well as the dhcp command. CMD_TFTPBOOT is selected by BOOTMETH_EFI due to this code having an implicit dependency on do_tftpb(). Signed-off-by: Jerome Forissier --- Makefile

Re: [PATCH 1/1] doc: update requirements.txt

2024-06-17 Thread Heinrich Schuchardt
On 17.06.24 15:53, Simon Glass wrote: Hi Heinrich, On Sun, 16 Jun 2024 at 02:59, Heinrich Schuchardt wrote: Update all required Python packages to current release. Signed-off-by: Heinrich Schuchardt --- doc/sphinx/requirements.txt | 16 1 file changed, 8 insertions

Re: [PATCH v2 2/2] bootstd: Replace bootmethod(s) -> bootmeth(s)

2024-06-17 Thread Heinrich Schuchardt
On 17.06.24 11:00, Quentin Schulz wrote: Hi all, On 6/17/24 8:31 AM, Mattijs Korpershoek wrote: Hi Heinrich, Thank you for your review. On dim., juin 16, 2024 at 09:38, Heinrich Schuchardt wrote: On 6/4/24 17:15, Mattijs Korpershoek wrote: According to [1], we should use bootmeth when

[PATCH 1/1] usb: informative message if no controller

2024-06-17 Thread Heinrich Schuchardt
The message 'No working controllers found' provides no clue that this refers to USB controllers. Provide a message that refers to USB. Use log_info(). Signed-off-by: Heinrich Schuchardt --- drivers/usb/host/usb-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/3] efi_loader: avoid duplicate weak invalidate_icache_all()

2024-06-16 Thread Heinrich Schuchardt
-by: Heinrich Schuchardt --- lib/efi_loader/efi_image_loader.c | 13 +++-- lib/efi_loader/efi_runtime.c | 7 ++- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/lib/efi_loader/efi_image_loader.c b/lib/efi_loader/efi_image_loader.c index 60424360328..45dc5b6b244 100644

[PATCH 2/3] arm: implement invalidate_icache_all on ARM11

2024-06-16 Thread Heinrich Schuchardt
In EFI sub-system we rely on invalidate_icache_all() to invalidate the instruction cache after loading binaries. Add the missing implementation on ARM1136, ARM1176. Signed-off-by: Heinrich Schuchardt --- arch/arm/cpu/arm11/cpu.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 1/3] cmd: avoid duplicate weak flush_dcache_all()

2024-06-16 Thread Heinrich Schuchardt
If we have multiple weak implementations of functions, the linker might choose any of these. ARM and RISC-V already provide a weak implementation of flush_dcache_all(). Signed-off-by: Heinrich Schuchardt --- cmd/cache.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cmd/cache.c b/cmd

[PATCH 0/3] cmd: avoid duplicate weak functions

2024-06-16 Thread Heinrich Schuchardt
invalidate_icache_all() after loading binaries. Both the EFI sub-system and cmd/cache.c provide a weak invalidate_icache_all() function. Remove the EFI instance. For ARM11 functional implementation of invalidate_icache_all is missing. Add it. Heinrich Schuchardt (3): cmd: avoid duplicate weak flush_dcache_all

  1   2   3   4   5   6   7   8   9   10   >