Re: [PATCH v3 14/16] adc: add missing depends on ADC for controller drivers

2024-03-11 Thread Kever Yang
in menuconfig when ADC isn't selected. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/adc/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/adc/Kconfig b/drivers/adc/Kconfig index a01d73846b7..c9cdbe6942d 100644

Re: [PATCH v3 13/16] rockchip: jaguar-rk3588: enable SARADC and derivatives

2024-03-11 Thread Kever Yang
-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- configs/jaguar-rk3588_defconfig | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/configs/jaguar-rk3588_defconfig b/configs/jaguar-rk3588_defconfig index f55bfb1c82b..275d70ae008 100644 --- a/configs

Re: [PATCH v3 11/16] rockchip: adc: rockchip-saradc: add support for RK3588

2024-03-11 Thread Kever Yang
Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/adc/rockchip-saradc.c | 102 +- 1 file changed, 101 insertions(+), 1 deletion(-) diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c index b5df58fe3eb..10ded1b088f 100644

Re: [PATCH v3 12/16] power: pmic: rk8xx: fix duplicate prompt

2024-03-11 Thread Kever Yang
tin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/pmic/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig index 9b61b18e11f..562c1a3b122 100644 --- a/drivers/

Re: [PATCH v4 11/20] rockchip: rk3588: disable force_jtag by default

2024-03-11 Thread Kever Yang
with soc_con[1] than soc_con[0], and that soc_con0 would actually be located at 4 bytes before soc_con1, let's just make soc_con0 part of the soc_con array. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/grf_rk3588.h

Re: [PATCH v3 10/16] rockchip: adc: rockchip-saradc: factor out stop callback

2024-03-11 Thread Kever Yang
Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/adc/rockchip-saradc.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c index 607d10b5b70..b5df58fe3eb

Re: [PATCH v3 09/16] rockchip: adc: rockchip-saradc: factor out start_channel callback

2024-03-11 Thread Kever Yang
On 2024/3/4 19:30, Quentin Schulz wrote: From: Quentin Schulz SARADC v1 and v2 have a different way of starting a channel, therefore let's abstract this function so that it can be provided from the udevice.data pointer. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever

Re: [PATCH v3 08/16] rockchip: adc: rockchip-saradc: factor out channel_data callback

2024-03-11 Thread Kever Yang
On 2024/3/4 19:30, Quentin Schulz wrote: From: Quentin Schulz SARADC v1 and v2 have a different way of reading data, therefore let's abstract this function so that it can be provided from the udevice.data pointer. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang

Re: [PATCH v3 07/16] rockchip: adc: rockchip-saradc: use union for preparing for v2

2024-03-11 Thread Kever Yang
On 2024/3/4 19:30, Quentin Schulz wrote: From: Quentin Schulz The registers are entirely different between SARADC v1 and SARADC v2, so let's prepare to add another struct for accessing v2 registers by adding a union. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever

Re: [PATCH v3 06/16] pmic: reword help text

2024-03-11 Thread Kever Yang
On 2024/3/4 19:30, Quentin Schulz wrote: From: Quentin Schulz Reword the help text for the pmic read and pmic write commands to better match what's expected from the user. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- cmd/pmic.c | 4

Re: [PATCH v3 05/16] power: rk8xx: add support for RK806

2024-03-11 Thread Kever Yang
rom the DT node name, NLDO and PLDO will have overlapping indices. Therefore, we need a separate logic from the already-existing ldo callbacks. Let's reuse as much as possible though. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/

Re: [PATCH v3 04/16] regulator: rk8xx: add indirection level for some ldo callbacks

2024-03-11 Thread Kever Yang
for RK806. No logic change is expected. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/regulator/rk8xx.c | 48 ++--- 1 file changed, 36 insertions(+), 12 deletions(-) diff --git a/drivers/power

Re: [PATCH v3 03/16] regulator: rk8xx: fix SWITCH enable on RK809

2024-03-11 Thread Kever Yang
-by: William Wu [reworded commit log] Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/regulator/rk8xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8xx.c index

Re: [PATCH v3 02/16] regulator: rk8xx: remove unused functions

2024-03-11 Thread Kever Yang
Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- drivers/power/regulator/rk8xx.c | 31 --- include/power/rk8xx_pmic.h | 2 -- 2 files changed, 33 deletions(-) diff --git a/drivers/power/regulator/rk8xx.c b/drivers/power/regulator/rk8

Re: [PATCH v3 6/6] rockchip: Use common bss and stack addresses on RK3588

2024-03-11 Thread Kever Yang
bss, stack and malloc heap size and addresses to mitigate these limitations and allow for a larger U-Boot proper size. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3588/Kconfig| 7 +-- configs/evb-rk3588_defconfig

Re: [PATCH v3 5/6] rockchip: Use common bss and stack addresses on RK356x

2024-03-11 Thread Kever Yang
) - SPL bss (SPL_BSS_START_ADDR, SPL_BSS_MAX_SIZE) SPL can safely load U-Boot proper + FDT to [10M, 12M-128K) with this layout. Migrate to use common bss, stack and malloc heap size and addresses to remove this size limitation. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH v3 4/6] rockchip: Use common bss and stack addresses on RK3399

2024-03-11 Thread Kever Yang
Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3399/Kconfig| 7 +-- configs/eaidk-610-rk3399_defconfig | 10 -- configs/evb-rk3399_defconfig | 10 -- configs/firefly-rk3399_defconfig | 10

Re: [PATCH v3 3/6] rockchip: Use common bss and stack addresses on RK3328

2024-03-11 Thread Kever Yang
Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3328/Kconfig | 11 --- configs/evb-rk3328_defconfig | 17 - configs/nanopi-r2c-plus-rk3328_defconfig | 15 --- configs/nanopi-r2c-rk3328_defconfig

Re: [PATCH v3 2/6] rockchip: Use common bss and stack addresses on RK3308

2024-03-11 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- Kconfig | 2 +- arch/arm/mach-rockchip/rk3308/Kconfig | 7 +-- configs/evb-rk3308_defconfig | 13 - configs/roc-cc-rk3308_defconfig | 13 - configs/rock-pi-s-rk3308_defconfig

Re: [PATCH v3 1/6] rockchip: Add common default bss and stack addresses

2024-03-11 Thread Kever Yang
relocated to top of memory we should be able to use 2M+ for loading kernel, initrd, scripts etc. Very good update and also good description here, can we also add the memory usage  description  after update to rockchip.rst? Reviewed-by: Kever Yang Thanks, - Kever Signed-off-by: Jonas

Re: [PATCH v1 2/2] rockchip: rock-pi-4-rk3399: Enable booting from SPI flash

2024-03-11 Thread Kever Yang
On 2024/3/2 23:28, Jonas Karlman wrote: Hi Christopher, On 2024-03-02 15:34, Christopher Obbard wrote: Some variants of the ROCK Pi 4 series contain an SPI flash chip, which can be booted from. This patch enables support in U-Boot for building the image for the SPI flash, support for booting

Re: [PATCH v1 1/2] arm: rockchip: sync ROCK Pi 4A DTS from Linux

2024-03-11 Thread Kever Yang
A/B/C") Signed-off-by: Christopher Obbard Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3399-rock-pi-4a.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/dts/rk3399-rock-pi-4a.dts b/arch/arm/dts/rk3399-rock-pi-4a.dts index 931334aa3d6..d5df8939

Re: [PATCH 10/11] rockchip: theobroma-systems: puma: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- This should be runtime tested by someone with a puma

Re: [PATCH 11/11] rockchip: google: gru: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- This should be runtime tested by someone with a gru

Re: [PATCH 09/11] rockchip: vamrs: rock960: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/vamrs/rock960_rk3399/Makefile | 6

Re: [PATCH 08/11] rockchip: pine64: pinephone-pro: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- This should be runtime tested by someone

Re: [PATCH 07/11] rockchip: pine64: pinebook-pro: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/pinebook-pro-rk3399/Makefile | 1

Re: [PATCH 06/11] rockchip: pine64: rockpro64: Migrate to use IO-domain driver

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Switch to use the IO-domain driver to configure IO-domain based on device tree instead of a setup_iodomain() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/rockpro64_rk3399/Makefile| 7

Re: [PATCH 05/11] rockchip: io-domain: Add support for RK3399

2024-03-11 Thread Kever Yang
that have been configured. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/misc/rockchip-io-domain.c | 79 +-- 1 file changed, 75 insertions(+), 4 deletions(-) diff --git a/drivers/misc/rockchip-io-domain.c b/drivers/misc

Re: [PATCH 04/11] board: rockchip: Add a common ROCK Pi 4 target

2024-03-11 Thread Kever Yang
Hi Jonas, On 2024/2/19 17:13, Quentin Schulz wrote: Hi Jonas, On 2/17/24 19:35, Jonas Karlman wrote: Move ROCK Pi 4 specific board code from the shared evb_rk3399 target into its own board target and update related defconfigs to use the new TARGET_ROCKPI4_RK3399 option. Also move the call to

Re: [PATCH 04/11] board: rockchip: Add a common ROCK Pi 4 target

2024-03-11 Thread Kever Yang
Hi Jonas, On 2024/2/18 02:35, Jonas Karlman wrote: Move ROCK Pi 4 specific board code from the shared evb_rk3399 target into its own board target and update related defconfigs to use the new TARGET_ROCKPI4_RK3399 option. Also move the call to gpt_capsule_update_setup() from the weak function

Re: [PATCH 03/11] board: rockchip: rk3399: Remove unused board_early_init_f functions

2024-03-11 Thread Kever Yang
, and fixed/gpio regulators now have basic reference counting support so the original intent of this code is no longer valid. Remove the unneeded and unused code that used to enable usb regulators. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/firefly/roc-pc

Re: [PATCH 02/11] board: rockchip: rk3399: Add myself as reviewer to MAINTAINERS

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Add myself as a reviewer for RK3399 boards that I have and can help with review and testing of defconfig and device tree changes. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/pinebook-pro-rk3399

Re: [PATCH 02/11] board: rockchip: rk3399: Add myself as reviewer to MAINTAINERS

2024-03-11 Thread Kever Yang
On 2024/2/18 02:35, Jonas Karlman wrote: Add myself as a reviewer for RK3399 boards that I have and can help with review and testing of defconfig and device tree changes. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/pinebook-pro-rk3399

Re: [PATCH v3 11/20] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-03-11 Thread Kever Yang
Hi Quentin, On 2024/3/9 01:55, Quentin Schulz wrote: Hi Kever, On 3/8/24 11:05, Kever Yang wrote: Hi Quentin, On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz Rockchip SoCs have some jtag/sdmmc autoswitching that simply doesn't work really well.[00] The Linux kernel disables

Re: [PATCH 1/4] rockchip: Update the default USB Product ID value

2024-03-10 Thread Kever Yang
Hi Jonas, On 2024/3/8 18:42, Jonas Karlman wrote: Hi Kever, On 2024-03-08 10:22, Kever Yang wrote: Hi Jonas,     Thanks for your patch. On 2024/2/27 07:08, Jonas Karlman wrote: RK3036 is using the USB product id normally used by RK3066B, and RK3328 is using the product id normally used

Re: [PATCH v3 20/20] rockchip: ringneck_px30: update website link

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz The original link returns a custom 404, so let's point to a link that works today instead. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems

Re: [PATCH v3 19/20] rockchip: ringneck_px30: migrate README to doc/board in rST format

2024-03-08 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems/ringneck_px30/MAINTAINERS | 1 + board/theobroma-systems/ringneck_px30/README | 70 + doc/board/theobroma-systems/index.rst | 1 + doc/board/theobroma-systems/ringneck_px30.rst | 95

Re: [PATCH v3 18/20] rockchip: rk3399-puma: migrate README to doc/board in rST format

2024-03-08 Thread Kever Yang
Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems/puma_rk3399/MAINTAINERS | 1 + board/theobroma-systems/puma_rk3399/README | 90 + doc/board/theobroma-systems/index.rst | 1 + doc/board/theobroma-systems/puma_rk3399.rst | 126

Re: [PATCH v3 17/20] rockchip: puma-rk3399: MAINTAINERS: use glob for dtses

2024-03-08 Thread Kever Yang
On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz There are multiple Device Trees in U-Boot git repo for Puma, so let's make the MAINTAINERS entry match them all. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board

Re: [PATCH v3 16/20] board: rockchip: add Theobroma-Systems RK3588 Jaguar SBC

2024-03-08 Thread Kever Yang
-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/Makefile | 1 + arch/arm/dts/rk3588-jaguar-u-boot.dtsi | 33 + arch/arm/dts/rk3588-jaguar.dts | 803 + arch/arm/mach-rockchip

Re: [PATCH v3 15/20] rockchip: rk3588: bind MMC controllers in U-Boot proper pre-reloc

2024-03-08 Thread Kever Yang
56x family. Additionally, if any other env function (e.g. env_load) were to be used before relocation, this is also required as otherwise it wouldn't be able to find the MMC device(s). Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts

Re: [PATCH v3 11/20] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-03-08 Thread Kever Yang
Hi Quentin, On 2024/2/21 18:37, Quentin Schulz wrote: From: Quentin Schulz Rockchip SoCs have some jtag/sdmmc autoswitching that simply doesn't work really well.[00] The Linux kernel disables it for all SoCs[01], so U-Boot needs to do the same in order to fix issues related to SD card on

Re: [PATCH 4/4] rockchip: Migrate to use DM_USB_GADGET on RK3328

2024-03-08 Thread Kever Yang
C2 and DWC2_OTG is removed from this board. Enable RockUSB and UMS on all boards with a otg port in peripheral mode. Also with the migration to DM_USB_GADGET completed the U-Boot specific change to reorder usb nodes in the device tree can be reverted. Signed-off-by: Jonas Karlman Reviewed-by: Keve

Re: [PATCH 3/4] rockchip: board: Use a common USB Product ID for UMS

2024-03-08 Thread Kever Yang
-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/board.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c index f84ff542aea9..e9cfba756639 100644 --- a/arch/arm/mach-rockchip/board.c +++ b

Re: [PATCH 2/4] rockchip: board: Prepare for use of DM_USB_GADGET with DWC2_OTG

2024-03-08 Thread Kever Yang
for USB_GADGET prepare for next patch that adds a g_dnl_bind_fixup() function. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/board.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach

Re: [PATCH 1/4] rockchip: Update the default USB Product ID value

2024-03-08 Thread Kever Yang
Hi Jonas,     Thanks for your patch. On 2024/2/27 07:08, Jonas Karlman wrote: RK3036 is using the USB product id normally used by RK3066B, and RK3328 is using the product id normally used by RK3368. Fix this and update the default USB_GADGET_PRODUCT_NUM Kconfig option for remaining supported

Re: [PATCH 2/2] phy: rockchip-inno-usb2: Limit changes made to regs

2024-03-08 Thread Kever Yang
Hi Jonas, On 2024/2/26 06:10, Jonas Karlman wrote: The USB2PHY regs already contain working default reset values for RK3328 and RK35xx as evidenced by the fact that this driver never has changed a single value for these SoCs. I would prefer to keep it as is for now, I think these configs are

Re: [PATCH 1/2] phy: rockchip-inno-usb2: Write to correct GRF

2024-03-08 Thread Kever Yang
2 PHY for rk3568") Fixes: cdf9010f6e17 ("phy: rockchip-inno-usb2: add initial support for rk3588 PHY") Fixes: 9aa93d84038b ("phy: rockchip-inno-usb2: Add USB2 PHY for RK3328") Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- drivers/phy/rockchip

Re: [PATCH] configs: rockchip: rock5a: enable environment

2024-03-06 Thread Kever Yang
Hi Eugen, On 2024/3/5 13:40, Eugen Hristev wrote: On 3/5/24 04:10, Trevor Woerner wrote: Following the pattern of other Rockchip devices, enable the U-Boot environment to be stored in MMC. This patch specifically assumes the environment will be stored on the SDcard. Signed-off-by: Trevor

Re: [PATCH] rockchip: ringneck-px30: put STM32_RST line in input mode instead of output

2024-02-17 Thread Kever Yang
Hi Quentin, On 2024/2/9 21:18, Quentin Schulz wrote: From: Quentin Schulz The STM32_RST line is routed to the ATtiny microcontroller PA0/RESET/UPDI pin. By driving the PX30 SoC pin as GPIO output high, we prevent external UPDI to be used for flashing without first putting this pin as GPIO

Pull request: u-boot-rockchip-20240207

2024-02-07 Thread Kever Yang
by default mmc: rockchip_sdhci: Fix HS400 mode write on RK3568 rockchip: rk3568-generic: Enable eMMC HS200 mode Kever Yang (2): spl: Make SPL_STACK available for ROCKCHIP_RK3036 without spl framework configs: rockchip: rk3036: Fix CONFIG_SPL_STACK define Shantur Rathore (2

Re: [PATCH V4 3/7] rockchip: boot_mode: Allow rockchip_dnl_key_pressed() in SPL

2024-02-05 Thread Kever Yang
On 2024/1/25 06:55, Chris Morgan wrote: On Fri, Jan 19, 2024 at 05:01:38PM +0800, Kever Yang wrote: Hi Chris, On 2024/1/18 23:06, Chris Morgan wrote: On Thu, Jan 18, 2024 at 03:20:52PM +0800, Kever Yang wrote: Hi Chris, On 2024/1/2 23:46, Chris Morgan wrote: From: Chris Morgan Update

Re: [PATCH 4/4] board: rockchip: Add early ADC button detect for RGxx3

2024-02-05 Thread Kever Yang
On 2024/2/6 02:58, Chris Morgan wrote: From: Chris Morgan Add ADC button detect for early SPL stage for RGxx3 device. This is important because on at least the RG353P and RG353V a clk pin is not exposed that would allow us to take the eMMC out of the boot path. This is another version of

Re: [PATCH 3/4] configs: Remove unnecessary options from RGxx3 config

2024-02-05 Thread Kever Yang
Morgan Reviewed-by: Kever Yang Thanks, - Kever --- configs/anbernic-rgxx3-rk3566_defconfig | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/configs/anbernic-rgxx3-rk3566_defconfig b/configs/anbernic-rgxx3-rk3566_defconfig index ed6643d9d4..d52a0d48f2 100644

Re: [PATCH 2/4] board: rockchip: Add support for Powkiddy RGB10MAX3

2024-02-05 Thread Kever Yang
On 2024/2/6 02:58, Chris Morgan wrote: From: Chris Morgan Add support to the RGxx3 device for the Powkiddy RGB10MAX3. This device is extremely similar to all the other devices and can use the same bootloader with the same detection logic. Signed-off-by: Chris Morgan Reviewed-by: Kever

Re: [PATCH 1/4] arm: dts: rockchip: rk3566: Remove unnecessary clks from rgxx3

2024-02-05 Thread Kever Yang
Hi Chris, On 2024/2/6 02:58, Chris Morgan wrote: From: Chris Morgan Remove unnecessary clock frequency defines from the RGxx3 u-boot dts. Move the necessary defines to the RGxx3 main dts file. Signed-off-by: Chris Morgan First of all, the dts should follow the one in mainline kernel; and

Re: [RFC] rockchip: Reset to bootrom download mode on hang

2024-02-05 Thread Kever Yang
Hi Jonas, On 2024/2/5 20:34, Jonas Karlman wrote: Hi Quentin, On 2024-02-05 11:49, Quentin Schulz wrote: Hi Jonas, On 2/2/24 01:12, Jonas Karlman wrote: Add support to reset to bootrom download mode on hang in U-Boot SPL and proper. ROCKCHIP_HANG_TO_BROM can be used to enable this feature.

Re: [PATCH] rockchip: rk3568-generic: Enable eMMC HS200 mode

2024-02-04 Thread Kever Yang
-generic.dtb to Makefile. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- This patch depends on the following series: - rockchip: rk35xx: Sync device tree with linux v6.8-rc1 [1] - rockchip: rk35xx: Fix writing to eMMC [2] [1] https://patchwork.ozlabs.org/cover/1891669

Re: [PATCH] board: rockchip: Add Pine64 PineTab2

2024-02-04 Thread Kever Yang
Hi Jonas, On 2024/2/5 01:30, Jonas Karlman wrote: The Pine64 PineTab2 is a tablet computer based on the Rockchip RK3566 SoC. The table features 4/8 GB LPDDR4 RAM and 64/128 GB eMMC storage. Features tested on a Pine64 PineTab2 8GB v2.0: - SD-card boot - eMMC boot - SPI Flash boot - USB host

Re: [PATCH] rockchip: rk3588-evb: Enable USB support

2024-02-04 Thread Kever Yang
On 2024/2/3 19:31, Andy Yan wrote: From: Andy Yan Enable USB releated config to support boot from usb. Signed-off-by: Andy Yan Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb-rk3588_defconfig | 12 1 file changed, 12 insertions(+) diff --git a/configs/evb

Re: [PATCH v2 3/3] mmc: rockchip_sdhci: Fix HS400 mode write on RK3568

2024-02-04 Thread Kever Yang
On 2024/2/5 04:53, Jonas Karlman wrote: Testing has shown that writing to eMMC using HS400 modes on RK3568 result in an ERROR. Change the tap number for transmit clock to fix this. Also stop DLL when config_dll() is called to disable DLL. Signed-off-by: Jonas Karlman Reviewed-by: Kever

Re: [PATCH v2 2/3] rockchip: rk35xx: Enable eMMC HS200 mode by default

2024-02-04 Thread Kever Yang
y default to prefer use of HS200 mode on RK356x and RK3588. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - Imply MMC_HS200_SUPPORT and SPL_MMC_HS200_SUPPORT in arch Kconfig instead of adding to each boards defconfig - R-b tags not collected because

Re: [PATCH v2 1/3] rockchip: rk35xx: Remove use of eMMC DDR52 mode

2024-02-04 Thread Kever Yang
ock to sector 0x4000 fails with ERROR => mmc write 2000 4000 1 With the MMC_SPEED_MODE_SET Kconfig option enabled. Fix this by removing the mmc-ddr-1_8v prop from sdhci nodes in affected board u-boot.dtsi files. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, -

Re: [PATCH v3] rockchip: spl: Enable caches to speed up checksum validation

2024-02-04 Thread Kever Yang
enables caches in SPL on all Rockchip ARM64 boards, the Kconfig options SPL_SYS_ICACHE_OFF and SPL_SYS_DCACHE_OFF can be used to disable caches for a specific board or SoC if needed. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang --- Changes in v3: - Limit to ARM64 SoCs - Fix build

Re: [PATCH v5 1/6] rockchip: rk3399: simplify logic for getting SPL boot medium DT node

2024-02-04 Thread Kever Yang
Schulz Reviewed-by: Kever Yang Signed-off-by: Quentin Schulz --- arch/arm/mach-rockchip/rk3399/rk3399.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c index

Re: [PATCH] rockchip: rk3588-quartzpro64: Enable AHCI, PCI and USB

2024-01-31 Thread Kever Yang
On 2024/1/27 07:39, Jonas Karlman wrote: Enable Kconfig options to support AHCI, PCI and USB features. This help keep rk3588-quartzpro64 in sync with other RK3588 boards. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- Please note that this has not been runtime

Re: [PATCH v2 5/6] rockchip: rv1126: select SPL_OPTEE_IMAGE

2024-01-31 Thread Kever Yang
On 2024/1/24 11:26, Tim Lunn wrote: rv1126 requires OPTEE as it provides pcsi support. Mainline Linux kernel will fail to boot without this. Select SPL_OPTEE_IMAGE when building FIT image. TEE must be provided when building. Signed-off-by: Tim Lunn Reviewed-by: Kever Yang Thanks, - Kever

Re: [PATCH v2 6/6] rockchip: rv1126: Move RAM disk address

2024-01-31 Thread Kever Yang
On 2024/1/24 11:26, Tim Lunn wrote: OPTEE gets loaded into a memory region overlapping with the ram disk. Fix the ramdisk address so it doesn't overlap with the OPTEE memory region. Signed-off-by: Tim Lunn Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) include

Re: [PATCH v2 4/6] board: rockchip: Add Sonoff iHost board

2024-01-31 Thread Kever Yang
: - Rockchip RV1126 - 4GB DDR4 - 8GB eMMC - microSD slot - RMII Ethernet PHY - 1x USB 2.0 Host - 1x USB 2.0 OTG - Realtek RTL8723DS WiFi/BT - EFR32MG21 Silabs Zigbee radio - Speaker/Microphone Signed-off-by: Tim Lunn Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - Remove board

Re: [PATCH v2 3/6] rockchip: Convert rv1126 to standard boot

2024-01-31 Thread Kever Yang
.I4cf7708a1ba953b9abd81375d93af34665c7b251@changeid/ Reviewed-by: Kever Yang Thanks, - Kever --- Changes in v2: - New patch to clean up distro boot from rv1126_common.h include/configs/neural-compute-module-2.h | 6 -- include/configs/rv1126_common.h | 3 +-- 2 files changed, 1

Re: [PATCH v2 2/6] ram: rockchip: Add rv1126 ddr4 support

2024-01-31 Thread Kever Yang
On 2024/1/24 11:25, Tim Lunn wrote: Add support for ddr4 on rv1126. Timing detection files are imported from downstream Rockchip BSP u-boot. Allow selecting ddr4 ram with define CONFIG_RAM_ROCKCHIP_DDR4. Signed-off-by: Tim Lunn Reviewed-by: Kever Yang Thanks, - Kever --- (no changes

Re: [PATCH v2 1/6] arm: dts: rockchip: Sync rv1126 dts from linux 6.8-rc1

2024-01-31 Thread Kever Yang
On 2024/1/24 11:25, Tim Lunn wrote: Sync linux dts files for rv1126 boards from linux v6.8-rc1 tag. Includes the newly added dts for Sonoff iHost. Signed-off-by: Tim Lunn Reviewed-by: Kever Yang Thanks, - Kever --- (no changes since v1) arch/arm/dts/rv1126-edgeble-neu2-io.dts | 70

Re: [PATCH 2/2] board: rockchip: Add support for rk3588 based Cool Pi CM5 EVB

2024-01-31 Thread Kever Yang
-by: Kever Yang Thanks, - Kever --- .../arm/dts/rk3588-coolpi-cm5-evb-u-boot.dtsi | 30 + arch/arm/dts/rk3588-coolpi-cm5-evb.dts| 214 ++ arch/arm/dts/rk3588-coolpi-cm5.dtsi | 650 ++ board/rockchip/evb_rk3588/MAINTAINERS | 8 + configs/coolpi-cm5

Re: [PATCH 1/2] board: rockchip: Add support for rk3588s based Cool Pi 4B

2024-01-31 Thread Kever Yang
OTG x 1 - USB 3.0 Host x 1 - WIFI/BT module AIC8800 - 40 pin header The dts is from linux-6.8 rc1. Signed-off-by: Andy Yan Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/Makefile | 1 + arch/arm/dts/rk3588s-coolpi-4b-u-boot.dtsi | 30 + arch/arm/dts

Re: [PATCH 2/2] rockchip: rk3328-rock-pi-e: Enable DM_ETH_PHY and PHY_REALTEK

2024-01-31 Thread Kever Yang
ound to address 192.168.1.114 (1004 ms) Reported-by: Trevor Woerner Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-pi-e-rk3328_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/rock-pi-e-rk3328_defconfig b/configs/rock-pi-e-r

Re: [PATCH 1/2] net: designware: Reset eth phy before phy connect

2024-01-31 Thread Kever Yang
from DT when DM_MDIO is disabled. This help fix ethernet on Radxa ROCK Pi E v1.21: => mdio list ethernet@ff54: 1 - RealTek RTL8211F <--> ethernet@ff54 Reported-by: Trevor Woerner Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- dr

Re: [PATCH 3/3] rockchip: rk3588: Enable eMMC HS200 mode

2024-01-31 Thread Kever Yang
On 2024/1/27 07:26, Jonas Karlman wrote: Writing to eMMC using HS200 mode work more reliably then other modes on RK3588 boards. Enable MMC_HS200_SUPPORT Kconfig option to prefer use of HS200 mode. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs/evb

Re: [PATCH 2/3] rockchip: rk356x: Enable eMMC HS200 mode

2024-01-31 Thread Kever Yang
On 2024/1/27 07:26, Jonas Karlman wrote: Writing to eMMC using HS200 mode work more reliably then other modes on RK356x boards. Enable MMC_HS200_SUPPORT Kconfig option to prefer use of HS200 mode. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- configs

Re: [PATCH 1/3] rockchip: rk35xx: Remove use of eMMC DDR52 mode

2024-01-31 Thread Kever Yang
On 2024/1/27 07:26, Jonas Karlman wrote: Writing to eMMC using DDR52 mode does not work reliably or at all on RK356x and RK3588 boards. Fix this by removing the mmc-ddr-1_8v prop from sdhci nodes. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts

Re: [PATCH 7/7] rockchip: rk35xx: Remove unnecessary status props

2024-01-31 Thread Kever Yang
-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk356x-u-boot.dtsi| 7 --- arch/arm/dts/rk3588-turing-rk1-u-boot.dtsi | 1 - arch/arm/dts/rk3588s-u-boot.dtsi | 7 +-- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git

Re: [PATCH 6/7] rockchip: rk3588: Add default u-boot,spl-boot-order prop

2024-01-31 Thread Kever Yang
On 2024/1/27 06:14, Jonas Karlman wrote: Add a default u-boot,spl-boot-order prop to rk3588s-u-boot.dtsi and remove the prop from board u-boot.dtsi files using the default value. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588-nanopc-t6-u

Re: [PATCH 5/7] rockchip: rk3588: Sync device tree from linux v6.8-rc1

2024-01-31 Thread Kever Yang
Seems Quentin also sync rk3588 with v6.8-rc1 in his patch. Hi Quentin,     Could you update your patchset base on this patch set ? Thanks, - Kever On 2024/1/27 06:14, Jonas Karlman wrote: Sync rk3588 device tree from linux v6.8-rc1. Signed-off-by: Jonas Karlman ---

Re: [PATCH 3/7] rockchip: rk356x: Move common uart2 props to rk356x-u-boot.dtsi

2024-01-31 Thread Kever Yang
tree already provide a stdout-path = "serial2:" value. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3566-anbernic-rgxx3-u-boot.dtsi | 7 --- arch/arm/dts/rk3566-quartz64-a-u-boot.dtsi | 12 arch/arm/dts/rk3566-qu

Re: [PATCH 2/7] rockchip: rk356x: Sync device tree from linux v6.8-rc1

2024-01-31 Thread Kever Yang
On 2024/1/27 06:14, Jonas Karlman wrote: Sync rk356x device tree from linux v6.8-rc1. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3566-quartz64-a.dts | 5 +++-- arch/arm/dts/rk3566-radxa-cm3-io.dts | 1 + arch/arm/dts/rk3566

Re: [PATCH 1/7] rockchip: rk356x: Sync device tree from linux v6.7

2024-01-31 Thread Kever Yang
On 2024/1/27 06:14, Jonas Karlman wrote: Sync rk356x device tree from linux v6.7. Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3566-anbernic-rgxx3.dtsi | 42 + arch/arm/dts/rk3566-quartz64-a.dts | 2 -- arch/arm

Re: [PATCH 16/18] rockchip: include asm/io.h directly in asm/arch-rockchip/hardware.h

2024-01-31 Thread Kever Yang
/hardware.h is included already. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/hardware.h| 2 ++ arch/arm/mach-rockchip/cpu-info.c| 1 - arch/arm/mach-rockchip/px30/px30.c

Re: [PATCH 14/18] rockchip: rk3588: add constants for some register address spaces

2024-01-31 Thread Kever Yang
. Reviewed-by: Kever Yang Thanks, - Kever Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- arch/arm/include/asm/arch-rockchip/cru_rk3588.h | 2 ++ arch/arm/include/asm/arch-rockchip/ioc_rk3588.h | 6 ++ arch/arm/mach-rockchip/rk3588/rk3588.c | 4 3 files changed, 8

Re: [PATCH 12/18] rockchip: transform rockchip_capsule_update_board_setup into a weak function symbol

2024-01-31 Thread Kever Yang
Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/misc.h | 9 - arch/arm/mach-rockchip/board.c| 5 - 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/arch/arm/include/asm/arch-rockchip

Re: [PATCH 10/18] rockchip: theobroma-systems: ringneck: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- .../theobroma-systems/ringneck_px30/ringneck-px30.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/board/theobroma-systems/ringneck_px30/ringneck-px30.c b/board/theobroma-systems/ringneck_px30

Re: [PATCH 11/18] rockchip: merge misc.c into board.c

2024-01-31 Thread Kever Yang
-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/include/asm/arch-rockchip/misc.h | 5 -- arch/arm/mach-rockchip/Makefile | 1 - arch/arm/mach-rockchip/board.c| 125 +++ arch/arm/mach-rockchip/misc.c

Re: [PATCH 09/18] rockchip: theobroma-systems: puma: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/theobroma-systems/puma_rk3399/puma-rk3399.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/board/theobroma-systems/puma_rk3399/puma-rk3399.c b/board/theobroma-systems

Re: [PATCH 08/18] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/rockpro64_rk3399/rockpro64-rk3399.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/board/pine64/rockpro64_rk3399/rockpro64-rk3399.c b/board/pine64/rockpro64_rk3399/rockpro64-rk3399

Re: [PATCH 07/18] rockchip: pine64: pinephone: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
instead of reimplementing the whole misc_init_r from Rockchip (the side effect being that rockchip_setup_macaddr() is back). Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- .../pine64/pinephone-pro-rk3399/pinephone-pro-rk3399.c | 17

Re: [PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
instead of reimplementing the whole misc_init_r from Rockchip (the side effect being that rockchip_setup_macaddr() is back). Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/pine64/pinebook-pro-rk3399/pinebook-pro-rk3399.c | 18

Re: [PATCH 05/18] rockchip: google: gru: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- board/google/gru/gru.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/board/google/gru/gru.c b/board/google/gru/gru.c index fbcf845e87d..ecbf702b035 100644 --- a/board/google/gru/gru.c +++ b

Re: [PATCH 04/18] rockchip: add weak function symbol called at the beginning of misc_init_r

2024-01-31 Thread Kever Yang
: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/board.c | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/mach-rockchip/board.c b/arch/arm/mach-rockchip/board.c index 2620530e03f..d5cb59c10fa 100644

Re: [PATCH 03/18] rockchip: avoid out-of-bounds when computing cpuid

2024-01-31 Thread Kever Yang
, derive them from cpuid_length. Cc: Quentin Schulz Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/misc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-rockchip/misc.c b/arch/arm/mach-rockchip/misc.c

Re: [PATCH 02/18] rockchip: rk3588: sync rk3588s dtsi from v6.8-rc1

2024-01-31 Thread Kever Yang
[sync with v6.8-rc1] [remove spi0 to spi4 aliases from rk3588s-u-boot.dtsi] Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588s-u-boot.dtsi | 36 ++ arch/arm/dts/rk3588s.dtsi| 152 +++ 2 files

Re: [PATCH 01/18] rockchip: rk3588: use mainline pmu-grf compatible

2024-01-31 Thread Kever Yang
-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3588s-u-boot.dtsi | 2 +- arch/arm/mach-rockchip/rk3588/syscon_rk3588.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi

<    1   2   3   4   5   6   7   8   9   10   >