[U-Boot] [PATCH v3 3/3] spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*

2019-09-04 Thread Lukasz Majewski
DM_SPI{_FLASH} defined to allow compiling SPL. This patch converts #ifdef CONFIG_DM_SPI* to #if CONFIG_IS_ENABLED(DM_SPI) and provides corresponding defines in Kconfig. Signed-off-by: Lukasz Majewski Tested-by: Adam Ford #da850-evm --- Changes in v3: - Fix da850evm_nand and da850evm by enabling

[U-Boot] [PATCH v3 2/3] spi: Move DM_SPI_FLASH and SPI_FLASH_DATAFLASH to Kconfig (for ls1021aXXX)

2019-09-04 Thread Lukasz Majewski
converted drivers), but it was set in u-boot.cfg file. Signed-off-by: Lukasz Majewski --- Changes in v3: None Changes in v2: None arch/arm/Kconfig | 6 -- include/configs/ls1021aiot.h | 6 -- include/configs/ls1021aqds.h | 8 include/configs/ls1021atwr.h | 5

[U-Boot] [PATCH v3 1/3] spi: Move DM_SPI_FLASH to Kconfig (for NXP's ls1043a)

2019-09-04 Thread Lukasz Majewski
of DM_SPI_FLASH to using CONFIG_IS_ENABLED() is not working properly. Signed-off-by: Lukasz Majewski --- Changes in v3: - Provide better Kconfig flags conditionals to avoid not compiling relavant code (there is negative diff observed after applying those patches) Changes in v2: None Buildman

Re: [U-Boot] [PATCH v2 4/4] spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*

2019-09-04 Thread Lukasz Majewski
Hi Tom, > On Tue, Sep 03, 2019 at 05:56:36PM +0200, Lukasz Majewski wrote: > > Hi Tom, > > > > > On Fri, Aug 23, 2019 at 11:02:27PM +0200, Lukasz Majewski wrote: > > > > Hi Tom, > > > > > > > > > On Tue, Au

Re: [U-Boot] [PATCH] imx: Introduce CONFIG_SPL_FORCE_MMC_BOOT to force MMC boot on falcon mode

2019-09-04 Thread Lukasz Majewski
On Wed, 4 Sep 2019 11:54:40 +0200 Lukasz Majewski wrote: > Hi Stefano, Heiko, > > > On 04/09/19 10:46, Lukasz Majewski wrote: > > > Hi Heiko, > > > > > >> Hello Lukasz, > > >> > > >> added Stefano to cc as he is th

Re: [U-Boot] [PATCH v1 1/7] dm: regulator: support regulator more state

2019-09-04 Thread Lukasz Majewski
ce *dev); > + > +/** > * regulator_set_value_force: set the microvoltage value of a given > regulator > * without any min-,max condition check > * > @@ -317,6 +341,24 @@ int regulator_set_enable(struct udevice *dev, > bool enable); int regulator_set

Re: [U-Boot] [PATCH] imx: Introduce CONFIG_SPL_FORCE_MMC_BOOT to force MMC boot on falcon mode

2019-09-04 Thread Lukasz Majewski
Hi Stefano, Heiko, > On 04/09/19 10:46, Lukasz Majewski wrote: > > Hi Heiko, > > > >> Hello Lukasz, > >> > >> added Stefano to cc as he is the imx custodian. > > > > I've relied on patman ... Thanks for adding Stefano to CC. > >

Re: [U-Boot] [PATCH] env: Add CONFIG_ENV_SUPPORT

2019-09-04 Thread Lukasz Majewski
t; --- a/include/env_flags.h > +++ b/include/env_flags.h > @@ -153,7 +153,11 @@ int env_flags_validate_env_set_params(char > *name, char *const val[], int count); > * When adding a variable to the environment, initialize the flags > for that > * variable. > */ >

Re: [U-Boot] [PATCH] imx: Introduce CONFIG_SPL_FORCE_MMC_BOOT to force MMC boot on falcon mode

2019-09-04 Thread Lukasz Majewski
Hi Heiko, > Hello Lukasz, > > added Stefano to cc as he is the imx custodian. I've relied on patman ... Thanks for adding Stefano to CC. > > Am 03.09.2019 um 23:43 schrieb Lukasz Majewski: > > This change tries to fix the following problem: > > > > - The boar

[U-Boot] [PATCH] imx: Introduce CONFIG_SPL_FORCE_MMC_BOOT to force MMC boot on falcon mode

2019-09-03 Thread Lukasz Majewski
code flow. Signed-off-by: Lukasz Majewski --- This patch is a follow up of previous discussion/fix: https://patchwork.ozlabs.org/patch/796237/ Travis-CI: https://travis-ci.org/lmajewski/u-boot-dfu/builds/580272414 --- arch/arm/mach-imx/spl.c | 11 +++ common/spl/Kconfig | 7

Re: [U-Boot] [PATCH] spl: mmc: Add option to set eMMC HW boot partition

2019-09-03 Thread Lukasz Majewski
Hi Marek, > On 9/3/19 5:49 PM, Lukasz Majewski wrote: > > Hi Måns, Marek, > > > >> Marek Vasut writes: > >> > >>> On 9/3/19 4:16 PM, Lukasz Majewski wrote: > >>>> From: Mans Rullgard > >>>> > >>>&

Re: [U-Boot] [PATCH v2 4/4] spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*

2019-09-03 Thread Lukasz Majewski
Hi Tom, > On Fri, Aug 23, 2019 at 11:02:27PM +0200, Lukasz Majewski wrote: > > Hi Tom, > > > > > On Tue, Aug 13, 2019 at 03:47:31PM +0200, Lukasz Majewski wrote: > > > > This change allows more fine tuning of driver model based SPI > > >

Re: [U-Boot] [PATCH] spl: mmc: Add option to set eMMC HW boot partition

2019-09-03 Thread Lukasz Majewski
Hi Måns, Marek, > Marek Vasut writes: > > > On 9/3/19 4:16 PM, Lukasz Majewski wrote: > >> From: Mans Rullgard > >> > >> This change allows setting pre-defined eMMC boot partition for SPL > >> eMMC booting. It is necessary in the case when o

[U-Boot] [PATCH v2 09/14] DM: WDT: Convert WDT driver to use DM/DTS (including SYSRESET)

2019-09-03 Thread Lukasz Majewski
This commit enables support for CONFIG_WDT in the U-Boot proper. Moreover, the SYSRESET_WATCHDOG driver is used to support 'reset' command. As SPL is not yet ready for DM conversion, the CONFIG_HW_WATCHDOG is enabled for it. This allows the legacy SPL code to work properly. Signed-off-by: Lukasz

[U-Boot] [PATCH v2 11/14] ARM: Update display5_factory_defconfig after switch to DM/DTS and uuu utility

2019-09-03 Thread Lukasz Majewski
overy.lst Signed-off-by: Lukasz Majewski --- Changes in v2: None configs/display5_factory_defconfig | 41 ++ 1 file changed, 37 insertions(+), 4 deletions(-) diff --git a/configs/display5_factory_defconfig b/configs/display5_factory_defconfig index c46

[U-Boot] [PATCH v2 06/14] DM: eth: Switch display5 board to use DM_ETH

2019-09-03 Thread Lukasz Majewski
After this commit the display5 device would use FEC driver supporting driver model (DM_ETH). Signed-off-by: Lukasz Majewski --- Changes in v2: - Use dm_gpio* functions instead of gpio_* ones arch/arm/mach-imx/mx6/Kconfig | 1 + board/liebherr/display5/display5.c | 134

[U-Boot] [PATCH v2 03/14] DM: I2C: Switch display5 board to use DM_I2C

2019-09-03 Thread Lukasz Majewski
After this commit the display5 device would use I2C driver supporting driver model (DM_I2C). The 'i2c' and 'eeprom' commands now use DM I2C drivers and initialize on-bus devices according to device tree description. Signed-off-by: Lukasz Majewski --- Changes in v2: None arch/arm/mach-imx/mx6

[U-Boot] [PATCH v2 10/14] ARM: display5: Remove common.c file (after DM/DTS U-Boot proper conversion)

2019-09-03 Thread Lukasz Majewski
The common.c file content can be safely moved to spl.c file after performing the DM/DTS conversion for the U-Boot proper. It contains the non DM/DTS setup code, which now is only used by SPL. Signed-off-by: Lukasz Majewski --- Changes in v2: None board/liebherr/display5/Makefile | 4

[U-Boot] [PATCH v2 12/14] cosmetic: Cleanup display5_defconfig with make savedefconfig

2019-09-03 Thread Lukasz Majewski
Fix the structure of configs/display5_defconfig file by using th make savedefconfig. Signed-off-by: Lukasz Majewski --- Changes in v2: None configs/display5_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/display5_defconfig b/configs/display5_defconfig

[U-Boot] [PATCH v2 04/14] ARM: imx: defconfig: Enable 'regulator' and 'pmic' commands on display5

2019-09-03 Thread Lukasz Majewski
Signed-off-by: Lukasz Majewski --- Changes in v2: None configs/display5_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configs/display5_defconfig b/configs/display5_defconfig index 9ab055ac5587..6c80a4d46678 100644 --- a/configs/display5_defconfig +++ b/configs

[U-Boot] [PATCH v2 08/14] ARM: display5: Remove UART initialization code after DM/DTS conversion (non-console)

2019-09-03 Thread Lukasz Majewski
This UART is not used in U-Boot, so there is no need to initialize it. Signed-off-by: Lukasz Majewski --- Changes in v2: None board/liebherr/display5/common.c | 13 - board/liebherr/display5/common.h | 1 - board/liebherr/display5/display5.c | 2 -- 3 files changed, 16

[U-Boot] [PATCH v2 14/14] imx: Rewrite display5 get_board_id() function to use dm_gpio_* API

2019-09-03 Thread Lukasz Majewski
The get_board_id() function was using the old gpio_* compatibility layer to read HW and SW ID numbers encoded on the PCB board. After this change the new dm_gpio* API is used for this purpose. Signed-off-by: Lukasz Majewski --- Changes in v2: None board/liebherr/display5/display5.c | 53

[U-Boot] [PATCH v2 13/14] imx: Convert emergency pad of display5 to use dm_gpio* functions

2019-09-03 Thread Lukasz Majewski
After this change the display5's emergency gpio use dm_gpio* functions instead of legacy ones (gpio*) to read its state. Signed-off-by: Lukasz Majewski --- Changes in v2: None board/liebherr/display5/display5.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[U-Boot] [PATCH v2 07/14] DM: SPI: Convert display5 to use SPI with DM/DTS (but no in SPL)

2019-09-03 Thread Lukasz Majewski
The DM/DTS support for SPI is disabled on purpose for SPL, as it is not supported as of time of this conversion. Signed-off-by: Lukasz Majewski --- Changes in v2: - Use dm_gpio_* instead of legacy gpio_* functions arch/arm/mach-imx/mx6/Kconfig | 1 + board/liebherr/display5/common.c

[U-Boot] [PATCH v2 02/14] ARM: imx: defconfig: Enable CONFIG_PINCTRL{_IMX6} on display5's defconfig

2019-09-03 Thread Lukasz Majewski
Enable PINCTRL for i.MX6 soc based display5 after DM/DTS conversion. Signed-off-by: Lukasz Majewski --- Changes in v2: None configs/display5_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/display5_defconfig b/configs/display5_defconfig index 8609cd5a8cf6

[U-Boot] [PATCH v2 01/14] fix: defconfig: Enable OF_CONTROL for display5_factory

2019-09-03 Thread Lukasz Majewski
This change fixes issue with building display5 "factory" U-Boot variant when the display5 board gains DM/DTS support. Signed-off-by: Lukasz Majewski --- Changes in v2: None configs/display5_factory_defconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[U-Boot] [PATCH v2 05/14] DM: mmc: Switch display5 board to use DM_MMC and BLK (USDHC)

2019-09-03 Thread Lukasz Majewski
After this commit the display5 device would use eMMC driver supporting driver model (DM_MMC and BLK). Signed-off-by: Lukasz Majewski --- Changes in v2: None arch/arm/mach-imx/mx6/Kconfig | 1 + board/liebherr/display5/common.c | 6 -- board/liebherr/display5/common.h | 1

[U-Boot] [PATCH v2 00/14] DM: display5: Convert display5 board to DM/DTS (including 'factory' setup)

2019-09-03 Thread Lukasz Majewski
of gpio_* ones - Use dm_gpio_* instead of legacy gpio_* functions Lukasz Majewski (14): fix: defconfig: Enable OF_CONTROL for display5_factory ARM: imx: defconfig: Enable CONFIG_PINCTRL{_IMX6} on display5's defconfig DM: I2C: Switch display5 board to use DM_I2C ARM: imx: defconfig: Enable

Re: [U-Boot] [PATCH] Revert "spi: Kconfig: Mark MXS_SPI has DEPRECATED"

2019-09-03 Thread Lukasz Majewski
evice Tree and Device Model, so the DEPRECATED Kconfig > symbol can be now removed. Gentle ping on this patch. > > Signed-off-by: Lukasz Majewski > > --- > > drivers/spi/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/spi/Kconfig b/drivers/spi/

[U-Boot] [PATCH] spl: mmc: Fix indentation in spl_mmc.c file

2019-09-03 Thread Lukasz Majewski
From: Mans Rullgard This fixes a wrongly indented block of code. Signed-off-by: Mans Rullgard [lukma: Make the commit message more verbose] Signed-off-by: Lukasz Majewski --- common/spl/spl_mmc.c | 40 1 file changed, 20 insertions(+), 20 deletions

[U-Boot] [PATCH] spl: mmc: Add option to set eMMC HW boot partition

2019-09-03 Thread Lukasz Majewski
message] Signed-off-by: Lukasz Majewski Acked-by: Andreas Dannenberg --- common/spl/Kconfig | 6 ++ common/spl/spl_mmc.c | 4 2 files changed, 10 insertions(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index f467eca2be..5b7667ea16 100644 --- a/common/spl/Kconfig +++ b/common

[U-Boot] [PATCH] spl: Introduce SPL_DM_GPIO Kconfig define

2019-09-03 Thread Lukasz Majewski
This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use #if !CONFIG_IS_ENABLED(DM_GPIO) to also support not yet DM/DTS converted boards. Signed-off-by: Lukasz Majewski --- common/spl/Kconfig | 6 ++ 1 file

[U-Boot] [PATCH] kconfig: doc: Update comment regarding CONFIG_IS_ENABLED(FOO) for TPL

2019-09-03 Thread Lukasz Majewski
This patch adds some commit info for CONFIG_IS_ENABLED(FOO) when used in TPL context. Signed-off-by: Lukasz Majewski --- include/linux/kconfig.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/kconfig.h b/include/linux/kconfig.h index fbfc7188b8..3a2da738c4 100644

[U-Boot] [PATCH] doc: fix: Replace SPL_OF_PLATDATA with OF_PLATDATA in examples

2019-09-03 Thread Lukasz Majewski
-off-by: Lukasz Majewski Reviewed-by: Peng Fan --- doc/driver-model/of-plat.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/driver-model/of-plat.rst b/doc/driver-model/of-plat.rst index 0d3cd8c01e..a38e58e4d2 100644 --- a/doc/driver-model/of-plat.rst +++ b/doc

Re: [U-Boot] [PATCH] dfu: dfu_nand: reduce verbosity

2019-08-27 Thread Lukasz Majewski
strtoul(s, , 10); > > sprintf(mtd_id, "%s%d,%d", "nand", dev, part - 1); > - printf("using id '%s'\n", mtd_id); > + debug("using id '%s'\n", mtd_id); > > mtdparts_init(); > Acke

Re: [U-Boot] [PATCH v3 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-08-26 Thread Lukasz Majewski
sdp_runtime_hs_descs; > sdp_func->usb_function.descriptors = sdp_runtime_descs; > sdp_func->usb_function.bind = sdp_bind; > sdp_func->usb_function.unbind = sdp_unbind; > @@ -725,6 +751,7 @@ static void sdp_handle_in_ep(struct > spl_image_info *spl_image) /* In SPL, allow jumps to U-Boot

Re: [U-Boot] [PATCH v3 1/4] imx: spl: Change USB boot device type for imx8/8m

2019-08-26 Thread Lukasz Majewski
ault: > return BOOT_DEVICE_NONE; > } Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax:

Re: [U-Boot] [GIT] Pull request: u-boot-clk (22.08.2019)

2019-08-26 Thread Lukasz Majewski
Hi Tom, > On Thu, Aug 22, 2019 at 05:14:57PM +0200, Lukasz Majewski wrote: > > > Dear Tom, > > > > Please find a PR for u-boot-clk branch: > > > > The following changes since commit > > 753e5385ca6d0fe5b5f5a3a97cc96b0f2469ca94: > > Can you

Re: [U-Boot] [PATCH 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2019-08-23 Thread Lukasz Majewski
Hi Jonas, > Quoting Lukasz Majewski (2019-08-23 10:37:28) > > On Sun, 18 Aug 2019 17:16:06 +0200 > > Jonas Smedegaard wrote: > > > > > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and > > > CONFIG_PREBOOT to Kconfig") intended to suppor

Re: [U-Boot] [PATCH v2 4/4] spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*

2019-08-23 Thread Lukasz Majewski
Hi Tom, > On Tue, Aug 13, 2019 at 03:47:31PM +0200, Lukasz Majewski wrote: > > This change allows more fine tuning of driver model based SPI > > support in SPL and TPL. It is now possible to explicitly > > enable/disable the DM_SPI support in SPL and TPL via Kconfig op

Re: [U-Boot] [PATCH 2/3] mmc: fsl_esdhc: clean up code

2019-08-23 Thread Lukasz Majewski
kpatch.py if it is clean? (You can also test tools/patman - which does automatic checkpatch check) > +{ Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-

Re: [U-Boot] [PATCH 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2019-08-23 Thread Lukasz Majewski
; > #ifdef CONFIG_USB_KEYBOARD > +#ifdef CONFIG_USE_PREBOOT > +#ifndef CONFIG_PREBOOT > +#define CONFIG_PREBOOT \ > + "usb start" Shouldn't this (CONFIG_PREBOOT) be set in the Kconfig? > +#endif > +#endif > #define CONSOLE_STDIN_SETTINGS \ > - "preboot=u

Re: [U-Boot] [PATCH v5 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-22 Thread Lukasz Majewski
On Thu, 22 Aug 2019 01:56:48 + Xiaowei Bao wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月20日 17:50 > > To: Xiaowei Bao > > Cc: w...@denx.de; Ruchika Gupta ; Shengzhou Liu > > ; ja...@amarulasolutions.com; Prabhakar

[U-Boot] [GIT] Pull request: u-boot-clk (22.08.2019)

2019-08-22 Thread Lukasz Majewski
-CI: https://travis-ci.org/lmajewski/u-boot-dfu/builds/575085150 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email

Re: [U-Boot] [PATCH V4 0/4] Prepare i.MX8MM clk

2019-08-20 Thread Lukasz Majewski
+++ drivers/clk/imx/clk-pll14xx.c >| 381 ++ drivers/clk/imx/clk.h > | 25 +++ 7 files changed, 1009 insertions(+), 2 deletions(-) > create mode 100644 drivers/clk/imx/clk-composite-8m.c > create mode 100644 drivers/clk/imx/clk-imx8m

Re: [U-Boot] [PATCH v5 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-20 Thread Lukasz Majewski
On Tue, 20 Aug 2019 09:00:40 + Xiaowei Bao wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月20日 16:20 > > To: Xiaowei Bao > > Cc: w...@denx.de; Ruchika Gupta ; Shengzhou Liu > > ; ja...@amarulasolutions.com; Prabhakar

Re: [U-Boot] [PATCH v5 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-20 Thread Lukasz Majewski
On Tue, 20 Aug 2019 07:51:18 + Xiaowei Bao wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月20日 15:43 > > To: Xiaowei Bao > > Cc: w...@denx.de; Ruchika Gupta ; Shengzhou Liu > > ; ja...@amarulasolutions.com; Prabhakar

Re: [U-Boot] [PATCH v5 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-20 Thread Lukasz Majewski
On Tue, 20 Aug 2019 07:27:39 + Xiaowei Bao wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月20日 15:14 > > To: Xiaowei Bao > > Cc: w...@denx.de; Ruchika Gupta ; Shengzhou Liu > > ; ja...@amarulasolutions.com; Prabhakar

Re: [U-Boot] [PATCH v5 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-20 Thread Lukasz Majewski
undef CONFIG_DM_GPIO > #undef CONFIG_DM_I2C > #undef CONFIG_DM_SPI > +#undef CONFIG_DM_SPI_FLASH > #endif > > #undef CONFIG_DM_WARN Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchens

[U-Boot] [PATCH v2 2/3] spl: mmc: Add option to set eMMC HW boot partition

2019-08-19 Thread Lukasz Majewski
message] Signed-off-by: Lukasz Majewski --- Changes in v2: None common/spl/Kconfig | 6 ++ common/spl/spl_mmc.c | 4 2 files changed, 10 insertions(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 0a3877ec28..4fe4a1359c 100644 --- a/common/spl/Kconfig +++ b/common/spl

[U-Boot] [PATCH v2 3/3] imx: Add support for i.MX28 based XEA board

2019-08-19 Thread Lukasz Majewski
MAC address - ce:e1:9e:46:f3:a2 eth0: ethernet@800f Hit any key to stop autoboot: 0 Signed-off-by: Mans Rullgard Signed-off-by: Lukasz Majewski --- Changes in v2: - Adjust config to match dependent patches - Increase malloc size to allow booting the board with GPIO DM/DTS support - Add

[U-Boot] [PATCH v2 1/3] spl: mmc: Fix indentation in spl_mmc.c file

2019-08-19 Thread Lukasz Majewski
From: Mans Rullgard This fixes a wrongly indented block of code. Signed-off-by: Mans Rullgard [lukma: Make the commit message more verbose] Signed-off-by: Lukasz Majewski --- Changes in v2: None common/spl/spl_mmc.c | 40 1 file changed, 20

[U-Boot] [PATCH v2 9/9] spi: Add support for SPL_OF_PLATDATA to mxs_gpio.c driver

2019-08-18 Thread Lukasz Majewski
After this patch the mxs_gpio.c DM/DTS driver can be used at early SPL to read states of gpio pins (and for example alter the boot flow). It was necessary to adjust its name to 'fsl_imx_2{38}_gpio' to match requirements for SPL_OF_PLATDATA usage. Signed-off-by: Lukasz Majewski --- Changes

[U-Boot] [PATCH v2 8/9] spl: Introduce SPL_DM_GPIO Kconfig define

2019-08-18 Thread Lukasz Majewski
This define indicates if DM_GPIO shall be supported in SPL. This allows proper operation of DM converted GPIO drivers in SPL, which use #if !CONFIG_IS_ENABLED(DM_GPIO) to also support not yet DM/DTS converted boards. Signed-off-by: Lukasz Majewski --- Changes in v2: - New patch common/spl

[U-Boot] [PATCH v2 7/9] mmc: Replace printf with debug call for timeouts in the i.MX28 mxs driver

2019-08-18 Thread Lukasz Majewski
bserial -b 115200 -d /dev/ttyUSB1 -e 30 -t -m "^U-Boot SPL*" Signed-off-by: Lukasz Majewski --- Changes in v2: - New patch drivers/mmc/mxsmmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/mxsmmc.c b/drivers/mmc/mxsmmc.c index 7ea47f9801..9414eff42b

[U-Boot] [PATCH v2 4/9] spi: fix: Call mxs_reset_block() during DM/DTS probe

2019-08-18 Thread Lukasz Majewski
() is not called at all and DM/DTS aware SPI driver in U-Boot proper is malfunctioning. Signed-off-by: Lukasz Majewski --- Changes in v2: None drivers/spi/mxs_spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c index b1cc83aab1..d475830f17

[U-Boot] [PATCH v2 2/9] dts: imx28: Remove #include "imx28.dtsi" from imx28-u-boot.dtsi file

2019-08-18 Thread Lukasz Majewski
abled" in the final DTB. Signed-off-by: Lukasz Majewski --- Changes in v2: None arch/arm/dts/imx28-u-boot.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/dts/imx28-u-boot.dtsi b/arch/arm/dts/imx28-u-boot.dtsi index d545b402a7..9db72a6be3 100644 --- a/arch/arm/dts/imx28-u-boot.

[U-Boot] [PATCH v2 6/9] mmc: Convert mxsmmc eMMC driver for i.MX2{38} to DM/DTS

2019-08-18 Thread Lukasz Majewski
This patch converts the mxsmmc driver to support DM/DTS. Moreover, it is also possible to use it in early SPL with SPL_OF_PLATDATA enabled. Signed-off-by: Lukasz Majewski --- Changes in v2: - Correct position of struct mmc_ops mxsmmc_ops to avoid build breaks on board using legacy i.MX28

[U-Boot] [PATCH v2 5/9] spi: Add support for SPL_OF_PLATDATA to mxs_spi.c driver

2019-08-18 Thread Lukasz Majewski
After this patch the mxs_spi.c DM/DTS driver can be used at early SPL to read payload from SPI-NOR memories. It was necessary to adjust its name to 'fsl_imx_2{38}_spi' to match requirements for SPL_OF_PLATDATA usage. Signed-off-by: Lukasz Majewski --- Changes in v2: None drivers/spi

[U-Boot] [PATCH v2 1/9] doc: fix: Replace SPL_OF_PLATDATA with OF_PLATDATA in examples

2019-08-18 Thread Lukasz Majewski
is also compiled in when U-Boot proper is build. Signed-off-by: Lukasz Majewski --- Changes in v2: None doc/driver-model/of-plat.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/driver-model/of-plat.rst b/doc/driver-model/of-plat.rst index 0d3cd8c01e..a38e58e4d2

[U-Boot] [PATCH v2 3/9] spl: Init proper struct driver member (platdata_auto_alloc_size) for mxs_spi

2019-08-18 Thread Lukasz Majewski
This change initializes proper member of struct driver - platdata_auto_alloc_size instead of priv_auto_alloc_size, which is setup twice. Signed-off-by: Lukasz Majewski --- Changes in v2: - New patch drivers/spi/mxs_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[U-Boot] [PATCH v2 0/9] imx: mxs: Fixes and DM/DTS conversion code for several i.MX28 drivers

2019-08-18 Thread Lukasz Majewski
driver. - New patch - New patch - New patch Lukasz Majewski (9): doc: fix: Replace SPL_OF_PLATDATA with OF_PLATDATA in examples dts: imx28: Remove #include "imx28.dtsi" from imx28-u-boot.dtsi file spl: Init proper struct driver member (platdata_auto_alloc_size) for mxs_spi spi:

Re: [U-Boot] [PATCH 1/3] clk: introduce enable_cnt

2019-08-16 Thread Lukasz Majewski
t; +++ b/include/clk.h > @@ -61,6 +61,7 @@ struct clk { > struct udevice *dev; > long long rate; /* in HZ */ > u32 flags; > + int enable_cnt; > /* >* Written by of_xlate. In the future, we might add more > fields here. */ Best regards,

Re: [U-Boot] [PATCH v4 2/2] board: Add support for iMX8QXP AI_ML board

2019-08-15 Thread Lukasz Majewski
On Thu, 15 Aug 2019 13:46:30 +0530 Manivannan Sadhasivam wrote: > Hi Lukasz, > > On Thu, Aug 15, 2019 at 09:51:25AM +0200, Lukasz Majewski wrote: > > Hi Manivannan, > > > > > Hi Lukasz, > > > > > > Thanks for the review! > > > > &

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-15 Thread Lukasz Majewski
On Thu, 15 Aug 2019 07:57:00 + Chuanhua Han wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月15日 15:54 > > To: Chuanhua Han > > Cc: Jagan Teki ; Xiaowei Bao > > ; U-Boot-Denx ; Pan > > Jiafei ; Jagan Teki ; > &g

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-15 Thread Lukasz Majewski
On Thu, 15 Aug 2019 07:39:45 + Chuanhua Han wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月15日 15:15 > > To: Chuanhua Han > > Cc: Jagan Teki ; Xiaowei Bao > > ; U-Boot-Denx ; Pan > > Jiafei ; Jagan Teki ; > &g

Re: [U-Boot] [PATCH v4 2/2] board: Add support for iMX8QXP AI_ML board

2019-08-15 Thread Lukasz Majewski
Hi Manivannan, > Hi Lukasz, > > Thanks for the review! > > On Wed, Jul 24, 2019 at 10:07:13AM +0200, Lukasz Majewski wrote: > > Hi Manivannan, > > > > > This commit adds initial board support for iMX8QXP AI_ML board > > > from Einfochip

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-15 Thread Lukasz Majewski
On Thu, 15 Aug 2019 03:35:28 + Chuanhua Han wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月14日 19:39 > > To: Chuanhua Han > > Cc: Jagan Teki ; Xiaowei Bao > > ; U-Boot-Denx ; Pan > > Jiafei ; Jagan Teki ; > &g

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-14 Thread Lukasz Majewski
On Wed, 14 Aug 2019 11:10:46 + Chuanhua Han wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月14日 18:53 > > To: Chuanhua Han > > Cc: Jagan Teki ; Xiaowei Bao > > ; U-Boot-Denx ; Pan > > Jiafei ; Jagan Teki ; > &g

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-14 Thread Lukasz Majewski
On Wed, 14 Aug 2019 10:41:32 + Chuanhua Han wrote: > > -Original Message- > > From: Lukasz Majewski > > Sent: 2019年8月14日 16:57 > > To: Chuanhua Han > > Cc: Jagan Teki ; Xiaowei Bao > > ; U-Boot-Denx ; Pan > > Jiafei ; Jagan Teki ; > &g

Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

2019-08-14 Thread Lukasz Majewski
> > #undef CONFIG_DM_SPI > > > +#undef CONFIG_DM_SPI_FLASH > > > > Have you made any Travis-CI run? > I tested it with a local board Could you be so kind and also test following patchset (parts from Layerscape also needs testing): https://patchwork.ozlabs.org/c

[U-Boot] [PATCH v2 0/4] spi: Split CONFIG_DM_SPI* to CONFIG_{SPL_TPL}DM_SPI*

2019-08-13 Thread Lukasz Majewski
. This series doesn't introduce build breaks, but board maintainers are kindly asked to check if their boards still boots. Changes in v2: - Resend patches with some not yet in mainline code removed as suggested by Adam Ford Lukasz Majewski (4): kconfig: doc: Update comment regarding CONFIG_IS_ENABLED

[U-Boot] [PATCH] kconfig: Convert CONFIG_MXS_GPIO to Kconfig

2019-08-13 Thread Lukasz Majewski
This converts the following to Kconfig: CONFIG_MXS_GPIO Travis-CI: https://travis-ci.org/lmajewski/u-boot-dfu/builds/571260789 Signed-off-by: Lukasz Majewski --- configs/apx4devkit_defconfig| 1 + configs/bg0900_defconfig| 1 + configs/mx23_olinuxino_defconfig

[U-Boot] [PATCH v2 4/4] spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*

2019-08-13 Thread Lukasz Majewski
DM_SPI{_FLASH} defined to allow compiling SPL. This patch converts #ifdef CONFIG_DM_SPI* to #if CONFIG_IS_ENABLED(DM_SPI) and provides corresponding defines in Kconfig. Signed-off-by: Lukasz Majewski Tested-by: Adam Ford #da850-evm --- Changes in v2: - Resend patches with some not yet in mainline

[U-Boot] [PATCH v2 3/4] spi: Move DM_SPI_FLASH and SPI_FLASH_DATAFLASH to Kconfig (for ls1021aXXX)

2019-08-13 Thread Lukasz Majewski
converted drivers), but it was set in u-boot.cfg file. Signed-off-by: Lukasz Majewski --- Changes in v2: None arch/arm/Kconfig | 6 -- include/configs/ls1021aiot.h | 6 -- include/configs/ls1021aqds.h | 8 include/configs/ls1021atwr.h | 5 - 4 files changed, 4

[U-Boot] [PATCH v2 2/4] spi: Move DM_SPI_FLASH to Kconfig (for NXP's ls1043a)

2019-08-13 Thread Lukasz Majewski
of DM_SPI_FLASH to using CONFIG_IS_ENABLED() is not working properly. Signed-off-by: Lukasz Majewski --- Changes in v2: None arch/arm/Kconfig | 4 include/configs/ls1043a_common.h | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm

[U-Boot] [PATCH v2 1/4] kconfig: doc: Update comment regarding CONFIG_IS_ENABLED(FOO) for TPL

2019-08-13 Thread Lukasz Majewski
This patch adds some commit info for CONFIG_IS_ENABLED(FOO) when used in TPL context. Signed-off-by: Lukasz Majewski --- Changes in v2: None include/linux/kconfig.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/kconfig.h b/include/linux/kconfig.h index fbfc7188b8f6

Re: [U-Boot] [PATCH V3 1/4] clk: imx: add Kconfig entry for i.MX8MM

2019-08-13 Thread Lukasz Majewski
Enable this option if you want to (re-)use the Linux > > > kernel's > > Common > > > Clock Framework [CCF] code in U-Boot's SPL. > > > @@ -62,7 +62,7 @@ config SPL_CLK_COMPOSITE_CCF > > > > > > config CLK_CCF > > >

Re: [U-Boot] [PATCH v1 0/4] spi: Split CONFIG_DM_SPI* to CONFIG_{SPL_TPL}DM_SPI*

2019-08-12 Thread Lukasz Majewski
Hi Adam, > On Mon, Aug 12, 2019 at 2:08 AM Lukasz Majewski wrote: > > > > This patch series introduces new SPL and TPL specific Kconfig > > entries for DM_SPI* options. Such change allows using the spi > > driver in SPL/TPL or U-Boot proper. > > > > First

[U-Boot] [PATCH v1 0/4] spi: Split CONFIG_DM_SPI* to CONFIG_{SPL_TPL}DM_SPI*

2019-08-12 Thread Lukasz Majewski
. This series doesn't introduce build breaks, but board maintainers are kindly asked to check if their boards still boots. Lukasz Majewski (4): kconfig: Update comment regarding CONFIG_IS_ENABLED(FOO) for TPL spi: Move DM_SPI_FLASH to Kconfig (for NXP's ls1043a) spi: Move DM_SPI_FLASH

[U-Boot] [PATCH] imx: Add support for i.MX28 based XEA board

2019-08-12 Thread Lukasz Majewski
MAC address - ce:e1:9e:46:f3:a2 eth0: ethernet@800f Hit any key to stop autoboot: 0 Signed-off-by: Mans Rullgard Signed-off-by: Lukasz Majewski --- Dependencies: - The whole patch series (1-4) starting at: https://patchwork.ozlabs.org/patch/1145520/ - Fixes/conversion for i.MX28 spi

[U-Boot] [PATCH 5/5] mmc: Convert mxsmmc eMMC driver for i.MX2{38} to DM/DTS

2019-08-12 Thread Lukasz Majewski
This patch converts the mxsmmc driver to support DM/DTS. Moreover, it is also possible to use it in early SPL with SPL_OF_PLATDATA enabled. Signed-off-by: Lukasz Majewski --- drivers/mmc/mxsmmc.c | 439 +++ 1 file changed, 369 insertions(+), 70

[U-Boot] [PATCH 2/5] dts: imx28: Remove #include "imx28.dtsi" from imx28-u-boot.dtsi file

2019-08-12 Thread Lukasz Majewski
abled" in the final DTB. Signed-off-by: Lukasz Majewski --- arch/arm/dts/imx28-u-boot.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/dts/imx28-u-boot.dtsi b/arch/arm/dts/imx28-u-boot.dtsi index d545b402a7..9db72a6be3 100644 --- a/arch/arm/dts/imx28-u-boot.dtsi +++ b/arch/arm/d

[U-Boot] [PATCH 3/5] spi: fix: Call mxs_reset_block() during DM/DTS probe

2019-08-12 Thread Lukasz Majewski
() is not called at all and DM/DTS aware SPI driver in U-Boot proper is malfunctioning. Signed-off-by: Lukasz Majewski --- drivers/spi/mxs_spi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c index 3a9756fbf1..b79a72db2b 100644 --- a/drivers

[U-Boot] [PATCH 4/5] spi: Add support for SPL_OF_PLATDATA to mxs_spi.c driver

2019-08-12 Thread Lukasz Majewski
After this patch the mxs_spi.c DM/DTS driver can be used at early SPL to read payload from SPI-NOR memories. It was necessary to adjust its name to 'fsl_imx_2{38}_spi' to match requirements for SPL_OF_PLATDATA usage. Signed-off-by: Lukasz Majewski --- drivers/spi/mxs_spi.c | 34

[U-Boot] [PATCH 1/5] doc: fix: Replace SPL_OF_PLATDATA with OF_PLATDATA in examples

2019-08-12 Thread Lukasz Majewski
is also compiled in when U-Boot proper is build. Signed-off-by: Lukasz Majewski --- doc/driver-model/of-plat.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/driver-model/of-plat.rst b/doc/driver-model/of-plat.rst index 0d3cd8c01e..a38e58e4d2 100644 --- a/doc

[U-Boot] [PATCH v1 2/4] spi: Move DM_SPI_FLASH to Kconfig (for NXP's ls1043a)

2019-08-12 Thread Lukasz Majewski
of DM_SPI_FLASH to using CONFIG_IS_ENABLED() is not working properly. Signed-off-by: Lukasz Majewski --- arch/arm/Kconfig | 4 include/configs/ls1043a_common.h | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index

[U-Boot] [PATCH v1 4/4] spi: Convert CONFIG_DM_SPI* to CONFIG_$(SPL_TPL_)DM_SPI*

2019-08-12 Thread Lukasz Majewski
DM_SPI{_FLASH} defined to allow compiling SPL. This patch converts #ifdef CONFIG_DM_SPI* to #if CONFIG_IS_ENABLED(DM_SPI) and provides corresponding defines in Kconfig. Signed-off-by: Lukasz Majewski --- === BIG FAT NOTE (REQUEST FOR TESTING

[U-Boot] [PATCH v1 3/4] spi: Move DM_SPI_FLASH and SPI_FLASH_DATAFLASH to Kconfig (for ls1021aXXX)

2019-08-12 Thread Lukasz Majewski
converted drivers), but it was set in u-boot.cfg file. Signed-off-by: Lukasz Majewski --- arch/arm/Kconfig | 6 -- include/configs/ls1021aiot.h | 6 -- include/configs/ls1021aqds.h | 8 include/configs/ls1021atwr.h | 5 - 4 files changed, 4 insertions(+), 21

[U-Boot] [PATCH v1 1/4] kconfig: Update comment regarding CONFIG_IS_ENABLED(FOO) for TPL

2019-08-12 Thread Lukasz Majewski
This patch adds some commit info for CONFIG_IS_ENABLED(FOO) when used in TPL context. Signed-off-by: Lukasz Majewski --- include/linux/kconfig.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/kconfig.h b/include/linux/kconfig.h index fbfc7188b8..3a2da738c4 100644

Re: [U-Boot] [PATCH v2 07/11] imx: tpc70: dts: Add TPC70 board (imx6q based) device tree description

2019-08-12 Thread Lukasz Majewski
Hi Tom, > On Sun, Aug 11, 2019 at 11:25:37PM +0200, Lukasz Majewski wrote: > > Hi Peng, > > > > > > Subject: [PATCH v2 07/11] imx: tpc70: dts: Add TPC70 board > > > > (imx6q based) device tree description > > > > > > >

Re: [U-Boot] [PATCH 01/22] tools: imx8m_image: align spl bin image size

2019-08-11 Thread Lukasz Majewski
train_1d_fw.bin > lpddr4_pmu_train_2d_fw.bin lpddr4_pmu_train_1d_imem_pad.bin > lpddr4_pmu_train_1d_dmem_pad.bin lpddr4_pmu_train_2d_imem_pad.bin > spl/u-boot-spl-pad.bin fi fi Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wo

Re: [U-Boot] [PATCH 18/22] imx8m: restructure clock.h

2019-08-11 Thread Lukasz Majewski
(0xf << 1) > +#define SSCG_PLL_SSE_MASK0x1 > + > +#define SSCG_PLL_REF_DIVR1_MASK (0x7 << 25) > +#define SSCG_PLL_REF_DIVR1_SHIFT 25 > +#define SSCG_PLL_REF_DIVR1_VAL(n)(((n) << 25) & > SSCG_PLL_REF_DIVR1_MASK) +#define SSCG

Re: [U-Boot] [PATCH 17/22] imx8m: rename clock to clock_imx8mq

2019-08-11 Thread Lukasz Majewski
ere be then two CONFIG_ entries? LIke CONFIG_IMX8MM and CONFIG_IMX8MQ? > diff --git a/arch/arm/mach-imx/imx8m/clock.c > b/arch/arm/mach-imx/imx8m/clock_imx8mq.c similarity index 100% > rename from arch/arm/mach-imx/imx8m/clock.c > rename to arch/arm/mach-imx/imx8m/clock_imx8mq.c

Re: [U-Boot] [PATCH 13/22] imx8m: Fix MMU table issue for OPTEE memory

2019-08-11 Thread Lukasz Majewski
the D and I caches were disabled. Why you add code to enable them and those are not enabled on imx8mm EVK board? > +} > + > static u32 get_cpu_variant_type(u32 type) > { > struct ocotp_regs *ocotp = (struct ocotp_regs > *)OCOTP_BASE_ADDR; Best regards, Lukasz Majewski

Re: [U-Boot] [PATCH 11/22] imx8m: add pin header for i.MX8MM

2019-08-11 Thread Lukasz Majewski
X > = IOMUX_PAD(0x04A0, 0x0238, 0, 0x, 0, 0), > + IMX8MM_PAD_UART1_TXD_UART1_RX > = IOMUX_PAD(0x04A0, 0x0238, 0, 0x04F4, 1, 0), > + IMX8MM_PAD_UART1_TXD_ECSPI3_MOSI > = IOMUX_PAD(0x04A0, 0x0238, 1, 0x, 0, 0), > + IMX8MM_PAD_UART1_TXD_GPIO5_IO23 > = IO

Re: [U-Boot] [PATCH v2 05/11] imx: tpc70: cosmetic: Replace magic numbers when setting ENET clock

2019-08-11 Thread Lukasz Majewski
Hi Peng, > > Subject: [PATCH v2 05/11] imx: tpc70: cosmetic: Replace magic > > numbers when setting ENET clock > > > > This is a cosmetic change, just to use proper define instead of > > magic numbers. > > > > Signed-off-by: Lukasz Majewski

Re: [U-Boot] [PATCH v2 07/11] imx: tpc70: dts: Add TPC70 board (imx6q based) device tree description

2019-08-11 Thread Lukasz Majewski
ubset of [1] was added to U-Boot. Note: [1] - https://elixir.bootlin.com/linux/v5.2.8/source/arch/arm/boot/dts/imx6q-kp.dtsi > Regards, > Peng. > > > > > Signed-off-by: Lukasz Majewski > > --- > > > > arch/arm/dts/imx6q-kp.dts | 219 > > +

Re: [U-Boot] [PATCH 22/22] imx: Add i.MX8MM EVK board support.

2019-08-10 Thread Lukasz Majewski
Hi Peng, I think that I've made a review to the code adding some i.MX8 board in the past, but I do see that those comments were not applied: 1. The DDR4 configuration code as a very large table of magic numbers (but there is a commented out CONFIG_ to train the DDR4 in .h file. 2. Not using

Re: [U-Boot] [PATCH] i2c: mxc: add CONFIG_CLK support

2019-08-08 Thread Lukasz Majewski
int mxc_i2c_probe(struct udevice *bus) > ret = i2c_idle_bus(i2c_bus); > if (ret < 0) { > /* Disable clk */ > +#if CONFIG_IS_ENABLED(CLK) > + clk_disable(_bus->per_clk); > +#else > enable_i2c_clk(0, bus->seq); > +

<    1   2   3   4   5   6   7   8   9   10   >