Re: [U-Boot] [PATCH] video: backlight: fix pwm invertation

2019-06-27 Thread Marc Dietrich
Am Freitag, 21. Juni 2019, 22:01:35 CEST schrieb Marc Dietrich: > Fixes: 57e7775413 ("video: backlight: Parse PWM polarity cell") > > set_pwm will always fail if pwm_set_invert is not implemented, leaving the > backlight dark. Fix this by calling pwm_set_invert o

[U-Boot] [PATCH] video: backlight: fix pwm invertation

2019-06-21 Thread Marc Dietrich
Fixes: 57e7775413 ("video: backlight: Parse PWM polarity cell") set_pwm will always fail if pwm_set_invert is not implemented, leaving the backlight dark. Fix this by calling pwm_set_invert only if pwm is inverted. Signed-off-by: Marc Dietrich --- drivers/video/pwm_backlight.c | 7

Re: [U-Boot] [Ac100] [PATCH v2 5/6] ARM: tegra: paz00: add dtbindingsfor nvec

2014-04-30 Thread Marc Dietrich
On Wed, 30 Apr 2014 10:21:07 -0600 Stephen Warren wrote: > On 04/30/2014 01:52 AM, Marc Dietrich wrote: > > Am Montag, 28. April 2014, 17:04:13 schrieb Stephen Warren: > >> On 04/26/2014 07:14 PM, Andrey Danin wrote: > >> > >> This patch isn't adding DT b

Re: [U-Boot] [Ac100] [PATCH v2 5/6] ARM: tegra: paz00: add dtbindings for nvec

2014-04-30 Thread Marc Dietrich
Hi, Am Montag, 28. April 2014, 17:04:13 schrieb Stephen Warren: > On 04/26/2014 07:14 PM, Andrey Danin wrote: > > This patch isn't adding DT bindings for NVEC, but rather add DT nodes. > The binding is the schema, not the content. > > We need a DT binding document that's been reviewed by the DT b

Re: [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboardsupport

2013-07-24 Thread Marc Dietrich
On Tuesday 23 July 2013 08:40:42 Stephen Warren wrote: > On 07/22/2013 01:09 AM, Marc Dietrich wrote: [ snip the stuff we agreed upon ] > > The nvec still needs to tell the slave driver which protocol to use, but > > that can be hard coded. > > I'm not sure what that m

Re: [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboard support

2013-07-23 Thread Marc Dietrich
On Friday 19 July 2013 13:14:13 Stephen Warren wrote: > On 07/19/2013 02:47 AM, Andrey Danin wrote: > > Signed-off-by: Andrey Danin > > (Some patch descriptions would be useful) > > > diff --git a/board/compal/dts/tegra20-paz00.dts > > b/board/compal/dts/tegra20-paz00.dts > > > > + nvec { > >

Re: [U-Boot] [Ac100] [PATCH 3/3] ARM: tegra: paz00: enable nveckeyboardsupport

2013-07-22 Thread Marc Dietrich
Am Samstag, 20. Juli 2013, 21:20:52 schrieb Stephen Warren: > On 07/20/2013 03:12 AM, Marc Dietrich wrote: > > On Friday 19 July 2013 13:14:13 Stephen Warren wrote: > ... > > > Let's skip how this may actually look like in software. Given the > > discussions w

Re: [U-Boot] [PATCH v3 8/9] tegra: i2c: Enable new CONFIG_SYS_I2Cframework

2013-05-07 Thread Marc Dietrich
Hi, Am Montag, 6. Mai 2013, 13:08:31 schrieb Stephen Warren: > On 05/04/2013 06:01 AM, Heiko Schocher wrote: > > From: Simon Glass > > > > This enables CONFIG_SYS_I2C on Tegra, updating existing boards and the > > Tegra i2c driver to support this. > > > > include/configs/beaver.h| 5 ++- >

[U-Boot] [PATCH V2] disk: fix unaligned access in efi partitions

2013-03-29 Thread Marc Dietrich
start_sect is not aligned to a 4 byte boundary thus causing exceptions on ARM platforms. Access this field via the get_unaligned_le32 macro. Signed-off-by: Marc Dietrich --- V2: replace le32_to_cpu(get_unaligned()) with get_unaligned_le32 disk/part_efi.c |3 ++- 1 file changed, 2

Re: [U-Boot] [PATCH] disk: fix unaligned access in efi partitions

2013-03-29 Thread Marc Dietrich
Albert, On Friday 29 March 2013 13:32:26 Albert ARIBAUD wrote: > On Fri, 29 Mar 2013 12:28:58 +0100, Marc Dietrich wrote: > > start_sect is not aligned to a 4 byte boundary thus causing exceptions > > on ARM platforms. Access this field via the get_unaligned macro. > > &g

Re: [U-Boot] [PATCH] disk: add -mno-unaligned-access to CFLAGS

2013-03-29 Thread Marc Dietrich
Albert, On Friday 29 March 2013 08:00:54 Albert ARIBAUD wrote: > On Thu, 28 Mar 2013 23:35 +0100, Marc Dietrich wrote: > > [ ... ] > > On Thursday 28 March 2013 21:42:13 Albert ARIBAUD wrote: > > > Which fields, which structures, which files are affected by the

[U-Boot] [PATCH] disk: fix unaligned access in efi partitions

2013-03-29 Thread Marc Dietrich
start_sect is not aligned to a 4 byte boundary thus causing exceptions on ARM platforms. Access this field via the get_unaligned macro. Signed-off-by: Marc Dietrich --- disk/part_efi.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/disk/part_efi.c b/disk/part_efi.c

Re: [U-Boot] [PATCH] disk: add -mno-unaligned-access to CFLAGS

2013-03-28 Thread Marc Dietrich
Hi Albert, On Thursday 28 March 2013 21:42:13 Albert ARIBAUD wrote: > On Thu, 28 Mar 2013 19:57:31 +0100, Marc Dietrich > wrote: > > Many on-disk structures used in the directory are accessed in a > > non aligned manner. gcc => 4.7 (and gcc-4.6 from Linaro) switched > &g

[U-Boot] [PATCH] disk: add -mno-unaligned-access to CFLAGS

2013-03-28 Thread Marc Dietrich
ned-off-by: Marc Dietrich --- disk/Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/disk/Makefile b/disk/Makefile index 5affe34..01134a3 100644 --- a/disk/Makefile +++ b/disk/Makefile @@ -24,6 +24,7 @@ include $(TOPDIR)/config.mk #CFLAGS += -DET_DEBUG -DDEBUG +CFLAGS += -

Re: [U-Boot] [PATCH] Tegra: Restore cp15 VBAR _start vector write forARMv7

2013-03-28 Thread Marc Dietrich
Tom, On Thursday 28 March 2013 10:26:03 Tom Warren wrote: > A start vector fix was added by AneeshV for OMAP4 (commit 0d479b53), > and caused the old monilithic Tegra builds to hang due to an undefined > instruction trap. Previously, the code needed to run on both the > AVP (ARM7TDI) and A9, and t

Re: [U-Boot] unaligned access in part_efi.c

2013-03-27 Thread Marc Dietrich
On Wednesday 27 March 2013 12:23:22 Stephen Warren wrote: > On 03/26/2013 02:42 PM, Marc Dietrich wrote: > > Hi, > > > > access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and > > propably other positions/fields causes an unaligned access on AR

[U-Boot] unaligned access in part_efi.c

2013-03-26 Thread Marc Dietrich
Hi, access to part->start_sect in pmbr_part_valid() (form disk/part_efi.c) and propably other positions/fields causes an unaligned access on ARM (tegra in my case) and a uboot crash. This was introduced by commit fae2bf22 [1] which changed le32_to_int (which is a byte access) to le32_to_cpu (wh

Re: [U-Boot] [PATCH v6 3/4] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files

2013-02-21 Thread Marc Dietrich
Thierry Reding looks (and boots) fine now. Thanks! Tested-by: Marc Dietrich > --- > v2: > - cleanup comments in dts files/match w/kernel files > - add sdhci aliases in all dts files > - use tegra20-tamonten.dtsi from the kernel for AD boards > v3: > - include tamonte

Re: [U-Boot] [PATCH v4 4/4] Tegra: MMC: Add DT support to MMCdriver for all T20 boards

2013-02-15 Thread Marc Dietrich
Stephen, On Thursday 14 February 2013 16:12:42 Stephen Warren wrote: > On 02/14/2013 02:04 PM, Tom Warren wrote: > > tegra_mmc_init() now parses the DT info for bus width, WP/CD GPIOs, etc. > > Tested on Seaboard, fully functional. > > > > Tamonten boards (medcom-wide, plutux, and tec) use a diff

Re: [U-Boot] [PATCH v4 0/4] Tegra: MMC: Add DT support for MMC to T20 boards

2013-02-14 Thread Marc Dietrich
Hi Tom, On Thursday 14 February 2013 14:03:57 Tom Warren wrote: > This patchset adds device-tree support to the Tegra MMC driver. > All device config is done via properties in the DT files instead > of hard-coded config options/function arguments. > > I've tested this on my Seaboard and everythin

Re: [U-Boot] [PATCH 2/2] Tegra: MMC: Add DT support to MMCdriverforall T20 boards

2013-02-05 Thread Marc Dietrich
Tom, On Tuesday 05 February 2013 13:41:21 Tom Warren wrote: > Marc, > > On Tue, Feb 5, 2013 at 1:06 PM, Marc Dietrich wrote: > > On Tuesday 05 February 2013 08:31:03 Tom Warren wrote: > >> Marc, > >> > >> On Tue, Feb 5, 2013 at 2:28 AM, Marc Dietrich

Re: [U-Boot] [PATCH 2/2] Tegra: MMC: Add DT support to MMC driverforall T20 boards

2013-02-05 Thread Marc Dietrich
On Tuesday 05 February 2013 08:31:03 Tom Warren wrote: > Marc, > > On Tue, Feb 5, 2013 at 2:28 AM, Marc Dietrich wrote: > >> > >> [...] > >> > >> diff --git a/board/compal/paz00/paz00.c b/board/compal/paz00/paz00.c > >> index 1447f47

Re: [U-Boot] [PATCH 2/2] Tegra: MMC: Add DT support to MMC driver forall T20 boards

2013-02-05 Thread Marc Dietrich
Hi Tom, Am Montag, 4. Februar 2013, 16:48:55 schrieb Tom Warren: > tegra_mmc_init() now uses DT info for bus width, WP/CD GPIOs, etc. > Tested on Seaboard, fully functional. > > Signed-off-by: Tom Warren > --- > arch/arm/include/asm/arch-tegra/mmc.h |2 +- > arch/arm/include/asm

[U-Boot] [PATCH] tegra: remove custom TEGRA_DEVICE_SETTINGS for board files

2012-11-29 Thread Marc Dietrich
TEGRA_DEVICE_SETTINGS lives now in tegra-common-post.h. This removes custom TEGRA_DEVICE_SETTINGS for all tegra boards providing video output, except seaboard, which was fixed by Stephen already. Cc: Thierry Reding Signed-off-by: Marc Dietrich --- Tom, this needs to be applied ontop of

[U-Boot] [PATCH 2/2 v2] tegra: enable LCD on PAZ00

2012-11-27 Thread Marc Dietrich
This adds LCD panel descriptions to the device tree of PAZ00 and enables LCD support in the configuration. Signed-off-by: Marc Dietrich --- I'll create a patch to add LCD support to common TEGRA_DEVICE_SETTINGS once the tegra tree is rebased. changes in V2: - s/DISPALY/DI

[U-Boot] [PATCH 1/2 v2] tegra: display: add board pinmux

2012-11-27 Thread Marc Dietrich
Boards may require a different pinmux setup for DISPLAY than the default one. Add a way to call into board specific code to set this up. Signed-off-by: Marc Dietrich --- changes in V2: - fix comment padding arch/arm/include/asm/arch-tegra/board.h |1 + board/nvidia/common/board.c

Re: [U-Boot] [PATCH 2/2] tegra: enable LCD on PAZ00

2012-11-26 Thread Marc Dietrich
On Monday 26 November 2012 12:00:51 Stephen Warren wrote: > On 11/25/2012 02:26 PM, Marc Dietrich wrote: > > This adds LCD panel descriptions to the device tree of PAZ00 and > > enables LCD support in the configuration. > > > > diff --git a/include/configs/paz00.

Re: [U-Boot] [PATCH 1/2] tegra: display: add board pinmux

2012-11-26 Thread Marc Dietrich
were > really doing here. yeah, I had to decide whether to create an ugly patch or an ugly comment. Will choose the other solution then. Marc > Otherwise this patchset LGTM. I'll apply it to tegra/next once you've > fixed these nits. > > Tom > > On Sun, Nov

[U-Boot] [PATCH 2/2] tegra: enable LCD on PAZ00

2012-11-25 Thread Marc Dietrich
This adds LCD panel descriptions to the device tree of PAZ00 and enables LCD support in the configuration. Signed-off-by: Marc Dietrich --- board/compal/dts/tegra20-paz00.dts | 32 board/compal/paz00/paz00.c | 11 +++ include/configs/paz00.h

[U-Boot] [PATCH 1/2] tegra: display: add board pinmux

2012-11-25 Thread Marc Dietrich
Boards may require a different pinmux setup for DISPALY than the default one. Add a way to call into board specific code to set this up. Signed-off-by: Marc Dietrich --- arch/arm/include/asm/arch-tegra/board.h |7 --- board/nvidia/common/board.c |7 +++ 2 files

Re: [U-Boot] [PATCH v4 07/16] tegra: Add LCD driver

2012-10-05 Thread Marc Dietrich
Simon, I tried to adapt this for paz00. I only get backlight and an all white screen. On checking what's wrong I stumpled about something strange below... Marc On Thursday 27 September 2012 17:44:28 Simon Glass wrote: > This driver supports driving a single LCD and providing a U-Boot console >

[U-Boot] [PATCH] tegra: move common features to a common makefile

2012-10-03 Thread Marc Dietrich
all new features become available for non-Nvidia board vendors. Cc: Stephen Warren Cc: Tom Warren Cc: Thierry Reding Cc: Lucas Stach Signed-off-by: Marc Dietrich --- Passed: MAKEALL -s tegra20, booted on paz00 --- board/avionic-design/medcom-wide/Makefile |6 -- board/avionic

Re: [U-Boot] [PATCH 2/2] tegra: enable lp0 on paz00

2012-09-16 Thread Marc Dietrich
Tom, On Monday 10 September 2012 12:32:00 Tom Warren wrote: > > -Original Message- > > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > > Sent: Monday, September 10, 2012 12:08 PM > > To: Marc Dietrich > > Cc: u-boot@lists.denx.de; Tom Warren >

Re: [U-Boot] [PATCH 1/2] tegra: i2c: Enable I2C on PAZ00

2012-09-10 Thread Marc Dietrich
On Monday 10 September 2012 13:04:42 Stephen Warren wrote: > On 09/10/2012 12:51 PM, Marc Dietrich wrote: > > This enables I2C on PAZ00. > > Really? You need to edit board/compal/dts/tegra20-paz00.dts to enable > the I2C ports, don't you? yes, together with the regulat

Re: [U-Boot] [PATCH 2/2] tegra: enable lp0 on paz00

2012-09-10 Thread Marc Dietrich
On Monday 10 September 2012 13:07:43 Stephen Warren wrote: > On 09/10/2012 12:51 PM, Marc Dietrich wrote: > > This enables LP0 to support suspend / resume on PAZ00. > > Ooh. Did you test this out with the AC100 kernel, and have it work? > That'd be pretty cool... yeah, i

[U-Boot] [PATCH 2/2] tegra: enable lp0 on paz00

2012-09-10 Thread Marc Dietrich
This enables LP0 to support suspend / resume on PAZ00. Signed-off-by: Marc Dietrich --- board/compal/paz00/Makefile |6 -- include/configs/paz00.h |8 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/board/compal/paz00/Makefile b/board/compal/paz00

[U-Boot] [PATCH 1/2] tegra: i2c: Enable I2C on PAZ00

2012-09-10 Thread Marc Dietrich
This enables I2C on PAZ00. Signed-off-by: Marc Dietrich --- include/configs/paz00.h |8 1 file changed, 8 insertions(+) diff --git a/include/configs/paz00.h b/include/configs/paz00.h index 24cda48..7e21e66 100644 --- a/include/configs/paz00.h +++ b/include/configs/paz00.h @@ -38,6

Re: [U-Boot] [PATCH] tegra: paz00: add device tree support

2012-05-23 Thread Marc Dietrich
Am Dienstag, 22. Mai 2012, 16:30:29 schrieb Stephen Warren: > On 05/22/2012 03:15 PM, Marc Dietrich wrote: > > On Tuesday 22 May 2012 10:58:37 Stephen Warren wrote: > >> On 05/22/2012 10:14 AM, Stephen Warren wrote: > >>> On 05/22/2012 02:04 AM, Marc Die

Re: [U-Boot] [PATCH] tegra: paz00: add device tree support

2012-05-22 Thread Marc Dietrich
On Tuesday 22 May 2012 10:58:37 Stephen Warren wrote: > On 05/22/2012 10:14 AM, Stephen Warren wrote: > > On 05/22/2012 02:04 AM, Marc Dietrich wrote: > >> Hi Stephen, > >> > >> Am Montag, 21. Mai 2012, 14:04:37 schrieb Stephen Warren: > >>> From

Re: [U-Boot] [PATCH] tegra: paz00: add device tree support

2012-05-22 Thread Marc Dietrich
Hi Stephen, Am Montag, 21. Mai 2012, 14:04:37 schrieb Stephen Warren: > From: Stephen Warren > > ... to enable USB host support, which enables Ethernet support. > > Signed-off-by: Stephen Warren while adding usb support is fine, I see no reason to add smsc95xx support because contrary to har

Re: [U-Boot] [PATCH v4 19/23] tegra: Add EMC settings for Seaboard

2012-04-10 Thread Marc Dietrich
Am Montag, 9. April 2012, 21:51:32 schrieb Stephen Warren: > On 04/09/2012 05:07 PM, Simon Glass wrote: > > Hi Stephen, > > > > On Mon, Apr 9, 2012 at 3:03 PM, Olof Johansson wrote: > >> On Mon, Apr 9, 2012 at 2:59 PM, Stephen Warren wrote: > >>> On 04/09/2012 03:40 PM, Simon Glass wrote: > >>>

Re: [U-Boot] [RFC PATCH 3/3] tegra2: Add support for Paz00 (Toshiba AC100)

2011-11-20 Thread Marc Dietrich
Hi Stephen, first, thanks for looking at this! On Sunday 20 November 2011 13:10:08 Thierry Reding wrote: > * Stephen Warren wrote: > > The Toshiba AC100 (code-name Paz00m a/k/a Dynabook AZ) is an netbook > > derived from the NVIDIA Tegra Harmony reference board. It ships with > > Ubuntu, but is o

Re: [U-Boot] [RFC PATCH 0/3] tegra2: Add paz00 support

2011-11-20 Thread Marc Dietrich
On Sunday 20 November 2011 13:05:58 Thierry Reding wrote: > * Stephen Warren wrote: > > This patch series adds support for the Toshiba AC100 Tegra netbook. > > > > I'm posting it as an RFC because: > > > > a) The AC100 is designed by Compal and marketed by Toshiba. Should we > > put > > the files