On Fri, Feb 2, 2024 at 6:03 AM Rob Herring wrote:
>
> On Wed, Jan 31, 2024 at 8:09 PM Masahiro Yamada wrote:
> >
> > On Thu, Feb 1, 2024 at 7:03 AM Rob Herring wrote:
> > >
> > > On Tue, Jan 30, 2024 at 3:16 AM Masahiro Yamada
> > > wrote:
> >
On Thu, Feb 1, 2024 at 7:03 AM Rob Herring wrote:
>
> On Tue, Jan 30, 2024 at 3:16 AM Masahiro Yamada wrote:
> >
> > On Fri, Jan 26, 2024 at 1:04 AM Simon Glass wrote:
> > >
> > > Hi,
> > >
> > > On Wed, 17 Jan 2024 at 06:14
On Fri, Jan 26, 2024 at 1:04 AM Simon Glass wrote:
>
> Hi,
>
> On Wed, 17 Jan 2024 at 06:14, Simon Glass wrote:
> >
> > Hi Masahiro, Tom,
> >
> > On Tue, 9 Jan 2024 at 07:33, Tom Rini wrote:
> > >
> > > On Tue, Jan 09, 2024 at 11:
rds,
> Simon
>
As I mentioned before, I am concerned with having
the same "compatible" entries, with different contents,
as you use the "compatible" string as an ID to selecting
the target config node, right?
$ fdtdump arch/arm64/boot/image.fit
...
conf-10 {
compatible = "tq,am642-tqma6442l-mbax4xxl",
"tq,am642-tqma6442l", "ti,am642";
description = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
fdt = "fdt-10";
kernel = "kernel";
};
...
conf-25 {
compatible = "tq,am642-tqma6442l-mbax4xxl",
"tq,am642-tqma6442l", "ti,am642";
description = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
fdt = "fdt-25";
kernel = "kernel";
};
--
Best Regards
Masahiro Yamada
On Fri, Dec 29, 2023 at 3:39 PM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Thu, Dec 14, 2023 at 7:34 AM Masahiro Yamada wrote:
> >
> > On Thu, Dec 14, 2023 at 3:12 PM Masahiro Yamada
> > wrote:
> > >
> > > On Thu, Dec 14, 2023 at 1:03 PM Che
On Thu, Dec 14, 2023 at 3:12 PM Masahiro Yamada wrote:
>
> On Thu, Dec 14, 2023 at 1:03 PM Chen-Yu Tsai wrote:
> >
> > On Sun, Dec 10, 2023 at 1:31 AM Geert Uytterhoeven
> > wrote:
> > >
> > > Hi Laurent,
> > >
> > > On Sat, Dec 9, 2
ng.
With this code in arch/arm64/boot/dts/ti/Makefile:
k3-am642-tqma64xxl-mbax4xxl-sdcard-dtbs := \
k3-am642-tqma64xxl-mbax4xxl.dtb k3-am64-tqma64xxl-mbax4xxl-sdcard.dtbo
k3-am642-tqma64xxl-mbax4xxl-wlan-dtbs := \
k3-am642-tqma64xxl-mbax4xxl.dtb k3-am64-tqma64xxl-mbax4xxl-wlan.dtbo
$ fdtdump arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl-sdcard.dtb
2>/dev/null| head -n15 | tail -n2
model = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
compatible = "tq,am642-tqma6442l-mbax4xxl", "tq,am642-tqma6442l",
"ti,am642";
$ fdtdump arch/arm64/boot/dts/ti/k3-am642-tqma64xxl-mbax4xxl-wlan.dtb
2>/dev/null| head -n15 | tail -n2
model = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
compatible = "tq,am642-tqma6442l-mbax4xxl", "tq,am642-tqma6442l",
"ti,am642";
These two go into image.fit, but one of them is completely dead
since there is no way to distinguish them.
$ fdtdump arch/arm64/boot/image.fit
...
conf-10 {
compatible = "tq,am642-tqma6442l-mbax4xxl",
"tq,am642-tqma6442l", "ti,am642";
description = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
fdt = "fdt-10";
kernel = "kernel";
};
...
conf-25 {
compatible = "tq,am642-tqma6442l-mbax4xxl",
"tq,am642-tqma6442l", "ti,am642";
description = "TQ-Systems TQMa64xxL SoM on MBax4xxL carrier board";
fdt = "fdt-25";
kernel = "kernel";
};
I agree with Chen-Yu.
FIT should not include full DTBs.
Bootloaders should assemble the final DTB
from base and overlays on-the-fly.
The FIT spec allows the "fdt" property to list
multiple image nodes.
o config-1
|- description = "configuration description"
|- kernel = "kernel sub-node unit name"
|- fdt = "fdt sub-node unit-name" [, "fdt overlay sub-node unit-name", ...]
|- loadables = "loadables sub-node unit-name"
|- script = "
|- compatible = "vendor
>
> ChenYu
>
>
> > Gr{oetje,eeting}s,
> >
> > Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> > ge...@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like
> > that.
> > -- Linus Torvalds
--
Best Regards
Masahiro Yamada
On Sat, Dec 2, 2023 at 3:09 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Fri, 1 Dec 2023 at 10:30, Masahiro Yamada wrote:
> >
> > On Fri, Dec 1, 2023 at 5:34 AM Simon Glass wrote:
> > >
> > > Add a script which produces a Flat Image Tree (FIT), a sin
On Fri, Dec 1, 2023 at 5:34 AM Simon Glass wrote:
>
> Add a script which produces a Flat Image Tree (FIT), a single file
> containing the built kernel and associated devicetree files.
> Compression defaults to gzip which gives a good balance of size and
> performance.
>
> The files compress from
ge FORCE
> + $(call cmd,fit,gzip)
The gzip parameter is not used.
Please do
$(call cmd,fit)
In the python script, functions are separated with two blank lines,
but there is only one blank line between parse_args() and setup_fit().
I do not mind either way because it does not contain any class,
but please keep consistency.
--
Best Regards
Masahiro Yamada
f
> >
> > +KBUILD_DTBS := dtbs
>
> Might you want to use tabs here as in the lines below?
This should not exist in the first place.
image.fit: dtbs
is better.
--
Best Regards
Masahiro Yamada
efi: vmlinux
> +$(BOOT_TARGETS): vmlinux
> $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
>
> Image.%: Image
> --
> 2.43.0.rc0.421.g78406f8d94-goog
>
--
Best Regards
Masahiro Yamada
h.join(dirpath, fname)
> +seq += 1
> +size += os.path.getsize(pathname)
> +model, compat = output_dtb(fsw, seq, pathname,
> + args.arch, args.compress)
> +entries.append([model, compat])
> +
> +finish_fit(fsw, entries)
> +
> +# Include the kernel itself in the returned file count
> +return fsw.as_fdt().as_bytearray(), seq + 1, size
> +
> +
> +def run_make_fit():
> +"""Run the tool's main logic"""
> +args = parse_args()
> +
> +out_data, count, size = build_fit(args)
> +with open(args.fit, 'wb') as outf:
> +outf.write(out_data)
> +
> +ext_fit_size = None
> +if args.external:
> +mkimage = os.environ.get('MKIMAGE', 'mkimage')
> +subprocess.check_call([mkimage, '-E', '-F', args.fit],
> + stdout=subprocess.DEVNULL)
> +
> +with open(args.fit, 'rb') as inf:
> +data = inf.read()
> +ext_fit = libfdt.FdtRo(data)
> +ext_fit_size = ext_fit.totalsize()
> +
> +comp_size = len(out_data)
> +print(f'FIT size {comp_size:#x}/{comp_size / 1024 / 1024:.1f} MB',
> end='')
> +if ext_fit_size:
> +print(f', header {ext_fit_size:#x}/{ext_fit_size / 1024:.1f} KB',
> end='')
> +print(f', {count} files, uncompressed {size / 1024 / 1024:.1f} MB')
> +
> +
> +if __name__ == "__main__":
> +sys.exit(run_make_fit())
> --
> 2.43.0.rc0.421.g78406f8d94-goog
>
--
Best Regards
Masahiro Yamada
XZ
> # -------
> --
> 2.42.0.869.gea05f2083d-goog
>
--
Best Regards
Masahiro Yamada
Hi Simon,
On Tue, Nov 7, 2023 at 3:11 PM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Tue, 7 Nov 2023 at 03:13, Masahiro Yamada wrote:
> >
> > On Sat, Nov 4, 2023 at 9:42 PM Simon Glass wrote:
> > >
> > > The use of single quotes in the image nam
> +bytes: Compatible stringlist
> +"""
> +with fsw.add_node(f'fdt-{seq}'):
> +# Get the compatible / model information
> +with open(fname, 'rb') as inf:
> +data = inf.read()
> +fdt = libfdt.FdtRo(data)
> +model = fdt.getprop(0, 'model').as_str()
> +compat = fdt.getprop(0, 'compatible')
> +
> +fsw.property_string('description', model)
> +fsw.property_string('type', 'flat_dt')
> +fsw.property_string('arch', 'arm64')
Why hard-code 'arm64' ?
--
Best Regards
Masahiro Yamada
$(UIMAGE_NAME)" -d $< $@
scripts/Makefile.lib: --name "$(UIMAGE_NAME)" \
You quoted the definition of UIMAGE_NAME,
and also variable references.
See how it is expanded.
--name "$(UIMAGE_NAME)"
==>
--name ""Linux-$(KERNELRELEASE)""
==>
--name Linux-$(KERNELRELEASE)
You added double quotes in a row, just to cancel it.
--
Best Regards
Masahiro Yamada
/source_file_format.rst
[flat-image-tree]
https://github.com/open-source-firmware/flat-image-tree/blob/v0.8/source/chapter1-introduction.rst
https://github.com/open-source-firmware/flat-image-tree/blob/v0.8/source/chapter2-source-file-format.rst
--
Best Regards
Masahiro Yamada
hitecture specific'
finds similar patterns, but presumably we are not
keen on fixing them tree-wide.
--
Best Regards
Masahiro Yamada
.lib
> index 68d0134bdbf9..4e4364ad641a 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -487,14 +487,26 @@ UIMAGE_OPTS-y ?=
> UIMAGE_TYPE ?= kernel
> UIMAGE_LOADADDR ?= arch_must_set_this
> UIMAGE_ENTRYADDR ?= $(UIMAGE_LOADADDR)
> -UIMAGE_NAME ?= 'Linux-$(KERNELRELEASE)'
> +UIMAGE_NAME ?= "Linux-$(KERNELRELEASE)"
Unneeded noise change.
--
Best Regards
Masahiro Yamada
On Mon, Sep 25, 2023 at 1:24 PM Vignesh Raghavendra wrote:
>
> Hi Masahiro,
>
> On 21/09/23 20:33, Masahiro Yamada wrote:
> > Hi.
> [...]
>
> > spl: mmc boot mode: fs
> > Found FIT
> > Error reading cluster
> > fit read sector 0, sectors=985528, ds
On Mon, Sep 25, 2023 at 1:28 PM Vignesh Raghavendra wrote:
>
> Hi,
>
> On 21/09/23 21:52, Masahiro Yamada wrote:
> > On Fri, Sep 22, 2023 at 12:03 AM Masahiro Yamada
> > wrote:
> >>
> >> Hi.
> >>
> >> I am seeing a boot failure
On Fri, Sep 22, 2023 at 5:04 PM Neha Malcom Francis wrote:
>
> Hi Masahiro
>
> On 22/09/23 12:48, Masahiro Yamada wrote:
> > On Fri, Sep 22, 2023 at 2:27 PM Neha Malcom Francis
> > wrote:
> >>
> >> Hi Masahiro
> >>
> >> On 21/09/
On Fri, Sep 22, 2023 at 2:27 PM Neha Malcom Francis wrote:
>
> Hi Masahiro
>
> On 21/09/23 21:06, Masahiro Yamada wrote:
> > Hi.
> >
> > Since the TI platform migrated to binman,
> > u-boot.img is built twice.
> >
> > It is created by "mkimag
On Fri, Sep 22, 2023 at 12:03 AM Masahiro Yamada wrote:
>
> Hi.
>
> I am seeing a boot failure on AM64-SK.
>
>
> I got the following error in SPL of the main core.
> Do you have any clue?
As a side-topic, I downloaded a prebuilt image
from https://www.ti.com/too
u-boot.img
=> u-boot and dt are embedded.
$ fdtdump u-boot.img.backup
=> u-boot and dt are appended after the
FIT structure
--
Best Regards
Masahiro Yamada
nux-gnu- \
BINMAN_INDIRS="${STAGE}/ti-linux-firmware" \
BL31="${STAGE}/bl31.bin" \
TEE="${STAGE}/tee-raw.bin" \
all
cp build-main/tispl.bin build-main/u-boot.img "${STAGE}"
Strangely, AM62-SK booted successfully,
but AM64-SK failed.
I do not know why.
--
Best Regards
Masahiro Yamada
On Thu, Jun 22, 2023 at 3:41 AM Tom Rini wrote:
>
> On Tue, Jun 06, 2023 at 08:37:42PM +0900, Masahiro Yamada wrote:
>
> > This function is not used by anyone.
> >
> > Signed-off-by: Masahiro Yamada
> > Reviewed-by: Simon Glass
>
> Applied to u-boot/nex
This function is not used by anyone.
Signed-off-by: Masahiro Yamada
---
common/stdio.c | 8
include/stdio_dev.h | 7 ---
2 files changed, 15 deletions(-)
diff --git a/common/stdio.c b/common/stdio.c
index cbedfdda53..894cbd3fb4 100644
--- a/common/stdio.c
+++ b/common
e optional if it does not make the code too ugly.
But, if you do not add CONFIG_MODULES in your Kconfig file,
users will not see 'm' in the first place.
I know some help messages still mention 'm', but is this the problem
you want to solve?
> And as Simon asked in the thread, what about code refactoring that makes
> further maintenance easier? Clearly, such patches would need to be
> against the current appropriate tree.
If such patches clean up the code, they will be appreciated.
--
Best Regards
Masahiro Yamada
Hi Simon,
On Mon, Feb 27, 2023 at 1:00 PM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sun, 26 Feb 2023 at 20:36, Masahiro Yamada wrote:
> >
> > Hi Simon,
> >
> > On Mon, Feb 27, 2023 at 4:23 AM Simon Glass wrote:
> > >
> > > Hi Masahiro,
>
Hi Simon,
On Mon, Feb 27, 2023 at 4:23 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sun, 26 Feb 2023 at 10:36, Masahiro Yamada wrote:
> >
> > On Sun, Feb 26, 2023 at 11:44 PM Tom Rini wrote:
> > >
> > > On Sun, Feb 26, 2023 at 11:32:03PM +0900, Mas
On Sun, Feb 26, 2023 at 11:44 PM Tom Rini wrote:
>
> On Sun, Feb 26, 2023 at 11:32:03PM +0900, Masahiro Yamada wrote:
> > On Sun, Feb 26, 2023 at 11:04 PM Simon Glass wrote:
> > >
> > > Hi Masahiro,
> > >
> > > On Sat, 25 Feb 2023 at 20:31, Masah
On Sun, Feb 26, 2023 at 11:04 PM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sat, 25 Feb 2023 at 20:31, Masahiro Yamada wrote:
> >
> > On Sat, Feb 25, 2023 at 11:38 AM Simon Glass wrote:
> > >
> > > +Masahiro Yamada
> >
> >
> >
> &
On Sat, Feb 25, 2023 at 11:38 AM Simon Glass wrote:
>
> +Masahiro Yamada
I do not know.
This seems a shorthand in Kconfig level.
masahiro@zoe:~/ref/u-boot(master)$ rgrep '^config SPL_' | wc
5401080 24872
masahiro@zoe:~/ref/u-boot(master)$ rgrep '^config TPL_' | wc
163
On Tue, Oct 11, 2022 at 11:16 PM Simon Glass wrote:
>
> This is required for if_changed to work correctly. Add it.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Pali Rohár
> ---
>
> (no changes since v1)
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
is set to 'y',
> >* abc if CONFIG_SPL_BUILD is undefined and CONFIG_FOO is set to 'y',
> >* abc if CONFIG_SPL_BUILD is defined and CONFIG_SPL_FOO is set to 'y',
> >* abc if CONFIG_TPL_BUILD is defined and CONFIG_TPL_FOO is set to 'y',
> >* nothing otherwise.
> >*
> >* CONFIG_IS_ENABLED(FOO, (abc), (def)) expands to
> > + * abc if USE_HOSTCC is defined and CONFIG_TOOLS_FOO is set to 'y',
> >* abc if CONFIG_SPL_BUILD is undefined and CONFIG_FOO is set to 'y',
> >* abc if CONFIG_SPL_BUILD is defined and CONFIG_SPL_FOO is set to 'y',
> >* abc if CONFIG_TPL_BUILD is defined and CONFIG_TPL_FOO is set to 'y',
> >
--
Best Regards
Masahiro Yamada
s adding
the objects to the 'targets'.
Somebody had broken the build system?
--
Best Regards
Masahiro Yamada
I am leaving Socionext. Orphan the UniPhier platform until somebody
takes the role.
Signed-off-by: Masahiro Yamada
---
MAINTAINERS | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index bebe87b4d1..101f4e185d 100644
--- a/MAINTAINERS
+++ b
)
UniPhier SoC updates for v2020.10 (2nd)
- minor code cleanups
- sync DT with Linux
Masahiro Yamada (6):
ARM: uniphier: rename include guard of include/configs/uniphier.h
ARM: uniphier: remove unused
Signed-off-by: Masahiro Yamada
---
arch/arm/dts/uniphier-ld11-global.dts | 2 +-
arch/arm/dts/uniphier-ld11-ref.dts | 8 +-
arch/arm/dts/uniphier-ld20-global.dts | 2 +-
arch/arm/dts/uniphier-ld20-ref.dts | 8 +-
arch/arm/dts/uniphier-ld20.dtsi | 2 +
arch/arm
ran the following semantic patch
excluding include/dm/.
@@
type T;
expression dev;
@@
-(T *)devfdt_get_addr_ptr(dev)
+dev_read_addr_ptr(dev)
@@
expression dev;
@@
-devfdt_get_addr_ptr(dev)
+dev_read_addr_ptr(dev)
Signed-off-by: Masahiro Yamada
---
drivers/clk/aspeed
It is strange to use devfdt_get_addr_ptr(), then cast the pointer
back to uint32 because you could use devfdt_get_addr() without casting.
Convert it to dev_read_addr(), which is capable to CONFIG_OF_LIVE.
Signed-off-by: Masahiro Yamada
---
drivers/gpio/at91_gpio.c | 2 +-
1 file changed, 1
It is strange to use devfdt_get_addr_ptr(), then cast the pointer
back to ulong because you could use devfdt_get_addr() without casting.
Convert it to dev_read_addr(), which is capable to CONFIG_OF_LIVE.
Signed-off-by: Masahiro Yamada
---
drivers/ata/ahci_mvebu.c | 2 +-
1 file changed, 1
Make the include guard match to the file name.
Signed-off-by: Masahiro Yamada
---
include/configs/uniphier.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/uniphier.h b/include/configs/uniphier.h
index d0841a7d55f9..1b942cf657db 100644
--- a/include
is unneeded since commit 9248a78f40d6 ("ARM: UniPhier: remove
Denali NAND controller fixup code").
is uneeded since commit 1320fa2e55d2 ("ARM: uniphier:
remove workaround for the NAND write protect").
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/board_la
Define register fields as macros, and use FIELD_GET().
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/sg-regs.h | 5 +
arch/arm/mach-uniphier/soc-info.c | 21 ++---
2 files changed, 15 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach-uniphier/sg
This function is unused since commit 862274913f8f ("bus:
uniphier-system-bus: move hardware init from board files").
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Makefile | 1 -
arch/arm/mach-uniphier/init.h | 1 -
arch/arm/mach-uniphier/pinctrl-g
Signed-off-by: Masahiro Yamada
---
drivers/serial/serial_uniphier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/serial/serial_uniphier.c b/drivers/serial/serial_uniphier.c
index 4004cb8d48a4..a098028ca001 100644
--- a/drivers/serial/serial_uniphier.c
+++ b
q = p;
> while (isalnum(*q) || *q == '_')
> q++;
> r = q;
> --
> 2.25.1
>
Sorry, I missed this patch.
Yes, this fixes the bug. Thanks.
Just a nit about the coding style:
There are two spaces after 'q'.
--
Best Regards
Masahiro Yamada
-name '*.[ch]' -type f -print | \
xargs sed -i -e 's/([^*)]*\*)devfdt_get_addr(/dev_read_addr_ptr(/'
I manually fixed drivers/usb/host/ehci-mx6.c
Signed-off-by: Masahiro Yamada
---
drivers/adc/exynos-adc.c| 2 +-
drivers/clk/renesas/clk-rcar-gen2.c | 2 +-
drive
This cast is unneeded.
Signed-off-by: Masahiro Yamada
---
drivers/net/fec_mxc.c | 2 +-
drivers/net/fsl_mcdmafec.c| 2 +-
drivers/net/mcffec.c | 2 +-
drivers/net/xilinx_axi_emac.c | 2 +-
drivers/net/xilinx_emaclite.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions
(dev)
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-snapdragon/clock-snapdragon.c | 2 +-
arch/arm/mach-snapdragon/pinctrl-snapdragon.c| 2 +-
drivers/ata/dwc_ahci.c | 2 +-
drivers/clk/altera/clk-agilex.c | 2 +-
drivers/clk/altera/clk
Currently, fdt_fixup_mtdparts() only checks the compatible property.
It is pointless to fix up the disabled node.
Skip the node if it has the property:
status = "disabled"
Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass
---
(no changes since v1)
common/fdt_supp
().
Signed-off-by: Masahiro Yamada
Reviewed-by: Simon Glass
---
Changes in v2:
- rename 'initialized' to 'inited'
common/fdt_support.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index 3778de5368..cf09c3c5fb 100644
On Fri, Jul 17, 2020 at 12:44 AM Simon Glass wrote:
>
> On Wed, 15 Jul 2020 at 04:57, Masahiro Yamada
> wrote:
> >
> > Currently, fdt_fixup_mtdparts() only checks the compatible property.
> > It is pointless to fix up the disabled node.
> >
> &g
Currently, fdt_fixup_mtdparts() only checks the compatible property.
It is pointless to fix up the disabled node.
Skip the node if it has the property:
status = "disabled"
Signed-off-by: Masahiro Yamada
---
common/fdt_support.c | 17 ++---
1 file changed, 10 insert
().
Signed-off-by: Masahiro Yamada
---
common/fdt_support.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index b010d0b552ad..717b2b6354c0 100644
--- a/common/fdt_support.c
+++ b/common/fdt_support.c
@@ -951,9 +951,7 @@ void
This function is only called from fdt_fixup_mtdpart() in the same file.
Signed-off-by: Masahiro Yamada
---
common/fdt_support.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/fdt_support.c b/common/fdt_support.c
index 3778de536866..b010d0b552ad 100644
Ley Foon Tan (2):
mtd: nand: raw: denali: Assert reset before deassert
mtd: nand: raw: denali: Wait for reset completion status
Masahiro Yamada (14):
Revert "ARM: uniphier: add weird workaround code for LD20"
ARM: uniphier: increase CONFIG_SYS_MONITOR_LEN to 2MB
On Thu, Jul 9, 2020 at 3:09 PM Masahiro Yamada
wrote:
>
> This reverts commit 45f41c134baf5ff1bbf59d33027f6c79884fa4d9.
>
> This weird workaround was the best I came up with at that time
> to boot U-Boot from TF-A.
>
> I noticed U-Boot successfully boots on LD20 (i.
On Fri, Jul 10, 2020 at 10:32 PM Masahiro Yamada
wrote:
>
> Now that commit fceee65c878c ("mtd: nand: raw: denali: Assert reset
> before deassert") added the reset assertion, this code in the board
> file is unneeded.
>
> Signed-off-by: Masahiro Yamada
>
On Fri, Jul 10, 2020 at 1:13 AM Masahiro Yamada
wrote:
>
> After all, I am not a big fan of using a structure to represent the
> hardware register map.
>
> You do not need to know the entire register map.
>
> Add only necessary register macros.
>
> Use FIELD_PREP() in
Now that commit fceee65c878c ("mtd: nand: raw: denali: Assert reset
before deassert") added the reset assertion, this code in the board
file is unneeded.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Makefile | 1 -
arch/arm/mach-uniphier/board_init.c | 4 ---
arc
has completed its reset and initialization process.
>
> Tested-by: Masahiro Yamada
> Signed-off-by: Radu Bacrau
> Signed-off-by: Ley Foon Tan
>
> ---
> v2:
> - Added "Tested-by" in commit message.
> - Restore "bootstrap process" in comment.
> ---
n
> (rst_comp) bit after reset.
>
> Tested-by: Masahiro Yamada
> Signed-off-by: Radu Bacrau
> Signed-off-by: Ley Foon Tan
I will include this in my next pull request.
Applied.
Thanks.
--
Best Regards
Masahiro Yamada
et: %d\n", ret);
> } else {
> + reset_assert_bulk();
> + udelay(2);
> reset_deassert_bulk();
>
> /*
Tested-by: Masahiro Yamada
--
Best Regards
Masahiro Yamada
> - udelay(200);
> + ret = denali_wait_reset_complete(denali);
> + if (ret) {
> + dev_err(denali->dev, "reset not completed.\n");
> + return ret;
> + }
> }
>
> return denali_init(denali);
> --
> 2.19.0
>
I tested this patch on some of my socionext SoC boards,
and I did not see regression.
Tested-by: Masahiro Yamada
But, please note this code will diverge from the Linux code.
--
Best Regards
Masahiro Yamada
After all, I am not a big fan of using a structure to represent the
hardware register map.
You do not need to know the entire register map.
Add only necessary register macros.
Use FIELD_PREP() instead of maintaining a pair of shift and mask.
Signed-off-by: Masahiro Yamada
---
drivers/serial
Ensure the transmitter is empty when chaining the baudrate or any
hardware settings. If a character is remaining in the transmitter,
the console will be garbled.
Signed-off-by: Masahiro Yamada
---
drivers/serial/serial_uniphier.c | 8
1 file changed, 8 insertions(+)
diff --git
This UART controller is integrated with a FIFO. Enable it.
You can put the next character into the FIFO while the transmitter
is sending out the current character. This works slightly faster.
Signed-off-by: Masahiro Yamada
---
drivers/serial/serial_uniphier.c | 7 +++
1 file changed, 7
R_LEN even more, the SPL stack must be
moved somewhere. I put it back to the original location prior to
commit 3ce5b1a8d86d.
With this change, there is no more practical size limit.
Signed-off-by: Masahiro Yamada
---
include/configs/uniphier.h | 4 ++--
1 file changed, 2 insertions(+), 2 dele
I actually do not see this used these days because eMMC or NAND is used
for non-volatile devices. Dump the burden to maintain this crappy code.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/board_init.c | 4 -
arch/arm/mach-uniphier/micro-support-card.c | 97
Now that this directory contains only uniphier_sbc_boot_is_swapped(),
move it to boot-device.c and delete the sbc/ directory entirely.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Makefile | 1 -
arch/arm/mach-uniphier/boot-device/boot-device.c | 9
This was used by the old sLD3 SoC, the support of which was removed
by commit 00aa453ebf56 ("ARM: uniphier: remove sLD3 SoC support").
There is no more user of this function.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/init.h| 5 -
arch/arm/mach-uniphier/sbc/
e settings to the this driver).
I put this to drivers/bus/uniphier-system-bus.c because this is the
same path as the driver in Linux kernel.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Kconfig| 1 +
drivers/Kconfig | 2 ++
drivers/Makefile | 1 +
d
Signed-off-by: Masahiro Yamada
---
arch/arm/dts/uniphier-ld11-global.dts | 1 +
arch/arm/dts/uniphier-ld11-ref.dts| 1 +
arch/arm/dts/uniphier-ld11.dtsi | 16 +++-
arch/arm/dts/uniphier-ld20-global.dts | 1 +
arch/arm/dts/uniphier-ld20-ref.dts| 1 +
arch/arm/dts/uniphier
Move the bus initialization code to this driver from board files.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/board_init.c | 12 --
arch/arm/mach-uniphier/init.h | 23 ---
arch/arm/mach-uniphier/micro-support-card.c | 13 +-
arch/arm/mach-uniphier/sbc
CONFIG_SPL=y.
Instead of using crappy CONFIG options, checking SPL and SPL_TEXT_BASE
is cleaner.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/Kconfig | 33 +
configs/uniphier_ld4_sld8_defconfig | 1 -
2 files changed, 15 insertions(+), 19 deletions
If CONFIG_MICRO_SUPPORT_CARD is unset, the build fails due to
function redefinition.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/sbc/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-uniphier/sbc/Makefile
b/arch/arm/mach-uniphier/sbc/Makefile
index
at EL2
instead of EL1, and this issue went away as a side-effect.
|commit f998a052fd94ea082833109f25b94ed5bfa24e8b
|Author: Masahiro Yamada
|Date: Thu Jul 25 10:57:38 2019 +0900
|
|uniphier: run BL33 at EL2
|
|All the SoCs in 64-bit UniPhier SoC family support EL2.
|
|Just hard-code
On Mon, Jul 6, 2020 at 1:33 PM Masahiro Yamada
wrote:
>
> Hi.
>
> On Mon, Jun 29, 2020 at 12:29 AM Masahiro Yamada wrote:
> >
> > On Wed, Jun 24, 2020 at 11:07 AM Volodymyr Babchuk
> > wrote:
> > >
> > > ARM Architecture reference manual clearly
Simon,
On Tue, Jul 7, 2020 at 3:44 AM Simon Glass wrote:
>
> Hi Masahiro,
>
> On Sat, 4 Jul 2020 at 11:43, Masahiro Yamada wrote:
> >
> > 'git grep' did not find any user of this stub.
> >
> > Signed-off-by: Masahiro Yamada
> > ---
> >
> >
Hi.
On Mon, Jun 29, 2020 at 12:29 AM Masahiro Yamada wrote:
>
> On Wed, Jun 24, 2020 at 11:07 AM Volodymyr Babchuk
> wrote:
> >
> > ARM Architecture reference manual clearly states that PE pipeline
> > should be flushed after any change to system registers. Refer to
&
at EL2
instead of EL1, and this issue does not happen:
|commit f998a052fd94ea082833109f25b94ed5bfa24e8b
|Author: Masahiro Yamada
|Date: Thu Jul 25 10:57:38 2019 +0900
|
|uniphier: run BL33 at EL2
|
|All the SoCs in 64-bit UniPhier SoC family support EL2.
|
|Just hard-code MODE_EL2
'git grep' did not find any user of this stub.
Signed-off-by: Masahiro Yamada
---
arch/x86/include/asm/u-boot-x86.h | 2 --
arch/x86/lib/zimage.c | 10 --
2 files changed, 12 deletions(-)
diff --git a/arch/x86/include/asm/u-boot-x86.h
b/arch/x86/include/asm/u-boot-x86.h
hand to test this.
(I do not commute to the office due to COVID-19 these days...)
I have another SoC board, but it does not integrate CA72.
I have ever seen this problem only on CA72.
Eventually, I will go to the office, and I can test this.
But, you do not need to wait for my test if other peopl
All the users of bd_t were converted to struct bd_info.
Remove the definitions.
Signed-off-by: Masahiro Yamada
---
arch/nds32/include/asm/u-boot.h | 5 ++---
arch/riscv/include/asm/u-boot.h | 5 ++---
include/asm-generic/u-boot.h| 4 ++--
3 files changed, 6 insertions(+), 8 deletions
Some code was not converted by coccinelle, somehow.
I manually fixed up the remaining, and comments, README docs.
Signed-off-by: Masahiro Yamada
---
arch/m68k/cpu/mcf523x/cpu.c | 2 +-
arch/m68k/cpu/mcf52x2/cpu.c | 2 +-
arch/m68k/cpu/mcf532x/cpu.c | 2 +-
arch/m68k/cpu
for Denali NAND driver
- Clean up include directives
- Migrate to DM_ETH, and remove legacy board_eth_init()
Masahiro Yamada (9):
mtd: rawnand: denali: configure SPARE_AREA_SKIP_BYTES only for denali_spl
ARM: uniphier
_ignored, val, ...) val
> +
> +/* Evaluates to 0 if option is not defined, int_option if it is defined */
> +#define IF_ENABLED_INT(option, int_option) \
> + config_opt_enabled(option, int_option)
> +
> /*
> * CONFIG_IS_ENABLED(FOO) evaluates to
> * 1 if CONFIG_SPL_BUILD is undefined and CONFIG_FOO is set to 'y' or 'm',
> --
> 2.27.0.rc0.183.gde8f92d652-goog
>
--
Best Regards
Masahiro Yamada
ues.
>
> Unfortunately, i am not a Makefile "expert", can anybody have a look at it ?
>
> Thanks
>
> Patrice
--
Best Regards
Masahiro Yamada
On Wed, May 20, 2020 at 12:09 PM Simon Glass wrote:
>
> HI Masahiro,
>
> On Tue, 19 May 2020 at 20:44, Masahiro Yamada
> wrote:
> >
> > arch/arm/include/asm/system.h declares psci_arch_init(), but it is
> > surrounded by #ifdef CONFIG_ARMV8_PSCI.
&
pulls in a lot of bloat. is unneeded in most of
places.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/arm32/cache-uniphier.c | 1 -
arch/arm/mach-uniphier/arm32/psci.c | 1 -
arch/arm/mach-uniphier/arm32/timer.c | 2 +-
arch/arm/mach
e.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/dram/umc-pxs2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-uniphier/dram/umc-pxs2.c
b/arch/arm/mach-uniphier/dram/umc-pxs2.c
index 3f7e5f30ba..24c6802a27 100644
--- a/arch/arm/mach-uniphier/dram/umc-pxs2.c
+++
ific cache functions, uniphier_cache_*() are
declared in cache-uniphier.h, which is already included from this file.
Including is sensible to fix the -Wmissing-prototypes
warnings because this file defines psci_cpu_on and psci_system_reset().
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/ar
This platform completely migrated to CONFIG_DM_ETH.
board_eth_init() is only called from net/eth_legacy.c
Remove the legacy hook.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/micro-support-card.c | 12
1 file changed, 12 deletions(-)
diff --git a/arch/arm/mach
I do not understand the changes made to these files by
commit f7ae49fc4f36 ("common: Drop log.h from common header").
git show f7ae49fc4f36 -- arch/arm/mach-uniphier/
None of them uses the log function feature.
Simply revert the changes made to these files.
Signed-off-by: Masah
, but I do not understand the
motivation of doing so, either.
Simply revert the changes made to this file.
Signed-off-by: Masahiro Yamada
---
arch/arm/mach-uniphier/micro-support-card.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-uniphier/micro-support-card.c
arch/arm/include/asm/system.h declares psci_arch_init(), but it is
surrounded by #ifdef CONFIG_ARMV8_PSCI.
psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing
function declaration.
Signed-off-by: Masahiro Yamada
---
arch/arm/include/asm/system.h | 1 +
1 file changed, 1
1 - 100 of 6324 matches
Mail list logo
