Re: [PATCH] fvp: Add support for loading Android boot images via semihosting

2020-04-06 Thread Ryan Harkin
On Mon, 6 Apr 2020 at 19:25, Peter Collingbourne wrote: > On Mon, Apr 6, 2020 at 10:40 AM Ryan Harkin > wrote: > >> Hi Peter, >> >> This looks good to me, but I have a quick question below. >> >> On Sat, 4 Apr 2020 at 03:58, Peter Collingbourne wrote: >

[U-Boot] [PATCH] Revert "vexpress64: fvp dram: add DRAM configuration"

2019-08-27 Thread Ryan Harkin
This reverts commit fc04b923541d984b1544056fd3bfa8129d4e5aac where the FVP DRAM configuration was added. Signed-off-by: Ryan Harkin --- arch/arm/Kconfig | 10 --- board/armltd/vexpress64/Kconfig| 2 +- board/armltd/vexpress64/MAINTAINERS| 5 configs

Re: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

2019-08-22 Thread Ryan Harkin
On Thu, 22 Aug 2019 at 13:10, Sudeep Holla wrote: > On Thu, Aug 22, 2019 at 12:38:31PM +0100, Ryan Harkin wrote: > > On Thu, 22 Aug 2019 at 02:25, Peng Fan wrote: > > > > > > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace > ear

Re: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon

2019-08-22 Thread Ryan Harkin
On Thu, 22 Aug 2019 at 02:25, Peng Fan wrote: > > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk > > with earlycon > > > > earlyprintk no longer works on arm64 platforms. Replace it with earlycon > > which works fine. > > > > Cc

Re: [U-Boot] [PATCH 0/2] Fix CAAM for TrustZone enable for warp7

2018-01-24 Thread Ryan Harkin
[1] Thanks for all of your help BTW - Peng, there's no way this would be > working without you giving direction on how. > > Bryan O'Donoghue (2): > drivers/crypto/fsl: assign job-rings to non-TrustZone > warp7 : run sec_init for CAAM RNG > This series: Tested-b

Re: [U-Boot] [PATCH 1/2] serial: mxc: support DTE mode

2018-01-22 Thread Ryan Harkin
Hi Simon, On 22 January 2018 at 00:29, Simon Glass wrote: > Hi Ryan, > > On 19 January 2018 at 06:21, Ryan Harkin wrote: > > Hi Stefan, > > > > Thanks for looking so quickly. > > > > On 19 January 2018 at 12:23, Stefan Agner > wrote: > >> >

Re: [U-Boot] [PATCH 1/2] serial: mxc: support DTE mode

2018-01-19 Thread Ryan Harkin
Hi Stefan, Thanks for looking so quickly. On 19 January 2018 at 12:23, Stefan Agner wrote: > Hi Ryan, > > > On 19.01.2018 10:53, Ryan Harkin wrote: > > Add DTE mode support via Kconfig on the MXC uart. > > Make use of the driver model, there DTE is supporte

[U-Boot] [PATCH 2/2] warp7: add support for console on UART6 and mikroBus

2018-01-19 Thread Ryan Harkin
Add support to route the serial console on the NXP WaRP7 board to UART6 and the mikroBus. To use UART6 on the WaRP7 board, I add the following lines to configs/warp7_defconfig: +CONFIG_MXC_CONSOLE_NUM=6 +CONFIG_SERIAL_MXC_DTE_MODE=y Signed-off-by: Ryan Harkin Reviewed-by: Bryan O'Don

[U-Boot] [PATCH 1/2] serial: mxc: support DTE mode

2018-01-19 Thread Ryan Harkin
Add DTE mode support via Kconfig on the MXC uart. Signed-off-by: Ryan Harkin Reviewed-by: Bryan O'Donoghue --- drivers/serial/Kconfig | 7 +++ drivers/serial/serial_mxc.c | 10 -- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/serial/Kconfig b/dr

[U-Boot] [PATCH 0/2] warp7: add UART6 support

2018-01-19 Thread Ryan Harkin
This small series adds support for using the console on UART6 on the WaRP7 board. The board retains current functionality: UART6 is not used by default and needs it needs to be enabled in defconfig. [PATCH 1/2] serial: mxc: support DTE mode [PATCH 2/2] warp7: add support for console on UART6 and

[U-Boot] [PATCH] do_smhload: fix return code

2017-03-02 Thread Ryan Harkin
, rather than the enumeration CMD_RET_FAILURE (which is also 1). Signed-off-by: Ryan Harkin --- arch/arm/lib/semihosting.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/lib/semihosting.c b/arch/arm/lib/semihosting.c index e32ad90..415ac89 100644 --- a/arch/arm/lib

Re: [U-Boot] [PATCH v3] cmd: move CONFIG_CMD_UNZIP and CONFIG_CMD_ZIP to Kconfig

2017-02-06 Thread Ryan Harkin
platform. > > Signed-off-by: Masahiro Yamada > Acked-by: Michal Simek > Acked-by: Stefan Roese Acked-by: Ryan Harkin Tested-by: Ryan Harkin Tested on TC2, FVP Foundation and AEMv8 models and Juno R0, R1 and R2. > --- > > Changes in v3: > - Fix a typo in Kconf

Re: [U-Boot] [PATCH v2] armv8: aarch64: Fix the warning about x1-x3 nonzero issue

2017-01-16 Thread Ryan Harkin
_el2 and armv8_switch_to_el1. The input argument 4 will >> be set to the right value, such as zero. >> >> Signed-off-by: Alison Wang Thanks Alison, this removes the warning for me now and still boots fine. I tested with Juno R0/1/2 and FVP Foundation and AEMv8 models. Tested-b

Re: [U-Boot] [RFC PATCH] arm: bootm: Boot kernel with U-Boot's FDT blob

2017-01-13 Thread Ryan Harkin
On 13 January 2017 at 14:19, Mark Rutland wrote: > On Thu, Jan 12, 2017 at 01:47:32PM +0000, Ryan Harkin wrote: >> On 12 January 2017 at 12:25, Mark Rutland wrote: >> > On Tue, Jan 10, 2017 at 06:50:19PM +, Jon Medhurst (Tixy) wrote: >> >> On Tue, 2017-01-1

Re: [U-Boot] [PATCH] armv8: aarch64: Fix the warning about x1-x3 nonzero issue

2017-01-13 Thread Ryan Harkin
Hi Alison, I'll wait for a new version based on Alex's feedback before I test. The change looks like it should work, so I'm happy to wait, unless you feel thjere is a need to test it sooner. Thanks for the quick response. Regards, Ryan. On 13 Jan 2017 08:16, "Alison Wang" wrote: Hi, Ryan,

Re: [U-Boot] [RFC PATCH] arm: bootm: Boot kernel with U-Boot's FDT blob

2017-01-12 Thread Ryan Harkin
On 12 January 2017 at 12:25, Mark Rutland wrote: > On Tue, Jan 10, 2017 at 06:50:19PM +, Jon Medhurst (Tixy) wrote: >> On Tue, 2017-01-10 at 18:34 +, Mark Rutland wrote: >> > Looking at the git log for arch/arm64/boot/dts/arm, most updates are >> > simply adding new descriptions, so a DTB

Re: [U-Boot] [PATCH v8 1/3] armv8: Support loading 32-bit OS in AArch32 execution state

2017-01-11 Thread Ryan Harkin
Hi Alison, I wasn't sure where about in this thread to reply to this patch, so I thought here was as good as any... I know I tested this commit and it works for me. However, my colleague Tixy has spotted a recent warning on the kernel dmesg output that only arrived with an update to u-boot: [

Re: [U-Boot] [RFC PATCH] arm: bootm: Boot kernel with U-Boot's FDT blob

2017-01-10 Thread Ryan Harkin
On 10 January 2017 at 16:58, Alexander Graf wrote: > On 01/10/2017 05:47 PM, Ryan Harkin wrote: >> >> On 10 January 2017 at 16:35, Alexander Graf wrote: >>> >>> On 01/10/2017 05:31 PM, york sun wrote: >>>> >>>> On 01/10/2017 05:02 AM,

Re: [U-Boot] [RFC PATCH] arm: bootm: Boot kernel with U-Boot's FDT blob

2017-01-10 Thread Ryan Harkin
On 10 January 2017 at 16:35, Alexander Graf wrote: > On 01/10/2017 05:31 PM, york sun wrote: >> >> On 01/10/2017 05:02 AM, Alexander Graf wrote: >>> >>> On 01/10/2017 01:58 PM, Michal Simek wrote: U-Boot configured via DTB can use the same DTB for booting the kernel. When OF_CONTROL

Re: [U-Boot] [RFC PACH v2 1/1] Add vexpress_aemv8a_aarch32 variant

2016-12-05 Thread Ryan Harkin
Hi Tom, On 5 December 2016 at 17:13, Tom Rini wrote: > On Mon, Dec 05, 2016 at 04:11:45PM +0000, Ryan Harkin wrote: > >> The ARM AEMv8 FVP model can be run in Aarch64 or Aarch32 mode. Aarch32 >> support is enable per-CPU when launching the model, eg: >> >> -C clust

[U-Boot] [RFC PACH v2 1/1] Add vexpress_aemv8a_aarch32 variant

2016-12-05 Thread Ryan Harkin
. Signed-off-by: Ryan Harkin --- Changes since v1: This single patch replaces my earlier RFC series of two patches, where the first modified generic code and the other added a new variant. After Tom's suggestion that I review the Raspberry PI code, my original [RFC PATCH 1/2] has been dr

Re: [U-Boot] [RFC PATCH 0/2] ARMv8 Aarch32 support

2016-12-05 Thread Ryan Harkin
On 5 December 2016 at 15:14, Andre Przywara wrote: > Hi, > > On 02/12/16 19:20, Tom Rini wrote: >> On Fri, Dec 02, 2016 at 04:25:37PM +0000, Ryan Harkin wrote: >>> On 2 December 2016 at 15:41, Tom Rini wrote: >>>> On Fri, Dec 02, 2016 at 11:51:07AM +, Rya

Re: [U-Boot] [RFC PATCH 0/2] ARMv8 Aarch32 support

2016-12-02 Thread Ryan Harkin
On 2 Dec 2016 19:20, "Tom Rini" wrote: > > On Fri, Dec 02, 2016 at 04:25:37PM +0000, Ryan Harkin wrote: > > On 2 December 2016 at 15:41, Tom Rini wrote: > > > On Fri, Dec 02, 2016 at 11:51:07AM +, Ryan Harkin wrote: > > > > > >> I'

Re: [U-Boot] [RFC PATCH 0/2] ARMv8 Aarch32 support

2016-12-02 Thread Ryan Harkin
On 2 December 2016 at 15:41, Tom Rini wrote: > On Fri, Dec 02, 2016 at 11:51:07AM +0000, Ryan Harkin wrote: > >> I've been working with Soby Mathew to get U-Boot booting on ARM's >> AEMv8 FVP model in Aarch32 mode. >> >> Soby worked out what needed to

[U-Boot] [RFC PATCH 1/2] Add Aarch32 option for ARMv8 CPUs

2016-12-02 Thread Ryan Harkin
core. This patch is co-authored with Soby Mathew . Signed-off-by: Ryan Harkin --- Makefile | 5 + arch/arm/Kconfig | 6 ++ arch/arm/cpu/armv7/virt-v7.c | 2 ++ arch/arm/cpu/armv8/u-boot-spl.lds | 5 + arch/arm/cpu/armv8/u-boot.lds

[U-Boot] [RFC PATCH 2/2] Add vexpress_aemv8a_aarch32 variant

2016-12-02 Thread Ryan Harkin
. Signed-off-by: Ryan Harkin --- arch/arm/Kconfig | 10 ++ board/armltd/vexpress64/Kconfig | 2 +- configs/vexpress_aemv8a_aarch32_defconfig | 30 ++ include/configs/vexpress_aemv8a.h | 28 ++-- 4

[U-Boot] [RFC PATCH 0/2] ARMv8 Aarch32 support

2016-12-02 Thread Ryan Harkin
I've been working with Soby Mathew to get U-Boot booting on ARM's AEMv8 FVP model in Aarch32 mode. Soby worked out what needed to be changed and I'm refining the changes into patches that can be built for both Aarch64 and Aarch32 mode. There are two patches for discussion: [RFC PATCH 1/2] Add Aa

Re: [U-Boot] [PATCH] vexpress64: Juno: Change PCI buss addresses for IO to start from zero.

2016-11-22 Thread Ryan Harkin
On 22 November 2016 at 15:08, Tom Rini wrote: > On Tue, Nov 22, 2016 at 12:08:49PM +, Liviu Dudau wrote: >> On Tue, Nov 22, 2016 at 11:29:20AM +, Sudeep Holla wrote: >> > Hi Liviu, >> > >> > On Tue, Nov 22, 2016 at 11:19 AM, Liviu Dudau >> > wrote: >> > > Juno uses a 1:1 mapping between

Re: [U-Boot] [PATCH v8 0/3] armv8: Support loading 32-bit OS in AArch32 execution state

2016-11-11 Thread Ryan Harkin
atforms. But I checked and the patches are bisect-able on my ARMv8 platforms. Tested-by: Ryan Harkin > - Support loading 32-bit OS with PSCI enabled. > > Changes in v7: > - Move the call for armv8_switch_to_el2_m into the first patch. > > Changes in v6: > - Modified armv8_

Re: [U-Boot] [PATCH v7 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-11-07 Thread Ryan Harkin
t;> >> >>> On 04/11/2016 16:43, york sun wrote: >> >>>> On 11/04/2016 09:32 AM, Ryan Harkin wrote: >> >>>>>>> >> >>>>>>> Yes, with the attached patch on top of your original 2 patches, >> >>>>&

Re: [U-Boot] [PATCH v7 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-11-04 Thread Ryan Harkin
On 4 November 2016 at 15:53, Alexander Graf wrote: > > > On 04/11/2016 16:43, york sun wrote: >> >> On 11/04/2016 09:32 AM, Ryan Harkin wrote: >>>>> >>>>> >>>>> Yes, with the attached patch on top of your original 2 patches, &

Re: [U-Boot] [PATCH v7 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-11-04 Thread Ryan Harkin
On 4 November 2016 at 15:08, york sun wrote: > On 11/04/2016 05:34 AM, Ryan Harkin wrote: >> On 4 November 2016 at 09:20, Alison Wang wrote: >>>> On 4 November 2016 at 02:26, Alison Wang wrote: >>>>> York, >>>>> >>>>> >>

Re: [U-Boot] [PATCH v7 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-11-04 Thread Ryan Harkin
standard boot flow to make sure nothing is broken for me. > Thanks. >> >> Regards, >> Ryan. >> >> > >> > >> > >> > >> > Best Regards, >> > >> > Alison Wang >> > >> > >> > >> > From: yor

Re: [U-Boot] [PATCH v7 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-11-04 Thread Ryan Harkin
..@phytium.com.cn; mon...@monstr.eu; > thomas...@samsung.com; mk7.k...@samsung.com; u-boot@lists.denx.de; Jason Jin > ; Alison Wang > > > Subject: Re: [PATCH v7 1/2] armv8: Support loading 32-bit OS in AArch32 > execution state > > > > Alison, > > Does Ryan have yo

Re: [U-Boot] [PATCH v7 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-11-03 Thread Ryan Harkin
Hi York/Alison, Sorry for not having had time to look at this earlier. On 26 October 2016 at 17:54, york sun wrote: > On 10/07/2016 11:56 PM, Alison Wang wrote: >> To support loading a 32-bit OS, the execution state will change from >> AArch64 to AArch32 when jumping to kernel. >> >> The archit

Re: [U-Boot] [PATCH 2/3] cmd: booti: move CONFIG_CMD_BOOTI to Kconfig

2016-07-25 Thread Ryan Harkin
On 25 July 2016 at 14:42, Michal Simek wrote: > On 25.7.2016 15:06, Masahiro Yamada wrote: >> This command is used to boot ARM64 Linux. >> >> I made DISTRO_DEFAULTS select this option for ARM64 to respect >> include/config_distro_defaults.h. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> Kcon

Re: [U-Boot] [PATCH v5 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-07-07 Thread Ryan Harkin
On 7 July 2016 at 13:41, Alexander Graf wrote: > On 07/07/2016 02:35 PM, Ryan Harkin wrote: >> >> On 7 July 2016 at 13:30, Alexander Graf wrote: >>> >>> On 07/07/2016 02:16 PM, Ryan Harkin wrote: >>>> >>>> On 7 July 2016 at 07:30, Aliso

Re: [U-Boot] [PATCH v5 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-07-07 Thread Ryan Harkin
On 7 July 2016 at 13:30, Alexander Graf wrote: > On 07/07/2016 02:16 PM, Ryan Harkin wrote: >> >> On 7 July 2016 at 07:30, Alison Wang wrote: >>> >>> To support loading a 32-bit OS, the execution state will change from >>> AArch64 to AArch32 when j

Re: [U-Boot] [PATCH v5 1/2] armv8: Support loading 32-bit OS in AArch32 execution state

2016-07-07 Thread Ryan Harkin
On 7 July 2016 at 07:30, Alison Wang wrote: > To support loading a 32-bit OS, the execution state will change from > AArch64 to AArch32 when jumping to kernel. > > The architecture information will be got through checking FIT image, > then U-Boot will load 32-bit OS or 64-bit OS automatically. > >

Re: [U-Boot] [PATCH] armv8: Remove the codes about switching to EL1 before jumping to kernel

2016-07-07 Thread Ryan Harkin
thing still works for me with this change. I tested on FVP AEMv8 Base and FVP Foundation models and Juno R0, R1 and R2 development boards; booting BusyBox, OpenEmbedded (not on R0 or R2) and Android environments (not on R1). Tested-by: Ryan Harkin > --- > arch/arm/cpu/armv8/fsl-lay

Re: [U-Boot] [RFC PATCH] vexpress: Check TC2 firmware support before defaulting to nonsec booting

2016-06-28 Thread Ryan Harkin
On 23 June 2016 at 13:37, Jon Medhurst (Tixy) wrote: > The firmware on TC2 needs to be configured appropriately before booting > in nonsec mode will work as expected, so test for this and fall back to > sec mode if required. > > Signed-off-by: Jon Medhurst Reviewed-by: Ryan Ha

Re: [U-Boot] [PATCH] arm64: Juno/FVP: adjust kernel load address

2016-01-05 Thread Ryan Harkin
ig and I'm not set up to test semihosting. However, the DRAM config already has this change, so I'm confident it's the right thing to do. > Reviewed-by: Linus Walleij Tested-by: Ryan Harkin > > Yours, > Linus Walleij ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v2 4/4] vexpress64: store env in flash

2015-11-18 Thread Ryan Harkin
.fnameWrite=${FILENAME} Foundation models don't simulate the NOR flash, but having NOR support in the u-boot binary does not harm: attempting to write to the NOR will fail gracefully. Signed-off-by: Ryan Harkin Acked-by: Linus Walleij --- configs/vexpress_aemv8a_dram_defconfig | 1 - co

[U-Boot] [PATCH v2 1/4] vexpress64: compile Juno PCIe conditionally

2015-11-18 Thread Ryan Harkin
Only compile in PCIe support if the board really uses it. Provide a __weak stub for the init function if e.g. FVP is being built. Signed-off-by: Ryan Harkin Acked-by: Linus Walleij --- board/armltd/vexpress64/Makefile | 3 ++- board/armltd/vexpress64/pcie.c | 2 -- board/armltd

[U-Boot] [PATCH v2 3/4] vexpress64: remove #error

2015-11-18 Thread Ryan Harkin
Unknown board variant" #error "Unknown board variant" make[1]: *** [tools/envcrc.o] Error 1 make: *** [tools] Error 2 In file included from include/config.h:5:0, from tools/envcrc.c:19: Signed-off-by: Ryan Harkin Acked-by: Linus Walleij --- include/configs/vexpre

[U-Boot] [PATCH v2 2/4] vexpress64: use 2nd DRAM bank only on juno

2015-11-18 Thread Ryan Harkin
-by: Linus Walleij Reviewed-by: Ryan Harkin Tested-by: Ryan Harkin Unfortunately, I only fully tested on Juno R0, R1 and the FVP Foundation model. Whilst FVP Base AEMV8 models run U-Boot OK, they fail to boot the kernel. Signed-off-by: Ryan Harkin Acked-by: Liviu Dudau Reviewed-by

[U-Boot] [PATCH v2 0/4] vexpress64 fixes and NOR support

2015-11-18 Thread Ryan Harkin
This series is a rework or repost of a few patches to fix vexpress64 FVP support and to add NOR flash support to the boards that support it, namely, Juno and the FVP AEMv8 models. The FVP Foundation model does not simulate NOR flash, but will fail gracefully with this series. The first patch was o

Re: [U-Boot] [PATCH] vexpress64: compile Juno PCIe conditionally

2015-11-16 Thread Ryan Harkin
On 16 November 2015 at 18:03, Tom Rini wrote: > On Mon, Nov 16, 2015 at 09:46:55AM +0000, Ryan Harkin wrote: >> On 13 November 2015 at 13:39, Ryan Harkin wrote: >> > [trying again with Linus on the to: list] >> > >> > Hi Linus, >> > >> > T

Re: [U-Boot] [PATCH] vexpress64: compile Juno PCIe conditionally

2015-11-16 Thread Ryan Harkin
On 13 November 2015 at 13:39, Ryan Harkin wrote: > [trying again with Linus on the to: list] > > Hi Linus, > > Tom asked for a small change to your patch. Would mind having a look > and re-working? > > Thanks, > Ryan. > > On 21 October 2015 at 14:16, Ryan Harkin

Re: [U-Boot] [PATCH] Juno: don't print PCI debug information by default

2015-11-13 Thread Ryan Harkin
On 13 November 2015 at 11:25, Andre Przywara wrote: > On a Juno r1 the PCI controller init routine outputs the rather boring > ATR entry information. > Do this only with DEBUG defined to avoid cluttering the user's > terminal. Good idea. > > Signed-off-by: Andre Przywara

Re: [U-Boot] [PATCH] vexpress64: compile Juno PCIe conditionally

2015-11-13 Thread Ryan Harkin
[trying again with Linus on the to: list] Hi Linus, Tom asked for a small change to your patch. Would mind having a look and re-working? Thanks, Ryan. On 21 October 2015 at 14:16, Ryan Harkin wrote: > On 21 October 2015 at 13:50, Tom Rini wrote: >> On Wed, Oct 21, 2015 at 12:00:0

Re: [U-Boot] [PATCH] vexpress64: compile Juno PCIe conditionally

2015-11-13 Thread Ryan Harkin
Hi Linus, Tom asked for a small change to your patch. Would mind having a look and re-working? Thanks, Ryan. On 21 October 2015 at 14:16, Ryan Harkin wrote: > On 21 October 2015 at 13:50, Tom Rini wrote: >> On Wed, Oct 21, 2015 at 12:00:03PM +0100, Ryan Harkin wrote: >>>

Re: [U-Boot] [U-Boot, v2] vexpress64: use 2nd DRAM bank only on juno

2015-11-13 Thread Ryan Harkin
On 13 November 2015 at 13:25, Tom Rini wrote: > On Fri, Nov 13, 2015 at 08:26:31AM +0000, Ryan Harkin wrote: >> Hi Tom, >> >> Thanks for coming back to this. >> >> On 12 November 2015 at 20:58, Tom Rini wrote: >> > On Mon, Oct 26, 2015 at 11:00:22AM

Re: [U-Boot] [U-Boot, v2] vexpress64: use 2nd DRAM bank only on juno

2015-11-13 Thread Ryan Harkin
Hi Tom, Thanks for coming back to this. On 12 November 2015 at 20:58, Tom Rini wrote: > On Mon, Oct 26, 2015 at 11:00:22AM +0000, Ryan Harkin wrote: > >> This patch makes the 2nd DRAM bank available on Juno only and not on >> other vexpress64 targets, eg. the FVP models. >

Re: [U-Boot] [PATCH 2/3] vexpress64: remove #error

2015-11-11 Thread Ryan Harkin
v8a.h) to indicate that no board was set, correct? Tom> Correct. So if Juno wants to use the NOR flash and therefore, the host tools, then first we need this patch to remove the #error statements. Thanks, Ryan. On 27 October 2015 at 12:29, Ryan Harkin wrote: > On 27 October 2015 at 11:36

Re: [U-Boot] [PATCH v2] vexpress64: use 2nd DRAM bank only on juno

2015-11-11 Thread Ryan Harkin
Hi, This is just a ping in case this patch has been forgotten. It was Acked and Reviewed. Thanks, Ryan. On 27 October 2015 at 12:10, Linus Walleij wrote: > On Mon, Oct 26, 2015 at 12:00 PM, Ryan Harkin wrote: > >> This patch makes the 2nd DRAM bank available on Juno only and not

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-29 Thread Ryan Harkin
Hi Tom, On 28 October 2015 at 22:07, Tom Rini wrote: > On Wed, Oct 28, 2015 at 10:43:41PM +0100, Linus Walleij wrote: >> On Wed, Oct 28, 2015 at 5:06 PM, Ryan Harkin wrote: >> >> > For reasons I don't understand, envcrc.c includes config.h which >> > in

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-28 Thread Ryan Harkin
On 28 October 2015 at 15:10, Linus Walleij wrote: > On Wed, Oct 28, 2015 at 4:07 PM, Ryan Harkin wrote: >> On 27 October 2015 at 21:39, Linus Walleij wrote: >>> On Tue, Oct 27, 2015 at 1:49 PM, Ryan Harkin wrote: >>> >>>> Either way, AFAIK, the existi

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-28 Thread Ryan Harkin
On 27 October 2015 at 21:39, Linus Walleij wrote: > On Tue, Oct 27, 2015 at 1:49 PM, Ryan Harkin wrote: > >> Either way, AFAIK, the existing CFI code does not handle AFS support. >> I think the CFI code would need extending to write the footer if we >> wanted the afs co

Re: [U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-27 Thread Ryan Harkin
Hi Linus, On 27 October 2015 at 11:49, Linus Walleij wrote: > On Wed, Oct 21, 2015 at 11:54 AM, Ryan Harkin wrote: > >> Juno has 1 flash part with 259 sectors. The first 255 sectors are >> 0x4 (256kb) and are followed by 4 sectors of 0x1 (64KB). >> >>

Re: [U-Boot] [PATCH 2/3] vexpress64: remove #error

2015-10-27 Thread Ryan Harkin
On 27 October 2015 at 11:36, Linus Walleij wrote: > On Wed, Oct 21, 2015 at 11:54 AM, Ryan Harkin wrote: > >> This patch allows vexpress64 targets to be compiled when >> CONFIG_SYS_FLASH_CFI is enabled. > > I can't see what this has to do with enabling CFI? The er

[U-Boot] [PATCH v2] vexpress64: use 2nd DRAM bank only on juno

2015-10-26 Thread Ryan Harkin
-by: Linus Walleij Reviewed-by: Ryan Harkin Tested-by: Ryan Harkin Unfortunately, I only fully tested on Juno R0, R1 and the FVP Foundation model. Whilst FVP Base AEMV8 models run U-Boot OK, they fail to boot the kernel. Signed-off-by: Ryan Harkin Acked-by: Liviu Dudau --- board

Re: [U-Boot] [PATCH] vexpress64: use 2nd DRAM bank only on juno

2015-10-26 Thread Ryan Harkin
On 26 October 2015 at 10:18, Liviu Dudau wrote: > On Fri, Oct 23, 2015 at 04:47:04PM +0100, Ryan Harkin wrote: >> This patch makes the 2nd DRAM bank available on Juno only and not on >> other vexpress64 targets, eg. the FVP models. >> >> The commit below added a 2nd

[U-Boot] [PATCH] cfi_flash: use specific width types for cword

2015-10-23 Thread Ryan Harkin
. Similar problems also existed with the other cword sizes. Signed-off-by: Ryan Harkin --- drivers/mtd/cfi_flash.c | 82 - include/mtd/cfi_flash.h | 8 ++--- 2 files changed, 45 insertions(+), 45 deletions(-) diff --git a/drivers/mtd/cfi_flash.c b/

[U-Boot] [PATCH] vexpress64: use 2nd DRAM bank only on juno

2015-10-23 Thread Ryan Harkin
-by: Linus Walleij Reviewed-by: Ryan Harkin Tested-by: Ryan Harkin Unfortunately, I only fully tested on Juno R0, R1 and the FVP Foundation model. Whilst FVP Base AEMV8 models run U-Boot OK, they fail to boot the kernel. Signed-off-by: Ryan Harkin --- board/armltd/vexpress64

Re: [U-Boot] [PATCH 1/3] cfi_flash: use specific length types for cword

2015-10-21 Thread Ryan Harkin
On 21 October 2015 at 13:49, Ryan Harkin wrote: > On 21 October 2015 at 13:40, Stefan Roese wrote: >> Hi Ryan, >> >> On 21.10.2015 13:34, Ryan Harkin wrote: >>> >>> On 21 October 2015 at 11:24, Stefan Roese wrote: >>>> >>>

Re: [U-Boot] [PATCH] vexpress64: compile Juno PCIe conditionally

2015-10-21 Thread Ryan Harkin
On 21 October 2015 at 13:50, Tom Rini wrote: > On Wed, Oct 21, 2015 at 12:00:03PM +0100, Ryan Harkin wrote: >> On 20 October 2015 at 16:38, Tom Rini wrote: >> >> > On Tue, Oct 20, 2015 at 08:05:40AM +0200, Linus Walleij wrote: >> > >> > > Only compil

Re: [U-Boot] [PATCH 1/3] cfi_flash: use specific length types for cword

2015-10-21 Thread Ryan Harkin
On 21 October 2015 at 13:40, Stefan Roese wrote: > Hi Ryan, > > On 21.10.2015 13:34, Ryan Harkin wrote: >> >> On 21 October 2015 at 11:24, Stefan Roese wrote: >>> >>> Hi Ryan, >>> >>> On 21.10.2015 11:54, Ryan Harkin wrote: >>>>

Re: [U-Boot] [PATCH 1/3] cfi_flash: use specific length types for cword

2015-10-21 Thread Ryan Harkin
Hi Stefan, On 21 October 2015 at 11:24, Stefan Roese wrote: > Hi Ryan, > > On 21.10.2015 11:54, Ryan Harkin wrote: >> >> cword.l is an unsigned long int, but it is intended to be 32 bits long. >> >> Unfortunately, it's 64-bits long on a 64-bit system, mean

Re: [U-Boot] [PATCH] vexpress64: compile Juno PCIe conditionally

2015-10-21 Thread Ryan Harkin
On 20 October 2015 at 16:38, Tom Rini wrote: > On Tue, Oct 20, 2015 at 08:05:40AM +0200, Linus Walleij wrote: > > > Only compile in PCIe support if the board really uses it. Provide > > a stub for the init function if e.g. FVP is being built. > > > > Cc: Li

[U-Boot] [PATCH 1/3] cfi_flash: use specific length types for cword

2015-10-21 Thread Ryan Harkin
uot;, flash_read32(addr), cword.l); ^ I masked these warnings in this patch, however, I am quite sure this is the wrong approach. Signed-off-by: Ryan Harkin --- drivers/mtd/cfi_flash.c | 4 ++-- include/mtd/cfi_flash.h | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff

[U-Boot] [PATCH 3/3] vexpress64: store env in flash

2015-10-21 Thread Ryan Harkin
.fnameWrite=${FILENAME} Foundation models don't simulate the NOR flash, but having NOR support in the u-boot binary does not harm: attempting to write to the NOR will fail gracefully. Signed-off-by: Ryan Harkin --- configs/vexpress_aemv8a_dram_defconfig | 1 - co

[U-Boot] [PATCH 2/3] vexpress64: remove #error

2015-10-21 Thread Ryan Harkin
Unknown board variant" #error "Unknown board variant" make[1]: *** [tools/envcrc.o] Error 1 make: *** [tools] Error 2 In file included from include/config.h:5:0, from tools/envcrc.c:19: Signed-off-by: Ryan Harkin --- include/configs/vexpress_aemv8a.h | 6 --

[U-Boot] [PATCH 0/3] vexpress64 flash support

2015-10-21 Thread Ryan Harkin
Whilst adding NOR support for Juno and FVP models, I encountered a problem in cfi_flash.c. It is using "unsigned long" to represent a 32-bit value. This does not work on 64-bit systems such as vexpress64. I fixed it up in patch 1/3, however, I'm not convinced that my mod is the correct one. I

Re: [U-Boot] [PATCH] vexpress64: compile Juno PCIe conditionally

2015-10-20 Thread Ryan Harkin
On 20 October 2015 at 09:07, Ryan Harkin wrote: > > > On 20 October 2015 at 07:05, Linus Walleij > wrote: > >> Only compile in PCIe support if the board really uses it. Provide >> a stub for the init function if e.g. FVP is being built. >> >> Cc: Liviu D

Re: [U-Boot] [PATCH] vexpress64: compile Juno PCIe conditionally

2015-10-20 Thread Ryan Harkin
On 20 October 2015 at 07:05, Linus Walleij wrote: > Only compile in PCIe support if the board really uses it. Provide > a stub for the init function if e.g. FVP is being built. > > Cc: Liviu Dudau > Cc: Ryan Harkin > Signed-off-by: Linus Walleij > --- > board/armltd

Re: [U-Boot] [PATCH v3 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge.

2015-10-19 Thread Ryan Harkin
Translation Tables. > > Signed-off-by: Liviu Dudau > Tested-by: Ryan Harkin > Reviewed-by: Ryan Harkin --- > board/armltd/vexpress64/Makefile | 2 +- > board/armltd/vexpress64/pcie.c | 197 > +++ > board/armltd/vexpress64/pc

Re: [U-Boot] [PATCH v2 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge.

2015-10-19 Thread Ryan Harkin
On 19 October 2015 at 10:10, Liviu Dudau wrote: > On Fri, 16 Oct 2015 17:58:44 +0100 > Ryan Harkin wrote: > > > Hi Liviu, > > > > These patches work well for me, so at the very least, you can add my > > Test-by for both: > > > > Tested-by: Ryan Har

Re: [U-Boot] [PATCH v2 1/2] vexpress64: Juno: Declare all 8GB of RAM and make them visible to the kernel.

2015-10-16 Thread Ryan Harkin
; Signed-off-by: Liviu Dudau > Reviewed-by: Linus Walleij > Reviewed-by: Ryan Harkin or Tested-by: Ryan Harkin > --- > board/armltd/vexpress64/vexpress64.c | 8 > include/configs/vexpress_aemv8a.h| 4 +++- > 2 files changed, 11 insertions(+), 1 deletion(-)

Re: [U-Boot] [PATCH v2 2/2] vexpress64: Juno: Add initialisation code for Juno R1 PCIe host bridge.

2015-10-16 Thread Ryan Harkin
Hi Liviu, These patches work well for me, so at the very least, you can add my Test-by for both: Tested-by: Ryan Harkin But... I ran checkpatch.pl across your patches and this one throws a few trivial warnings, mostly about 80 character lines and a few like this: CHECK: Prefer using the BIT

Re: [U-Boot] [U-Boot,v4,02/10] vexpress64: Kconfig: tidy up

2015-10-12 Thread Ryan Harkin
Hi Tom, On 12 October 2015 at 16:17, Tom Rini wrote: > On Fri, Oct 09, 2015 at 05:18:00PM +0100, Ryan Harkin wrote: > > > The FVP and Juno settings were identical, but duplicated, so I removed > > the duplication with this patch. > > > > Signed-off-by: Ryan

[U-Boot] [PATCH v4 10/10] vexpress64: juno: use /dev/sda2

2015-10-09 Thread Ryan Harkin
a different nature to a distro image. Linaro uses /dev/sda2 for the rootfs partition. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- include/configs/vexpress_aemv8a.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/vexpress_aemv8a.h b/include/c

[U-Boot] [PATCH v4 09/10] vexpress64: juno: add alternate kernel and device tree filenames

2015-10-09 Thread Ryan Harkin
, 00AB6318 bytes image "board.dtb" not found in flash Loading juno instead of board.dtb loaded region 0 from 0A00 to 8300, 3188 bytes Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- include/configs/vexpress_aemv8a.h | 16 ++-- 1 file cha

[U-Boot] [PATCH v4 06/10] common/armflash: add command to check if image exists

2015-10-09 Thread Ryan Harkin
; fi Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- common/cmd_armflash.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/common/cmd_armflash.c b/common/cmd_armflash.c index 1db92b0..a37f5c4 100644 --- a/common/cmd_armflash.c +++ b/common

[U-Boot] [PATCH v4 08/10] vexpress64: juno: add optional initrd

2015-10-09 Thread Ryan Harkin
Some OS images require an initrd on Juno. If the file ramdisk.img exists in NOR flash, then we load it and pass the address to the kernel. Otherwise, we pass the "-" parameter as before. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- include/configs/vexpress_ae

[U-Boot] [PATCH v4 02/10] vexpress64: Kconfig: tidy up

2015-10-09 Thread Ryan Harkin
The FVP and Juno settings were identical, but duplicated, so I removed the duplication with this patch. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- board/armltd/vexpress64/Kconfig | 17 - 1 file changed, 17 deletions(-) diff --git a/board/armltd/vexpress64

[U-Boot] [PATCH v4 01/10] vexpress64: fix checkpatch warnings

2015-10-09 Thread Ryan Harkin
This patch fixes a couple of checkpatch warnings on the vexpress64 config. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- include/configs/vexpress_aemv8a.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/configs/vexpress_aemv8a.h b/include/configs

[U-Boot] [PATCH v4 03/10] vexpress64: increase max gunzip size

2015-10-09 Thread Ryan Harkin
vexpress64 kernels are usually over 8 MBytes in length, so setting the max uImage length to 64 Mbytes should give us plenty of scope for expansion. I mostly chose this length to match other board configs that use "(64 << 20)". Signed-off-by: Ryan Harkin Reviewed-by: Linus Walle

[U-Boot] [PATCH v4 04/10] vexpress64: fvp dram: add DRAM configuration

2015-10-09 Thread Ryan Harkin
DRAM: --data cluster0.cpu0=Image@0x8008 \ --data cluster0.cpu0=fvp-base-gicv2-psci.dtb@0x8300 \ --data cluster0.cpu0=uInitrd@0x8400 Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- arch/arm/Kconfig | 9 + board/armltd/vexpress64/MAINTA

[U-Boot] [PATCH v4 05/10] vexpress64: juno: add androidboot.hardware=juno

2015-10-09 Thread Ryan Harkin
Linaro's Juno Android builds requires the androidboot.hardware parameter be set to a know board name. Non-Android kernels ignore this extra parameter because they don't contain code to parse it. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- include/configs/vexpress_ae

[U-Boot] [PATCH v4 07/10] common/armflash: load_image returns success or failure

2015-10-09 Thread Ryan Harkin
loaded; else echo \ not loaded; fi Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij --- common/cmd_armflash.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/common/cmd_armflash.c b/common/cmd_armflash.c index a37f5c4..af453f7 100644 --- a/common/cmd_armflash.c

[U-Boot] [PATCH v4 00/10] vexpress64 FVP and Juno configuration updates

2015-10-09 Thread Ryan Harkin
This patch series updates the default configuration of the vexpress64 FVP and Juno platforms to allow it to work on a variety of setups without modification by the user. A propsed change to use a script from NOR as recommended by Liviu Dudau has not been included in this series to limit churn and

Re: [U-Boot] [PATCH v3 09/10] vexpress64: juno: add alternate kernel and device tree filenames

2015-10-02 Thread Ryan Harkin
Hi Liviu, On 2 October 2015 at 14:21, Liviu Dudau wrote: > Hi Ryan, > > On Thu, Oct 01, 2015 at 06:43:35PM +0100, Ryan Harkin wrote: > > The default Juno firmware has renamed the kernel and device tree > > filenames to norkern and board.dtb. > > > > Rather than

Re: [U-Boot] [PATCH v3 04/10] vexpress64: fvp dram: add DRAM configuration

2015-10-01 Thread Ryan Harkin
I'm sorry about this, it's becoming embarassing: I've dropped the maintainer hunk this time. I'll stop posting until my jetlag subsides and make sure I've covered all the bases. Apologies. On 1 October 2015 at 18:43, Ryan Harkin wrote: > Create an additional FVP

[U-Boot] [PATCH v3 08/10] vexpress64: juno: add optional initrd

2015-10-01 Thread Ryan Harkin
Some OS images require an initrd on Juno. If the file ramdisk.img exists in NOR flash, then we load it and pass the address to the kernel. Otherwise, we pass the "-" parameter as before. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij CC: David Feng CC: Bhupesh Sharma

[U-Boot] [PATCH v3 06/10] common/armflash: add command to check if image exists

2015-10-01 Thread Ryan Harkin
; fi Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij CC: David Feng CC: Bhupesh Sharma CC: Linus Walleij --- common/cmd_armflash.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/common/cmd_armflash.c b/common/cmd_armflash.c index 1db92b0

[U-Boot] [PATCH v3 09/10] vexpress64: juno: add alternate kernel and device tree filenames

2015-10-01 Thread Ryan Harkin
aded region 0 from 0850 to 8000, 00AB6318 bytes image "juno" not found in flash Loading board.dtb instead of juno loaded region 0 from 0A00 to 83000000, 00003188 bytes Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij CC: David Feng CC: Bhupesh Sharma

[U-Boot] [PATCH v3 03/10] vexpress64: Kconfig: add CONFIG_SYS_BOOTM_LEN

2015-10-01 Thread Ryan Harkin
arithmetic operations. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij CC: Masahiro Yamada --- board/armltd/vexpress64/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/board/armltd/vexpress64/Kconfig b/board/armltd/vexpress64/Kconfig index 8da3bec..72679be 100644 --- a/board/arml

[U-Boot] [PATCH v3 10/10] vexpress64: juno: use /dev/sda2

2015-10-01 Thread Ryan Harkin
a different nature to a distro image. Linaro uses /dev/sda2 for the rootfs partition. Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij CC: David Feng CC: Bhupesh Sharma CC: Linus Walleij --- include/configs/vexpress_aemv8a.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[U-Boot] [PATCH v3 07/10] common/armflash: load_image returns success or failure

2015-10-01 Thread Ryan Harkin
loaded; else echo \ not loaded; fi Signed-off-by: Ryan Harkin Reviewed-by: Linus Walleij CC: Linus Walleij --- common/cmd_armflash.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/common/cmd_armflash.c b/common/cmd_armflash.c index a37f5c4..af453f7 100644 --- a

  1   2   >