On Mon, 29 Jul 2024 at 20:58, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Mon, 29 Jul 2024 at 02:53, Sughosh Ganu wrote:
> >
> > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote:
> > >
> > > Hi Sughosh,
> > >
> > > On Wed, 24 Jul 2024 a
On Wed, 31 Jul 2024 at 13:43, Heinrich Schuchardt
wrote:
>
> Simplify the code by using the list_count_nodes() function.
>
> Signed-off-by: Heinrich Schuchardt
> ---
I have made changes to the files that you mentioned in your review,
and plan to come up with a v2 once the CI goes through. Thanks
Use the API function list_count_nodes() to count the number of list
entries.
Signed-off-by: Sughosh Ganu
---
Note: To be applied on top of efi-2024-10-rc2
boot/scene.c | 8 +---
drivers/mtd/ubi/fastmap.c | 8 +++-
fs/yaffs2/yaffs_guts.c| 5 ++---
lib
On Wed, 31 Jul 2024 at 20:08, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Wed, 31 Jul 2024 at 01:26, Sughosh Ganu wrote:
> >
> > On Mon, 29 Jul 2024 at 20:58, Simon Glass wrote:
> > >
> > > Hi Sughosh,
> > >
> > > On Mon, 29 Jul 2024
On Tue, 30 Jul 2024 at 20:10, Simon Glass wrote:
>
> This function has more special cases than it needs. Simplify it to
> reduce code size and complexity.
>
> Signed-off-by: Simon Glass
> ---
>
> lib/lmb.c | 57 +++
> 1 file changed, 19 inserti
On Thu, 1 Aug 2024 at 20:28, Sughosh Ganu wrote:
>
> On Tue, 30 Jul 2024 at 20:10, Simon Glass wrote:
> >
> > This function has more special cases than it needs. Simplify it to
> > reduce code size and complexity.
> >
> > Signed-off-by: Simon Gl
On Thu, 1 Aug 2024 at 21:42, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Thu, 1 Aug 2024 at 08:58, Sughosh Ganu wrote:
> >
> > On Tue, 30 Jul 2024 at 20:10, Simon Glass wrote:
> > >
> > > This function has more special cases than it needs. Simplify i
On Mon, 29 Jul 2024 at 20:58, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Mon, 29 Jul 2024 at 02:52, Sughosh Ganu wrote:
> >
> > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote:
> > >
> > > Hi Sughosh,
> > >
> > > On Wed, 24 Jul 20
On Sun, 17 Jul 2022 at 02:43, Jassi Brar wrote:
>
> On Thu, 14 Jul 2022 at 13:39, Sughosh Ganu wrote:
> >
> > Add bindings needed for accessing the FWU metadata partitions. These
> > include the compatible string which point to the access method and the
> > actu
hi Ilias,
On Fri, 15 Jul 2022 at 22:11, Ilias Apalodimas
wrote:
>
> Hi Sughosh,
>
> On Thu, 14 Jul 2022 at 21:40, Sughosh Ganu wrote:
> >
> > Add support for setting OEM flags in the capsule header. As per the
> > UEFI specification, bits 0-15 of the flags member
rsion functions
Sughosh Ganu (6):
tpm: rng: Add driver model interface for TPM RNG device
tpm: Add the RNG child device
cmd: rng: Add support for selecting RNG device
cmd: rng: Use a statically allocated array for random bytes
doc: rng: Add documentation for the rng command
test: rng: Add a
From: Simon Glass
These functions should really be available outside the TPM code, so that
other callers can find out which version the TPM is. Rename them to have
a tpm_ prefix() and add them to the header file.
Signed-off-by: Simon Glass
---
Changes since V6: None
include/tpm_api.h | 10 +++
to comply with the driver model api.
Signed-off-by: Sughosh Ganu
---
Changes since V6:
* Remove the changes made in tpm-v[12].c to return -EIO instead of
TPM_LIB_ERROR as suggested by Simon
drivers/rng/Kconfig | 9 +
drivers/rng/Makefile | 1 +
drivers/rng/tpm_rng.c | 23
randomisation through the
EFI_RNG_PROTOCOL interface.
Signed-off-by: Sughosh Ganu
---
Changes since V6: None
drivers/tpm/tpm-uclass.c | 37 +
1 file changed, 33 insertions(+), 4 deletions(-)
diff --git a/drivers/tpm/tpm-uclass.c b/drivers/tpm/tpm-uclass.c
index
udo device through the TPM chip.
Extend the 'rng' command so that the user can provide the RNG device
number from which the random bytes are to be read. This will be the
device index under the RNG uclass.
Signed-off-by: Sughosh Ganu
Tested-by: Heinrich Schuchardt
Reviewed-by: Ilias Apa
Use a statically allocated buffer on stack instead of using malloc for
reading the random bytes. Using a local array is faster than
allocating heap memory on every initiation of the command.
Signed-off-by: Sughosh Ganu
---
Changes since V6: None
cmd/rng.c | 17 +++--
1 file changed
Add a usage document for the 'rng' u-boot command.
Signed-off-by: Sughosh Ganu
Reviewed-by: Ilias Apalodimas
Reviewed-by: Simon Glass
---
Changes since V6: None
doc/usage/cmd/rng.rst | 26 ++
doc/usage/index.rst | 1 +
2 files changed, 27 insertions(+)
c
The 'rng' command dumps a number of random bytes on the console. Add a
set of tests for the 'rng' command. The test function performs basic
sanity testing of the command.
Since a unit test is being added for the command, enable it by default
in the sandbox platforms.
Signed-
anks.
-sughosh
>
> Thanks
> /Ilias
>
> On Wed, 20 Jul 2022 at 15:30, Sughosh Ganu wrote:
> >
> > Use a statically allocated buffer on stack instead of using malloc for
> > reading the random bytes. Using a local array is faster than
> > allocating heap memory on
:
tpm: Export the TPM-version functions
Sughosh Ganu (6):
tpm: rng: Add driver model interface for TPM RNG device
tpm: Add the RNG child device
cmd: rng: Add support for selecting RNG device
cmd: rng: Use a statically allocated array for random bytes
doc: rng: Add documentation for
From: Simon Glass
These functions should really be available outside the TPM code, so that
other callers can find out which version the TPM is. Rename them to have
a tpm_ prefix() and add them to the header file.
Signed-off-by: Simon Glass
Reviewed-by: Ilias Apalodimas
---
Changes since V7: No
From: Ilias Apalodimas
Due to U-Boot's lazy binding the RNG presented by the TCG is not available
until the EFI_TCG2 protocol has been initialized. Since the TPM has a
built-in RNG device we can use for the OS randomization, move the RNG
protocol installation after the TCG.
Signed-off-by: Ilias
to comply with the driver model api.
Signed-off-by: Sughosh Ganu
Reviewed-by: Ilias Apalodimas
---
Changes since V7: None
drivers/rng/Kconfig | 9 +
drivers/rng/Makefile | 1 +
drivers/rng/tpm_rng.c | 23 +++
lib/Kconfig | 1 +
lib/tpm_api.c
added.
Signed-off-by: Sughosh Ganu
Reviewed-by: Ilias Apalodimas
---
Changes since V7:
* Added a paragraph in the commit message highlighting the absence of
the compatible string in the RNG driver, as suggested by Simon.
* Rearranged the inclusion of headers as per the coding style
udo device through the TPM chip.
Extend the 'rng' command so that the user can provide the RNG device
number from which the random bytes are to be read. This will be the
device index under the RNG uclass.
Signed-off-by: Sughosh Ganu
Tested-by: Heinrich Schuchardt
Reviewed-by: Ilias Apa
Use a statically allocated buffer on stack instead of using malloc for
reading the random bytes. Using a local array is faster than
allocating heap memory on every initiation of the command.
Signed-off-by: Sughosh Ganu
Reviewed-by: Ilias Apalodimas
Reviewed-by: Simon Glass
---
Changes since V7
Add a usage document for the 'rng' u-boot command.
Signed-off-by: Sughosh Ganu
Reviewed-by: Ilias Apalodimas
Reviewed-by: Simon Glass
---
Changes since V7: None
doc/usage/cmd/rng.rst | 26 ++
doc/usage/index.rst | 1 +
2 files changed, 27 insertions(+)
c
The 'rng' command dumps a number of random bytes on the console. Add a
set of tests for the 'rng' command. The test function performs basic
sanity testing of the command.
Since a unit test is being added for the command, enable it by default
in the sandbox platforms.
Signed-
On Fri, 22 Jul 2022 at 09:09, Jassi Brar wrote:
>
> On Thu, 14 Jul 2022 at 13:40, Sughosh Ganu wrote:
> >
> > Add helper functions needed for accessing the FWU metadata which
> > contains information on the updatable images. These functions have
> > been added for t
On Fri, 22 Jul 2022 at 23:13, wrote:
>
> From: Sughosh Ganu
>
> Add bindings needed for accessing the FWU metadata regions.
> These include the compatible string which point to the access
> method, the actual device which stores the FWU metadata and
> the offsets for
ar (2):
> dt: fwu: developerbox: enable fwu banks and mdata regions
> fwu: DeveloperBox: add support for FWU
>
> Sughosh Ganu (3):
> dt/bindings: Add bindings for FWU Metadata mtd storage
> FWU: Add FWU metadata access driver for MTD storage regions
> FWU: mtd: Add help
hi Ilias,
On Wed, 20 Jul 2022 at 13:06, Ilias Apalodimas
wrote:
>
> Hi Sughosh,
>
> >
> > > + nimages = CONFIG_FWU_NUM_IMAGES_PER_BANK;
> > > + active_bank = mdata->active_index;
> > > + img_entry = &mdata->img_entry[0];
> > > + for (i = 0; i < nimages; i++) {
> > > +
the sandbox
and sandbox_flattree variants. The capsule generation through config
file is enabled for the sandbox variant, with the sandbox_flattree
variant generating capsules through the command-line parameters.
The document has been updated to reflect the above changes.
Sughosh Ganu (7):
capsul
psule authentication in
the platform's dtb, and call this as part of building the dtb(s). This
brings the embedding of the ESL in the dtb into the u-boot build flow.
The path to the ESL file is specified through the
CONFIG_EFI_CAPSULE_ESL_FILE symbol.
Signed-off-by: Sughosh Ganu
---
lib/efi_load
which embeds the
ESL file into the platform's dtb(s) as part of the u-boot build. This
requires generating the keys and the ESL file prior to invoking the
u-boot build.
Bring about the same sequence of generating these files prior to
invoking the u-boot build while testing.
Signed-off-by: Su
Update the document to specify how the EFI Signature List(ESL) file
can be embedded into the platform's dtb as part of the u-boot build.
Signed-off-by: Sughosh Ganu
---
doc/develop/uefi/uefi.rst | 19 +--
1 file changed, 5 insertions(+), 14 deletions(-)
diff --git a/doc/de
Add a target for building EFI capsules. The capsule parameters are
specified through a config file, and the path to the config file is
specified through CONFIG_EFI_CAPSULE_CFG_FILE. When the config file is
not specified, the command only builds tools.
Signed-off-by: Sughosh Ganu
---
Makefile
.
This path is to be used for generating capsules through a make target,
with the parameters being parsed from the config file.
Signed-off-by: Sughosh Ganu
---
tools/Kconfig | 9 +
tools/Makefile | 1 +
tools/eficapsule.h | 110
tools/mkeficapsule.c
The UEFI capsule can be generated either through command-line
parameters, or, by specifying those in a config file. Add
documentation to describe the format of the config file.
Signed-off-by: Sughosh Ganu
---
doc/develop/uefi/uefi.rst | 64 +++
1 file changed
: Sughosh Ganu
---
configs/sandbox_defconfig | 1 +
test/py/tests/test_efi_capsule/conftest.py| 106 +++---
.../test_efi_capsule/sandbox_capsule_cfg.txt | 75 +
3 files changed, 139 insertions(+), 43 deletions(-)
create mode 100644 test/py/tests
hi Takahiro,
On Wed, 14 Jun 2023 at 09:09, Takahiro Akashi
wrote:
>
> Hi Sughosh,
>
> I think this is a good extension to mkeficapsule, but
>
> On Tue, Jun 13, 2023 at 04:08:03PM +0530, Sughosh Ganu wrote:
> > Add support for specifying the parameters needed for capsule
On Wed, 14 Jun 2023 at 11:23, Takahiro Akashi
wrote:
>
> On Wed, Jun 14, 2023 at 10:56:23AM +0530, Sughosh Ganu wrote:
> > hi Takahiro,
> >
> > On Wed, 14 Jun 2023 at 09:09, Takahiro Akashi
> > wrote:
> > >
> > > Hi Sughosh,
> > >
&g
hi Simon,
On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Tue, 13 Jun 2023 at 11:41, Sughosh Ganu wrote:
> >
> > The EFI capsule authentication logic in u-boot expects the public key
> > in the form of an EFI Signature List(ESL) to
hi Simon,
On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Tue, 13 Jun 2023 at 11:39, Sughosh Ganu wrote:
> >
> > Add a target for building EFI capsules. The capsule parameters are
> > specified through a config file, and the path to th
On Thu, 15 Jun 2023 at 11:19, Takahiro Akashi
wrote:
>
> On Thu, Jun 15, 2023 at 10:09:06AM +0530, Sughosh Ganu wrote:
> > On Wed, 14 Jun 2023 at 11:23, Takahiro Akashi
> > wrote:
> > >
> > > On Wed, Jun 14, 2023 at 10:56:23AM +0530, Sughosh Ganu wrote:
>
hi Takahiro,
On Fri, 16 Jun 2023 at 10:16, Takahiro Akashi
wrote:
>
> Hi Sughosh,
>
> On Fri, Jun 16, 2023 at 09:56:33AM +0530, Sughosh Ganu wrote:
> > On Thu, 15 Jun 2023 at 11:19, Takahiro Akashi
> > wrote:
> > >
> > > On Thu, Jun 15, 2023 at 10:09:
On Fri, 16 Jun 2023 at 10:48, Takahiro Akashi
wrote:
>
> On Fri, Jun 16, 2023 at 10:37:01AM +0530, Sughosh Ganu wrote:
> > hi Takahiro,
> >
> > On Fri, 16 Jun 2023 at 10:16, Takahiro Akashi
> > wrote:
> > >
> > > Hi Sughosh,
> > >
>
hi Stefan,
On Fri, 16 Jun 2023 at 17:04, Stefan Herbrechtsmeier
wrote:
>
> From: Malte Schmidt
>
> The UEFI [1] specification allows multiple payloads inside the capsule
> body. Add support for this. The command line arguments are kept
> backwards-compatible.
>
> [1] https://uefi.org/specs/UEFI/
On Fri, 16 Jun 2023 at 17:56, Sughosh Ganu wrote:
>
> hi Stefan,
>
> On Fri, 16 Jun 2023 at 17:04, Stefan Herbrechtsmeier
> wrote:
> >
> > From: Malte Schmidt
> >
> > The UEFI [1] specification allows multiple payloads inside the capsule
> >
On Sat, 17 Jun 2023 at 06:26, AKASHI Takahiro
wrote:
>
> On Fri, Jun 16, 2023 at 06:02:52PM +0530, Sughosh Ganu wrote:
> > On Fri, 16 Jun 2023 at 17:56, Sughosh Ganu wrote:
> > >
> > > hi Stefan,
> > >
> > > On Fri, 16 Jun 2023 at 17:04, Stefan He
hi Malte,
On Fri, 16 Jun 2023 at 18:42, Schmidt, Malte
wrote:
>
> Hi sughosh,
>
> Am 16.06.2023 um 08:35 schrieb Sughosh Ganu:
>
> On Fri, 16 Jun 2023 at 10:48, Takahiro Akashi
> wrote:
>
> On Fri, Jun 16, 2023 at 10:37:01AM +0530, Sughosh Ganu wrote:
>
> hi Tak
hi Simon,
On Mon, 19 Jun 2023 at 18:07, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Thu, 15 Jun 2023 at 17:11, Sughosh Ganu wrote:
> >
> > hi Simon,
> >
> > On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote:
> > >
> > > Hi Sughosh,
hi Simon,
On Mon, 19 Jun 2023 at 18:07, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Thu, 15 Jun 2023 at 17:25, Sughosh Ganu wrote:
> >
> > hi Simon,
> >
> > On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote:
> > >
> > > Hi Sughosh,
The UEFI capsule can be generated either through command-line
parameters, or, by specifying those in a config file. Add
documentation to describe the format of the config file.
Signed-off-by: Sughosh Ganu
---
Changes since V1: None
doc/develop/uefi/uefi.rst | 64
eter to pass the config file to the mkeficapsule
tool. This results in generation of the same tool image irrespective
of using command-line parameters or config file.
* Call the mkeficapsule utility with the cfg-file parameter when
building capsules via the config file.
Sughosh Ganu (8):
fdt
Update the document to specify how the EFI Signature List(ESL) file
can be embedded into the platform's dtb as part of the u-boot build.
Signed-off-by: Sughosh Ganu
---
Changes since V1: None
doc/develop/uefi/uefi.rst | 19 +--
1 file changed, 5 insertions(+), 14 dele
: Sughosh Ganu
---
Changes since V1: None
configs/sandbox_defconfig | 1 +
test/py/tests/test_efi_capsule/conftest.py| 107 +++---
.../test_efi_capsule/sandbox_capsule_cfg.txt | 75
3 files changed, 139 insertions(+), 44 deletions(-)
create mode
.
This path is to be used for generating capsules through a make target,
with the parameters being parsed from the config file.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Add a cfg-file parameter to pass the config file to the mkeficapsule
tool. This results in generation of the same tool
x27;s that are packaged into the FIT image.
The path to the ESL file is specified through the
CONFIG_EFI_CAPSULE_ESL_FILE symbol.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Achieve the embedding of the ESL into the DTB through binman
* Add an entry type fdt-esl-embed for embedding the E
Add a target for building EFI capsules. The capsule parameters are
specified through a config file, and the path to the config file is
specified through CONFIG_EFI_CAPSULE_CFG_FILE. When the config file is
not specified, the command only builds tools.
Signed-off-by: Sughosh Ganu
---
Changes
uild.
The binman node needed for invoking the corresponding entry module for
embedding the ESL has been added for sandbox to facilitate testing.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Add the logic to generate the keys in the yml files which get used
in the CI setup.
* Add a fdt
key added for FIT signature verification, the ESL
file contents are added as a whole, as a property under the signature
node in the DTB.
The public key in the ESL form is used by the capsule authentication
feature for authenticating the capsules, prior to update.
Signed-off-by: Sughosh Ganu
hi Simon,
On Mon, 26 Jun 2023 at 14:38, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Wed, 21 Jun 2023 at 05:26, Sughosh Ganu wrote:
> >
> > hi Simon,
> >
> > On Mon, 19 Jun 2023 at 18:07, Simon Glass wrote:
> > >
> > > Hi Sughosh,
hi Simon,
On Mon, 26 Jun 2023 at 17:43, Sughosh Ganu wrote:
>
> hi Simon,
>
> On Mon, 26 Jun 2023 at 14:38, Simon Glass wrote:
> >
> > Hi Sughosh,
> >
> > On Wed, 21 Jun 2023 at 05:26, Sughosh Ganu wrote:
> > >
> > > hi Simon,
> &
hi Simon,
On Tue, 27 Jun 2023 at 15:44, Simon Glass wrote:
>
> Hi,
>
> On Tue, 27 Jun 2023 at 10:55, Ilias Apalodimas
> wrote:
> >
> > Hi Simon,
> >
> > On Mon, 26 Jun 2023 at 14:19, Simon Glass wrote:
> > >
> > > Hi Ilias,
> > >
> > > On Mon, 26 Jun 2023 at 10:53, Ilias Apalodimas
> > > wrote
hi Simon,
On Tue, 27 Jun 2023 at 16:50, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Tue, 27 Jun 2023 at 05:57, Sughosh Ganu wrote:
> >
> > hi Simon,
> >
> > On Mon, 26 Jun 2023 at 17:43, Sughosh Ganu wrote:
> > >
> > > hi Simon,
> &
hi Simon,
On Tue, 27 Jun 2023 at 17:51, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Tue, 27 Jun 2023 at 13:08, Sughosh Ganu wrote:
> >
> > hi Simon,
> >
> > On Tue, 27 Jun 2023 at 16:50, Simon Glass wrote:
> > >
> > > Hi Sughosh,
hi Simon,
On Wed, 28 Jun 2023 at 13:12, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Tue, 27 Jun 2023 at 18:42, Sughosh Ganu wrote:
> >
> > hi Simon,
> >
> > On Tue, 27 Jun 2023 at 17:51, Simon Glass wrote:
> > >
> > > Hi Sughosh,
hi Simon,
On Wed, 28 Jun 2023 at 15:49, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Wed, 28 Jun 2023 at 11:00, Sughosh Ganu wrote:
> >
> > hi Simon,
> >
> > On Wed, 28 Jun 2023 at 13:12, Simon Glass wrote:
> > >
> > > Hi Sughosh,
On Mon, 29 Jul 2024 at 20:56, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Mon, 29 Jul 2024 at 02:40, Sughosh Ganu wrote:
> >
> > On Fri, 26 Jul 2024 at 05:02, Simon Glass wrote:
> > >
> > > Hi Sughosh,
> > >
> > > On Wed, 24 Jul 2024
On Wed, 7 Aug 2024 at 03:21, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Mon, 5 Aug 2024 at 05:55, Sughosh Ganu wrote:
> >
> > On Mon, 29 Jul 2024 at 20:56, Simon Glass wrote:
> > >
> > > Hi Sughosh,
> > >
> > > On Mon, 29 Jul 2024 at 0
On Thu, 8 Aug 2024 at 11:05, Michal Simek wrote:
>
>
>
> On 8/7/24 23:12, Tom Rini wrote:
> > On Tue, Aug 06, 2024 at 05:37:00PM +0530, Prasad Kummari wrote:
> >
> >> Added LMB API to prevent SF command from overwriting reserved
> >> memory areas. The current SPI code does not use LMB APIs for
> >
On Thu, 8 Aug 2024 at 19:58, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Wed, 7 Aug 2024 at 00:32, Sughosh Ganu wrote:
> >
> > On Wed, 7 Aug 2024 at 03:21, Simon Glass wrote:
> > >
> > > Hi Sughosh,
> > >
> > > On Mon, 5 Aug 2024 at 05:
On Fri, 9 Aug 2024 at 21:28, Simon Glass wrote:
>
> Hi Sughosh,
>
> On Fri, 9 Aug 2024 at 02:25, Sughosh Ganu wrote:
> >
> > On Thu, 8 Aug 2024 at 19:58, Simon Glass wrote:
> > >
> > > Hi Sughosh,
> > >
> > > On Wed, 7 Aug 2024 at 00
).
* Add a function for setting up a new and separate lmb instance for
the tests(sjg).
* Add functions to push and pop the lmb pointer for running lmb
tests(sjg).
* Get the alloced lists through the lmb_get() function.
Sughosh Ganu (32):
alist: add a helper to check if the list is full
Add a helper function to check if the alist is full. This can then be
used to extend the alist.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Do away with the alist_empty() function, as it is no longer needed
include/alist.h | 11 +++
1 file changed, 11 insertions(+)
diff --git
d the corresponding test code changes have been made.
Signed-off-by: Sughosh Ganu
---
Changes since V1: None
configs/sandbox64_defconfig| 4 +---
configs/sandbox_defconfig | 7 ---
configs/sandbox_flattree_defconfig | 4 +---
configs/sandbox_noinst_defconfig | 8
co
The lmb_is_reserved() API is not used. There is another API,
lmb_is_reserved_flags() which can be used to check if a particular
memory region is reserved. Remove the unused API.
Signed-off-by: Sughosh Ganu
Reviewed-by: Ilias Apalodimas
Reviewed-by: Simon Glass
---
Changes since V1: None
The __lmb_alloc_base() function is only called from within the lmb
module. Moreover, the lmb_alloc() and lmb_alloc_base() API's are good
enough for the allocation API calls. Make the __lmb_alloc_base()
function static.
Signed-off-by: Sughosh Ganu
Reviewed-by: Ilias Apalodimas
Reviewed-by:
Use the BIT macro for assigning values to the LMB flags instead of
assigning random values to them.
Signed-off-by: Sughosh Ganu
---
Changes since V1: None
include/lmb.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/lmb.h b/include/lmb.h
index 7b87181b9e
e for the available(free) memory,
and one for the used memory. Once full, the list can then be extended
at runtime.
Signed-off-by: Sughosh Ganu
Signed-off-by: Simon Glass
[sjg: Optimise the logic to add a region in lmb_add_region_flags()]
---
Changes since V1:
* Keep the alloced lists for use
this attribute would indicate that the region cannot be
resized.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Handle all cases for merging regions in the lmb_resize_regions()
function, thus removing the need for lmb_merge_overlap_regions().
* Do away with lmb_region_flags_match() as there
the earlier implementation of static arrays.
Signed-off-by: Sughosh Ganu
Reviewed-by: Simon Glass
Reviewed-by: Ilias Apalodimas
---
Changes since V1: None
configs/a3y17lte_defconfig | 1 -
configs/a5y17lte_defconfig | 1 -
configs/a7y17lte_defconfig | 1
The LMB memory map is now persistent and global, and the
CONFIG_LMB_USE_MAX_REGIONS config symbol has now been removed. Remove
the corresponding lmb test case.
Signed-off-by: Sughosh Ganu
Reviewed-by: Simon Glass
Reviewed-by: Ilias Apalodimas
---
Changes since V1: None
test/lib/lmb.c | 67
heap in SPL.
Signed-off-by: Sughosh Ganu
---
Changes since V1: None
lib/Kconfig | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index f8ac8daad3..6a9338390a 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -1103,7 +1103,17 @@ config LMB
With the introduction of separate config symbols for the SPL phase of
U-Boot, the condition checks need to be tweaked so that platforms that
enable the LMB module in SPL are also able to call the LMB API's. Use
the appropriate condition checks to achieve this.
Signed-off-by: Sughosh
With the changes to make the LMB reservations persistent, the common
memory regions are being added during board init. Remove the
now superfluous lmb_init_and_reserve() function.
Signed-off-by: Sughosh Ganu
Reviewed-by: Simon Glass
Reviewed-by: Ilias Apalodimas
---
Changes since V1: None
With the move to make the LMB allocations persistent and the common
memory regions being reserved during board init, there is no need for
an explicit reservation of a memory range. Remove the
lmb_init_and_reserve_range() function.
Signed-off-by: Sughosh Ganu
Reviewed-by: Ilias Apalodimas
Introduce a function lmb_add_memory() to add available memory to the
LMB memory map. Call this function during board init once the LMB data
structures have been initialised.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Call the lmb_add_memory() from lmb_init() instead of
ned-off-by: Sughosh Ganu
Reviewed-by: Simon Glass
---
Changes since V1: None
lib/lmb.c | 36 ++--
1 file changed, 34 insertions(+), 2 deletions(-)
diff --git a/lib/lmb.c b/lib/lmb.c
index f35a94c41b..a661dd2c4c 100644
--- a/lib/lmb.c
+++ b/lib/lmb.c
@@ -13,6 +13,7 @@
Remove a couple of superfluous LMB stub functions, and instead put a
check for calling the lmb_reserve() function.
Signed-off-by: Sughosh Ganu
Reviewed-by: Simon Glass
---
Changes since V1: None
boot/bootm.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/boot
the board init.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Move the initr_lmb() function to board_r.c
* Call lmb_init() from spl.c instead of initr_lmb().
common/board_r.c | 17 +
common/spl/spl.c | 3 +++
2 files changed, 20 insertions(+)
diff --git a/common/board_r.c
memory map
specified in the documentation accordingly.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Rejig the memory map to have the event log at 0xb000 and bloblist at
0xd000.
* Update the memory map in the document accordingly.
arch/sandbox/dts/test.dts| 2 +-
common/Kconfig
of using the current value of stack pointer for starting
the reserved region, have a fixed value, considering the stack size
config value.
Signed-off-by: Sughosh Ganu
---
Changes since V1: None
arch/arc/lib/cache.c| 14 --
arch/arm/lib/stack.c| 14 --
arch
LMB memory map.
Signed-off-by: Sughosh Ganu
Reviewed-by: Simon Glass
---
Changes since V1: None
common/spl/spl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/common/spl/spl.c b/common/spl/spl.c
index 4102e25115..f58c1f97b9 100644
--- a/common/spl/spl.c
+++ b/common
Initialise the ram bank information for sandbox in SPL. This is needed
for adding available memory to the LMB memory map, which is done as
part of the initialisation sequence.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Update the commit message to explain why this change is being done
Enable the LMB config in SPL. This helps in testing the LMB code in
SPL on sandbox.
Signed-off-by: Sughosh Ganu
---
Changes since V1: None
configs/sandbox_noinst_defconfig | 1 +
configs/sandbox_spl_defconfig| 1 +
2 files changed, 2 insertions(+)
diff --git a/configs
memory range has other side effects. On the
other hand, the sandbox iommu test expects to see this particular
value of the DVA. Use the DVA address directly, instead of mapping it
in the LMB memory map, and then have it allocated.
Signed-off-by: Sughosh Ganu
---
Changes since V1:
* Move the DVA address
The LMB memory is typically not needed very early in the platform's
boot. Do not add memory to the LMB map before relocation. Reservation
of common areas and adding of memory is done after relocation.
Signed-off-by: Sughosh Ganu
---
Changes since V1: None
board/xilinx/common/board.c
used to compute the ram_top
address.
Signed-off-by: Sughosh Ganu
---
Changes since V1: New patch
arch/arm/mach-stm32mp/dram_init.c| 17 +
arch/arm/mach-stm32mp/include/mach/stm32mp.h | 11 +++
arch/arm/mach-stm32mp/stm32mp1/spl.c | 17
1401 - 1500 of 1848 matches
Mail list logo
