Re: [U-Boot] [PATCH v2] smc911x driver frame alignment patch

2010-04-23 Thread Valentin Yakovenkov
23.04.2010 19:11, Mike Frysinger wrote: for future reference, you shouldnt put "patch" in the subject name ... i'm not referring to the leading [PATCH], but the trailing "patch". ok, thanx also, i'm not sure if you're using `git send-email` because the trail of your patch is missing the "---"

[U-Boot] [PATCH v2] smc911x driver frame alignment patch

2010-04-22 Thread Valentin Yakovenkov
ads). Signed-off-by: Valentin Yakovenkov diff -r 7dc8ff189175 a/drivers/net/smc911x.c --- a/drivers/net/smc911x.c Mon Mar 29 11:08:55 2010 +0400 +++ b/drivers/net/smc911x.c Mon Apr 19 10:46:02 2010 +0400 @@ -220,7 +220,7 @@ smc911x_reg_write(dev, RX_CFG, 0); -

Re: [U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-22 Thread Valentin Yakovenkov
22.04.2010 23:43, Mike Frysinger wrote: i would send the patch again with this info in the changelog. however, at least on my board, i see no speed difference with this patch. i get about 2.8MiB/s on my bf548-ezkit with and without your change. so, it doesnt break anything that i can see, nor

Re: [U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-22 Thread Valentin Yakovenkov
21.04.2010 23:52, Mike Frysinger wrote: Wrong alignment in smc911x driver when reading a frame from fifo. Neither smc911x chip nor U-Boot doesn't use IP-alignment, so we don't need to add anything here. I know you use this driver a lot. Please comment on this patch. i really havent a clue wh

[U-Boot] [PATCH] smc911x driver frame alignment patch

2010-04-21 Thread Valentin Yakovenkov
Wrong alignment in smc911x driver when reading a frame from fifo. Neither smc911x chip nor U-Boot doesn't use IP-alignment, so we don't need to add anything here. Signed-off-by: Valentin Yakovenkov diff -r 7dc8ff189175 a/drivers/net/smc911x.c --- a/drivers/net/smc911x.c Mon Mar 2