Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Jorge Ramirez-Ortiz, Foundries
gt; > > [1] > > > > https://trustedcomputinggroup.org/wp-content/uploads/TCG_PCClientTPMInterfaceSpecification_TIS__1-3_27_03212013.pdf > > > > > > > > Signed-off-by: Tim Harvey > > > > > > Looks way cleaner, thanks. > > > > &

Re: [PATCH v3] tpm: display warning if using gpio reset with TPM

2024-05-16 Thread Jorge Ramirez-Ortiz, Foundries
4, DeviceID 0x3205, RevisionID 0x01 [open] > > - board with a reset gpio > > u-boot=> tpm init && tpm info > > tpm@1: TPM gpio reset should not be used on secure production devices > > tpm@1 v2.0: VendorID 0x1114, DeviceID 0x3205, RevisionID 0x01 [open] > > > > [1] > > https://trustedcomputinggroup.org/wp-content/uploads/TCG_PCClientTPMInterfaceSpecification_TIS__1-3_27_03212013.pdf > > > > Signed-off-by: Tim Harvey > > Looks way cleaner, thanks. > > Reviewed-by: Miquel Raynal > > Miquèl nice. if needed Signed-off-by: Jorge Ramirez-Ortiz

Re: [PATCH] poplar: add myself as co-maintainer

2024-02-03 Thread Jorge Ramirez-Ortiz, Gmail
On 03/02/24 17:45:42, Yang Xiwen wrote: > On 2/3/2024 4:32 PM, Jorge Ramirez-Ortiz, Gmail wrote: > > On 03/02/24 07:54:22, Shawn Guo wrote: > > > On Sat, Feb 3, 2024 at 5:44 AM Igor Opaniuk > > > wrote: > > > > > > > > Add myself

Re: [PATCH] poplar: add myself as co-maintainer

2024-02-03 Thread Jorge Ramirez-Ortiz, Gmail
On 03/02/24 07:54:22, Shawn Guo wrote: > On Sat, Feb 3, 2024 at 5:44 AM Igor Opaniuk wrote: > > > > Add myself as co-maintainer for Poplar board, as I'm currently > > working on it (re-testing releases, addressing issues etc). > > > > CC: Jorge Ramirez-Ortiz

[PATCHv2] drivers: tee: sandbox: Fix SCP03 control emulator

2023-04-08 Thread Jorge Ramirez-Ortiz
Fix and document the Secure Channel Protocol03 emulator. Fixes: 5a8783c80c39 ("drivers: tee: sandbox: SCP03 control emulator") Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- drivers/tee/sandbox.c | 15 +++ 1 file c

[PATCH] drivers: tee: sandbox: Fix SCP03 control emulator

2023-04-05 Thread Jorge Ramirez-Ortiz
Fix and document the Secure Channel Protocol03 emulator. Fixes: 5a8783c80c39 ("drivers: tee: sandbox: SCP03 control emulator") Signed-off-by: Jorge Ramirez-Ortiz --- drivers/tee/sandbox.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/tee/s

Re: BUG: pta_scp03_invoke_func() in drivers/tee/sandbox.c

2023-04-02 Thread jorge . ramirez . ortiz
sorry i am out of the office for a couple of days but that commit looks horrible. not sure what happened there. i'll propose something before thursday. > On 2 Apr 2023, at 04:41, Simon Glass wrote: > > Hi Heinrich, > >> On Sat, 1 Apr 2023 at 20:58, Heinrich Schuchardt < >> heinrich.schucha.

[PATCH] firmware: ti_sci: fix typo in boot authentication message name

2023-01-10 Thread Jorge Ramirez-Ortiz
Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE) Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Oleksandr Suvorov Acked-by: Andrew Davis --- drivers/firmware/ti_sci.c | 2 +- drivers/firmware/ti_sci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware

Re: [PATCH] firmware: ti_sci: fix typo in boot authentication message name

2023-01-10 Thread Jorge Ramirez-Ortiz, Foundries
On 10/01/23, Andrew Davis wrote: > On 1/10/23 6:30 AM, Jorge Ramirez-Ortiz wrote: > > Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE) > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > Looks like this typo got copy/pasted over to ATF also[0].. > I&#

[PATCH] firmware: ti_sci: fix typo in boot authentication message name

2023-01-10 Thread Jorge Ramirez-Ortiz
Fix AUTH_BOOT message identifier (s/IMIAGE/IMAGE) Signed-off-by: Jorge Ramirez-Ortiz --- drivers/firmware/ti_sci.c | 2 +- drivers/firmware/ti_sci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c index 727e090e8a

Re: [PATCHv5] drivers: tee: i2c: support the NXP SE05x probe errata

2022-09-14 Thread Jorge Ramirez-Ortiz, Foundries
On 14/09/22, Tom Rini wrote: > On Tue, Aug 30, 2022 at 09:56:45PM +0200, Jorge Ramirez-Ortiz wrote: > > > Early instantiation of this I2C device would lock up when being > > probed. > > > > https://www.nxp.com/docs/en/errata/SE050_Erratasheet.pdf > > 3.2.2

Re: [PATCH v3 3/3] i2c: stm32: do not set the STOP condition on error

2022-09-12 Thread Jorge Ramirez-Ortiz, Foundries
ontroller itself is already > > sending automatically a STOP when a NACK is generated. > > > > Thanks to Jorge Ramirez-Ortiz for diagnosing and proposing a first > > fix for this. [1] > > > > [1] > > https://lore.kernel.org/u-boot/20220815145211.31342-2-jo.

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-11 Thread Jorge Ramirez-Ortiz, Foundries
lots > > > of debug messages), ending up send 2 STOP (one automatically by the > > > controller and a 2nd one at the end of the stm32_i2c_message_xfer > > > function). > > > > > > Thanks to Jorge Ramirez-Ortiz for diagnosing and proposing a first >

Re: [PATCH v2 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-09 Thread Jorge Ramirez-Ortiz, Foundries
the stm32_i2c_message_xfer > > function). > > Cmon no need to thank me, that is kind of excessive :) Just the sign-off or codevelop tags for reference if you can wait before merging I will test the series before monday thanks Jorge > > Thanks to Jorge Ramirez-Ortiz for diagnosin

Re: [PATCH 3/3] i2c: stm32: only send a STOP upon transfer completion

2022-09-08 Thread Jorge Ramirez-Ortiz, Foundries
On 08/09/22, Alain Volmat wrote: > Current function stm32_i2c_message_xfer is sending a STOP > whatever the result of the transaction is. This can cause issues > such as making the bus busy since the controller itself is already > sending automatically a STOP when a NACK is generated. This can >

Re: [PATCH] configs: stm32mp*: fix system reset

2022-09-06 Thread Jorge Ramirez-Ortiz, Foundries
On 06/09/22, Patrick DELAUNAY wrote: > Hi, > > On 9/5/22 19:33, Jorge Ramirez-Ortiz wrote: > > Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI > > from executing. > > > > The side effect observed are I2C devices no longer being > > ac

[PATCH] configs: stm32mp*: fix system reset

2022-09-05 Thread Jorge Ramirez-Ortiz
s dependency on CONFIG_TFABOOT") Signed-off-by: Jorge Ramirez-Ortiz --- configs/stm32mp13_defconfig | 1 - configs/stm32mp15_defconfig | 1 - configs/stm32mp15_trusted_defconfig | 1 - 3 files changed, 3 deletions(-) diff --git a/configs/stm32mp13

Re: [PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI

2022-09-05 Thread Jorge Ramirez-Ortiz, Foundries
On 30/08/22, Jorge Ramirez-Ortiz wrote: > Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI > from executing. > > The side effect observed are I2C devices no longer being > accessible from U-boot after a soft reset. I think this PR should get a bit more of attention. Th

[PATCHv5] drivers: tee: i2c: support the NXP SE05x probe errata

2022-08-30 Thread Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz Acked-by: Oleksandr Suvorov --- v5: address Kconfig issue with select (remove) v4: address build issue when feature not enabled v3,2,1: no changes (were part of a patchset) drivers/tee/optee/Kconfig | 13 drivers/tee/optee/i2c.c | 44

[PATCH] configs: stm32mp*: reset via CONFIG_RESET_SCMI

2022-08-30 Thread Jorge Ramirez-Ortiz
Enabling CONFIG_SYSRESET_PSCI prevents CONFIG_RESET_SCMI from executing. The side effect observed are I2C devices no longer being accessible from U-boot after a soft reset. Signed-off-by: Jorge Ramirez-Ortiz --- configs/stm32mp13_defconfig | 1 - configs/stm32mp15_defconfig | 1

[PATCHv4] drivers: tee: i2c: support the NXP SE05x probe errata

2022-08-30 Thread Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz Acked-by: Oleksandr Suvorov --- drivers/tee/optee/Kconfig | 14 + drivers/tee/optee/i2c.c | 44 +++ 2 files changed, 54 insertions(+), 4 deletions(-) diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee

[PATCHv2 1/2] i2c: stm32f7: fix clearing the control register

2022-08-24 Thread Jorge Ramirez-Ortiz
Bits should be set to 0, not 1. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Patrice Chotard --- drivers/i2c/stm32f7_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c index bf2a6c9b4b..3a727e68ac 100644 --- a

[PATCHv3] drivers: tee: i2c: support the NXP SE05x probe errata

2022-08-16 Thread Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz Acked-by: Oleksandr Suvorov --- drivers/tee/optee/Kconfig | 14 + drivers/tee/optee/i2c.c | 44 +++ 2 files changed, 54 insertions(+), 4 deletions(-) diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee

Re: [PATCH] drivers: tee: i2c: support the NXP SE05x probe errata

2022-08-16 Thread Jorge Ramirez-Ortiz, Foundries
On 16/08/22, Oleksandr Suvorov wrote: > Hi Jorge, > > On Tue, Aug 16, 2022 at 2:28 PM Jorge Ramirez-Ortiz > wrote: > > > > Early instantiation of this I2C device would lock up when being > > probed. > > > > Signed-off-by: Jorge Ramirez-Ortiz > >

[PATCHv2] drivers: tee: i2c: support the NXP SE05x probe errata

2022-08-16 Thread Jorge Ramirez-Ortiz
Signed-off-by: Jorge Ramirez-Ortiz --- drivers/tee/optee/Kconfig | 14 + drivers/tee/optee/i2c.c | 44 +++ 2 files changed, 54 insertions(+), 4 deletions(-) diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig index d03028070b

[PATCH] drivers: tee: i2c: support the NXP SE05x probe errata

2022-08-16 Thread Jorge Ramirez-Ortiz
Early instantiation of this I2C device would lock up when being probed. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/tee/optee/Kconfig | 14 + drivers/tee/optee/i2c.c | 44 +++ 2 files changed, 54 insertions(+), 4 deletions(-) diff --git a

[PATCHv2 2/2] i2c: stm32f7: do not set the STOP condition on error

2022-08-15 Thread Jorge Ramirez-Ortiz
Sending the stop condition without waiting for transfer complete has been found to lock the bus (BUSY) when NACKF is raised. Tested accessing the NXP SE05X I2C device. https://www.nxp.com/docs/en/application-note/AN12399.pdf Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Oleksandr Suvorov

[PATCHv2 1/2] i2c: stm32f7: fix clearing the control register

2022-08-15 Thread Jorge Ramirez-Ortiz
Bits should be set to 0, not 1. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/i2c/stm32f7_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c index bf2a6c9b4b..3a727e68ac 100644 --- a/drivers/i2c/stm32f7_i2c.c +++ b

[PATCH 2/2] i2c: stm32f7: do not set the STOP condition on error

2022-08-15 Thread Jorge Ramirez-Ortiz
Sending the stop condition without waiting for TC has been found to lock the bus. Tested accessing the the NXP SE05X I2C device. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/i2c/stm32f7_i2c.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/i2c

[PATCH 1/2] i2c: stm32f7: fix clearing the control register

2022-08-15 Thread Jorge Ramirez-Ortiz
Bits should be set to 0, not 1. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/i2c/stm32f7_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c index bf2a6c9b4b..3a727e68ac 100644 --- a/drivers/i2c/stm32f7_i2c.c +++ b

Re: [PATCH v2] soc: xilinx: versal: fix out of bounds array access

2022-04-19 Thread Jorge Ramirez-Ortiz, Foundries
On 16/04/22, Jorge Ramirez-Ortiz wrote: > The call to xilinx_pm_request requires an array of a larger size. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > drivers/soc/soc_xilinx_versal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/s

[PATCH v2] soc: xilinx: versal: fix out of bounds array access

2022-04-16 Thread Jorge Ramirez-Ortiz
The call to xilinx_pm_request requires an array of a larger size. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/soc/soc_xilinx_versal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/soc_xilinx_versal.c b/drivers/soc/soc_xilinx_versal.c index f8bcd9ab40

[PATCH] soc: xilinx: versal: fix out of bounds array access

2022-04-16 Thread Jorge Ramirez-Ortiz
The call to xilinx_pm_request requires an array of a larger size. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/soc/soc_xilinx_versal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/soc_xilinx_versal.c b/drivers/soc/soc_xilinx_versal.c index f8bcd9ab40

Re: [PATCH] arm64: zynqmp: enable the PMUFW watchdog

2022-03-24 Thread Jorge Ramirez-Ortiz, Foundries
On 24/03/22, Michal Simek wrote: > > > On 3/23/22 15:04, Jorge Ramirez-Ortiz wrote: > > From 528b3117a36b7b4eea1839afbea7191d60638b0c Mon Sep 17 00:00:00 2001 > > From: Jorge Ramirez-Ortiz > > Date: Wed, 23 Mar 2022 14:41:15 +0100 > > Subject: [PATCH] arm64:

Re: [PATCH] arm64: zynqmp: enable the PMUFW watchdog

2022-03-23 Thread Jorge Ramirez-Ortiz, Foundries
On 23/03/22, Jorge Ramirez-Ortiz wrote: > From 528b3117a36b7b4eea1839afbea7191d60638b0c Mon Sep 17 00:00:00 2001 > From: Jorge Ramirez-Ortiz > Date: Wed, 23 Mar 2022 14:41:15 +0100 > Subject: [PATCH] arm64: zynqmp: enable the PMUFW watchdog um, seems my sendpatch script is a bit off

[PATCH] arm64: zynqmp: enable the PMUFW watchdog

2022-03-23 Thread Jorge Ramirez-Ortiz
>From 528b3117a36b7b4eea1839afbea7191d60638b0c Mon Sep 17 00:00:00 2001 From: Jorge Ramirez-Ortiz Date: Wed, 23 Mar 2022 14:41:15 +0100 Subject: [PATCH] arm64: zynqmp: enable the PMUFW watchdog If the PMUFW was built with support for the CSU watchdog we must let the firmware know that it can

Re: Unable to select a different ENV location due env_get_location on zynqmp

2022-02-15 Thread Jorge Ramirez-Ortiz, Foundries
On 15/02/22, Michal Simek wrote: > Hi, > > On 2/14/22 21:10, Ricardo Salveti wrote: > > Hi Michal, > > > > This is a bit similar to the issue raised on iMX8-based targets a few > > days ago, which is forcing the environment location based on the boot > > mode and not allowing the user to use a di

Re: FIT image: load secure FPGA

2022-02-08 Thread Jorge Ramirez-Ortiz, Foundries
ian, > > > > On Wed, Jan 19, 2022 at 7:23 PM Jorge Ramirez-Ortiz, Foundries > > wrote: > > > On 19/01/22, Jorge Ramirez-Ortiz, Foundries wrote: > > > > On 19/01/22, Jorge Ramirez-Ortiz, Foundries wrote: > > > > > On 19/01/22, Adrian Fiergo

Re: [PATCHv2] arm64: zynqmp: Print the secure boot status information

2022-02-04 Thread Jorge Ramirez-Ortiz, Foundries
On 04/02/22, Michal Simek wrote: > Hi, > > pá 4. 2. 2022 v 8:47 odesílatel Jorge Ramirez-Ortiz, Foundries > napsal: > > > > On 13/10/21, Jorge Ramirez-Ortiz wrote: > > > Output the secure boot configuration to the console. > > > > > > Hi, M

Re: [PATCHv2] arm64: zynqmp: Print the secure boot status information

2022-02-03 Thread Jorge Ramirez-Ortiz, Foundries
On 13/10/21, Jorge Ramirez-Ortiz wrote: > Output the secure boot configuration to the console. Hi, Michal was there any reason for not merging this patch? thanks Jorge > > Signed-off-by: Jorge Ramirez-Ortiz > --- > > v2: >Michal review 12 Aug 2021 > prin

Re: FIT image: load secure FPGA

2022-01-19 Thread Jorge Ramirez-Ortiz, Foundries
On 19/01/22, Jorge Ramirez-Ortiz, Foundries wrote: > On 19/01/22, Jorge Ramirez-Ortiz, Foundries wrote: > > On 19/01/22, Adrian Fiergolski wrote: > > > Hi Jorge, > > > > hi Adrian, > > > > > > > > Have you succeeded to enable secure bo

Re: FIT image: load secure FPGA

2022-01-19 Thread Jorge Ramirez-Ortiz, Foundries
On 19/01/22, Jorge Ramirez-Ortiz, Foundries wrote: > On 19/01/22, Adrian Fiergolski wrote: > > Hi Jorge, > > hi Adrian, > > > > > Have you succeeded to enable secure boot on ZynqMP with SPL (not Xilinx's > > FSBL)? Is it documented somewhe

Re: FIT image: load secure FPGA

2022-01-19 Thread Jorge Ramirez-Ortiz, Foundries
On 19/01/22, Adrian Fiergolski wrote: > Hi Jorge, hi Adrian, > > Have you succeeded to enable secure boot on ZynqMP with SPL (not Xilinx's > FSBL)? Is it documented somewhere? Any configuration files/yocto recipes? somewhere there: https://github.com/foundriesio/meta-lmp > Have you managed to

[PATCHv2] fpga_load: pass compatible string

2021-10-15 Thread Jorge Ramirez-Ortiz
Instead of ignoring the mandatory fpga compatible string, let the different implementations decide how to handle it Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Simon Glass --- RFC v1->v2: added function comment cmd/fpga.c | 8 common/image.c |

Re: [RFC PATCH 1/2] fpga_load: pass compatible string

2021-10-15 Thread Jorge Ramirez-Ortiz, Foundries
On 14/10/21, Simon Glass wrote: > Hi Jorge, > > On Tue, 5 Oct 2021 at 05:13, Jorge Ramirez-Ortiz wrote: > > > > Instead of ignoring the mandatory fpga compatible string, let the > > different implementations decide how to handle it > > > > Signed-off-by

Re: [PATCHv3] zynqmp: restore the jtag interface

2021-10-14 Thread Jorge Ramirez-Ortiz, Foundries
On 14/10/21, Michal Simek wrote: > > > On 10/13/21 15:48, Jorge Ramirez-Ortiz wrote: > > When boot.bin is configured for secure boot the CSU will disable the > > JTAG interface on all cases. > > > > Some boards might rely on this interface for flashing to QSP

[PATCHv2] arm64: zynqmp: Print the secure boot status information

2021-10-13 Thread Jorge Ramirez-Ortiz
Output the secure boot configuration to the console. Signed-off-by: Jorge Ramirez-Ortiz --- v2: Michal review 12 Aug 2021 print information on SPL and UBOOT improve the print command add macros to mask the status arch/arm/mach-zynqmp/include/mach/hardware.h | 6

Re: [PATCHv2] zynqmp: restore the jtag interface

2021-10-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/10/21, Michal Simek wrote: > > > On 10/13/21 13:40, Jorge Ramirez-Ortiz, Foundries wrote: > > On 13/10/21, Michal Simek wrote: > > > > > > > > > On 10/13/21 10:25, Jorge Ramirez-Ortiz wrote: > > > > When boot.bin is configured

[PATCHv3] zynqmp: restore the jtag interface

2021-10-13 Thread Jorge Ramirez-Ortiz
-off-by: Jorge Ramirez-Ortiz --- v3: delete unvalid removal of empty line arch/arm/mach-zynqmp/Kconfig | 8 + arch/arm/mach-zynqmp/include/mach/hardware.h | 31 +++- board/xilinx/zynqmp/zynqmp.c | 19 3 files changed, 51 insertions

Re: [PATCHv2] zynqmp: restore the jtag interface

2021-10-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/10/21, Michal Simek wrote: > > > On 10/13/21 10:25, Jorge Ramirez-Ortiz wrote: > > When boot.bin is configured for secure boot the CSU will disable the > > JTAG interface on all cases. > > > > Some boards might rely on this interface for flashing to QSP

[PATCHv2] zynqmp: restore the jtag interface

2021-10-13 Thread Jorge Ramirez-Ortiz
-off-by: Jorge Ramirez-Ortiz --- arch/arm/mach-zynqmp/Kconfig | 8 + arch/arm/mach-zynqmp/include/mach/hardware.h | 31 +++- board/xilinx/zynqmp/zynqmp.c | 20 - 3 files changed, 51 insertions(+), 8 deletions(-) diff --git a/arch/arm

[PATCH] zynqmp: restore the jtag interface

2021-10-13 Thread Jorge Ramirez-Ortiz
-off-by: Jorge Ramirez-Ortiz --- arch/arm/mach-zynqmp/Kconfig | 8 + arch/arm/mach-zynqmp/include/mach/hardware.h | 31 +++- board/xilinx/zynqmp/zynqmp.c | 20 - 3 files changed, 51 insertions(+), 8 deletions(-) diff --git a/arch/arm

Re: [RFC PATCH 2/2] fpga: xilinx: allow loading authenticated images (DDR)

2021-10-05 Thread Jorge Ramirez-Ortiz, Foundries
On 05/10/21, Michal Simek wrote: > > > On 10/5/21 1:13 PM, Jorge Ramirez-Ortiz wrote: > > Add new compatible string u-boot,zynqmp-fpga-ddrauth to handle this > > use case. > > > > Signed-off-by: Jorge Ramirez-Ortiz > >

[RFC PATCH 2/2] fpga: xilinx: allow loading authenticated images (DDR)

2021-10-05 Thread Jorge Ramirez-Ortiz
Add new compatible string u-boot,zynqmp-fpga-ddrauth to handle this use case. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/fpga/xilinx.c | 29 + drivers/fpga/zynqmppl.c | 4 ++-- include/xilinx.h| 2 +- 3 files changed, 28 insertions(+), 7 deletions

[RFC PATCH 1/2] fpga_load: pass compatible string

2021-10-05 Thread Jorge Ramirez-Ortiz
Instead of ignoring the mandatory fpga compatible string, let the different implementations decide how to handle it Signed-off-by: Jorge Ramirez-Ortiz --- cmd/fpga.c | 8 common/image.c | 4 ++-- common/spl/spl_fit.c | 4 +--- drivers/fpga/fpga.c | 11

[PATCH] arm64: zynqmp: Print the secure boot status information in EL3

2021-10-05 Thread Jorge Ramirez-Ortiz
Confirm the secure boot configuration on the console. Signed-off-by: Jorge Ramirez-Ortiz --- arch/arm/mach-zynqmp/include/mach/hardware.h | 3 ++- board/xilinx/zynqmp/zynqmp.c | 16 +++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach

Re: FIT image: load secure FPGA

2021-10-04 Thread Jorge Ramirez-Ortiz, Foundries
On 05/10/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 04/10/21, Alex G. wrote: > > On 10/4/21 3:32 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > > Hello, > > > > > hi Alex, > > > > We are enabling secure boot on Zynqmp with SPL. > > > &

Re: FIT image: load secure FPGA

2021-10-04 Thread Jorge Ramirez-Ortiz, Foundries
On 04/10/21, Alex G. wrote: > On 10/4/21 3:32 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > Hello, > > hi Alex, > > We are enabling secure boot on Zynqmp with SPL. > > > > The issue however is that during secure boot, the bootrom not only > > validates the

FIT image: load secure FPGA

2021-10-04 Thread Jorge Ramirez-Ortiz, Foundries
Hello, We are enabling secure boot on Zynqmp with SPL. The issue however is that during secure boot, the bootrom not only validates the first loader (SPL and PMUFW combo) but it will also expect a signed bitstream during load(FPGA). Since currently the SPL load of an FPGA image from FIT does not

Re: cdns_wdt: who enables the clock

2021-09-10 Thread Jorge Ramirez-Ortiz, Foundries
On 10/09/21, Michal Simek wrote: > Hi, > > On 9/8/21 5:39 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > Hi Michal > > > > The *linux* cadence_wdt driver for the watchdog enables the clock that > > controls its behaviour. However this is not done in the U-boot &g

cdns_wdt: who enables the clock

2021-09-08 Thread Jorge Ramirez-Ortiz, Foundries
Hi Michal The *linux* cadence_wdt driver for the watchdog enables the clock that controls its behaviour. However this is not done in the U-boot driver; I dont think it is safe to assume that the clock will be active. do you know why is the driver making that assumption? and how to enable the cloc

Re: [PATCH] arm64: zynqmp: Print the secure boot status information in EL3

2021-08-27 Thread Jorge Ramirez-Ortiz, Foundries
On 12/08/21, Michal Simek wrote: > > > On 7/22/21 1:19 PM, Jorge Ramirez-Ortiz wrote: > > Confirm the secure boot configuration on the console. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > arch/arm/mach-zynqmp/include/mach/hardware.h |

Re: [PATCH] zynqmp: restore the jtag interface

2021-08-27 Thread Jorge Ramirez-Ortiz, Foundries
On 12/08/21, Michal Simek wrote: > > > On 7/16/21 7:16 PM, Jorge Ramirez-Ortiz wrote: > > As a security feature, if boot.bin was configured for secure boot the > > CSU will disable the JTAG interface on all cases. > > > > Some boards might rely on this interf

Re: [PATCH] zynqmp: restore the jtag interface

2021-08-11 Thread Jorge Ramirez-Ortiz, Foundries
On 16/07/21, Jorge Ramirez-Ortiz wrote: reminder > As a security feature, if boot.bin was configured for secure boot the > CSU will disable the JTAG interface on all cases. > > Some boards might rely on this interface for flashing to QSPI in which > case those systems might

Re: [PATCH] arm64: zynqmp: Print the secure boot status information in EL3

2021-08-11 Thread Jorge Ramirez-Ortiz, Foundries
On 22/07/21, Jorge Ramirez-Ortiz wrote: reminder > Confirm the secure boot configuration on the console. > > Signed-off-by: Jorge Ramirez-Ortiz > --- > arch/arm/mach-zynqmp/include/mach/hardware.h | 3 ++- > board/xilinx/zynqmp/zynqmp.c | 16 +

[PATCH] arm64: zynqmp: Print the secure boot status information in EL3

2021-07-22 Thread Jorge Ramirez-Ortiz
Confirm the secure boot configuration on the console. Signed-off-by: Jorge Ramirez-Ortiz --- arch/arm/mach-zynqmp/include/mach/hardware.h | 3 ++- board/xilinx/zynqmp/zynqmp.c | 16 +++- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach

[PATCH] zynqmp: restore the jtag interface

2021-07-16 Thread Jorge Ramirez-Ortiz
- if the CSU allows for it. Signed-off-by: Jorge Ramirez-Ortiz --- arch/arm/mach-zynqmp/Kconfig | 9 arch/arm/mach-zynqmp/include/mach/hardware.h | 23 +-- board/xilinx/zynqmp/zynqmp.c | 24 3 files changed, 49

Re: [PATCH] arm: mach-snapdragon: pinctrl: Place pin_name in .data section

2021-07-15 Thread Jorge Ramirez-Ortiz, Gmail
On 15/07/21, Jorge Ramirez-Ortiz, Gmail wrote: > On 06/07/21, Ramon Fried wrote: > > On Mon, Jul 5, 2021 at 3:19 PM Stephan Gerhold wrote: > > > > > > According to arch/arm/lib/crt0_64.S, the BSS section is "UNAVAILABLE" > > > and uninitialized

Re: [PATCH] arm: mach-snapdragon: pinctrl: Place pin_name in .data section

2021-07-15 Thread Jorge Ramirez-Ortiz, Gmail
On 06/07/21, Ramon Fried wrote: > On Mon, Jul 5, 2021 at 3:19 PM Stephan Gerhold wrote: > > > > According to arch/arm/lib/crt0_64.S, the BSS section is "UNAVAILABLE" > > and uninitialized before relocation. Also, it overlaps with the > > appended DTB before relocation, so writing data into a varia

Re: zynqmpbif - sample

2021-07-14 Thread Jorge Ramirez-Ortiz, Foundries
On 14/07/21, Michal Simek wrote: > Hi, > > On 7/14/21 9:37 AM, Jorge Ramirez-Ortiz, Foundries wrote: > > On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > >> On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > >>> On 13/07/21, Jorge Ramirez-Ortiz, Foundri

Re: zynqmpbif - sample

2021-07-14 Thread Jorge Ramirez-Ortiz, Foundries
On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > > On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > > > On 13/07/21, Michal Simek wrote: > > > > > > > > > > > > On 7/13/21 11:25 AM,

Re: zynqmpbif - sample

2021-07-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > > On 13/07/21, Michal Simek wrote: > > > > > > > > > On 7/13/21 11:25 AM, Jorge Ramirez-Ortiz, Foundries wrote: > > > > On 13/07/21, Jorge R

Re: zynqmpbif - sample

2021-07-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 13/07/21, Michal Simek wrote: > > > > > > On 7/13/21 11:25 AM, Jorge Ramirez-Ortiz, Foundries wrote: > > > On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > > >> On 13/07/21, Michal Simek wrote

Re: zynqmpbif - sample

2021-07-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/07/21, Michal Simek wrote: > > > On 7/13/21 11:25 AM, Jorge Ramirez-Ortiz, Foundries wrote: > > On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > >> On 13/07/21, Michal Simek wrote: > >>> Hi, > >>> > >>> On 7/12/21 7:4

Re: zynqmpbif - sample

2021-07-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/07/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 13/07/21, Michal Simek wrote: > > Hi, > > > > On 7/12/21 7:40 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > > hi Michal, > > > > > > Would you have some sample/reference code to generate a

Re: zynqmpbif - sample

2021-07-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/07/21, Michal Simek wrote: > Hi, > > On 7/12/21 7:40 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > hi Michal, > > > > Would you have some sample/reference code to generate a SPL boot image > > using zynqmpbif instead of zynqmpimage? I cant find any documen

zynqmpbif - sample

2021-07-12 Thread Jorge Ramirez-Ortiz, Foundries
hi Michal, Would you have some sample/reference code to generate a SPL boot image using zynqmpbif instead of zynqmpimage? I cant find any documentation and I see no option to enable it (I was expecting to find some config in Makefile.spl but I see none). What is the expected way of building these

Re: Zynq MPSoC - secure boot

2021-06-22 Thread Jorge Ramirez-Ortiz, Foundries
On 22/06/21, Michal Simek wrote: > Hi, > > On 6/21/21 7:27 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > hi Michal, > > > > Is secure boot supported using SPL? or is there a plan for it (maybe a > > branch somewhere that I can work from and contribute to?). >

Zynq MPSoC - secure boot

2021-06-21 Thread Jorge Ramirez-Ortiz, Foundries
hi Michal, Is secure boot supported using SPL? or is there a plan for it (maybe a branch somewhere that I can work from and contribute to?). ATM looking into how to write the key sha to the fuses without Vivado. thanks for any information that you might have, jorge

[PATCHv2] zynqmp: spl: support DRAM ECC initialization

2021-06-13 Thread Jorge Ramirez-Ortiz
initialize SPL_ZYNQMP_DRAM_BANK1_LEN : len of memory to initialize (hex) SPL_ZYNQMP_DRAM_BANK2_BASE: start of memory to initialize SPL_ZYNQMP_DRAM_BANK2_LEN : len of memory to initialize (hex) Setting SPL_ZYNQMP_DRAM_BANK_LEN to 0 takes no action. Signed-off-by: Jorge Ramirez-Ortiz --- v2

Re: [PATCH] zynqmp: spl: support DRAM ECC initialization

2021-06-11 Thread Jorge Ramirez-Ortiz, Foundries
On 11/06/21, Michal Simek wrote: > Hi, > > On 6/11/21 12:09 PM, Jorge Ramirez-Ortiz wrote: > > Use the ZDMA channel 0 to initialize the DRAM banks. > > A little bit short. Can you please extend it? ok > > > > > Signed-off-by: Jorge Ramirez-Ortiz >

[PATCH] zynqmp: spl: support DRAM ECC initialization

2021-06-11 Thread Jorge Ramirez-Ortiz
Use the ZDMA channel 0 to initialize the DRAM banks. Signed-off-by: Jorge Ramirez-Ortiz --- arch/arm/mach-zynqmp/Kconfig| 35 +++ arch/arm/mach-zynqmp/Makefile | 1 + arch/arm/mach-zynqmp/ecc_spl_init.c | 139 arch/arm/mach-zynqmp/spl.c

Re: Zynq UltraScale MPSoC, DMA driver

2021-06-08 Thread Jorge Ramirez-Ortiz, Foundries
On 08/06/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 08/06/21, Michal Simek wrote: > > Hi, > > > > On 6/7/21 8:41 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > > On 07/06/21, Jorge Ramirez-Ortiz, Foundries wrote: > > >> hi Michal > > >>

Re: Zynq UltraScale MPSoC, DMA driver

2021-06-08 Thread Jorge Ramirez-Ortiz, Foundries
On 08/06/21, Michal Simek wrote: > Hi, > > On 6/7/21 8:41 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > On 07/06/21, Jorge Ramirez-Ortiz, Foundries wrote: > >> hi Michal > >> > >> um, when we exchanged emails about enabling ECC support for MPSoC, I &

Re: Zynq UltraScale MPSoC, DMA driver

2021-06-07 Thread Jorge Ramirez-Ortiz, Foundries
On 07/06/21, Jorge Ramirez-Ortiz, Foundries wrote: > hi Michal > > um, when we exchanged emails about enabling ECC support for MPSoC, I > left with the understanding that there already was a DMA driver > available in u-boot that I could use to initialize the memory. > > do

Zynq UltraScale MPSoC, DMA driver

2021-06-07 Thread Jorge Ramirez-Ortiz, Foundries
hi Michal um, when we exchanged emails about enabling ECC support for MPSoC, I left with the understanding that there already was a DMA driver available in u-boot that I could use to initialize the memory. do you have something in the works or will I have to write such a driver? compatible would

[PATCHv5] drivers: tpm2: update reset gpio semantics

2021-06-03 Thread Jorge Ramirez-Ortiz
Use the more generic reset-gpios property name. Signed-off-by: Jorge Ramirez-Ortiz Acked-by: Michal Simek --- v5: added Acked-by: Michal Simek .../tpm2/tis-tpm2-spi.txt | 3 ++- drivers/tpm/tpm2_tis_spi.c| 23 --- 2 files changed, 17

[PATCHv4] drivers: tpm2: update reset gpio semantics

2021-06-03 Thread Jorge Ramirez-Ortiz
Use the more generic reset-gpios property name. Signed-off-by: Jorge Ramirez-Ortiz --- v4: s/will be deprecated/is deprecated .../tpm2/tis-tpm2-spi.txt | 3 ++- drivers/tpm/tpm2_tis_spi.c| 23 --- 2 files changed, 17 insertions(+), 9

[PATCHv3] drivers: tpm2: update reset gpio semantics

2021-06-03 Thread Jorge Ramirez-Ortiz
Use the more generic reset-gpios property name. Signed-off-by: Jorge Ramirez-Ortiz --- v3: maintained the legacy property in the docs .../tpm2/tis-tpm2-spi.txt | 3 ++- drivers/tpm/tpm2_tis_spi.c| 23 --- 2 files changed, 17 insertions

Re: [PATCHv2] drivers: tpm2: update reset gpio semantics

2021-06-03 Thread Jorge Ramirez-Ortiz, Foundries
On 01/06/21, Michal Simek wrote: > > > On 6/1/21 9:35 AM, Jorge Ramirez-Ortiz, Foundries wrote: > > On 01/06/21, Michal Simek wrote: > >> > >> > >> On 6/1/21 8:09 AM, Jorge Ramirez-Ortiz wrote: > >>> Use the more generic reset-gpios proper

Re: [PATCHv2] drivers: tpm2: update reset gpio semantics

2021-06-01 Thread Jorge Ramirez-Ortiz, Foundries
On 01/06/21, Michal Simek wrote: > > > On 6/1/21 8:09 AM, Jorge Ramirez-Ortiz wrote: > > Use the more generic reset-gpios propery name. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > v2: kept gpio-reset as legacy > > > >

[PATCHv2] drivers: tpm2: update reset gpio semantics

2021-05-31 Thread Jorge Ramirez-Ortiz
Use the more generic reset-gpios propery name. Signed-off-by: Jorge Ramirez-Ortiz --- v2: kept gpio-reset as legacy .../tpm2/tis-tpm2-spi.txt | 2 +- drivers/tpm/tpm2_tis_spi.c| 21 --- 2 files changed, 14 insertions(+), 9 deletions

Re: [PATCH] drivers: tpm2: update reset gpio semantics

2021-05-31 Thread Jorge Ramirez-Ortiz, Foundries
On 31/05/21, Michal Simek wrote: > > > On 5/28/21 6:18 PM, Bruno Thomsen wrote: > > Den tor. 27. maj 2021 kl. 09.15 skrev Michal Simek > > : > >> > >> > >> > >> On 5/26/21 9:57 PM, Jorge Ramirez-Ortiz wrote: > >>> Use the mo

Re: [PATCH] drivers: tpm2: update reset gpio semantics

2021-05-27 Thread Jorge Ramirez-Ortiz, Gmail
On 27/05/21, Simon Glass wrote: > On Wed, 26 May 2021 at 13:57, Jorge Ramirez-Ortiz wrote: > > > > Use the more generic reset-gpios propery name. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > doc/device-tree-bindings/tpm2/tis-tpm2-spi.txt

[PATCH] drivers: tpm2: update reset gpio semantics

2021-05-26 Thread Jorge Ramirez-Ortiz
Use the more generic reset-gpios propery name. Signed-off-by: Jorge Ramirez-Ortiz --- doc/device-tree-bindings/tpm2/tis-tpm2-spi.txt | 2 +- drivers/tpm/tpm2_tis_spi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/device-tree-bindings/tpm2/tis

Re: Zynq MPSoC Dynamic DDR DIMM Configuration support

2021-05-14 Thread Jorge Ramirez-Ortiz, Foundries
On 14/05/21, Michal Simek wrote: > > > On 5/14/21 9:38 AM, Jorge Ramirez-Ortiz, Foundries wrote: > > On 13/05/21, Michal Simek wrote: > >> Hi, > >> > >> On 5/13/21 9:24 AM, Jorge Ramirez-Ortiz, Foundries wrote: > >>> On 13/05/21, Michal Sim

Re: Zynq MPSoC Dynamic DDR DIMM Configuration support

2021-05-14 Thread Jorge Ramirez-Ortiz, Foundries
On 13/05/21, Michal Simek wrote: > Hi, > > On 5/13/21 9:24 AM, Jorge Ramirez-Ortiz, Foundries wrote: > > On 13/05/21, Michal Simek wrote: > >> Hi Jorge, > >> > >> On 5/12/21 11:21 PM, Jorge Ramirez-Ortiz, Foundries wrote: > >>> Hi Micha

Re: Zynq MPSoC Dynamic DDR DIMM Configuration support

2021-05-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/05/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 13/05/21, Michal Simek wrote: > > Hi Jorge, > > > > On 5/12/21 11:21 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > > Hi Michal > > > > > > We are doing some work on an MPSoC UZ3EG platform

Re: Zynq MPSoC Dynamic DDR DIMM Configuration support

2021-05-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/05/21, Michal Simek wrote: > Hi Jorge, > > On 5/12/21 11:21 PM, Jorge Ramirez-Ortiz, Foundries wrote: > > Hi Michal > > > > We are doing some work on an MPSoC UZ3EG platform part of which > > requires us to replace FSBL with SPL. > > Just f

Zynq MPSoC Dynamic DDR DIMM Configuration support

2021-05-12 Thread Jorge Ramirez-Ortiz, Foundries
Hi Michal We are doing some work on an MPSoC UZ3EG platform part of which requires us to replace FSBL with SPL. It seems the actual boot process is becoming an issue on these SoCs; currently, 1) we embed the PMU firmware on SPL so the bootrom can extract it and program it; 2) then SPL configures

  1   2   3   4   >