Re: [U-Boot] [v2 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-08-13 Thread vikasm
Hi, On 08/13/2015 10:35 AM, Marek Vasut wrote: > On Thursday, August 13, 2015 at 05:50:18 PM, vikasm wrote: >> Hi Marek, > > Hi! > >> On 08/12/2015 07:07 PM, Marek Vasut wrote: >>> On Thursday, July 16, 2015 at 04:27:29 AM, Vikas Manocha wrote: >>> >

Re: [U-Boot] [v2 5/6] spi: cadence_qspi: fix base trigger address & transfer start address

2015-08-13 Thread vikasm
Hi Marek, On 08/12/2015 07:15 PM, Marek Vasut wrote: > On Thursday, July 16, 2015 at 04:27:33 AM, Vikas Manocha wrote: >> This patch is to separate the base trigger from the read/write transfer >> start addresses. > > This patch breaks the QSPI support on SoCFPGA. ok, can you please try to debug

Re: [U-Boot] [v2 3/6] spi: cadence_qspi: remove sram polling from flash write

2015-08-13 Thread vikasm
Hi Marek, On 08/12/2015 07:11 PM, Marek Vasut wrote: > On Thursday, July 16, 2015 at 04:27:31 AM, Vikas Manocha wrote: >> There is no need to poll sram level before writing to flash, data going to >> SRAM till sram is full, after that backpressure will take over. > > Please see the question I pos

Re: [U-Boot] [v2 2/6] spi: cadence_qspi: remove sram polling from flash read

2015-08-13 Thread vikasm
Hi Marek, On 08/12/2015 07:09 PM, Marek Vasut wrote: > On Thursday, July 16, 2015 at 04:27:30 AM, Vikas Manocha wrote: >> There is no need to check for sram fill level. If sram is empty, cpu will >> go in the wait state till the time data is available from flash. > > > Consider the following sce

Re: [U-Boot] [v2 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-08-13 Thread vikasm
Hi Marek, On 08/12/2015 07:07 PM, Marek Vasut wrote: > On Thursday, July 16, 2015 at 04:27:29 AM, Vikas Manocha wrote: > > Commit message is missing. Actually subject of the mail was sufficient, this patch just moves the register configuration in init. > >> Signed-off-by: Vikas Manocha >> --

Re: [U-Boot] [PATCH RESEND 0/7] spi: cadence_qspi: optimize & fix indirect rd-writes

2015-08-12 Thread vikasm
Hi Marek, On 08/12/2015 05:26 PM, Marek Vasut wrote: > On Thursday, August 13, 2015 at 02:16:21 AM, vikasm wrote: >> Hi Marek, >> >> On 08/12/2015 01:22 PM, Marek Vasut wrote: >>> On Wednesday, August 12, 2015 at 07:52:28 PM, vikasm wrote: >>>> Than

Re: [U-Boot] [PATCH RESEND 0/7] spi: cadence_qspi: optimize & fix indirect rd-writes

2015-08-12 Thread vikasm
Hi Marek, On 08/12/2015 01:22 PM, Marek Vasut wrote: > On Wednesday, August 12, 2015 at 07:52:28 PM, vikasm wrote: >> Thanks Jagan, >> >> On 08/12/2015 05:01 AM, Jagan Teki wrote: >>> Vikas, >>> >>> Did you verified on board, can you just verifie

Re: [U-Boot] [PATCH RESEND 0/7] spi: cadence_qspi: optimize & fix indirect rd-writes

2015-08-12 Thread vikasm
t; Hi Vikas, >> >> (added Marek to Cc) >> >> >> On 11.08.2015 23:19, vikasm wrote: >>> >>> On 07/23/2015 05:22 AM, Stefan Roese wrote: >>>> >>>> Hi Vikas, >>>> >>>> On 16.07.2015 08:46, Stefan Roese wrote:

Re: [U-Boot] [PATCH RESEND 0/7] spi: cadence_qspi: optimize & fix indirect rd-writes

2015-08-11 Thread vikasm
Hi Stefan, On 07/23/2015 05:22 AM, Stefan Roese wrote: > Hi Vikas, > > On 16.07.2015 08:46, Stefan Roese wrote: > In addition can you please check the patch causing this instability on > socfpga. I don't like to bug you but to close this patchset, this info > & tests mentioned above s

Re: [U-Boot] [PATCH] spi: cadence_qspi: Fix the indirect ahb trigger address setting

2015-05-29 Thread vikasm
Hi Stefan, On 05/28/2015 11:20 PM, Stefan Roese wrote: > Hi Vikas, > > (added Dinh, Graham and Marek to Cc) > > On 29.05.2015 03:22, Vikas Manocha wrote: >> Trigger base address can be set to the spi flash address without any >> masking, here is the explanation of the register. >> >> QSPI_IND_AHB_

Re: [U-Boot] [PATCH] serial: fdt: add device tree support for pl01x

2015-05-04 Thread vikasm
Hello Masahiro, On 05/01/2015 03:32 PM, vikasm wrote: > Thanks Simon, > > On 05/01/2015 03:02 PM, Simon Glass wrote: >> +Masahiro, for my of_match_ptr() comment below. >> >> Hi Vikas, >> >> On 1 May 2015 at 15:48, Vikas Manocha wrote: >>> This pa

Re: [U-Boot] [PATCH v2 1/2] stv0991: fdt: add stv0991 device tree

2015-05-03 Thread vikasm
Thanks Simon, On 05/02/2015 07:26 AM, Simon Glass wrote: > Hi Vikas, > > On 1 May 2015 at 18:07, Vikas Manocha wrote: >> This patch adds device tree for the ST Micro stv0991 board & enables >> device tree control. Progressively device tree support for the drivers >> being used will also be added.

Re: [U-Boot] [PATCH 1/2] stv0991: fdt: add stv0991 device tree

2015-05-01 Thread vikasm
Hi Simon, On 05/01/2015 04:45 PM, Simon Glass wrote: > Hi Vikas, > > On 1 May 2015 at 17:18, vikasm wrote: >> Thanks Simon, >> >> On 05/01/2015 04:01 PM, Simon Glass wrote: >>> Hi Vikas, >>> >>> On 1 May 2015 at 16:43, Vikas Manocha wro

Re: [U-Boot] [PATCH] serial: fdt: add device tree support for pl01x

2015-05-01 Thread vikasm
Thanks Simon, On 05/01/2015 03:02 PM, Simon Glass wrote: > +Masahiro, for my of_match_ptr() comment below. > > Hi Vikas, > > On 1 May 2015 at 15:48, Vikas Manocha wrote: >> This patch adds device tree support for arm pl010/pl011 driver. >> >> Signed-off-by: Vikas Manocha >> --- >> doc/device-tr

Re: [U-Boot] [PATCH 1/2] stv0991: fdt: add stv0991 device tree

2015-05-01 Thread vikasm
Thanks Simon, On 05/01/2015 04:01 PM, Simon Glass wrote: > Hi Vikas, > > On 1 May 2015 at 16:43, Vikas Manocha wrote: > > There is not much to add in the commit message apart from info in the title, that is why i didn't add any message in the body. Please let me know if i am missing something

Re: [U-Boot] [PATCH 10/12] ARM: stv0991: use "select" instead of default value in defconfig

2015-04-13 Thread vikasm
On 03/30/2015 08:48 PM, Masahiro Yamada wrote: > Signed-off-by: Masahiro Yamada > --- > > arch/arm/Kconfig | 2 ++ > configs/stv0991_defconfig | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) Acked-by : Vikas Manocha ___ U-Boot mai

Re: [U-Boot] [PATCH] stv0991: record defconfig ownership in MAINTAINERS

2015-01-05 Thread vikasm
On 12/18/2014 09:19 PM, Masahiro Yamada wrote: > This commit fixes warnings reported by tools/genboardscfg.py. > > Signed-off-by: Masahiro Yamada > Cc: Vikas Manocha > --- > > board/st/stv0991/MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/board/st/stv0991/MAINTAINERS b/bo

Re: [U-Boot] [PATCH v4 0/4] add support for new arch stv0991

2014-11-25 Thread vikasm
Hi Simon, On 11/25/2014 11:50 AM, vikasm wrote: Hello Simon, On 11/18/2014 10:17 AM, vikasm wrote: Hello Simon, On 11/17/2014 09:19 PM, Simon Glass wrote: Hi Vikas, On 18 November 2014 01:30, Vikas Manocha wrote: This patchset add support for new arch stv0991. Changes in v4: - rebased

Re: [U-Boot] [PATCH v4 0/4] add support for new arch stv0991

2014-11-25 Thread vikasm
Hello Simon, On 11/18/2014 10:17 AM, vikasm wrote: Hello Simon, On 11/17/2014 09:19 PM, Simon Glass wrote: Hi Vikas, On 18 November 2014 01:30, Vikas Manocha wrote: This patchset add support for new arch stv0991. Changes in v4: - rebased to current master - added maintainers info Changes

Re: [U-Boot] [PATCH 0/5] PL01x: baudrate & line control fixes

2014-11-25 Thread vikasm
Hello Simon, On 11/24/2014 07:51 PM, Simon Glass wrote: Hi Vikas, On 24 November 2014 at 17:40, vikasm wrote: Hi Simon, On 11/24/2014 07:51 AM, Simon Glass wrote: Hi Vikas, On 18 November 2014 at 11:59, vikasm wrote: Thanks Simon, On 11/17/2014 09:30 PM, Simon Glass wrote: Hi Vikas

Re: [U-Boot] [PATCH 0/5] PL01x: baudrate & line control fixes

2014-11-24 Thread vikasm
Hi Simon, On 11/24/2014 07:51 AM, Simon Glass wrote: Hi Vikas, On 18 November 2014 at 11:59, vikasm wrote: Thanks Simon, On 11/17/2014 09:30 PM, Simon Glass wrote: Hi Vikas, On 18 November 2014 00:17, Vikas Manocha wrote: This patchset fixes the pl01x driver esp for pl011 baudrate

Re: [U-Boot] [PATCH 0/5] PL01x: baudrate & line control fixes

2014-11-18 Thread vikasm
Thanks Simon, On 11/17/2014 09:30 PM, Simon Glass wrote: Hi Vikas, On 18 November 2014 00:17, Vikas Manocha wrote: This patchset fixes the pl01x driver esp for pl011 baudrate & line control. Vikas Manocha (5): serial: pl01x: pass pl01x_type to set baudrate serial: pl01x: fix pl011 baud

Re: [U-Boot] [PATCH v4 0/4] add support for new arch stv0991

2014-11-18 Thread vikasm
Hello Simon, On 11/17/2014 09:19 PM, Simon Glass wrote: Hi Vikas, On 18 November 2014 01:30, Vikas Manocha wrote: This patchset add support for new arch stv0991. Changes in v4: - rebased to current master - added maintainers info Changes in v3: - removed period from commit messages Changes

Re: [U-Boot] [PATCH v4 3/4] stv0991: default + misc command configs enabled

2014-11-18 Thread vikasm
Hello Albert, On 11/17/2014 11:29 PM, Albert ARIBAUD wrote: Hello Vikas, (nitpicking) can you replace '+' in the subject with 'and' ? ok, i will submit the v5. (nitpicking yet more) can you keep the "action" form for the subject rather than "action done", i.e., "stv0991: enable default and

Re: [U-Boot] [PATCH v4 1/4] stv0991: Add basic stv0991 architecture support

2014-11-18 Thread vikasm
Thanks Albert, On 11/17/2014 11:21 PM, Albert ARIBAUD wrote: Hello Vikas, On Mon, 17 Nov 2014 17:30:25 -0800, Vikas Manocha wrote: stv0991 architecture support added. It contains the support for following blocks - Timer - uart Signed-off-by: Vikas Manocha --- Changes in v4: - added maintai

Re: [U-Boot] [PATCH v3 0/3] add support for new arch stv0991

2014-09-16 Thread vikasm
Hello Masahiro/Nobuhiro, As per your comments , the changes are done in V3 patchset. Please provide your acceptance for reviewed-by or acked-by tag ? Rgds, Vikas On 09/02/2014 03:04 PM, Vikas MANOCHA wrote: This patchset add support for new arch stv0991. Changes in v3: - removed period from c

Re: [U-Boot] [PATCH v2 1/3] stv0991 : Add basic stv0991 architecture support.

2014-09-02 Thread vikasm
Thanks Masahiro, On 08/30/2014 11:25 PM, Masahiro YAMADA wrote: Hi Vikas stv0991 : Add basic stv0991 architecture support. Please do not add a priod at the end of the commit subject when you post patches next time. I agree, i will remove the periods & submit v3. Rgds, Vikas This is ment

Re: [U-Boot] [PATCH 1/3] stv0991 : Add basic stv0991 architecture support.

2014-08-28 Thread vikasm
Thanks Nobuhiro, On 08/25/2014 06:47 PM, Nobuhiro Iwamatsu wrote: Hi, 2014-08-23 4:43 GMT+09:00 Vikas Manocha : stv0991 architecture support added. It contains the support for following blocks - Timer - uart Signed-off-by: Vikas Manocha --- arch/arm/Kconfig