Re: [PATCH] Add Phytec i.MX93 support

2024-01-24 Thread Yannic Moog
On Wed, 2024-01-24 at 14:30 +0100, Mathieu Othacehe wrote: > > Hello Yannic, > > > As a heads-up: you need to rebase as am62 (doc) got applied by Tom. > > Noted. > > > Is the trusted-firmware-a upstream version working? If so, please use that > > instead. > > It is but only on the master bran

Re: [PATCH] Add Phytec i.MX93 support

2024-01-24 Thread Mathieu Othacehe
Hello Yannic, > As a heads-up: you need to rebase as am62 (doc) got applied by Tom. Noted. > Is the trusted-firmware-a upstream version working? If so, please use that > instead. It is but only on the master branch, so it might be better to stick to the nxp-imx repository until a lts release

Re: [PATCH] Add Phytec i.MX93 support

2024-01-18 Thread Yannic Moog
Hello Mathieu As a heads-up: you need to rebase as am62 (doc) got applied by Tom. On Wed, 2024-01-17 at 08:52 +0100, Mathieu Othacehe wrote: > Add support for the Phytec i.MX93 Segin evaluation kit. The SoM consists > of an NXP i.MX93 dual A55 CPU. The SoM is mounted on a Phytec Segin SBC. > > S

Re: [Upstream] [PATCH] Add Phytec i.MX93 support

2024-01-18 Thread Yannic Moog
Hi Mathieu On Thu, 2024-01-18 at 12:04 +0100, Mathieu Othacehe wrote: > > Hi, > > Thanks for the review! > > > s/imx93_phycore/phycore_imx93 > > > > To fit into existing PHYTEC boards already in tree. > > I deliberately picked that order so that it is aligned with most imx > boards already su

Re: [PATCH] Add Phytec i.MX93 support

2024-01-18 Thread Mathieu Othacehe
Hi, Thanks for the review! > s/imx93_phycore/phycore_imx93 > > To fit into existing PHYTEC boards already in tree. I deliberately picked that order so that it is aligned with most imx boards already supported by u-boot. The supported imx93 boards follow that pattern: - imx93_var_som - imx93_

Re: [PATCH] Add Phytec i.MX93 support

2024-01-18 Thread Primoz Fiser
Hi Mathieu, I already gave my review on the kernel mailing list. As first step, naming scheme is not compatible with PHYTEC naming convention. Please fix it across the entire patch. Maybe reference downstream u-boot for that? Please also use "phyBOARD-Segin-i.MX93" when referencing the board as

[PATCH] Add Phytec i.MX93 support

2024-01-17 Thread Mathieu Othacehe
Add support for the Phytec i.MX93 Segin evaluation kit. The SoM consists of an NXP i.MX93 dual A55 CPU. The SoM is mounted on a Phytec Segin SBC. Signed-off-by: Mathieu Othacehe --- arch/arm/dts/Makefile |3 +- arch/arm/dts/imx93-phycore-segin-u-boot.dtsi | 274 +++

Re: [PATCH] Add Phytec i.MX93 support

2024-01-17 Thread Fabio Estevam
Hi Mathieu, Thanks for the patch. I have added more Phytec folks in case they could help review/test. On Wed, Jan 17, 2024 at 4:53 AM Mathieu Othacehe wrote: > > Add support for the Phytec i.MX93 Segin evaluation kit. The SoM consists > of an NXP i.MX93 dual A55 CPU. The SoM is mounted on a Phy