Re: [EXT] Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-09 Thread Tom Rini
On Mon, Aug 09, 2021 at 04:11:36PM +0200, Wolfgang Denk wrote: > Dear Tom, > > In message <20210809131640.GN858@bill-the-cat> you wrote: > > > > Thanks for explaining. It sounds like > > arch/arm/mach-imx/imx8m/soc.c::the=A0ft_system_setup() needs a comment > > that it uses a lot of stack, due t

Re: [EXT] Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-09 Thread Wolfgang Denk
Dear Tom, In message <20210809131640.GN858@bill-the-cat> you wrote: > > Thanks for explaining. It sounds like > arch/arm/mach-imx/imx8m/soc.c::the=A0ft_system_setup() needs a comment > that it uses a lot of stack, due to how complex it is, and that I think this is the wrong approach. It sounds

Re: [EXT] Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-09 Thread Tom Rini
On Mon, Aug 09, 2021 at 07:34:34AM +, Ye Li wrote: > Hi Marek, > > On Sun, 2021-08-08 at 17:25 +0200, Marek Vasut wrote: > > Caution: EXT Email > > > > On 8/8/21 4:54 PM, Tom Rini wrote: > > > > [...] > > > > > > > > > > > > > > > > > > > I expect it was not simply because up > > > > > u

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-09 Thread Tom Rini
On Mon, Aug 09, 2021 at 08:44:58AM +0200, Wolfgang Denk wrote: > Dear Marek, > > In message <03720507-5ea4-0fb9-0549-37df3128b...@denx.de> you wrote: > > > > The IMX thing is odd indeed and raises a bigger question -- what is the > > "right" amount of stack to reserve ? > > In the original U-Boo

Re: [EXT] Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-09 Thread Ye Li
Hi Marek, On Sun, 2021-08-08 at 17:25 +0200, Marek Vasut wrote: > Caution: EXT Email > > On 8/8/21 4:54 PM, Tom Rini wrote: > > [...] > > > > > > > > > > > > > > I expect it was not simply because up > > > > until rather recently we didn't have any checks for "don't > > > > overwrite > > > >

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Wolfgang Denk
Dear Marek, In message <03720507-5ea4-0fb9-0549-37df3128b...@denx.de> you wrote: > > The IMX thing is odd indeed and raises a bigger question -- what is the > "right" amount of stack to reserve ? In the original U-Boot design (which is still documented in the README, see section "Memory Manageme

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Tom Rini
On Thu, Jul 29, 2021 at 09:22:02AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. > > While the goal is valid and there is surely unused memory in that area, > we also have a lot of crucial things still located at the top-of-memory

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Tom Rini
On Sun, Aug 08, 2021 at 05:25:33PM +0200, Marek Vasut wrote: > On 8/8/21 4:54 PM, Tom Rini wrote: > > [...] > > > > > I expect it was not simply because up > > > > until rather recently we didn't have any checks for "don't overwrite > > > > specific areas of memory" other than right before firing

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Marek Vasut
On 8/8/21 4:54 PM, Tom Rini wrote: [...] I expect it was not simply because up until rather recently we didn't have any checks for "don't overwrite specific areas of memory" other than right before firing off the OS (and modify whatever memory you want to modify is a feature not a bug). The L

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Tom Rini
On Sun, Aug 08, 2021 at 04:28:14PM +0200, Marek Vasut wrote: > On 8/8/21 4:00 PM, Tom Rini wrote: > > On Sun, Aug 08, 2021 at 03:45:30PM +0200, Marek Vasut wrote: > > > On 8/6/21 6:49 PM, Tom Rini wrote: > > > > On Fri, Aug 06, 2021 at 12:22:43AM +0200, Marek Vasut wrote: > > > > > On 8/3/21 11:51

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Marek Vasut
On 8/8/21 4:00 PM, Tom Rini wrote: On Sun, Aug 08, 2021 at 03:45:30PM +0200, Marek Vasut wrote: On 8/6/21 6:49 PM, Tom Rini wrote: On Fri, Aug 06, 2021 at 12:22:43AM +0200, Marek Vasut wrote: On 8/3/21 11:51 PM, Tom Rini wrote: On Mon, Aug 02, 2021 at 05:27:59PM -0400, Tom Rini wrote: On Thu

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Tom Rini
On Sun, Aug 08, 2021 at 03:45:30PM +0200, Marek Vasut wrote: > On 8/6/21 6:49 PM, Tom Rini wrote: > > On Fri, Aug 06, 2021 at 12:22:43AM +0200, Marek Vasut wrote: > > > On 8/3/21 11:51 PM, Tom Rini wrote: > > > > On Mon, Aug 02, 2021 at 05:27:59PM -0400, Tom Rini wrote: > > > > > On Thu, Jul 29, 20

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Marek Vasut
On 8/6/21 6:49 PM, Tom Rini wrote: On Fri, Aug 06, 2021 at 12:22:43AM +0200, Marek Vasut wrote: On 8/3/21 11:51 PM, Tom Rini wrote: On Mon, Aug 02, 2021 at 05:27:59PM -0400, Tom Rini wrote: On Thu, Jul 29, 2021 at 09:22:02AM +0200, Jan Kiszka wrote: From: Jan Kiszka This reverts commit 235

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-08 Thread Marek Vasut
On 8/6/21 1:31 AM, Tom Rini wrote: On Thu, Aug 05, 2021 at 11:53:24PM +0200, Marek Vasut wrote: On 8/2/21 3:00 PM, Tom Rini wrote: On Mon, Aug 02, 2021 at 02:54:22AM +0200, Marek Vasut wrote: On 7/29/21 6:58 PM, Tom Rini wrote: [...] so when did rcar3 introduce something there that shouldn'

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-06 Thread Tom Rini
On Fri, Aug 06, 2021 at 12:22:43AM +0200, Marek Vasut wrote: > On 8/3/21 11:51 PM, Tom Rini wrote: > > On Mon, Aug 02, 2021 at 05:27:59PM -0400, Tom Rini wrote: > > > On Thu, Jul 29, 2021 at 09:22:02AM +0200, Jan Kiszka wrote: > > > > > > > From: Jan Kiszka > > > > > > > > This reverts commit 23

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-06 Thread Tom Rini
On Thu, Aug 05, 2021 at 11:52:05PM +0200, Marek Vasut wrote: > On 8/2/21 4:44 PM, Tom Rini wrote: > > On Mon, Aug 02, 2021 at 04:34:29PM +0200, Jan Kiszka wrote: > > > On 02.08.21 16:27, Tom Rini wrote: > > > > On Mon, Aug 02, 2021 at 04:03:01PM +0200, Jan Kiszka wrote: > > > > > On 02.08.21 15:04,

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-05 Thread Tom Rini
On Thu, Aug 05, 2021 at 11:53:24PM +0200, Marek Vasut wrote: > On 8/2/21 3:00 PM, Tom Rini wrote: > > On Mon, Aug 02, 2021 at 02:54:22AM +0200, Marek Vasut wrote: > > > On 7/29/21 6:58 PM, Tom Rini wrote: > > > > > > [...] > > > > > > > > > so when did rcar3 introduce something there that shouldn

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-05 Thread Marek Vasut
On 8/3/21 11:51 PM, Tom Rini wrote: On Mon, Aug 02, 2021 at 05:27:59PM -0400, Tom Rini wrote: On Thu, Jul 29, 2021 at 09:22:02AM +0200, Jan Kiszka wrote: From: Jan Kiszka This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. While the goal is valid and there is surely unused memory

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-05 Thread Marek Vasut
On 8/2/21 3:00 PM, Tom Rini wrote: On Mon, Aug 02, 2021 at 02:54:22AM +0200, Marek Vasut wrote: On 7/29/21 6:58 PM, Tom Rini wrote: [...] so when did rcar3 introduce something there that shouldn't be reserved? And you had phrased this to me on IRC as about reserving spot for ATAGS, and that

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-05 Thread Marek Vasut
On 8/2/21 4:44 PM, Tom Rini wrote: On Mon, Aug 02, 2021 at 04:34:29PM +0200, Jan Kiszka wrote: On 02.08.21 16:27, Tom Rini wrote: On Mon, Aug 02, 2021 at 04:03:01PM +0200, Jan Kiszka wrote: On 02.08.21 15:04, Tom Rini wrote: On Mon, Aug 02, 2021 at 01:54:57PM +0200, Jan Kiszka wrote: On 02.0

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-03 Thread Tom Rini
On Mon, Aug 02, 2021 at 05:27:59PM -0400, Tom Rini wrote: > On Thu, Jul 29, 2021 at 09:22:02AM +0200, Jan Kiszka wrote: > > > From: Jan Kiszka > > > > This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. > > > > While the goal is valid and there is surely unused memory in that area, >

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Tom Rini
On Thu, Jul 29, 2021 at 09:22:02AM +0200, Jan Kiszka wrote: > From: Jan Kiszka > > This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. > > While the goal is valid and there is surely unused memory in that area, > we also have a lot of crucial things still located at the top-of-memory

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 04:34:29PM +0200, Jan Kiszka wrote: > On 02.08.21 16:27, Tom Rini wrote: > > On Mon, Aug 02, 2021 at 04:03:01PM +0200, Jan Kiszka wrote: > >> On 02.08.21 15:04, Tom Rini wrote: > >>> On Mon, Aug 02, 2021 at 01:54:57PM +0200, Jan Kiszka wrote: > On 02.08.21 13:38, Marek

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Jan Kiszka
On 02.08.21 16:27, Tom Rini wrote: > On Mon, Aug 02, 2021 at 04:03:01PM +0200, Jan Kiszka wrote: >> On 02.08.21 15:04, Tom Rini wrote: >>> On Mon, Aug 02, 2021 at 01:54:57PM +0200, Jan Kiszka wrote: On 02.08.21 13:38, Marek Vasut wrote: > On 8/2/21 1:36 PM, Jan Kiszka wrote: >> On 02.0

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 04:03:01PM +0200, Jan Kiszka wrote: > On 02.08.21 15:04, Tom Rini wrote: > > On Mon, Aug 02, 2021 at 01:54:57PM +0200, Jan Kiszka wrote: > >> On 02.08.21 13:38, Marek Vasut wrote: > >>> On 8/2/21 1:36 PM, Jan Kiszka wrote: > On 02.08.21 12:48, Marek Vasut wrote: > >

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Jan Kiszka
On 02.08.21 15:04, Tom Rini wrote: > On Mon, Aug 02, 2021 at 01:54:57PM +0200, Jan Kiszka wrote: >> On 02.08.21 13:38, Marek Vasut wrote: >>> On 8/2/21 1:36 PM, Jan Kiszka wrote: On 02.08.21 12:48, Marek Vasut wrote: > On 8/2/21 11:37 AM, Jan Kiszka wrote: >> On 02.08.21 02:54, Marek V

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 01:54:57PM +0200, Jan Kiszka wrote: > On 02.08.21 13:38, Marek Vasut wrote: > > On 8/2/21 1:36 PM, Jan Kiszka wrote: > >> On 02.08.21 12:48, Marek Vasut wrote: > >>> On 8/2/21 11:37 AM, Jan Kiszka wrote: > On 02.08.21 02:54, Marek Vasut wrote: > > On 7/29/21 6:58 PM

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Tom Rini
On Mon, Aug 02, 2021 at 02:54:22AM +0200, Marek Vasut wrote: > On 7/29/21 6:58 PM, Tom Rini wrote: > > [...] > > > > > so when did rcar3 introduce something there that shouldn't be > > > > reserved? And you had phrased this to me on IRC as about reserving spot > > > > for ATAGS, and that not bei

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Jan Kiszka
On 02.08.21 13:38, Marek Vasut wrote: > On 8/2/21 1:36 PM, Jan Kiszka wrote: >> On 02.08.21 12:48, Marek Vasut wrote: >>> On 8/2/21 11:37 AM, Jan Kiszka wrote: On 02.08.21 02:54, Marek Vasut wrote: > On 7/29/21 6:58 PM, Tom Rini wrote: > > [...] > so when did rcar3 int

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Marek Vasut
On 8/2/21 1:36 PM, Jan Kiszka wrote: On 02.08.21 12:48, Marek Vasut wrote: On 8/2/21 11:37 AM, Jan Kiszka wrote: On 02.08.21 02:54, Marek Vasut wrote: On 7/29/21 6:58 PM, Tom Rini wrote: [...] so when did rcar3 introduce something there that shouldn't be reserved?  And you had phrased this

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Jan Kiszka
On 02.08.21 12:48, Marek Vasut wrote: > On 8/2/21 11:37 AM, Jan Kiszka wrote: >> On 02.08.21 02:54, Marek Vasut wrote: >>> On 7/29/21 6:58 PM, Tom Rini wrote: >>> >>> [...] >>> >> so when did rcar3 introduce something there that shouldn't be >> reserved?  And you had phrased this to me on I

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Marek Vasut
On 8/2/21 11:37 AM, Jan Kiszka wrote: On 02.08.21 02:54, Marek Vasut wrote: On 7/29/21 6:58 PM, Tom Rini wrote: [...] so when did rcar3 introduce something there that shouldn't be reserved?  And you had phrased this to me on IRC as about reserving spot for ATAGS, and that not being needed of

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-02 Thread Jan Kiszka
On 02.08.21 02:54, Marek Vasut wrote: > On 7/29/21 6:58 PM, Tom Rini wrote: > > [...] > so when did rcar3 introduce something there that shouldn't be reserved?  And you had phrased this to me on IRC as about reserving spot for ATAGS, and that not being needed of course on arm6

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-08-01 Thread Marek Vasut
On 7/29/21 6:58 PM, Tom Rini wrote: [...] so when did rcar3 introduce something there that shouldn't be reserved? And you had phrased this to me on IRC as about reserving spot for ATAGS, and that not being needed of course on arm64. But that's not what's going on. Perhaps the answer is that

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-07-29 Thread Tom Rini
On Thu, Jul 29, 2021 at 06:47:02PM +0200, Marek Vasut wrote: > On 7/29/21 5:23 PM, Tom Rini wrote: > > On Thu, Jul 29, 2021 at 05:01:09PM +0200, Marek Vasut wrote: > > > On 7/29/21 9:22 AM, Jan Kiszka wrote: > > > > From: Jan Kiszka > > > > > > > > This reverts commit 2359fa7a87848626bcbd3399e92c

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-07-29 Thread Marek Vasut
On 7/29/21 5:23 PM, Tom Rini wrote: On Thu, Jul 29, 2021 at 05:01:09PM +0200, Marek Vasut wrote: On 7/29/21 9:22 AM, Jan Kiszka wrote: From: Jan Kiszka This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. While the goal is valid and there is surely unused memory in that area, we als

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-07-29 Thread Tom Rini
On Thu, Jul 29, 2021 at 05:01:09PM +0200, Marek Vasut wrote: > On 7/29/21 9:22 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > > > This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. > > > > While the goal is valid and there is surely unused memory in that area, > > we also have a lot o

Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-07-29 Thread Marek Vasut
On 7/29/21 9:22 AM, Jan Kiszka wrote: From: Jan Kiszka This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. While the goal is valid and there is surely unused memory in that area, we also have a lot of crucial things still located at the top-of-memory while running lmb_alloc_base. Suc

[PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64"

2021-07-29 Thread Jan Kiszka
From: Jan Kiszka This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. While the goal is valid and there is surely unused memory in that area, we also have a lot of crucial things still located at the top-of-memory while running lmb_alloc_base. Such things are the page table (tlb_addr),