Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-02-11 Thread Michael Nazzareno Trimarchi
Hi Linus On Fri, Feb 3, 2023 at 6:23 PM William Zhang wrote: > > Hi Linus and Michael, > > On 02/03/2023 03:10 AM, Linus Walleij wrote: > > On Fri, Feb 3, 2023 at 9:48 AM Michael Nazzareno Trimarchi > > wrote: > >> On Thu, Jan 26, 2023 at 6:39 PM William Zhang > >> wrote: > >>> > >>> > >>> > >>

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-02-03 Thread William Zhang
Hi Linus and Michael, On 02/03/2023 03:10 AM, Linus Walleij wrote: On Fri, Feb 3, 2023 at 9:48 AM Michael Nazzareno Trimarchi wrote: On Thu, Jan 26, 2023 at 6:39 PM William Zhang wrote: On 01/26/2023 12:43 AM, Linus Walleij wrote: On Thu, Jan 26, 2023 at 2:02 AM William Zhang wrote:

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-02-03 Thread Linus Walleij
On Fri, Feb 3, 2023 at 9:48 AM Michael Nazzareno Trimarchi wrote: > On Thu, Jan 26, 2023 at 6:39 PM William Zhang > wrote: > > > > > > > > On 01/26/2023 12:43 AM, Linus Walleij wrote: > > > On Thu, Jan 26, 2023 at 2:02 AM William Zhang > > > wrote: > > > > > Can you add your review-by? I think

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-02-03 Thread Michael Nazzareno Trimarchi
Hi William On Thu, Jan 26, 2023 at 6:39 PM William Zhang wrote: > > > > On 01/26/2023 12:43 AM, Linus Walleij wrote: > > On Thu, Jan 26, 2023 at 2:02 AM William Zhang > > wrote: > > Can you add your review-by? Michael > >> Unfortunately the u-boot nand base code still uses nand_ecclayout > >>

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-01-26 Thread William Zhang
On 01/26/2023 12:43 AM, Linus Walleij wrote: On Thu, Jan 26, 2023 at 2:02 AM William Zhang wrote: Unfortunately the u-boot nand base code still uses nand_ecclayout structure because it was based on old kernel nand driver. Your change cause bugcheck in the nand_scan_tail at line 4978 when mt

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-01-26 Thread Linus Walleij
On Thu, Jan 26, 2023 at 2:02 AM William Zhang wrote: > Unfortunately the u-boot nand base code still uses nand_ecclayout > structure because it was based on old kernel nand driver. Your change > cause bugcheck in the nand_scan_tail at line 4978 when mtd->oobsize is > not one of the default size

Re: [PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-01-25 Thread William Zhang
Hi Linus, Unfortunately the u-boot nand base code still uses nand_ecclayout structure because it was based on old kernel nand driver. Your change cause bugcheck in the nand_scan_tail at line 4978 when mtd->oobsize is not one of the default size (i.e. some large nand with BCH-8 ecc requiremen

[PATCH 01/14] mtd: nand: brcm: switch to mtd_ooblayout_ops

2023-01-15 Thread Linus Walleij
From: Boris Brezillon Implementing the mtd_ooblayout_ops interface is the new way of exposing ECC/OOB layout to MTD users. Signed-off-by: Boris Brezillon [Ported to U-Boot from the Linux kernel] Signed-off-by: Linus Walleij --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 260 ++