Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Kever Yang
Hi Vasily, On 2023/3/8 05:34, Vasily Khoruzhick wrote: On Tue, Mar 7, 2023 at 1:04 PM Mark Kettenis wrote: And implement support for the CLK_PCIEPHYn_REF clocks in drivers/clk/rockchip/clk_rk3568.c:rk3568_pmuclk_set_rate()? Yes, I'd say so. If U-Boot doesn't actually need these clocks to

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
On Tue, Mar 7, 2023 at 1:04 PM Mark Kettenis wrote: > And implement support for the CLK_PCIEPHYn_REF clocks in > drivers/clk/rockchip/clk_rk3568.c:rk3568_pmuclk_set_rate()? > > Yes, I'd say so. > > If U-Boot doesn't actually need these clocks to run at the frequency > provided by

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Mark Kettenis
> From: Vasily Khoruzhick > Date: Tue, 7 Mar 2023 12:34:48 -0800 > > On Tue, Mar 7, 2023 at 11:53 AM Mark Kettenis wrote: > > > That is probably the wrong approach. It should be possible to boot an > > OS with the device tree provided by U-Boot. Removing these properties > > means the OS

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
On Tue, Mar 7, 2023 at 11:53 AM Mark Kettenis wrote: > That is probably the wrong approach. It should be possible to boot an > OS with the device tree provided by U-Boot. Removing these properties > means the OS doesn't see them either. But if the assigned-clocks > property isn't needed it

Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Mark Kettenis
> From: Vasily Khoruzhick > Date: Tue, 7 Mar 2023 11:37:48 -0800 > > combphy0 is failing to probe due to unhandled assigned-clocks and > assigned-clocks-rates. That is probably the wrong approach. It should be possible to boot an OS with the device tree provided by U-Boot. Removing these

[PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates

2023-03-07 Thread Vasily Khoruzhick
combphy0 is failing to probe due to unhandled assigned-clocks and assigned-clocks-rates. commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates") dropped these properties for combphy1, so let's drop them for combphy0 as well. Signed-off-by: Vasily Khoruzhick ---