Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-10 Thread Tom Rini
On Wed, Jan 10, 2024 at 06:06:45PM +0200, Roger Quadros wrote: > +Lukasz & Mattijs > > On 10/01/2024 11:34, Roger Quadros wrote: > > > > > > On 09/01/2024 22:00, Francesco Dolcini wrote: > >> On Tue, Jan 09, 2024 at 02:54:00PM -0500, Tom Rini wrote: > >>> On Tue, Jan 09, 2024 at 01:18:59PM -0600

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-10 Thread Roger Quadros
+Lukasz & Mattijs On 10/01/2024 11:34, Roger Quadros wrote: > > > On 09/01/2024 22:00, Francesco Dolcini wrote: >> On Tue, Jan 09, 2024 at 02:54:00PM -0500, Tom Rini wrote: >>> On Tue, Jan 09, 2024 at 01:18:59PM -0600, Nishanth Menon wrote: On 14:26-20240109, Roger Quadros wrote: > CON

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-10 Thread Roger Quadros
On 09/01/2024 22:00, Francesco Dolcini wrote: > On Tue, Jan 09, 2024 at 02:54:00PM -0500, Tom Rini wrote: >> On Tue, Jan 09, 2024 at 01:18:59PM -0600, Nishanth Menon wrote: >>> On 14:26-20240109, Roger Quadros wrote: CONFIG_CMD_PMIC=y CONFIG_CMD_REGULATOR=y +CONFIG_CMD_MTDPARTS=

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Tom Rini
On Tue, Jan 09, 2024 at 02:00:14PM -0600, Nishanth Menon wrote: > On 14:48-20240109, Tom Rini wrote: > [...] > > > > -- > > > > 2.34.1 > > > > > > > > > > Why not a config fragment? > > > > To me, this makes sense to keep in the main config. It can be turned off > > as needed, and at run time i

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
On 21:00-20240109, Francesco Dolcini wrote: > On Tue, Jan 09, 2024 at 02:54:00PM -0500, Tom Rini wrote: > > On Tue, Jan 09, 2024 at 01:18:59PM -0600, Nishanth Menon wrote: > > > On 14:26-20240109, Roger Quadros wrote: > > > > CONFIG_CMD_PMIC=y > > > > CONFIG_CMD_REGULATOR=y > > > > +CONFIG_CMD_MT

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Francesco Dolcini
On Tue, Jan 09, 2024 at 02:54:00PM -0500, Tom Rini wrote: > On Tue, Jan 09, 2024 at 01:18:59PM -0600, Nishanth Menon wrote: > > On 14:26-20240109, Roger Quadros wrote: > > > CONFIG_CMD_PMIC=y > > > CONFIG_CMD_REGULATOR=y > > > +CONFIG_CMD_MTDPARTS=y > > > +CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
On 14:48-20240109, Tom Rini wrote: [...] > > > -- > > > 2.34.1 > > > > > > > Why not a config fragment? > > To me, this makes sense to keep in the main config. It can be turned off > as needed, and at run time if it's not present, it's safe. Three reasons: * There is going to be duplication ac

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Tom Rini
On Tue, Jan 09, 2024 at 01:18:59PM -0600, Nishanth Menon wrote: > On 14:26-20240109, Roger Quadros wrote: > > Enables configuration required for NAND in SPL and u-boot. > > > > Enable MTD Driver model and MTD + UBI command line utilities. > > > > Add mtdids/mtdparts for NAND as it is required for

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Tom Rini
On Tue, Jan 09, 2024 at 01:16:27PM -0600, Nishanth Menon wrote: > On 14:26-20240109, Roger Quadros wrote: > > Enables configuration required for NAND in SPL and u-boot. > > > > Enable MTD Driver model and MTD + UBI command line utilities. > > > > Add mtdids/mtdparts for NAND as it is required for

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
On 14:26-20240109, Roger Quadros wrote: > Enables configuration required for NAND in SPL and u-boot. > > Enable MTD Driver model and MTD + UBI command line utilities. > > Add mtdids/mtdparts for NAND as it is required for u-boot's > MTD subsystem commands to recognize NAND partitions. > > Add u-

Re: [PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Nishanth Menon
On 14:26-20240109, Roger Quadros wrote: > Enables configuration required for NAND in SPL and u-boot. > > Enable MTD Driver model and MTD + UBI command line utilities. > > Add mtdids/mtdparts for NAND as it is required for u-boot's > MTD subsystem commands to recognize NAND partitions. > > Add u-

[PATCH 4/4] configs: am64x_evm_a53_defconfig: Enable NAND

2024-01-09 Thread Roger Quadros
Enables configuration required for NAND in SPL and u-boot. Enable MTD Driver model and MTD + UBI command line utilities. Add mtdids/mtdparts for NAND as it is required for u-boot's MTD subsystem commands to recognize NAND partitions. Add u-boot partition location. Signed-off-by: Roger Quadros