Re: [PATCH 7/8] spl: fit: Replace #ifdef blocks with more readable constructs

2020-12-21 Thread Simon Glass
Hi Alex, On Mon, 21 Dec 2020 at 10:43, Alex G. wrote: > > > > On 12/18/20 8:29 PM, Simon Glass wrote: > > On Tue, 15 Dec 2020 at 17:10, Alexandru Gagniuc > > wrote: > >> > >> Use the IS_ENABLED() macro to control code flow, instead of the > >> caveman approach of sprinkling #ifdefs. Code size i

Re: [PATCH 7/8] spl: fit: Replace #ifdef blocks with more readable constructs

2020-12-21 Thread Alex G.
On 12/18/20 8:29 PM, Simon Glass wrote: On Tue, 15 Dec 2020 at 17:10, Alexandru Gagniuc wrote: Use the IS_ENABLED() macro to control code flow, instead of the caveman approach of sprinkling #ifdefs. Code size is not affected, as the linker garbage-collects unused functions. However, readabi

Re: [PATCH 7/8] spl: fit: Replace #ifdef blocks with more readable constructs

2020-12-18 Thread Simon Glass
On Tue, 15 Dec 2020 at 17:10, Alexandru Gagniuc wrote: > > Use the IS_ENABLED() macro to control code flow, instead of the > caveman approach of sprinkling #ifdefs. Code size is not affected, as > the linker garbage-collects unused functions. However, readability is > improved significantly. > > S

[PATCH 7/8] spl: fit: Replace #ifdef blocks with more readable constructs

2020-12-15 Thread Alexandru Gagniuc
Use the IS_ENABLED() macro to control code flow, instead of the caveman approach of sprinkling #ifdefs. Code size is not affected, as the linker garbage-collects unused functions. However, readability is improved significantly. Signed-off-by: Alexandru Gagniuc --- common/spl/spl_fit.c | 53 +