Re: [PATCH v2 2/5] sunxi: psci: refactor register access to separate functions

2023-08-18 Thread Sam Edwards
On 8/18/23 07:57, Andre Przywara wrote: On Wed, 16 Aug 2023 10:34:17 -0700 Sam Edwards wrote: Hi Sam, Likewise Andre, -static void __secure sunxi_set_entry_address(void *entry) +static void __secure sunxi_cpu_set_entry(int __always_unused cpu, void *entry) So what is the reasoning behind

Re: [PATCH v2 2/5] sunxi: psci: refactor register access to separate functions

2023-08-18 Thread Andre Przywara
On Wed, 16 Aug 2023 10:34:17 -0700 Sam Edwards wrote: Hi Sam, > This is to prepare for R528, which does not have the typical > "CPUCFG" block; it has a "CPUX" block which provides these > same functions but is organized differently. > > Moving the hardware-access bits to their own functions sep

[PATCH v2 2/5] sunxi: psci: refactor register access to separate functions

2023-08-16 Thread Sam Edwards
This is to prepare for R528, which does not have the typical "CPUCFG" block; it has a "CPUX" block which provides these same functions but is organized differently. Moving the hardware-access bits to their own functions separates the logic from the hardware so we can reuse the same logic. Signed-