Re: [PATCH v2 5/5] power: regulator: tps65941: Add TPS65224 PMIC regulator support

2024-03-09 Thread Dan Carpenter
On Fri, Mar 08, 2024 at 02:40:11PM +0530, Dhruva Gole wrote: > > + > > + if (val < 0 || val > mask) > > + return -EINVAL; > > Probably combine this with below if's, eitherway is fine. > > > + > > + if (val <= reg_base) > > + return base; > > + > > + if (val >= reg_max) >

Re: [PATCH v2 5/5] power: regulator: tps65941: Add TPS65224 PMIC regulator support

2024-03-08 Thread Dhruva Gole
Hi, On Mar 06, 2024 at 19:09:47 +0530, Bhargav Raviprakash wrote: > Reuse TPS65941 regulator driver to adds support for > TPS65224 PMIC's regulators. 4 BUCKs and 3 LDOs, where > BUCK1 and BUCK2 can be configured in dual phase mode. > > Signed-off-by: Bhargav Raviprakash > --- > drivers/power/re

[PATCH v2 5/5] power: regulator: tps65941: Add TPS65224 PMIC regulator support

2024-03-06 Thread Bhargav Raviprakash
Reuse TPS65941 regulator driver to adds support for TPS65224 PMIC's regulators. 4 BUCKs and 3 LDOs, where BUCK1 and BUCK2 can be configured in dual phase mode. Signed-off-by: Bhargav Raviprakash --- drivers/power/regulator/tps65941_regulator.c | 280 ++- 1 file changed, 267 inser