Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-28 Thread Jagan Teki
On Sat, Mar 28, 2020 at 9:38 PM André Przywara wrote: > > On 28/03/2020 14:32, Jagan Teki wrote: > > On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard wrote: > >> > >> commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > >> Kconfig") intended to support CONFIG_PREBOOT, but > >>

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-28 Thread André Przywara
On 28/03/2020 14:32, Jagan Teki wrote: > On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard wrote: >> >> commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to >> Kconfig") intended to support CONFIG_PREBOOT, but >> include/configs/sunxi-common.h hardcodes preboot as part of

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-28 Thread Jonas Smedegaard
Quoting Jagan Teki (2020-03-28 15:32:46) > On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard wrote: > > > > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > > Kconfig") intended to support CONFIG_PREBOOT, but > > include/configs/sunxi-common.h hardcodes preboot as part of

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-28 Thread Jagan Teki
On Tue, Mar 3, 2020 at 8:37 PM Jonas Smedegaard wrote: > > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > Kconfig") intended to support CONFIG_PREBOOT, but > include/configs/sunxi-common.h hardcodes preboot as part of internally > defined CONSOLE_STDIN_SETTINGS, silently

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-04 Thread Jonas Smedegaard
Quoting Andre Przywara (2020-03-04 11:59:40) > On Tue, 3 Mar 2020 16:08:00 +0100 > Jonas Smedegaard wrote: > > Tested-by: Jonas Smedegaard > > Some nit: This is somewhat implicit when you are the author. At least that's > the hope ;-) Ah, ok. Will keep that in mind for future patch

Re: [PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-04 Thread Andre Przywara
On Tue, 3 Mar 2020 16:08:00 +0100 Jonas Smedegaard wrote: Hi, > commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to > Kconfig") intended to support CONFIG_PREBOOT, but > include/configs/sunxi-common.h hardcodes preboot as part of internally > defined CONSOLE_STDIN_SETTINGS,

[PATCH v3 1/2] sunxi: fix support board-specific CONFIG_PREBOOT

2020-03-03 Thread Jonas Smedegaard
commit 37304aaf60bf ("Convert CONFIG_USE_PREBOOT and CONFIG_PREBOOT to Kconfig") intended to support CONFIG_PREBOOT, but include/configs/sunxi-common.h hardcodes preboot as part of internally defined CONSOLE_STDIN_SETTINGS, silently ignoring any board-specific CONFIG_PREBOOT. This commit moves