Re: [PATCH v3 2/4] clk: qcom: clear div mask before assigning a new divider

Hi Sumit, Thank you for the review. Sumit Garg writes: > On Tue, 12 Mar 2024 at 03:03, Volodymyr Babchuk > wrote: >> >> The current behaviour does a bitwise OR of the previous and new >> divider values, this is wrong as some bits maybe be set already. We > > nit: s/maybe be/maybe/ > Oops, r

Re: [PATCH v3 2/4] clk: qcom: clear div mask before assigning a new divider

On Tue, 12 Mar 2024 at 03:03, Volodymyr Babchuk wrote: > > The current behaviour does a bitwise OR of the previous and new > divider values, this is wrong as some bits maybe be set already. We nit: s/maybe be/maybe/ > need to clear all the divider bits before applying new ones. > > This fixes po

[PATCH v3 2/4] clk: qcom: clear div mask before assigning a new divider

The current behaviour does a bitwise OR of the previous and new divider values, this is wrong as some bits maybe be set already. We need to clear all the divider bits before applying new ones. This fixes potential issue with 1Gbit ethernet on SA8155P-ADP boards. Signed-off-by: Volodymyr Babchuk