Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

Jerry Van Baren wrote: > OK, critique v2 (thanks to Wolfgang calling BS on my previous critique :-). > > richardretanubun wrote: > >> Added for convenience for other platforms that uses MPC8360 (has 8 UCC). >> 6 eth interface is chosen because the platform I am using combines >> UCC1&2 and UCC3&

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

Dear Jerry Van Baren, In message <[EMAIL PROTECTED]> you wrote: > > Here is where a modification Kumar's loop (I would loop over > /aliases/ethernet[N] instead of the env variables) would cut out 5 > copies of the same code and would scale infinitely. Hmmm, we have > MAXCONTROLLERS (CONFIG_NU

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

OK, critique v2 (thanks to Wolfgang calling BS on my previous critique :-). richardretanubun wrote: > Added for convenience for other platforms that uses MPC8360 (has 8 UCC). > 6 eth interface is chosen because the platform I am using combines > UCC1&2 and UCC3&4 as gigEth and the other 4 UCC as 1

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

Dear Kim Phillips, In message <[EMAIL PROTECTED]> you wrote: > > > - Ethernet address: > > CONFIG_ETHADDR > > + CONFIG_ETH1ADDR > > CONFIG_ETH2ADDR > > hmm..historically ETHADDR has been the implicit ETH1ADDR. Did you mean No. ETHADDR is ETH0ADDR Best regards

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

Dear Jerry Van Baren, In message <[EMAIL PROTECTED]> you wrote: > > Kumar solved this problem WRT cpu/mpc83xx/fdt.c fdt_fixup_ethernet(void > *fdt) (and other CPUs) by using the device tree to find all the > ethernets and configure them. >

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

Dear Kim Phillips, In message <[EMAIL PROTECTED]> you wrote: > > > >> - Ethernet address: > > >> CONFIG_ETHADDR > > >> +CONFIG_ETH1ADDR > > >> CONFIG_ETH2ADDR > > > > > > hmm..historically ETHADDR has been the implicit ETH1ADDR. Did you mean > >

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

richardretanubun wrote: > Added for convenience for other platforms that uses MPC8360 (has 8 UCC). > 6 eth interface is chosen because the platform I am using combines > UCC1&2 and UCC3&4 as gigEth and the other 4 UCC as 10/100 Eth. We are about to fall into a never ending explosion of #define CO

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

On Thu, 25 Sep 2008 16:25:20 -0400 richardretanubun <[EMAIL PROTECTED]> wrote: > Kim Phillips wrote: > > > On Thu, 25 Sep 2008 08:53:24 -0400 > > richardretanubun <[EMAIL PROTECTED]> wrote: > >> --- > > > > ..i.e, here. > > > Understood, thanks for the clarification, will heed for future patches.

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

Kim Phillips wrote: > On Thu, 25 Sep 2008 08:53:24 -0400 > richardretanubun <[EMAIL PROTECTED]> wrote: > >> Added for convenience for other platforms that uses MPC8360 (has 8 UCC). >> 6 eth interface is chosen because the platform I am using combines >> UCC1&2 and UCC3&4 as gigEth and the other 4

Re: [U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

On Thu, 25 Sep 2008 08:53:24 -0400 richardretanubun <[EMAIL PROTECTED]> wrote: > Added for convenience for other platforms that uses MPC8360 (has 8 UCC). > 6 eth interface is chosen because the platform I am using combines > UCC1&2 and UCC3&4 as gigEth and the other 4 UCC as 10/100 Eth. > > - Ric

[U-Boot] [PATCH] [83xx] Adds two more ethernet interface to 83xx

Added for convenience for other platforms that uses MPC8360 (has 8 UCC). 6 eth interface is chosen because the platform I am using combines UCC1&2 and UCC3&4 as gigEth and the other 4 UCC as 10/100 Eth. - Richard From: Richard Retanubun <[EMAIL PROTECTED]> Date: Wed, 24 Sep 2008 17:21:47 -0400 Su