Re: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-14 Thread Kim Phillips
On Fri, 13 Mar 2009 08:58:14 +0100 Norbert van Bolhuis wrote: > OK, no problem. > Eventually I'll get it right :-) > 3rd (and hopefully final) attempt: something is still wrong with the way you are submitting this patch: Applying: mpc83xx: correctly set encryption and I2C bus 0 clock error: pat

Re: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-13 Thread Norbert van Bolhuis
OK, no problem. Eventually I'll get it right :-) 3rd (and hopefully final) attempt: This patch makes sure the correct mask is applied when setting the encryption and I2C bus 0 clock in SCCR. Failing to do so may lead to ENCCM being 0 in which case I2C bus 0 won't function. diff --git a/cpu/mpc83

Re: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-12 Thread Wolfgang Denk
Dear Norbert van Bolhuis, In message <49b8b26b.4090...@aimvalley.nl> you wrote: > > Yes I just cut-n-pasted it. > I hope it's better now. No, it is not better. Patches should be sent inline, and not as attachments. It would be best if you used git-send-email to post the patch. Also, your Signed

Re: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-11 Thread Norbert van Bolhuis
Kim, Yes I just cut-n-pasted it. I hope it's better now. Regards, Norbert. Kim Phillips wrote: On Wed, 11 Mar 2009 13:22:05 -0500 Scott Wood wrote: On Wed, Mar 11, 2009 at 12:57:43PM -0500, Kim Phillips wrote: heh, I thought it wouldn't be a problem, but you're right Heiko: Applying: 83

Re: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-11 Thread Kim Phillips
On Wed, 11 Mar 2009 13:22:05 -0500 Scott Wood wrote: > On Wed, Mar 11, 2009 at 12:57:43PM -0500, Kim Phillips wrote: > > heh, I thought it wouldn't be a problem, but you're right Heiko: > > > > Applying: 83xx: correctly set encryption and I2C bus 0 clock > > error: mpc83xx/cpu_init.c: does not e

Re: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-11 Thread Scott Wood
On Wed, Mar 11, 2009 at 12:57:43PM -0500, Kim Phillips wrote: > heh, I thought it wouldn't be a problem, but you're right Heiko: > > Applying: 83xx: correctly set encryption and I2C bus 0 clock > error: mpc83xx/cpu_init.c: does not exist in index > Patch failed at 0001. > When you have resolved th

Re: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-11 Thread Kim Phillips
On Wed, 11 Mar 2009 09:33:04 +0100 Heiko Schocher wrote: > > --- cpu/mpc83xx/cpu_init.c.org 2009-03-11 07:56:57.0 +0100 > > +++ cpu/mpc83xx/cpu_init.c 2009-03-11 07:57:37.0 +0100 > > @@ -106,7 +106,7 @@ void cpu_init_f (volatile immap_t * im) > > #ifdef CONFIG_SYS_SCCR_ENC

Re: [U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-11 Thread Heiko Schocher
Hello Norbert, added Kim Phillips to cc as he is the 83xx maintainer Norbert van Bolhuis wrote: > This patch makes sure the correct mask is applied when setting > the encryption and I2C bus 0 clock in SCCR. > Failing to do so may lead to ENCCM being 0 in which case I2C bus 0 > won't function. > >

[U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

2009-03-11 Thread Norbert van Bolhuis
This patch makes sure the correct mask is applied when setting the encryption and I2C bus 0 clock in SCCR. Failing to do so may lead to ENCCM being 0 in which case I2C bus 0 won't function. --- cpu/mpc83xx/cpu_init.c.org 2009-03-11 07:56:57.0 +0100 +++ cpu/mpc83xx/cpu_init.c 2009-03