Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-07-19 Thread Wolfgang Denk
Dear Kazuaki Ichinohe, In message 4a321b74.8040...@fsi.co.jp you wrote: This patch adds a SATA harddisk driver for the canyonlands. This patch is kernel driver's porting. This patch corresponded to not cmd_scsi but cmd_sata. This patch divided an unused member with ifndef __U_BOOT__ in the

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-06-04 Thread Wolfgang Denk
Dear Kazuaki Ichinohe, In message 4a247247.70...@fsi.co.jp you wrote: ... But, other local, private, resource management structures are encouraged to be shrinked/optimized, as it's just waste of ROM space. Originally U-boot of PowerPC is not importance for the size because the size is

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-06-03 Thread Kazuaki Ichinohe
Kuribayashi-san, Do you think that you should include the Acked SATA driver in merge window of the next release (2009/08 or -09?)? I want to open the ACKed SATA driver to the public to the CanyonLands user. Regards, Kazuaki Ichinohe ___ U-Boot

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-06-01 Thread Kazuaki Ichinohe
Hello Kuribayashi-san, Please make sure I'm not talking about register definition structures. They're harmless, and no need to be cleaned up. The definition of the register of DMA is the following. However, the structure is used a little for the usage in which DMA is disabled. struct dmareg {

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-06-01 Thread Shinya Kuribayashi
Kazuaki Ichinohe wrote: But, other local, private, resource management structures are encouraged to be shrinked/optimized, as it's just waste of ROM space. Originally U-boot of PowerPC is not importance for the size because the size is large. I will point out and object about you. As

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-06-01 Thread Jean-Christophe PLAGNIOL-VILLARD
On 18:07 Fri 29 May , Shinya Kuribayashi wrote: Kazuaki Ichinohe wrote: DMA function was scheduled to be developed as my schedule. However, the development of the DMA function is discontinued once now. The structure of the register that controls DMA has not been used any longer. I

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-05-29 Thread Kazuaki Ichinohe
Hello, The SATA harddisk driver is based on the Linux kernel source code. Therefore, the software structure is the same structure as the Linux kernel driver. DMA function was scheduled to be developed as my schedule. However, the development of the DMA function is discontinued once now. The

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-05-20 Thread Stefan Roese
On Friday 15 May 2009 11:32:26 Kazuaki Ichinohe wrote: This patch adds a SATA harddisk driver for the canyonlands. This patch is kernel driver's porting. This pach corresponded to not cmd_scsi but cmd_sata. Looks good now. Thanks for all your effort here. So: Acked-by: Stefan Roese

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-05-20 Thread Shinya Kuribayashi
Stefan Roese wrote: On Friday 15 May 2009 11:32:26 Kazuaki Ichinohe wrote: This patch adds a SATA harddisk driver for the canyonlands. This patch is kernel driver's porting. This pach corresponded to not cmd_scsi but cmd_sata. Looks good now. Thanks for all your effort here. So:

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-05-14 Thread Kazuaki Ichinohe
Hello Denk, Stefan, I sent the patch source again on May 13. Could you review the patch source again ? Regards, Kazuaki Ichinohe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-05-14 Thread Stefan Roese
On Thursday 14 May 2009 10:28:08 Kazuaki Ichinohe wrote: I sent the patch source again on May 13. Could you review the patch source again ? Yes, will do. Best regards, Stefan = DENX Software Engineering GmbH, MD: Wolfgang

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-05-12 Thread Wolfgang Denk
Dear Kazuaki Ichinohe, In message 4a0947cd.6050...@fsi.co.jp you wrote: I re-send the patch source. The following three points were corrected. 1.--- was adjusted to add git history. 2.The following lines of /drivers/block/Makefile were matched to sorting. You really don't get it. All

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-05-11 Thread Stefan Roese
Hi Kazuaki Ichinohe, first the good news. This patch version now applies clean. Thanks. But please find still a few comments below. On Friday 08 May 2009 08:27:27 Kazuaki Ichinohe wrote: Hello Denk, Stefan, The confirmed patch is sent again. Please review this patch. Move the lines above

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-05-07 Thread Wolfgang Denk
Dear Kazuaki Ichinohe, In message 4a027e44.5080...@fsi.co.jp you wrote: Hello Denk, Stefan, Could you please rebase your patch against the current top-of-tree mainline repository and resumbmit? Thank you for the reply. I made the patch from the source obtained with git in 5/7. The

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-04-29 Thread Stefan Roese
On Monday 27 April 2009, Kazuaki Ichinohe wrote: I sent the SATA patch mail on April 17. However, the following content is not confirmed, and there is not a reply either. Could you confirm it? I re-send the SATA driver patch. I failed applying your patch: Applying: Canyonlands SATA harddisk

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-04-27 Thread Stefan Roese
Hi Kazuaki Ichinohe, On Monday 27 April 2009, Kazuaki Ichinohe wrote: I sent the SATA patch mail on April 17. However, the following content is not confirmed, and there is not a reply either. Could you confirm it? I re-send the SATA driver patch. Sorry, I forgot about reviewing it. I'll do

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-03-30 Thread Kazuaki Ichinohe
Hello Denk, After confirming operation, I'll send sata_dwc.c with cmd_sata.c again. Regards, Kazuaki Ichinohe Wolfgang Denk wrote: Dear Kazuaki Ichinohe, In message 49cb5f77.1060...@fsi.co.jp you wrote: ... Why do you add this 460EX SATA support to cmd_scsi.c? Wouldn't cmd_sata.c be a

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-03-27 Thread Stefan Roese
On Thursday 26 March 2009, Kazuaki Ichinohe wrote: Thank you for the reply. My answer is described in the beginning. OK, I just tried to apply your patch for basic testing. Didn't work though. Here the error log: [ste...@kubuntu u-boot (master)]$ patch -p1 patches_sata/\[U-Boot\]\

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-03-27 Thread Wolfgang Denk
Dear Kazuaki Ichinohe, In message 49cb5f77.1060...@fsi.co.jp you wrote: ... Why do you add this 460EX SATA support to cmd_scsi.c? Wouldn't cmd_sata.c be a better place? Or did I miss something here? The cmd_scsi.c which define CONFIG_CMD_SCSI are modified because I want to use scsiboot

Re: [U-Boot] [PATCH] Canyonlands SATA harddisk driver

2009-03-25 Thread Stefan Roese
On Wednesday 25 March 2009, Kazuaki Ichinohe wrote: Hi Stefan, Thank you for the reply. This is the patch that corrects the point. Signed-off-by: Kazuaki Ichinohe kazuichi at fsi.co.jp OK, now you added your Signed-off-by line and the patch itself doesn't seem to be line wrapped. But the