Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-27 Thread Simon Glass
On 21 August 2017 at 21:46, Bin Meng wrote: > All these places seem to inherit the codes from the MMC driver where > a FIXME was put in the comment. However the correct operation after > read should be cache invalidate, not flush. > > The underlying drivers should be

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-24 Thread Joe Hershberger
On Mon, Aug 21, 2017 at 10:46 PM, Bin Meng wrote: > All these places seem to inherit the codes from the MMC driver where > a FIXME was put in the comment. However the correct operation after > read should be cache invalidate, not flush. > > The underlying drivers should be

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-23 Thread Y.b. Lu
> -Original Message- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: Wednesday, August 23, 2017 1:29 PM > To: Y.b. Lu > Cc: Qiang Zhao; York Sun; Grygorii Strashko; Michal Simek; Angelo > Dureghello; Kever Yang; Jaehoon Chung; Albert Aribaud; Marcel Ziswiler; > Markus Niebel; Z.q.

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-23 Thread York Sun
On 08/21/2017 08:42 PM, Bin Meng wrote: > All these places seem to inherit the codes from the MMC driver where > a FIXME was put in the comment. However the correct operation after > read should be cache invalidate, not flush. > > The underlying drivers should be responsible for the cache

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-23 Thread York Sun
On 08/22/2017 03:53 PM, Bin Meng wrote: > Hi York, > > On Wed, Aug 23, 2017 at 12:49 AM, York Sun wrote: >> On 08/21/2017 08:42 PM, Bin Meng wrote: >>> All these places seem to inherit the codes from the MMC driver where >>> a FIXME was put in the comment. However the correct

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-22 Thread Bin Meng
Hi Yangbo, On Wed, Aug 23, 2017 at 11:29 AM, Y.b. Lu wrote: > cmd/mmc.c > > Maybe SD controller on some vendor platforms doesn't support SNOOP. > flush_cache() is required to sync between DDR and cache. > Should be careful to remove this. > Please do not top-posting. What

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-22 Thread Y.b. Lu
cmd/mmc.c Maybe SD controller on some vendor platforms doesn't support SNOOP. flush_cache() is required to sync between DDR and cache. Should be careful to remove this. > -Original Message- > From: Qiang Zhao > Sent: Wednesday, August 23, 2017 11:14 AM > To: Y.b. Lu; York Sun; Bin Meng;

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-22 Thread Qiang Zhao
+Yangbo Best Regards Qiang Zhao > -Original Message- > From: York Sun > Sent: Wednesday, August 23, 2017 12:49 AM > To: Bin Meng ; Grygorii Strashko > ; Michal Simek ; Angelo > Dureghello ; Kever Yang

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-22 Thread Bin Meng
Hi York, On Wed, Aug 23, 2017 at 12:49 AM, York Sun wrote: > On 08/21/2017 08:42 PM, Bin Meng wrote: >> All these places seem to inherit the codes from the MMC driver where >> a FIXME was put in the comment. However the correct operation after >> read should be cache

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-22 Thread York Sun
On 08/21/2017 08:42 PM, Bin Meng wrote: > All these places seem to inherit the codes from the MMC driver where > a FIXME was put in the comment. However the correct operation after > read should be cache invalidate, not flush. > > The underlying drivers should be responsible for the cache

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-22 Thread Bin Meng
Hi Stefan, On Tue, Aug 22, 2017 at 2:19 PM, Stefan Roese wrote: > On 22.08.2017 05:46, Bin Meng wrote: >> >> All these places seem to inherit the codes from the MMC driver where >> a FIXME was put in the comment. However the correct operation after >> read should be cache

Re: [U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-22 Thread Stefan Roese
On 22.08.2017 05:46, Bin Meng wrote: All these places seem to inherit the codes from the MMC driver where a FIXME was put in the comment. However the correct operation after read should be cache invalidate, not flush. The underlying drivers should be responsible for the cache operation. Remove

[U-Boot] [PATCH] blk: Remove various places that do flush cache after read

2017-08-21 Thread Bin Meng
All these places seem to inherit the codes from the MMC driver where a FIXME was put in the comment. However the correct operation after read should be cache invalidate, not flush. The underlying drivers should be responsible for the cache operation. Remove these codes completely. Signed-off-by: