Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-09-10 Thread Wolfgang Denk
Dear Timur Tabi, In message 20100616145133.bbde7d81...@gemini.denx.de I wrote: we add support to U-Boot to conditionally check for the gcc version like Linux to know when to use -fno-toplevel-reorder? =A0Or do we use a linker script that would support more versions of gcc at the cost

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-09-10 Thread Peter Tyser
On Fri, 2010-09-10 at 14:53 -0500, Timur Tabi wrote: On Fri, Sep 10, 2010 at 2:49 PM, Wolfgang Denk w...@denx.de wrote: AFAICT you did not reply to this, and the problem is still unsolved. Do you still have this on your list? Sorry, I'm confused. What exactly do you want me to do?

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-29 Thread Wolfgang Denk
In message 1276631305-30648-1-git-send-email...@denx.de you wrote: From: Peter Tyser pty...@xes-inc.com Previously, standalone applications were compiled with gcc flags that produced relocatable executables on the PowerPC architecture (eg with the -mrelocatable and -fPIC flags). There's no

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-16 Thread Timur Tabi
On Tue, Jun 15, 2010 at 10:37 PM, Peter Tyser pty...@xes-inc.com wrote: It looks like the -fno-toplevel-reorder flag is only available in gcc = 4.2 (http://gcc.gnu.org/gcc-4.2/changes.html released May 2007).  So, do we add support to U-Boot to conditionally check for the gcc version like

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-16 Thread Wolfgang Denk
Dear Timur Tabi, In message aanlktild0osohtpuqpqwsrzsaxptcqnb_c2s0wtvi...@mail.gmail.com you wrote: we add support to U-Boot to conditionally check for the gcc version like Linux to know when to use -fno-toplevel-reorder? =A0Or do we use a linker script that would support more versions

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Timur Tabi
Peter Tyser wrote: Previously, standalone applications were compiled with gcc flags that produced relocatable executables on the PowerPC architecture (eg with the -mrelocatable and -fPIC flags). There's no reason for these applications to be fully relocatable at this time since no relocation

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Timur Tabi
Timur Tabi wrote: Peter Tyser wrote: Previously, standalone applications were compiled with gcc flags that produced relocatable executables on the PowerPC architecture (eg with the -mrelocatable and -fPIC flags). There's no reason for these applications to be fully relocatable at this time

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Peter Tyser
On Tue, 2010-06-15 at 14:05 -0500, Timur Tabi wrote: Timur Tabi wrote: Peter Tyser wrote: Previously, standalone applications were compiled with gcc flags that produced relocatable executables on the PowerPC architecture (eg with the -mrelocatable and -fPIC flags). There's no reason for

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Timur Tabi
Peter Tyser wrote: Can you do a 'make clean', then recompile? That *was* with a 'make clean'. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Peter Tyser
On Tue, 2010-06-15 at 14:20 -0500, Timur Tabi wrote: Peter Tyser wrote: Can you do a 'make clean', then recompile? That *was* with a 'make clean'. Just to be sure, where did the output in your first email come from? It looked like a successful compile, but libstubs wasn't recompiled (I

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Peter Tyser
On Tue, 2010-06-15 at 14:05 -0500, Timur Tabi wrote: Timur Tabi wrote: Peter Tyser wrote: Previously, standalone applications were compiled with gcc flags that produced relocatable executables on the PowerPC architecture (eg with the -mrelocatable and -fPIC flags). There's no reason for

[U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Wolfgang Denk
From: Peter Tyser pty...@xes-inc.com Previously, standalone applications were compiled with gcc flags that produced relocatable executables on the PowerPC architecture (eg with the -mrelocatable and -fPIC flags). There's no reason for these applications to be fully relocatable at this time since

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Peter Tyser
On Tue, 2010-06-15 at 14:45 -0500, Timur Tabi wrote: Peter Tyser wrote: Was commenting out the 'ifeq' above necessary? It shouldn't be, so my first question would be why it was needed. Probably because I was using an older U-Boot. When I switch to the latest code, it compiles fine.

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Wolfgang Denk
Dear Peter Tyser, In message 1276632905.32134.1535.ca...@petert you wrote: I think by default its not possible to guarantee function order in gcc's output if a file contains multiple functions. We could create a basic Correct. If you check for example the timer example program (build for

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Peter Tyser
snip all: $(obj).depend $(OBJS) $(LIB) $(SREC) $(BIN) $(ELF) @@ -88,7 +89,7 @@ $(LIB): $(obj).depend $(LIBOBJS) $(ELF): $(obj)%: $(obj)%.o $(LIB) - $(LD) -g -Ttext $(STANDALONE_LOAD_ADDR) \ + $(LD) -g -Ttext $(STANDALONE_LOAD_ADDR)

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Timur Tabi
Wolfgang Denk wrote: I think the timer code is sufficient to show the problem, and that your fix helps. If Timur confirms it's working for his secret code too we should apply this. Doing this at the top of my source file: static int __flash_wp(int argc, char *argv[]); int

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Wolfgang Denk
Dear Peter, In message 1276634341.32134.1541.ca...@petert you wrote: I think the timer code is sufficient to show the problem, and that your fix helps. If Timur confirms it's working for his secret code too we should apply this. Do you want this rolled into the first patch, or sent as

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Wolfgang Denk
Dear Timur Tabi, In message 4c17e4f2.70...@freescale.com you wrote: Doing this at the top of my source file: static int __flash_wp(int argc, char *argv[]); int flash_wp(int argc, char *argv[]) { return __flash_wp(argc, argv); } and then adding

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Timur Tabi
Wolfgang Denk wrote: I think the static int __flash_wp() thing is not even needed assuming that flash_wp() is the first function in your file. That's the thing -- I don't want flash_wp() to be the first function in my file. I would then need a forward reference to all the other functions in my

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Wolfgang Denk
Dear Timur Tabi, In message 4c17ea8d.9080...@freescale.com you wrote: Wolfgang Denk wrote: I think the static int __flash_wp() thing is not even needed assuming that flash_wp() is the first function in your file. That's the thing -- I don't want flash_wp() to be the first function in my

Re: [U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-15 Thread Peter Tyser
On Tue, 2010-06-15 at 22:51 +0200, Wolfgang Denk wrote: Dear Peter, In message 1276634341.32134.1541.ca...@petert you wrote: I think the timer code is sufficient to show the problem, and that your fix helps. If Timur confirms it's working for his secret code too we should apply

[U-Boot] [PATCH] examples/standalone: Remove relocation compile flags for PowerPC

2010-06-14 Thread Peter Tyser
Previously, standalone applications were compiled with gcc flags that produced relocatable executables on the PowerPC architecture (eg with the -mrelocatable and -fPIC flags). There's no reason for these applications to be fully relocatable at this time since no relocation fixups are performed on