Re: [U-Boot] [PATCH] gpio: altera_pio: Fix inversed logic of gpio_is_valid() implementation

2013-08-04 Thread Axel Lin
2013/7/29 Albert ARIBAUD : > Hi Axel, > > On Sat, 15 Jun 2013 17:10:38 +0800, Axel Lin > wrote: > >> The implementation of gpio_is_valid() has inversed logic, fix it. >> >> Signed-off-by: Axel Lin >> --- >> Hi, >> I don't have this hardware to test, but current code looks obviously wrong. >> I'd

Re: [U-Boot] [PATCH] gpio: altera_pio: Fix inversed logic of gpio_is_valid() implementation

2013-07-29 Thread Albert ARIBAUD
Hi Axel, On Sat, 15 Jun 2013 17:10:38 +0800, Axel Lin wrote: > The implementation of gpio_is_valid() has inversed logic, fix it. > > Signed-off-by: Axel Lin > --- > Hi, > I don't have this hardware to test, but current code looks obviously wrong. > I'd appreciate if someone can review and test

[U-Boot] [PATCH] gpio: altera_pio: Fix inversed logic of gpio_is_valid() implementation

2013-06-15 Thread Axel Lin
The implementation of gpio_is_valid() has inversed logic, fix it. Signed-off-by: Axel Lin --- Hi, I don't have this hardware to test, but current code looks obviously wrong. I'd appreciate if someone can review and test this patch. Axel drivers/gpio/altera_pio.c | 4 ++-- 1 file changed, 2 inse