[U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-10 Thread Peng Fan
Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces error register offset. Change the "char reserved3[59]" to "char reserved3[56]". Signed-off-by: Peng Fan --- drivers/mmc/fsl_esdhc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mm

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-10 Thread Marek Vasut
On Tuesday, March 10, 2015 at 08:35:46 AM, Peng Fan wrote: > Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces > error register offset. > > Change the "char reserved3[59]" to "char reserved3[56]". > > Signed-off-by: Peng Fan This should probably be applied to 2015.04 . What are the sy

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-10 Thread Peng Fan
Hi, Marek On 3/10/2015 9:45 PM, Marek Vasut wrote: On Tuesday, March 10, 2015 at 08:35:46 AM, Peng Fan wrote: Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces error register offset. Change the "char reserved3[59]" to "char reserved3[56]". Signed-off-by: Peng Fan This should probab

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-10 Thread Marek Vasut
On Wednesday, March 11, 2015 at 01:58:37 AM, Peng Fan wrote: > Hi, Marek Hi! > On 3/10/2015 9:45 PM, Marek Vasut wrote: > > On Tuesday, March 10, 2015 at 08:35:46 AM, Peng Fan wrote: > >> Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces > >> error register offset. > >> > >> Change the

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-10 Thread Peng Fan
Hi, Marek On 3/11/2015 10:03 AM, Marek Vasut wrote: On Wednesday, March 11, 2015 at 01:58:37 AM, Peng Fan wrote: Hi, Marek Hi! On 3/10/2015 9:45 PM, Marek Vasut wrote: On Tuesday, March 10, 2015 at 08:35:46 AM, Peng Fan wrote: Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces erro

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-11 Thread Marek Vasut
On Wednesday, March 11, 2015 at 03:17:00 AM, Peng Fan wrote: > Hi, Marek > > On 3/11/2015 10:03 AM, Marek Vasut wrote: > > On Wednesday, March 11, 2015 at 01:58:37 AM, Peng Fan wrote: > >> Hi, Marek > > > > Hi! > > > >> On 3/10/2015 9:45 PM, Marek Vasut wrote: > >>> On Tuesday, March 10, 2015 at

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-11 Thread Fabio Estevam
On Tue, Mar 10, 2015 at 4:35 AM, Peng Fan wrote: > Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces > error register offset. > > Change the "char reserved3[59]" to "char reserved3[56]". > > Signed-off-by: Peng Fan On a imx6sl-warp: Tested-by: Fabio Estevam ___

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-11 Thread Pantelis Antoniou
Hi Peng, > On Mar 11, 2015, at 04:17 , Peng Fan wrote: > > Hi, Marek > > On 3/11/2015 10:03 AM, Marek Vasut wrote: >> On Wednesday, March 11, 2015 at 01:58:37 AM, Peng Fan wrote: >>> Hi, Marek >> Hi! >> >>> On 3/10/2015 9:45 PM, Marek Vasut wrote: On Tuesday, March 10, 2015 at 08:35:46 A

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-11 Thread Tom Rini
On Wed, Mar 11, 2015 at 01:03:16PM -0300, Fabio Estevam wrote: > On Wed, Mar 11, 2015 at 10:55 AM, Pantelis Antoniou > wrote: > > > Although I agree with fixing this, I’m kinda scared about how fragile > > structs for describing hardware registers are. > > Agreed! > > > But we’re stuck with it

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-12 Thread Joakim Tjernlund
On Wed, 2015-03-11 at 15:55 +0200, Pantelis Antoniou wrote: > Hi Peng, > > > > On Mar 11, 2015, at 04:17 , Peng Fan wrote: > > > > Hi, Marek > > > > On 3/11/2015 10:03 AM, Marek Vasut wrote: > > > On Wednesday, March 11, 2015 at 01:58:37 AM, Peng Fan wrote: > > > > Hi, Marek > > > Hi! > > > >

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-12 Thread Fabio Estevam
On Wed, Mar 11, 2015 at 10:55 AM, Pantelis Antoniou wrote: > Although I agree with fixing this, I’m kinda scared about how fragile > structs for describing hardware registers are. Agreed! > But we’re stuck with it I guess. Yes, it seems this is mandatory in U-boot. Kernel does not have such r

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-14 Thread Peng Fan
Hi, On 3/11/2015 9:00 PM, Fabio Estevam wrote: On Tue, Mar 10, 2015 at 4:35 AM, Peng Fan wrote: Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces error register offset. Change the "char reserved3[59]" to "char reserved3[56]". Signed-off-by: Peng Fan On a imx6sl-warp: Tested-by: F

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-15 Thread Marek Vasut
On Sunday, March 15, 2015 at 06:54:49 AM, Peng Fan wrote: > Hi, > > On 3/11/2015 9:00 PM, Fabio Estevam wrote: > > On Tue, Mar 10, 2015 at 4:35 AM, Peng Fan wrote: > >> Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces > >> error register offset. > >> > >> Change the "char reserved3[59]

Re: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset

2015-03-15 Thread Joakim Tjernlund
On Sun, 2015-03-15 at 13:54 +0800, Peng Fan wrote: > Hi, > > On 3/11/2015 9:00 PM, Fabio Estevam wrote: > > On Tue, Mar 10, 2015 at 4:35 AM, Peng Fan wrote: > > > Commit f022d36e8a4517b2a9d25ff2d75bd2459d0c68b1 introduces > > > error register offset. > > > > > > Change the "char reserved3[59]" t