Re: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-18 Thread Michal Simek
On 17.5.2016 21:09, Stephen Warren wrote: > On 05/17/2016 12:00 PM, Michal Simek wrote: >> On 17.5.2016 19:36, Stephen Warren wrote: >>> On 05/17/2016 11:03 AM, Michal Simek wrote: On 17.5.2016 19:00, Stephen Warren wrote: > On 05/17/2016 10:56 AM, Michal Simek wrote: >> Hi Stephen, >>

Re: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-17 Thread Stephen Warren
On 05/17/2016 12:00 PM, Michal Simek wrote: On 17.5.2016 19:36, Stephen Warren wrote: On 05/17/2016 11:03 AM, Michal Simek wrote: On 17.5.2016 19:00, Stephen Warren wrote: On 05/17/2016 10:56 AM, Michal Simek wrote: Hi Stephen, On 17.5.2016 18:50, Stephen Warren wrote: On 05/17/2016 07:57 A

Re: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-17 Thread Michal Simek
On 17.5.2016 19:36, Stephen Warren wrote: > On 05/17/2016 11:03 AM, Michal Simek wrote: >> On 17.5.2016 19:00, Stephen Warren wrote: >>> On 05/17/2016 10:56 AM, Michal Simek wrote: Hi Stephen, On 17.5.2016 18:50, Stephen Warren wrote: > On 05/17/2016 07:57 AM, Michal Simek wrote:

Re: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-17 Thread Stephen Warren
On 05/17/2016 11:03 AM, Michal Simek wrote: On 17.5.2016 19:00, Stephen Warren wrote: On 05/17/2016 10:56 AM, Michal Simek wrote: Hi Stephen, On 17.5.2016 18:50, Stephen Warren wrote: On 05/17/2016 07:57 AM, Michal Simek wrote: If timeout happen it should be reported as fault. Presumably i

Re: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-17 Thread Michal Simek
On 17.5.2016 19:00, Stephen Warren wrote: > On 05/17/2016 10:56 AM, Michal Simek wrote: >> Hi Stephen, >> >> On 17.5.2016 18:50, Stephen Warren wrote: >>> On 05/17/2016 07:57 AM, Michal Simek wrote: If timeout happen it should be reported as fault. >>> >>> Presumably if a timeout occurs, the e

Re: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-17 Thread Stephen Warren
On 05/17/2016 10:56 AM, Michal Simek wrote: Hi Stephen, On 17.5.2016 18:50, Stephen Warren wrote: On 05/17/2016 07:57 AM, Michal Simek wrote: If timeout happen it should be reported as fault. Presumably if a timeout occurs, the expected text does not appear, i.e. the existing assert fails an

Re: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-17 Thread Michal Simek
Hi Stephen, On 17.5.2016 18:50, Stephen Warren wrote: > On 05/17/2016 07:57 AM, Michal Simek wrote: >> If timeout happen it should be reported as fault. > > Presumably if a timeout occurs, the expected text does not appear, i.e. > the existing assert fails anyway? > > Anyway, it's useful to poin

Re: [U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-17 Thread Stephen Warren
On 05/17/2016 07:57 AM, Michal Simek wrote: If timeout happen it should be reported as fault. Presumably if a timeout occurs, the expected text does not appear, i.e. the existing assert fails anyway? Anyway, it's useful to point out problems explicitly, so, Acked-by: Stephen Warren

[U-Boot] [PATCH] test/py: Detect timeout in phy negotiation

2016-05-17 Thread Michal Simek
If timeout happen it should be reported as fault. Signed-off-by: Michal Simek --- test/py/tests/test_net.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/py/tests/test_net.py b/test/py/tests/test_net.py index 4f4a876c1335..833a8fd5b3e3 100644 --- a/test/py/tests/test_net.py +++ b/