[U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-15 Thread Ilya Yanok
Sometimes we want to build common tools without configuring for specific target. Currently top Makefile has some support for this but it doesn't work. This patch tries to fix this. Things changed: - config.mk disable 'ld script not found error' in case if we are building tools only. - Makefile

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-18 Thread Mike Frysinger
On Wednesday, June 15, 2011 17:37:33 Ilya Yanok wrote: > Sometimes we want to build common tools without configuring for specific > target. Currently top Makefile has some support for this but it doesn't > work. This patch tries to fix this. i think you'll need to split this up in logical sep chan

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-18 Thread Wolfgang Denk
Dear Mike Frysinger, In message <201106181503.10550.vap...@gentoo.org> you wrote: > > pretty sure this breaks board builds. if the only thing this fixes is a > harmless warning when generating dependency files, then i say ignore it. > after all, this is how it has always worked in the past and

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-18 Thread Mike Frysinger
On Saturday, June 18, 2011 16:11:17 Wolfgang Denk wrote: > Mike Frysinger wrote: > > pretty sure this breaks board builds. if the only thing this fixes is a > > harmless warning when generating dependency files, then i say ignore it. > > after all, this is how it has always worked in the past and

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-19 Thread Mike Frysinger
On Sunday, June 19, 2011 13:55:13 Ilya Yanok wrote: > On 18.06.2011 23:03, Mike Frysinger wrote: > >> - tools/Makefile put common/env_embedded.o and envcrc.o to object list > >> > >> conditionally. This fixes errors during dependency generation. > > > > pretty sure this breaks board builds. if

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-19 Thread Ilya Yanok
Hi Mike, thanks for your comments. On 18.06.2011 23:03, Mike Frysinger wrote: > i think you'll need to split this up in logical sep changesets since you are > fixing different problems. Ok, will do. >> Things changed: >> - config.mk disable 'ld script not found error' in case if we are >> b

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-19 Thread Ilya Yanok
Hi Mike, On 19.06.2011 22:27, Mike Frysinger wrote: > i might be thinking of a different env_embedded situation. a different > problem with your patch to tools/Makefile: you copied the same logic multiple > times which means more bitrot. Yes, that's a good point. Your patch looks good to me. S

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-19 Thread Mike Frysinger
On Sunday, June 19, 2011 18:46:42 Ilya Yanok wrote: > On 19.06.2011 22:27, Mike Frysinger wrote: > > i might be thinking of a different env_embedded situation. a different > > problem with your patch to tools/Makefile: you copied the same logic > > multiple times which means more bitrot. > > Yes,

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-06-20 Thread Scott Wood
On Sat, 18 Jun 2011 15:03:09 -0400 Mike Frysinger wrote: > considering LDSCRIPT/CONFIG_SYS_LDSCRIPT only get used by the top level > u-boot > file, and only when the system is configured, i wonder if we shouldnt just > rip > it out of config.mk and into the top level Makefile. > > let's see

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-10-17 Thread Wolfgang Denk
Dear Ilya, In message <1308173853-20178-1-git-send-email-ya...@emcraft.com> you wrote: > Sometimes we want to build common tools without configuring for specific > target. Currently top Makefile has some support for this but it doesn't > work. This patch tries to fix this. > Things changed: > - c

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-10-17 Thread Ilya Yanok
Dear Wolfgang, On 17.10.2011 23:42, Wolfgang Denk wrote: >> Sometimes we want to build common tools without configuring for specific >> target. Currently top Makefile has some support for this but it doesn't >> work. This patch tries to fix this. >> Things changed: >> - config.mk disable 'ld sc

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-10-17 Thread Wolfgang Denk
Dear Ilya Yanok, In message <4e9c8ef9.3030...@emcraft.com> you wrote: > > > Is it correct to assume that this commit has been obsolteted by > > the following commits: ... > Not exactly. I've reposted my patch splitting it into three as Mike > suggested, and all these patches are already applied.

Re: [U-Boot] [PATCH] tools: make it possible to build tools unconfigured

2011-10-17 Thread Ilya Yanok
Dear Wolfgang, On 18.10.2011 00:35, Wolfgang Denk wrote: >>> Is it correct to assume that this commit has been obsolteted by >>> the following commits: > ... >> Not exactly. I've reposted my patch splitting it into three as Mike >> suggested, and all these patches are already applied. >> >> The co