Re: [U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes

2013-02-28 Thread Julius Werner
Oops... I somehow pulled three lines of other local changes in there that don't belong when I cherry-picked this into my upstream branch. Sorry, will resubmit this once more. On Tue, Feb 19, 2013 at 5:14 PM, Julius Werner jwer...@chromium.org wrote: This patch adds a new 'usb test' command, that

[U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes

2013-02-28 Thread Julius Werner
This patch adds a new 'usb test' command, that will set a port to a USB 2.0 test mode (see USB 2.0 spec 7.1.20). It supports all five test modes on both downstream hub ports and ordinary device's upstream ports. In addition, it supports EHCI root hub ports. Signed-off-by: Julius Werner

Re: [U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes

2013-02-20 Thread Julius Werner
Hi Tom, This patch is not really target specific, it works on all platforms that support USB 2.0. I just wrapped it in a new config option because most people probably won't need it… it is only really useful for hardware verification, so I figured whoever needs it can hack in the config option

Re: [U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes

2013-02-20 Thread Julius Werner
I guess you are right about the bit rot, it makes more sense to keep this on so people notice when things break. I have compiled it for smdk5250 (though it's all common and EHCI code, so that should make no difference) and only measured a 1.1k increase in uncompressed code size (less than 0.3%). I

[U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes

2013-02-20 Thread Julius Werner
This patch adds a new 'usb test' command, that will set a port to a USB 2.0 test mode (see USB 2.0 spec 7.1.20). It supports all five test modes on both downstream hub ports and ordinary device's upstream ports. In addition, it supports EHCI root hub ports. Signed-off-by: Julius Werner

Re: [U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes

2013-02-19 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/19/2013 04:29 PM, Julius Werner wrote: Hi Tom, This patch is not really target specific, it works on all platforms that support USB 2.0. I just wrapped it in a new config option because most people probably won't need it… it is only really

Re: [U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes

2013-02-18 Thread Tom Rini
On Fri, Feb 15, 2013 at 05:52:45PM -0800, Julius Werner wrote: This patch adds a new 'usb test' command, that will set a port to a USB 2.0 test mode (see USB 2.0 spec 7.1.20). It supports all five test modes on both downstream hub ports and ordinary device's upstream ports. In addition, it

[U-Boot] [PATCH] usb: Add new command to set USB 2.0 port test modes

2013-02-16 Thread Julius Werner
This patch adds a new 'usb test' command, that will set a port to a USB 2.0 test mode (see USB 2.0 spec 7.1.20). It supports all five test modes on both downstream hub ports and ordinary device's upstream ports. In addition, it supports EHCI root hub ports. The command is guarded by the