Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-31 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek, > > In message <1375220281-11132-6-git-send-email-ma...@denx.de> you wrote: > > ... > > > + /* Program the SmartLCD controller */ > > + writel(LCDIF_CTRL1_RECOVER_ON_UNDERFLOW, ®s->hw_lcdif_ctrl1_set); > > + > > + writel(0x03030202, ®s->hw_lcdif_timing);

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-31 Thread Wolfgang Denk
Dear Marek, In message <1375220281-11132-6-git-send-email-ma...@denx.de> you wrote: > ... > + /* Program the SmartLCD controller */ > + writel(LCDIF_CTRL1_RECOVER_ON_UNDERFLOW, ®s->hw_lcdif_ctrl1_set); > + > + writel(0x03030202, ®s->hw_lcdif_timing); Please don't use such magic number

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-31 Thread Marek Vasut
Dear Stefano Babic, [...] > > @@ -0,0 +1,47 @@ > > +# > > +# (C) Copyright 2000-2006 > > +# Wolfgang Denk, DENX Software Engineering, w...@denx.de. > > +# > > +# See file CREDITS for list of people who contributed to this > > +# project. > > +# > > +# This program is free software; you can redist

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-31 Thread Stefano Babic
Hi Marek, On 30/07/2013 23:37, Marek Vasut wrote: > Add STMP3780-based XFi3 board. This board is a small PMP device > sporting a CPU which was later rebranded to i.MX233 . Currently > supported is USB gadget mode and both external SD and internal > Phison SD-NAND bridge . > > Signed-off-by: Marek

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-31 Thread Otavio Salvador
On Tue, Jul 30, 2013 at 8:36 PM, Marek Vasut wrote: > Dear Otavio Salvador, > >> On Tue, Jul 30, 2013 at 7:46 PM, Marek Vasut wrote: >> > Dear Otavio Salvador, >> > >> > [...] >> > >> >> > + mxsfb_write_register(0x36, 0xaf); >> >> > + mxsfb_write_register(0x37, 0); >> >> > + mxs

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-31 Thread Marek Vasut
Dear Heiko Schocher, > Hello Marek, > > Am 30.07.2013 23:37, schrieb Marek Vasut: > > Add STMP3780-based XFi3 board. This board is a small PMP device > > sporting a CPU which was later rebranded to i.MX233 . Currently > > supported is USB gadget mode and both external SD and internal > > Phison S

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-30 Thread Heiko Schocher
Hello Marek, Am 30.07.2013 23:37, schrieb Marek Vasut: Add STMP3780-based XFi3 board. This board is a small PMP device sporting a CPU which was later rebranded to i.MX233 . Currently supported is USB gadget mode and both external SD and internal Phison SD-NAND bridge . Signed-off-by: Marek Vasu

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-30 Thread Marek Vasut
Dear Otavio Salvador, > On Tue, Jul 30, 2013 at 7:46 PM, Marek Vasut wrote: > > Dear Otavio Salvador, > > > > [...] > > > >> > + mxsfb_write_register(0x36, 0xaf); > >> > + mxsfb_write_register(0x37, 0); > >> > + mxsfb_write_register(0x38, 0xdb); > >> > + mxsfb_write_regi

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-30 Thread Otavio Salvador
On Tue, Jul 30, 2013 at 7:46 PM, Marek Vasut wrote: > Dear Otavio Salvador, > > [...] > >> > + mxsfb_write_register(0x36, 0xaf); >> > + mxsfb_write_register(0x37, 0); >> > + mxsfb_write_register(0x38, 0xdb); >> > + mxsfb_write_register(0x39, 0); >> > + mxsfb_write_reg

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-30 Thread Marek Vasut
Dear Otavio Salvador, [...] > > + mxsfb_write_register(0x36, 0xaf); > > + mxsfb_write_register(0x37, 0); > > + mxsfb_write_register(0x38, 0xdb); > > + mxsfb_write_register(0x39, 0); > > + mxsfb_write_register(0x20, 0); > > + mxsfb_write_register(0x21, 0); > > +

Re: [U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-30 Thread Otavio Salvador
On Tue, Jul 30, 2013 at 6:37 PM, Marek Vasut wrote: > Add STMP3780-based XFi3 board. This board is a small PMP device > sporting a CPU which was later rebranded to i.MX233 . Currently > supported is USB gadget mode and both external SD and internal > Phison SD-NAND bridge . > > Signed-off-by: Mare

[U-Boot] [PATCH 05/11] ARM: mxs: Add Creative ZEN XFi3 board

2013-07-30 Thread Marek Vasut
Add STMP3780-based XFi3 board. This board is a small PMP device sporting a CPU which was later rebranded to i.MX233 . Currently supported is USB gadget mode and both external SD and internal Phison SD-NAND bridge . Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Otavio Salvador Cc: Stefano Bab