Re: [U-Boot] [PATCH 09/11] dma: ti-edma3: Add BIT(x) macro definition

2015-07-04 Thread Jagan Teki
On 4 July 2015 at 18:23, R, Vignesh wrote: > > > On 7/3/2015 7:27 PM, Andy Pont wrote: >> Vignesh wrote... >> >> [snip] >> >>> +#define BIT(x) (1 << (x)) >>> + >> >> Is this not something that would be better in a global header file somewhere >> rather than it

Re: [U-Boot] [PATCH 09/11] dma: ti-edma3: Add BIT(x) macro definition

2015-07-04 Thread R, Vignesh
On 7/3/2015 7:27 PM, Andy Pont wrote: > Vignesh wrote... > > [snip] > >> +#define BIT(x) (1 << (x)) >> + > > Is this not something that would be better in a global header file somewhere > rather than it starting a trend of a per-driver, per-arch, etc. defi

Re: [U-Boot] [PATCH 09/11] dma: ti-edma3: Add BIT(x) macro definition

2015-07-03 Thread Andy Pont
Vignesh wrote... [snip] > +#define BIT(x) (1 << (x)) > + Is this not something that would be better in a global header file somewhere rather than it starting a trend of a per-driver, per-arch, etc. definitions? Andy.

[U-Boot] [PATCH 09/11] dma: ti-edma3: Add BIT(x) macro definition

2015-07-03 Thread Vignesh R
Add BIT(x) macro definition to edma3 driver file. Fixes following compiler warning when CONFIG_TI_EDMA3 is enabled for am437x and dra7x: drivers/dma/ti-edma3.c: In function ‘edma3_set_dest’: drivers/dma/ti-edma3.c:92:10: warning: implicit declaration of function ‘BIT’ [-Wimplicit-function-declarat