Re: [U-Boot] [PATCH 16/17] aspeed: Add AST2500/AST2400 compatible NIC Driver

2017-03-23 Thread Maxim Sloyko
On Wed, Mar 22, 2017 at 6:06 AM, Simon Glass wrote: > Hi Maxim, > > On 21 March 2017 at 17:44, Maxim Sloyko wrote: > > Hi Joe, > > > > Please see responses inline, simply ACK'ed comments will be addressed > > in the next version. > > > > On Tue, Mar 21,

Re: [U-Boot] [PATCH 16/17] aspeed: Add AST2500/AST2400 compatible NIC Driver

2017-03-22 Thread Simon Glass
Hi Maxim, On 21 March 2017 at 17:44, Maxim Sloyko wrote: > Hi Joe, > > Please see responses inline, simply ACK'ed comments will be addressed > in the next version. > > On Tue, Mar 21, 2017 at 12:32 PM, Joe Hershberger > wrote: >> On Thu, Mar 16,

Re: [U-Boot] [PATCH 16/17] aspeed: Add AST2500/AST2400 compatible NIC Driver

2017-03-21 Thread Maxim Sloyko
Hi Joe, Please see responses inline, simply ACK'ed comments will be addressed in the next version. On Tue, Mar 21, 2017 at 12:32 PM, Joe Hershberger wrote: > On Thu, Mar 16, 2017 at 4:36 PM, Maxim Sloyko wrote: >> The device that Aspeed uses is

Re: [U-Boot] [PATCH 16/17] aspeed: Add AST2500/AST2400 compatible NIC Driver

2017-03-21 Thread Joe Hershberger
On Thu, Mar 16, 2017 at 4:36 PM, Maxim Sloyko wrote: > The device that Aspeed uses is basically Faraday FTGMAC100, but with > some differences here and there. Since I don't have access to a properly > implemented FTGMAC100 though, I can't really test it and so I don't > feel

[U-Boot] [PATCH 16/17] aspeed: Add AST2500/AST2400 compatible NIC Driver

2017-03-16 Thread Maxim Sloyko
The device that Aspeed uses is basically Faraday FTGMAC100, but with some differences here and there. Since I don't have access to a properly implemented FTGMAC100 though, I can't really test it and so I don't feel comfortable claiming compatibility, even though I reused a lot of FTGMAC100 driver