[U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory

2015-05-21 Thread Roy Spliet
From: Daniel Kochmański V2: - Rename config option - Move to separate driver - fix DMA directly into RAM - Many readability upgrades - Drop R32 and W32 macros in favour of readl/writel respectively - Use standard port controller methods for pinctl - Make many NAND options semi-configurable Signe

Re: [U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory

2015-05-21 Thread Hans de Goede
Hi, On 21-05-15 15:59, Roy Spliet wrote: From: Daniel Kochmański V2: - Rename config option - Move to separate driver - fix DMA directly into RAM - Many readability upgrades - Drop R32 and W32 macros in favour of readl/writel respectively - Use standard port controller methods for pinctl - Mak

Re: [U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory

2015-05-21 Thread Ian Campbell
On Thu, 2015-05-21 at 20:39 +0200, Hans de Goede wrote: [...] > Please create a struct reflecting the register layout and > then initialize a ptr to this struct from the base-address > and get register addresses this way, this is how we deal > with this in pretty much all other sunxi code, see e.g.

Re: [U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory

2015-05-22 Thread Hans de Goede
Hi, On 21-05-15 21:02, Ian Campbell wrote: On Thu, 2015-05-21 at 20:39 +0200, Hans de Goede wrote: [...] Please create a struct reflecting the register layout and then initialize a ptr to this struct from the base-address and get register addresses this way, this is how we deal with this in pre

Re: [U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory

2015-05-22 Thread Ian Campbell
On Fri, 2015-05-22 at 09:30 +0200, Hans de Goede wrote: > Hi, > > On 21-05-15 21:02, Ian Campbell wrote: > > On Thu, 2015-05-21 at 20:39 +0200, Hans de Goede wrote: > > [...] > >> Please create a struct reflecting the register layout and > >> then initialize a ptr to this struct from the base-addr

Re: [U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory

2015-06-01 Thread Scott Wood
On Thu, 2015-05-21 at 15:59 +0200, Roy Spliet wrote: > +#ifdef CONFIG_NAND_SUNXI > +#include > +#endif Why do you need the ifdef? +#include > +#include > +#include > +#include > + > +/* DMAC */ > +#define DMAC_BASE0x01c02000 > +#define DMAC_REG(a) (DMAC_B

Re: [U-Boot] [PATCH 2/2] nand: sunxi: Add support for booting from internal NAND memory

2015-06-01 Thread Roy Spliet
Dear Scott, Thank you for taking your time to feedback. However, it seems to be about a week and two versions of the patchset too late. Most of your issues have been addressed in the meanwhile, as you can see in Hans de Goede's sunxi branch. Yours, Roy Op 02-06-15 om 00:14 schreef Scott Woo